summaryrefslogtreecommitdiff
path: root/scripting
AgeCommit message (Collapse)AuthorFilesLines
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin1-5/+4
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin2-2/+2
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin2-3/+3
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan2-5/+3
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #3tymyjan3-5/+3
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4 Reviewed-on: https://gerrit.libreoffice.org/23752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01sequence->vector in scriptingNoel Grandin3-26/+23
Change-Id: I5efd5ed8755b6127f08f711b8b7337b87b89bbd4 Reviewed-on: https://gerrit.libreoffice.org/23700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin1-1/+1
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-17loplugin:constantparam in toolsNoel Grandin1-1/+1
Change-Id: I3774661799c074561c694515baba42a375d0a077 Reviewed-on: https://gerrit.libreoffice.org/23301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-14remove some unused Java codeNoel Grandin2-8/+0
found by UCDetector Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df
2016-03-14scripting: JDK 1.5 compatibility: don't use java.awt.Font.MONOSPACEDDouglas Mencken1-1/+1
MONOSPACED is defined in java/awt/Font.java as /* @since 1.6 */ static final String MONOSPACED = "Monospaced"; Change-Id: I31847c939387c139971ff55f786773c7ce51448c Reviewed-on: https://gerrit.libreoffice.org/23164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-09loplugin:constantparam in sfx2Noel Grandin1-1/+1
Change-Id: I50a2d8221f907f0e844e558f3dbdd0346c010201
2016-03-04cid#1326861,1326862: Eq: Problems with implementation of equals()Stephan Bergmann2-27/+1
Cloneable, odd additional equals overloads, odd hasCode implementation---all smells like clueless cargo cult. And I see no place where it would get used. Change-Id: Icca89531ce9181fb47eacfb6fae704f4f45012a9
2016-03-04This ScriptEntry ctor is always called with empty languagedeppropsStephan Bergmann3-10/+4
Change-Id: Ia8ddfecf2f809e9f0132ba59812446973532476c
2016-03-04Scripting.location is unusedStephan Bergmann4-16/+7
Change-Id: Ia534b5aa579a678f8b0273e6c8c12a6ad335c67a
2016-03-04ScriptEntry fields can be finalStephan Bergmann1-6/+6
Change-Id: I7616641584b7ea8192cf3724d8b7d5b88af39da6
2016-03-04Turn forwarding among ScriptEntry ctors around, dropping oneStephan Bergmann1-19/+11
Change-Id: If3c86c7e5c4acaf4a3e48194e24c3c73e4e99499
2016-03-04Remove unusd ScriptEntry ctorStephan Bergmann1-4/+0
Change-Id: I7109877e789659b87cbc16e9c5da39dcc8249e09
2016-03-04Forwarding-only ctor, can be privateStephan Bergmann1-1/+1
Change-Id: I9ed2aa9c2bf2e17705dc711560154a9596c8264a
2016-03-04This ScriptEntry ctor is only needed by ctor of derived class ScriptMetaDataStephan Bergmann1-1/+1
Change-Id: If3e6aae326aa53825edca9d5dc207d185d288cce
2016-03-04Remove unused ScriptEntry.setLogicalNameStephan Bergmann1-4/+0
Change-Id: Iad58e4227433b766bbdce92a53c95aed48320f88
2016-03-04Parcel.getByName apparently wants to return ScriptMetaDataStephan Bergmann3-10/+10
Change-Id: I4a710384ec3a0d719f2ad1fbbe7b43b0be1fa1d9
2016-02-25coverity#1354272 SS: Unread field should be staticCaolán McNamara1-1/+1
Change-Id: Ie9480265be8053805cb48cefe189e65a47ce0908
2016-02-22tdf#98004 Added toolbar to beanshell editor with undo/redo buttonsChirag Manwani3-22/+37
Change-Id: I1d553473f34622e1cb1dab3ffe74ec0c5fa05605 Reviewed-on: https://gerrit.libreoffice.org/22612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-21tdf#97636 Added Undo/Redo functionality to Beanshell EditorChirag Manwani1-1/+66
Change-Id: Ie24f7bb5e59cd78ba2d06a4ed1b6a0bcaf1a3736 Reviewed-on: https://gerrit.libreoffice.org/22500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-18coverity#1326437 Dereference null return valueCaolán McNamara1-1/+1
Change-Id: I9fe5f799b7b47d8dc1fd34893c392fcecef5b5a4
2016-02-18tdf#97637 Fixed Tab size of beanshell editor to 4Chirag Manwani1-0/+1
Change-Id: Ifeb73ab210d9d955e502fab3e3ec993081625945 Reviewed-on: https://gerrit.libreoffice.org/22473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-18tdf#97642 Use native theming for swing controls in Beanshell EditorChirag Manwani1-0/+7
Change-Id: Ifb2f3cfe5132e9b6f7d5d2df5868b09b39c5ec47 Reviewed-on: https://gerrit.libreoffice.org/22429 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-17tdf#97640 Fixed-Width Font for Beanshell EditorChirag Manwani1-0/+1
Change-Id: I809253a4f0481c825368d9c608cac77e64376aa0 Reviewed-on: https://gerrit.libreoffice.org/22404 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-16coverity#1326200 Explicit null dereferencedCaolán McNamara1-0/+1
Change-Id: I39ed18b55657e375b1c22f97c49a0e43aedce4f5
2016-02-16coverity#1326199 Explicit null dereferencedCaolán McNamara1-7/+3
extensionDb is always the same Change-Id: I57b59f09b3f55757844a6aab6c6698857da2e15b
2016-02-09Remove excess newlinesChris Sherlock19-132/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04coverity#1326399 Dereference null return valueCaolán McNamara1-1/+3
Change-Id: I7828cdfcda5d4065fc3dafee744757292753abb5
2016-02-04coverity#1326631 DE: Dropped or ignored exceptionCaolán McNamara1-2/+2
Change-Id: If1f4f46ba51360eff3537f6804286adfe16c4a0e
2016-02-04coverity#1326630 DE: Dropped or ignored exceptionCaolán McNamara1-1/+1
Change-Id: I495c1b5d9d0e03a92330fe6b9371183471aee7bb
2016-02-04coverity#1326629 DE: Dropped or ignored exceptionCaolán McNamara1-2/+3
Change-Id: Ifb82c92eb0eaa019a19deee3dce375204576e2ee
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin3-3/+4
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-18loplugin:unusedfieldsNoel Grandin1-1/+0
Change-Id: I321b594f1190cdd997b4769161e1c02d31f46213 Reviewed-on: https://gerrit.libreoffice.org/21566 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-14loplugin:unusedmethods unused return value in scriptingNoel Grandin2-23/+0
Change-Id: I9b203e255eddce59c37df1a94884e459df034459
2016-01-10Fix typosAndrea Gelmini10-13/+13
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-29cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
2015-12-22loplugin:unusedfields in scriptingNoel Grandin3-32/+17
Change-Id: Ida8fb31bd85f4807d74daab3d022d8e6340a774d
2015-11-26mark UNO structs as SAL_WARN_UNUSED, where possibleNoel Grandin1-3/+0
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-20add mapKeysToSequence/mapValuesToSequence methods to comphelperNoel Grandin1-7/+1
and use them Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec Reviewed-on: https://gerrit.libreoffice.org/20055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-19use comphelper::containerToSequenceNoel Grandin1-8/+1
in chart2, we remove a local equivalent of the method Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-16no need to take a mutex when only dealing with stack-local dataNoel Grandin1-2/+1
Change-Id: Ie45e626aad55a8174a53b769a98601bf54dedf65 Reviewed-on: https://gerrit.libreoffice.org/19979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin1-3/+1
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin1-2/+1
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin2-8/+4
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-13cppcheck: noExplicitConstructorCaolán McNamara1-3/+3
Change-Id: Ife26f55c28c4631aec4ba4105225bfca72da8bff