summaryrefslogtreecommitdiff
path: root/scripting
AgeCommit message (Collapse)AuthorFilesLines
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-2/+2
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin1-3/+0
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin1-14/+15
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin4-58/+19
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-24coverity#1237350 use our double-locking templates for thisCaolán McNamara2-23/+25
Change-Id: I589468e9663ffd01a237a1684345985396bc4eac
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist1-1/+1
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-19scripting: redundant cast to StringRobert Antoni Buj i Gelonch2-5/+5
Change-Id: I5e048964cc7885a32c59ff8a9eb1fc5b9523e843 Reviewed-on: https://gerrit.libreoffice.org/11859 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: when rethrowing exceptions, store the originalNoel Grandin1-14/+20
Change-Id: I8a2a264597d0b1ae06b08136fea36003682380b5
2014-10-17java: final fields that can be staticNoel Grandin1-1/+1
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17java: no need to call String.valueOf to append to a StringNoel Grandin1-4/+2
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin10-74/+88
Change-Id: I14666493e72da177fcfff1895ef3206f0e13cc01
2014-10-16java: always use braces for while loopsNoel Grandin1-1/+2
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-14fix import location of XScriptContextNoel Grandin4-4/+4
Change-Id: I3b0ec540ed37e40f59210b7fb563196aee63d1ea
2014-10-14scripting: replace '.size() == 0' with '.isEmpty()' (collections)Robert Antoni Buj i Gelonch2-2/+2
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/Map.html#isEmpty() http://docs.oracle.com/javase/1.5.0/docs/api/java/util/ArrayList.html#isEmpty() Change-Id: I76d8d8be2794655cb27ab121759494d7084b4744 Reviewed-on: https://gerrit.libreoffice.org/11967 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-14scripting: use new exception constructorsRobert Antoni Buj i Gelonch5-15/+9
Change-Id: I7eeece85d4e462bf2df010ee29c062941a677759 Reviewed-on: https://gerrit.libreoffice.org/11966 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13scripting: Null pointer dereferenceRobert Antoni Buj i Gelonch1-1/+1
Change-Id: I0d72ef34945065f68e9af8b0957dc440a74c14ce Reviewed-on: https://gerrit.libreoffice.org/11923 Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-10Scripting: Remove org packageDavid Ostrovsky201-21407/+0
Change-Id: If0b6ac87b5d53da43557dee5824e9413a260ba7c Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-09typo: Lable -> LabelAndras Timar1-162/+162
Change-Id: I8b9e9f75dd22ee5bff678c5bc0e1fa9381a103de
2014-10-08scripting: as of release 5, 'enum' is a keywordRobert Antoni Buj i Gelonch1-3/+3
Change-Id: Ia45890892f3a0fa89b4c1f97a4c169de5e25c593 Reviewed-on: https://gerrit.libreoffice.org/11860 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-07LocalOffice should be an abstract classNoel Grandin1-11/+7
Change-Id: I9531b64dc8cb2545dfc41ae4d69007eced8f2d26
2014-10-07java: use isEmpty() instead of "size() == 0"Noel Grandin3-6/+5
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
2014-10-07java: use equalsIgnoreCase() instead of toLowerCase().equals()Noel Grandin3-4/+5
Change-Id: I8f4afc7e15a9d85d99ea80edbbbd2b507b254ddc
2014-10-07java: simplify conditions involving logical negationNoel Grandin1-2/+1
Change-Id: Ib45e58273e650ef9a31dbdb5f71e995a5976f50e
2014-10-07java: optimise calls to toArrayNoel Grandin1-4/+2
passing in a correctly sized array requires one less allocation Change-Id: I6198d226d9b630c99c4e8b6e3d0fdf890c495b44
2014-10-07java: remove useless overriding methodsNoel Grandin3-13/+0
that only call their superclass method Change-Id: I9be2f69be132eec7918964f504c50df0ae8401a2
2014-10-06scripting: line break (code formatting)Robert Antoni Buj i Gelonch43-883/+1136
Change-Id: Ib1a8d7e4bdaad2f4eae822d9af280fd5b6f9dd7b Reviewed-on: https://gerrit.libreoffice.org/11794 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-05coverity#1209004 Unchecked return valueNorbert Thiebaud1-1/+1
Change-Id: I8749a5d6f176406e181312d94a1e643974d87617
2014-10-03scripting: organize importsRobert Antoni Buj i Gelonch36-282/+370
Change-Id: I26a1164d44f464a44ed7deb93ac39465feb0541c Reviewed-on: https://gerrit.libreoffice.org/11768 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02scripting: The if statement is redundantRobert Antoni Buj i Gelonch4-18/+6
Change-Id: Ia6186be4ed48fd75d1063eed233a88e09b675bf1 Reviewed-on: https://gerrit.libreoffice.org/11774 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-02scripting: Format_java_code.sh initial runRobert Antoni Buj i Gelonch156-6950/+6399
Conflicts: scripting/java/com/sun/star/script/framework/io/UCBStreamHandler.java Change-Id: I09b94d8c96dfbaf498bd93a0088feb80a9e4afb6
2014-10-01scripting: std::auto_ptr -> std::unique_ptrStephan Bergmann1-1/+1
Change-Id: I91f4a037dfcfbea83cb1ea546ea73880f0480961
2014-09-30scripting: another missing SolarMutex guardMichael Stahl1-0/+2
Change-Id: I762dad4d94ab4f27912b4ddac5b6a77f7d685cb8
2014-09-29fix more Java1.5 incompatibilityNoel Grandin1-2/+6
Change-Id: I9d750f525fe73d59c150b322401418dfbd0822dd
2014-09-26scripting: modify astyle.optionsRobert Antoni Buj i Gelonch1-2/+2
Change-Id: I0e5fb63e2c632890e774b59e6808907067c87ce6 Reviewed-on: https://gerrit.libreoffice.org/11643 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25scripting: astyle-java.conf -> astyle.optionsRobert Antoni Buj i Gelonch3-1/+6
Reviewed on: https://gerrit.libreoffice.org/11639 Change-Id: I0852f9766495379b0208e236b3cbeafde5bf07b3
2014-09-25scripting: Format java code by using astyle toolrbuj2-0/+21
Change-Id: Ifcd90612f22282c16efdbf4d300b8164bf68f760 Reviewed-on: https://gerrit.libreoffice.org/11304 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin8-79/+35
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-24fdo#47302: Added insert->fields->page title buttonJennifer Liebel1-0/+1
Change-Id: Iebc8298a7e6a7d423d2667eec8a46a936cc4d2cd Reviewed-on: https://gerrit.libreoffice.org/11599 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler1-20/+2
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-17Improve loggingStephan Bergmann1-1/+3
Change-Id: I9c879cc16de0d5353a5ab8ce4c8a8cd7f000a170
2014-09-17BRAND_BIN_SUBDIR -> BRAND_INI_DIR, to cater for new Mac OS X layoutStephan Bergmann3-6/+6
Change-Id: Ic367545895a25a4cf6e95fc1be2f5db9f36a221b
2014-09-16ScriptProvider implementations need to be accessibleStephan Bergmann3-3/+3
...from com.sun.star.comp.loader.FactoryHelper. Regression introduced with 70f56bc22fe952c75ec714e05e1bb5296491a36a "java: reduce scope, make member classes private." Change-Id: Iabf41a5eca2df25408e90428c60736b4a73db4c3
2014-09-16scripting: decode(String) in URLDecoder has been deprecatedrbuj1-5/+14
http://docs.oracle.com/javase/1.5.0/docs/api/java/net/URLDecoder.html#decode(java.lang.String) Change-Id: I71ecb498c93d5e8d6959bdc3ab263a5ff48c1c21 Reviewed-on: https://gerrit.libreoffice.org/11453 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-14scripting: Uncaught Exceptionrbuj1-1/+9
Change-Id: I949aa58416dbd80d87c9455009258f7bd2fd8520 Reviewed-on: https://gerrit.libreoffice.org/11439 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-14scripting: replace StringBuffer with StringBuilder methodrbuj8-12/+9
In JDK 1.3, StringBuffer makes the String concatenations faster. public String concat(String s1, String s2) { StringBuffer sb = new StringBuffer(); sb.append(s1); sb.append(s2); return sb.toString(); } JDK 1.5 comes with StringBuilder (which is faster than StringBuffer) and the method: public String concat(String s1, String s2) { return s1 + s2; } is translated to: public String concat(String s1, String s2) { return new StringBuilder().append(s1).append(s2).toString(); } Change-Id: I2924fcdf23d7ffbb567d9e924d02edcab4d21be6 NOTE: StringBuffer is synchronized, StringBuilder is not. Reviewed-on: https://gerrit.libreoffice.org/11436 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-13scripting: encode(String) in URLEncoder has been deprecatedrbuj1-1/+1
http://docs.oracle.com/javase/1.5.0/docs/api/java/net/URLEncoder.html Change-Id: I9d9b40ecf0d76618376975c52e5d9f27ec4bae8e Reviewed-on: https://gerrit.libreoffice.org/11438 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-13scripting: [deprecation] show() in Window has been deprecatedrbuj1-1/+1
Change-Id: I1c157ebbfa0c307fd92c0a2d26e7d530be8ea9da Reviewed-on: https://gerrit.libreoffice.org/11437 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-13scripting: use String.length()==0 instead of String.equals(empty string)rbuj6-7/+7
Change-Id: Icff6a5d19aaf7ac7ebb0cd54140bd388cba0f24d Reviewed-on: https://gerrit.libreoffice.org/11431 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-09-13scripting: use a character literalrbuj7-11/+11
Change-Id: Iabd3514f3c64ff851463cb9b2c1c425164285eb5 Reviewed-on: https://gerrit.libreoffice.org/11430 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-25 10:26:15 +0000