summaryrefslogtreecommitdiff
path: root/scripting/java
AgeCommit message (Collapse)AuthorFilesLines
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-15java: 'final static' to 'static final'Noel Grandin2-5/+5
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin3-4/+4
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-17Fix various XServiceInfo implementationsStephan Bergmann1-2/+4
...to match what is recorded in the .component files Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-02-21Typo: deleteing->deletingJulien Nabet1-2/+2
Change-Id: I2bdde7524a97039c94a8da5ac5d2eba38c91d71a
2015-02-16Make LogUtils.getTrace actually workStephan Bergmann1-25/+6
Change-Id: I59e2b93ed1142bac22ead08cc101e27cfa3e02df
2015-02-16rhbz#1192732: Revert "From the context of the code, this field should...Stephan Bergmann1-1/+1
...not be static." This reverts commit 6d4c1f0d4a623bf7f3b3a0af2ece5c969d5aec77. Whatever made the author of that commit think rhinoWindow shouldn't be static, it clearly needs to be, as in edit()'s Runnable.run(), the usage of rhinoWindow at the end relies on rhinoWindow being set via the new ScriptEditorForJavaScript(context, url) call to initUI() (or else rhinoWindow already being set from a previous such call if already editor != null).
2015-01-23typo: langugage -> languageAndras Timar1-2/+2
Change-Id: Ifabd5a7851946b3e4109e22e6e9a1ff34575c1e5
2015-01-13fdo#88256 fix crash when running javascript macroNoel Grandin5-6/+49
caused by my commit 8583da1e934a49791ef8d86668f3d5c3c5dae1d7 "java: remove unused fields" Change-Id: Ibcd6462e8229a0a6cb98ebfd16ce5d2ea45ca931
2014-12-19java: scripting: fix bug in removing model from mapNoel Grandin1-1/+1
found by PMD Change-Id: I4bd35dd30f6c77aad96932216d8459b812004a88
2014-12-11java: revert part of commit, scripting/ is public APINoel Grandin2-5/+5
revert part of my commit 7557f23b31dcfb4d86c122bb34d9675c0db9a694 "java: reduce visibility of fields and methods" Change-Id: I2049a154b60b165d4d2217495935442d6da66e97
2014-12-11java: reduce visibility of fields and methodsNoel Grandin2-4/+4
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: unused importsNoel Grandin1-1/+0
Change-Id: I05824a6f19a5f3048a52101b96f6bf3d3099df08 Reviewed-on: https://gerrit.libreoffice.org/13403 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-05java: remove some unused local variablesNoel Grandin7-28/+12
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-12-05java: remove some unused fieldsNoel Grandin1-4/+0
Change-Id: I1b6fb6b47439c448ac31983702772e2115c70d56
2014-11-25java: final fields that can be staticNoel Grandin1-1/+1
found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18java: make fields final where possibleNoel Grandin24-54/+52
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12java: convert fields to local variables where possibleNoel Grandin1-3/+0
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin1-14/+15
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-19scripting: redundant cast to StringRobert Antoni Buj i Gelonch2-5/+5
Change-Id: I5e048964cc7885a32c59ff8a9eb1fc5b9523e843 Reviewed-on: https://gerrit.libreoffice.org/11859 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: when rethrowing exceptions, store the originalNoel Grandin1-14/+20
Change-Id: I8a2a264597d0b1ae06b08136fea36003682380b5
2014-10-17java: final fields that can be staticNoel Grandin1-1/+1
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17java: no need to call String.valueOf to append to a StringNoel Grandin1-4/+2
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin10-74/+88
Change-Id: I14666493e72da177fcfff1895ef3206f0e13cc01
2014-10-16java: always use braces for while loopsNoel Grandin1-1/+2
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-14scripting: replace '.size() == 0' with '.isEmpty()' (collections)Robert Antoni Buj i Gelonch2-2/+2
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/Map.html#isEmpty() http://docs.oracle.com/javase/1.5.0/docs/api/java/util/ArrayList.html#isEmpty() Change-Id: I76d8d8be2794655cb27ab121759494d7084b4744 Reviewed-on: https://gerrit.libreoffice.org/11967 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-14scripting: use new exception constructorsRobert Antoni Buj i Gelonch5-15/+9
Change-Id: I7eeece85d4e462bf2df010ee29c062941a677759 Reviewed-on: https://gerrit.libreoffice.org/11966 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13scripting: Null pointer dereferenceRobert Antoni Buj i Gelonch1-1/+1
Change-Id: I0d72ef34945065f68e9af8b0957dc440a74c14ce Reviewed-on: https://gerrit.libreoffice.org/11923 Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-10Scripting: Remove org packageDavid Ostrovsky113-10502/+0
Change-Id: If0b6ac87b5d53da43557dee5824e9413a260ba7c Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-08scripting: as of release 5, 'enum' is a keywordRobert Antoni Buj i Gelonch1-3/+3
Change-Id: Ia45890892f3a0fa89b4c1f97a4c169de5e25c593 Reviewed-on: https://gerrit.libreoffice.org/11860 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-07LocalOffice should be an abstract classNoel Grandin1-11/+7
Change-Id: I9531b64dc8cb2545dfc41ae4d69007eced8f2d26
2014-10-07java: use isEmpty() instead of "size() == 0"Noel Grandin3-6/+5
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
2014-10-07java: use equalsIgnoreCase() instead of toLowerCase().equals()Noel Grandin3-4/+5
Change-Id: I8f4afc7e15a9d85d99ea80edbbbd2b507b254ddc
2014-10-07java: simplify conditions involving logical negationNoel Grandin1-2/+1
Change-Id: Ib45e58273e650ef9a31dbdb5f71e995a5976f50e
2014-10-07java: optimise calls to toArrayNoel Grandin1-4/+2
passing in a correctly sized array requires one less allocation Change-Id: I6198d226d9b630c99c4e8b6e3d0fdf890c495b44
2014-10-07java: remove useless overriding methodsNoel Grandin2-8/+0
that only call their superclass method Change-Id: I9be2f69be132eec7918964f504c50df0ae8401a2
2014-10-06scripting: line break (code formatting)Robert Antoni Buj i Gelonch43-883/+1136
Change-Id: Ib1a8d7e4bdaad2f4eae822d9af280fd5b6f9dd7b Reviewed-on: https://gerrit.libreoffice.org/11794 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-03scripting: organize importsRobert Antoni Buj i Gelonch36-282/+370
Change-Id: I26a1164d44f464a44ed7deb93ac39465feb0541c Reviewed-on: https://gerrit.libreoffice.org/11768 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02scripting: The if statement is redundantRobert Antoni Buj i Gelonch4-18/+6
Change-Id: Ia6186be4ed48fd75d1063eed233a88e09b675bf1 Reviewed-on: https://gerrit.libreoffice.org/11774 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-02scripting: Format_java_code.sh initial runRobert Antoni Buj i Gelonch103-4479/+4049
Conflicts: scripting/java/com/sun/star/script/framework/io/UCBStreamHandler.java Change-Id: I09b94d8c96dfbaf498bd93a0088feb80a9e4afb6
2014-09-29fix more Java1.5 incompatibilityNoel Grandin1-2/+6
Change-Id: I9d750f525fe73d59c150b322401418dfbd0822dd
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin8-79/+35
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-17BRAND_BIN_SUBDIR -> BRAND_INI_DIR, to cater for new Mac OS X layoutStephan Bergmann2-5/+5
Change-Id: Ic367545895a25a4cf6e95fc1be2f5db9f36a221b
2014-09-16ScriptProvider implementations need to be accessibleStephan Bergmann3-3/+3
...from com.sun.star.comp.loader.FactoryHelper. Regression introduced with 70f56bc22fe952c75ec714e05e1bb5296491a36a "java: reduce scope, make member classes private." Change-Id: Iabf41a5eca2df25408e90428c60736b4a73db4c3
2014-09-16scripting: decode(String) in URLDecoder has been deprecatedrbuj1-5/+14
http://docs.oracle.com/javase/1.5.0/docs/api/java/net/URLDecoder.html#decode(java.lang.String) Change-Id: I71ecb498c93d5e8d6959bdc3ab263a5ff48c1c21 Reviewed-on: https://gerrit.libreoffice.org/11453 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-14scripting: Uncaught Exceptionrbuj1-1/+9
Change-Id: I949aa58416dbd80d87c9455009258f7bd2fd8520 Reviewed-on: https://gerrit.libreoffice.org/11439 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-14scripting: replace StringBuffer with StringBuilder methodrbuj8-12/+9
In JDK 1.3, StringBuffer makes the String concatenations faster. public String concat(String s1, String s2) { StringBuffer sb = new StringBuffer(); sb.append(s1); sb.append(s2); return sb.toString(); } JDK 1.5 comes with StringBuilder (which is faster than StringBuffer) and the method: public String concat(String s1, String s2) { return s1 + s2; } is translated to: public String concat(String s1, String s2) { return new StringBuilder().append(s1).append(s2).toString(); } Change-Id: I2924fcdf23d7ffbb567d9e924d02edcab4d21be6 NOTE: StringBuffer is synchronized, StringBuilder is not. Reviewed-on: https://gerrit.libreoffice.org/11436 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-13scripting: encode(String) in URLEncoder has been deprecatedrbuj1-1/+1
http://docs.oracle.com/javase/1.5.0/docs/api/java/net/URLEncoder.html Change-Id: I9d9b40ecf0d76618376975c52e5d9f27ec4bae8e Reviewed-on: https://gerrit.libreoffice.org/11438 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-13scripting: [deprecation] show() in Window has been deprecatedrbuj1-1/+1
Change-Id: I1c157ebbfa0c307fd92c0a2d26e7d530be8ea9da Reviewed-on: https://gerrit.libreoffice.org/11437 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-13scripting: use String.length()==0 instead of String.equals(empty string)rbuj6-7/+7
Change-Id: Icff6a5d19aaf7ac7ebb0cd54140bd388cba0f24d Reviewed-on: https://gerrit.libreoffice.org/11431 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-17 19:15:28 +0000