summaryrefslogtreecommitdiff
path: root/scaddins
AgeCommit message (Collapse)AuthorFilesLines
2015-11-11new loplugin: memoryvarNoel Grandin1-5/+4
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann5-18/+18
Change-Id: Id275f54b08da54c356db052b949d7a1f9154b22c
2015-11-04yyyyyNoel Grandin1-2/+1
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-02cppcheck: noExplicitConstructorCaolán McNamara5-10/+10
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
2015-10-28com::sun::star->css in scaddins,sccomp,scriptingNoel Grandin4-57/+57
Change-Id: Id9167341940bac65f055e1e33ff0670f6fa0f6c4 Reviewed-on: https://gerrit.libreoffice.org/19629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27loplugin:unusedmethodsNoel Grandin1-9/+0
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-19loplugin:defaultparamsStephan Bergmann1-3/+3
Change-Id: I511b95a62f43f9f726fbe5253c7ffc6b510b0346
2015-10-13cppcheck:variableScopeNoel Grandin1-10/+5
Change-Id: I7cbd5a9e9bb5417f754d4e2445df309140fd40af Reviewed-on: https://gerrit.libreoffice.org/19329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann4-178/+178
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-08be consistent with suffixEike Rathke2-8/+8
Change-Id: I40af1526bd8155ad66303f8519c8a6c36a5aa57b
2015-10-08Number(s) makes no sense for one parameter, use Number insteadEike Rathke1-3/+3
Change-Id: Iaf15e4a2b7d29dbdecafcc8089d96c0d6bee6d35
2015-10-08Make clear to user that Calc add-in functions GCD and LCM only exist forWinfried Donkers2-10/+10
interoperability with Excel2003 and before. Follow up of commit 74010f1c502a4bd7eb1ef3ee3d0e8c45a1c9afee Change-Id: I824df2fc50200fc29f7de61881d867f53056edc9 Reviewed-on: https://gerrit.libreoffice.org/19241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-07rename WEEKNUM_ADD to WEEKNUM_EXCEL2003 in UI, tdf#50950 follow-upEike Rathke4-13/+35
... and add description to clarify that it exists for interoperability and for new documents WEEKNUM should be used instead. Also NETWORKDAYS_ADD to NETWORKDAYS_XCL. Change-Id: I01e705d57f0b31983950ac0e47ecb894f657de88
2015-10-02loplugin:unusedmethodsNoel Grandin1-2/+0
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c Reviewed-on: https://gerrit.libreoffice.org/19072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01remove old standalone Sun bug numbersNoel Grandin1-2/+2
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Ia41f4f0ca30ae3346d0720271478ec5bcdab797b Reviewed-on: https://gerrit.libreoffice.org/18967 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-15Resolves: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe3-6/+6
with the variadic variants. Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a Reviewed-on: https://gerrit.libreoffice.org/18580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-13Removed another FuncDataList collectionIan4-86/+41
This time the existing collection used a vector internally and mapped operations onto its standard interface. Removing it in favour of a raw typedef'd vector and find_if reduces the volume of code and simplifies the lookup mechanism. Change-Id: I86fdb85773577019073803c2fc249d04196afe31 Reviewed-on: https://gerrit.libreoffice.org/17680 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-13migrated some raw pointers to unique_ptr'sIan2-26/+14
Change-Id: Ibbe088e73bdf987bf3784b61aa8b38a86d6654e3 Reviewed-on: https://gerrit.libreoffice.org/17679 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-13tdf#90222: Removed ScaList and cleaned up usagesIan2-109/+47
- Removed now-unused ScaList type - Changed ScaFuncDataMap from a map to a vector, using find_if for lookup. Change-Id: Ia22763f221f9a58d85dc363cab2585d7df37877c Reviewed-on: https://gerrit.libreoffice.org/17678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-08-12tdf#90222: Removed ScaList from pricing scaddinIan2-110/+47
Removed the ScaList type. Migrated the ScaFuncDataList to a vector and changed lookup to std::find_if with a functor. This reduces memory use slightly and makes the use of the lookup result a little simpler. Change-Id: I4e5f4d27107512a7c53935f123d5e7e8aca625ee Reviewed-on: https://gerrit.libreoffice.org/17652 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-12tdf#90222: Removed ScaFuncDataList typeIan2-86/+44
This repeats the same change in the pricing addin as already carried out in datefunc. This type was a special case of a custom implemented list, and wasused like a map. I have replaced it with a std::map typedef'd as ScaFuncDataMap. Since the map key also exists in the value object, there are more memory-efficient ways to implement this with a vector and a predicate functor for searching at the cost of some code complexity. I opted for the simpler code afforded by using a std::map implementation. Change-Id: I7d28e0bc58f713cf4f4e962302e09788b3ac4218 Reviewed-on: https://gerrit.libreoffice.org/17651 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-11tdf#90222: Removed ScaFuncDataList typeIan2-89/+47
This type was a special case of a custom implemented list, and was used like a map. I have replaced it with a std::map typedef'd as ScaFuncDataMap. Since the map key also exists in the value object, there are more memory-efficient ways to implement this with a vector and a predicate functor for searching at the cost of some code complexity. I opted for the simpler code afforded by using a std::map implementation. Change-Id: Idd450f4a908ff503cb02e8e363ddbe3512903f47 Reviewed-on: https://gerrit.libreoffice.org/17579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-07tdf#90222: Removed redundant collection typeIan2-51/+7
Removed ScaStringList collection and replaced it with std::vector<OUString> Change-Id: Iba9680454a7a154cc445e2b5c8a436917868b40e Reviewed-on: https://gerrit.libreoffice.org/17573 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-07tdf#90222: Removed ScaStringList and replaced all uses with std::vectorIan2-51/+7
Change-Id: Icd12e4a1557b39fd387173ce261118c27200dd2b Reviewed-on: https://gerrit.libreoffice.org/17543 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21loplugin:unusedmethods reportdesign,scaddinsNoel Grandin3-27/+6
Change-Id: I3e2ccdbc0dd97f276a96eae5c041c09e69cede91 Reviewed-on: https://gerrit.libreoffice.org/17235 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10add a SAL_RAND_REPEATABLE for repeatable random numsCaolán McNamara2-3/+2
merge the formula and comphelper ones together Change-Id: I2e7e2cdb176afc6982e384fa1e007da5b914e6f0
2015-07-04Fix typosAndrea Gelmini1-1/+1
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1 Reviewed-on: https://gerrit.libreoffice.org/16710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-29coverity#1308576 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ic31670bd8999961dc9571c8d55817951a702d417
2015-06-29coverity#1308594 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ic320ba53565ef735d24a3538bf1863b3fb37c97a
2015-06-29coverity#1308584 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I55178c48f57c26f7eec7efa052abd9edbf7adeb0
2015-06-29tdf#39468 Translate German Comments - scaddins/Phillip Sz1-5/+2
Change-Id: I95ea40b1b349f03e8ce45906a50e18f7a95ca5e9 Reviewed-on: https://gerrit.libreoffice.org/16525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-29coverity#1308568 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ic9e4136619d9babe5333f815c9a0268830fbc0d6
2015-06-29coverity#1308597 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ibcbdd39952a573e72edbe1813c9d8b73c5e32f78
2015-06-28coverity#1308546 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ia5b1c50ecff3fde4b698012304cd75fa1a7b4ce6
2015-06-28coverity#1308538 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ib1e110617911ae3e9c13f013f8e807576abb00e6
2015-06-28coverity#1308529 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I8a91a9016e198e7f27d5c0e92789ae458f98f713
2015-06-28coverity#1308518 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I511989f80316eb6791d3418848b1e5c7c4b97a85
2015-06-23Revert "Typo: iff->if"Julien Nabet3-3/+3
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet3-3/+3
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann3-3/+3
Change-Id: Id1b618d9e0bfa69e3d118b6735fd421d0517c3d9
2015-06-02loplugin:loopvartoosmallNoel Grandin3-3/+3
Change-Id: I809e408c994222cfa95ba8f56e4db7bd96be7080
2015-05-05fdo#77985 make calc function NETWORKDAYS comply with ODFF1.2Winfried Donkers1-1/+1
Change-Id: I523b0c71bc0fed501a4d5fffd75c5a4704f6dd13 Reviewed-on: https://gerrit.libreoffice.org/9827 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin4-66/+66
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-06Resolves: #i95167# XIRR() function gives Err:502Regina Henschel1-7/+28
Patch by: Driss Ben Zoubeir <driss.zoubeir@gmail.com> Review by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 85cd072198d9024c20b741c04a20ef99fc9b5910) Conflicts: scaddins/source/analysis/financial.cxx Change-Id: I385d5f9bfa840fe609cb5723f2d4d57d26fd0d6c
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann3-3/+3
Change-Id: I47be8a3e4be0a19fb476ab551e8bf394244a66a4
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann2-4/+4
Change-Id: I156cbb51efe9346af88fb82a648fa09715d299a5
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann1-3/+3
Change-Id: I67b37e64435a038d4ed5d9acdfde668c86859121
2015-03-03Improve previous commit to disambiguate FuncData typesStephan Bergmann5-16/+17
...by making more liberal use of already existing sca::analysis namespace instead. Change-Id: I17355b3aca3a5f415db1de718feba9153012bb2a
2015-03-03Avoid ASan confusion of different FuncData typesStephan Bergmann1-1/+1
...in sc/inc/callform.hxx and scaddins/source/analysis/analysishelper.hxx, where using -fvisiblity-ms-compat for Clang -fsanitize=* on Linux would make both _ZTS8FuncData externally visible and confuse -fsanitize=address. Change-Id: I216665ca8931dbe22a7f9eccd4fa7d73592ef0b5