summaryrefslogtreecommitdiff
path: root/scaddins
AgeCommit message (Collapse)AuthorFilesLines
2016-04-12Avoid reserved identifiersStephan Bergmann2-4/+4
Change-Id: I41a490832c9dd312775f420807e4bed93557a24e
2016-03-24loplugin:constantparam in scNoel Grandin3-9/+7
Change-Id: I8608a6cb47972e9b838cc5ea431863348758ded0
2016-03-02loplugin:unuseddefaultparam in scaddinsNoel Grandin2-5/+3
Change-Id: I47f7ead34832c19d5194c1e4ccf190384262f436
2016-02-09Remove excess newlinesChris Sherlock3-15/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock1-13/+13
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04loplugin:fpcomparison in scaddins/Noel Grandin1-4/+4
Change-Id: I9a303a92f5531d549faf6d86ea0ce6360e115567 Reviewed-on: https://gerrit.libreoffice.org/21865 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-11new loplugin: memoryvarNoel Grandin1-5/+4
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann5-18/+18
Change-Id: Id275f54b08da54c356db052b949d7a1f9154b22c
2015-11-04yyyyyNoel Grandin1-2/+1
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-02cppcheck: noExplicitConstructorCaolán McNamara5-10/+10
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
2015-10-28com::sun::star->css in scaddins,sccomp,scriptingNoel Grandin4-57/+57
Change-Id: Id9167341940bac65f055e1e33ff0670f6fa0f6c4 Reviewed-on: https://gerrit.libreoffice.org/19629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27loplugin:unusedmethodsNoel Grandin1-9/+0
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-19loplugin:defaultparamsStephan Bergmann1-3/+3
Change-Id: I511b95a62f43f9f726fbe5253c7ffc6b510b0346
2015-10-13cppcheck:variableScopeNoel Grandin1-10/+5
Change-Id: I7cbd5a9e9bb5417f754d4e2445df309140fd40af Reviewed-on: https://gerrit.libreoffice.org/19329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann4-178/+178
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-08be consistent with suffixEike Rathke2-8/+8
Change-Id: I40af1526bd8155ad66303f8519c8a6c36a5aa57b
2015-10-08Number(s) makes no sense for one parameter, use Number insteadEike Rathke1-3/+3
Change-Id: Iaf15e4a2b7d29dbdecafcc8089d96c0d6bee6d35
2015-10-08Make clear to user that Calc add-in functions GCD and LCM only exist forWinfried Donkers2-10/+10
interoperability with Excel2003 and before. Follow up of commit 74010f1c502a4bd7eb1ef3ee3d0e8c45a1c9afee Change-Id: I824df2fc50200fc29f7de61881d867f53056edc9 Reviewed-on: https://gerrit.libreoffice.org/19241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-07rename WEEKNUM_ADD to WEEKNUM_EXCEL2003 in UI, tdf#50950 follow-upEike Rathke4-13/+35
... and add description to clarify that it exists for interoperability and for new documents WEEKNUM should be used instead. Also NETWORKDAYS_ADD to NETWORKDAYS_XCL. Change-Id: I01e705d57f0b31983950ac0e47ecb894f657de88
2015-10-02loplugin:unusedmethodsNoel Grandin1-2/+0
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c Reviewed-on: https://gerrit.libreoffice.org/19072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01remove old standalone Sun bug numbersNoel Grandin1-2/+2
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Ia41f4f0ca30ae3346d0720271478ec5bcdab797b Reviewed-on: https://gerrit.libreoffice.org/18967 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-15Resolves: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe3-6/+6
with the variadic variants. Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a Reviewed-on: https://gerrit.libreoffice.org/18580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-13Removed another FuncDataList collectionIan4-86/+41
This time the existing collection used a vector internally and mapped operations onto its standard interface. Removing it in favour of a raw typedef'd vector and find_if reduces the volume of code and simplifies the lookup mechanism. Change-Id: I86fdb85773577019073803c2fc249d04196afe31 Reviewed-on: https://gerrit.libreoffice.org/17680 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-13migrated some raw pointers to unique_ptr'sIan2-26/+14
Change-Id: Ibbe088e73bdf987bf3784b61aa8b38a86d6654e3 Reviewed-on: https://gerrit.libreoffice.org/17679 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-13tdf#90222: Removed ScaList and cleaned up usagesIan2-109/+47
- Removed now-unused ScaList type - Changed ScaFuncDataMap from a map to a vector, using find_if for lookup. Change-Id: Ia22763f221f9a58d85dc363cab2585d7df37877c Reviewed-on: https://gerrit.libreoffice.org/17678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-08-12tdf#90222: Removed ScaList from pricing scaddinIan2-110/+47
Removed the ScaList type. Migrated the ScaFuncDataList to a vector and changed lookup to std::find_if with a functor. This reduces memory use slightly and makes the use of the lookup result a little simpler. Change-Id: I4e5f4d27107512a7c53935f123d5e7e8aca625ee Reviewed-on: https://gerrit.libreoffice.org/17652 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-12tdf#90222: Removed ScaFuncDataList typeIan2-86/+44
This repeats the same change in the pricing addin as already carried out in datefunc. This type was a special case of a custom implemented list, and wasused like a map. I have replaced it with a std::map typedef'd as ScaFuncDataMap. Since the map key also exists in the value object, there are more memory-efficient ways to implement this with a vector and a predicate functor for searching at the cost of some code complexity. I opted for the simpler code afforded by using a std::map implementation. Change-Id: I7d28e0bc58f713cf4f4e962302e09788b3ac4218 Reviewed-on: https://gerrit.libreoffice.org/17651 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-11tdf#90222: Removed ScaFuncDataList typeIan2-89/+47
This type was a special case of a custom implemented list, and was used like a map. I have replaced it with a std::map typedef'd as ScaFuncDataMap. Since the map key also exists in the value object, there are more memory-efficient ways to implement this with a vector and a predicate functor for searching at the cost of some code complexity. I opted for the simpler code afforded by using a std::map implementation. Change-Id: Idd450f4a908ff503cb02e8e363ddbe3512903f47 Reviewed-on: https://gerrit.libreoffice.org/17579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-07tdf#90222: Removed redundant collection typeIan2-51/+7
Removed ScaStringList collection and replaced it with std::vector<OUString> Change-Id: Iba9680454a7a154cc445e2b5c8a436917868b40e Reviewed-on: https://gerrit.libreoffice.org/17573 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-07tdf#90222: Removed ScaStringList and replaced all uses with std::vectorIan2-51/+7
Change-Id: Icd12e4a1557b39fd387173ce261118c27200dd2b Reviewed-on: https://gerrit.libreoffice.org/17543 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21loplugin:unusedmethods reportdesign,scaddinsNoel Grandin3-27/+6
Change-Id: I3e2ccdbc0dd97f276a96eae5c041c09e69cede91 Reviewed-on: https://gerrit.libreoffice.org/17235 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10add a SAL_RAND_REPEATABLE for repeatable random numsCaolán McNamara2-3/+2
merge the formula and comphelper ones together Change-Id: I2e7e2cdb176afc6982e384fa1e007da5b914e6f0
2015-07-04Fix typosAndrea Gelmini1-1/+1
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1 Reviewed-on: https://gerrit.libreoffice.org/16710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-29coverity#1308576 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ic31670bd8999961dc9571c8d55817951a702d417
2015-06-29coverity#1308594 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ic320ba53565ef735d24a3538bf1863b3fb37c97a
2015-06-29coverity#1308584 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I55178c48f57c26f7eec7efa052abd9edbf7adeb0
2015-06-29tdf#39468 Translate German Comments - scaddins/Phillip Sz1-5/+2
Change-Id: I95ea40b1b349f03e8ce45906a50e18f7a95ca5e9 Reviewed-on: https://gerrit.libreoffice.org/16525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-29coverity#1308568 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ic9e4136619d9babe5333f815c9a0268830fbc0d6
2015-06-29coverity#1308597 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ibcbdd39952a573e72edbe1813c9d8b73c5e32f78
2015-06-28coverity#1308546 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ia5b1c50ecff3fde4b698012304cd75fa1a7b4ce6
2015-06-28coverity#1308538 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ib1e110617911ae3e9c13f013f8e807576abb00e6
2015-06-28coverity#1308529 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I8a91a9016e198e7f27d5c0e92789ae458f98f713
2015-06-28coverity#1308518 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I511989f80316eb6791d3418848b1e5c7c4b97a85
2015-06-23Revert "Typo: iff->if"Julien Nabet3-3/+3
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet3-3/+3
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann3-3/+3
Change-Id: Id1b618d9e0bfa69e3d118b6735fd421d0517c3d9
2015-06-02loplugin:loopvartoosmallNoel Grandin3-3/+3
Change-Id: I809e408c994222cfa95ba8f56e4db7bd96be7080
2015-05-05fdo#77985 make calc function NETWORKDAYS comply with ODFF1.2Winfried Donkers1-1/+1
Change-Id: I523b0c71bc0fed501a4d5fffd75c5a4704f6dd13 Reviewed-on: https://gerrit.libreoffice.org/9827 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>