summaryrefslogtreecommitdiff
path: root/scaddins
AgeCommit message (Collapse)AuthorFilesLines
2016-11-16new loplugin finalprotectedNoel Grandin1-1/+1
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in sc..scaddinsNoel Grandin3-11/+11
Change-Id: I4a2d333984827f363ea76580993438d704f9738f Reviewed-on: https://gerrit.libreoffice.org/30660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin3-10/+6
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28loplugin:expandablemethods in scaddins..scriptingNoel Grandin6-22/+4
Change-Id: I6a39184e526c9a41155565e798a7f1f2542985f2 Reviewed-on: https://gerrit.libreoffice.org/30331 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20loplugin:expandablemethodds in scaddins..sdextNoel Grandin2-7/+1
Change-Id: Ife021e368efaafe9097750b4ca1a5472e94352a9 Reviewed-on: https://gerrit.libreoffice.org/30054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05tdf#100496 accept year basis 2 for AMORDEGRC and AMORLINC.Winfried Donkers1-6/+0
Although year basis 2 is not supported by Excel, it is defined in ODFF1.2 for AMORLINC and is supported by Gnumeric. Change-Id: Iacf60dbb7c0502338998f7ff22233c5f8b0b7146 Reviewed-on: https://gerrit.libreoffice.org/29188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann4-4/+4
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (scaddins)Stephan Bergmann1-2/+1
Change-Id: I30a66d2ff5233d6a2a6ec076e188f75a74843cc7
2016-08-18cppcheck: useInitializationListCaolán McNamara1-6/+5
Change-Id: I10b2985f615e1943f56aed086739258c43ede985
2016-08-05no need to check for nullptr before deletingMarkus Mohrhard1-5/+2
Change-Id: I5512ad52c9a0f943b29656e16cceeb08ce164abf Reviewed-on: https://gerrit.libreoffice.org/27888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-05loplugin:countusersofdefaultparams in oox..sdNoel Grandin2-5/+5
Change-Id: I4504939a3957606979c6ac36af6611e1fe072d01 Reviewed-on: https://gerrit.libreoffice.org/27902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-03Resolves: tdf#69539 UI rename CONVERT to CONVERT_OOO, CONVERT_ADD to CONVERTEike Rathke1-1/+1
... with same syntax but different semantics that was even more confusing. Change-Id: Ibe1efcd5c4e82c9ce8d9fe8ed0f85e86dac327f7
2016-08-03UI rename DURATION to PDURATION, DURATION_ADD to DURATION, tdf#50488 relatedEike Rathke1-1/+1
Change-Id: I7ba783b59a711fc9c9d6bbe68dcf8c3c1a0d409d
2016-07-29Make Calc Add-In function RECEIVED behave like Excel and Gnumeric.Winfried Donkers1-1/+1
EXcel and Gnumeric demand that Maturity > Settlement, Calc now does too. Change-Id: Id02918153d5c07f438c9160330b0dc09fdf13f6c Reviewed-on: https://gerrit.libreoffice.org/27619 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-12tdf100766 : ODDLPRICE apply constraints to comply with ODFF1.2Winfried Donkers1-1/+1
Change-Id: I7706a950b904603b6d87306e4a8faa0c4f0cc8d8 Reviewed-on: https://gerrit.libreoffice.org/27006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-12tdf#100729 ODDLYIELD : apply constraints in compliance with ODFF1.2Winfried Donkers1-1/+1
(and Excel). Change-Id: I1cc40494fb2451a06864f770af7c33d26013dcaa Reviewed-on: https://gerrit.libreoffice.org/27002 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-12tdf#100528 follow up; filter nonsense results.Winfried Donkers1-3/+7
With unrealistic depreciation rates (>100%), the caluculated amortisation value can be < 0. Although mathematically correct, financially this is nonsense. The patch returns 0.0 when the calculated amortisation values gets < 0.0. (Excel does the same.) Change-Id: I928bba647429ff6141abfdbd996d4562e31da746 Reviewed-on: https://gerrit.libreoffice.org/26996 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-11tdf#100843 LCM_EXCEL2003 fix incorrect handling of non-integer values.Winfried Donkers1-4/+8
Non-integer values should be truncated as Excel does. Also, make the function return an error with negative values. Change-Id: I6a8ce1fb82d20294d9398ca2af308f88b51d5e82 Reviewed-on: https://gerrit.libreoffice.org/27096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-11tdf#100811 Add extra conversion units to ODFF function CONVERTWinfried Donkers1-3/+9
for full compliance with ODFF1.2. (UI name of function still is CONVERT_ADD.) Change-Id: I6b620c35a5be2bb7195ff0e569dfe6c9cf63ad6d Reviewed-on: https://gerrit.libreoffice.org/27106 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-30Resolves: tdf#100440 check mode to be 0 or 1 for MONTHS(), YEARS() and WEEKS()Eike Rathke1-0/+9
Needed to adapt the WEEKS and YEARS test documents to cope with the change. Change-Id: Ia52505418f4fed684bd04290c608e2a65eee2fbc
2016-06-28tdf#100528 Add constraints for AMORLINC functionWinfried Donkers1-1/+2
Function returned different results than Excel does because of missing constraints. Added constraints are all defined in ODFF1.2 for AMORLINC. Change-Id: Icd5f9de9cf252e6864e3aa9b47346f6f75669c92 Reviewed-on: https://gerrit.libreoffice.org/26572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-28tdf#100523 Add constraints for AMORDEGRC function.Winfried Donkers1-1/+2
Function returned different results than Excel does because of missing constraints. Change-Id: Iea8424a8429e0c48a19fe2818ca4be26c90afd32 Reviewed-on: https://gerrit.libreoffice.org/26571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-10o3tl::tryGet on a temporary is dangerousStephan Bergmann2-5/+5
...so rename to o3tl::tryAccess to make it more obvious that the returned proxy points into the internals of the given Any, and forbid calling o3tl::tryAccess on a temporary Change-Id: Ia412c6b2b06693811b9b7f0076a08bbf97142df9
2016-06-06Use o3tl/any.hxx in scaddinsStephan Bergmann2-7/+10
Change-Id: Ifb19d216a00db90d6a267099077f90e6c54cd942
2016-05-10clang-tidy modernize-loop-convert scaddins to sdextNoel Grandin3-8/+8
Change-Id: I63ccc56df1a1de8bc443abb95e520246c457912f Reviewed-on: https://gerrit.libreoffice.org/24798 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12Avoid reserved identifiersStephan Bergmann2-4/+4
Change-Id: I41a490832c9dd312775f420807e4bed93557a24e
2016-03-24loplugin:constantparam in scNoel Grandin3-9/+7
Change-Id: I8608a6cb47972e9b838cc5ea431863348758ded0
2016-03-02loplugin:unuseddefaultparam in scaddinsNoel Grandin2-5/+3
Change-Id: I47f7ead34832c19d5194c1e4ccf190384262f436
2016-02-09Remove excess newlinesChris Sherlock3-15/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock1-13/+13
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04loplugin:fpcomparison in scaddins/Noel Grandin1-4/+4
Change-Id: I9a303a92f5531d549faf6d86ea0ce6360e115567 Reviewed-on: https://gerrit.libreoffice.org/21865 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-11new loplugin: memoryvarNoel Grandin1-5/+4
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann5-18/+18
Change-Id: Id275f54b08da54c356db052b949d7a1f9154b22c
2015-11-04yyyyyNoel Grandin1-2/+1
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-02cppcheck: noExplicitConstructorCaolán McNamara5-10/+10
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
2015-10-28com::sun::star->css in scaddins,sccomp,scriptingNoel Grandin4-57/+57
Change-Id: Id9167341940bac65f055e1e33ff0670f6fa0f6c4 Reviewed-on: https://gerrit.libreoffice.org/19629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27loplugin:unusedmethodsNoel Grandin1-9/+0
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-19loplugin:defaultparamsStephan Bergmann1-3/+3
Change-Id: I511b95a62f43f9f726fbe5253c7ffc6b510b0346
2015-10-13cppcheck:variableScopeNoel Grandin1-10/+5
Change-Id: I7cbd5a9e9bb5417f754d4e2445df309140fd40af Reviewed-on: https://gerrit.libreoffice.org/19329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann4-178/+178
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-08be consistent with suffixEike Rathke2-8/+8
Change-Id: I40af1526bd8155ad66303f8519c8a6c36a5aa57b
2015-10-08Number(s) makes no sense for one parameter, use Number insteadEike Rathke1-3/+3
Change-Id: Iaf15e4a2b7d29dbdecafcc8089d96c0d6bee6d35
2015-10-08Make clear to user that Calc add-in functions GCD and LCM only exist forWinfried Donkers2-10/+10
interoperability with Excel2003 and before. Follow up of commit 74010f1c502a4bd7eb1ef3ee3d0e8c45a1c9afee Change-Id: I824df2fc50200fc29f7de61881d867f53056edc9 Reviewed-on: https://gerrit.libreoffice.org/19241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-07rename WEEKNUM_ADD to WEEKNUM_EXCEL2003 in UI, tdf#50950 follow-upEike Rathke4-13/+35
... and add description to clarify that it exists for interoperability and for new documents WEEKNUM should be used instead. Also NETWORKDAYS_ADD to NETWORKDAYS_XCL. Change-Id: I01e705d57f0b31983950ac0e47ecb894f657de88
2015-10-02loplugin:unusedmethodsNoel Grandin1-2/+0
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c Reviewed-on: https://gerrit.libreoffice.org/19072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01remove old standalone Sun bug numbersNoel Grandin1-2/+2
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Ia41f4f0ca30ae3346d0720271478ec5bcdab797b Reviewed-on: https://gerrit.libreoffice.org/18967 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-15Resolves: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe3-6/+6
with the variadic variants. Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a Reviewed-on: https://gerrit.libreoffice.org/18580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-13Removed another FuncDataList collectionIan4-86/+41
This time the existing collection used a vector internally and mapped operations onto its standard interface. Removing it in favour of a raw typedef'd vector and find_if reduces the volume of code and simplifies the lookup mechanism. Change-Id: I86fdb85773577019073803c2fc249d04196afe31 Reviewed-on: https://gerrit.libreoffice.org/17680 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 16:02:28 +0000