summaryrefslogtreecommitdiff
path: root/scaddins
AgeCommit message (Collapse)AuthorFilesLines
2017-05-21make string translation loading more uniformCaolán McNamara3-3/+3
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2155e04d6343638ca9815d394cbc4f78c2b17c3a) drop toString Change-Id: I0f67c8931523bbe90bfbc8cc7d9a5bd523758ee5 (cherry picked from commit 8b1101023f01b2c7478a014b5ead73ada4fd4861) pNameResId is unused Change-Id: Ic1fe6abc7066517187695266c4d1a0888b41ffe7 (cherry picked from commit c2667d7ff558a1b7bf83e694909465f00d1a16f6) Reviewed-on: https://gerrit.libreoffice.org/37843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-18loplugin:unusedmethodsNoel Grandin1-2/+0
Change-Id: I1c50d176e793397a1f9625f797a3750cf191a61c Reviewed-on: https://gerrit.libreoffice.org/37679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke3-3/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-06coverity#1405891..1405898: MISSING_COMMAJulien Nabet1-8/+8
Change-Id: I481fd6fedf4df6ecbd1b9ae1651f95278fdb3b80 Reviewed-on: https://gerrit.libreoffice.org/37313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-04tdf#107566 adjust constraints for Add-In function YIELDMAT.Winfried Donkers1-1/+1
Constraints are adjusted to make Calc behave the same as Excel. Constraint for rate is less severe than ODFF1.2, but a rate of 0 is mathematically no problem and Excel allows a rate of 0. Constraint that Settlement date cannot be before Issue date is neither mentioned in ODFF1.2 nor in Excel's help text for YIELDMAT, but is applied by Excel. In reality, a settlement before issue is not possible. Change-Id: I9c19d33abe8518311606fcee1c9dea32438d61a4 Reviewed-on: https://gerrit.libreoffice.org/37206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-02untranslated strings are just stringsCaolán McNamara5-91/+84
removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-28split these out into a standalone headerCaolán McNamara2-606/+632
cut down on the chance they get mangled by a non utf-8 editor Change-Id: I672885c26883275ba57fbfac49a6c761ec00bef1
2017-04-27can move these nonlocalized strings into sourceCaolán McNamara6-1066/+618
if u8 is suported everywhere Change-Id: I0448db49e6f2e5c6cd6806b8da072ba672b6d95a Reviewed-on: https://gerrit.libreoffice.org/37029 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky3-3/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-20loplugin:unusedmethodsNoel Grandin3-3/+2
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04scaddins: silence -Werror=maybe-uninitializedMiklos Vajna1-1/+1
Change-Id: Idbbd6490c954f50d3baa7a72cd89f081d1316e6b
2017-03-25Fix typosAndrea Gelmini2-2/+2
Change-Id: I4e1a613fc99b931e84a1955695364e1d25e25e5c Reviewed-on: https://gerrit.libreoffice.org/35642 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin2-2/+2
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann3-25/+25
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02Fix typosAndrea Gelmini1-1/+1
Change-Id: If5e709c9d6e3a4fbb568bdc261cccd214dd0cbd3 Reviewed-on: https://gerrit.libreoffice.org/34784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-14unwind RID_ANALYSIS_DEFFUNCTION_NAMES local resourceCaolán McNamara3-633/+610
Change-Id: I65ce69460b6c5f73fd41345f55630d0fcf5c04a4
2017-02-14covert ANALYSIS_* resources to StringArraysCaolán McNamara2-3195/+882
Change-Id: Id0aba9531ef179102f62c4f89fa65a244c975570
2017-02-14unwind RID_ANALYSIS_FUNCTION_DESCRIPTIONS local resourceCaolán McNamara3-3326/+3308
Change-Id: Iad53fa9af738873c6d594d60aec1cfdb29e2ea1d
2017-02-14unwind RID_ANALYSIS_FUNCTION_NAMES local resourceCaolán McNamara4-528/+504
Change-Id: Icaab5d3690922748bd473434dbbb1d8cc6eccd2d
2017-02-14convert DATE_FUNCDESC_* resources to StringArraysCaolán McNamara3-157/+54
Change-Id: I13527ba3a53b7a0e913b672a5a87dae4a1556270
2017-02-14convert PRICING_FUNCDESC_* resources to StringArraysCaolán McNamara3-379/+94
Change-Id: If1726a57b427b73269e826b0f719d6b69782611e
2017-02-14unwind RID_DATE_FUNCTION_DESCRIPTIONS local resourceCaolán McNamara4-177/+160
Change-Id: If769264721850397c3c243c976c64c49fddf64fb
2017-02-14unwind RID_PRICING_FUNCTION_DESCRIPTIONS local resourceCaolán McNamara4-389/+371
Change-Id: Ib171e111c330241fb93edf1f2f39933eadc4adea
2017-02-14unwind RID_PRICING_FUNCTION_NAMES local resourceCaolán McNamara4-27/+20
Change-Id: I3da1caed4b6c91acdabe16d98e6d43bf5dc32247
2017-02-14unwind RID_DATE_FUNCTION_NAMES local resourceCaolán McNamara4-30/+39
Change-Id: I1d849238f6dd96986d640bb791f966a29b19525b
2017-02-14unwind RID_DATE_DEFFUNCTION_NAMES local resourceCaolán McNamara4-75/+50
Change-Id: I99ac46b89d2158d420e6458055cdeb5c6421f1ac
2017-02-14unwind RID_PRICING_DEFFUNCTION_NAMES local resourceCaolán McNamara4-46/+22
Change-Id: I9834795ef873e1ffb6cb1abc092a8333f9373e32
2017-02-14don't need to store this dataCaolán McNamara2-6/+1
Change-Id: I797c0fc9cc293b0538392362e2e582e9821da530
2017-02-14don't need to store this dataCaolán McNamara2-3/+1
Change-Id: Ic6d1e061073937b967e289d16a7d2926b5cb733a
2017-02-14don't need to store this dataCaolán McNamara2-3/+1
Change-Id: I7606088fe9e04edddc1918fa8847f927510b1086
2017-02-14replace localresource of strings and keys with StringArrayCaolán McNamara2-34/+15
Change-Id: I09543bf862dce9e0ad2afb626d58f062f552fcba
2017-02-14replace localresource of strings and keys with StringArrayCaolán McNamara2-51/+19
Change-Id: I4bbf5286384905b6201b1a04f161d50f4c9d4aef
2017-02-07remove more STR_FROM_ANSI macroNoel Grandin1-13/+11
Change-Id: I0957d1162c7b5bf8f52c7a79aaced667961d40a3
2017-02-07convert ScaCategory to scoped enumNoel Grandin2-23/+19
and drop unused AddIn constant Change-Id: Ic775e3c956c7200bb04be0a776a688284ba9d19b
2017-02-07remove unnecessary STR_FROM_ANSI macroNoel Grandin1-14/+11
Change-Id: I262158991a83083f999b0ae48da4ed4d77fc57fe
2017-02-07convert ScaCategory to scoped enumNoel Grandin2-27/+23
and drop unused AddIn constant Change-Id: I4422f34db756649cb08aa9aa7f975cef73ccfa91
2017-02-07convert FDCategory to scoped enumNoel Grandin3-130/+124
and drop unused AddIn constant Change-Id: I9cb07d58d7c986973d9713572538ce2142654397
2017-01-26Remove dynamic exception specificationsStephan Bergmann11-528/+486
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25Avoid calling log10(0)Stephan Bergmann1-6/+10
...to avoid UBSan reporting during CppunitTest_sc_addin_functions_test: [...] > Testing file:///data/sbergman/lo-san/core/sc/qa/unit/data/functions/addin/fods/imabs.fods: > warn:xmloff.style:14186:1:xmloff/source/style/xmlstyle.cxx:300: Here is a duplicate Style > scaddins/source/analysis/analysishelper.cxx:949:37: runtime error: value -inf is outside the range of representable values of type 'int' > #0 0x7f77717d11d6 in sca::analysis::ParseDouble(char16_t const*&, double&) scaddins/source/analysis/analysishelper.cxx:949:37 > #1 0x7f77717e39e5 in sca::analysis::Complex::ParseString(rtl::OUString const&, sca::analysis::Complex&) scaddins/source/analysis/analysishelper.cxx:1690:10 > #2 0x7f77717e317f in sca::analysis::Complex::Complex(rtl::OUString const&) scaddins/source/analysis/analysishelper.cxx:1664:10 > #3 0x7f777167fa79 in AnalysisAddIn::getImabs(rtl::OUString const&) scaddins/source/analysis/analysis.cxx:912:19 > #4 0x7f78148bd16a in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 > #5 0x7f78148b6b70 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 > #6 0x7f78148b3894 in bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**) bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:420:13 > #7 0x7f7772bdd096 in stoc_corefl::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) stoc/source/corereflection/criface.cxx:697:9 > #8 0x7f7772bdf45a in non-virtual thunk to stoc_corefl::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) stoc/source/corereflection/criface.cxx > #9 0x7f77d3c63f17 in ScUnoAddInCall::ExecuteCallWithArgs(com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) sc/source/core/tool/addincol.cxx:1466:31 > #10 0x7f77d3c631da in ScUnoAddInCall::ExecuteCall() sc/source/core/tool/addincol.cxx:1444:9 > #11 0x7f77d484504f in ScInterpreter::ScExternal() sc/source/core/tool/interpr4.cxx:2999:19 [...] Change-Id: Ie31d6374bdac3ae11784d925011c5a67802cdf56
2017-01-25loplugin: unnecessary destructor scaddins..sdextNoel Grandin1-1/+0
Change-Id: I6ae02ad25863ec7e0f780020dbc69c9a99488c24 Reviewed-on: https://gerrit.libreoffice.org/33511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, scaddinsStephan Bergmann8-12/+180
Change-Id: I8b78ab7ac34cace1a6aad8807f4964e4414c9ac3
2017-01-10New loplugin:conststringvar: scaddinsStephan Bergmann1-1/+1
Change-Id: I14b74d90fabaa288f412ebb63a10c07de824f0f3
2016-11-16new loplugin finalprotectedNoel Grandin1-1/+1
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in sc..scaddinsNoel Grandin3-11/+11
Change-Id: I4a2d333984827f363ea76580993438d704f9738f Reviewed-on: https://gerrit.libreoffice.org/30660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin3-10/+6
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28loplugin:expandablemethods in scaddins..scriptingNoel Grandin6-22/+4
Change-Id: I6a39184e526c9a41155565e798a7f1f2542985f2 Reviewed-on: https://gerrit.libreoffice.org/30331 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20loplugin:expandablemethodds in scaddins..sdextNoel Grandin2-7/+1
Change-Id: Ife021e368efaafe9097750b4ca1a5472e94352a9 Reviewed-on: https://gerrit.libreoffice.org/30054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05tdf#100496 accept year basis 2 for AMORDEGRC and AMORLINC.Winfried Donkers1-6/+0
Although year basis 2 is not supported by Excel, it is defined in ODFF1.2 for AMORLINC and is supported by Gnumeric. Change-Id: Iacf60dbb7c0502338998f7ff22233c5f8b0b7146 Reviewed-on: https://gerrit.libreoffice.org/29188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann4-4/+4
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (scaddins)Stephan Bergmann1-2/+1
Change-Id: I30a66d2ff5233d6a2a6ec076e188f75a74843cc7
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 11:33:24 +0000