summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2012-11-21fdo#56584: delete also note caption.Markus Mohrhard1-1/+1
Change-Id: I1d792082e79d6bb68004a84c172cc3bb5c194826 Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-21fdo#54898: Test equality by order index (integer) which is more stable.Kohei Yoshida1-3/+3
At the point where std::unique is called, we can use order indices to determine whether the two items are equal. This should be more stable than using CaseInsEqual() to assess equality. Change-Id: I88310fc7beede19fb1c629b9b7e3cb9a069b2b23 Reviewed-on: https://gerrit.libreoffice.org/1013 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2012-11-21remove conditional formats withiout range after import, related fdo#56983Markus Mohrhard3-4/+29
(cherry picked from commit eb240530443b964ea45bf80a5e3711e11a3f09c5) Change-Id: I9a8c02369c3e5a12310a46229bdc1671f75593ad
2012-11-20only set entries for existing sort entries, related fdo#56958Markus Mohrhard1-1/+1
Change-Id: Ib48606402fb90b259f705badeac294d7c336cb9c (cherry picked from commit c45b6496e87fe74570a41821bc5f4fbdb3d3cf8e) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-11-20make sure that the sort vector is large enough, fdo#56958Markus Mohrhard1-0/+3
Change-Id: I7099e984a8b05ccd3324f3b9231c193e716eaf83 (cherry picked from commit cd545dcf511daedd548c11159b8c244f272e9cb6) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-11-20fix for fdo#55875 numbers as text converted strangelyNoel Power1-1/+8
old code used to use XCell->setString, new code uses rDoc.SetString which by default tries to detect number formats. The ScColumn::SetString that eventually gets called seems to do lots of additional checks ( and apparently even if an ScSetStringParam instance with mbDetectNumberFormat ( false ) was passed it seems that it will still try to detect decimal number formats. With that in mind I restore and un-unoified version of what XCell->setString used do Change-Id: Ifaef74c78b198f492a390a3d5dc1721622a01ea4 Reviewed-on: https://gerrit.libreoffice.org/1020 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-20fdo#56776: Change in formula options should cause repaint.Kohei Yoshida1-0/+5
Else Calc would fail to update the column headers due to A1 to R1C1 change (and vise versa). Change-Id: I2c403212f5bc539aea92370e60da96f480549d6d Reviewed-on: https://gerrit.libreoffice.org/1049 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2012-11-20resolved fdo#56278 broadcast deletion to dependent formula cellsEike Rathke1-32/+35
Consolidated changes for fdo#56278 fdo#54074 fdo#53364 fdo#55059 (and earlier i#99844 and i#101869). The replacement cell for the broadcaster to inform listeners, if any, is transferred the broadcaster and owns it, the remembered formula cell never does. When broadcasting the change use the replacement cell instead of the remembered formula cell. Don't fiddle around with ReleaseBroadcaster() at the remembered cell, we don't delete twice and now also don't leak. (cherry picked from commit 8165bfa2afbe828caf37df57b83cb31bef2559cb) Change-Id: Ia11b6d3d751c784af64aaed05f8508887f869a80 Reviewed-on: https://gerrit.libreoffice.org/1069 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-11-07fix ooxml color exportMarkus Mohrhard1-1/+1
Change-Id: I4b94883f594e13e9923bdd05593447a152fa8b0a Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-07export dxfs at the correct placeMarkus Mohrhard1-1/+1
Change-Id: I2ab31904169adad4f173d4655d0511855de77464 Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-07fdo#53531: Time field can be represented with an extended time field type.Kohei Yoshida1-0/+2
And Calc's header footer currently don't distinguish between time and extended time. Time fields in the header / footer are always dynamic and never static. Change-Id: If628d179968c270a63d38cdc3bf6018c01241ac1 Reviewed-on: https://gerrit.libreoffice.org/992 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-07halt corrupted styles with multi-saved xlsx document fdo#55418Noel Power1-1/+4
Change-Id: I2d53c88ab121edeec2bf53f7fd177a0edcc05a25 Reviewed-on: https://gerrit.libreoffice.org/958 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-07fix copy paste error, fdo#55673Markus Mohrhard1-1/+1
Change-Id: I1e31fe05e00ed7e298642da9c0e35ae834dfa74f Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-07only delete cond formats if the correct attributes are passed, fdo#56316Markus Mohrhard1-1/+2
Change-Id: If9859b5021c532daacccfaf386e0489c134e4afb Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-05Correctly handle cell note shifting when immediate row/column is deleted.Kohei Yoshida1-4/+12
Currently, having a note e.g. at D5, and deleting cell D4 and shifting the cells below upward will remove the note at D5. But the correct behavior is to shift that note up to D4. This change fixes it. Change-Id: Ia37f1ce67a003deab424f2b805a2ce333fc10ed4 (cherry picked from commit d3344dd85ee31b195a3709d16e734245e1d0a4b6) Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-05Fix incorrect shifting of cell notes upon cell insertion / deletion.Kohei Yoshida1-2/+8
Steps to reproduce: 1) Insert a comment at D5. 2) Move cursor to C4. 3) Right-click and select Insert. 4) Choose shift cells down. 5) The comment gets shifted down but it shouldn't. The same thing happens when deleting a cell and shifting content. Change-Id: I5a71845cca6abde6b7c940e152e155da26343cef Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-05Remove the correct range, or else maItems would end up with invalid pointer.Kohei Yoshida1-1/+1
nStopPos is non-inclusive, and STL's erase() method also expects a non-inclusive end position (like any other STL methods do). It's wrong to -1 here which would end up not erasing the last element containing a pointer to the deleted cell instance. Change-Id: Ic09ab4a6bb03d0f56bb854a91bf93a99be867116
2012-11-05fdo#56325: Don't forget to build_tree() in fillTable().Kohei Yoshida1-6/+10
Else you'll get the wrong answer in isRowActive(), which always search flag via tree. Change-Id: I3fa92d06f7ba3040eca061d5424afefe362703de Signed-off-by: David Tardon <dtardon@redhat.com>
2012-11-05Merge remote-tracking branch 'origin/libreoffice-3-6-3' into suse-3.6Petr Mladek34-198/+312
Conflicts: desktop/source/app/sofficemain.cxx instsetoo_native/util/openoffice.lst solenv/inc/minor.mk Change-Id: I3e9510067c7173f6c71368e70ba6dfe168c5318e
2012-10-30vba procedures and macro names will result in crash, fdo#55174Markus Mohrhard1-0/+4
Change-Id: I23073ecc56482670d185b39452a7d8b9d6eb38c8
2012-10-30hopefully more successful attempt to solve fdo#50304Noel Power1-5/+17
Change-Id: I86dfff571c14bce97d0851b4093dbc376d8b6ea4
2012-10-22only use non blank cells in the visible data methods, fdo#54552Markus Mohrhard1-3/+7
(cherry picked from commit 40377a6e26aa61a1c0788cad1c97a10911d38da8) Signed-off-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 23e6bac62ef6482c287bb0f55c662ac2047ebb33) Change-Id: I2a0914fbaff3e3f707a9c06f693079aed2b89ba4 Signed-off-by: Petr Mladek <pmladek@suse.cz> Signed-off-by: Eike Rathke <erack@redhat.com>
2012-10-22write the custom sort list info into the item set, fdo#53870Markus Mohrhard2-0/+5
(cherry picked from commit 4302eb0a6c4e28ab675de9d59e73cac345ba30c7) Signed-off-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 07cc274256ebff259e228e7285bc27e6ddc94fdc) Change-Id: I9c7f62b47f83b7798a8efdbf3896503918929f03 Signed-off-by: Petr Mladek <pmladek@suse.cz> Signed-off-by: Eike Rathke <erack@redhat.com>
2012-10-22ignore broadcaster cells to fill autofilter dialog, fdo#55712Markus Mohrhard1-0/+4
(cherry picked from commit 622f7751b78fd8584e34f5fa96a04ed6e8bb98f5) Signed-off-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 637096b75f2989640967e72aee41e48b07a5a602) Change-Id: Iacd3f8cfc26bb147eaf3b6957338be212b448226 Signed-off-by: Petr Mladek <pmladek@suse.cz> Signed-off-by: Eike Rathke <erack@redhat.com>
2012-10-19exchange sort settings between the two tab pages, fdo#53482Noel Power2-10/+10
Change-Id: I540481585bec2479db541025755c2a5a670da9ed Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com> Signed-off-by: Petr Mladek <pmladek@suse.cz>
2012-10-16don't insert notes from deleted cells, fdo#55885Markus Mohrhard1-4/+14
Change-Id: I036f0531dc2290c5eb480258bc70ec13b810e6bc Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com> Signed-off-by: Eike Rathke <erack@redhat.com> Signed-off-by: Noel Power <nopower@novell.com>
2012-10-15Check for null object. The OLE name may not always be set.Kohei Yoshida1-1/+1
(cherry picked from commit fb1d9cc99e026ba9cf15ab49b2251cecfbbf6d10) Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit ea50fe437b4f61e6c97d81721441da2b7d1e2f66) Change-Id: Ib3e55af8870b41a5b76179d2215fc5125ceda5af Signed-off-by: Michael Meeks <michael.meeks@suse.com> Signed-off-by: Eike Rathke <erack@redhat.com>
2012-10-11only access first element if vector is not empty, fdo#55734Markus Mohrhard1-1/+3
Change-Id: I60db486195e7216968dc8c7c7c0c79fb7e8c1b88 Signed-off-by: Noel Power <nopower@suse.com> Signed-off-by: Eike Rathke <erack@redhat.com> Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-10-11kill this hard coded sheet limit for xlsx import, rhbz#864858Markus Mohrhard1-1/+1
(cherry picked from commit 458d68fffa883bc706638299e5a5b2d1399beb0d) Signed-off-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 0eee6469304ba15f42bcafb6707cc98bcbff9112) Change-Id: I49e12d97d1e17b0a63daf374e7ff4b4720129553 Reviewed-on: https://gerrit.libreoffice.org/857 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-10-11fix for fdo#53814 Revert "there should be no need any more for this check"Noel Power1-0/+4
This reverts commit bea018a7040c36e91487b27c7b59c6c8a970bf5f. Change-Id: Id554a8f05b82f146a505ac0a39afe14a3161291c (cherry picked from commit cd9d51a36cc3106d4124855874af657615a93061) Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com> Signed-off-by: Jan Holesovsky <kendy@suse.cz> Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-10-09don't insert the same pointer twice into a ptr_set, fdo#55710Markus Mohrhard1-2/+2
Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>
2012-10-09xlsx fix import/export of column widths fdo#55623Noel Power3-5/+6
column widths were never imported or exported correctly in xlsx. Change-Id: I92d469ce52495fe77281cb22341e9c5127e6b506 (cherry picked from commit 8e753f8446554822d97969b0c18eba6cb9d79e26) Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-10-05workaround broken uno implementatiion with ScRangeListMarkus Mohrhard1-0/+13
Change-Id: Ied665e59ada98c25651be562c4a2fe54ffd1ec6a Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2012-10-04really export default row heights for xlsx fdo#55621Noel Power2-1/+8
Change-Id: Icdf581cd7ae245f2749fecf00957bc9524f717d8 (cherry picked from commit 5a651522acb42fcffa6defc212cb8d0e9b9b7d3f) Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-10-04fdo#54940 - make editing relative refs more intuitive to meMichael Meeks4-3/+20
Change-Id: Id3aa76010d92e71c5dc417fdafba90c3ea8401c8 Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-10-04Revert "really export default row heights for xlsx fdo#55621" wrong branchNoel Power2-8/+1
This reverts commit 6b686a18539b384d032358879bd06d2def280842.
2012-10-04Revert "xlsx fix import/export of column widths fdo#55623" wrong branchNoel Power3-7/+6
This reverts commit f08e1ac6c0998e36359cc08e590ee6e8dfab3599.
2012-10-04xlsx fix import/export of column widths fdo#55623Noel Power3-6/+7
column widths were never imported or exported correctly in xlsx. Change-Id: I92d469ce52495fe77281cb22341e9c5127e6b506
2012-10-04really export default row heights for xlsx fdo#55621Noel Power2-1/+8
Change-Id: I81173507b30fc260043e6c57c123926a17424797
2012-10-03fix parent style import xlsx fdo#55198Noel Power3-6/+29
Change-Id: I77d38eba69ad7aa89b0f9b692e40fd365d002071 (cherry picked from commit 72d3539e26f0485743126301c438bcb05b02643d) Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-10-03misc comment import/export fixesNoel Power1-0/+13
Cherry pick the rest of the commit ... a) fix vmldrawing.vml for xlsx export ( changed from frame to textbox, added support for shadow element with attributes, shadow color, shadow obscured ) b) use proper fillcolor attribute c) detect whether note/comment is shown on import d) export state of note ( shown/hidden ) text position still not perfect, we still are missing some attributes to control that. Change-Id: I59b446175217479ce7960287aa540df8c6b2b1ea Conflicts: oox/source/export/vmlexport.cxx sc/source/filter/xcl97/xcl97rec.cxx
2012-10-02fdo#46278 - misc comment import/export fixesNoel Power2-3/+2
detect whether note/comment is shown on import export state of note ( shown/hidden ) parts of Change-Id: I59b446175217479ce7960287aa540df8c6b2b1e Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2012-10-01auto-expand the first conditional format in the list.Michael Meeks1-0/+2
Change-Id: I65280d39b560b4b7eed3e21a6e6c7b02c124f10a Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-10-01improve conditional formatting height calculations.Michael Meeks1-21/+16
Change-Id: If5080892b820d268ffef22111d0caee217586b56 Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-10-01fetime of mpCondFormat is more complex, fdo#55379Markus Mohrhard2-6/+6
Change-Id: I2b34f9fefdfdfa245ab73f8691090cbde8bcd34e Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2012-10-01fix vell value import from ooxml with array formulas, fdo#54558Markus Mohrhard1-8/+9
Change-Id: I3a7e30940caaaa543a178bba3008db2c6056b4d3 Signed-off-by: Noel Power <noel.power@suse.com>
2012-10-01ooxml spec allow ext ref to non existent entry, fdo#54558Markus Mohrhard1-1/+7
Change-Id: I717917d04a93975472d60248eb61066cd04d1bbe Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2012-10-01vba procedures and macro names will result in crash, fdo#55174Markus Mohrhard1-0/+4
Change-Id: I23073ecc56482670d185b39452a7d8b9d6eb38c8 Signed-off-by: Noel Power <noel.power@suse.com>
2012-09-28xlsx fix cyclic referenced defined names partially fixes bnc#780296 bnc#781166Noel Power3-15/+38
Use scoped_ptr instead of deprecated auto_ptr Change-Id: I8dcae78d6faab29c3889e97185839d41cbc3e402 Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-09-28add TabRatio api and detect macro at group shape fixes bnc#770708Noel Power4-9/+36
Change-Id: I73eb612edaba21aa5bb07577b42bd31f8de2dd2a