summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2017-06-25ne plus faire la détection automatioque une 2e foisprivate/lmamane/for-julien2412Lionel Elie Mamane1-4/+0
et lui faire confiance, i.e. ne plus écraser IBM_850 TODO: vérifier le cas base, où ce ne serait pas une 2e fois et il faudrait encore la faire Change-Id: I401a93dce8ddf100031f1f04872df47ef453eb63
2017-06-25utiliser la détection automatiqueLionel Elie Mamane1-8/+29
Change-Id: I355396794a883e131698d56046b9226095dd8414
2017-06-25détection automatiqueLionel Elie Mamane1-28/+111
Change-Id: Ic6b940b4bd5f3c181b022acffb211b719b99710f
2017-06-24Resolves: tdf#108292 WalkAndMatchElements: really limit the matchEike Rathke1-4/+9
... to the columns queried, not just when entering an mdds node. Otherwise it would return an unexpected index, plus bailing out early spares unnecessary comparisons for the rest of a node block. Regression of commit 3fed166279377f7ad702b8911899243b8adff3bf Date: Fri Aug 16 16:29:38 2013 +0200 that started to use commit 7334f8db6f6004d48e2dbf014f27878a7ae21eb1 Date: Fri Aug 16 16:29:27 2013 +0200 with its bad implementation. Just that VLOOKUP on a matrix with a larger block of same typed data as the query *and* a match in an excess column seems to be rare.. Change-Id: Ia4ef3fd56490de82910d5aa13a84be2de851f9b0 (cherry picked from commit d3b77628efc72d857c63c8fb91d7ed2b499ac860) Reviewed-on: https://gerrit.libreoffice.org/39082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-20Resolves: tdf#104875 defer filter detection to first load/update of externalEike Rathke2-7/+8
This is a combination of 2 commits. This could never have been meant Since commit 67b374980f340faa2695001984aaf98886a32fad executing ScDocumentLoader::GetFilterName() twice if there was no stored filter, and still executing it if there was one, even if the comment says we shouldn't. (cherry picked from commit 1bc793f8ab8f9b4ce435bd3585f9579df4a11819) Resolves: tdf#104875 defer filter detection to first load/update of external Attempting to access all linked external documents right on load time was specifically nasty for non-local URIs (unmounted smb, http, ...) (cherry picked from commit 416752b9e4bc4605c479d3eff7797be9f0ef2a38) f4a7414dfe36875b505c73b8c963b650eeffe204 Change-Id: Iaf4b88e63b3987fb661df0e9b095f06b29076894 Reviewed-on: https://gerrit.libreoffice.org/38820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-15Resolves: tdf#104989 a matrix/array formula cell needs to have dimensionsEike Rathke2-0/+8
This is a combination of 2 commits. Resolves: tdf#104989 a matrix/array formula cell needs to have dimensions Most spreadsheet functions don't need it, but some may. (cherry picked from commit 033d018a3a1d345d61f3c4dc4da693cdd4004dea) Ensure all cases push an error return, tdf#104989 related (not the cause) A formula cell in matrix context could have no dimensions.. (which is the cause but elsewhere). (cherry picked from commit e6abe9c3d06d6776e05bef93b5e6f87b403ea967) 1a04f9808d8f5c802789e3db77052351b24c24c7 Change-Id: I954acaa0a64c4dac8d15acd5b3f404019a7e0bce Reviewed-on: https://gerrit.libreoffice.org/38832 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-12tdf#106423: dbase file can have no recordsJulien Nabet1-1/+2
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=4e3ff19b33c84557fd20e68960499933b4e52638 tdf#84834 sc: stricter type detection for dBASE files Log test file from tdf#84834 still opens in Writer as expected Change-Id: Ibf5a0f586e3a132455d2363e61e5cc7ea249002d Reviewed-on: https://gerrit.libreoffice.org/38660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 57ae8834c8313354477117b65d87c86407f6bf82) Reviewed-on: https://gerrit.libreoffice.org/38692 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-06-03sc::ColRowSpan::mnEnd is inclusiveEike Rathke1-2/+2
Wrong since commit 1e721077b43de84edab2a3ed2f316ddcbec6e3ec Date: Tue Oct 7 00:22:32 2014 +0900 and commit 91502a72c12c559442e8bf77c27a516b49c2a68d Date: Thu Oct 9 14:44:27 2014 +0200 So HasAttribSelection() and HasSelectionMatrixFragment() did not query the rightmost column of each marked range from ScMarkData. Change-Id: Ie3aca26ee1b6c249c1135268dc0ad3ea053ea2b8 (cherry picked from commit 77d1e0c49adea959dd418de9b6cf9901e01be3ae) Reviewed-on: https://gerrit.libreoffice.org/38371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-01Resolves: tdf#108279 dimension rows are 32-bit and don't wrap at 64kEike Rathke1-1/+1
Change-Id: I7bf7a149fb1db526ef62bea2f52b200cf5053cc2 (cherry picked from commit 259c2409310814ae62c8d0aefef19a71e8d88dbe) Reviewed-on: https://gerrit.libreoffice.org/38331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-29tdf#107389: Wrong positioning of AutoFilter buttons in tiledrendering modeTamás Zolnai1-1/+4
Must be a regression from this commit: 9113f17e65b1dafbc178fd269e2967c1e2632f0e Where the offset's and origin's meaning were changed, but not all code path was updated accordingly. Change-Id: Ib519303d5ca5ac7f13e74944e8147ea3220d7684 Reviewed-on: https://gerrit.libreoffice.org/38102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit ba5a9132375bcfedebd7c3d2500006161800da3b) Reviewed-on: https://gerrit.libreoffice.org/38112 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-29import stream on the LibreOffice side, tdf#107827Markus Mohrhard1-3/+13
This adds support for all LibreOffice content providers and non-ascii file names. Change-Id: I0a0fd0ab0c78ef039679516e7a3e880929e8f725 Reviewed-on: https://gerrit.libreoffice.org/37578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 5e9178f765b327a8aba17476d135ba3b1f881bf7) Reviewed-on: https://gerrit.libreoffice.org/37582 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-29use empty document in orcus gnumeric import, tdf#107828Markus Mohrhard3-0/+11
Change-Id: Ia7ee2de6f9b14a132a29c01f8d863889477c0a8d Reviewed-on: https://gerrit.libreoffice.org/37579 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/37659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-29PushError() instead of SetError() so there's a result tokenEike Rathke1-5/+5
Change-Id: I8c2a7e01b04c26e008c8cbea9332f71d47293c75 (cherry picked from commit cd87661b4761ee9f512fc01f95d84f786c97bb66) Reviewed-on: https://gerrit.libreoffice.org/37950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-26tdf#108049 VBA exception avoided in ScVbaRange::setStyleJustin Luth1-1/+2
Change-Id: I5fc928373d70829b6e68d9000140a30f04179536 Reviewed-on: https://gerrit.libreoffice.org/37981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 4dc3e7d5e9044be66177e467d739bd8be7556783) Reviewed-on: https://gerrit.libreoffice.org/38063 (cherry picked from commit bb9c240046955c432d963610d5dd99edcc6b43e6) Reviewed-on: https://gerrit.libreoffice.org/38083 Tested-by: Justin Luth <justin_luth@sil.org>
2017-05-26tdf#108017 xlsb import: protection settings were reversedJustin Luth3-26/+41
Back in LO4.3, commit 5728a56b20e01d6c9e86a23f20af64a1b68ad604 fdo#70499 selectn of lock/unlocked cells with worksheet protection reversed ...reversed finalizeImport's understanding of maSheetProt.* to match xml import, but then it no longer matched the binary stream import. So, .xlsb imported the opposite of what .xlsx/.xlsm imported. Reviewed-on: https://gerrit.libreoffice.org/37952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 0d3fcbf809852aab0d0f88272bbfd2e8507d1c5e) Reviewed-on: https://gerrit.libreoffice.org/38041 Change-Id: I2da3967ef52187e4ef36ce7d01b17a4672f61e1c Reviewed-on: https://gerrit.libreoffice.org/38052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-18tdf#107920: Crash when using ScCompiler in condformatJulien Nabet1-0/+2
Just call SetGrammar from ScCompiler object with grammar of document See bt in https://bugs.documentfoundation.org/attachment.cgi?id=133382 Change-Id: Iedf4b88f2821bbcf728e4b1c023041fd6f10e5f3 Reviewed-on: https://gerrit.libreoffice.org/37739 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 63843a97262ccfa38d838a9cbbc3faadba8290a6) Reviewed-on: https://gerrit.libreoffice.org/37756 Tested-by: Eike Rathke <erack@redhat.com>
2017-05-17tdf#107892: fix negative values case with maxifsJulien Nabet2-2/+2
std::numeric_limits<double>::min() returns positive value for float/double so use std::numeric_limits<double>::lowest() (see http://stackoverflow.com/questions/17070351/why-does-numeric-limitsmin-return-a-negative-value-for-int-but-positive-values) Change-Id: I0afce2d38c6936aeff26923182bcafd2f0008d9e Reviewed-on: https://gerrit.libreoffice.org/37693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 20d3a60b41bda2513723c145d919f584840b1056) Reviewed-on: https://gerrit.libreoffice.org/37730
2017-05-15tdf#82326 calc 32bits unable to open files with a lot of cond formattingfrederic vroman1-2/+2
The code to build and compute formulas is using an fixed size array. The size of this array has been changed from 512 to 8192 by commit 9c1ca6dca3b553c302a635357e33591605343b99 Since then, LO consumes a LOT of memory while opening scalc files which are making extensive use of conditional formatting. This is a silent issue when working with a 64bits versions of LO because the memory is immediately released at the end of the load phase. However, with 32bits versions, some files can not be opened anymore as it can consume the full process memory space (2GB on windows). The parser is creating ScCondtionEntry objects to store conditional formatting expressions which are immediately compiled in the constructor. However the compile method did not return a flattened token array. Change-Id: Id290bc1f5838c246d4c2322b297b13307defaf88 Reviewed-on: https://gerrit.libreoffice.org/37527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit f566e2d579f5385b01d9b124e7055721313325c9) Reviewed-on: https://gerrit.libreoffice.org/37644
2017-05-12tdf#106051 Notify listeners on top and bottom of split formula groupArul Michael1-0/+6
Change-Id: Icecb59a476f57cee0c04c3e21d60e6c7fa12f65a Reviewed-on: https://gerrit.libreoffice.org/37011 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c882c60f54cc90740a674eed8c47bde0e9959652) Reviewed-on: https://gerrit.libreoffice.org/37543
2017-05-12tdf#93171 Subtotal function with function indexes don't updateArul Michael3-0/+15
Calling InerpretTail during Hide rows by SfxHintId::ScDataChanged broadcast Reviewed-on: https://gerrit.libreoffice.org/37509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 970b431f1a7b6b96c4c9536657ce4fe9d8f5b585) Backported. Conflicts: sc/inc/column.hxx Change-Id: Ie78170bb6d49933a49d828a18637cb410796dc06 Reviewed-on: https://gerrit.libreoffice.org/37522 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-11tdf#107572: retrieve Default autoformatJulien Nabet1-0/+2
by fixing DefaultFirstEntry comparison operator. From http://www.cplusplus.com/reference/map/map/key_comp/: "... Two keys are considered equivalent if key_comp returns false reflexively (i.e., no matter the order in which the keys are passed as arguments). ..." Certainly regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=652158c3f2c9cd0d6f71ecd14bf5d5cc02a71b50 author Julien Nabet <serval2412@yahoo.fr> 2015-09-15 19:41:48 (GMT) committer Julien Nabet <serval2412@yahoo.fr> 2015-09-30 12:11:35 (GMT) commit 652158c3f2c9cd0d6f71ecd14bf5d5cc02a71b50 (patch) tree 13ad29a110565f24e7010a68d902cadf1c441b62 parent 8727afe771a3e4d585e98ca9cceff2504e500bb0 (diff) tdf#94173: Calc doesn't save your own created autoformat presets This new patch has also been tested for tdf#94173 Change-Id: I60de5fffe39be9b3615c32a317611812b42bafc7 (cherry picked from commit 965494c544dd8f35ae83b7cf38549009da06c367) Reviewed-on: https://gerrit.libreoffice.org/37487 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-11tdf#86001: Pass on the language info from the cell to the engine.Kohei Yoshida2-6/+25
So that it can be used to set the correct language to use to check spelling (or disable it altogether). Reviewed-on: https://gerrit.libreoffice.org/37307 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit eb35ead64b1371ea27420b57387ff1db0cbbbcf6) Conflicts: sc/source/ui/view/gridwin.cxx Change-Id: I4fddd9a7e08ab55476566db98476794b2fc1eb13 Reviewed-on: https://gerrit.libreoffice.org/37308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-02Resolves: tdf#99625 add parameter classification for TEXTJOIN and CONCATEike Rathke1-0/+2
So in array context the functions return a single string instead of an array of identical strings. Change-Id: Ia6ada10be4912745b60e281fac1736c560162d3a (cherry picked from commit f0fef88b747cc4f4de7a5ccb93da9c062545dcfb) Reviewed-on: https://gerrit.libreoffice.org/36742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-04-27Resolves: tdf#107241 don't let floating function description grow infinitelyCaolán McNamara1-0/+1
Change-Id: Ief87c15c637d725d25416b64739fb3f5f07cded4 (cherry picked from commit e33447a24c6800bbd34ea1463ee823737bf555cd) Reviewed-on: https://gerrit.libreoffice.org/37036 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-27Resolves: tdf#102525 handle array/matrix formula in cycle cell reference typesEike Rathke1-1/+11
(cherry picked from commit 6c73ca4671958cb066beecade5661e124c497e25) Conflicts: sc/source/ui/view/viewfun4.cxx keep the leading '=' equal character, tdf#102525 follow-up So to feed it to the compiler again in case it's a "==" force-always formula, which theoretically would also be valid in matrix mode. (cherry picked from commit c15f497b9a3463c7eeca1e8cc2c6f46ca293b9af) e694e12a3bc4581469b7ad9cc06a23333a664d6f Change-Id: Ib2443d5bda0c9b1268835f08e4931d5dec2d7f1b Reviewed-on: https://gerrit.libreoffice.org/36669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27mark all new styles as default styles, tdf#103380, tdf#103330Markus Mohrhard4-0/+18
Change-Id: I0b893d61ea6c9d0fd4af9f08b0d3b2e5454e544e Reviewed-on: https://gerrit.libreoffice.org/36827 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-25tdf#107310: hybrid cell is a value cell as well as a string cell.Kohei Yoshida1-0/+3
Else it would cause a legitimate calculation to fail with #VALUE!. Change-Id: If8d4f40859d0c87b97afc952e4a3e4268450c40c Reviewed-on: https://gerrit.libreoffice.org/36817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 7c80ea40fab3cb8e8893d14e80e7bb7f63f0dbb0) Reviewed-on: https://gerrit.libreoffice.org/36917 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-20Resolves: tdf#106838 icon set not visible in conditional formattingCaolán McNamara3-11/+27
Change-Id: Ibafaa487d39a69bc7c5c150361368614c0d9e004 (cherry picked from commit 1c2dd8dc14effe739bd826cf4fe77145d5b751bc) Reviewed-on: https://gerrit.libreoffice.org/35899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-19call UpdateReference also for single cell copying, tdf#105245Markus Mohrhard1-0/+9
This is a combination of 2 commits. call UpdateReference also for single cell copying, tdf#105245 Reviewed-on: https://gerrit.libreoffice.org/36393 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit cb57a432ba98ffe197c8fd2528e4b363c3285cc4) only handling copy&paste needed, cut&paste bailed out, tdf#105245 follow-up (cherry picked from commit 840ac578dc5c21731b927bad6113839c4c69c108) 946d9f09e7571d347111ad66326ab375d153e298 Change-Id: I5fed22d2835466cbd07f8dbd917e9f881b7b2832 Reviewed-on: https://gerrit.libreoffice.org/36557 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-18tdf#92650: handle overwritten references correctly in undo.Kohei Yoshida3-2/+12
(cherry picked from commit de39b6ba3a9edd20a476937ef0c78920df2f5c6d) Conflicts: sc/source/ui/docshell/docfunc.cxx Change-Id: Idc3fbd78f8163c97a9cd80a3ff474b6da0349353 Reviewed-on: https://gerrit.libreoffice.org/36539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-18actually show the newly selected cell, tdf#106194Markus Mohrhard1-0/+1
Change-Id: I0c9f839cbe55f2670602567e61dc4aba77fbef61 Reviewed-on: https://gerrit.libreoffice.org/36303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit dbc616c0021b86e6365930ba581818fea280d1a8) Reviewed-on: https://gerrit.libreoffice.org/36386 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-12don't replace content of formula field when selecting range, tdf#58635Markus Mohrhard1-1/+4
Change-Id: I85953fdd7c2b7f193b2a815564526d985ae2bba4 Reviewed-on: https://gerrit.libreoffice.org/36309 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 42aece949ec96c775b31216bddd723aa5321e966) Reviewed-on: https://gerrit.libreoffice.org/36310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-04-11out-of-bounds tab access when deleting second last sheetEike Rathke1-2/+2
Which in a debug build lead to STL assert Error: attempt to subscript container with out-of-bounds index Change-Id: I09fddbc9e4b214b0313c193f85830ed458d20c0e (cherry picked from commit 0c55972d747511dbc711f3c9cbb4db5d8c5dc2ff) Reviewed-on: https://gerrit.libreoffice.org/36274 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-10tdf#106253 Precision as shown for thousand dividorLaurent Balland-Poirier1-0/+6
Info().nThousand contains number of thousands dividors after which digits are not displayed, i.e. 12345 is displayed as 12 with format 0, (in en_US) Change-Id: Ifa5540f2efd8ab006a07eade53f7aa0d31a19eac Reviewed-on: https://gerrit.libreoffice.org/35097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 60d7644a46970e6eaee882e0c5d65692da206c24) Reviewed-on: https://gerrit.libreoffice.org/35204
2017-04-10tdf#106252 Engineering notation for Precision as shownLaurent Balland-Poirier2-29/+96
with more tests Reviewed-on: https://gerrit.libreoffice.org/35089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5f2db66ad0de6fbbae309850516e17eaa17934cb) Change-Id: Ifc77b847af4eaaa3c85e904e46c2663b6d768241 Reviewed-on: https://gerrit.libreoffice.org/36369 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-10Tests for "Precision as shown" following tdf#105657 tdf#106052Laurent Balland-Poirier2-0/+107
I was unabled to add these test svl/qa/unit/svl.cxx because they required ScDocument::RoundValueAsShown() Found that other formats are not supported by "Precision as shown" option: - engineering tdf#106252 - thousand tdf#106253 Change-Id: Iaf98c404cabec0f5c69f94f2bf863351487fe9d7 Reviewed-on: https://gerrit.libreoffice.org/34750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 7496f7d3cae8a932dc43ede8a30a99289366a264) Reviewed-on: https://gerrit.libreoffice.org/36368
2017-04-10tdf#106052 Treat SubFormat for "Precision as shown"Laurent Balland-Poirier1-1/+1
Get precision from the correct subformat Change-Id: I458e5b3d1fb515864f19499ac9ac529e1d68a267 Reviewed-on: https://gerrit.libreoffice.org/34505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e7f769bc67d3f132b477b3c253f8065243b9b8ac) Reviewed-on: https://gerrit.libreoffice.org/36367
2017-04-10don't obtain the underlying SvNumberformat thrice, tdf#105657 follow-upEike Rathke1-4/+6
... which all GetFormatTable()->...(nFormat) do. Also introduce SvNumberformat::GetMaskedType() for convenience. Change-Id: I9495d71b99116e74e8b877ffc9cd21bd36cc7b7f (cherry picked from commit 820cb1f86f3fd177877b8719315fc03534e2049c) Reviewed-on: https://gerrit.libreoffice.org/36366 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-10tdf#105657 Treat "Precision as shown" for fractionsLaurent Balland-Poirier1-0/+4
For Option "Precision as shown", fraction must specificly be treated ImpGetFractionElements retrieves values of each part of fraction (integer, numerator, denominator) independently from its exact representation Update: avoid include of zformat.hxx in document4.cxx Change-Id: Ia3ea2322f3d311c04ef71f3260730c7154c3dc15 Reviewed-on: https://gerrit.libreoffice.org/34331 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5706b29974c1c3ab0ba5a23685accf2fbebc3e06) Reviewed-on: https://gerrit.libreoffice.org/36365 Tested-by: Jenkins <ci@libreoffice.org>
2017-04-07Resolves: tdf#100011 (re-)add ocCeil and ocFloor .xls(x) export mappingsEike Rathke2-2/+7
This is a combination of 2 commits. Resolves: tdf#100011 (re-)add ocCeil and ocFloor .xls(x) export mappings ... for CEILING and FLOOR that were lost when introducing CEILING.MATH and FLOOR.MATH which are semantically identical, but the export needs a distinct known mapping otherwise the function is stored as a macro call, which Excel dislikes. (cherry picked from commit ea01a08763e56a7de66f0c24655a627669c8a7f7) these FUNCFLAG_EXPORTONLY need also FUNCFLAG_MACROCALL_NEW, tdf#100011 related Maybe one day we'll actually use these tables also for export capabilities ... (cherry picked from commit 4dd95cadcd330aee49b3c84d3e336b808217af46) f3d55ec008e321d95b21e0d284c7d58d13a2399b Change-Id: Id371c1732984a8e5567f74fd265b9aee88fb1898 Reviewed-on: https://gerrit.libreoffice.org/36233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-06tdf#105908: restore previously deleted range references upon undo.Kohei Yoshida5-2/+49
Change-Id: If1932a5eb10da4c50fbcc3329af75f2e7a0a5137 Reviewed-on: https://gerrit.libreoffice.org/35607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 749405af4fc38e0c16dc7e860d23a13dfceb4e40) Reviewed-on: https://gerrit.libreoffice.org/35672 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-06tdf#106868: fix crash when modify external linkNoel Grandin6-64/+57
The EndDialog callback Hdl was disposing the Dialog, which is a little troublesome since the stack wants to go back through the Dialog code when the callback is done. Rather just the more normal synchronous Execute() style of Dialog execute, instead of the asynchronous StartExecuteModal. Change-Id: I14933bd475da228c9648a6fa0564bda4a60d9d12 Reviewed-on: https://gerrit.libreoffice.org/36074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit cedbc4031f26ea13b188a4ecc5b90cc9646095fb) Reviewed-on: https://gerrit.libreoffice.org/36179
2017-03-30handle date autofilter entries correctly, tdf#106214Markus Mohrhard4-26/+35
Change-Id: I8fd2896c8998e79794a0ccaae1c2442caf8b89ac Reviewed-on: https://gerrit.libreoffice.org/35730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit b3d498755238cb0d9a7a3e33b6070c1e4c0e3482) Reviewed-on: https://gerrit.libreoffice.org/35733 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-23tdf#106047 Fix case-insensitive search in autofilterVitaliy Anderson1-4/+4
Change-Id: I67899789b0a51a3a04c2085cbab8c0ed62903413 (cherry picked from commit b0240bf12a94e71d1e2ebe3922afc1a3de5cd933) Reviewed-on: https://gerrit.libreoffice.org/35544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-22tdf#104383: prevent crash during file load.Kohei Yoshida1-2/+14
Apparently xView may be null sometimes. Change-Id: Icef81159eeaf5c9bdb0a91e036019b820952d20b (cherry picked from commit 273d7cec114ace96c5d891fdb24ddc36be3a2376) Reviewed-on: https://gerrit.libreoffice.org/35520 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-17the range should be updated after the references, tdf#104026Markus Mohrhard1-3/+3
Change-Id: I2cb674b8b3bc64df031b473b337d266a2eaab43d Reviewed-on: https://gerrit.libreoffice.org/35289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 3f0f35c89f3f64fcb110483fd562a59f729dc344) Reviewed-on: https://gerrit.libreoffice.org/35297 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-03-17Resolves: tdf#102777 broadcast SC_TAB_INSERTED when inserting scenarioEike Rathke1-0/+3
So ScViewData::maTabData gets an entry added which deleting the scenario can remove again. (cherry picked from commit 4c8059a3e140171399ac85ceb882d23bb458599d) Change-Id: I166baeff5408ef67faef41364515a13b8d4610bb Reviewed-on: https://gerrit.libreoffice.org/34942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-03-14don't forget to set the managed flag, tdf#105544Markus Mohrhard1-0/+1
Change-Id: I46d534a157b05ce22ba42e269ca8266e3403ecd2 Reviewed-on: https://gerrit.libreoffice.org/34229 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 0b9e33cceb635cd3c173bd1f461af98cfd6f6ed2) Reviewed-on: https://gerrit.libreoffice.org/35182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-03-14fix conditional format import from XLSB, tdf#105486Markus Mohrhard1-1/+3
Change-Id: I2b781f45221e434c8ec0ee079afb54c505faf2b5 Reviewed-on: https://gerrit.libreoffice.org/34396 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit aaea9beabcdfa16ffd36116591c5ebea25906b94) Reviewed-on: https://gerrit.libreoffice.org/35154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-14tdf#106456, don't try to use invalid ranges in external ref codeMarkus Mohrhard1-0/+6
Change-Id: I38e622df87dd4b5e37dd248c5181978e13890fda Reviewed-on: https://gerrit.libreoffice.org/35132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 951fcc6556346e19a028443c70dea27d0cbc9c36) Reviewed-on: https://gerrit.libreoffice.org/35180 Reviewed-by: Eike Rathke <erack@redhat.com>