summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2014-03-18sfx2: sal_Bool->boolNoel Grandin7-11/+11
Change-Id: I375a72c34e46778385a9fdc24c9ebd0f0a3f3c9b
2014-03-18sfx2: sal_Bool->boolNoel Grandin6-72/+72
Change-Id: I87c5a180566e9da185c2992844e6522e82c17747
2014-03-18sfx2: sal_Bool->boolNoel Grandin2-9/+9
Change-Id: I733cd63e321bdc775739228c269fa66ff7780780
2014-03-17fdo#76140: Reimplement XIRR OpenCL test.Kohei Yoshida3-14/+13
1) Use ods format and store the expected formula results as numeric cells, to avoid having to load the same file twice (which is slower). 2) Use rtl::math::approxEqual to evaluate two numbers that may be subject to numerical instability especially when the expected values are very small. Change-Id: Ie08e91f797065f4593f996df3541da84019cc53c
2014-03-17fdo#76181 - cleanup OUString constructorsManas Joshi1-113/+80
Change-Id: I0a5fbfc0b33b16e0eba7410957ab83ffbff4e008
2014-03-17justify range to prevent negative tab span and memory alloc, rhbz#1057741Eike Rathke1-0/+1
I could not reproduce the crash of that bug (probably having more memory available), but the backtrace had nTabSpan = -2 implicitly casted to size_t leading to allocation of a huge amount of memory with vector::reserve(), which ScRange::Justify() exactly prevents. Change-Id: Idb79e1be62649922ba793cab01e00011479fade9
2014-03-17sc: prefer passing OUString by referenceNoel Grandin38-111/+108
Change-Id: I85e8823e872bf53182ce90576225e462edb1930a
2014-03-16sal_Bool to boolMatteo Casalin2-2/+2
Change-Id: Ib19ecab287396dc6d6cf4a77dcf7072c5c4c84f8
2014-03-15coverity#705829 Dereference before null checkCaolán McNamara1-1/+9
Change-Id: Ic624b6bab3215148ff0b9a73fd24577623b398f9
2014-03-15coverity#705838 Dereference before null checkCaolán McNamara1-1/+1
Change-Id: I9a18699554bb0831478e5ca177e87ae11a6206cf
2014-03-15coverity#735797 Explicit null dereferencedCaolán McNamara1-0/+3
Change-Id: I67345e7eaae16baf677e9aad721d39b4ea0c43d1
2014-03-15Use listener's listening range when re-activating area listeners.Kohei Yoshida3-17/+32
Otherwise listeners may end up listening to larger areas than their original listening areas after the relocation. Change-Id: I12a7f49aec1c78611db5c31ba2d18574e91a5416
2014-03-15Unregister all listeners first then re-register them.Kohei Yoshida3-56/+134
It's safe this way in case we are transferring them within the same column. Any empty broadcasters are checked and purged at the end. Change-Id: Ib2d46e616cde4923720ad21cb101d3a97dc8c5d9
2014-03-15The test is incorrect.Kohei Yoshida1-1/+1
Change-Id: I4e4b788f34e01f926d60d97515de4191d7346d5e
2014-03-15We should broadcast on reference move only when undoing move, not copy.Kohei Yoshida1-7/+10
Change-Id: I8b60969312fd262ee8cd996c861e4d69f9ea3372
2014-03-15fdo#71491: Adjust reference during undo of drag-n-drop of cell range.Kohei Yoshida28-19/+451
Also with this commit, the signature of SvtListener::Notify() changes, by dropping the first argument which nobody uses. This change was necessary in order to call it directly without needing to pass any broadcaster instance. Change-Id: I6a1e97f0fb1e070d1d8f7db614690b04c9e8024e
2014-03-15fdo#71491: Write test for this.Kohei Yoshida2-0/+118
Change-Id: I20de3d5c3c254b2ce96678553d91492dc95e2c39
2014-03-14some formula interpreter options are document specificEike Rathke14-16/+73
Ideally they'd even be stored as document options. Future work? Change-Id: Ida126a441ca88c35406fb66ea3722d6335e6e8e2
2014-03-14Related: rhbz#1076264 intermittent a11y crash in calcCaolán McNamara1-34/+53
http://retrace.fedoraproject.org/faf/reports/338291/ this crash refuses to be captured alive. But seeing as we sometimes check mpViewShell against NULL and sometimes check GetViewData against NULL its worth making those checks everytime for consistency see also... rhbz#923993 rhbz#896711 rhbz#602273 rhbz#577595 lp#811057 lp#760665 Change-Id: I5553848018f500b63ade60bcfc756a736b27c64f
2014-03-14recalc for interpreter options changesEike Rathke1-0/+4
Change-Id: I6a6d0ba558d0aae075e2a00f76ce96990af882d3
2014-03-14fdo#72741 - write unit test for in formula group swapping.Michael Meeks2-6/+71
Change-Id: I9da62b026b40b08784415e0421556946646d25e2
2014-03-14fdo#72741 - swap values only inside a formula group.Michael Meeks3-14/+62
Speeds up sorting large ranges containing formula groups by a computational order or two: can sort 1 million rows of =A1 in sub 10s Change-Id: I729c801e68154986956b1726e1c35ef973cc4248
2014-03-14coverity#705828 Dereference before null checkCaolán McNamara1-8/+4
Change-Id: Ie76ee86f6ae48012c92a3f06ad1372f126f1ea29
2014-03-14Clean up a little.Kohei Yoshida1-9/+1
Change-Id: I0014cc8af22e4f2284d8e72b6b79fa300ad89028
2014-03-14unit test for string conversion feature, related fdo#37132 fdo#74622Eike Rathke1-3/+74
Change-Id: If7d9c032d6025a6c6bf850e338923296ba2590dd
2014-03-14user selectable string conversion models, related fdo#37132 fdo#74622Eike Rathke7-66/+390
Determines how to treat text when encountered as operand in an arithmetic operation or as argument to a function that expects a number instead. Selectable under Tools->Options->Calc->Formula "Detailed calculation settings" "Custom" from "Conversion from text to number" are: Generate #VALUE! error: =1+"1" or =1+"x" give #VALUE! Treat as zero: =1+"1" or =1+"x" give 1 Convert only unambiguous: =1+"1" gives 2, but =1+"1.000" or =1+"x" give #VALUE! Convert also locale dependent: =1+"1.000" may be 2 or 1001 ... =1+"x" gives #VALUE! For "Generate #VALUE! error" and "Treat as zero" the "Treat empty string as zero" option follows these settings, for "Convert only unambiguous" and "Convert also locale dependent" it can be set independently. When reading documents created by other spreadsheet applications or older versions of LibreOffice, and to interchange documents between different locales the "Convert only unambiguous" with "Treat empty string as zero = True" setting is recommended, though LibreOffice so far acted as "Convert also locale dependent" with "Treat empty string as zero = False", which is the reason that option is kept as default. The best setting to create new documents that can be interpreted by all spreadsheet applications without on-the-fly string conversion is "Generate #VALUE! error". Not having to convert strings during calculation ist also faster, of course. Change-Id: Ie6dc34a00a82064a2d862b2178ce715fab945f85
2014-03-14SvxCheckListBox/SvTreeList/ListBox position types nitpickEike Rathke1-5/+5
Change-Id: Id77f90189d7dffe660ae509f563ea8eb6deb1727
2014-03-14Help poor old Mac compiler by making ScClipParam copy ctor non-explicitStephan Bergmann2-10/+0
(and defaulted) Change-Id: I0cccef5710fad801e5541ce581ac976f645a7fdb
2014-03-14sfx2: sal_Bool->boolNoel Grandin6-6/+6
Change-Id: I56a50ee4a169c8f82c830ebf498f7ead1335f0b5
2014-03-14svx: sal_Bool->boolNoel Grandin1-3/+3
Change-Id: I673d022c01b7d076120c026b236a37735b5043b0
2014-03-13fdo#58307: Write export test for this to ensure it won't go away...Kohei Yoshida3-1/+69
Change-Id: I01ebdfab7d6098402e2911713b0eb51e2003047c
2014-03-13fdo#58307: Export sheet tab colors to xlsx.Kohei Yoshida3-15/+36
And let's not re-use Biff's XclExpWsbool record class to export <SheetPr> elements. That was a bit hacky... Change-Id: Ia585f53d547af3d6840fce1b1244b60bb5076b07
2014-03-13fdo#76032: This row index is 1-based whereas our own mnRow is 0-based.Kohei Yoshida2-4/+4
Change-Id: I098d300532bef164bef0d40ebf62a6848bc19cb8
2014-03-13fdo#76032: Write test for this.Kohei Yoshida2-0/+39
Change-Id: Iec8d32a4e53d2d5d3cdc9767c2ede7654fe2bdd6
2014-03-13fdo#76132: Don't create a formula group of length 1.Kohei Yoshida1-10/+25
That's asking for trouble. Change-Id: I6aaa4d1e2aed4f166ee216c3eb02d3b7794c9a8c
2014-03-13fdo#76132: Write test for this first.Kohei Yoshida1-0/+31
The crash is a result of the pasted formula cell (single cell) being marked "shared", which should never happen. Change-Id: I7b7fa536c520c76b56cce78457e11b6e2eaee76f
2014-03-13fdo#75642: Check the high position block correctly.Kohei Yoshida1-1/+3
Change-Id: I25deabf69e78c6e0354e8a528ab88891a30f9aec
2014-03-13fdo#75642: Add test case for this.Kohei Yoshida3-1/+24
Change-Id: I220cc3aeac79325e7664461d3bd5219e9e1f04f7
2014-03-13coverity#705844 Dereference before null checkCaolán McNamara1-12/+9
Change-Id: I6505b2825d99e3e294814f8ece0d54fe6fd74c1f
2014-03-13MoreButtons cannot be loaded from .src anymoreCaolán McNamara1-2/+0
Change-Id: Ib831895b33323dd478cc125b3bf93c43826ef59d
2014-03-13-Werror=shadowMiklos Vajna1-2/+2
Change-Id: I6160150950d981a01b49cfc4c740683c1fd89b8e
2014-03-12fdo#75977: Clear sheet deleted flags for affected references when undoing.Kohei Yoshida19-46/+174
This will allow formula cells to restore deleted references when they get recalculated. With this change, SetDirty() that previosly took no argument has been renamed to SetAllFormulasDirty(), and it now takes one argument that stores context information. Change-Id: If0de5dc1737a2722b6d61a87644b10a4f921edc5
2014-03-12fdo#75977: Write test for this.Kohei Yoshida2-0/+61
Change-Id: I96bd008759a2a06ffeea46f2b25b847bc895e9eb
2014-03-12fdo#75982: Better hot keys for pivot table fields.Kohei Yoshida1-4/+4
R for Row, C for Column, P for Page, and D for Data fields. Change-Id: I4e29fcdf77a17498d9325a09f0b21154cab04f83
2014-03-12Let's not leak here.Kohei Yoshida1-0/+1
Change-Id: I12a50d0028164c37d06ff846bfbeff56a4591d12
2014-03-12coverity#1158232 Fix ownership of NamedDBs::insert argumentStephan Bergmann9-8/+36
f70d03436b7b501e0ed1d745935a204b9b97b855 "coverity#1158232 have a stab at silencing warning with function markup" claimed that NamedDBs::insert always takes ownerhip of its argument, but boost::ptr_set::insert(std::auto_ptr<U> x) simply calls insert(x.release()), so only takes ownership when it returns true. ScDBDocFunc::AddDBRange (sc/source/ui/docshell/dbdocfun.cxx) relies on this behavior, deleting the argument when insert failed. ScDBDocFunc::RenameDBRange (sc/source/ui/docshell/dbdocfun.cxx) relied on this behavior, deleting the argument when insert failed, until f55cc330dec0dec60c755e2ce28a840c7fca1956 "Fixed the fallout of the changes in ScDBCollection" removed the delete (presumably in error?). I put it back in now. All other uses of NamedDBs::insert ignored the return value (witnessed with SAL_WARN_UNUSED_RESULT). Some are insert-if-not-found cases, where I added asserts now (Sc10Import::LoadDataBaseCollection, sc/source/filter/starcalc/scflt.cxx, is not entirely clear to me, so I added a TODO), while others would have potentially leaked the argument, in which cases I fixed the code. Change-Id: Iad40fbeb625c8ce6b0a61cbf16298d71cdc7de80
2014-03-12Resolves: fdo#75982 set mnemonics targets for hidden labelsCaolán McNamara1-0/+15
the key piece though is that labels that have mnemonic targets are always candidates for getting mnemonics generated for them Change-Id: Ie4bcbc18e94467936f40875c749cd22793021d0c
2014-03-12Spelling fix: suportedTor Lillqvist1-1/+1
Change-Id: I3b67edd5ba4541a65cb0916abea6db1362c32afd
2014-03-12std::strlen requires cstring include to buildLuboš Luňák2-2/+2
Or, even simpler, don't bother with the needless namespacing. Change-Id: I4bbb115c1c2c89881a0bf88ccd54b0f5cb8b3518
2014-03-12coverity#705469 Dereference null return valueCaolán McNamara1-1/+4
Change-Id: I8880f0f441456fe1951145551ef6dfa0e9d65b66
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 12:13:20 +0000