summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2020-05-27Fix test UI_chartSzymon Kłos1-3/+3
Sync chart wizard code with master Change-Id: I4ab2cbfa9efd3caca3c7951150b7daa3a133b634
2020-05-27tdf#131230: Sidebar: Can't set Automatic colorPranam Lashkari1-1/+1
This also solved the issue in sidebar with some controls when selecting an item it selects the item below Change-Id: I607b8bc44402b57b5c4833f918fb41b23ddf48c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93099 Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94855 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-27Revert "tdf#37268: use also sheet local range in Pivot"Julien Nabet2-52/+6
This reverts commit 73af06a6a7fcb2d92d36a45bbe54395bcba8dfb0. The patch is wrong according to: https://bugs.documentfoundation.org/show_bug.cgi?id=37268#c24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94748 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 818af4717bd7d4fbb6f622128c99259efb0714c9) Change-Id: I63dd69afa3fc324930cd16ccc3458372d7745531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94684 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-05-27lok: send "EMPTY" if the rect is empty for cell selection or fillTomaž Vajngerl1-7/+19
It can happen that the selection or auto-fill rectangles are empty and if that's the case then we need to send "EMPTY" string and not the content of an empty rectangle (0, 0, -32768, -32768). This can happen for CELL_SELECTION_AREA or CELL_AUTO_FILL_AREA in calc. Change-Id: I9a60e3907a2ab8b0e0fd1a2ff81137fba6c8e9a3 Reviewed-on: https://gerrit.libreoffice.org/85437 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit df6871286d7b769bc47554955213a2d727c47875)
2020-05-26lokit: fix edit-text/view-cursor positionDennis Francis3-7/+134
in case of views with heterogeneous zooms. 1. EditText render position fix The EditView has an 'output-area' which is used to clip the rectangle we pass to the Paint() call. It also holds on to the ScGridWindow instance where the edit started. The 'output-area' of the EditView is in the coordinates/units of the MapMode of the ScGridWindow it holds. So we need to temporarily change the MapMode and 'output-area' of the EditView in agreement to the device(with the current view's zoom settings) where we are going to paint to. After we call the Paint(), we rollback the original settings of the EditView. 2. EditViewCursor position fix Before this change the cursor position in twips (calculated based on pixel aligned cell position in the view where editing occurred) is broadcasted to all the client-views. If the clients have different zooms, then simply scaling this common cursor position in the client for its zoom is not going to be accurate enough (due to the non-linear Logic->Pixel->Logic transformation involving pixel rounding). This is very visible if you are editing far away from A1 (like Z50). The fix is to turn off this broadcast for calc-cell editing and send view specific edit-cursor invalidation messages. This is accompanied by a online.git patch that removes unnessecary broadcast of view-cursor invalidation messages which messes up things again. "Do not broadcast view-cursor invalidation messages" Change-Id: Ib2fbbe4b6f93f26fc85d6adaa8684dd4397d886f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92631 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit d58f1e334245f9e136750fbba267c2a941a213cc) Conflicts: editeng/source/editeng/impedit.hxx
2020-05-26mobile: escape JSON for function wizard, and emit only on mobile.Michael Meeks1-5/+16
Otherwise typing "-> wa" into a cell gives JS exceptions. Change-Id: I5303186fe9f84e055d65cf1929ccf5a7a20cae35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86705 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ff365eb193279bb9866b8fad7378f6068b207051)
2020-05-26lok: calc - update our version of the other view's selections on zoom.Michael Meeks3-2/+40
Change-Id: I4d23bb77045b41d04109e7dd70a1f47bca8aaa56 Reviewed-on: https://gerrit.libreoffice.org/84767 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ca2fdd792de5d6d208097b3049238865058c7cc1)
2020-05-26lok: calc - update our version of the other view's selections on zoom.Michael Meeks4-26/+60
Change-Id: I8487f28d762c8bf5be4f00a331263218dc71d179 Reviewed-on: https://gerrit.libreoffice.org/84694 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 2986620074d104611a6e78c98ee5a09941866125)
2020-05-26lok: calc - send other views our selection in their co-ordinates.Michael Meeks5-35/+82
Change-Id: If48b5adb9b8b03310d2d2c4e4fefab84ad8bb149 Reviewed-on: https://gerrit.libreoffice.org/84370 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ab07df7ee12aef8bb3770e69d22ecb272d379ece)
2020-05-26lok: send other views our cursor position in their view co-ordinates.Michael Meeks1-17/+31
Change-Id: If8d84a04e8d7b4863dcb9bc9058939b1eb793266 (cherry picked from commit c6b18508aec0e609b4c3c000faf89c21e93620bd)
2020-05-23lokit: trim validation dropdown height to contentDennis Francis1-1/+5
The validation dropdown looks ugly for lists with small number of items as its height is hardcoded to SC_FILTERLISTBOX_LINES(=12) * TextHeight Instead lets use the number of entries in the list to determine the height if this count is less than SC_FILTERLISTBOX_LINES Change-Id: If026140044e6665159cd616c13a2eb57356ae53f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92914 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit adf10bae8aecd8b765a21660b31056292276bdb2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93066 Tested-by: Jenkins
2020-05-23lokit: fix validation dropdown's wrong positionDennis Francis1-0/+16
Reverse the zoom scale on the position of the dropdown before letting the vcl::FloatingWindow convert this to twips without any scale information. Without this reverse scaling, the dropdown will be incorrect due to double application of the same zoom (one in core and one in client). Change-Id: I73de12593b13e1bc9fb0514bec23c20d440d8923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92913 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit a68bfe87f6c720dd2b4721edf869c6801fa2d967) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93008 Tested-by: Jenkins
2020-05-23LOK: spelldialog: don't create the dialog when loading new viewsAshod Nakashian1-1/+4
By default dialogs/decks are re-created when a new view is created/attached, if they are visible. For the spell checker this is unexpected, as the user doesn't expect to be doing spell checking upon loading a document, just because another user was at the time spell checking. Currently the suppression is for LOK only. This also adds support to suppress the recreation of any dialog by flagging it with the SfxChildWindowFlags::NEVERCLONE flag upon invoking RegisterChildWindow. (cherry picked from commit e3fb48fe4f84b5609730c64fdb49b1bd7ddd1f96) Reviewed-on: https://gerrit.libreoffice.org/85004 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e573919cd8561a81d967c1a4566c5733dd44b7b1) Change-Id: I7d71c664f1b2804910c96eeb0431164d48b5679b Reviewed-on: https://gerrit.libreoffice.org/85680 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-23Store and retrieve client visible area on ScViewDataMuhammet Kara2-0/+8
So that core will be aware of the visible area on the client side, and act accordingly when needed. Change-Id: Ieca9b23deb36f3e713704304672dd7037154e904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88487 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2020-05-23lok: Center shape on insert also for Desktop viewMuhammet Kara1-7/+1
Change-Id: I85c3fe3d0166eb42f46f2aa65d0319e582b851af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88489 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2020-05-23mobile: Center inserted shapes on visible areaMuhammet Kara1-0/+12
Change-Id: I366ef5d01ee3afb072b1f67d24015c889a41f4b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88488 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-23Added unique id for number format comboboxMert Tumer1-0/+1
This will allow us to control it for the mobilewizard easily rather than using the id of 'category' which is not unique. Change-Id: I61b612d5355584597a16942b7151a82376033a45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92202 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-23tdf#130770 apply autofilter to data regardless of autofilter changesscito3-22/+88
Add a unit test Apply autofilter to data if there are no changes from the user for AutoFilterMode::Normal mode The condition eMode == AutoFilterMode::Normal at that position is equivalent to eMode != AutoFilterMode::Top10 && eMode != AutoFilterMode::Empty && eMode != AutoFilterMode::NonEmpty because - Top10: Excluded in if() - Custom: Already handled before - Empty: Excluded in if() - NonEmpty: Excluded in if() - SortAscending: Already handled before - SortDescending: Already handled before - Normal: The remaining condition Delete dead code: The condition if (mpAutoFilterPopup->isAllSelected()) will never be true since eMode == AutoFilterMode::Normal && mpAutoFilterPopup->isAllSelected() is excluded in the "outer if condition" !(eMode == AutoFilterMode::Normal && mpAutoFilterPopup->isAllSelected()) Moreover aParam.RemoveAllEntriesByField(rPos.Col()); has already been called before. Change-Id: I1a5362f6edf6d28b3e049977d761cef83897e63e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91645 Tested-by: Jenkins Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit e9c04fdc6d91a152c9197bda3b07316bed1dc4f3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94457 Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-21lok: introduce QueryControlState functionHenry Castro3-0/+12
The sidebar usually executes UNO commands to the core framework, however the controls already have formatted the text that is useful in Online client side. For example the units conversion. The QueryControlState method will retrieve the current formatted text of the sidebar control to be used in Client Side. Change-Id: I0b3e3a1462d4391ac911352f35808a5e5d9f9ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91237 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91577 Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94516 Tested-by: Henry Castro <hcastro@collabora.com>
2020-05-21lok: remove complex rotation / alignment settingsHenry Castro2-0/+48
It is very confusing for mobile user the text orientation properties, let's remove the property for mobile view. Change-Id: I4150f9ed7343d38fd00ee66fa5afffe40426b984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89840 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94514 Tested-by: Henry Castro <hcastro@collabora.com>
2020-05-21lok: ui: more files to increase the 'step-increment'Henry Castro2-4/+4
property to 5. In mobile view, touch spin button should increment by 5 Change-Id: Ib3c8966443d053ab0588fa0c124f0daae31b7ed8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86844 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94510 Tested-by: Henry Castro <hcastro@collabora.com>
2020-05-20fix buildSzymon Kłos1-1/+1
Change-Id: I9a370f2ad877d6c7deca44b01adfe09f94e9a496
2020-05-20jsdialog: use for message dialogs on mobileSzymon Kłos1-1/+6
Change-Id: Ib172dc264d7f55fef08dc474f7e6f4d1b3108085 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94431 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-18loplugin:implicitboolconversionStephan Bergmann1-2/+2
...in non-dependent templated code that Clang trunk now apparently processes more aggressively, presumably since <https://github.com/llvm/llvm-project/ commit/878a24ee244a24c39d1c57e9af2e88c621f7cce9> "Reapply 'Fix crash on switch conditions of non-integer types in templates'" Change-Id: I561d046c736b4e9574565c01daf0f59e7d5ec414 Reviewed-on: https://gerrit.libreoffice.org/84656 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93696 Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-18tdf#130112 lok: Do not apply zoom-factor twice...Dennis Francis1-4/+5
... in ScOutputData::FillReferenceMarks(). mnPPT[XY] already has the factor aZoom[XY] in it. Refer ScViewData::CalcPPT() to see how PPT[XY] are derived. Change-Id: I3f9b5c01cb53514450fad5f7b2b6861b112effdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87158 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 3f62c10548466119ec6b1a662ab339e5dbe0b05f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87170 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-05-18lok: cleanup getCellCursorMichael Meeks6-65/+43
Switching the zoom is no longer necessary - we now have a known and fixed zoom per view now (as the core has), that saves some complexity. Change-Id: I14c952ca1e06fae016faa8b6ee07115c56312ed6 Reviewed-on: https://gerrit.libreoffice.org/84372 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94392 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-18revert optimization - 31b7dc19c32f42197c481cb7d2f44c600b755e2bMichael Meeks3-15/+0
Doing faster lookups across the calc data structrures is far more effective than complex caching of this kind. Change-Id: I43d3ee948ae817ec1d196acc6e5603e6acf1970c Reviewed-on: https://gerrit.libreoffice.org/84371 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94391 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-17Rename isMobile to isMobilePhone and introduce a separate isTabletTor Lillqvist5-6/+7
The intended semantics of isMobile() has been to say whether the device is a mobile phone ot not. Not whether it is a mobile device in general. So make that explicit. Adjust call sites as necessary. Also, in a couple of places where it is likely that what is relevant is whether it is a mobile device in general, not just whether it is a mobile phone, check both isMobile() and isTablet(). For stable interoperability with current Online, keep accepting also the .uno:LOKSetMobile "command" (and .uno:LOKUnSetMobile, except that Online never sends that), but Online will be changed to use .uno:LOKSetMobilePhone. Also drop the default value for the bool parameter to setMobilePhone(). Default bool parameters can be quite confusing, and it was especially silly in this case as there is one (1) call site. Change-Id: I2a71c37323ee151cbc671bd8e714e1dee10f8b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90560 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94390 Tested-by: Tor Lillqvist <tml@collabora.com>
2020-05-17Remove some redundantly user-declared copy ctors and assignment opsStephan Bergmann3-12/+0
...that trigger -Werror,-Wdeprecated-copy ("definition of implicit copy {constructor, assignment operator} for ... is deprecated beause it has a user-declared copy {assignment operator, constructor}") new in recent Clang 10 trunk (and which apparently warns about more cases then its GCC counterpart, for which we already adapted the code in the past, see e.g. the various "-Werror=deprecated-copy (GCC trunk towards GCC 9)" commits) Change-Id: Ie37bd820e6c0c05c74e1a862bb1d4ead5fb7cc9c Reviewed-on: https://gerrit.libreoffice.org/83698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93694 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-17mobile: fix double tap on chart doesn't get into editmodeMert Tumer1-0/+11
Sometimes double tapping on a chart when it is not selected in the beginning, starts the input mode instead of chart editing. Change-Id: Iee2a01c1ac909ac4060e91cdacfa9161dc4f1c3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91992 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d09a35bc10251ef0b66e06c6ffbb2d16332b318b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92291 Tested-by: Jenkins
2020-05-17fix ToC links give unhelpful url popupsMert Tumer1-3/+7
core expects ctrl+click for internal links too and it should not expect it if it is tiled rendering Change-Id: Id841f0e9729e46f00988ea0b4eb29bd65098a740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89559 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3fe9dfca2d44d9e41ee329883f199359c673f382) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89919 Tested-by: Jenkins
2020-05-17send hyperlinkclicked callback on calc mobileMert Tumer1-1/+20
for opening links ctrl+click must be pressed but in mobile this cant be done This patch allows it to send the callback and also cell coordinates for hyperlink popup Change-Id: I8c0fac167627ef449d9cf20a36a7a5a77978ae0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89121 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 9bfa939f87f28cdaed2a24c3dc5f9a21004b19da) Blind build fix for Android After 9bfa939f87f28cdaed2a24c3dc5f9a21004b19da Also, replace chained OStringBuffer::append() with operator+ Change-Id: I7012667b3c4173cc0193720e0197992e5942bc7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89693 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-17lok: get the formula input bar focused after inserting '='Marco Cecchetti1-0/+2
Change-Id: I7f86ea7135fcb4071cc0162c233c63be6c9485bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92083 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-05-17formula manager: wrong category returned by ScFuncDesc::getCategoryMarco Cecchetti1-1/+1
In the function manager the index associated to each category starts from 0 while in ScFuncDesc starts from 1 (data member ScFuncDesc::nCategory) Change-Id: I92d0cd2a1a2871785e45faafd797dcf3a500bec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89198 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90072 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-05-17lok: calc: unwanted cell range selection occurs when clicking on a cellMarco Cecchetti1-1/+1
When user clicks on a cell after the browser has lost focus user gets the cell range from A1 to the current clicked cell selected Change-Id: I1dd495f42ca7e5ee8cad1d2354dcebc0cb05d65f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88549 Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90071 Tested-by: Jenkins
2020-05-17lok: calc: send text selection rectangles for the input barMarco Cecchetti1-0/+5
Change-Id: I3caeaddd7a5ddc6e496650539b88e2fd81b37e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86790 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90069 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-05-17lok: calc: zoomed text entry not renderedMarco Cecchetti1-4/+7
Change-Id: I829966d81bd68571a0651feb458a817587e4d88e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84992 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-17lok: formula bar: function completionMarco Cecchetti4-0/+31
lok clients can request to complete a function name partially typed in the formula input box. Change-Id: I8771fd4d2a7f79c20138d9183162da23a92f2ba4 Reviewed-on: https://gerrit.libreoffice.org/83984 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84258 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-17lok: calc formula bar tunneling: function list callbackMarco Cecchetti1-0/+57
Added a lok callback for sending the list of functions matching the current characters typed by the user. Change-Id: Ia971fc55ec5eb961b4098592a8049dd0eed3ba14 Reviewed-on: https://gerrit.libreoffice.org/83750 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-17lok: calc formula bar tunneling: resize the main windowMarco Cecchetti2-0/+23
When a resize msg is forwarded from the client to the core for the formula bar, for instance because of a browser window resizing, we need to resize the whole main app window not the formula bar only. On the contrary we have 2 issues: 1) each time the formula bar get focus the layout manager tries to set the size of the formula bar back so that it fits inside the app window 2) the part of the formula bar outside the app window doesn't respond to mouse events on the client side. Change-Id: I13ddc40a2a8e543808a4bf36a04022deb3700163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89858 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-05-17lok: calc formula bar tunnelingMarco Cecchetti4-11/+115
Change-Id: I92026098222e04a163796225a048c6d7dc1b37c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89857 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-05-17lok: on calc spelling context menu didn't pop upMarco Cecchetti2-10/+17
The problem has been fixed by making visible cell range syncronized with client visible area Change-Id: I632f8ef4d5e8fa227b55fcb0459ed89d10798134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89856 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-05-17sc: LOK: commit cell edits before saveasAshod Nakashian2-0/+8
Users typically don't recognize that changes done to a cell need to be committed (typically by hitting RETURN) before they are saved to file. This is especially true on the web. This patch commits any in-flight changes before SaveAs. This is currently done only for LOK and unconditionally at that. This can be controlled via a flag, if there is such a use-case. Reviewed-on: https://gerrit.libreoffice.org/78012 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit cc7eb4d345e3fede698a3f255c1938d275305c14) Reviewed-on: https://gerrit.libreoffice.org/78455 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit e867404fbe7e0ff0d6f2573292c19b3a178a412d) Change-Id: I2a88b2f1df47be764058f4505561b22830d9d67a Reviewed-on: https://gerrit.libreoffice.org/82102 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-17LOK: emit modified status on entering cell dataAshod Nakashian1-0/+12
Entering data into a cell without committing will normally not set the modified flag. However clients might want to know whether there is in-flight changes when they need to save the document. A possible scenario is that the user enters some cell data and then closes the window. Both WSD and the client app would here rely on the modified notification to decide whether to save the document or not. We do not change the document modified state, since that may be incorrect (in case the user actually cancel the cell entry), so we preserve that so future updates to the modified status would reflect the correct state of the file. Instead, we emit a client notification that the document has been modified, to signal them that saving is sensible. Note that ideally we would undo this when the user cancels the cell edit, but that would be complicated due to multi-editor scenarios. For example, another user might actually edit the document while we cancel our cell edit, and in this case we should not reset the modify flag. Since this is unreliable, we leave the flag set, unless the Core emits an update, which will surely be accurate. Reviewed-on: https://gerrit.libreoffice.org/75513 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 38b899312245758381fa72ad17c2d4c281edb1ba) Reviewed-on: https://gerrit.libreoffice.org/78451 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Change-Id: Id26aa6f8ce2c0a08f8bee6812fcf99275dc24551 Reviewed-on: https://gerrit.libreoffice.org/82093 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-05-16lokit: Mark document as modified on chart insert/edit...Dennis Francis1-1/+4
immediately at least in the case when LOKit is active. This is to allow prompt emission of .uno:ModifiedStatus=true statechange message from lokit to the client. Without this, in online the chart insert/modify related changes may not get saved on client exit. (cherry picked from commit 75adb624dfff4659e6f3099a1720fbd697560f9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91036 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Change-Id: I8c38a37cc455f74a70d43b6aaa3e5035b283d47f
2020-05-16sc: correctly update spelling markers on undo/redoAshod Nakashian1-0/+4
(cherry picked from commit 62eb6210895b24855b077fb0d89f182beac4a43c) Reviewed-on: https://gerrit.libreoffice.org/85005 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit a05fd0eb30767471c6d20c93e0fb8b3ff7c7eaee) Change-Id: I946cede7967f454813f717273c4114d31167c8c6 Reviewed-on: https://gerrit.libreoffice.org/85681 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-16sc: clear the spell checking markers after applying correctionsAshod Nakashian1-0/+5
Change-Id: Ia3fc3b5a21d21b9b945ce72f397350a57859f107 (cherry picked from commit afa5f2b0edb43b36b1b4f0ab8f70ecbe638435e5) Reviewed-on: https://gerrit.libreoffice.org/85006 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e1ca2b989bf4d124588c35f7f4a0bc3da3c1f58e) Reviewed-on: https://gerrit.libreoffice.org/85682 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-16sc: spelldialog: lock before resetting the editviewAshod Nakashian1-0/+3
Painting also resets the view and that can happen asynchronously. When the spelldialog gets focus it resets the editview if it detects it has changed, which happens when, for example, another view is created. (cherry picked from commit d91d940ad0319e0cc6e0080a903ac0a7e9f6ba88) Reviewed-on: https://gerrit.libreoffice.org/85003 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 550c0a666e119c911b311c96f9185c11d8465dcb) Change-Id: Ib23e332e4ba069e05787d1cc03ae23fe657b12c8 Reviewed-on: https://gerrit.libreoffice.org/85679 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-16lok: Improve hyperlink insertion to cell with contentMuhammet Kara1-2/+19
Change-Id: I520939dd5b44236cf835108ee2bc96c29f0a9677 Reviewed-on: https://gerrit.libreoffice.org/85509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89707 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-05-16lok: calc: zoom: object selection - is unreliableMarco Cecchetti1-0/+25
Change-Id: Ic8e61c56bdf38bbb74f179fa36075bdd3a601249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90068 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-01 00:00:54 +0000