summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2017-10-19tdf#113159: Pivot table: tabular mode is converted to oultine modeTamás Zolnai3-13/+64
... after RT XLSX in Calc Change-Id: I9725ca55aed973133db1d5fe47463575148e00b8 Reviewed-on: https://gerrit.libreoffice.org/43537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-19Fix assertion to check the right thingTor Lillqvist1-1/+1
We want to assert that the token separator character is not one of the quote pair characters. Change-Id: Ic6114238f4a45a4f1ed7d255e7e9da3519479148
2017-10-19dyncolcontainer: convert nRight to std::vectorNoel Grandin2-15/+13
Change-Id: Ie1c081250b22d80ece3c8f5a21e9728c14d7bdb1 Reviewed-on: https://gerrit.libreoffice.org/43516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-18use rtl::Reference in sc/../uno/*Noel Grandin6-58/+41
instead of manual reference counting Change-Id: I60798316f2b63800a9f539cb719305c00d91ecc5 Reviewed-on: https://gerrit.libreoffice.org/43491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-18svx: remove pointless duplicate SdrFitToSizeTypeMichael Stahl1-1/+1
Change-Id: I7a59ecfdb8d09ecbc0b760003dbc453ac5646d1c
2017-10-18add CVE-2017-0199 test-casesCaolán McNamara2-0/+0
Change-Id: I562c16a1dfcf4d8ba6b893da71ae557c4811ac24 Reviewed-on: https://gerrit.libreoffice.org/43480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18dyncolcontainer: convert aColWidthPath to std::mapNoel Grandin3-3/+4
Change-Id: Ifb86372de3671b81c0438c0096b375b07d2f6754 Reviewed-on: https://gerrit.libreoffice.org/43468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-18dyncolcontainer: use std::map in DifAttrCacheNoel Grandin2-6/+7
Change-Id: Ic3280c5548555ceeb722788dc0a90f8898f46c2e Reviewed-on: https://gerrit.libreoffice.org/43467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17turn implicit container explicit in buildable notebooksCaolán McNamara18-78/+564
as in interim measure for SfxTabDialogs we throw away the TabPage if its not suitable for reuse Change-Id: Ic5776ca3d2a8cb6bf41f33df01b211f81c62a842 Reviewed-on: https://gerrit.libreoffice.org/43134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-17remove unused ScCompressedArray constructorNoel Grandin2-33/+0
Change-Id: Ida4d8abe50885d10288169024b597fa946d1c26b Reviewed-on: https://gerrit.libreoffice.org/43438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17Simplify ScCompressedArray constructorNoel Grandin2-13/+7
nobody is setting a custom delta Change-Id: I5dd9ac691fb226697eb8cb2b6b0b673552a4f049 Reviewed-on: https://gerrit.libreoffice.org/43437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17use rtl::Reference in ScAddInListenerNoel Grandin2-16/+11
instead of manual ref counting Change-Id: I04bdb5b34921da9ab08a55a95b99ff1635a9cda6 Reviewed-on: https://gerrit.libreoffice.org/43420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17dyncolcontainer: use ScBitMaskCompressedArray for pColFlagsNoel Grandin6-40/+27
Change-Id: I5df10fe7477e05424eb5e8a3544073a264568aac Reviewed-on: https://gerrit.libreoffice.org/43409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17dyncolcontainer: use ScCompressedArray for pColWidthNoel Grandin6-53/+127
and enhance ScCompressedArray with an iterator to avoid O(n^2) "for" loops. Change-Id: I7d8fda8306b0a5c73bf373b3991e1c07271bc9d9 Reviewed-on: https://gerrit.libreoffice.org/43387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-16Translate German variable names in Calc (financial)Johnny_M1-25/+25
These names of variables correspond to German function names in Calc and were translated to their English equivalents. For used translations, see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=GDA&sfields=target&soptions=exact,case Change-Id: I58be84b37e045ac15bcdf15032def7591be53de7 Reviewed-on: https://gerrit.libreoffice.org/43078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-16use rtl::Reference for SvXMLGraphicHelperNoel Grandin1-5/+6
Change-Id: I0052b29660fb6157f7e98c4e124f030ba439d304 Reviewed-on: https://gerrit.libreoffice.org/43417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-16tdf#105853 improve layout Options > Calc > Formula ... separatorCor Nouws1-72/+20
thanks Olivier for help with mastering Glade ;) Change-Id: If2e2381168a98d5b04c28d6625800d03b0c5e868 Reviewed-on: https://gerrit.libreoffice.org/43352 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-14ofz#3634: add a SC_MAX_MATRIX_ELEMENTS to limit max matrix elementsCaolán McNamara1-1/+7
Change-Id: Ib2b1a36d56cc8ac63cf28a18fa20ad2f075dcf21 Reviewed-on: https://gerrit.libreoffice.org/43394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-14implement new more user friendly data provider dlgMarkus Mohrhard10-125/+729
This is still a work in progress. Change-Id: I1e68c86acc810eec068b1f184b2307c51d9b58df Reviewed-on: https://gerrit.libreoffice.org/43259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-13derive size of tab bar in Calc from TabFont (in pixels).Bernhard Widl1-1/+5
Change-Id: I3a35850cb6a66b06ae6568b54c008669ee2f391a Reviewed-on: https://gerrit.libreoffice.org/43328 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-10-13Replace lists by vectors in chart2uno (sc)Julien Nabet2-19/+14
+ remove useless 'using ::std::list' in externalrefmgr (sc) Change-Id: Iacff73fafe5a048b47abea865a77645a960e1a0d Reviewed-on: https://gerrit.libreoffice.org/43355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-12Translate German variable names in Calc (financial)Johnny_M1-13/+13
These names of variables correspond to German function names in Calc and were translated to their English equivalents. For used translations, see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=RMZ&sfields=target&soptions=exact,case Note: This is an alignment of the function declaration to the definitions in /core/sc/source/core/tool/interpr2.cxx, some of which were translated on f8b9b8ec5686c1453e335d895aa78faba5fdf268, while others were already in English. Change-Id: Ifb01992e42af707a08a02139ffb8313d3b92701c Reviewed-on: https://gerrit.libreoffice.org/43077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-12adapt dataprovider to the requirements of the new UIMarkus Mohrhard6-77/+90
Change-Id: If10a68a27591f3195ef85c21ea98324903819b36 Reviewed-on: https://gerrit.libreoffice.org/43256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-11Replace list by vector "DataPilotSort" from dbfunc3 (sc)Julien Nabet1-12/+7
Change-Id: Ib8754d7e459d1019ed2d5f49ce593e20af0b7f0c Reviewed-on: https://gerrit.libreoffice.org/43315 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-10use std::swap instead of own implementationMarkus Mohrhard1-4/+1
Change-Id: Iabc0eee868a2ad5623a1ac39b26bb2bc5981e829 Reviewed-on: https://gerrit.libreoffice.org/43249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09sc, implement HAVE_FEATURE_AVMEDIAjan Iversen4-1/+23
iOS does not support avmedia, therefore HAVE_FEATURE_AVMEDIA is set, however not all sources test for it. Change-Id: I627d1a45420d4af093c57bc53d716d48bf3a4b00
2017-10-09update notebookbar to add ExportDirectToPDF and ExportDirectToEPUBandreas kainz2-4/+18
Change-Id: I6b161cc7d5e56b1a6507d6a513f1d3d70e8671c9 Reviewed-on: https://gerrit.libreoffice.org/43271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-10-09tdf#45904: Move _XAreaLinks Java to C++Jens Carl3-0/+205
This allows to re-activate the test and fixes #i84701. Change-Id: Ifd295e9521a04e88a68aa96fad8f9e8e32f927fa Reviewed-on: https://gerrit.libreoffice.org/41855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09make sure to include all relevant header filesMarkus Mohrhard1-0/+1
Change-Id: I313d3a7dce5143ad8703e8ef8c2d066e652a4483 Reviewed-on: https://gerrit.libreoffice.org/43248 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09prevent crash in the new dataprovider UI when adding a new columnMarkus Mohrhard1-1/+1
Change-Id: I3f87d2dac75662ab1da6049579d33d6b39e1da0c Reviewed-on: https://gerrit.libreoffice.org/43257 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09document how formulas are stored in the cacheMarkus Mohrhard1-0/+2
Change-Id: I1a4f8dd16bb739eb84087e596278fbd4cdc8db7c Reviewed-on: https://gerrit.libreoffice.org/43255 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09document a few method parametersMarkus Mohrhard1-0/+5
Change-Id: I08273d2a84c335e5eb9998e41a67b3b7340f348d Reviewed-on: https://gerrit.libreoffice.org/43250 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-08tdf#45904: Move _XSubTotalField Java tests to C++Jens Carl4-1/+225
Change-Id: I64528c4e315247583e185bc3ab0defbc22bd8726 Reviewed-on: https://gerrit.libreoffice.org/41826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-07This method was replaced accidentallyTamás Zolnai1-1/+1
Change-Id: I37d6d0fc36420de6dbdd69f264b85f3ba591e312 Reviewed-on: https://gerrit.libreoffice.org/43232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-07tdf#109016: Avoid to write the same pivot item member more timesTamás Zolnai3-2/+19
It seems it's allowed to have the same member name in a pivot table. We need to handle this in the filtering code. Regression from: 625653c8d119e720fb93b0c9f6f50d1eb625b179 Change-Id: Ic6f4110da3d83f4bbf5284e1b772e9e31b250bf1 Reviewed-on: https://gerrit.libreoffice.org/43230 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-06tdf#112946: Pivot table: Missing selector for a row field after RT in CalcTamás Zolnai3-0/+25
We need to explicitly set compact flags to false, since true is the default. It seems MSO prefers compact mode, when the file contains colliding mode flags. Change-Id: Ib311f1cf44345be294e6c6607c227c2baa0fb693 Reviewed-on: https://gerrit.libreoffice.org/43210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-06tdf#112936: Pivot table: LO created XLSX file makes Excel to crashTamás Zolnai1-0/+1
It's not actually clear, why Excel crashes, but setting the version makes it working. I expect that this version number (which specifies MSO Excel versions) makes MSO to handle the pivot table differently. As the internal implementation of the pivot table was changed in different versions. The name "DATA" might had a special meaning in the earlier versions (e.g. XP, MSO 2000) which leads this crash. So setting the version to MSO 2007 seems a good solution for this. Older versions not seems a target of LO exported XLSX files in these days. Also smaller values leads to the crash described in the bug report. Change-Id: I6e9edc949d1670d657effff9277cfd86ff163458 Reviewed-on: https://gerrit.libreoffice.org/43208 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-06Process all pending events during Cppunit setUpJan-Marek Glogowski5-0/+5
Larger unit tests collect a lot of events, which are just processed on shutdown. But since the Scheduler is just an unsorted linked list, processing these in order is O(n^2) for lookup, which really adds up, e.g. sw_ooxmlexport8 has 35047 tasks on shutdown. So this just processes all pending events before running each unit test. Also adds missing spellchecking components to some calc tests. Change-Id: Icf12146015afc17a1f52f79c18f248b72650ad46 Reviewed-on: https://gerrit.libreoffice.org/43199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-06use rtl::Reference in SvXMLEmbeddedObjectHelperNoel Grandin1-15/+18
instead of manual ref-counting Change-Id: I559ebb3871dd3dd4a160bd83a259e36dd2f7b4d6 Reviewed-on: https://gerrit.libreoffice.org/43200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-06coverity#1418967 Uninitialized scalar variableCaolán McNamara1-0/+4
and coverity#1418960 Uninitialized scalar variable Change-Id: I2f96b3824fca585a22d7a02a974c371ebaf57bde Reviewed-on: https://gerrit.libreoffice.org/43187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-06coverity#1418961 Uninitialized scalar fieldCaolán McNamara1-0/+2
Change-Id: I84692e07f3887c8440df535c2c0c1191cd2773be Reviewed-on: https://gerrit.libreoffice.org/43188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-06coverity#1418965 Uninitialized scalar fieldCaolán McNamara1-0/+4
and coverity#1418963 Uninitialized scalar field Change-Id: I16bd91d2dfe2a1ae3f4697b5ff67acf6b6a5ba1c Reviewed-on: https://gerrit.libreoffice.org/43189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-05sc: try to fix DISABLE_DYNLOADING hackeryMichael Stahl1-1/+2
Change-Id: I291ffc6cd1c7e9a43cd6f0861c05833316bfff78
2017-10-05tdf#112893: Pivot table: filtering of error item is not importedTamás Zolnai6-7/+40
... from XLSX Change-Id: Ib155852e5f0718f41e02596d1042513286c6d845 Reviewed-on: https://gerrit.libreoffice.org/43166 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-05tdf#112884: Error string is displayed as empty item in pivot tableTamás Zolnai1-1/+1
Need to get the right string representation of error cells. Based on the code it seems a regression from: d4cd8677889ec3807c194ef5b462f8e031807e5b Change-Id: I30001e63cd17ae68ba4988d5825de479a4496326 Reviewed-on: https://gerrit.libreoffice.org/43146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-04Fix typosAndrea Gelmini1-1/+1
Change-Id: I7f6dbb170b88cc1717d08651d4ddd3aace0a7933 Reviewed-on: https://gerrit.libreoffice.org/43141 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin12-17/+17
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-04Revert "check for unnecessary DLLPUBLIC annotations"Stephan Bergmann1-1/+1
This reverts commit a599eeab786ecbe1b5b6509e3c792e5c1ba31248, plus follow-up fa4431449d0306e8179f53a2a69c549800bd24bd "Avoid bogus loplugin:dllmacro 'unnecessary *DLLPUBLIC declaration ...'". See (abandoned) <https://gerrit.libreoffice.org/#/c/42983/> "loplugin:dllmacro: Handle implicit member functions" how this would have needed to be extended to give consistent results across Linux and macOS, but then would have started to remove DLLPUBLIC from entities that apparently need to at least have default type visibility on macOS and started to make tests fail.
2017-10-04Indent part of ScInterpreter that for some reason was not indented at allTor Lillqvist1-749/+749
Change-Id: Ib514d8422a1a881f24fe7a10e8ce538ea997dc6b
2017-10-03tdf#112842: UI enable/disable leadingzeroeslabelXisco Fauli2-0/+5
Change-Id: I73c617c1416628d094b8ee5794f43e16b77681d3 Reviewed-on: https://gerrit.libreoffice.org/43058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>