summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2018-02-09CheckLinkFormulaNeedingCheck() for named expressionsEike Rathke3-1/+12
This is a combination of 3 commits. CheckLinkFormulaNeedingCheck() for .ods named expressions This is specifically necessary for named expressions that are used in conditional format formulas, for which RPN is generated at a later stage, not during import. (cherry picked from commit eae9648e99be53ba441d9d8207aac6f3ce211ef2) CheckLinkFormulaNeedingCheck() for .xls named expressions (cherry picked from commit 8512f13c42ae3fbb287a555616fe10ff04295616) CheckLinkFormulaNeedingCheck() for .xlsx named expressions (cherry picked from commit a1f933ee2b9e23a505d937035821e9571cf4119c) Conflicts: sc/source/filter/oox/defnamesbuffer.cxx e03cb5767c34f8157a492a6d6c3b0700d065052d 217c89822ab477a6c383d170ae739e44efd10fa3 Change-Id: I54ab8dc14f81d6b18b0d17f448187d19d8e396fc Reviewed-on: https://gerrit.libreoffice.org/48858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-09CheckLinkFormulaNeedingCheck() for conditional format expressionsEike Rathke4-2/+29
This is a combination of 4 commits. Prepare CheckLinkFormulaNeedingCheck() to use either RPN or tokenized code Conditional format formulas aren't finally compiled until needed so the check will have to operate on the tokenized expression instead of RPN code. (cherry picked from commit faa0305ba3d0dc698fce4915d4f3a1fb52422380) CheckLinkFormulaNeedingCheck() for .ods conditional format expressions (cherry picked from commit 2930ba2ac5d9423f2848b968edcd8ddc71966186) CheckLinkFormulaNeedingCheck() for .xlsx conditional format expressions (cherry picked from commit fef24d9f999ee54d7936900485d97ff26656f517) CheckLinkFormulaNeedingCheck() for .xls conditional format expressions (cherry picked from commit af2a2a0c72db312902e466c36697b5c198041e82) 45eb1ab5efa0ec9da2663f20427d2474ce300826 31ede1a23223a798141a0891deeabd8cf88fff58 afa112cc591b411d80ead48bf726788d361f6eb3 Change-Id: I68837e9bd33f125ab47b10b1a6fa18175abd1627 Reviewed-on: https://gerrit.libreoffice.org/48719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-09CheckLinkFormulaNeedingCheck() for .xls and .xlsx formula cellsEike Rathke7-2/+20
This is a combination of 3 commits. Move implementation to CheckLinkFormulaNeedingCheck() for further reuse (cherry picked from commit 55e484c7bcd3ef218e08d3fd93f97bf98fd8cb7f) CheckLinkFormulaNeedingCheck() for .xlsx cell formulas (cherry picked from commit f96dbc3dd9c33202f75e29ef49d962386595995d) CheckLinkFormulaNeedingCheck() for .xls cell formulas (cherry picked from commit 6bc48275558c3f76c4da25eb8af3c48583ac5599) a6dd195f7eb4d43483e87eeca59f651e7bf2dcb8 2587fbc4fec39b6f2c8e733331815a2953dee308 Change-Id: I541d2b6e12a88371c064b901b00e71206ee0c18e Reviewed-on: https://gerrit.libreoffice.org/48143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-09handle ocWebservice similarly to ocDdeCaolán McNamara10-43/+253
might have too much in here seeing as we don't need to worry about ocWebservice calling into itself Reviewed-on: https://gerrit.libreoffice.org/47819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e1946d75a1095c2596d7815600454ff01fcd3270) Signed-off-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 78c1ae24007d8098ee4f4add6d72e84411181785) (cherry picked from commit a09ca6b29b16f29e21ea65658c112eaf1cf7d819) Change-Id: I0145f38cc1c1f9ff514a496f7101d81cde9e7c67
2018-02-09Better handle ScDde formulas with missing dde-link entriesCaolán McNamara6-10/+18
typically each ScDde formula has a matching table:dde-link which results in a ScDdeLink getting inserted during the load. If that dde-link is missing then no ScDdeLink exists and ScDde() will create a new one without cached content. So detect that ScDde is used in the freshing loaded ods and defer fetching new content until the right time. only call GetHasMacroFunc to set SetHasMacroFunc and bHasMacroFunc is not accessed any other way, so this is an oxbow Reviewed-on: https://gerrit.libreoffice.org/47757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b0597ba5d745974fce752e1b677451a19350d351) Reviewed-on: https://gerrit.libreoffice.org/47818 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 4ede45eb239b1604bca900c22481b7d13e4c2790) Signed-off-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3139914eb6379837fbf309642a63371128042db1) (cherry picked from commit ef93fb5ae0691cba777c9d2b24a3180e14281cbc) Change-Id: I016b53288076d83dd49e92e245346a5f7f560522
2018-02-09limit WEBSERVICE to http[s] protocolsCaolán McNamara1-0/+9
and like excel... 'For protocols that aren’t supported, such as ftp:// or file://, WEBSERVICE returns the #VALUE! error value.' Change-Id: I0e9c6fd3426fad56a199eafac48de9b0f23914b3 (cherry picked from commit c6c3ed3c750a3c71cb57909c60773fde2c43cd2a) (cherry picked from commit defb648f718c3ea52c719313986a7188c6a6eafd)
2017-04-23coverity#1399031 golden, Out-of-bounds readCaolán McNamara1-1/+1
There are 17 elements, so SAL_N_ELEMENTS(sppnPatterns) is 17 The largest valid index is 16, not 17, so valid max index is out by one Change-Id: Id20218a0e73cb9e502a631fa6bfbb3f0a22c4727 (cherry picked from commit 9ad08b403be9c6646cda9a379332545c3668975b) Reviewed-on: https://gerrit.libreoffice.org/33401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5e314dfb058990a78cd9e1b9045ac0f186de7003) (cherry picked from commit be08514ac4a8d3e4b837937bfc46528503d434c4)
2017-03-22disable generation of ole previews in ODF format until after loadCaolán McNamara5-9/+43
so the user update links dialog can control their generation SdrEmbedObjectLink becomes exposed to calc so it can detect if the link dialog needs to be used to update ole links. Reviewed-on: https://gerrit.libreoffice.org/28879 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 74844277cc2194c9e43f5bd7a6f78a9603da32f3) detangle gadzillion checks into something readable no logic change intended (cherry picked from commit fad9786b06d188ba6e354620f57176f3d94a6637) + partial merge of commit c09b3e32372537be739182b02ae83a96386d1e1c Author: Noel Grandin <noel@peralex.com> Date: Tue Mar 8 13:13:59 2016 +0200 loplugin:constantparam in sw for bool bUI is always true in UpdateLinks Unmodified default SdrOle2Obj size is 101x101 svx/source/unodraw/unoshape.cxx sets a css::awt::Size maSize to 100, 100 svx/source/unodraw/unopage.cxx increases that by 1, 1 awt::Size aSize = xShape->getSize(); aSize.Width += 1; aSize.Height += 1; to call SdrObjFactory::MakeNewObject with 101, 101 so default size is 101x101 (getWidth() vs GetWidth() confusion ?) Reviewed-on: https://gerrit.libreoffice.org/28895 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7f0a219c9ad38ae33b51ff69d545f69659691c1e) b6af93afc1f80b7fc36239c96d5e0a71fcbcb789 4d4375dff64d7b8e236d1a24322e749e04ee530f Reviewed-on: https://gerrit.libreoffice.org/28930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 2ff4c68b63c4842ec85a21287317096b6ca8e66e) Change-Id: Id1dd7ea17342140eab9307d546528747e3a98090
2016-09-01sc lok: fix re-sizing several rows/columns at onceHenry Castro1-6/+24
Reviewed-on: https://gerrit.libreoffice.org/28351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Conflicts: sc/source/ui/view/cellsh3.cxx Change-Id: I7b3760432aa4b3120bfd586a1abc42a46fff0df8
2016-09-01sc lok: add parameters for column/row resizeHenry Castro3-8/+74
Reviewed-on: https://gerrit.libreoffice.org/27701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Conflicts: sc/qa/unit/tiledrendering/tiledrendering.cxx Change-Id: I189178b6060c229dd8d93b6fdee7d4d81354ced5
2016-06-19bccu#1893 - [PERFORMANCE] .uno:ViewRowColumnHeaders too slowAshod Nakashian1-23/+22
For very large spreadsheets, the boost json generator (property_tree) is extremely slow and memory-inefficient. There is little need for generic json generator, however, since there are exactly two nodes (rows and columns) and each is an array of size/text pairs. The new logic uses a string with reserved capacity to accomodate the output and generates it in one step. The speed improvement is orders of magnitude (hours to seconds) for very large spreadsheets. Change-Id: Ifaf316c270ed6e4b923ec44189a315f69e7e9b0e Reviewed-on: https://gerrit.libreoffice.org/26480 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-19LOK: Fix cell editing with zoomAshod Nakashian1-2/+2
Change-Id: I243e8af47d35a2aae972b15d0b53ff9f41441668 Reviewed-on: https://gerrit.libreoffice.org/26478 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-19Use explicit type in std::maxAshod Nakashian1-2/+2
Change-Id: I777d5387d9377f0f8032d68a9191a7fa110287c5 Reviewed-on: https://gerrit.libreoffice.org/26477 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-16Revert "sc lok: limit movement of the cursor"Ashod Nakashian3-11/+1
This reverts commit 538d0c92ae2d5cb36869360a0889bc063a854f47. No longer necessary with fast calc tile rendering. Change-Id: I82b020666abe13aa7a5292ad3c3dd979b970e2b0 Reviewed-on: https://gerrit.libreoffice.org/26368 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-16LOK: tile rendering regression fixAshod Nakashian1-0/+1
Calc fast rendering requires us to offset the are being rendered and shift all bitmaps accordingly. This however is breaking Impress rendering since the offseting logic is common (in svx and vcl). This adds new API to enable or disable this local rendering (as opposed to rendering a full document as was previously done. The new flag is then set by Calc to enable the offseting logic in isolation without affecting other applications. In one case isolation was achieved by checking the MapModeUnit. Change-Id: Ia0aadfc3f6df7c1a891b97dc731f5897414c9420 Reviewed-on: https://gerrit.libreoffice.org/26367 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-13LOK: fast tile rendering (cell editing)Ashod Nakashian1-0/+13
Cell editing uses editeng which has a different set of requirements. The coordinates are in 100th mm and so we have to convert the ofsets to 100mm. Change-Id: I278457ffc2273eb786101875c85ddfb959d4c5e3 Reviewed-on: https://gerrit.libreoffice.org/26205 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-13LOK: fast tile rendering (graphics and buttons)Ashod Nakashian1-0/+3
Since embedded graphics and buttons use absolute coordinates, we set the origin to be the top-left corner of the tile. This includes the origin + ScrPos (see previous patch). Then, the coordinates of the graphic is shifted by this amount to make sure it renders in its relative position to the tile. This renders embedded graphics and buttons at their correct position, with some limitations. Tiles large enough to cover a graphic object show the graphic object where it should be. However, rendering a relatively small tile doesn't render the graphic. This seems to be an issue with moving the graphic's coordinate at a later stage than the 2D Processor decides what objects intersect with the 'view area' that is rendered. Another issue is that graphs don't render. What they seem to suffer is incorrect scale and a fix coordinates (they show up as tiny thumbnails at the top-left corner and grow in proportion to the real graph when resized). These shall be addressed in a separate patch. Change-Id: I4b71bf5f2e357d1114d46022bc00905ceed0c2f9 Reviewed-on: https://gerrit.libreoffice.org/26204 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-13LOK: fast tile rendering (text only)Ashod Nakashian1-86/+120
For every tile, the bounding columns and rows are found. The origin of the device is set to the top-left corner of the top-most row and left-most column, respectively. Because tiles don't have to align with a column or row, the ScrX and ScrY (Screen Position) coordinates are set to the offset a tile has to its top-most row and left-most column. Rendering of text is super fast as the minimum area is rendered for a given tile. However, it doesn't work for embedded objects. This is addressed in a separate patch. One pending issue with text is when editing. The text doesn't correctly render while editing a cell. This is almost certainly because the edit control is not rendered at the correct offset (in the middle top row it can be seen showing up to the right of where it should be). Change-Id: I6f1ea0aa2f19a7fda926f596a2009290680c593c Reviewed-on: https://gerrit.libreoffice.org/26203 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-06-08sc lok: catch unhandled exceptionPranav Kant1-1/+15
Now, after 432b27ec73940738bb0b4f9d3d749c70a2525700, we do not export newlines when empty range is selected. Trying to get transfer data in such a case throws an exception. (cherry-picked from commit 82ed95b7554cfa3b5e98f67cc53c6219e3a09886) Change-Id: If2b16bfa2c1932b0599108b989e62e200c1b3b27
2016-06-06sc: Don't export in case of invalid rangePranav Kant1-1/+2
For example, copying an empty column or row range, and then pasting as unformatted text exports all the newline characters inspite of the fact that this is an invalid data range. The problem becomes worse when someone tries to copy an entire column which implies exporting MAXROW times newline characters. Change-Id: Ie0a09890e2d0cd5f44d89d520959248e65365ad7 (cherry picked from commit 432b27ec73940738bb0b4f9d3d749c70a2525700)
2016-06-01Linux x86 build fixcp-5.0-38COOL_1.0Andras Timar1-1/+1
Change-Id: I34a393745265b8daca832c7df896bea090bb2554
2016-06-01sc lok: limit movement of the cursorHenry Castro3-1/+11
Change-Id: Ic7fe2dec012efb8ba180feb4d3df6f4bfbf6c38a
2016-06-01sc lok: Add new param to .uno:EnterString to prevent committingPranav Kant2-7/+27
If new param, DontCommit, is specified start the edit engine and edit the current cell. This helps in not triggering calculations that depend on the current cell. In case DontCommit param is missing, it will work as it used to. Change-Id: I62408932e52ff68fa11568cfc16a43e4c1e919c5 Reviewed-on: https://gerrit.libreoffice.org/25753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.com> (cherry picked from commit c14627d66ca8d9fe14272fadb5305857101f513e) Reviewed-on: https://gerrit.libreoffice.org/25788 Tested-by: pranavk <pranavk@collabora.com>
2016-06-01LOK: calc tile renderingAshod Nakashian1-1/+2
Change-Id: I122922ac18a652dbbce01932eaaad92ded45098d Reviewed-on: https://gerrit.libreoffice.org/25782 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-28bccu#1845 - Calc tile rendering very slowAshod Nakashian1-7/+83
For some reason trying to draw exactly the region of the tile results in black tiles. That is, when the top rows and left columns are not drawn, black tiles show. This patch still reduces the time to render a given tile by limiting the bottom-most row and right-most column to the max necessary. For large tabs rendering the first few 100 rows is very fast (<100ms at most). More work is necessary to reduce drawing time for large sheets (when rendering tiles at the bottom). Still, even those slow bottom-rows are now faster with this patch. Currently the slowest function by far is ScGridWindow::DrawContent. Change-Id: I6e88c7b3a1c483bf43bfcfb38f4b41ffc08a9744 Reviewed-on: https://gerrit.libreoffice.org/25586 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-26widen table-info capacity and count to SCSIZEAshod Nakashian2-5/+5
Change-Id: Id659978e71c7027bc1c58f0bc276da38e1ada4ba Reviewed-on: https://gerrit.libreoffice.org/25488 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22sc lok bccu#1610 - Tiles not rendering in large spreadsheetsAshod Nakashian3-12/+12
Variable max info rows instead of hard-coded allows for collecting info on more rows. FillInfo, however, is extremely slow for large row count (a few thousand) and needs improving. Change-Id: Ib0e475513bc3ba98fff66a5b9d405aeba1057331 Reviewed-on: https://gerrit.libreoffice.org/25293 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22coverity#738785 reorg to silence Uninitialized pointer fieldCaolán McNamara2-55/+66
(cherry picked from commit 3ac0778c0a2b2f693a1029b7b05c1be4f71944a9) Change-Id: If2225e77215e2a6fb6b9e9dfc6021a2c20babe50 Reviewed-on: https://gerrit.libreoffice.org/25292 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22add TODO comment for a bugMarkus Mohrhard1-0/+2
This bug is the first one that was discovered because it is now much easier to see which parts of the code work on cells, pattern areas and whole columns/rows. Change-Id: I8f22bf421298947d65bfc2fc9c986d85169e6545 Reviewed-on: https://gerrit.libreoffice.org/23636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 2c69316037e29db52393d898100e6593a6cd5a24) Reviewed-on: https://gerrit.libreoffice.org/25291 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22extract another function from ScDocument::FillInfoMarkus Mohrhard1-54/+65
Change-Id: Ief094beebbff2bce9f087853cbda6adeeafe07fc Reviewed-on: https://gerrit.libreoffice.org/23635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit b22e51d0c60f959c2db77bd3d23119b53bd87545) Reviewed-on: https://gerrit.libreoffice.org/25290 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22stylistic changes in ScDocument::FillInfoMarkus Mohrhard1-1/+4
Change-Id: I98bb25d414106259a809698941a000d6d0bc35e0 Reviewed-on: https://gerrit.libreoffice.org/23634 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit b27428d2136e67ee7c7449a7db562a957af390d6) Reviewed-on: https://gerrit.libreoffice.org/25289 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22limit scope of another variable in ScDocument::FillInfoMarkus Mohrhard1-2/+1
Change-Id: Ic53bcaa5e33f221a643de4e854990769b5c04a74 Reviewed-on: https://gerrit.libreoffice.org/23633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 8f0668a0e18f4fa01864ede5fa3f66b36bd4ad85) Reviewed-on: https://gerrit.libreoffice.org/25288 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22limit the scope of a few variable in ScDocument::FillInfoMarkus Mohrhard1-21/+17
This makes the code at least a little bit easier to read as we can now see much easier when a variable is used to transport state between loops and when it is just a variable local to a loop Change-Id: Ib92ff1596bda35f9892accc820bc3596bafb7d96 Reviewed-on: https://gerrit.libreoffice.org/23632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 36eec4d179898302578c428564f1b60406c0716c) Reviewed-on: https://gerrit.libreoffice.org/25287 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22extract another function from ScDocument::FillInfoMarkus Mohrhard1-15/+20
Change-Id: Iac607e1fe915c8bc90316508c98855a60117d435 Reviewed-on: https://gerrit.libreoffice.org/23631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 772e66406b90bdb898e73b4fa944a6e55a42683b) Reviewed-on: https://gerrit.libreoffice.org/25286 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22extract another function from ScDocument::FillInfoMarkus Mohrhard1-51/+59
Change-Id: If6f898d514dc454a7f1c5448769a95269e9066d7 Reviewed-on: https://gerrit.libreoffice.org/23550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 5ecda97eeab36ceab022458345f2c61c31ab2d94) Reviewed-on: https://gerrit.libreoffice.org/25285 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22that should not have become part of the previous commitMarkus Mohrhard1-2/+3
Change-Id: Ia116e5f9fdbd34cd1017ec1f2dabf6e581c4c707 (cherry picked from commit 789a3e61785a2458429890e28ad9a37fab8cdade) Reviewed-on: https://gerrit.libreoffice.org/25284 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22extract another function from ScDocument::FillInfoMarkus Mohrhard1-83/+90
(cherry picked from commit a70824f0220b88f3f209266f8e1cba98dc89ca8f) Change-Id: Ifd39ec5ad7aebac532ea7145274005507a5b177f Reviewed-on: https://gerrit.libreoffice.org/25283 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22Refactor ScMarkData for tdf#50916Dennis Francis14-125/+818
Made the container for storing multimarks dynamic. Also let the full row marks to be stored in a dedicated ScMarkArray object rather than in the multimarks container. Unit tests for ScMarkData and ScMultiSel will come in a follow up patch. Reviewed-on: https://gerrit.libreoffice.org/22163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit bc20c6d0f397c0c1aef6ef7d6f750c2f81af8db6) Change-Id: I300ff80bebd6f4f39c284c1e8cb7deece82c1bec Reviewed-on: https://gerrit.libreoffice.org/25282 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-22extract function from ScDocument::FillInfoMarkus Mohrhard1-8/+15
A first step in breaking the function into smaller pieces. Change-Id: I94aeb11fd9c44a7eaa198cb39f208b574ef2758d Reviewed-on: https://gerrit.libreoffice.org/23548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit efea43b4c4f42023a540079866b065068ae8a8e5) Reviewed-on: https://gerrit.libreoffice.org/25280 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-12sc lok: Invalidate the new extended areacp-5.0-35Pranav Kant1-1/+27
Change-Id: I1fa58ca935860ed3c5983f4e6b15c9f7c8feda9b Reviewed-on: https://gerrit.libreoffice.org/24930 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-05-11sc: Add new param, DontTerminateEdit, to .uno:SavePranav Kant1-2/+9
... which determines if current editing mode before save should be terminated with save or not. Change-Id: I49318013f1244eb8681a19ed3da50fbecd336a3d (cherry picked from commit a5a71cea62ac3041006c5e9815ae2317999639ac) Reviewed-on: https://gerrit.libreoffice.org/24895 Reviewed-by: pranavk <pranavk@collabora.com> Tested-by: pranavk <pranavk@collabora.com>
2016-05-10sc lok: Extend the spreadsheet area when we are "close enough" to the end.Jan Holesovsky1-5/+6
We can tweak later what the "close enough" means - for the moment it is 10 columns and 25 rows. Change-Id: I92127a71aa6683c03692e96b9e0da7827942c94b
2016-05-10sc lok: Move the handling of the area back to GetTiledRenderingArea().Jan Holesovsky5-13/+32
Change-Id: I4dbfc090ab43065c719f83b5355cd9832ee4d1e3
2016-05-10sc lok: set a limit for tiled column and rowHenry Castro9-15/+86
In the tiled rendering case, not all column and row are rendered, so it was set a limit for tiled column and row. However, when a client request to move the cursor beyond the limit, the tiled column and row is updated and they are rendered later. Change-Id: Id0de533ebf7b3c6e0343f9dc15336150729299fa
2016-05-10LOK: fire SET_PART event when Calc page is changedAshod Nakashian1-0/+5
Change-Id: I9a2ed653bcb6afe803b781fc686c02f817d84e75 Reviewed-on: https://gerrit.libreoffice.org/24818 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-07sc lok: Add initial test for .uno:CellCursorAndrzej Hunt1-5/+2
This should be extended with checking that we receive "EMPTY" when there is no cursor shown - that would require e.g. simulating keyboard input to hide the cell cursor. Reviewed-on: https://gerrit.libreoffice.org/19828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andrzej Hunt <andrzej@ahunt.org> Tested-by: Andrzej Hunt <andrzej@ahunt.org> (cherry picked from commit 2f13f051c3c39f77d5f65ff0e3f4a476ccb95f1a) Change-Id: Ia7be5ec3e158f21967b4c307ac10abb2b5e2a56a Reviewed-on: https://gerrit.libreoffice.org/24724 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-07Let LIBO_INTERNAL_ONLY imply LOK_USE_UNSTABLE_APIMiklos Vajna2-2/+0
(cherry picked from commit 958b9a7fbdd58fdce762021917155c58fbb90d18) Change-Id: Ifbed5e534ba79d32b7188bb7fb7108338b6e124d Reviewed-on: https://gerrit.libreoffice.org/24722 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-02don't allocate and destroy a LocaleDataItem for each cell, tdf#97989Markus Mohrhard1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/23480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 7da3a53958695bfb1405fa513f71beddc6c0ecb7) Change-Id: I8bcdc7a42c87d17fde1dc9c79bc361bb625f992b
2016-05-02don't sanitize value to an insane value, tdf#97863Markus Mohrhard1-1/+4
Change-Id: I0e4de6b676fb61536dadefc96a719cf50be128ed (cherry picked from commit 6aa836329d17bf0aca4aead6bb9c35a6783ec215)
2016-05-02we need the position in the formula converter, tdf#99093Markus Mohrhard1-23/+37
Reviewed-on: https://gerrit.libreoffice.org/23884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit e214df32fb3637bd7810a299fb8b38810b1a3874) Change-Id: Ic3dd13aa4d4b8190b78f3e6f1cdda844e39cc719
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-16 22:06:17 +0000