summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2022-06-10tdf#149503: Check size of vectorsXisco Fauli4-1/+29
Crash introduced by 41f95c4a35a6335e9edb2f51c11d136d88bd0749 "Remove SC_DPOUT_MAXLEVELS limit in Pivot" This brings back the old behaviour and now the "You cannot change this part of the pivot table." message is displayed again Change-Id: Ibad84c0a279d7d67b709b7e311ac875739cdb210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135578 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-06-10new loplugin:moveitNoel Grandin2-3/+3
look for local variables that can be std::move'd to parameters off by default, since it doesn't do proper data flow analysis Change-Id: I3403a0fcffd165bdea6a772528bc53995c5fdb40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-10Resolves: tdf#148072 Restore sheet-local names for Undo of CutEike Rathke1-5/+13
Undo of Cut uses CopyToTable() and not UndoToTab() as Copy does, so copy the sheet-local names also *from* Undo and not only *to* Undo. And mark for ScAreasChanged broadcast. Change-Id: Ib07f711a7d407dafdf548873291f1ccc81b85d47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135568 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-10tdf#135346 clear page row map to avoid invalid "hidden" flagsTomaž Vajngerl1-0/+4
With the print range cache surviving a longer time, we can get to a state where we reuse the page row map (m_xPageRows) that had older "hidden rows" flags still set, but they aren't valid for our new recalculated ranges. The result for this is that in the bug document, the print preview is empty (as hidden flags for the rows was kept but not valid anymore). We don't really benefit from keeping this map, so we can just clear it when we need to recalculate the print ranges. Change-Id: I1f8de889d6f006e700c6f21ef5bfa52a36bcdfc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135567 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-06-09Resolves: tdf#142368 drop popover on ControlLoseFocusCaolán McNamara1-2/+2
which is what appears when the Control derived inputbar loses focus while the main window losing focus gives WindowLoseFocus Change-Id: Iae9a2874c3dd513a1a092a18846858f819542370 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135533 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-09tdf#149484: subsequent_filters: Add unittestXisco Fauli2-0/+15
Change-Id: I867696100d79f599a58e8cc5a64723cec3cea2b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135525 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-09tdf#149414 change Format Object label for Calc and ImpressSeth Chaiklin1-1/+1
The label for Calc was Format > OLE Object (using .uno:ObjectMenu), while the label for Impress was Format > "Object and Shape" (using .uno:FormatObjectMenu). This patch (a) changes the label of .uno:FormatObjectMenu from "Object and Shape" to "Text Box and Shape" (to bring it in line with Writer). This change appears immediately in Impress, and (b) changes the .uno:ObjectMenu in Calc to .uno:FormatObjectMenu, which also gives the "Text Box and Shape" label, which is also more appropriate for its submenu. Kept the same keyboard accelerator "o", which was used both in Impress and Calc. Change-Id: Ifcf7b953b6bed262d630f7a07bf1f5000ee33aa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135162 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-06-08Fix typosAndrea Gelmini1-1/+1
Change-Id: If282a3a9f68de2cf0f1576ea34b56b9316f03ef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135470 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-07tdf#129674 Add GoTo Sheet commandLaurent BP14-7/+442
Insert command in menu Sheet > Navigate (alongs with To Previous/Next Sheet) Use .uno:JumpToTable command from Navigator Use its own Go To Sheet dialog Add a Search entry to type partial name of sheet Menu translation missing? Change-Id: I16b8b56a688c8396159617f04a2a7e034721ce31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134714 Tested-by: Jenkins Reviewed-by: Laurent Balland-Poirier <laurent.balland@mailo.fr>
2022-06-07Resolves tdf#146928 - Redesign charnamedialogHeiko Tietze3-25/+31
Dialog was changed in d73602dc51aa8829fc88e5e67e2b0c4da6b8f715 to fit vertical size on small screens by placing Western/CJK/CTL into a notebook. But for CJK and CTL it's required to have Western fonts visible in parallel. * dual solution for western with nocjk and cjk dropped western scales to the dialog width if no CJK nor CTL is enabled * CJK and CTL placed in a notebook, Western as well for proper alignment * font names are presented in lists but size and style per simple dropdowns * info text sized at 80% * variables renamed to keep track of controls (old names kept in l10n descriotion) * UITests adjusted for variable names and tab positioning Change-Id: I45b40e9bc37565f6364f1dfc1b5d837270fe4644 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134666 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-06-06ScSingleRefData::TabValid: for absolute reference take sheets into accountEike Rathke2-4/+4
Change-Id: I56e7e34f127345e2633b5bef07c2783ed8ffbbfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135456 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-06Resolves: tdf#148163 Preserve names of bad cell reference input againEike Rathke2-3/+3
A regression of commit e247262327d04ad9933f4af354050f4420c6e303 CommitDate: Tue Jul 30 23:49:55 2013 -0400 More on avoiding direct access to data members. that changed, for example, invalid sheet references - aRef.nTab = MAXTAB+3; + aRef.SetTabDeleted(true); The then following commit 8a19af57bbcc57a02a7d87c6408d1e3212a6deba CommitDate: Tue Jul 30 23:50:03 2013 -0400 Now nobody accesses reference members directly. Make them private. changed ScSingleRefData::Valid() - return nCol >= 0 && nCol <= MAXCOL && - nRow >= 0 && nRow <= MAXROW && - nTab >= 0 && nTab <= MAXTAB; + return ColValid() && RowValid() && TabValid(); without taking the deleted flags into account, where previous to commit e247262327d04ad9933f4af354050f4420c6e303 nTab > MAXTAB fulfilled the condition of not valid. This makes it necessary to adjust the TestFormula::testFuncRangeOp() test case that relied on the broken behaviour. Change-Id: I42e769ca0d56a2eb786bb6f65917f0c15d082763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135453 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-06Fix typosAndrea Gelmini1-1/+1
Change-Id: I36d81be6e591830ee3762a0d43357dbacd68ad93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135439 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-05restore %PRODUCTNAME to accessible descriptions that need themCaolán McNamara7-16/+11
The original problem was that %PRODUCTNAME wasn't replaced for accessibility descriptions (which are reused for extended tips) under gtk. Universally querying all a11y descs on load to potentially replace %PRODUCTNAME in a11y descs at runtime led to tdf146971 which was a huge startup slowdown. The half way 7.3 fix was to leave a11y descs alone, but do the replacement when querying for the extended tip case. So the extended tooltips were ok, but screen readers would still say a raw "%PRODUCTNAME" text, hence the rewording effort to remove %PRODUCTNAME from the a11y descs entirely for 7.4. But there is now a few cases where some options paths exists in the a11y descs which is not exactly correct wrt to the text shown in the options dialog. Reworking the options dialog to not have %PRODUCTNAME there at all and updating everything to fit that sort of change would not be popular. So move the cases where a11y descs really should have %PRODUCTNAME in them out of the .ui files and into .hrc files and use specific set_accessibility_description calls for them via ResID which will do the %PRODUCTNAME replacement automatically. Hopefully the a11y runtime cost for just this handful of cases is negligible in the overall scheme of things. Change-Id: Ieb17d26fd581cd5804a52b371b3bb5ea43023aa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135432 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-05drop stray space before full stopCaolán McNamara1-1/+1
Change-Id: I50013a672cc953822845a2e02d038e75f51ef457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135431 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-04Function Wizard: increase display length of array resultsEike Rathke1-1/+1
So if the dialog is widened the Structure tab can display more details. Change-Id: I857ca525fea8badc229328ab4c822b7de0b2cc0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135369 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-04Function Wizard: use actual array separators to truncate resultEike Rathke1-4/+7
... instead of hard coded ',' and ';'. And truncate / append "..." after separator, not at. Change-Id: I62f8c00f108165102d3b6a8b73b82774b8973a67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135370 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-03tdf#149378: sc_uicalc: Add unittest, follow-upXisco Fauli1-0/+24
This commit also tests - 6079bf6879c4baf144b68ef459d825412ecea697 "Add binary operators to ForceArrayReturn handling, tdf#149378 follow-up" - a15ce15709acee3b46fb9f7d6836c57f6e1ef9a7 "Propagate ForceArrayReturn only for Value parameters, tdf#149378 follow-up" - bac202275b1bf1abe4277daf35f74ff973c23483 "Propagate inline array only for Value parameters, tdf#149378 follow-up" based on their commit description Change-Id: Ie69868460ae87a67b31e0bd30a66644e89ea60ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135368 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-03tdf#149378: sc_uicalc: Add unittestXisco Fauli1-0/+16
Change-Id: Ie92b22ce664d667892e864598158618a0ee4ae6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135362 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-03elide some makeStringAndClear() classNoel Grandin13-24/+37
when we are passing the result to a string_view, it is pointless. Change-Id: I5af990cbe1a8f2d5b19fea9a031d7d64aeba1c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135329 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-02tdf#148087 assert editing a cell with OnSelectionChange macro breakpointNoel Grandin1-0/+4
assert was introduced in commit e1972743d692c8d8611912c31aae2cb08ae7636d Author: Noel Grandin <noelgrandin@gmail.com> Date: Sun Sep 5 15:01:44 2021 +0200 be more disciplined with SetUpdateLayout on editengine We want to restore UpdateLayout when we're done doing layout, we should not just leave it FALSE Change-Id: Ic0431ffc3c66d0d02bfd10c323b18383f52dbc95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132209 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-02std::move SfxPoolItem into SfxItemSet where possibleNoel Grandin5-21/+16
found with the help of a temporary loplugin (which i have put into the store/ folder) Change-Id: Ide40d09bef6993ace50039a8fd0439b7e29c09a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135288 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-02Resolves: tdf#149378 Force array input if outer function returns array/matrixEike Rathke3-6/+34
So the result will actually display as full matrix, or in the cell range marked prior to input, instead of just the top left element in one cell, without having to close the input with Shift+Ctrl+Enter to force array mode. The previous behaviour can be forced by pre-selecting/marking one cell, which also worked previously when closing as array input. Change-Id: I81c079ce02e0c8d0536617ca6882fb470a352441 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135278 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-01tdf#90579: sc_uicalc: Add unittestXisco Fauli1-0/+37
Change-Id: I96b1b639c766664e14a50ab8a267eb490d7239a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135274 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-01Remove nonsense comment, function *is* usedEike Rathke1-1/+1
Change-Id: I514b38c0770deb85ca995aed1e8e454eb4f23e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135251 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-01pass ScRange around by valueNoel Grandin15-138/+129
it's a very small object, and trivially movable. No need to allocate it separately Change-Id: I0adf947433e73a425f39004297c450a93ac4e5f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135216 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-01no need to allocate guards on the heapNoel Grandin1-2/+2
Change-Id: I66491a057f082a970158504474b678dbb4decf50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135228 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-01The return value of those getLength functions is guaranteed to be non-negativeStephan Bergmann3-4/+6
...so use o3tl::make_unsigned when comparing it against an expression of unsigned integer type, instead of casting that expression to a signed type Change-Id: Ic47c6d96919b2aba2d16ce6d1a2a8e4c5761a480 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135219 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-01MoveCursorAbs: it is cheaper to check for marks first and then formula modeEike Rathke1-3/+4
... so repeated travelling with cell cursor will be less affected. Change-Id: I3f42356e66b2ec8acf60c0e0c777f8c34b9a952a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135211 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-05-31MoveCursorAbs: do not reset selection marks while editing a formulaEike Rathke1-2/+3
i.e. when moving the cursor for reference selection, so an existing mark is preserved for Alt+Enter or Shift+Ctrl+Enter. Change-Id: I3a73145b4e3e299fa9eb28e2198338e76ffe5093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135202 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-05-31Use some range-based for loopsStephan Bergmann3-15/+15
Change-Id: I26ad6ff194742b69cb6048c48fa01de7715865ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135191 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31InsertMatrixFormula: correct references for across sheets array formulasEike Rathke1-15/+8
Inserting an array/matrix formula across two or more selected/marked sheets generated wrong matrix offset references starting with the second sheet, pointing to the top left of the first array formula. Only the top left cell of the inserted formula on each sheet displayed the correct value. Deleting the array formula on the first sheet then left all matrix offset references on the remaining sheets with #REF! errors and those cells could not be deleted anymore because their original parent cell was gone. Change-Id: If5d53311f9aabdcd7432ff26ab555bb91b0b121d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135147 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-05-30fix setting cell borders for unallocated cellsLuboš Luňák3-6/+77
First of all, it should not be clamped to allocated columns. Second, 06d3294502413a231e5c5265609862c7f67a2f2b incorrectly handled unallocated columns by setting the attribute for all rows, instead of handling the inner ones differently. Change-Id: I3115b314971f8c152cbdeda674863a8a78ee12eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135131 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-30first arg of ApplyFrame is never nullLuboš Luňák2-16/+16
e4008dc0c3b43c9eacdd88511075be2b88 did this for ApplyBlockFrame() but didn't chagne ApplyFrame() which is only called from there. Change-Id: I9f1dce3dc7fda23b42e90432c13dfca0aa7f267e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135130 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-30these ScTokenArray can be stack allocatedNoel Grandin5-18/+18
Change-Id: I53d370bf6bc5133b7279e569516fc5a0a5ede1b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30no need to use unique_ptr for tokens in ScChartListenerNoel Grandin4-24/+23
since vector is a moveable type, and we always initialise this field Change-Id: Icd598ad942dcfbdf77c7c8eef9fa0b6b7c6fe1be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135134 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30in ScOutputData::DrawFrame, we can skip the intermediate containerNoel Grandin1-5/+3
and just feed the data in as we create it Change-Id: I5112e0b61bc4f4976978d5e4724053ab9ffc97e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30sc uitests: Cleaning up unused variablestagezi106-325/+72
Removed unused variables in the 'with' statement as the syntax allows the statement to be used without a variable. Removed variables like 'xcomments' and 'xseedspin', which seem to have been copied and not cleaned up. Removed variables 'gridwin' and 'xCalcDoc' if 'gridwin' is not used. Change-Id: Ia97692a0fb2e2af1d2693e09ac8f7c614360ade8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135042 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-28use the new SfxWhichIter::GetItemState featureNoel Grandin1-1/+1
to speed up other places that are iterating over SfxItemSets Change-Id: I646bae12420d15e67effdd279e071cdf8a8afffd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-28try to range-reduce even COUNTIFS if not matching empty cellsLuboš Luňák2-50/+132
It's possible to do reduce range of COUNTIFS to non-empty data too, since empty cells cannot contribute to the result, as long as the criteria do not require matching empty cells. Without this queries like =COUNTIFS($A:$A,...) can spend most of their time clearing and searching the vConditions vector that's big and not useful for the trailing empty cells in that column. Change-Id: I8d1e7977f172ac9b2cf84af3f982e945be3cb46c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135049 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-28fix COUNTIFS when matching empty cellsLuboš Luňák2-2/+43
Change-Id: I8577324c0194d594a6df0b51431729b30ac8165c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135047 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-27tdf#132293: Removing unused imports from uitests files.tagezi13-30/+21
This is the final cleanup of imports in the sc module. 'pyflakes sc' is now empty. It seems, the most imports were copy-pasted from a file to a new one. Additionally, the import block and surrounding area made more readable. Change-Id: I8c4dff1007b9954c35795a7c8a940e8fcf8d7f93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135036 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-26cid#1504573 Dereference before null checkCaolán McNamara1-1/+1
since... commit 8b4b852a35149b1cfffc681cbb4f57d4c0b671b3 Date: Mon May 23 15:48:41 2022 +0200 Advanced Diagram support: Isolated IDiagramHelper, selection visualization we've already derefed pObj so can drop that check Change-Id: I9bdab5c069405c0015f74e4621e7b37fbbed2dd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-26WIP: dunno about "Hodler"Andrea Gelmini1-1/+1
Change-Id: I9fbee006237ccb70e31109023cf46b21aec325d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134668 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-26tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktopSiddhant Chaudhary1-2/+0
Removed a redundant assert on returned value of `MacrosTest::loadFromDesktop`. Change-Id: Ia318cd770b120baff87e7cf5f01120beaf112794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134957 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-05-25directly instantiate IndexedPropertyValuesContainerNoel Grandin3-9/+10
without the overhead of the UNO service engine Change-Id: I4a02fda2b3c92a897634374bf72cfffee4f531f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-25tdf#148467 Move sparklines items to Insert/Format main menuRoman Kuznetsov1-10/+10
Change-Id: I2606fdd6301e5d1cb1e855d79a971762ed2d835d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133608 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-05-25check column again when going to the next Calc sheetLuboš Luňák1-2/+2
Since the number of allocated columns may be lower in the next one. Change-Id: I92eb4642ed01ff6c858a250aefcfa36c565103d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134932 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-25Advanced Diagram support: Isolated IDiagramHelper, selection visualizationArmin Le Grand (Allotropia)2-8/+5
Moved and isolated IDiagramHelper to own file to get SdrObjGroup smaller and less dependent again, all places adapted. isDiagram() now available at SdrObject directly, adapted and have less places which need to cast for SdrObjGroup for check. Started to add SdrHdl/selection visualization to seleced Diagram. Only as a start, will need to be extended to look good/better, plus evtl. functionality in handles/UI. Corrected error(s) found by failing UnitTests More clang-notes (static, namespace) I nneeded to follow Change-Id: If4675b3270d3ee30259fce49deb017dbbaf5c0c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134825 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-05-24tdf#145248 don't start a drag if actively selectingCaolán McNamara1-1/+2
Change-Id: I00565adbb32a6d9109a75548a544e79ba1951650 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134881 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-20 12:43:36 +0000