summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2017-11-24ofz#4406: don't increment ScCompressedArray::Iterator past endCaolán McNamara1-7/+12
Change-Id: I2adc204722a6143384bab8aecd16bed42cb5016a Reviewed-on: https://gerrit.libreoffice.org/45192 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-24drop unused ATTR itemsNoel Grandin6-188/+33
the table autoformat stuff does not use these values at all, it just writes the internal details of PoolItems in a pre-determined order Change-Id: Id6d8ae7508a8d19f5fd1e70f9a428d324082d3bf Reviewed-on: https://gerrit.libreoffice.org/45199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-24consistently use sal_uInt32 for number formats in scNoel Grandin56-144/+141
instead of a mix of short/sal_uLong/sal_uInt32 Change-Id: Ie5bd26e1a6f716c0c4e174a6d560827084b3f421 Reviewed-on: https://gerrit.libreoffice.org/45159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23Document, and simplify the two uses of ScMutationGuard.Michael Meeks4-47/+66
Creates ScMutationDisable - used to ensure that no core data structure is mutated below this guard in any thread. This can also be used to disable access in the same thread now. Change-Id: I7e4e98d8ff986490ccd5064b3b9af56acd877b49 Reviewed-on: https://gerrit.libreoffice.org/45119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-23related tdf#108757 small enhancements for speed upSerge Krot3-11/+13
- no strings reallocation - faster for-loops Change-Id: I98a355eb3bcb48219afd6334615c9c092ed1a352 Reviewed-on: https://gerrit.libreoffice.org/45142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-23Add debug output operator<< for ScRangeListTor Lillqvist1-0/+17
Change-Id: I55f16428bbadd45d302ac31df9c1a691730c4a49 Reviewed-on: https://gerrit.libreoffice.org/45158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-23crashtesting: crash loading fdo41403-1.xlsmCaolán McNamara1-1/+1
regression since... commit 3af8a4faf5e20ccae2386052697713da160afb16 Date: Wed Nov 15 13:10:40 2017 +0300 tdf#113861: Less aggressive expansion of chart headers. pre-change code had... FormulaToken* pToken = it2->second; if (pToken && nRow>=nHeaderRowCount) check, so restore that check for presence of FormulaToken Change-Id: Ia1b301e4f7fdf447b08de7fb22bd7fde8735bd52 Reviewed-on: https://gerrit.libreoffice.org/45155 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23Resolves: tdf#113962 save detected filter outside file dialogCaolán McNamara1-1/+1
different file dialog impls work differently so store the detected filter outside the file dialog Change-Id: I144d8df06e5265fed8f11b284a2f40c17c3e09ef Reviewed-on: https://gerrit.libreoffice.org/45166 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23Move the need for several ugly const_casts deeper down to just one placeTor Lillqvist4-7/+7
Change-Id: I2cdd66b9819f070548c2a0af7388d9bfbd3689c1 Reviewed-on: https://gerrit.libreoffice.org/45144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-23TypedWhichId create custom get methods in ScPatternAttrNoel Grandin36-306/+263
Change-Id: Iaa326332f5806477dd81463e6b6004a962bac934 Reviewed-on: https://gerrit.libreoffice.org/45128 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23tdf#50746 add paste unformatted to menu and context menuYousuf Philips2-3/+6
also unified menus and context menus in writer and calc Change-Id: I929df7a0fe2be7b8bf58cf048e53536ea89d5c9c Reviewed-on: https://gerrit.libreoffice.org/45095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-23Disabled slot with Put leaks entry (tabvwsha/sc)Julien Nabet1-9/+9
Same as https://cgit.freedesktop.org/libreoffice/core/commit/?id=21dde7a09e2cfe7b48d2fec1edc7a94fa94af5c3 Change-Id: Ie4e3fcf097a6aa7b9a019947a677701723f98bf3 Reviewed-on: https://gerrit.libreoffice.org/45052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann1-1/+1
...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: https://gerrit.libreoffice.org/45122 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23tdf#45904 Move _XScenarioEnhanced Java test to C++Jens Carl1-1/+39
Change-Id: Ibc99dc0d50e612bc6cdebaf5f9c5f828e5af859f Reviewed-on: https://gerrit.libreoffice.org/45123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-23tdf#45904 Move _XSheetAuditing Java tests to C++Jens Carl1-3/+17
Change-Id: I057447494ff488546d43d2d3068a65d5c0d402e0 Reviewed-on: https://gerrit.libreoffice.org/45120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-23TypedWhichId for sc constantsNoel Grandin51-472/+418
Change-Id: I25a07d84ae24fdd3b4fbd303beea755169eb9acb Reviewed-on: https://gerrit.libreoffice.org/45084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin9-18/+18
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Avoid using the hideous std::stack -> deque inside ::InterpretMichael Meeks1-4/+4
dequeue loves to allocate and free memory crazily, vector is much saner. Change-Id: Idcd2c1d693594f280ce94423161651502f25dc2d Reviewed-on: https://gerrit.libreoffice.org/45086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-22Don't re-create the interpreter context for each row.Michael Meeks1-1/+3
Change-Id: I272c9dc09806d47add26866f517e6ea07282c35f Reviewed-on: https://gerrit.libreoffice.org/45087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-22Follow our naming conventions, tdf#39593 follow-upEike Rathke2-12/+12
Change-Id: Iee95b5bf0dd42169447163a41be5b2aa1899e83c
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann6-8/+8
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22clang-format on non-blacklisted file interpretercontext.hxxDennis Francis1-11/+8
which is a new header file introduced in calc formulagroup threading work. Change-Id: I8203ce392b36581f64457edb52449df3e84fb216 Reviewed-on: https://gerrit.libreoffice.org/45080 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-22turn some eof checks to eof or errorCaolán McNamara2-3/+3
Change-Id: I4592d7aa86c2cc2f420bccc622ffb95aa5cefa17 Reviewed-on: https://gerrit.libreoffice.org/45077 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22replace check of eof and GetError with goodCaolán McNamara1-6/+2
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291 Reviewed-on: https://gerrit.libreoffice.org/45076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara6-14/+14
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22good() includes !IsEof() alreadyCaolán McNamara1-1/+1
Change-Id: I6eddd347333638c0a8ea924e6062f8e4d379a20e Reviewed-on: https://gerrit.libreoffice.org/45074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22tdf#39593 deduplicate code in ScOutputDatatagezi2-139/+41
Change-Id: Ie7efcdf23e65b2047af7972756c2ba11cc178672 Reviewed-on: https://gerrit.libreoffice.org/45064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-22ofz#4361 Integer-overflowCaolán McNamara1-4/+15
Change-Id: I7b41a53622e2e87dc0998a4a181bb8e49ef8d277 Reviewed-on: https://gerrit.libreoffice.org/45046 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22There appears to be no reason to ignore macros in these parts of...Stephan Bergmann1-1/+1
...loplugin:unnecessaryparen Change-Id: I473a1e16cf9f485a61af5477aca22798996253a3
2017-11-22Fix typoAndrea Gelmini1-1/+1
Change-Id: I591214b246f7702e52f71b95cdc2255bc296224b Reviewed-on: https://gerrit.libreoffice.org/45063 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-22TypedWhichId for SDRATTR* constants (3)Noel Grandin2-3/+3
Change-Id: Iea72cb3a4bbf693096de46269f58259b5952eedb Reviewed-on: https://gerrit.libreoffice.org/45024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin1-1/+1
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21ofz#4305 do not read past end of fileEike Rathke2-2/+11
Change-Id: I7e048c012296fc080434e527c533ea987184699b
2017-11-21Fix typosAndrea Gelmini1-1/+1
Change-Id: I4713dd5c590d331e599b7e9ab88f5cc65e8d7b87 Reviewed-on: https://gerrit.libreoffice.org/45045 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-21tdf#113970 : blacklist vlookup/hlookup for threading...Dennis Francis1-1/+3
... until the root issue is fixed. Change-Id: I8969a78fe252e0b12c5703519641f008d33dc02c Reviewed-on: https://gerrit.libreoffice.org/45039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
2017-11-21coverity warningsCaolán McNamara1-1/+2
Change-Id: I456210188ab96e6be03e65c94eedb348cc93a8e1 Reviewed-on: https://gerrit.libreoffice.org/45023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-21Introduce and use ScCellShell::HasClipboardFormat(), tdf#50746 follow-upEike Rathke3-15/+11
Intead of gathering all possible formats just to check one.. Change-Id: I80f3a2c957492c9f72084c69b867aaccfbdd0530
2017-11-21tdf#113571, tdf#32213, tdf#50746: Make "paste unformatted text"Serge Krot1-2/+27
Added check for availability of the SotClipboardFormatId::STRING_TSVC that could be used instead of SotClipboardFormatId::STRING. Change-Id: I03de4500affb71270b501b12c14287037cea7c3c Reviewed-on: https://gerrit.libreoffice.org/44975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-21Adapt documentation to realityEike Rathke1-1/+5
Change-Id: Ia773da1fb1c0af0855321ce88c488a5b86c7cf92
2017-11-21Keep number format on string cell content Undo, tdf#103234 follow-upEike Rathke2-0/+8
Change-Id: I18c281211e6eeb4816da13972c360df85d577491
2017-11-21Invert logic of ScSetStringParam::* enum value checks, tdf#103234 follow-upEike Rathke1-2/+10
In preparation for adding a new enum value to keep existing formatting in any case. Change-Id: Ic15a900adba0281d1267d95f821e1e898f80f566
2017-11-21WaE: C4334: '<<': result of 32-bit shift implicitly converted to 64 bitsTor Lillqvist1-2/+2
Change-Id: I6e30bd1b77f0f7df01571c9f497cbde1380e73be
2017-11-21Move token-cache for doubles to ScInterpreterContext...Dennis Francis13-35/+47
...from ScInterpreter and in the s/w interpreter, create a ScInterpreterContext for each thread for passing into per thread ScInterpreter constructor. Change-Id: I4e0abce043c7e1e70859efb2e5001fc284f416a9
2017-11-21Type check the tokens before reuseDennis Francis1-2/+23
If the exisiting token is of wrong type, create and use a fresh new token instead. Change-Id: I348b0972306497dfe7eae0655c9b93d5830cb740
2017-11-21cache FormulaToken for doublesDennis Francis2-6/+43
Change-Id: Ic0b4dff6f03ef3f88bd150e798fa2d83dfb0f486
2017-11-21halve thread count if HT active for group interpreter tooDennis Francis1-0/+6
Change-Id: Iacc93122191152183127500a4172358a14e96c8b
2017-11-21halve the number of threads if HT is activeDennis Francis1-0/+5
added hasHyperThreading() function to tools::cpuid to detect hyperthreading. Change-Id: I13fab4b6c649e681c329b7e3f4c9f36bda879d84
2017-11-21Avoid ScTokenArray thrashDennis Francis1-9/+34
Allocate ScTokenArray object only once per worker thread, fill it for the first row/cell and reuse them for subsequent rows/cells if possible. Change-Id: If8f20da618938d0e189224f189b4763815702e10
2017-11-21Thread the software interpreterDennis Francis5-102/+221
Also introduce new state ScFormulaVectorState::FormulaVectorEnabledForThreading to indicate that using the “traditional” vectoring is disabled, but threading should be tried. Change-Id: I552d9e29e1ab9e5721534e07f4a45fdd5a23f399
2017-11-21Add OFFSET to blacklist for threaded calculationTor Lillqvist1-0/+1
Change-Id: Ia1aaf40aa4e8e6f41ca190272365528bf37bf130
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 12:04:06 +0000