Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I152f6358e505d7a480e157bd49613e0bb496e163
Reviewed-on: https://gerrit.libreoffice.org/44748
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I374873eed5e89c0788869150187219078d22f986
Reviewed-on: https://gerrit.libreoffice.org/44757
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I18143d96f49ea4f4b80ae89df33d2963bb20e125
Reviewed-on: https://gerrit.libreoffice.org/44747
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
use a strong-typedef template to give which IDs a type, which we can
carry around to do a
(a) little bit more convenience when Get()'ing them
and
(b) a little bit of enforcement of which PoolItem subclass each ID uses
Fix a bug in casting EE_PARA_BULLETSTATE to the wrong subclass
in AccessibleEditableTextPara::_correctValues
Change-Id: I015ce8b3b0f6d21308af182afa3caf122c877a5b
Reviewed-on: https://gerrit.libreoffice.org/44587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8bdced3fa572074aedabdcfce841adf525ae8b81
Reviewed-on: https://gerrit.libreoffice.org/44710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
|
|
Change-Id: I12c92ecc270e65cb99e38e9179cf354a8c0708aa
Reviewed-on: https://gerrit.libreoffice.org/44633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
A single cell may contain embedded line breaks and tabs,
copy/pasting multiple cells may not.
Change-Id: Iae58f5c6b5330b327acfb50a37e9d210e72de7c7
|
|
In [54]: open("sc/qa/unit/pivottable_filters_test.cxx",'r').readlines()
---------------------------------------------------------------------------
UnicodeDecodeError Traceback (most recent call last)
<ipython-input-54-39091a82db4d> in <module>()
----> 1 open("sc/qa/unit/pivottable_filters_test.cxx",'r').readlines()
/usr/lib/python3.6/codecs.py in decode(self, input, final)
319 # decode input (taking the buffer into account)
320 data = self.buffer + input
--> 321 (result, consumed) = self._buffer_decode(data, self.errors, final)
322 # keep undecoded input until the next call
323 self.buffer = data[consumed:]
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 1648: invalid continuation byte
In [55]: open("sc/qa/unit/pivottable_filters_test.cxx",'r',encoding="cp1252").readlines()
Out[55]:
['/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */\n',
'/*\n',
...
Change-Id: Iad48bdf3502fcb6340e358249781a39d50f80c85
Reviewed-on: https://gerrit.libreoffice.org/44708
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Ib9beadaea1bc6521faf7d8080d301e4b5451fb1d
Reviewed-on: https://gerrit.libreoffice.org/44685
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I707631718c30d4503ae675f3679038705371f969
Reviewed-on: https://gerrit.libreoffice.org/44672
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Tested-by: Jens Carl <j.carl43@gmx.de>
|
|
For intra-Calc on-cell pastes using the paste special toolbar
button the SotClipboardFormatId::STRING_TSVC format can be used,
which preserves embedded line breaks and tabs by enclosing such
content in double quotes and escaping quotes by doubling them,
similar to CSV. This differs from the IANA
text/tab-separated-values MIME type (see
https://www.iana.org/assignments/media-types/text/tab-separated-values)
that does not allow quoted fields or embedded line breaks or tabs.
The text/plain "Unformatted text" format now again (after the
change with commit cdcd262ea4aa3c3e407b14ed533e514f75de2d3a for
tdf#32213) results in unquoted/unescaped content as expected for
external pastes.
A follow-up commit probably should distinguish whether the source
is one single cell or multiple cells and for multiple cells use a
strict TSV (with embedded line breaks and tabs changed to spaces)
if a simple "Unformatted text" is requested, which always uses
tabs as field separators anyway.
Further enhancement could be to offer strict
text/tab-separated-values and also text/csv at the clipboard if
there are applications that actually handle these MIME types.
Change-Id: Ica60f256e26867d854639823c62eedbf13eb4d4b
Reviewed-on: https://gerrit.libreoffice.org/44686
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
This follows up on https://gerrit.libreoffice.org/44295
Change-Id: Iac8351161a5e0d79a61fbb06d96985f92db68e3c
Reviewed-on: https://gerrit.libreoffice.org/44626
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Also, use self-explaining variable name for argument NoSwitch.
Added use of argument NoSwitch to unit test document.
Change-Id: I801d4dbd489898b28543e0eb46f74717671ea03a
Reviewed-on: https://gerrit.libreoffice.org/44647
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
if, before lcl_UnicodeStrNCpy is called, aSymbol contains embedded
nulls then the aSymbol.getLength() and the mnRangeOpPosInSymbol value
derived from an earlier aSymbol.getLength() include the range after
the embedded null, while lcl_UnicodeStrNCpy stops at the first
embedded null leaving cSymbol with uninitialized value that
are later read from it.
Conditional jump or move depends on uninitialised value(s)
at 0x23BFBCA0: ScCompiler::IsReference(rtl::OUString const&, rtl::OUString const*) (compiler.cxx:3275)
by 0x23BFFF4C: ScCompiler::NextNewToken(bool) (compiler.cxx:4248)
by 0x23C00D20: ScCompiler::CompileString(rtl::OUString const&) (compiler.cxx:4419)
by 0x23A29FAF: ScFormulaCell::Compile(rtl::OUString const&, bool, formula::FormulaGrammar::Grammar) (formulacell.cxx:1118)
by 0x23A278B7: ScFormulaCell::ScFormulaCell(ScDocument*, ScAddress const&, rtl::OUString const&, formula::FormulaGrammar::Grammar, ScMatrixMode) (formulacell.cxx:656)
by 0x23772EC3: ScColumn::ParseString(ScCellValue&, int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam const*) (column3.cxx:1729)
by 0x2377354B: ScColumn::SetString(int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam*) (column3.cxx:1851)
by 0x23AE2B97: ScTable::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (table2.cxx:1369)
by 0x23897045: ScDocument::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (document.cxx:3377)
by 0x1F35F41C: ScEEImport::WriteToDocument(bool, double, SvNumberFormatter*, bool) (eeimpars.cxx:400)
by 0x1F366F3B: ScFormatFilterPluginImpl::ScImportRTF(SvStream&, rtl::OUString const&, ScDocument*, ScRange&) (rtfimp.cxx:34)
Change-Id: Iefc6be6c3a383bd9b3cdeaa896c07e24e5100dc7
Reviewed-on: https://gerrit.libreoffice.org/44658
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Ic0797a988b7135927a53ca9f16c8bc30d24feef5
Reviewed-on: https://gerrit.libreoffice.org/44673
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I32d07ba85f4a37a10eaf03d251d41b9e71d34c93
Reviewed-on: https://gerrit.libreoffice.org/44660
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I2a10e087a776ac96b3193226610577227d2492a8
Reviewed-on: https://gerrit.libreoffice.org/44655
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
|
|
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91
Reviewed-on: https://gerrit.libreoffice.org/44654
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
|
|
Do like ScDataTableView::MouseButtonDown
188 void ScDataTableView::MouseButtonDown(const MouseEvent& rMEvt)
189 {
190 if (!rMEvt.IsLeft())
191 return;
...
See bt:
0 0x00007fffc971096c in Point::X() const (this=0x0) at /home/julien/lo/libreoffice/include/tools/gen.hxx:77
1 0x00007fffc9c67f92 in Point::getX() const (this=0x0) at /home/julien/lo/libreoffice/include/tools/gen.hxx:98
2 0x00007fffca04ca9f in ScDataTableView::MouseButtonUp(MouseEvent const&) (this=0x555558afbed0, rMEvt=...)
at /home/julien/lo/libreoffice/sc/source/ui/miscdlgs/datatableview.cxx:242
Change-Id: Ia124dcec698438b51072956949e3274a8e3f77c5
Reviewed-on: https://gerrit.libreoffice.org/44651
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ie15243714464cf8343fff27507e4b257846cdebd
Reviewed-on: https://gerrit.libreoffice.org/44638
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Id680df2145ac691a30f93cea4e565a2467b45dc6
Reviewed-on: https://gerrit.libreoffice.org/44640
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I279f319bd3a3bf71cf0c7b138723d9601e693e7b
Reviewed-on: https://gerrit.libreoffice.org/44634
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I2e238c2f5dfbb1294049b3b089699deab957be38
Reviewed-on: https://gerrit.libreoffice.org/44632
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6cf6f1775fc47014185607433ab0e5cc1a2761d6
Reviewed-on: https://gerrit.libreoffice.org/44571
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I5171de5a13861d36d30f8489b7d83768e8c2ac25
Reviewed-on: https://gerrit.libreoffice.org/44622
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I03f53b84e8ed5804c466859c9c7cb80e7da040a4
Reviewed-on: https://gerrit.libreoffice.org/44620
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I38d83b7d611537ae903d7d63d2a04391eece11ae
Reviewed-on: https://gerrit.libreoffice.org/44621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
+ use for range loops
Change-Id: I896775db65cfddbe30a91b12f1d3a1633f49c068
Reviewed-on: https://gerrit.libreoffice.org/44619
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Do not try to squeeze it into such.. especially if
SotClipboardFormatId::... enum identifiers are used in a user
object id context that is completely not related to the identifier
name this is totally confusing.
commit fb14be5f8f74f83ba89e15f891ddf1f753dcc62f
Date: Thu Mar 12 14:53:28 2015 +0200
create new 'enum class' SotClipboardFormatId to unify types
overdid with that.
Change-Id: I34b570be9f52b7b94ca8af6b23983393ac3a3a55
Reviewed-on: https://gerrit.libreoffice.org/44612
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
...in code accidentally using auto like
> auto const aURL = uri->getUriReference() + "/"
> + INetURLObject::encode(
> m_sEmbeddedName, INetURLObject::PART_FPATH,
> INetURLObject::EncodeMechanism::All);
>
> uno::Reference<uno::XInterface> xDataSource(xDatabaseContext->getByName(aURL), uno::UNO_QUERY);
in <https://gerrit.libreoffice.org/#/c/44569/1> "Properly construct
vnd.sun.star.pkg URL" did (causing hard to debug test failures there).
So make functions taking O[U]StringConcat take those by rvalue reference.
Unfortunately, that also needed adaption of various functions that just forward
their arguments. And some code in sc/qa/unit/ucalc_formula.cxx used
CPPUNIT_ASSERT_EQUAL on OUStringConcat arguments in cases where that happened to
actually compile (because the structure of the two OUStringConcats was
identical), which needed adaption too (but which would arguably better use
CPPUNIT_ASSERT_EQUAL_MESSAGE, anyway).
Change-Id: I8994d932aaedb2a491c7c81c167e93379d4fb6e3
Reviewed-on: https://gerrit.libreoffice.org/44608
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Icde57593fb2cb589465c574894ab10184702655a
Reviewed-on: https://gerrit.libreoffice.org/44603
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I3d1ae5f55343b1b8ec3b0d79a56c9368385a0af8
Reviewed-on: https://gerrit.libreoffice.org/44581
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I543b0943f0bc918d59debc8ee051f88c29d18454
Reviewed-on: https://gerrit.libreoffice.org/44553
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ifb6f22472a9e9c0be95131bf8f49985ccc17c483
|
|
Change-Id: I1fa3543d541ea084a43a1a11f62680fa798f5647
|
|
+ use for range loops
Change-Id: I598d09a363005781a89354a25ea6a87a2b7c8b62
Reviewed-on: https://gerrit.libreoffice.org/44568
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I85396e3192ca09aba8f97c564f8d80058b362d91
Reviewed-on: https://gerrit.libreoffice.org/44564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Remove the special snowflake sc_condformats because it's
now covert by xsheetconditionalentries (see commit
44e9640748791f602edb22cbc499200283466e1e).
Change-Id: Ibdae392533605b56cf9b9c28f8c419ea0d32c0d8
Reviewed-on: https://gerrit.libreoffice.org/44523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I7cfca9d920fd8e060ad984df05d62ae82bad4766
|
|
Change-Id: I5db40b513de43a27a2e58937ea2ad9501d432917
|
|
Change-Id: Ib15931e415990b56367fe3e1c7cf3f22cc4826d5
Reviewed-on: https://gerrit.libreoffice.org/44529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
> sc_apitest::ScTableSheetObj::testCreateFilterDescriptorByObject finished in: 1823012ms
in my --enable-dbgutil build. (Having to adjust NUMBER_OF_TESTS here appears to
be a rather brittle design, btw.)
Change-Id: I48499a0490db86c58ef2b819b64f545be0c1f5b2
|
|
Change-Id: Ieae5a81a1b475fd56cce76c43dab11c2d9fcbe6c
Reviewed-on: https://gerrit.libreoffice.org/44498
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...after 9fbe22e1d9b30c5c0087e84809c80b936c5c142f "No need to blacklist this
loplugin:unnecessaryoverride"
Change-Id: Ie79f99441fd879a95fd1ca53a9bd0f50af9e0c7d
|
|
Convert the Java _XSheetFilterableEx tests to C++ and make changes to
the XSubTotalCalculatable::::testApplyRemoveSubTotals(), because
XSheetFilterableEx::testCreateFilterDescriptorByObject() has to work
with the same sheet.
Change-Id: I89c11bc8f10ec8d2ff4b170aeb9df5a00ca98133
Reviewed-on: https://gerrit.libreoffice.org/44512
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
This now hides one of the ScVbaFormatCondition_BASE::Operator overloads, but
that doesn't get called directly at ScVbaFormatCondition anyway. (And if it
were, we could add an appropriate using declaration to ScVbaFormatCondition.)
Change-Id: I8440b76a5745c6874f7a3bfcbb4bc4ce5618a4c4
|
|
simplify dynamic_cast followed by static_cast
Change-Id: I965afcf05d1675094cfde53d3590a0fd00f26279
Reviewed-on: https://gerrit.libreoffice.org/44460
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
cause that's what its really used for and a couple of cases
are not specifically about avoiding config but avoiding uninteresting
disk acccess and what not
Change-Id: I4c6454f98388579fcd0bf9798321d30408ab65ee
Reviewed-on: https://gerrit.libreoffice.org/44491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Improve sc/ UNO API unit tests by adding a CPPUNIT_ASSERT with
NUMBER_OF_TESTS in setUp(). Makes it easier to spot a mismatch between
actual and expected number of tests (you get a cppunit message instead
of a crash without an explanation).
Change-Id: I7621d8afde3bebbf94cfc3923ad2c12e249ed4c2
Reviewed-on: https://gerrit.libreoffice.org/41829
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: If021d54df28343a6d8885a7a009b251a394d388b
Reviewed-on: https://gerrit.libreoffice.org/44489
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|