summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2016-06-23Resolves: tdf#100460 queryContentCells doesn't count annotations...Caolán McNamara3-1/+17
since commit c06dbbe7594c2a0b5a5b19f8e183d9c421e6e094 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Thu Feb 23 23:36:49 2012 +0100 remove mpNote from ScBaseCell Change-Id: I281a207e26aec8886b1f46b9279e1135b61586da (cherry picked from commit 83f977c7f40d1a5fb975b8ce7c9958c992dba3f1) Related: tdf#100460 GetNotesInRange doesn't count last cell in range e.g. open document from tdf#100460 and select select A20:A21 and right click and there is a hide comment entry. Shrink the selection to just A20 (which has the comment in it) and the right click menu has no hide comment entry in it. std::for_each(it, itEnd means it < itEnd but here we want the rows indicated by nStartRow <= nEndRow so we need to increment itEnd by one to get the right range Change-Id: I48e8c0748f520671e09f04b16961bf9729960317 (cherry picked from commit 84dc0157df9cb173ec74da2bd27507329efc3816) Reviewed-on: https://gerrit.libreoffice.org/26608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-21tdf#96540 dragging between sheets can change the current cursor positionCaolán McNamara5-3/+37
so the at position at time of drop may not be that at the start of the drag. So set the current cursor position to ScTransferObj when the drag starts and retrieve it later Related to: commit ac3b66057ba677903b6de354317417b267be0fa0 Author: Kohei Yoshida <kyoshida@novell.com> Date: Thu Sep 16 11:09:29 2010 +0200 calc-selection-fixed-cursor.diff: Migrated n#502717, i#21869, i#97093, when making selection, don't move the cursor position and commit c433fa0639ccf5caeb0c128c8a3794322e2a1c81 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Fri Jul 6 02:04:44 2012 +0200 adjust the calculation of the cursor pos if ALT is used, fdo#48869 Change-Id: I6316717c860d999270aa7f0fb50af5f6dfc7efd7 I haven't used SetSourceCursorPos everywhere a ScTransferObj is created, just where its created through a drag event Change-Id: I50c36b4a2ba45426edebc1f1dfa5e262db3c5d03 Reviewed-on: https://gerrit.libreoffice.org/26512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit f9b46bbd2446a6c9a0aaab31016536bda4a77294)
2016-06-20Resolves: tdf#99310 data validity cell range dropdown empty under windowsCaolán McNamara1-3/+0
if I make this block unconditional then it also disappears under Linux so I speculate that this is why its missing under Windows. I can't see why this is the way it is (since initial import in 2000), This is reportedly a problem since commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves; tdf#87120 no keyboard navigation inside floating windows (cherry picked from commit c3a5012c5a9699040698505d3e34672382c026b8) Change-Id: I6159d419bccef851c8f9e965d063882173d91620
2016-06-17tdf#98955 hardware_concurrency not ideal for thread poolsAshod Nakashian2-2/+2
A new static member getPreferredConcurrency added to comphelper::ThreadPool to return a configurable max number of threads. By default the new function returns the hardware_concurrency value provided by std::thread. When MAX_CONCURRENCY envar is defined, the return value is limited to whatever is set there. Three call-sites that used std::thread::hardware_concurrency have been replaced with getPreferredConcurrency. Unittests added to cover the functionality of the new member. Unittests are capped to 4 threads. Reviewed-on: https://gerrit.libreoffice.org/26254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 60e75fb276778459f6055360646d879b8c615d83) Change-Id: I3332e393a88a5ed436316fa712ed920a4b37f4af Reviewed-on: https://gerrit.libreoffice.org/26395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-06-15do not override nGlobalError with error from ConvertStringToValue()Eike Rathke1-3/+4
... so an already existing previous error is kept. Change-Id: Ie731f17e93afa512542cc3ba2378031e978f9462 (cherry picked from commit df149997849c1e07d735fdeefccf875e7361aa4c) Reviewed-on: https://gerrit.libreoffice.org/26338 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-15set string conversion error also at interpreter if availableEike Rathke1-0/+3
Change-Id: Idedb9192938a01ecfda3dd93e69c16a896801fd7 (cherry picked from commit 68455c20cb5edf2bfc57243b44fc81b7fa5ea5db) Reviewed-on: https://gerrit.libreoffice.org/26335 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-15Resolves: tdf#100409 GetDoubleWithStringConversion() in GetDoubleFromMatrix()Eike Rathke1-2/+2
Change-Id: I1e88e9fa6361c6f1f2aebebc101d44bc8e974283 (cherry picked from commit f219bd4c3599e0933760f8a9f0155fc97a9ab23c) Reviewed-on: https://gerrit.libreoffice.org/26334 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-15introduce ScMatrix::GetDoubleWithStringConversion() preparing for tdf#100409Eike Rathke2-10/+41
... as GetDouble() returns 0.0 for any string and we don't want to change that, most relevant places already check for numeric/text beforehand. Change-Id: Ifbc04e892f6f504040026042faa38674ced880fb (cherry picked from commit 481b8589d135baced12469bec4ee734b23faac21) Reviewed-on: https://gerrit.libreoffice.org/26333 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-15tdf#61396 Possibility to edit a template not in Template RepositoryAkshay Deep1-0/+2
Menu Sequence: Open Template... Save as Template... ---------------------- Manage Templates Change-Id: I0d0c8ca15d8dc38662e7f84a4f598933c13dd512 Reviewed-on: https://gerrit.libreoffice.org/26179 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com> (cherry picked from commit 384c75b7e8b50a64a1c0e8fd1ffef1350e2522d2) Reviewed-on: https://gerrit.libreoffice.org/26314
2016-06-15Resolves: tdf#100396 handle unspecified WEEKDAY arguments and support new onesEike Rathke1-8/+28
... introduced with Excel 2010. Change-Id: Ide47fea0e8bc109dc47f591c33ec1d1a13c08d72 (cherry picked from commit d9911e0d13c96feb0b0d1feacef6be7be29ccfe1) Reviewed-on: https://gerrit.libreoffice.org/26297 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-14do not use OUString::number() to "format" numeric valuesEike Rathke1-39/+9
Change-Id: Ie35a34152556e19eff1f196ddd0ddd51a6da1a23 (cherry picked from commit be2cf3d28b91cff4127c95cfe4481f36bdeb24fb) Reviewed-on: https://gerrit.libreoffice.org/26274 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-14tdf#100342 fix order of weekdays in NETWORKDAYSWinfried Donkers1-1/+2
For the definition of working/weekend days, ODFF1.2 uses 0..6 for Sunday..Saturday. NETWORKDAYS used ISO ordering (Monday..Sunday), but now complies with ODFF1.2. Change-Id: I169433adfac5d66af979181c328658040d7ab77f Reviewed-on: https://gerrit.libreoffice.org/26246 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit d81fa4eb3a8960c1a1280fdd07bafa29de8290d2) Reviewed-on: https://gerrit.libreoffice.org/26269
2016-06-14allow text as dates in inline array of holidays for NETWORKDAYS()Eike Rathke1-1/+1
Change-Id: I0c5438a0ee23a5974495a9f782b3f22ef7472c87 (cherry picked from commit 3c2803bdbc598deeaf6efe43870d4f9d61cb2c6a) Reviewed-on: https://gerrit.libreoffice.org/26273 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-14check ExternalSingleRef token for svDouble typeEike Rathke1-1/+6
... before accessing GetDouble(). Else convert the string. The new assert() introduced in FormulaToken::GetDouble() virtual dummy was hit by loading gnome334723-1.sxc Change-Id: I144b0cabee3aac44d206d76a83b1c4d81ab4a02e (cherry picked from commit 243f19a1878d52a4074b59041dc3bc57ab84e417) Reviewed-on: https://gerrit.libreoffice.org/26262 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-14fix obtaining ScRefCellValue results, tdf#97831 follow-upEike Rathke1-14/+38
ScRefCellValue in interpreter context has to be used with GetCellValue() and GetCellString(), using raw ScRefCellValue getString() and getValue() is not enough. This also changes behavior with referenced empty cells that sc/qa/unit/data/functions/fods/Functions_Excel_2016.fods tests for, but I assume that tested our implementation, not what Excel does in these cases. Needs checking. (cherry picked from commit ab7e112bcf2ecd09ea129ef81177df8036110cb6) Conflicts: sc/qa/unit/data/functions/fods/Functions_Excel_2016.fods Change-Id: I16194ad59cce3d15271e7610e8ed90ac1786bcaa Reviewed-on: https://gerrit.libreoffice.org/26241 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-13Resolves: tdf#100048 we can rearrange the hidden child to allow tab traversalCaolán McNamara1-47/+59
the problem is the hidden window used to be the temp parent for the ref edit and button when this dialog is in shrink-ed to reference mode from the cell-range option on the criteria page Change-Id: Ic11299aae159b4f58f2158442b0a787fb0607c03 (cherry picked from commit 3bd190aea386d16bee9c129699d1e19580a2d4ba)
2016-06-13Resolves: tdf#90419 diminish precision error in Series FillEike Rathke1-4/+39
There may be more elegant ways to accomplish this, go and find one.. Change-Id: Iceaa0783db9cf3d3e1aa20f075fe7e0618a1feb6 (cherry picked from commit e89c0e4fb783bd36d5f5fea154ee8608e542dae4) Reviewed-on: https://gerrit.libreoffice.org/26219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-06-12tdf#92218 tweaks to single toolbar mode toolbarsYousuf Philips1-3/+3
Change-Id: Ia8311c48dfa116b4557880a48a7299659a10cb0e Reviewed-on: https://gerrit.libreoffice.org/26131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit f72270a6a23e2577cb3b67f154e1ec55df8afadd) Reviewed-on: https://gerrit.libreoffice.org/26192 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-10tdf#100257 - Data : XML Source does not workNoel Grandin2-11/+21
Revert "sc: boost::ptr_vector->std::vector" This reverts commit 280553e30f4ddc932838f98a9efaac03a988a0df. Reviewed-on: https://gerrit.libreoffice.org/26106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit d6a6f587a852ba5c993c658b6b6432a65207f5b7) sc: eeek, a boost::ptr_vector! take it off! take it off! (cherry picked from commit 741077bf1cdb0c9240ee3e90f07a42bef5bb7a8f) Change-Id: Ia50c9cf7902e2e830c6e7f7a13c8f04341556e6c Reviewed-on: https://gerrit.libreoffice.org/26150 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-09Resolves: tdf#100285 EASTERSUNDAY() check valid year between 1583 and 9956Eike Rathke1-0/+6
Change-Id: I4b25f1eb8e3cf0236b69607bb9ab9b4c57ae918a (cherry picked from commit 2c08ec226e771de10c8863b7f1cda016fea442d2) Reviewed-on: https://gerrit.libreoffice.org/26107 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-07Resolves: tdf#89186 descend into dimension children to obtain leaf resultEike Rathke1-0/+18
(cherry picked from commit 81f2bbc2fc42688d5f884d3dde58abe4c265694a) Backported. Change-Id: Iea6c292c6d7347c4abb221672e583118196e6c1f Reviewed-on: https://gerrit.libreoffice.org/26026 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-07Resolves: tdf#88237 crash without java but with nlp solver installedCaolán McNamara1-14/+21
Change-Id: Ifb451c299e4586a3a38c83a3111f3ac0b46d9315 (cherry picked from commit a33d18c1e38dd783e779ca1dbf54e1ad90cae751)
2016-06-07tdf#97340 : Handle autofilter search for dates correctlyDennis Francis2-26/+150
Change-Id: I5c8413d560789a626ea87eb28a89059960177f1f Reviewed-on: https://gerrit.libreoffice.org/26005 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-07tdf#85594 Unify Calc drawing toolbar with WriterYousuf Philips3-5/+14
Change-Id: Iac74d5d8f8b20cd771ce67c713ef53eccaa6f1f0 Reviewed-on: https://gerrit.libreoffice.org/25895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit 3eb15d6119ff36d79aed3b8a42bac42c25afea4e) Reviewed-on: https://gerrit.libreoffice.org/25954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-07sc: StarCalc/DOS import: fix an endian issueMichael Stahl1-1/+15
(cherry picked from commit 1bf3cafd4cd6c3133adaad764e4f216a5d0ead1c) sc: -Werror=unused-variable (cherry picked from commit 722f6109296e115f56281bae548f809ef60327c2) Change-Id: I0f76661d1aec104ee7e22a8abd5f734553796c33 Reviewed-on: https://gerrit.libreoffice.org/25994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-03Resolves: tdf#98880 ensure backing context of DoubleVectorRefToken...Caolán McNamara5-5/+24
exists for the lifetime of the ScGroupTokenConverter otherwise in tdf#98880 ScDocument::InterpretDirtyCells releases that backing storage that the DoubleVectorRefToken relies on, and the ScVectorRefMatrix relies on that, so... when sc/source/core/tool/interpr4.cxx calls ::IsString on the ScVectorRefMatrix which calls ensureFullMatrix. That makes use of rArray.mpStringArray where rArray's mpStringArray is set to that rArray by FormulaGroupContext::ensureStrArray and the storage of mpStringArray belongs to the FormulaGroupContext, but that context was reset and destroyed up the stack in ScDocument::InterpretDirtyCells so the data is now invalid We could turn the unique_ptr into a shared_ptr and have the ScGroupTokenConverter take a ref to the currently active FormulaGroupContext to ensure any generated DoubleVectorRefToken/SingleVectorRefToken point to valid data during the lifetime of the ScGroupTokenConverter Change-Id: Id457934cdff18570961cb261cf5c46b6ef8ea083 Reviewed-on: https://gerrit.libreoffice.org/25815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit dc78e5c6f5f55b0289012f4c4e6013d2935b1cc6) Reviewed-on: https://gerrit.libreoffice.org/25866 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-02tdf#92218 Implement Calc single toolbar mode toolbarYousuf Philips2-0/+89
Change-Id: Ie261b71000c37f18efe0658bbf239c9639a5fcf3 Reviewed-on: https://gerrit.libreoffice.org/24088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit da27c5d58948a782f25338320f9c57cfe542986e) Reviewed-on: https://gerrit.libreoffice.org/25725 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-01Resolves: tdf#53899 if there is no CurrentController, use the ScTabViewObjCaolán McNamara1-3/+22
as the CurrentController for the duration of the first recalculation. That way any StarBasic has a CurrentController available to it during initial load. Change-Id: I8aa85562a44b49192dd8729c9da57392470b9106 Reviewed-on: https://gerrit.libreoffice.org/25514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 50e39c58f152888e7001a1b0e3a9fd84b691216e) Reviewed-on: https://gerrit.libreoffice.org/25772
2016-06-01tdf#84411 - OpenCL: S/W interpreter throws std::out_of_range errorMarco Cecchetti1-0/+4
The problem is that in a array fragment, row start can be beyond data row end. Change-Id: I33658c87c21d1be237f4675241e3eabdd4ec7058 Reviewed-on: https://gerrit.libreoffice.org/25734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-30we already have pClipDocEike Rathke1-1/+1
Change-Id: I0485f15b6771d10d4b077f5034db77e4c13ef877 (cherry picked from commit f65b29ff13211449144455668014a80aa8b331a3) Reviewed-on: https://gerrit.libreoffice.org/25687 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-30actually multiple destination sheets are handled, tdf#97158 follow-upEike Rathke3-6/+5
... so ScMarkData doesn't need to be passed. Which it wasn't anyway because the destination sheet span is part of CopyFromClipContext. Change-Id: I0addd370d96ab78b22ed957081a1212fc70419a1 (cherry picked from commit 9d07f557572bdeaeda8e923525c8895d79fc0d22) Reviewed-on: https://gerrit.libreoffice.org/25685 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-30Resolves: tdf#97158 CopyOneCellFromClip() does not handle multiple sheetsEike Rathke3-3/+8
... so check that and bail out to let the remainder of CopyFromClip() handle it. Change-Id: I9d139de905fd108ae41fed79a38860058525272c (cherry picked from commit dc9eac5a5f4f247ba5efb67931ffde61f2c8d5b6) Reviewed-on: https://gerrit.libreoffice.org/25678 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-30FORECAST.ETS.* functions: default aggregation is 1 (0 is not allowed)Stanislav Horacek1-2/+2
Change-Id: I71470b0871a181dd9ce090053a41238698744424 Reviewed-on: https://gerrit.libreoffice.org/25577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 3239ecb4916e0b5ac7583c6de884c9c00f5ebc90) Reviewed-on: https://gerrit.libreoffice.org/25658
2016-05-28Improve alignment and use of space in Document Properties dialogAdolfo Jayme Barrientos1-34/+14
Change-Id: Id4da1138931ef1601541b7108a4e90b3656a5ccb (cherry picked from commit 60dd1527d2b59e63c9e6b73cfbe59ba6cefbba16) Reviewed-on: https://gerrit.libreoffice.org/25578 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-05-26correct description of the SWITCH functionStanislav Horacek1-1/+1
Change-Id: I5180efcf5930c60c5340e195069cbffa2b459fc1 Reviewed-on: https://gerrit.libreoffice.org/25255 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5784ba5ffed88c4fa5da0ac6d06fd2e70a8456c1) Reviewed-on: https://gerrit.libreoffice.org/25522
2016-05-25remove now moot comment, tdf#86282 follow-upEike Rathke1-14/+2
Change-Id: I7e720de93a5f47ca6a81addbb75c113dc2fe53f0
2016-05-25add DVARP test caseZdeněk Crhonek1-0/+1663
Change-Id: I8b591ce8a96484df9a2c7e570227f75f80732e34 Reviewed-on: https://gerrit.libreoffice.org/25461 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-25tdf#86282 switch to base name sheet name again for external references CSVEike Rathke1-9/+13
... now that we can handle both, a base name and Sheet1 name. For the following reasons: * Since 4.3 we write and expect the base name as sheet name for CSV. While 43030487c45f49bccdfad987c60d9483b938ebac switched that back to Sheet1 or its equivalent to be able to load older documents, a mixed environment of earlier and later versions gets confused by this. * The name Sheet1 can be localized and even customized by the user and thus fails to update/refresh in a different localized or customized environment. This also was already the case for all versions prior to 4.3 but apparently wasn't recognized or brought in connection with some possible failures when updating externally referenced CSV files. * Deriving the sheet name to be stored from the base name prevents all problems related to localized or customized environments, and keeps interoperability with all versions from 4.3 on. Change-Id: I8d71b3ad6370747115ea419a21094b649326642c
2016-05-25add DVAR test caseZdeněk Crhonek1-0/+1686
Change-Id: I1e7e86ec28138453a56170d7bc40076708930c0b Reviewed-on: https://gerrit.libreoffice.org/25460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-25tdf#86282 handle both, base name and Sheet1, as external reference sheet nameEike Rathke3-30/+191
While 43030487c45f49bccdfad987c60d9483b938ebac fixed things for older 'name.csv'#Sheet1.A1 references, loading documents that meanwhile stored 'name.csv'#name.A1 lead to #REF! when the external links were updated. Now recognize both, the base file name and Sheet1 name and set up one as the alias of the other, so both variants can be handled. Change-Id: Ie9314e11be19c3316a06e10583777e2d5f5ec1b8
2016-05-25Resolves: tdf#98895 range search crashes open office if range is nullCaolán McNamara1-3/+3
Change-Id: I12cf1045e1fd606cff58b68254eaf5cba6dee838
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara3-3/+0
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-25SWITCH returns error if compared value contains an error, tdf#97831 follow-upWinfried Donkers1-7/+3
Partial revert of commit a2aea8bac55cef23297573733ba28f563f5aa791 Change-Id: Ia059dd434a52e959495c0ea6ffc47e68df7a474a Reviewed-on: https://gerrit.libreoffice.org/25165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-25correct description of range argument of MINIFS and MAXIFSStanislav Horacek1-2/+2
Change-Id: Ie319836f1d916d3a53237fdbc80d6530a000afa9 Reviewed-on: https://gerrit.libreoffice.org/25256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-05-25use consistent case for argument names of IFS functionStanislav Horacek1-1/+1
Change-Id: I19480507e90df46deee15a6a4e80b0fcd6a9c70d Reviewed-on: https://gerrit.libreoffice.org/25254 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-25Convert SC_MF to scoped enumNoel Grandin38-160/+170
Change-Id: I3089006b502e33710bfb2564f051ebf2892ad08a Reviewed-on: https://gerrit.libreoffice.org/25085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25add DSUM test caseZdeněk Crhonek1-0/+3629
Change-Id: I0afb85a16f1128542eae5e966ac0d98f1d66861e Reviewed-on: https://gerrit.libreoffice.org/25414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-25DCOUNT test case - one more testZdeněk Crhonek1-0/+2943
Change-Id: Id4753112ec287f185440d1fd6f231841c944daec Reviewed-on: https://gerrit.libreoffice.org/25413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-24Resolves: tdf#99733 don't crash on moving range of cellsCaolán McNamara2-0/+10
Change-Id: Ib9afc8ef292e517954b24321100862f5235290e5 Reviewed-on: https://gerrit.libreoffice.org/25405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-24convert PIVOT_FUNC to scoped enumNoel Grandin14-112/+120
Change-Id: I6d50ad6fa0dbe7b21ad73e14dc2df3c854d08153 Reviewed-on: https://gerrit.libreoffice.org/25076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-18 05:45:58 +0000