summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2013-11-22resolved fdo#38592 do not insert extraneous parameter in importEike Rathke2-8/+9
Importing already a Calc-only number of parameters do not insert extraneous parameters. (cherry picked from commit 4b9304ecdd067307e24e4388fe1addcab9e85bd0) Change-Id: I011e3df24573fce9f2788c9311089af984650220 Reviewed-on: https://gerrit.libreoffice.org/6764 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-11-20resolved fdo#70750 reverted inappropriate implementation of fdo#63546Eike Rathke1-59/+0
This is a combination of 2 commits. Revert "fdo#63546: set appropriate alignment when wrt direction of cells is changed." This reverts commit 706e3b8e43df94310b2fe8458da67875073a046c. Related previous commits that commit depends on will also be reverted. Triggered by fdo#70750 inspecting the code it turned out that the changes for fdo#63546 did several things wrong: * looping over individual cells of a large selected range results in slicing and merging ScAttrArray for each row in each column which is utterly slow (the reason for fdo#70750) * instead of executing the changes in ScFormatShell calls should had been forwarded through ScTabViewShell to be passed down to ScViewFunc, ScDocFunc, ScDocument, ... * setting hard attributes on all cells (except if already centered or block justified) is not wanted * value cells for example should stay automatically right justified if no justification is given yet * overwriting already existing left or right justification may not be what the user expects * applied styles' justification is overridden this way (cherry picked from commit 2f29e544932633a01162ecb80e50872eabdd2bc1) Revert "fix fdo#63546 : set appropriate alignment when writing direction is changed." This reverts commit 16f508686c29bfa244ca6f81b5ab3bbaf5fef2a7. (cherry picked from commit 955281e50e2728932edc3b688ce3cf235bdfd0c9) Conflicts: sc/source/ui/view/formatsh.cxx Change-Id: I53fc56a09f2b396577fff3ec679b39837fc2f649 Reviewed-on: https://gerrit.libreoffice.org/6691 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-08"%1 is replaced to ..." ... maybe, or maybe notEike Rathke6-18/+33
Translations may have omitted the %1 placeholder in SCSTR_COLUMN and SCSTR_ROW, or not have it translated newly yet because it was introduced later. In these cases append the column indicator / row number as it was done before. (cherry picked from commit 9b10373edae490d2b9b7f8d733c59b4f63927bec) Conflicts: sc/source/ui/dbgui/filtdlg.cxx sc/source/ui/dbgui/pfiltdlg.cxx sc/source/ui/dbgui/tpsort.cxx sc/source/ui/dbgui/tpsubt.cxx Change-Id: I331cf0c529bebea02277784ea145c202eb6f6fda Reviewed-on: https://gerrit.libreoffice.org/6618 Reviewed-by: Ivan Timofeev <timofeev.i.s@gmail.com> Tested-by: Ivan Timofeev <timofeev.i.s@gmail.com>
2013-11-08"%1 is replaced to column letter" ... so do itEike Rathke1-3/+1
In StandardFilter dialog when not using column headers the field names were displayed as "Column %1 A" instead of "Column A". Change-Id: I29216eaa6b98e4a786f77d47ef20135e15d7d45a (cherry picked from commit 2d793b1a7f08e2f42a8e9bd96b7470e15784f7cf) Reviewed-on: https://gerrit.libreoffice.org/6591 Reviewed-by: Ivan Timofeev <timofeev.i.s@gmail.com> Tested-by: Ivan Timofeev <timofeev.i.s@gmail.com>
2013-11-04fdo#69971 formula dialog crash when Paint restores EditEngine listenerCaolán McNamara1-0/+17
We need the EditEngine Modification handler of the inputbar that we are feeding to be disabled while this dialog is open. Otherwise we end up in a situation where... a) this ScFormulaDlg changes the editengine b) the modify callback gets called c) which also modifies the editengine d) on return from that modify handler the editengine attempts to use old node pointers which were replaced and removed by c We turn it off in the ctor and back on in the dtor, but if calc has to repaint, e.g. when switching to another window and back, then in ScMultiTextWnd::Paint a new editengine will have been created via GetEditView with its default Modification handler enabled. So ensure its off everytime we will access it via InputReplaceSelection pScMod->InputEnterHandler(); I wonder if we should really be calling ScMultiTextWnd::GetEditView (which creates an EditView if one does not already exist) in ScMultiTextWnd::Paint or just check for pEditView directly, but that then leading to the need for it to be explicitly created somewhere else. As it stands in ScMultiTextWnd::Paint(...) the "if ( pView )" can never be false. Change-Id: I2f6df9ce0cc7ec59e8be33f4e67d91422796d251 (cherry picked from commit a9d85d62a889288b17899c8defc020da487d8b36) Reviewed-on: https://gerrit.libreoffice.org/6566 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2013-11-02remember column style during XLSX import, fdo#70315Markus Mohrhard1-1/+3
WE overwrote the column style that was set earlier with the default style. Change-Id: I4c02e1cdd3e72f27d75b8153e2af45b5658ff456 (cherry picked from commit 512a14438c4098ca2e30d0b10b6e18506c8475f1) Reviewed-on: https://gerrit.libreoffice.org/6528 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-11-02no default LTR mode does not mean RTL, fdo#68097Markus Mohrhard1-1/+6
Change-Id: Ice4957077e7eda5f7bb93042d6e2ba745935ef8b (cherry picked from commit 045e037b7acde9d8e63fbb977c28b167e8815278) Reviewed-on: https://gerrit.libreoffice.org/6527 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2013-11-01Resolves: fdo#71106 editing dde function crashesCaolán McNamara1-5/+9
Change-Id: Id2f4bffb7de7201ddeb8f75daaa2723cc42c59b0 (cherry picked from commit 3b27470860cfa377dfc0cb940bba204d827434ad) Reviewed-on: https://gerrit.libreoffice.org/6520 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-10-31resolved fdo#70815 broadcast emptied cell in ScColumn::SwapRow()Eike Rathke1-0/+6
Change-Id: Ie939f12a54d0b4cf8bedc34683e20fb924f1bf3b Reviewed-on: https://gerrit.libreoffice.org/6516 Tested-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2013-10-31resolved fdo#56209 reviving FilterFormulaParserEike Rathke5-0/+320
First it was moved from oox to sc without carrying over the component factory bits, then subsequent commits removed the remaining bits in steps as it appeared to be unused: 8ada1cd2846e5e60ad63250c68ddea3a9356546f 887d7945addeb823e0d3f783609c4e79d92ad4a7 effda59a12cedd3cf200d2e9f5186a623b0855bb f2fd2a66ee827024b31a310d67804cb7cb18d2da (cherry picked from commit 20e0afa76087e20f95247406d265a122263a8c6f) Backported. Change-Id: I445b11c95daff6f30b3654936d0f22a113158f97 Reviewed-on: https://gerrit.libreoffice.org/6469 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-10-29Related: fdo#69641 double iterateCodePoints doesn't make sense to meCaolán McNamara1-2/+2
This came in with 04212c3015cd4ab118a0aec2bb04bc153a64af41 but the bug number of #i86439# appears to be the wrong id. It doesn't make sense to me. Rework cclass_Unicode::getStringType to iterate safely over the codepoints of the requested range. Perhaps that was the reason for the original commit. Change-Id: Ice4287eb6f9fc6a9705845c0cf995263815de2e7 (cherry picked from commit 507e627d83dbfb6a35677450a3fc42d10c79a82e) Related: fdo#69641 check index against length before iterateCodePoints Change-Id: I71346b12fcfe3e02015038c3c78db574ada873d6 (cherry picked from commit 08b7af126e546bdbd175023429f544baa9861dba) Related: fdo#69641 add a regression test Change-Id: Icf3324a224d02425acd679a286f3c4a0b7e3ed1c (cherry picked from commit 9d5b07b9085f97edfff5d4ac474e9711036bb0c4) lets be super sure in the face of falling between surrogates Change-Id: I6d8259df3d4f2e73f9236b7c0547f87c89801082 (cherry picked from commit 8f0ecf253531963144d3d1c9ee5c12a6cda99c4e) Reviewed-on: https://gerrit.libreoffice.org/6473 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-10-28fdo#70100 Detect single stream excel files with BOF ID 5Maxim Monastirsky1-0/+1
Change-Id: I321b7a08e0436a9c33878acd1ce2f98c497040b5 Reviewed-on: https://gerrit.libreoffice.org/6447 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 71882916f617528a6d6fcc54450674dc3f630319) Reviewed-on: https://gerrit.libreoffice.org/6464 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-10-13fixed another "Out of bounds substring access"Eike Rathke1-6/+5
Introduced with 3c2a26c84e70fd996855181d319970e2230b2459 Didn't have consequences here because the result was used to check for a "startsWith" condition which it wouldn't had matched anyway. However, use the real startsWith() now. (cherry picked from commit b1caf176a44b6979d2e0ea47f495a3dacf86e197) With f81ed484ffd443e2593627f3d8d3133161817af2 in 4-1 we should have this as well. Change-Id: Ia1d558fc106d9a2010ad41c30f7eb2a2a480c59b Reviewed-on: https://gerrit.libreoffice.org/6218 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-04compare against IDF_HARDATTR, fdo#69720Markus Mohrhard1-1/+1
regression from e851ea0ed30e9bb95c273a29aeab7f48f606145f Change-Id: I07819f90efe87fe9d82515d637960fe48ca40c80 (cherry picked from commit 6f2957969bd72308ddf79cb2befa2373f2dc1dbe) Reviewed-on: https://gerrit.libreoffice.org/6034 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-10-03Resolves: rhbz#1013844 fdo#47482 encrypted OOo 1.0 docs cannot be reopenedCaolán McNamara2-0/+10
Workaround for the encrypted OpenOffice.org 1.0 documents generated by Libreoffice <= 3.6 with the new encryption format and using SHA256, but missing a specified startkey of SHA256 Change-Id: Ib1acc4441b5adc6721cb3cde7a1191aa978e9a1b (cherry picked from commit 11ad93f4ba84f190c908e92a2c960f7a9fa800c0) Reviewed-on: https://gerrit.libreoffice.org/6105 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-27fdo#69450 - IDF_ATTRIB & IDF_CONTENTS must be disjoint.Michael Meeks1-1/+1
Change-Id: Ib971824a7f274334012b872acec65310535ad767 Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-09-19Resolves: fdo#68431 style:font-name unknown in non autostyles in impress/drawCaolán McNamara2-1/+5
Reviewed-on: https://gerrit.libreoffice.org/5810 Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric@lanedo.com> Tested-by: Pierre-Eric Pelloux-Prayer <pierre-eric@lanedo.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d87cb77b42b591b1333aacd60e107514d6e20864) Conflicts: xmloff/source/style/xmlexppr.cxx Change-Id: Ib904af4fac5659821ba3b5dbbf62370df8243001 Reviewed-on: https://gerrit.libreoffice.org/5988 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-16fdo#69091: Copying data from Base-table to Calc by drag and dropJulien Nabet1-1/+1
Depending on whether the data source is registered, either rDescriptor[svx::daDataSource] or rDescriptor[svx::daDatabaseLocation] will be filled in (and should be used). Luckily, ODataAccessDescriptor provides a utility function that will automatically return the one that is set. Use that instead of hardcoding svx::daDataSource. Thank you Lionel! Change-Id: I02673e7924c4323915dea579015326194c3f5077 Reviewed-on: https://gerrit.libreoffice.org/5959 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-09-09CID#1079180 initialize bufferCaolán McNamara1-1/+2
Change-Id: Id00bce6fe4826293f6b0ae842bc70b536e9aa99a (cherry picked from commit c119ec426b2a20b79d3ecaccaa91d15bc8d43a23) Reviewed-on: https://gerrit.libreoffice.org/5892 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-09-09CID#1079181 initialize bufferCaolán McNamara1-9/+9
Change-Id: I516aedd445c8fcd4cefed1ed23d5bf8157b200a6 Reviewed-on: https://gerrit.libreoffice.org/5889 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 21efe9ed56372dee93258fdbfd1bc88a0fd45760) Reviewed-on: https://gerrit.libreoffice.org/5890 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-09-07fix validity dialog with lists, fdo#65686Markus Mohrhard1-1/+1
regression from b0cf3aba085373d84a55ef144b273a8a89d017af Change-Id: Ia3d39e02f35f3e23d93c7fe771bdbeb6eb3d2caf Reviewed-on: https://gerrit.libreoffice.org/5856 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-30resolved fdo#67836 do not overwrite already interpreted English cellEike Rathke1-6/+11
... with a not matching locale dependent interpretation Change-Id: I66553627cab282ed333443ee8bf687596a616a28 (cherry picked from commit a6fdfb960ad0f5b019adff700d0046f20a740996) Reviewed-on: https://gerrit.libreoffice.org/5712 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-08-27fdo#68581: The first paragraph text can be legitimately empty.Kohei Yoshida2-9/+9
Change-Id: I2309a0c6aebc8a111e67e2e3d591cbabfbbadfb4 (cherry picked from commit 969d5a3b97903fe32b3a7da0c3de8bf86f323c17) Reviewed-on: https://gerrit.libreoffice.org/5637 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-08-27Resolves: fdo#68555 use (current) consistent ok/cancel/help button orderCaolán McNamara1-8/+8
Change-Id: Id5bb5c48fe82229fe378500d7cacd36d8554707f (cherry picked from commit 9d8cda2f54adc0af4abdc1fc9675e7bc9c94228c) Reviewed-on: https://gerrit.libreoffice.org/5643 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-26Ugly bad and nasty workaround for some dupplicate symbols issueFridrich Štrba2-0/+50
Somehow, under same circumstances, MSVC creates object code for 2 inlined functions. Nobody here uses them, so simply define them away so that there be no dupplicate symbols anymore. The symbols extents and indices come from boost::multi_array. (cherry picked from commit 5b734c8e19ceb38ec2f632b14fbbc753d95de77e) Change-Id: I7283ecff340d95f16bb3a8d0aae97e166fa5f0e4 Reviewed-on: https://gerrit.libreoffice.org/5633 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-08-26resolved fdo#68437 append the bDetectSpecialNumber "true" string in optionsEike Rathke1-1/+1
Regression introduced with 465dbaecf9890b7117a45d02ea982ef7aca32720 Change-Id: I7c05c7f246dddd0271c421aa358068365d44fb98 (cherry picked from commit aaa1bc40bb197968946c39d4c31c13588191bf55) Reviewed-on: https://gerrit.libreoffice.org/5632 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-24fdo#39484 - don't loose outlines while trying to undo formulae changes.Michael Meeks3-6/+8
Change-Id: Ib3b2bab5beffb8164a8cd2c0b4db4c97f427507e Reviewed-on: https://gerrit.libreoffice.org/5592 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-21fdo#68381 take care of cell notes on TransposeLaurent Godard1-0/+14
Change-Id: I4272b45a1c8ad34b540ee39d9ef9dd717d4f6325 Reviewed-on: https://gerrit.libreoffice.org/5572 Reviewed-by: Kohei Yoshida <kohei.yoshida@suse.de> Tested-by: Kohei Yoshida <kohei.yoshida@suse.de> (cherry picked from commit 68dd91f9e9d9201287acb5825748954a5446f323) Reviewed-on: https://gerrit.libreoffice.org/5575
2013-08-21fdo#53032 - Use the right mark area to undo paste of RTF.Michael Meeks1-4/+4
Change-Id: Iee0521e4f7851f5b51cf6ab7a973bf8b46fb09f5 Reviewed-on: https://gerrit.libreoffice.org/5538 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-20Return on NULL right away, to avoid null dereferencing below.Kohei Yoshida1-1/+1
Change-Id: I17b45a5fb6ac5d30be5d3575fec76a61662decdf (cherry picked from commit e7164ec2858a25a9f57fac199132dea0e70a8555) Reviewed-on: https://gerrit.libreoffice.org/5520 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-19fdo#67699: Remove a whole bunch of old hacks.Kohei Yoshida1-332/+184
The new format detection service is much simpler than the old one. In the new framework, each detection service receives the name of format that it is expected to check against, and it should either reject it by returning an empty string in case the file is not of that format, or if the file is indeed that format, set the appropriate filter name and return that type to the caller. We no longer need to deal with preselected filters (which is dealt with in the detection framework itself) or return an entirely different format that's different from the one being asked to verify. (cherry picked from commit e69aa9572bb2206313cd2aa7edd13da91460f2c4) Conflicts: sc/source/ui/unoobj/scdetect.cxx Change-Id: I3f36951b0ad821d836fb8a56b852e40d43095f09 Reviewed-on: https://gerrit.libreoffice.org/5518 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-19Resolves: fdo#68220 wrong index into source tableCaolán McNamara1-1/+1
code in master is all very different, so 4-1-* only I think Change-Id: I9277faa462b66a38c7da3ba9a92b0381c67cfe23 Reviewed-on: https://gerrit.libreoffice.org/5515 Reviewed-by: Kohei Yoshida <kohei.yoshida@suse.de> Tested-by: Kohei Yoshida <kohei.yoshida@suse.de>
2013-08-19fix for bnc#834705 missing drop downs for autofilterNoel Power3-4/+33
After commit fc861c7088e9b639a1c2c80f8ba4535c798aeb34 there is now an order dependency, between any ScPatternAttr flags indirectly set and SheetDataBuffer::finalizeImport which sets the attributes directly for a column So the ATTR_MERGE_FLAG that has ScMergeFlagAttr ( and associated SC_MF_AUTO flag ) is scrubbed when by the direct writting of the attribute from SheetDataBuffer::finalizeImport -> Document::SetAttrEntries I've reordered that Table import here and split the finalize ( which happens before heetDataBuffer::finalizeImport ) so that the databaseranges which were created before sheet import still happens, the autofilter part of the import is now deferred ( until after SheetDataBuffer::finalizeImport ) Change-Id: I11bb45ee7b330760fd93ecca30b23399414ac3a7 (cherry picked from commit edd51b813005c2159426d8f2917eede5b14a4577) Reviewed-on: https://gerrit.libreoffice.org/5447 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-08-16import .xlsx files saved by Calc before fdo#59727 was patchedWinfried Donkers1-2/+12
Change-Id: Id1eedc86056f7de24913f8156a819f8a0695fd59 (cherry picked from commit 78c995a184115ef4ec1c348bd9b910a3791de550) Signed-off-by: Eike Rathke <erack@redhat.com> differentiated warning for symbol/AddIn pair insertion, fdo#59727 Change-Id: I371bca810c40d4cfab0b9fcd47a070b4e68ee768 (cherry picked from commit b24e3a6042ccfeee650664cc6fb244dfeea497cb) Signed-off-by: Eike Rathke <erack@redhat.com>
2013-08-15resolved fdo#67571 write flags and formula token array againEike Rathke1-33/+33
Regression introduced with 337066eb1fa395990b78d1032c399a4688d2a6f9, flags and formula token array weren't written if the formula result was an error value. Change-Id: I8ccd55a7b43d5ceb79002e01f0b3d33d36d85538 (cherry picked from commit 25763e59625ce83de4b82927359108f9e7878744) Reviewed-on: https://gerrit.libreoffice.org/5429 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-14fdo#59727 fix #NAME?-error with add-in functions on (re)open of xlsxWinfried1-0/+13
Change-Id: Ia3c452f21328e2d5773f245e729905a70d14c29e Reviewed-on: https://gerrit.libreoffice.org/5312 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 27aeea8e2bd374ec2f7317ac485315118ea1feee) Signed-off-by: Eike Rathke <erack@redhat.com>
2013-08-12fdo#37341 fix unending loop in calc with Goal SeekWinfried4-242/+179
This is an improved patch of commit G12a712245bdcca40bb87e2bd118eec9635848 which was reverted with commit bcbdf6763944dcc53c2667bf829a005ff0b9223a The original patch still contained a piece of test code that does not belong in the patch. The goal seek tests from Junittest_sc_unoapi now all give the expected results (tested manually). Reviewed-on: https://gerrit.libreoffice.org/5359 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 416d10b5f91047f0dcfbcc233c60322810bfc8d0) Signed-off-by: Eike Rathke <erack@redhat.com> Conflicts: sc/source/core/data/documen4.cxx sc/source/core/tool/interpr2.cxx Change-Id: I8009a0dd3601a1d7d54899e781e30363cf0c36ea
2013-08-10resolved fdo#66205 call PostPaintCell() in Set...Cell() data entryEike Rathke1-0/+4
Cell modifications need to chain repaint positions. Regression introduced with bcf5b54b47eda4e39b4f5f4813cb43e1f52f0201 and related. Change-Id: I4df633304443ea761ae743ee1271f5777e0da5b2 (cherry picked from commit bc599dca8b6b46cff35dab01ad26c18ea529b261) Reviewed-on: https://gerrit.libreoffice.org/5332 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-09Resolves: fdo#67947 charsets not sorted in csv dialogCaolán McNamara1-0/+2
regression since 538ba011d7b598737c898cfcce1e0d7b00b40c84 Change-Id: I260819681dfd47435d8edf5fd97c873238c5d808 (cherry picked from commit a783c7ce72c6dc306dcd39868c9bf41d9dc886e0) Reviewed-on: https://gerrit.libreoffice.org/5326 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-08-06fix build with debug STLDavid Tardon1-7/+17
Failed with: /usr/include/c++/4.8.1/debug/safe_iterator.h:510:error: attempt to compare iterators from different sequences. Objects involved in the operation: ... The problem is that miPos in _copied_ object points ot maAttrs in the original object, not in the copy (and std::for_each takes a copy of the functor). This could be solved by defining copy constructor and operator=, but given the limited usage of the class, it is simpler to let copies share the state. (cherry picked from commit 95d1b05430d0d6384c6910fa9dfdd3c703201d34) Conflicts: sc/source/core/data/documentimport.cxx Change-Id: Icf3f02ecd2fe4ce6dd77f3cde226d32beb4d4b3f Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-08-05fdo#67684: Store imported text style entries, else they won't get exported.Kohei Yoshida1-0/+5
Change-Id: Id784772e677e176622e75ff5ae33ab3eb78b1d9a Reviewed-on: https://gerrit.libreoffice.org/5263 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-08-05fdo#67099: Don't use edit engine for a single unformatted paragraph.Kohei Yoshida2-8/+38
which is most common, and using edit engine for it would decrease loading performance. Change-Id: I65c20eef96c88edd8eb07c73c27716c4f03c4cda Reviewed-on: https://gerrit.libreoffice.org/5259 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-08-05fdo#67099: Remove overheads on inserting cells during ods import.Kohei Yoshida10-260/+485
We will switch to using ScDocumentImport to populate the document from import filters, instead of using ScDocument directly. Conflicts: sc/inc/column.hxx sc/inc/documentimport.hxx sc/source/core/data/column2.cxx sc/source/core/data/column3.cxx sc/source/core/data/documentimport.cxx sc/source/filter/xml/xmlcelli.cxx and a whole bunch of changes backported in order retrofit this code in the 4.1 branch. Change-Id: Ie59d6877d1ac4fc04751a84b663772a9dc9a3efc Reviewed-on: https://gerrit.libreoffice.org/5258 Reviewed-by: Michael Meeks <michael.meeks@suse.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-08-031st step fix for exporting SheetProtection fdo#64753 is to import correctlyNoel Power6-6/+117
(cherry picked from commit 016e18680e471d9f0cea8ee35f9716ae0f9baa11) 2nd step to export SheetProtection fdo#64753, actually export the data (cherry picked from commit 8ce1124359783df750d176b8390b4eb0f54fb6ba) unit test for fdo#64753 ( import/export of sheetprotection ) Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: If420b386543c15c7b550a720b6e2db69bf372d7f Reviewed-on: https://gerrit.libreoffice.org/5229 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-08-02Fix build.Thorsten Behrens1-1/+1
Change-Id: Ic1a6ce26e84982a617d9814645a7bfc3ccd3a63f
2013-08-02fdo#67489: Don't stop range search even when the first cell is empty.Kohei Yoshida2-2/+37
Because we aren't supposed to. Think of those formula cells that follow the empty one. Change-Id: I2cd04833d5e6c561e9ab6d83a984dbdceefa2e71 Reviewed-on: https://gerrit.libreoffice.org/5233 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-08-02fdo#67621: Delay populating the ranges until the dialog is shown.Kohei Yoshida2-5/+15
Otherwise the table widget won't have any idea which rows are displayed, and end up not populating the ranges. This is caused by the switch to the .ui dialog, which delays calculation of the dialog size until late. But the code that populates the ranges was execuated when the widget was instantiated, at which time the widget didn't have its size assigned. Change-Id: I22943b41b21b58cc67e872dff13ad3c25eee8438 (cherry picked from commit b8b807ae589a0b0daa101a0b00bcbe21aa138e2f) Reviewed-on: https://gerrit.libreoffice.org/5227 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-28fdo#61201: Don't forget to calculate row offset for external single ref.Kohei Yoshida1-0/+1
Change-Id: Ie3dbf2eeba98a60aa2426b1db35ac885102d3821 (cherry picked from commit 8b96cfd6caedbad7b3b79e57421a834f18c5c511) Reviewed-on: https://gerrit.libreoffice.org/5142 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-28fdo#67246: Detect BIFF 2 (and 3) file format like we should.Kohei Yoshida1-4/+14
(cherry picked from commit b46688a663b8709e0e0795f25ef8961db1f46cba) Change-Id: I1421cca4b0ef8e9410aab5725cc5a8d9cffef7a9 Reviewed-on: https://gerrit.libreoffice.org/5145 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-26fix for fdo#62729 reference pos can point to non existing tableNoel Power3-0/+31
there is an existing function ( called at least from uno names api also ) that updates the tab pos, calling that seems to fix this problem (cherry picked from commit b5fffdb8d0438a2fe933a5742d41fe50a14b71f3) with squash of unit test for fdo#62729 (cherry picked from commit 7b3d8e0a7dcf6ae05e1de5c33ed382822cf52cce) Change-Id: I6f6f31895eda9c338eeabd3f3285bf2c9eb23b7e b9be75459aa49b8bab968dedae9e0760ccef9a26 Reviewed-on: https://gerrit.libreoffice.org/5124 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 06:12:15 +0000