summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2018-08-08ofz#9431 don't check attribs of Invalid columnCaolán McNamara1-1/+1
Change-Id: I9c5adcadfa2a8593ff90622449d6bdfa4810f2c0 Reviewed-on: https://gerrit.libreoffice.org/57917 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit d909146913c762c2cdb6bed52fbbd817c05681e9) (cherry picked from commit f4189f0dab25dbb61332d70c434485f8dc28be70)
2018-06-30tdf#118441: also keep string-formula results for shared formulasMike Kaganski1-3/+19
... like it is done for normal cells. So, the cells that have markup like <row r="2" ...> <c r="A2" t="str"> <f t="shared" ref="A2:A65" si="0">Test(B2:Z2)</f> <v>0</v> </c> </row> <row r="3" ...> <c r="A3" t="str"> <f t="shared" si="0"/> <v>0</v> </c> </row> now are handled (wrt restoring the stored result value) just like cells with this markup without sharing have long been handled: <row r="1" ...> <c r="A1" t="str"> <f>Test(B1:Z1)</f> <v>0</v> </c> </row> Change-Id: Ifcf62cf6d073faff310aa8553c6f57f42ae588cc Reviewed-on: https://gerrit.libreoffice.org/56697 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-06-26forcepoint#40 null derefCaolán McNamara2-4/+4
presumably since commit 0098bee792c3e208ea4f6ef1c676958d3f4cd207 Date: Thu Sep 21 06:48:09 2017 +0200 tdf#112501: Pivot table: popupbuttons are placed on wrong cells Change-Id: I5413c0ba06fca25cb22256a20ef9640767dd9e50 Reviewed-on: https://gerrit.libreoffice.org/54970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 69c5be9b26cf1a45e220d69f65b1bb0fa2aedaf6)
2018-06-21Resolves: tdf#108654 check nTabNo against maTabData sizeEike Rathke1-1/+12
ScViewData::DeleteTab() and DeleteTabs() never did that and worked by accident for which commit 73dec49802ef8fc42c5719efaa42a33cde68e569 removed the grounding.. squash this into it too: assert(nTab < static_cast<SCTAB>(maTabData.size())); cause of tdf#108796 Have a dev friendly abort instead of a deep throw in case of the unexpected. Change-Id: I95460cd017d558c073df7891551d0251009dc1d4 Reviewed-on: https://gerrit.libreoffice.org/56261 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit abe9a9b023d1b08384f2f529e442e9a59de10f8c)
2018-05-16Related: tdf#100925 background not getting set under X sometimesCaolán McNamara1-1/+6
not sure why this is the case, but it is reminiscent of rhbz#1283420 which results in missing glyphs in some circumstances X11CairoTextRender::getCairoContext has a hack in it for that problem, whic forces a read from the underlying X Drawable before writing to it which seems to have the effect of syncing it up. So, just before drawing the bg, draw a glyph on it to get it synced, and then overwrite it. Reviewed-on: https://gerrit.libreoffice.org/52819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e8080c79043a7d9036f27cc24b76b7ff21c58da8) Change-Id: I2ffff7e8e989b91821869d8b75a59728ac513d1b
2018-04-07forcepoint #34 survive missing autostylesCaolán McNamara1-0/+2
Change-Id: I742816297659d614e836a8d5e8965b1c55154719 Reviewed-on: https://gerrit.libreoffice.org/51892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 2446ae942b2ca35c9f727fb15ef5ec8d248b55c5)
2018-04-07forcepoint #32 survive missing value rangeCaolán McNamara1-4/+14
Change-Id: I90315f0481bf73c4d9071959bf5408f4a2690257 Reviewed-on: https://gerrit.libreoffice.org/51886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit ee9d80d6d93afe914097b3f1835777052cc0000d)
2018-04-07forcepoint #31 check validity of another group rangeCaolán McNamara1-0/+2
Change-Id: I82ff3e47a033c91581b108e1685b1ff4d5865895 Reviewed-on: https://gerrit.libreoffice.org/51883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit be9e229ee147d45f110ecc1680be4068c1716c02)
2018-04-07forcepoint #30 check validity of group rangeCaolán McNamara2-0/+2
Change-Id: Ie0611f36809b051ce46030e44c137b4e1f8d2fe0 Reviewed-on: https://gerrit.libreoffice.org/51865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit e82beb0812f2f4742b80ba1f63a026cbe77f5b25)
2018-04-07forcepoint #29 detect illegal self series addCaolán McNamara2-0/+5
Change-Id: I3bba0f942780c54951a3a810c05cc3b56ca18a5e Reviewed-on: https://gerrit.libreoffice.org/51862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit a471620af5099c960e22b46fad6e6f92a5055dbd)
2018-04-07ofz#7121 NamedDBs::insert takes ownership of its argumentEike Rathke4-11/+8
at one point this was based on std::auto_ptr and didn't free its arg on failure Adapt description to reality (cherry picked from commit f161cdc979587488df83e63002bee7ee15152d42) Reviewed-on: https://gerrit.libreoffice.org/51934 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c4946ba195c9f0c2fb3f18f1028eea725c920e2e) Change-Id: I24133fb6c52bd7500037364120cb11d1b1f099c2 8aeed6876d80b7ebe4ebb5e2cfd12e00420bd207
2018-04-07forcepoint #26 check input against max valid enum valuesCaolán McNamara2-8/+8
Change-Id: Ide72884c77904ae9495b5189cde086e43923e4bd Reviewed-on: https://gerrit.libreoffice.org/51138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 05315e34c354b84409aa5e29ce9b8ce494570b52)
2018-03-27tdf#116241 Customizing value highlighting colorsSzymon Kłos3-13/+16
Available in: Tools->Options->Application colors Change-Id: I6e4f7a0dcad9a6ee222275019596853f0cbd3ab0 Reviewed-on: https://gerrit.libreoffice.org/51791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51943 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit a99998525242d7d3ee48bece6ea699814fd4433f)
2018-03-13for listeners the range needs to be set before the formula, tdf#115530Aron Budea1-5/+7
Reviewed-on: https://gerrit.libreoffice.org/49957 Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 26b51c9550ef300e7685fc41eb9cde4dbbc11265) Reviewed-on: https://gerrit.libreoffice.org/50016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 56e0895730fa289d72333d7b432122292e37b4c4) Change-Id: I001795fd456375c4babab2c2e505bedff03e991f (cherry picked from commit ad907b7b00efd889aed89cc0545472af829b6e65)
2018-03-06tdf#112033: enable the xml source feature when the experimental features are ↵Markus Mohrhard1-1/+5
enabled Change-Id: I066b2927c5e22664b7a4e96549da3a02ec4c99d3 Reviewed-on: https://gerrit.libreoffice.org/41085 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 65722772f00a40b8ca8adf21e31c22295ef7d215) Reviewed-on: https://gerrit.libreoffice.org/47696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 4ac1a46f712f38fee3323e7c4ed121880469a9d3)
2018-03-06tdf#115044: do not load external documents if it is not allowedVasily Melenchuk1-0/+9
Referenced external document data can be loaded after user permission from dialog or corresponding settings. Change-Id: If3aec37c8bbdee4aebeb99c7807e87c26df8e592 Reviewed-on: https://gerrit.libreoffice.org/48398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8b98991a66197a71953dbb900dc3aece6b4f9e3a) Reviewed-on: https://gerrit.libreoffice.org/48870 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0e7c8c3a1be5c266f8ba7ad42fd9ce80beae5264)
2018-03-06Related: tdf#114251 disable vectorization of svDoubleRefEike Rathke2-1/+15
It doesn't work, not knowing how to handle implicit intersections not only produces huge unnecessary matrix operations but also delivers wrong results. Unit test will follow as a separate commit. Change-Id: I14982d4a53d6af57196da998e53d426502c22fec Reviewed-on: https://gerrit.libreoffice.org/46647 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 67444cbe5dae6e24db776ab712017ad063319276) Reviewed-on: https://gerrit.libreoffice.org/46670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 811b40327c15e197b0967393e4071f48a60af42a)
2018-03-06Type svIndex does not necessarily mean range name, tdf#114251 relatedEike Rathke1-0/+7
Change-Id: I5e7930b7f93ee44fb0d6b4c86f261afde8ed2ccc Reviewed-on: https://gerrit.libreoffice.org/46615 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit ecac94f3a6872538c19827603b52f1ed7e671a4c) Reviewed-on: https://gerrit.libreoffice.org/46668 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 0443eb8bf5ed79d13ec1aa49ac83ed2b2e8eea54)
2018-03-06copy ScAddress before possibly joining itCaolán McNamara2-1/+3
Change-Id: Ib1148584b9771da67d3f4b3141184228e1bbe3a2 Reviewed-on: https://gerrit.libreoffice.org/48271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f6eefd96cb16a9b5607fe59bdbf9b1121c9b56e8) Reviewed-on: https://gerrit.libreoffice.org/48298 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 915ce86d14eb219fee467443fe57a984648f3836)
2018-02-26Custom data validation: Add a missing string.Jan Holesovsky1-0/+5
Change-Id: Ief0891d73f0b0ecd0bfdf7092118d795d32d285e Reviewed-on: https://gerrit.libreoffice.org/50366 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> (cherry picked from commit f2f3944cbf4be87bc4f9045c5f5e21570e7b1213) Reviewed-on: https://gerrit.libreoffice.org/50370 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-21Resolves: tdf#115710 let css::sheet::FunctionAccess execute WEBSERVICEEike Rathke4-5/+37
... independent of a LinkManager that is not present in the interim FunctionAccess document. FunctionAccess is executed by extensions, Add-Ons and macros that the user gave permission already. (cherry picked from commit 121fda77b0cc16d54607a1f5f7b26c0f1050284f) Change-Id: I9349a59ee24089c3657de7786b49e5e81946f175
2018-02-21tdf#96698 - calc: add support for custom validation (through a formula)Marco Cecchetti10-12/+91
Now it is possible to select a `custom` validation in the validation dialog: this type of validation let's the user to define a formula, the cell content is valid when the formula is evaluted to true, and not valid when evaluated to false. The `cutom` validation is correctly saved and restored for ods documents, and is correctly imported and exported to xlsx documents This patch contains an adaptation of a preliminary work of Justin Luth for importing custom validation from xlsx documents. Thanks Justin! Change-Id: Idc26654ba69a6f73d1b208d63acdad4b880c776d Reviewed-on: https://gerrit.libreoffice.org/49979 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-08CheckLinkFormulaNeedingCheck() for named expressionsEike Rathke3-1/+12
This is a combination of 3 commits. CheckLinkFormulaNeedingCheck() for .ods named expressions This is specifically necessary for named expressions that are used in conditional format formulas, for which RPN is generated at a later stage, not during import. (cherry picked from commit eae9648e99be53ba441d9d8207aac6f3ce211ef2) CheckLinkFormulaNeedingCheck() for .xls named expressions (cherry picked from commit 8512f13c42ae3fbb287a555616fe10ff04295616) CheckLinkFormulaNeedingCheck() for .xlsx named expressions (cherry picked from commit a1f933ee2b9e23a505d937035821e9571cf4119c) Conflicts: sc/source/filter/oox/defnamesbuffer.cxx e03cb5767c34f8157a492a6d6c3b0700d065052d 217c89822ab477a6c383d170ae739e44efd10fa3 Change-Id: I54ab8dc14f81d6b18b0d17f448187d19d8e396fc Reviewed-on: https://gerrit.libreoffice.org/48858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 908854a7b281454332af434be9468ec45d420030)
2018-02-08CheckLinkFormulaNeedingCheck() for conditional format expressionsEike Rathke4-2/+29
This is a combination of 4 commits. Prepare CheckLinkFormulaNeedingCheck() to use either RPN or tokenized code Conditional format formulas aren't finally compiled until needed so the check will have to operate on the tokenized expression instead of RPN code. (cherry picked from commit faa0305ba3d0dc698fce4915d4f3a1fb52422380) CheckLinkFormulaNeedingCheck() for .ods conditional format expressions (cherry picked from commit 2930ba2ac5d9423f2848b968edcd8ddc71966186) CheckLinkFormulaNeedingCheck() for .xlsx conditional format expressions (cherry picked from commit fef24d9f999ee54d7936900485d97ff26656f517) CheckLinkFormulaNeedingCheck() for .xls conditional format expressions (cherry picked from commit af2a2a0c72db312902e466c36697b5c198041e82) 45eb1ab5efa0ec9da2663f20427d2474ce300826 31ede1a23223a798141a0891deeabd8cf88fff58 afa112cc591b411d80ead48bf726788d361f6eb3 Change-Id: I68837e9bd33f125ab47b10b1a6fa18175abd1627 Reviewed-on: https://gerrit.libreoffice.org/48719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit dc44111ad5965bf4179fc654b677e1e445dea2f0)
2018-02-08CheckLinkFormulaNeedingCheck() for .xls and .xlsx formula cellsEike Rathke7-2/+20
This is a combination of 3 commits. Move implementation to CheckLinkFormulaNeedingCheck() for further reuse (cherry picked from commit 55e484c7bcd3ef218e08d3fd93f97bf98fd8cb7f) CheckLinkFormulaNeedingCheck() for .xlsx cell formulas (cherry picked from commit f96dbc3dd9c33202f75e29ef49d962386595995d) CheckLinkFormulaNeedingCheck() for .xls cell formulas (cherry picked from commit 6bc48275558c3f76c4da25eb8af3c48583ac5599) a6dd195f7eb4d43483e87eeca59f651e7bf2dcb8 2587fbc4fec39b6f2c8e733331815a2953dee308 Change-Id: I541d2b6e12a88371c064b901b00e71206ee0c18e Reviewed-on: https://gerrit.libreoffice.org/48143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2bef4debcf7650f3b3922134dff0332d4a95da3f)
2018-01-17Resolves: tdf#114539 only pop own parameters from stackEike Rathke1-1/+2
... and not another pending one.. Change-Id: Ief5c27ccfb0b4121f2ba019e0fb8770dabbf60cf (cherry picked from commit 4b444b4c1efc2be219e6975e30048ff616fdac0f) Reviewed-on: https://gerrit.libreoffice.org/46801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit a8a8559a24d043b4b1180acb3a0ff60052be5fad) (cherry picked from commit 4cbde23fb6ebde6743c2cca0eeeee916e71bcb4e)
2018-01-17handle ocWebservice similarly to ocDdeCaolán McNamara10-45/+252
might have too much in here seeing as we don't need to worry about ocWebservice calling into itself Reviewed-on: https://gerrit.libreoffice.org/47819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e1946d75a1095c2596d7815600454ff01fcd3270) Signed-off-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 78c1ae24007d8098ee4f4add6d72e84411181785) Change-Id: I0145f38cc1c1f9ff514a496f7101d81cde9e7c67
2018-01-17Better handle ScDde formulas with missing dde-link entriesCaolán McNamara7-11/+19
typically each ScDde formula has a matching table:dde-link which results in a ScDdeLink getting inserted during the load. If that dde-link is missing then no ScDdeLink exists and ScDde() will create a new one without cached content. So detect that ScDde is used in the freshing loaded ods and defer fetching new content until the right time. only call GetHasMacroFunc to set SetHasMacroFunc and bHasMacroFunc is not accessed any other way, so this is an oxbow Reviewed-on: https://gerrit.libreoffice.org/47757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b0597ba5d745974fce752e1b677451a19350d351) Reviewed-on: https://gerrit.libreoffice.org/47818 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 4ede45eb239b1604bca900c22481b7d13e4c2790) Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I016b53288076d83dd49e92e245346a5f7f560522 (cherry picked from commit 3139914eb6379837fbf309642a63371128042db1)
2018-01-17VclPtr, missing disposeCaolán McNamara1-1/+1
Change-Id: I790cd8be0d461d4c82c9b1c64e334bd37115dcaf Reviewed-on: https://gerrit.libreoffice.org/47803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 06a2ffe863501e8bef88cd0201bd5e8d73e92242) Signed-off-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 932508baccd9b97c761980d36ae45e1ae0d85157)
2018-01-17limit WEBSERVICE to http[s] protocolsCaolán McNamara1-0/+9
and like excel... 'For protocols that aren’t supported, such as ftp:// or file://, WEBSERVICE returns the #VALUE! error value.' Change-Id: I0e9c6fd3426fad56a199eafac48de9b0f23914b3 (cherry picked from commit c6c3ed3c750a3c71cb57909c60773fde2c43cd2a)
2018-01-17Windows build fix - uninitialized variableSzymon Kłos1-1/+1
docsh4.cxx(1186) : warning C4701: potentially uninitialized local variable 'eLang' used Change-Id: I9a885cb8ce26f11f43c44ac1ca602d03ef84dfed Reviewed-on: https://gerrit.libreoffice.org/45988 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 0f685ee5a0913cab5826eec737f25328fabf256d)
2018-01-17disambiguation (build fix on Windows)Andras Timar1-1/+1
Change-Id: Icd42b11564b715754b125af6cbcd1d1a359eb5bd Reviewed-on: https://gerrit.libreoffice.org/45494 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit fe96bca99cf378579a204813eb88bef143c24fe4)
2017-11-28tdf#109240, tdf#112571: don't export dupe built-in named rangesAron Budea2-3/+7
XclTools::GetBuiltInDefNameIndex(...) only checked for prefix used in binary Excel format, and didn't recognize OOXML built-in names, which resulted in saving them twice in OOXML files. Adapt to check both binary and OOXML prefixes, similarly to XclTools::IsBuiltInStyleName(...). Saving "bad" files after the fix will purge bad "_0", "_0_0" etc. suffixed built-in names due to how GetBuiltInDefNameIndex(...) works. Change-Id: I1bbe11f9c654a142a4626003df4cb0fd2a0f9c71
2017-11-28lok - calc: outline and group handlingMarco Cecchetti14-37/+377
Change-Id: Ibb287468653bc381acf034dcb8531c5faf61aef3 Reviewed-on: https://gerrit.libreoffice.org/45416 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-11-28lok: sc: subdivide headers data in rangeMarco Cecchetti1-1/+10
Change-Id: I984b5da5774f97172de7659ecab84675060f8301 Reviewed-on: https://gerrit.libreoffice.org/45415 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-11-28lokdialog: Move the LOKWindowId <-> VclPtr<Window> mapping to Window.Jan Holesovsky2-9/+0
This allows registering & de-registering of non-sfx windows too, and makes the Calc autofilter popup to appear. Change-Id: I7cbbe94d208115aabcb6fa5f964646c7b7ce4c93
2017-11-28lokdialog: Move the painting down to Window, and enable Calc and Impress.Jan Holesovsky2-0/+9
Tested with .uno:FormatCellDialog in Calc, Impress not tested. Change-Id: I6d911c29616988db0625be9e2a63cf2172c69ee8
2017-11-28lokdialog: Make the Autofilter popup notify about its creation.Jan Holesovsky1-0/+1
Change-Id: Ib4062fa887b44eb1368205a414f4ac162f648c5c
2017-11-27tdf#111907 Allow box in Manage Names dialog to expand on resizingAndreas Brandner1-1/+4
Reviewed-on: https://gerrit.libreoffice.org/41946 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 9c34471f54870fc685c343f4af30310e75d3a9ca) Change-Id: I821e12d771d574dd191d9be86a19c23288902d5b
2017-11-27ofz: special case max index for cSymbolCaolán McNamara1-0/+2
Change-Id: Ia5fb036196b0cff0739789e691a36d294660540b Reviewed-on: https://gerrit.libreoffice.org/44759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit a5550289a37950195b7a7e5b22cba79ce5b5a673) Reviewed-on: https://gerrit.libreoffice.org/44803 (cherry picked from commit 701e1ec3a2e38a7b0bd2cdd3511a2a50578ea74e)
2017-11-27ofz#4123 do not read past end of fileEike Rathke1-5/+25
Change-Id: I1fa3543d541ea084a43a1a11f62680fa798f5647 (cherry picked from commit 78bcc5ddca186f0009124a697184f332405d3e1e) Reviewed-on: https://gerrit.libreoffice.org/44586 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6ba9b72cff5a761f36b2b9b892b572bc7cb5ae18)
2017-11-27ofz+valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara1-1/+1
if, before lcl_UnicodeStrNCpy is called, aSymbol contains embedded nulls then the aSymbol.getLength() and the mnRangeOpPosInSymbol value derived from an earlier aSymbol.getLength() include the range after the embedded null, while lcl_UnicodeStrNCpy stops at the first embedded null leaving cSymbol with uninitialized value that are later read from it. Conditional jump or move depends on uninitialised value(s) at 0x23BFBCA0: ScCompiler::IsReference(rtl::OUString const&, rtl::OUString const*) (compiler.cxx:3275) by 0x23BFFF4C: ScCompiler::NextNewToken(bool) (compiler.cxx:4248) by 0x23C00D20: ScCompiler::CompileString(rtl::OUString const&) (compiler.cxx:4419) by 0x23A29FAF: ScFormulaCell::Compile(rtl::OUString const&, bool, formula::FormulaGrammar::Grammar) (formulacell.cxx:1118) by 0x23A278B7: ScFormulaCell::ScFormulaCell(ScDocument*, ScAddress const&, rtl::OUString const&, formula::FormulaGrammar::Grammar, ScMatrixMode) (formulacell.cxx:656) by 0x23772EC3: ScColumn::ParseString(ScCellValue&, int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam const*) (column3.cxx:1729) by 0x2377354B: ScColumn::SetString(int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam*) (column3.cxx:1851) by 0x23AE2B97: ScTable::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (table2.cxx:1369) by 0x23897045: ScDocument::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (document.cxx:3377) by 0x1F35F41C: ScEEImport::WriteToDocument(bool, double, SvNumberFormatter*, bool) (eeimpars.cxx:400) by 0x1F366F3B: ScFormatFilterPluginImpl::ScImportRTF(SvStream&, rtl::OUString const&, ScDocument*, ScRange&) (rtfimp.cxx:34) Change-Id: Iefc6be6c3a383bd9b3cdeaa896c07e24e5100dc7 Reviewed-on: https://gerrit.libreoffice.org/44658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 6be596c282f84a3cb3a62edccfdfbf69663cf59e) Reviewed-on: https://gerrit.libreoffice.org/44690 (cherry picked from commit 8959754d2617dad38968ca008791e6431afcbdbd)
2017-11-27ofz: bad mnRangeOpPosInSymbolCaolán McNamara1-0/+2
Change-Id: Ieae5a81a1b475fd56cce76c43dab11c2d9fcbe6c Reviewed-on: https://gerrit.libreoffice.org/44499 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit f17640a95b4c65809f8573c778a293c836a847cd)
2017-11-22Resolves: tdf#111428 swap ScColumn::mnBlkCountFormulaEike Rathke1-0/+3
This is a combination of 2 commits. (cherry picked from commit 423df1fa929784c14e3a133c06468589fe9269cd) (cherry picked from commit 911e2aff3cc37cb7410292728ffea05fffbfb0b3) CellStoreEvent remembered the original ScColumn::mnBlkCountFormula, hence after inserting a column to the left the quick check of ScColumn::HasFormulaCell() whether there are any formula cells worked on the swapped in count (originally the one to the right) that happens to be empty in the scenario. Things worked correctly by accident if the next column to the right already contained a formula cell. c44fed96c49bea7365bf1200e06788860966795c Change-Id: If993856ceee657736f516a81c293506041a6b7eb Reviewed-on: https://gerrit.libreoffice.org/44210 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Eike Rathke <erack@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/44493 (cherry picked from commit 7f1297d9b4f449eb9ada8008fb21b7046d1a8f19)
2017-11-15TypoPranav Kant1-1/+1
Change-Id: I2ecf3050aa68a0f2986c43b651d71b662a77e55a
2017-11-01tdf#113268: Pivot table: Missing popup button after opening a ODSTamás Zolnai4-1/+32
Wrong row number was calculated here. This ++nCurRow is usefull only when headerlayout flag is set. It's a MSO compatibility flag so it's not there by default in LO created tables. Reviewed-on: https://gerrit.libreoffice.org/43552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 291874c09c4bcde61f2c6808f2df6079f38d74e0) Change-Id: Id7989d898f2647f1ba45ed95e0aa615e3b4fa311 Reviewed-on: https://gerrit.libreoffice.org/43974 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-11-01tdf#113159: Pivot table: tabular mode is converted to oultine modeTamás Zolnai3-13/+64
... after RT XLSX in Calc Reviewed-on: https://gerrit.libreoffice.org/43537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 8cf0b4b4cd748094889a6a9ac6883dd457113b74) Change-Id: I9725ca55aed973133db1d5fe47463575148e00b8 Reviewed-on: https://gerrit.libreoffice.org/43971 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-26sc lok: fix spell checking languages in CalcHenry Castro7-0/+158
Change-Id: Iadcc3b55a30ce2a2c785366fb3807ff6e4bda1fe Reviewed-on: https://gerrit.libreoffice.org/43581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/43701 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-10-18Resolves: tdf#112780 no ResetDirty() after SetHybridEmptyDisplayedAsString()Eike Rathke1-1/+6
Change-Id: Idea5c1bd8e8577eaf90fc47d39f88c79963c422b (cherry picked from commit df778416981ab02d42182e5c2e46dc09ba2e2a3c) Reviewed-on: https://gerrit.libreoffice.org/43048 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8d9b236dcb3fd0f7028e4d19ede04589cf85d760)
2017-10-18Resolves: tdf#100822 use sax::Converter::parseDateTime() for 'd' ISO 8601 dateEike Rathke1-8/+11
Instead of squeezing the string through the locale dependent number parser (which should force '.' Time100SecSeparator for 'T' ISO 8601 but apparently doesn't yet) that is a bottle neck anyway. Change-Id: I70f74e680322a715c9cc658c8be033620d9798e3 (cherry picked from commit 5374c04a89e1720490a3625dfd95406c2d60c0cd) Reviewed-on: https://gerrit.libreoffice.org/42971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit d4dad2989071eb5a21d608aa5c3782a68fddf571)
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-07 12:39:16 +0000