summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2015-06-09tdf#91726: AutoFormat: Crash when using an existing nameJulien Nabet1-1/+1
Add a test to check if name already exists Change-Id: Ie23de04c0b747f58ab61a6e498bf212bf38b346a Reviewed-on: https://gerrit.libreoffice.org/16000 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3807946b5515e943169da907866c93b52a2b3f19) Reviewed-on: https://gerrit.libreoffice.org/16055 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2015-06-08destroy and reconstruct listeners only if content is affectedEike Rathke1-12/+20
Pasting formula content that created a formula group always constructed group listeners, then destroyed those listeners again and reconstructed the same listeners, because ScDocument::DeleteArea() is called with IDF_OBJECTS again if nothing is excluded from paste. Do the listener stuff only if one or more of the IDF_CONTENTS bits are set. Change-Id: I8c6b7f7bb3402590f2b1f3259ee730f26a906cdf (cherry picked from commit 97fea63ddf21f48ebb3950952b7d5c6c5f648de4)
2015-06-08Windows MSVC: cannot specify explicit initializer for arraysEike Rathke1-2/+6
Change-Id: Ic42897ba6bb520c931f63e56d0f453ed14cfaa3d (cherry picked from commit 883ebe0283dc6bdf62f08191dede2a249f777f63)
2015-06-08check bounds in RPN tokens, tdf#90694 related and othersEike Rathke1-114/+159
Listeners are set up from references in RPN, so check those for bounds to catch also references resulting from named expressions, database ranges, tables, ... and references in the token code array that are not referenced in RPN. Change-Id: I54770b45818f4c0541a39815278d3271a77b345d (cherry picked from commit 4baf76ddb39580678cf14019900be78bb9071d7b)
2015-06-08tdf#90694 reset group area listeners on correct topEike Rathke1-5/+6
Follow-up on 2f6a06856ad8df0c11a112d1e457b408e9a7af1d, rTop is top of created group, listening needs to be ended on original (previous) group. Change-Id: I1f975a0a6c85e649aa07ce5c6e97bc6e917ff9ce (cherry picked from commit 5d6448a5131488eac3a6af16bff06140663c3db4)
2015-06-07tdf#90888:Shrink the properties sidebar sections in CalcRishabh Kumar8-340/+167
Removal of less used controls Change-Id: I2948e6582031db1f743af59fb1ae02c1a86467f4 Reviewed-on: https://gerrit.libreoffice.org/15935 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit 1c18deee371ae21088383b2a2ddc55c7a7fd41b7) Reviewed-on: https://gerrit.libreoffice.org/16133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Philippe Jung <phil.jung@free.fr>
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin35-49/+82
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-05tdf#90694 reset group area listeners when splitting groupEike Rathke1-0/+11
Change-Id: Ib3e85e1f7e12447fc2998711663ea1e9d1b322e5 (cherry picked from commit 2f6a06856ad8df0c11a112d1e457b408e9a7af1d)
2015-06-05Revert "update to liborcus 0.9.1"Thorsten Behrens3-83/+5
This reverts commit 2f437f5a1003d9593b7e1d35fb31c2bd34c58151, e0e989ef5b24fbe8222aa676aa6491eebce68974 and 81ae40bfe35fd55db789d75d1698f186f13402dd.
2015-06-05update to liborcus 0.9.1David Tardon3-5/+83
Includes switching to dynamic libs. Change-Id: I959c4e9430f8cf95f50d48e1b01d8323dba4af81 (cherry picked from commit edb38d702dd5a058ae0702b73a43328318b94649) Signed-off-by: David Tardon <dtardon@redhat.com>
2015-06-05sc tiled editing: Editview register LOKit callbackHenry Castro1-0/+7
Change-Id: I5ad07f0f3defacaac0f5dac724e9867bbc011dd6
2015-06-05sc tiled editing: double-click empty cellHenry Castro1-1/+1
Change-Id: I35c43e2a22ac6591a2bcf9857808503c0e111344
2015-06-05sc tiled editing: EndTracking trigger MouseUpHenry Castro1-1/+1
It does not need to trigger fake MouseUp event Change-Id: Id90c7787ef3312abe81bce359648aee0dfccd905
2015-06-04tdf#90996: don't overwrite comments in ScTable::FillFormulaVerticalMike Kaganski1-1/+1
IDF_CONTENTS includes IDF_NOTE, which should not be used here Change-Id: I904fbdbfcb97865a5682d9073e0ce2d5a2c694fb Reviewed-on: https://gerrit.libreoffice.org/16085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-04tdf#91702 - fix stack-based MessBox allocation.Michael Meeks14-28/+28
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-04tdf#91425 CRASH - Calc Insert Columns LeftTakeshi Abe1-20/+26
This fix is a SCCOL variant of: commit c66d1b9fcc2244b4fd8940f17ebf4e772f09c84e Author: Kohei Yoshida <kyoshida@novell.com> Date: Thu May 5 00:23:25 2011 -0400 fdo#36406: Let's not use invalidated iterators. std::set::erase(iterator) call invalidates the iterator of the erased element. We better not use it after the erase() call. Since the number of manual breaks should not be high enough to cause a performance bottleneck under normal usage, a safer linear copy should just be fine. Now, I'm not sure if this indeed is the cause of the erroneous amount of manual breaks in the test document, but I didn't see any other likely spot. Change-Id: I0c2e8f738949776aa7f8ea5528e2c0eeb9351c16 Reviewed-on: https://gerrit.libreoffice.org/16063 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1ba1cbe48c40d649c33661abb32369c39a23fff4) Reviewed-on: https://gerrit.libreoffice.org/16080
2015-06-04Resolves: tdf#90435 secondary pool set to that of temp docs drawing layersCaolán McNamara1-2/+2
overwriting the original one, and when the temp doc goes away then its drawing layer goes away autoamtically settings the secondary pools of the other pools it is a secondary of back to 0 (see also tdf#87245) Change-Id: Ie6dd8d615f81cf4d4776eaeac1cc2507b2abaa37 (cherry picked from commit 8ae25bbc092254f680e2976873f15bdbc26615ef)
2015-06-04sc: Notify about the part change when searching.Henry Castro1-0/+19
Change-Id: Ieea445b64f72f270885d6e21d4070fefe8d82567
2015-06-04sc: SvxSearchItem, m_nStartPoint{X,Y}Henry Castro1-1/+18
The idea is that if you have your cursor at the begining of a Calc document, and you scroll down a lot, then search, then it's annoying that search jumps back to the start of the document for the first hit. Add an optional way to provide what is the starting point of such a search, so we can have "when nothing is selected, then search from the top left corner of the visible area". Change-Id: I22624dd52a093759d46541e003d838aeb0db943f
2015-06-04sc LOKit callback for search not found.Henry Castro1-0/+4
Needed for signaling the user when no match was found for the searched input Change-Id: I10089d065c26deea7cb57a9dc20f130f9afb6d99
2015-06-01tdf#91489 - CONDITIONAL FORMATTING: Crash on select Icon Set from dialogPhilippe Jung1-1/+0
Removed the recalcAll line in IMPL_LINK_NOARG( ScIconSetFrmtEntry, IconSetTypeHdl ) 1) ScCondFormatList already calls RecalcAll on selection new/changed 2) Without this line, it does not crash Change-Id: I8aa45f691d33d8ad046a88e7695913e2ccff3caf Reviewed-on: https://gerrit.libreoffice.org/15928 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 0b52089c1d88a5223981d8c177b3044d53eff700) Reviewed-on: https://gerrit.libreoffice.org/15944 Tested-by: Jenkins <ci@libreoffice.org>
2015-05-29convert WINDOW_POSSIZE constants to scoped enumNoel Grandin3-4/+4
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert WINDOW constants for GetWindow() methods to scoped enumNoel Grandin3-10/+10
Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin2-2/+2
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert POINTER constants to scoped enumNoel Grandin26-151/+151
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-28Resolves: tdf#90960 toggle out of paste-mode on editing an objectCaolán McNamara1-0/+6
otherwise pressing return in the object goes to the sheet and attempts to paste over the current cell reproduce with insert->comment in A1, insert some text and click in e.g. A5, ctrl c, right click on A1 and show comment, double click on comment to edit, go to end of text and press enter, either "bad things happen" if a11y is enabled , or "nothing happens" instead of a new line appearing in the object Change-Id: Ie44851cf3394652e1a60eecb59a999889094b3c5 (cherry picked from commit 7b75dc8ccca61988392779d4c61eef15f1211c16)
2015-05-28Rewrite all calls like Dialog(params).Execute()Philippe Jung10-11/+11
Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-28Resolves tdf#67712 form controls and draw objectsHenry Castro5-0/+327
anchored to cell but changes position after reopening Also included tdf#68797 "FILEOPEN lost position of lines anchored to cell". It was marked as duplicate but the step to reproduce are different. Conflicts: sc/qa/unit/subsequent_filters-test.cxx Conflicts: sc/qa/unit/subsequent_export-test.cxx Reviewed-on: https://gerrit.libreoffice.org/15523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 487880b6882ec01c1b4679eae60bec484272a86b) Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: Ia1c4010f118749256077a0ecad6ca16b867d22f7
2015-05-27tdf#91416 - fix some incorrectly allocated VirtualDevices.Michael Meeks2-2/+2
Change-Id: I9ebed313827986473c60e77b7e218b4c1b2487fe (cherry picked from commit f849d96463d967214bc063f6de912a082272c395)
2015-05-27Resolves: tdf#91416 setting progress -> resize -> destroy formula contextCaolán McNamara4-7/+35
i.e. setting progress triggers ScTabView::DoResize and an InterpretVisible and InterpretDirtyCells which resets the mpFormulaGroupCxt that the current rCxt points to, which is bad, so disable progress for the duration of the GetResult loop Change-Id: I8e88cee4dd2308ef61dee934d300a38978833703 (cherry picked from commit e3c1a394a00cef416a81b89b6d5c204891abb286)
2015-05-27Fix accidental mis-uses of VclPtr address-of operatorStephan Bergmann1-1/+1
Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb (cherry picked from commit 668408fa1c69eaf0f0a37f24e2ec8b4a38fe3db7, w/o the accidentally included sw/htmlexport-swobjects.patch)
2015-05-26Audit all PostUserEvent calls and instrument for VclPtr.Michael Meeks4-4/+4
Hold a reference on the VclPtr while we're waiting for the UserEvent. Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-26tdf#91499 - cleanup AnyRefDialog VclPtr's with an explicit dispose method.Michael Meeks2-1/+16
Change-Id: Ib3571fc6d2aa9343bcfd2d6a5bdbd6b1d193c0f1 Reviewed-on: https://gerrit.libreoffice.org/15883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-22tdf#54346 remove confusing description for function WEEKDAYWinfried Donkers1-1/+1
The output range mentioned in the function wizard is not always 1-7, but dependent of the value of argument Mode. The output range for each possible value of argument Mode is clearly described in the regular help for Calc. Change-Id: I23eae9be6f8f38319496aaf4a1b7f2349e2be3eb Reviewed-on: https://gerrit.libreoffice.org/15852 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Tested-by: Joren De Cuyper <jorendc@libreoffice.org> (cherry picked from commit b2cf675b827912feb5edfbca1ea902d1ab92ed6b) Reviewed-on: https://gerrit.libreoffice.org/15868 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-20ScIconSetFormatData::mbCustom read uninitialized...Stephan Bergmann1-1/+2
...in ScIconSetFormat::GetIconSetInfo, e.g. during CppunitTest_sc_ucalc Change-Id: Ia4380110cafdb0f220b99a8e1aeb5c3efde60d7f (cherry picked from commit 186b1e00017c163fdef5e8ceb1221c2d416b32cf)
2015-05-20bin/rename-sw-abbreviations.shlibreoffice-5-0-branch-pointChristian Lohmaier12-54/+54
renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-20Those #define-s are still usedKatarina Behrens1-0/+4
Maybe they don't have to be, but this fixes the build at least Change-Id: I278ecafcc96d8febc802c7a7ce907c98df95271c
2015-05-20tdf#91126: Enable click-on-column-header sortingKatarina Behrens1-7/+3
in the same way as in f92ab4da51647a4353038 Change-Id: I209475499307c5564774e1cd5808e3792a10be25
2015-05-20tweak to try and silence coverityCaolán McNamara1-1/+1
Change-Id: I990ad07784266e2b48638ece6a84471b3bef173a
2015-05-20convert DEFAULTCONSTANT constant to scoped enumNoel Grandin6-8/+8
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
2015-05-20convert DRAWMODE constants to scoped enumNoel Grandin4-15/+15
Change-Id: I36cbe8057d09226f8b302963bdd94dc5600b686f
2015-05-20convert GRID constants to scoped enumNoel Grandin2-4/+4
Change-Id: I73ae63bc5f41f38d1a4e396152808b22e88681d8
2015-05-20convert TEXT_DRAW constants to scoped enumNoel Grandin2-2/+2
Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
2015-05-20forgot to include that partMarkus Mohrhard1-2/+3
Change-Id: I8d905ca573e1ff15c4bf6049ce8884b223ff146c
2015-05-20better algorithm for OOXML column width import, tdf#91267Markus Mohrhard1-1/+22
This patch contains a magic factor of 1.047 that is necessary as the set value and retrieved value are not the same. When we ahve too much time (propably never) we should explore why the value that we set for the column width is not equal to the one that we see on the screen. Change-Id: I317127ea5b8af2d5e8386758e66907a44fe58579
2015-05-20add missing DoClose at end of testMarkus Mohrhard1-0/+2
Change-Id: Ia06522ba4d3e6b4495e17d260d0bc3618b1a7cf2
2015-05-19Typo: SetCharAttriutes->SetCharAttributesJulien Nabet3-3/+3
Change-Id: I889f67f1bc097b171ba416cd07d1a54a0cbc542d
2015-05-19draw Note mark before text for correct ZOrder tdf#89182Laurent Godard1-5/+5
the cell content is now drawn over the cell note rectangle Change-Id: Idce05497b7a9f67e5e315f5bc2f9c59e53898131 Reviewed-on: https://gerrit.libreoffice.org/15802 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-05-19tdf#91364 - fix data-pilot and auto-filter popup lifecycle.Michael Meeks2-1/+3
Change-Id: I6bc94025da3d6536b38cb43eef262d1d5f4c4c4c
2015-05-19fix Windows buildNoel Grandin1-1/+1
after my commit 10749bbf8247f0b17201b33f95a090dfc4fc3211 "remove the last of the OUString #defines in header files" Change-Id: I0db573b59571ed859d14e5e7d5550cfa0335234d
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 02:37:10 +0000