summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2018-01-17Resolves: tdf#114539 only pop own parameters from stackEike Rathke1-1/+2
... and not another pending one.. Change-Id: Ief5c27ccfb0b4121f2ba019e0fb8770dabbf60cf (cherry picked from commit 4b444b4c1efc2be219e6975e30048ff616fdac0f) Reviewed-on: https://gerrit.libreoffice.org/46801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit a8a8559a24d043b4b1180acb3a0ff60052be5fad) (cherry picked from commit 4cbde23fb6ebde6743c2cca0eeeee916e71bcb4e)
2018-01-17handle ocWebservice similarly to ocDdeCaolán McNamara10-45/+252
might have too much in here seeing as we don't need to worry about ocWebservice calling into itself Reviewed-on: https://gerrit.libreoffice.org/47819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e1946d75a1095c2596d7815600454ff01fcd3270) Signed-off-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 78c1ae24007d8098ee4f4add6d72e84411181785) Change-Id: I0145f38cc1c1f9ff514a496f7101d81cde9e7c67
2018-01-17Better handle ScDde formulas with missing dde-link entriesCaolán McNamara7-11/+19
typically each ScDde formula has a matching table:dde-link which results in a ScDdeLink getting inserted during the load. If that dde-link is missing then no ScDdeLink exists and ScDde() will create a new one without cached content. So detect that ScDde is used in the freshing loaded ods and defer fetching new content until the right time. only call GetHasMacroFunc to set SetHasMacroFunc and bHasMacroFunc is not accessed any other way, so this is an oxbow Reviewed-on: https://gerrit.libreoffice.org/47757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b0597ba5d745974fce752e1b677451a19350d351) Reviewed-on: https://gerrit.libreoffice.org/47818 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 4ede45eb239b1604bca900c22481b7d13e4c2790) Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I016b53288076d83dd49e92e245346a5f7f560522 (cherry picked from commit 3139914eb6379837fbf309642a63371128042db1)
2018-01-17VclPtr, missing disposeCaolán McNamara1-1/+1
Change-Id: I790cd8be0d461d4c82c9b1c64e334bd37115dcaf Reviewed-on: https://gerrit.libreoffice.org/47803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 06a2ffe863501e8bef88cd0201bd5e8d73e92242) Signed-off-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 932508baccd9b97c761980d36ae45e1ae0d85157)
2018-01-17limit WEBSERVICE to http[s] protocolsCaolán McNamara1-0/+9
and like excel... 'For protocols that aren’t supported, such as ftp:// or file://, WEBSERVICE returns the #VALUE! error value.' Change-Id: I0e9c6fd3426fad56a199eafac48de9b0f23914b3 (cherry picked from commit c6c3ed3c750a3c71cb57909c60773fde2c43cd2a)
2018-01-17Windows build fix - uninitialized variableSzymon Kłos1-1/+1
docsh4.cxx(1186) : warning C4701: potentially uninitialized local variable 'eLang' used Change-Id: I9a885cb8ce26f11f43c44ac1ca602d03ef84dfed Reviewed-on: https://gerrit.libreoffice.org/45988 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 0f685ee5a0913cab5826eec737f25328fabf256d)
2018-01-17disambiguation (build fix on Windows)Andras Timar1-1/+1
Change-Id: Icd42b11564b715754b125af6cbcd1d1a359eb5bd Reviewed-on: https://gerrit.libreoffice.org/45494 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit fe96bca99cf378579a204813eb88bef143c24fe4)
2017-11-28tdf#109240, tdf#112571: don't export dupe built-in named rangesAron Budea2-3/+7
XclTools::GetBuiltInDefNameIndex(...) only checked for prefix used in binary Excel format, and didn't recognize OOXML built-in names, which resulted in saving them twice in OOXML files. Adapt to check both binary and OOXML prefixes, similarly to XclTools::IsBuiltInStyleName(...). Saving "bad" files after the fix will purge bad "_0", "_0_0" etc. suffixed built-in names due to how GetBuiltInDefNameIndex(...) works. Change-Id: I1bbe11f9c654a142a4626003df4cb0fd2a0f9c71
2017-11-28lok - calc: outline and group handlingMarco Cecchetti14-37/+377
Change-Id: Ibb287468653bc381acf034dcb8531c5faf61aef3 Reviewed-on: https://gerrit.libreoffice.org/45416 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-11-28lok: sc: subdivide headers data in rangeMarco Cecchetti1-1/+10
Change-Id: I984b5da5774f97172de7659ecab84675060f8301 Reviewed-on: https://gerrit.libreoffice.org/45415 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-11-28lokdialog: Move the LOKWindowId <-> VclPtr<Window> mapping to Window.Jan Holesovsky2-9/+0
This allows registering & de-registering of non-sfx windows too, and makes the Calc autofilter popup to appear. Change-Id: I7cbbe94d208115aabcb6fa5f964646c7b7ce4c93
2017-11-28lokdialog: Move the painting down to Window, and enable Calc and Impress.Jan Holesovsky2-0/+9
Tested with .uno:FormatCellDialog in Calc, Impress not tested. Change-Id: I6d911c29616988db0625be9e2a63cf2172c69ee8
2017-11-28lokdialog: Make the Autofilter popup notify about its creation.Jan Holesovsky1-0/+1
Change-Id: Ib4062fa887b44eb1368205a414f4ac162f648c5c
2017-11-27tdf#111907 Allow box in Manage Names dialog to expand on resizingAndreas Brandner1-1/+4
Reviewed-on: https://gerrit.libreoffice.org/41946 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 9c34471f54870fc685c343f4af30310e75d3a9ca) Change-Id: I821e12d771d574dd191d9be86a19c23288902d5b
2017-11-27ofz: special case max index for cSymbolCaolán McNamara1-0/+2
Change-Id: Ia5fb036196b0cff0739789e691a36d294660540b Reviewed-on: https://gerrit.libreoffice.org/44759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit a5550289a37950195b7a7e5b22cba79ce5b5a673) Reviewed-on: https://gerrit.libreoffice.org/44803 (cherry picked from commit 701e1ec3a2e38a7b0bd2cdd3511a2a50578ea74e)
2017-11-27ofz#4123 do not read past end of fileEike Rathke1-5/+25
Change-Id: I1fa3543d541ea084a43a1a11f62680fa798f5647 (cherry picked from commit 78bcc5ddca186f0009124a697184f332405d3e1e) Reviewed-on: https://gerrit.libreoffice.org/44586 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6ba9b72cff5a761f36b2b9b892b572bc7cb5ae18)
2017-11-27ofz+valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara1-1/+1
if, before lcl_UnicodeStrNCpy is called, aSymbol contains embedded nulls then the aSymbol.getLength() and the mnRangeOpPosInSymbol value derived from an earlier aSymbol.getLength() include the range after the embedded null, while lcl_UnicodeStrNCpy stops at the first embedded null leaving cSymbol with uninitialized value that are later read from it. Conditional jump or move depends on uninitialised value(s) at 0x23BFBCA0: ScCompiler::IsReference(rtl::OUString const&, rtl::OUString const*) (compiler.cxx:3275) by 0x23BFFF4C: ScCompiler::NextNewToken(bool) (compiler.cxx:4248) by 0x23C00D20: ScCompiler::CompileString(rtl::OUString const&) (compiler.cxx:4419) by 0x23A29FAF: ScFormulaCell::Compile(rtl::OUString const&, bool, formula::FormulaGrammar::Grammar) (formulacell.cxx:1118) by 0x23A278B7: ScFormulaCell::ScFormulaCell(ScDocument*, ScAddress const&, rtl::OUString const&, formula::FormulaGrammar::Grammar, ScMatrixMode) (formulacell.cxx:656) by 0x23772EC3: ScColumn::ParseString(ScCellValue&, int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam const*) (column3.cxx:1729) by 0x2377354B: ScColumn::SetString(int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam*) (column3.cxx:1851) by 0x23AE2B97: ScTable::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (table2.cxx:1369) by 0x23897045: ScDocument::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (document.cxx:3377) by 0x1F35F41C: ScEEImport::WriteToDocument(bool, double, SvNumberFormatter*, bool) (eeimpars.cxx:400) by 0x1F366F3B: ScFormatFilterPluginImpl::ScImportRTF(SvStream&, rtl::OUString const&, ScDocument*, ScRange&) (rtfimp.cxx:34) Change-Id: Iefc6be6c3a383bd9b3cdeaa896c07e24e5100dc7 Reviewed-on: https://gerrit.libreoffice.org/44658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 6be596c282f84a3cb3a62edccfdfbf69663cf59e) Reviewed-on: https://gerrit.libreoffice.org/44690 (cherry picked from commit 8959754d2617dad38968ca008791e6431afcbdbd)
2017-11-27ofz: bad mnRangeOpPosInSymbolCaolán McNamara1-0/+2
Change-Id: Ieae5a81a1b475fd56cce76c43dab11c2d9fcbe6c Reviewed-on: https://gerrit.libreoffice.org/44499 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit f17640a95b4c65809f8573c778a293c836a847cd)
2017-11-22Resolves: tdf#111428 swap ScColumn::mnBlkCountFormulaEike Rathke1-0/+3
This is a combination of 2 commits. (cherry picked from commit 423df1fa929784c14e3a133c06468589fe9269cd) (cherry picked from commit 911e2aff3cc37cb7410292728ffea05fffbfb0b3) CellStoreEvent remembered the original ScColumn::mnBlkCountFormula, hence after inserting a column to the left the quick check of ScColumn::HasFormulaCell() whether there are any formula cells worked on the swapped in count (originally the one to the right) that happens to be empty in the scenario. Things worked correctly by accident if the next column to the right already contained a formula cell. c44fed96c49bea7365bf1200e06788860966795c Change-Id: If993856ceee657736f516a81c293506041a6b7eb Reviewed-on: https://gerrit.libreoffice.org/44210 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Eike Rathke <erack@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/44493 (cherry picked from commit 7f1297d9b4f449eb9ada8008fb21b7046d1a8f19)
2017-11-15TypoPranav Kant1-1/+1
Change-Id: I2ecf3050aa68a0f2986c43b651d71b662a77e55a
2017-11-01tdf#113268: Pivot table: Missing popup button after opening a ODSTamás Zolnai4-1/+32
Wrong row number was calculated here. This ++nCurRow is usefull only when headerlayout flag is set. It's a MSO compatibility flag so it's not there by default in LO created tables. Reviewed-on: https://gerrit.libreoffice.org/43552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 291874c09c4bcde61f2c6808f2df6079f38d74e0) Change-Id: Id7989d898f2647f1ba45ed95e0aa615e3b4fa311 Reviewed-on: https://gerrit.libreoffice.org/43974 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-11-01tdf#113159: Pivot table: tabular mode is converted to oultine modeTamás Zolnai3-13/+64
... after RT XLSX in Calc Reviewed-on: https://gerrit.libreoffice.org/43537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 8cf0b4b4cd748094889a6a9ac6883dd457113b74) Change-Id: I9725ca55aed973133db1d5fe47463575148e00b8 Reviewed-on: https://gerrit.libreoffice.org/43971 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-26sc lok: fix spell checking languages in CalcHenry Castro7-0/+158
Change-Id: Iadcc3b55a30ce2a2c785366fb3807ff6e4bda1fe Reviewed-on: https://gerrit.libreoffice.org/43581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/43701 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-10-18Resolves: tdf#112780 no ResetDirty() after SetHybridEmptyDisplayedAsString()Eike Rathke1-1/+6
Change-Id: Idea5c1bd8e8577eaf90fc47d39f88c79963c422b (cherry picked from commit df778416981ab02d42182e5c2e46dc09ba2e2a3c) Reviewed-on: https://gerrit.libreoffice.org/43048 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8d9b236dcb3fd0f7028e4d19ede04589cf85d760)
2017-10-18Resolves: tdf#100822 use sax::Converter::parseDateTime() for 'd' ISO 8601 dateEike Rathke1-8/+11
Instead of squeezing the string through the locale dependent number parser (which should force '.' Time100SecSeparator for 'T' ISO 8601 but apparently doesn't yet) that is a bottle neck anyway. Change-Id: I70f74e680322a715c9cc658c8be033620d9798e3 (cherry picked from commit 5374c04a89e1720490a3625dfd95406c2d60c0cd) Reviewed-on: https://gerrit.libreoffice.org/42971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit d4dad2989071eb5a21d608aa5c3782a68fddf571)
2017-10-18Resolves: tdf#103734 propagate error from matrix to MIN()/MAX()Eike Rathke2-2/+14
(cherry picked from commit 9e694c747954078442d47d3d7bd1d4db283b96ff) Conflicts: sc/source/core/tool/interpr1.cxx Backported. Change-Id: I1ebc5baf4957ef9e3d1477b803cf7fee02754360 Reviewed-on: https://gerrit.libreoffice.org/41886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 149f28e9a5d66db18ffb36547b2ba394c303fc4d)
2017-10-18Resolves: tdf#112523 do not use anything Ascii in UI contextEike Rathke1-1/+1
Change-Id: I0854f7b1e6e0bf51d8b4c7d846fad9b0ff25e763 (cherry picked from commit 86910087fa41956aad6a22943bfbeb158e205dcd) Reviewed-on: https://gerrit.libreoffice.org/42872 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit f38e9f1d194e23e455c69e9417185986daeccc39)
2017-10-15tdf#109016: Avoid to write the same pivot item member more timesTamás Zolnai3-2/+20
It seems it's allowed to have the same member name in a pivot table. We need to handle this in the filtering code. Regression from: 625653c8d119e720fb93b0c9f6f50d1eb625b179 Reviewed-on: https://gerrit.libreoffice.org/43230 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit fe6ea004872c86c4a2e5849c7c9e75905711d6f3) Change-Id: Ic6f4110da3d83f4bbf5284e1b772e9e31b250bf1 Reviewed-on: https://gerrit.libreoffice.org/43233 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-07tdf#112946: Pivot table: Missing selector for a row field after RT in CalcTamás Zolnai3-0/+25
We need to explicitly set compact flags to false, since true is the default. It seems MSO prefers compact mode, when the file contains colliding mode flags. Reviewed-on: https://gerrit.libreoffice.org/43210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit ad439ded005cffd525ffe874f535fca7a4da1f49) Change-Id: Ib311f1cf44345be294e6c6607c227c2baa0fb693 Reviewed-on: https://gerrit.libreoffice.org/43218 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-07tdf#112893: Pivot table: filtering of error item is not importedTamás Zolnai6-7/+40
... from XLSX Reviewed-on: https://gerrit.libreoffice.org/43166 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 9fa34e9f2cebe2cfc551668f2a67ddcb799d3fb8) Change-Id: Ib155852e5f0718f41e02596d1042513286c6d845 Reviewed-on: https://gerrit.libreoffice.org/43216 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-07tdf#107711:Pivot table: filtering of non-string fields is not exported to XLSXTamás Zolnai10-8/+390
Same issue what we have in case of XLS filter. We need to have the right string representation of pivot field items. Reviewed-on: https://gerrit.libreoffice.org/42956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 625653c8d119e720fb93b0c9f6f50d1eb625b179) Change-Id: Ifb686ad268c61b03c7dcccc66f65e6f8247eab4f Reviewed-on: https://gerrit.libreoffice.org/43053 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-07tdf#112936: Pivot table: LO created XLSX file makes Excel to crashTamás Zolnai1-0/+1
It's not actually clear, why Excel crashes, but setting the version makes it working. I expect that this version number (which specifies MSO Excel versions) makes MSO to handle the pivot table differently. As the internal implementation of the pivot table was changed in different versions. The name "DATA" might had a special meaning in the earlier versions (e.g. XP, MSO 2000) which leads this crash. So setting the version to MSO 2007 seems a good solution for this. Older versions not seems a target of LO exported XLSX files in these days. Also smaller values leads to the crash described in the bug report. Change-Id: I6e9edc949d1670d657effff9277cfd86ff163458 Reviewed-on: https://gerrit.libreoffice.org/43208 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit bab595df78bd05a45f92aa15dca058f27b86d5be) Reviewed-on: https://gerrit.libreoffice.org/43217 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-07tdf#112884: Error string is displayed as empty item in pivot tableTamás Zolnai1-1/+1
Need to get the right string representation of error cells. Based on the code it seems a regression from: d4cd8677889ec3807c194ef5b462f8e031807e5b Reviewed-on: https://gerrit.libreoffice.org/43146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit ee46269003aed237edcd9c086fd14ecded08bbeb) Change-Id: I30001e63cd17ae68ba4988d5825de479a4496326 Reviewed-on: https://gerrit.libreoffice.org/43215 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-07tdf#112735: Pivot table: page field displays empty stringTamás Zolnai1-1/+6
... instead of the "(empty)" string Change-Id: I2df84393b5213a57e941c9447e4367d7605a6b00 Reviewed-on: https://gerrit.libreoffice.org/42957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 8a4df9376bf299beb49fe116882ffdbd10b5e02b) Reviewed-on: https://gerrit.libreoffice.org/43052 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-07tdf#112733: Pivot table is displayed wrong in Excel after saved in LO CalcTamás Zolnai3-1/+24
Reviewed-on: https://gerrit.libreoffice.org/42955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 9e81e845d8299f117e96c30e8b40fcf602e9ca2c) Change-Id: I5dad2ff95ab5dd090296cf8c6e4a8274355c262b Reviewed-on: https://gerrit.libreoffice.org/43051 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-03lok: temporary workaround: disable formula mode for onlineMarco Cecchetti3-0/+44
- Start empty spreadsheet, open it with two users (let's call them A & B). - Type "=" with user A. - Start moving around to different cells with user B. => Cell name of user B's selected cell is entered in user A's formula. This is due to the fact that ScModel::GetInputHandler() returns always the input handler which is handling the edited formula and not the input handler of the current view. That really messes up collaborative editing, so better to disable it, until we implement an alternative solution. Change-Id: I6e779cba3f377d12b7a4a19a6ee53c924fc9ba20 Reviewed-on: https://gerrit.libreoffice.org/43036 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-09-28tdf#86083 Restore old operation buttons but have them hiddenYousuf Philips1-0/+6
Change-Id: I7d006d3d5e22ade59ddfe46f21fbc777a1c75dac Reviewed-on: https://gerrit.libreoffice.org/42684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit 7dc82cc2e424b6acddb1aa06338f51db20e6a21e) Reviewed-on: https://gerrit.libreoffice.org/42687 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8a808dcb220e068f224266c0dab3fe8dd16a2964)
2017-09-26tdf#112089 add charts to the ShapeMapSzymon Kłos1-1/+2
Charts weren't added to the collection what resulted in missing ids during export (target field). Change-Id: Ie96a4e33a52c5448342a3c3dcec0d8e8b244e270 Reviewed-on: https://gerrit.libreoffice.org/42552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-26tdf#112005 xmloff: ODF export: export embedded object text *first*Michael Stahl1-0/+22
... before adding any attributes, so that the attributes don't erroneously get added to the paragraph element. Also fix the problem that if you set "ODF format version" to 1.1 or 1.2, export asserts in SvXMLNamespaceMap::GetQNameByKey() because the "loext" namespace isn't registered, and creates an invalid <p> element. Change-Id: I637f9d3ff746d877ced480e35ef53f4545a06a4b (cherry picked from commit 86f256596c8566e80993e1cf6035bc3534b6f816) Reviewed-on: https://gerrit.libreoffice.org/42569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 65c99825ceb08743a70b6e598f65491a67d9a884)
2017-09-25tdf#112501: Pivot table: popupbuttons are placed on wrong cellsTamás Zolnai9-2/+133
...imported from XLS Reviewed-on: https://gerrit.libreoffice.org/42508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 0098bee792c3e208ea4f6ef1c676958d3f4cd207) Change-Id: I45bc4a0182e6a62471bc02ac1bca31f9735e6566 Reviewed-on: https://gerrit.libreoffice.org/42647 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-19ofz#3412 SYLK import: check ;X;Y;C;R col/row validity earlyCaolán McNamara1-0/+10
Change-Id: I91fcd2571e528201e01467f3bcdbbff30cdfb50c Reviewed-on: https://gerrit.libreoffice.org/42426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 51854f5432de42bcc1154469edb5395328870613)
2017-09-19tdf#111305: Fix group name refresh in pivot tableDimitri Bouron1-0/+14
Change-Id: Ibc22bfba5765aba3014651df50afb23b893d2b5a Reviewed-on: https://gerrit.libreoffice.org/40712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 3d37e10684edf9536beefe5670b144571e6c9792)
2017-09-18ofz#3362 SYLK import: check ;X;Y;C;R col/row validity earlyEike Rathke1-0/+20
Change-Id: I37d5ce67f975b6b89c4b8a9baefae2467da2eb84 (cherry picked from commit 34ac0f9a0376b43bcff78a49ccaf4caa34c8c990) Reviewed-on: https://gerrit.libreoffice.org/42278 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c759f30a5220dfd29894e34ee16c3fe2bf415592)
2017-09-14tdf#112348: Pivot table: page field filtering is not imported from XLSTamás Zolnai4-29/+141
Reviewed-on: https://gerrit.libreoffice.org/42201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 55a43f30a54816e13eb6704a8ec5952a63b01a64) Change-Id: I3477cd17f679bdfefb9340656999630380713d3f Reviewed-on: https://gerrit.libreoffice.org/42225 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-14tdf#112337: Pivot table: empty / blank item is not imported from XLSTamás Zolnai4-3/+48
Reviewed-on: https://gerrit.libreoffice.org/42181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit d44c7ffda598d4d4e8a3963133735a771ba3fe30) Change-Id: I7ed9e5cacdf6df80b2f100d040cbbeda33b085d3 Reviewed-on: https://gerrit.libreoffice.org/42224 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-14tdf#112328: Pivot table, XLS: Popup button for column fields is missingTamás Zolnai1-2/+2
...after round trip in Calc Wrong heading row was exported. Change-Id: I410eeeff7d7af408de1ea8128b6b21ac0cc76ea5 Reviewed-on: https://gerrit.libreoffice.org/42175 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit bc9714fefb2dd2ad55a92aaacb6b246f354ed2c0) Reviewed-on: https://gerrit.libreoffice.org/42223 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-12tdf#112278: Pivot table: filtering of non-string fields is not exported to XLSTamás Zolnai14-50/+501
It is needed to use the right string representation of field value. During export this representation is available directly, next to the actual value. During import we can use the number format attached to the corresponding pivot field. Reviewed-on: https://gerrit.libreoffice.org/42069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 7c429ddca63c09a2b656715292968000bfe86a1a) Change-Id: Ie8f731f6c72d7f55f43c318e52d63dc4e993d9c0 Reviewed-on: https://gerrit.libreoffice.org/42137 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-10tdf#112306: containsSemiMixedTypes is true for blanks-onlyMike Kaganski3-46/+66
Also export containsNonDate Change-Id: I16283a272d51e6c305f8c381c359168c1e3848a8 Reviewed-on: https://gerrit.libreoffice.org/42130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42131 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-08tdf#111974: Ensure sufficient space for all sheets in FormulaBuffer...Dennis Francis3-1/+11
and not just for the number of sheet fragments. This is important because we changed the internal storage of FormulaBuffer from based on std::map to std::vector in d17a83fa549f828f29e6939b16ba8b568a75f95e Added simple unit test that loads the bugdoc in subsequent_filters-test.cxx Reviewed-on: https://gerrit.libreoffice.org/41792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk> (cherry picked from commit 20169423d492b58ab93fb0e8e9d2918c0baebc92) Reviewed-on: https://gerrit.libreoffice.org/41841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Conflicts: sc/qa/unit/subsequent_filters-test.cxx Backported. Change-Id: I7320dd537266e540d585d3fccfbb8665bba457c7 Reviewed-on: https://gerrit.libreoffice.org/42057 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 500b5727fd5902b7d14c6e707c2ad3d2b227bb1a)
2017-09-04tdf#111939: Fallback to getting view data from best view shell...Dennis Francis1-0/+6
...when ScDocShell::GetViewData() returns nullptr. This is needed when a macro is run from the macro editor window instead of running the macro from Tools menu in the Calc window. Change-Id: I89c23c2ec08e8e9907f02eb1389236111530058b Reviewed-on: https://gerrit.libreoffice.org/41733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk> (cherry picked from commit c864fc9eab79d0b24036588cf8fc37ef51bd1907) Reviewed-on: https://gerrit.libreoffice.org/41757 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 980fbcaf9de67013b1e72806de7746543040d48e) Signed-off-by: Andras Timar <andras.timar@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 05:42:14 +0000