summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2015-11-03Resolves: tdf#95395 force range reference to array only in array formula, ↵Eike Rathke1-1/+7
also tdf#95419 ... and not already if the function has a (ReferenceOr)ForceArray type parameter somewhere else in the parameter list. Regression triggered by commit 01eea7fe40c939311bf1920b6e8b4391a93c2e82 for MATCH, HLOOKUP and VLOOKUP first parameter, but behavior already present since OOo for LOOKUP; FORECAST in its first parameter, PROB, LINEST, LOGEST and TTEST in the last two parameters. Change-Id: I4a30ea3362f86274a048b0e3f47fa12da3001a3a (cherry picked from commit b5cd11b4b02a85a83db77ba9d8d1763f0cd88cb1) Reviewed-on: https://gerrit.libreoffice.org/19660 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-22Resolves: tdf#95226 fix broken IFERROR/IFNA array logicEike Rathke1-2/+3
Change-Id: I059248659f51746cfc1d06faeaadaf3d645c03d3 (cherry picked from commit 968e2faff6d4283dacd9010d31cb4c0df45eb7c5) Reviewed-on: https://gerrit.libreoffice.org/19522 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-09Resolves: tdf#93613 let referenced document evaluate macro configEike Rathke1-0/+16
... if the current document allows macros. Change-Id: I927981334e27d073696286ba680777a645d53653 (cherry picked from commit 8e2acdbcbd3afc1777d6e68a83ebbe6d8dd77645) Reviewed-on: https://gerrit.libreoffice.org/19266 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-05Probably good to move the more complicates test after the light-weight onesTor Lillqvist1-3/+3
We will return false if any of the tests here match, so good to test the trivial things first before ones involving a potentially complex function call. Change-Id: I531282041c888799d37d95ae773daa349e60a37d
2015-10-05tdf#94173: Calc doesn't save your own created autoformat presetsJulien Nabet2-1/+15
Auformat list (maData) is defined as "MapType" which itself is defined like this: boost::ptr_map<OUString, ScAutoFormatData> so default sorting is ascii 2 consequences: 1) Default didn't appear first 2) When adding a new autoformat entry when it was new first one of the list wasn't saved because of iterator was incremented first before looping See https://bugs.documentfoundation.org/show_bug.cgi?id=94173#c5 There were some other weird behaviors too according to comments of the bugtracker Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=72c1b6141d590fb4479925ed8bc88b79357c2bfc Solution: Add a Compare so Default entry is always first one so the first time incremented iterator is ok and new entry (even if new first one in list) is saved Thank you Markus for the idea! (I was lost in Compare syntax) Reviewed-on: https://gerrit.libreoffice.org/18598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 652158c3f2c9cd0d6f71ecd14bf5d5cc02a71b50) use collator for UI visible sorting, tdf#94173 follow-up (cherry picked from commit a71febc99d2cfc2fe51dec8c0bca5d84d8577168) b9f7ebb087c1ce5008f43b2df3f1fadc41066ed1 Change-Id: I9ba0cdc63c66b747db102bb661cd09fbfe5996ae Reviewed-on: https://gerrit.libreoffice.org/19029 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/19152
2015-09-30don't believe xls wrt size to reserveCaolán McNamara2-3/+8
(cherry picked from commit 358ca9eaa3d85236047a7a2781e38f57209c2858) Change-Id: Id9864f199e270d13d801348b12f1e94dd80558c7 Reviewed-on: https://gerrit.libreoffice.org/19043 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-09-27Resolves: tdf#85979 TextToColumns is overwriting, so set at ScImportExportEike Rathke1-0/+1
Change-Id: Id0fec512b53aab47f9951056e8726af0cce45708 (cherry picked from commit 624ab2e5a52e9b8aa139bae4cd1436d23b80bf8c) Reviewed-on: https://gerrit.libreoffice.org/18666 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-09-27follow up of tdf#94214Winfried Donkers1-0/+1
provide forward compatibility for name change of FINV Change-Id: I0afd2555be94c452172e5a357f2f0897be381863 Reviewed-on: https://gerrit.libreoffice.org/18814 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-09-25fix IterateMatrix for ifPRODUCT and ifSUMSQEike Rathke1-1/+2
... if more than one argument is passed to PRODUCT() or SUMSQ() and matrix/array arguments are involved the functions returned wrong results. For example, wrong behavior =PRODUCT({2,3},{4,5}) gave 6 =SUMSQ({2,3},{4,5}) gave 34 Correct is =PRODUCT({2,3},{4,5}) result 120 =SUMSQ({2,3},{4,5}) result 54 Change-Id: Iec7b136a5cc678416f28b1abfe19cd0901ef22b6 (cherry picked from commit c1780ad265ce5f6abb3b91a4f70bf2b3d7a47149) Reviewed-on: https://gerrit.libreoffice.org/18867 Reviewed-by: Łukasz Hryniuk <lukasz.hryniuk@wp.pl> Tested-by: Łukasz Hryniuk <lukasz.hryniuk@wp.pl>
2015-09-25Revert "Fix a bug in SUMSQ"Eike Rathke1-1/+0
This reverts commit 2c6b94672e8536ade098244c9c32e67dd23e119a. Just discovered that this is wrong, sorry for fuzz. Change-Id: I66f0d69ee6f558d2dc968ecdfff6f9dd42332a7e Reviewed-on: https://gerrit.libreoffice.org/18845 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-09-25Fix a bug in SUMSQŁukasz Hryniuk1-0/+1
The same one as was in SumMXMY2, with IterateResult. Change-Id: I18a5993493ca7514848baad25232f4c254c1e044 Reviewed-on: https://gerrit.libreoffice.org/18765 Reviewed-by: Łukasz Hryniuk <lukasz.hryniuk@wp.pl> Tested-by: Łukasz Hryniuk <lukasz.hryniuk@wp.pl> (cherry picked from commit 793d1aba304217dcea6707a4b8acf5ac09f62e5a) Reviewed-on: https://gerrit.libreoffice.org/18842 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-21Resolves: rhbz#1264585 check data pilot field name availabilityEike Rathke1-3/+9
Change-Id: Iaadf7044acb7299ee878de2fbc08992447587d62 (cherry picked from commit f09a91630c767370871389c28b81280807513431) Reviewed-on: https://gerrit.libreoffice.org/18752 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17tdf#61908 OOXML export cell range for matrix/array formulaEike Rathke1-17/+76
Problem Description: - Matrix multiplication cell formula range is not exported after roundtrip. XML Difference: Original : <f t="array" ref="G5:G6">MMULT(A1:C2,E1:E3)</f> Roundtrip : <f aca="false">MMULT(A1:C2,E1:E3)</f> Solution : Added formula cell range support for matrix multiplication. Reviewed-on: https://gerrit.libreoffice.org/16033 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com> (cherry picked from commit beb8e2830dc9e1c771e196fcaf08cdfd6bf3dde3) Conflicts: sc/qa/unit/subsequent_export-test.cxx Omitted test case and document from commit. fix 176 unbalanced XML_f xlsx export failuires regression from commit beb8e2830dc9e1c771e196fcaf08cdfd6bf3dde3 Author: yogesh.bharate001 <yogesh.bharate@synerzip.com> Date: Tue Jun 2 16:39:09 2015 +0530 tdf#61908:XLSX formula cell range is not exported for MMULT. (cherry picked from commit 103b619401f06697255167c788192601e87758b9) array formulas do not consist only of multiple rows, tdf#61908 follow-up For example, {={1,2}*3} is a two columns one row vector, or even a single cell could hold an array formula. (cherry picked from commit 92df7db85a3da10f18a5a06fb53a9cb69910e835) a54ce5ce437e592378fe930b779c518de9670995 14a44ac8356fdffc98b7097f48319755f5f2f317 do not write MM_REFERENCE formulas to OOXML, tdf#61908 follow-up The array range is covered by MM_FORMULA. Excel even complained when loading such a document. (cherry picked from commit f501fe4da88e1d64fcc88a492a52911113d28f6a) Change-Id: Ic871f064a98a324bc16a4253b633c97417c3f900 10e1b19fbfb8ea849ffe3d46504fdf3389633c5f Reviewed-on: https://gerrit.libreoffice.org/18593 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17Resolves: tdf#93895 broadcast cell changes when multi-selection was pastedEike Rathke1-4/+12
It is not sufficient to collect the cells, one has to broadcast on the collection. (cherry picked from commit 97ad6393525a928b5dfe2a6562d7604446da7af0) Conflicts: sc/source/core/data/document.cxx Change-Id: I11f889936aff43f958c56789e539809289819752 Reviewed-on: https://gerrit.libreoffice.org/18575 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17Resolves: tdf#94249 do not remove broadcasters while iterators are in useEike Rathke4-13/+21
EndListeningContext holds BroadcasterStoreType iterators in its ColumnBlockPositionSet and collects broadcasters to purge them at the end. Removing broadcasters from ScColumn::maBroadcasters in between invalidates the iterators. Hence calling the "normal" EndListening() that removes a broadcaster when all listeners are gone while an EndListeningContext is in use is bad. Change-Id: Ibdd88469e91e6173ceff1f391c23ef7cb7c6f596 (cherry picked from commit e4a8ae0bf54476e9a0c9e1f5348c05f3cd838899) Reviewed-on: https://gerrit.libreoffice.org/18618 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-11Resolves: tdf#92995 do not delete caption objects that are held by UndoEike Rathke6-6/+36
Drag&Drop Undo is a special case of ownership.. Change-Id: I2fe7769c4d84efe09d432335d5d8e72d506bf7a1 (cherry picked from commit 44f34c1163882c2e3086282374fee9cd55ee211f) Reviewed-on: https://gerrit.libreoffice.org/18474 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-31tdf#89245 xmloff: fix Calc header background image savingMiklos Vajna2-0/+16
Regression from commit 7d9bb549d498d6beed2c4050c402d09643febdfa (Related: #i124638# Second step of DrawingLayer FillAttributes..., 2014-06-02), the problem was that the new CTF_PM_REPEAT_OFFSET_X..CTF_PM_FILLTRANSNAME range's values overlapped with the existing CTF_PM_HEADERHEIGHT..CTF_PM_HEADERGRAPHICURL range's values, so when the new code in XMLPageMasterExportPropMapper::ContextFilter() tried to tweak header repeat offset properties, it actually disabled HeaderBackGraphicURL instead. (cherry picked from commit 3b40329f9a64b93b1e1230b1bff74ed8cda8cd70) Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: I9c2700fa71a4ef2a813ec671049ee9d98171b57e Reviewed-on: https://gerrit.libreoffice.org/18162 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-08-26Resolves: rhbz#1255811 implement Edit modify handlerEike Rathke8-9/+259
... and disable/enable Apply/Ok buttons for in/valid ranges. (cherry picked from commit ad1284df599f3493e7c76c7f8b4230aab1946558) implement Edit modify handler, rhbz#1255811 related Same as in ScRandomNumberGeneratorDialog. (cherry picked from commit da9ecf1a59b85eb93004507fe55b92f74c2cdb4c) implement Edit modify handler, rhbz#1255811 related Same as in ScSamplingDialog. (cherry picked from commit a88fecdcdbf0b3f6a5ba3375f8193a9dc7ba7422) implement Edit modify handler, rhbz#1255811 related Same as in ScStatisticsInputOutputDialog. (cherry picked from commit b2363e98af7b0281279617e43b8fec5b898b9120) 1bc9296bfc8b1b2b8f3fc20183e2c626f94dee09 ff709ec2284673efa8824a9b8cfc037e4d6d567a 0e3eb06bc86cf77c405c54f312340c7b2551c1ec Change-Id: I52b5eae2f34e3fca7c0761b14124477a0d160b01 Reviewed-on: https://gerrit.libreoffice.org/18010 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-25MATCH, HLOOKUP and VLOOKUP have a ReferenceOrForceArray parameterEike Rathke1-3/+3
tdf#91278 related Change-Id: Iab4728b07649bcbb1beb372e68369f3762b13a5c (cherry picked from commit 01eea7fe40c939311bf1920b6e8b4391a93c2e82) Reviewed-on: https://gerrit.libreoffice.org/17265 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-25Resolves: tdf#88402 remember sort "has headers" at anonymous database rangesEike Rathke3-0/+29
Change-Id: I4a126f40589fd401f3a63f74be5e86e3df947ef6 (cherry picked from commit 33255f974fc712b9e9e2965a350c65a2195a7ae6) Reviewed-on: https://gerrit.libreoffice.org/17140 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-21Resolves: tdf#58838 do not use collation for Equal/NotEqual operatorsEike Rathke5-20/+34
Unicode collation ignores control characters and other specific characters, see http://www.unicode.org/charts/collation/chart_Ignored.html and thus is not suitable to be used for Equal/NotEqual operators. (cherry picked from commit 1e5e7b9323c3321a380edf86097ccc2e3f0a7a7a) Conflicts: sc/source/core/tool/interpr1.cxx Change-Id: Ib84713e1da59d92e07bc974d93b6def8217bb067 Reviewed-on: https://gerrit.libreoffice.org/17238 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-08-18Resolves: tdf#92749 invalidate lookup caches after initial hard recalcEike Rathke1-0/+8
... because the caches are not setup as listeners during when the document's hard recalc state is active. Change-Id: Ie7ec84ee64d046e3e55ce26b92824e94a2f660e9 (cherry picked from commit f7e493229bd949066b4d8984dce7678b8687d1ae) Reviewed-on: https://gerrit.libreoffice.org/17832 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-17Resolves: tdf#93358 resync attribute pattern that may have changedEike Rathke1-1/+13
Change-Id: If3ce8feec940c7212fe467f39db868630522b17e (cherry picked from commit f089de7dc5c367a3123129b08a9050b3bacc4eba) Reviewed-on: https://gerrit.libreoffice.org/17766 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-17Resolves: tdf#93098 replace remembered listener when replacing cellEike Rathke1-2/+14
... where SvtListener* is the base of ScFormulaCell* and lead to use after delete. Change-Id: I45b8e16f05cf5d4d0d4858dc9cd0c748f8184978 (cherry picked from commit ea29d320754fdb21b336cb78f816b8081371def9) Reviewed-on: https://gerrit.libreoffice.org/17727 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-17Resolves: tdf#92448 check for numeric '.' only if sheet separator is '.'Eike Rathke1-1/+1
Change-Id: I427da08eed3fc5daed2bac4d588b66a3f03fd28c (cherry picked from commit 2fd3560e0815b547ada7d7f6557857fe3c8678ba) Reviewed-on: https://gerrit.libreoffice.org/17245 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-13Resolves: tdf#93388 broadcasting to removed listeners isn't a good ideaEike Rathke1-5/+15
This cures only a symptom, the underlying cause is that the broadcasters still are listed in maBulkGroupAreas. Change-Id: I9625483016a51eb6f6a7e3d58ed42c7dad3a57b3 (cherry picked from commit 2d4edd7de2e67db5bd17e7a89e2496611ebcc165) Reviewed-on: https://gerrit.libreoffice.org/17685 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-11Resolves: tdf#86024 do not attempt to shorten numeric value outputEike Rathke1-22/+30
Regression of 087a79db1272858f107656c5ca3c6efb45680986 Change-Id: I903e05234882c79e6da6499cb17e16fd7226f91c (cherry picked from commit 2a06a052b920f696a794c2fb847fce63038220e9) Reviewed-on: https://gerrit.libreoffice.org/17637 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-11tdf#79741: Macro with Find @ Replace crash CalcJulien Nabet2-4/+4
0x00002aaaaf4bd163 in SfxItemSet::GetItemState (this=0x0, nWhich=26182, bSrchInParent=true, ppItem=0x7fffffff1730) at /home/julien/compile-libreoffice/libreoffice/svl/source/items/itemset.cxx:422 422 SfxItemArray ppFnd = pAktSet->m_pItems; (gdb) bt 0 0x00002aaaaf4bd163 in SfxItemSet::GetItemState(unsigned short, bool, SfxPoolItem const**) const (this=0x0, nWhich=26182, bSrchInParent=true, ppItem=0x7fffffff1730) at /home/julien/compile-libreoffice/libreoffice/svl/source/items/itemset.cxx:422 1 0x00002aaaaf4bd306 in SfxItemSet::HasItem(unsigned short, SfxPoolItem const**) const (this=0x0, nWhich=26182, ppItem=0x7fffffff1730) at /home/julien/compile-libreoffice/libreoffice/svl/source/items/itemset.cxx:463 2 0x00002aaacd9902c9 in ScCellShell::ExecuteEdit(SfxRequest&) (this=0x312fe10, rReq=...) at /home/julien/compile-libreoffice/libreoffice/sc/source/ui/view/cellsh1.cxx:1032 See https://gerrit.libreoffice.org/#/c/17603/ for details Thank you Maxim! Change-Id: Ie4cf31e3764c02f335830c59674a94acd6c209df Reviewed-on: https://gerrit.libreoffice.org/17603 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 958ec9ccfe3bbe54369f9e9105c10beae80d9548) Reviewed-on: https://gerrit.libreoffice.org/17615 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit ed09c7638e3ea40fc40b51af5cf0b2018c5c78c9) Reviewed-on: https://gerrit.libreoffice.org/17649 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-20check annotation caption pointers, blind fix for rhbz#1242099Eike Rathke1-3/+6
Apparently there may have been situations when the caption or its shape could not be obtained for whatever reason. (cherry picked from commit 47d90af52a548429224c38b5c58a70116e0f7907) Conflicts: sc/source/filter/xml/xmlexprt.cxx Change-Id: Ie9b97d4b3999cb4645bb6b8b688b3666cfd71ccc Reviewed-on: https://gerrit.libreoffice.org/17222 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-20Resolves: tdf#92767 use ISO 8601 for internal date string representationEike Rathke1-0/+4
Change-Id: I481bf3295feb64827de2122234a9300d0b8ced40 (cherry picked from commit 3e17ed1fc2845da5a279d21ffa3ea51d637e515e) Reviewed-on: https://gerrit.libreoffice.org/17173 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-13tdf#89031 remove agressiveness from Calc function suggestionsWinfried Donkers2-34/+20
Change-Id: I7751a038f8482addc0e45c0461666bbd1c959d12 Reviewed-on: https://gerrit.libreoffice.org/16478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit f3d748937a177cbbc0033bcf54d0d0fd57a1b409) Reviewed-on: https://gerrit.libreoffice.org/17009 Reviewed-on: https://gerrit.libreoffice.org/17013
2015-07-09execute the terrible bottle neck loop only if there are conditional formatsEike Rathke3-2/+16
(cherry picked from commit 2aefb89b299e7ebdca5bb35aa4e9059e59805715) Conflicts: sc/source/core/data/documen7.cxx Change-Id: Ic8bd65a728289c9fa1a0721b0ecbd9b4a48672ca Reviewed-on: https://gerrit.libreoffice.org/16903 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-09Resolves: tdf#84762 collect all recalc-always cells before setting any dirtyEike Rathke1-6/+14
(cherry picked from commit bf35419b68d7f100a634572236f7d593638981c8) Conflicts: sc/source/core/data/documen7.cxx Change-Id: I38f69bcbb9eb550fb97b0f84bc0cb486863060b4 Reviewed-on: https://gerrit.libreoffice.org/16872 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-08use ScMatrix::IsValueOrEmpty() on math operators Mul/Div/Pow, tdf#91453Eike Rathke3-5/+21
... which aren't implemented at ScMatrix yet. Using IsValue() worked when errors were not propagated, and before that when errors were propagated because ScMatrix didn't have empty elements but instead was initialized to 0.0 Change-Id: Ib9c6d34f2e6a68e483b606923cbcc41a3c1d2f51 Reviewed-on: https://gerrit.libreoffice.org/16799 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-08always justify a referenced range in order, tdf#92468Eike Rathke6-0/+138
(cherry picked from commit d24c6a0280b0287ee6c23ca89068323c6b7c3dd7) (re-)introduce ScComplexRefData::PutInOrder(), tdf#92468 (cherry picked from commit ad3d2b6c2e88d191d76f90eb5be927f7ca76c670) introduce ScTokenArray::AdjustReferenceOnCopy(), tdf#92468 (cherry picked from commit 369ee0b1faf79f1bd23c75ee04dd0dcc5bf283af) call ScTokenArray::AdjustReferenceOnCopy() in ScFormulaCell clone, tdf#92468 (cherry picked from commit 3ddaeaab37d585971e376de6ad7b0f06f55f2e1a) f551e02a77a416b95f74266de896391d1d72eb3c 0a7ac0d9d10e96223cd5f095a771aa6f9d271417 0dc0c3528b35bc6ea2525bafb94d72ee65e4791a Backported. Change-Id: Id69c58800d28f1733777f7931a20d8ee7bdf034f Reviewed-on: https://gerrit.libreoffice.org/16829 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-08end/restart group listening in DeleteSelection(), similar to DeleteArea()Eike Rathke1-0/+63
Reproducer: * in A1 enter =SUM(B1:C4) * copy A1 to clipboard * paste to A2 and A3 * formula in A2 is =SUM(B2:C5) A3 is =SUM(B3:C6) * select A2:A3 * hit Del key to delete the two cells * enter any numeric value in B2 => formula result in A1 is not updated Shift+Ctrl+F9 hard recalc updates Change-Id: I55e55b8cfe69e9273170ceaea4e6c046b3d4f7b7 (cherry picked from commit a49b8af4cf03ae08cb7a28f66e24368a7b08ae3f) Reviewed-on: https://gerrit.libreoffice.org/16838 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-06This one should override SfxToolBoxControl::SelectMaxim Monastirsky2-4/+2
We don't have there Select(bool) since c3a89936abc7967ebe8916ca83cb38f6837f9aa1. (cherry picked from commit 4604a6a7cd66907fc29e01aacf2146f17fa19d34) (cherry picked from commit bc3c7f2557a1871fb1e41fc9cac4426a6b208901) Conflicts: sc/source/ui/cctrl/tbinsert.cxx sc/source/ui/inc/tbinsert.hxx Change-Id: Id496725d82289d1be004bdc36195877c12f336b0 Reviewed-on: https://gerrit.libreoffice.org/16773 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-07-03fix a11y crash seen on moving chart wizard dialogCaolán McNamara1-1/+2
Change-Id: Ic3ba292e28fe12d7dcc2c2e67aeea48a4c8aaac2 (cherry picked from commit b161552bd9f7d6b6de9752e4f0e7d6f65bbcf42e) (cherry picked from commit ea228fdffd17b87e398216625213a691fcb34825) Reviewed-on: https://gerrit.libreoffice.org/16714 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-07-02tdf#91641 adjust cursor when deleting preceding charactersJustin Luth1-2/+10
IMDeleteSurrounding is used by input methods to take multiple keystrokes and convert them into a special character. Then the composing keystrokes are removed. Before this fix, the cursor placement was not adjusted, so the special character was inserted in the wrong position and if 3+ keystrokes were involved, the wrong characters were deleted. Also fixes "editLine should have focus on accessibleText init." The first time an accessibleEdit is created, it didnt recognize any focused text when editing in the "Input Line". Change-Id: Ib2608c46bba1c84bb49aa29619a004c125a3bf98 Reviewed-on: https://gerrit.libreoffice.org/16637 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-30tdf#44419 in second reference part stop number parsing at separatorEike Rathke1-0/+12
Change-Id: I70218bc41df0d56ab42d652aa7ac51733dc06f4b (cherry picked from commit 71dba79c1c84d693a59c53a8965caef0ddd1c2cc) Reviewed-on: https://gerrit.libreoffice.org/16496 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-30Resolves: tdf#83365 push proper references in INDIRECTEike Rathke5-4/+101
... that take relative/absolute addressing and sheet 3D flag into account to be fed to reference extension via range operator. (cherry picked from commit fb6dd2a73074b9695bd8ddf7ba40f1819b03024e) properly inherit relative and 3D flags when extending, tdf#83365 related Commit 194e9f9bae28bdf22a9ed4779c1656ee693f3302 oversimplified things. (cherry picked from commit e503addfbbe45efe1a3c06392c66fb79c3c72d07) Change-Id: Iabe13ae384577e2d71ca87af6482ddccbf7ad0ac ea6a84c4a7be49af036690afbb1512ae2c1045a2 Reviewed-on: https://gerrit.libreoffice.org/16352 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-30tdf#90717 prevent crash, not really fixedEike Rathke1-1/+32
Try to resync shared group top and length. Change-Id: I31bd0db7c1dceb880a22274edc4c3f20ce253095 (cherry picked from commit d8541c2a62121894bf87c91f1f89aea1ea30d680) Reviewed-on: https://gerrit.libreoffice.org/16533 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-30Resolves: tdf#31577 volatile lookup ranges must not be cachedEike Rathke1-1/+7
Change-Id: Iac8574329c8c8e0bc0ac956993ccdd085372a6cc (cherry picked from commit 5e83f49e5d62587f427ad416f5188ce81506c05b) Reviewed-on: https://gerrit.libreoffice.org/16598 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-25a singleton must be fully parsed to be valid, tdf#44419 relatedEike Rathke1-2/+2
No trailing characters must be present in 1:1 or A:A full row/column references, e.g. 2:2,2 is not valid. The original cause is the lexical analyzer that accepted 2,2 as the second part after the range operator because ',' is also the group separator here, which needs further changes. Change-Id: Iff354469f7dcb4e0b6fa645c39cc1f8ebad4a6ea (cherry picked from commit c48af2b55a60492565b987ee65d98edc6bd94533) Reviewed-on: https://gerrit.libreoffice.org/16490 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-23LinkUpdateMode is a global settingStephan Bergmann2-4/+24
(cherry picked from commit 77cc71476bae2b3655102e2c29d36af40a393201) Conflicts: sw/source/core/doc/DocumentLinksAdministrationManager.cxx sw/source/filter/xml/xmlimp.cxx Change-Id: Ida1257337c6e0916f2228fe053d9c9f085183af6 Reviewed-on: https://gerrit.libreoffice.org/16422 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-06-17Resolves: tdf#86305 clone upper left of matrix result if double tokenEike Rathke2-5/+20
Change-Id: I541577e0b99b0144a755e5755adc890c0ca8d204 (cherry picked from commit ffc1ffed11dc63a69fc2db04f12b3ea266b580fe) Reviewed-on: https://gerrit.libreoffice.org/16326 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16do not access token data after token has been destroyedEike Rathke1-1/+1
Change-Id: I624e64745fd3874be3e1bd3df6bac18dfb17aebb (cherry picked from commit c1fc84ac140d519e0bfa7a607e36771682b08eed) Reviewed-on: https://gerrit.libreoffice.org/16258 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Resolves tdf#67712 form controls and draw objectsHenry Castro1-0/+59
anchored to cell but changes position after reopening Also included tdf#68797 "FILEOPEN lost position of lines anchored to cell". It was marked as duplicate but the step to reproduce are different. Conflicts: sc/qa/unit/subsequent_filters-test.cxx Conflicts: sc/qa/unit/subsequent_export-test.cxx Reviewed-on: https://gerrit.libreoffice.org/15523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 487880b6882ec01c1b4679eae60bec484272a86b) Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: Ia1c4010f118749256077a0ecad6ca16b867d22f7 (cherry picked from commit b1f1c77687e301c99e81631d33298e44bdb5ca84) Reviewed-on: https://gerrit.libreoffice.org/16280 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Resolves: tdf#91411 end listening only on selected sheetsEike Rathke1-4/+7
... not in cell areas of all sheets. (cherry picked from commit 80ec99db4325a439a8a3f1d420d0a80f8bf9c439) Conflicts: sc/source/core/data/document.cxx Change-Id: I8d19c15c6d8d89652ac5695214bc4dd930783087 Reviewed-on: https://gerrit.libreoffice.org/16303 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-15Resolves: tdf#89643 report builder function wizard segfaultsCaolán McNamara2-7/+10
regression from commit 3d6521280929ecacc53b7c358d29d0b5d31b3462 CommitDate: Thu Jul 31 22:14:25 2014 +0200 fix memory leak around function descriptions Found by Lsan. There are two implementations of getCategory, one (sc) returns a new one each time (hence the leak fix) and the other (reportdesign) returns a pointer to one that belongs to the manger (hence the crash). The code in formula really looks to me to expect that the getCategory return a pointer that "someone else" needs to look after, i.e. the reportdesign variant is the more correct so revert 3d6521280929ecacc53b7c358d29d0b5d31b3462 and to fix the leak make the sc own the ScFunctionCategories and just cache them like the reportdesign one does Change-Id: Ifd986301a54b4d20449e864697655cd973e0c4df (cherry picked from commit 7c3abee29c742593206b755b20a718c46f0780fa) (cherry picked from commit 73107eb3375f1671f549f0467be2812df9223848) Reviewed-on: https://gerrit.libreoffice.org/16232 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 20:35:58 +0000