summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2016-10-10Resolves: tdf#101562 ScRefUpdate::Update() needs to flag sticky even unchangedEike Rathke2-4/+21
... so area broadcasters can be "adapted" (though not changed) and broadcast a change to invalidate listening lookup caches. This is the delete row part of the bug scenario. (cherry picked from commit 866eb4a7f93414932b8669d1a6afe0611655dfb4) tdf#101562 inserting within an entire col/row reference needs to flag change This is the insert part (e.g. Undo) of the bug scenario. (cherry picked from commit 180fe3e991432a5ab1ef573686ff9b35c732756b) 87060bd9f0ad6d58a11308e58e7ce56875327c52 Change-Id: Ie6072a6b8e7967faa135a3c4d0a9024b6afcd69c Reviewed-on: https://gerrit.libreoffice.org/29595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-10skip hidden rows/columns for spellchecking, tdf#99607Markus Mohrhard1-2/+22
Change-Id: Ic84368f4bb70973c3c5f5293d852fc573c5f73f7 Reviewed-on: https://gerrit.libreoffice.org/29601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit eadd75ef212b4dd1b43aeacb34c8dd3ab40df369) Reviewed-on: https://gerrit.libreoffice.org/29609
2016-10-05Resolves: tdf#101711 revert attempt to drop unused bg imagesCaolán McNamara1-1/+1
for 5-2/5-1 simply revert the effort Revert "Related: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if..." This reverts commit 914d72ee1edb351e4975a516240a38696f619217. Revert "Resolves: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if..." This reverts commit de4908eb4d2f1f2ce38a37eea18a9efc4a0073b1. Revert "use unique_ptr" This reverts commit ee4f35090657fdce572c5bc6238aceb4098a6e4e. Revert "fix typo" This reverts commit a084962e8c3deaeb3c1b6b9119215b48cf27e76e. Revert "rbhz#1326602 avoid exp. bg bitmaps from deleted slides" This reverts commit b876bbe2cacce8af379b10d82da6c7e7d229b361. Change-Id: I65a2f50d1087d6f8bb94d8bb73d54d3f378c6800 Reviewed-on: https://gerrit.libreoffice.org/29490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-10-04tdf#99386, broadcast that cell content changed after merge cells undo/redoMarkus Mohrhard1-0/+2
Change-Id: Idf41d1b07e26af66d9eefd18e5d5b582edc205e9 Reviewed-on: https://gerrit.libreoffice.org/29370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit f6f213bed507d1d7547f6098a67b6e460d46bce6) Reviewed-on: https://gerrit.libreoffice.org/29376 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-04tdf#101910, mark ScRangeList updated when DeleteArea was usedMarkus Mohrhard2-4/+20
Change-Id: I98390b28c5a1bbbd391ff054b2f574951c7c00c4 Reviewed-on: https://gerrit.libreoffice.org/29422 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 5f658dc87794036182aa1f8586d82c5ee997cd8b) Reviewed-on: https://gerrit.libreoffice.org/29424 Reviewed-by: Eike Rathke <erack@redhat.com>
2016-10-04support TargetFrame in url field import/export code, tdf#77873Markus Mohrhard7-8/+20
Change-Id: Id09ecbd10b8ee60371f223d62f2dd6fe1c2296ca Reviewed-on: https://gerrit.libreoffice.org/29459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit b11ad787372c4b833cc58a3738e375af26309b8d) Reviewed-on: https://gerrit.libreoffice.org/29463 Reviewed-by: Eike Rathke <erack@redhat.com>
2016-10-03Avoid pointless single-line wrapper for OpenCL isnan()Tor Lillqvist9-554/+553
Change-Id: I4056a1afac1413616a06d0b2f03d4bdead6cad10 Reviewed-on: https://gerrit.libreoffice.org/29483 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-03tdf#101843, ensure repeated rows set the hidden/filtered flag correctlyMarkus Mohrhard1-0/+6
Change-Id: I759107eeb074698d5e4987c76005788aee33287d (cherry picked from commit 7e7f6b0a056b51a425934f63745ae5c9fed2e51f) Reviewed-on: https://gerrit.libreoffice.org/29327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-30tdf#101894 Copying a single sheet with a chart on it garbles the chartNoel Grandin1-7/+3
..on the new sheet Bug introduced with commit 86e9ef21a06a9babefb778dfc3e02118d371d70d Author: Noel Grandin <noelgrandin@gmail.com> Date: Tue Mar 8 20:41:21 2016 +0200 sequence->vector in sc Change-Id: I7a6539005f42c7a7036c60b12a9ff2f77f71ba6b Reviewed-on: https://gerrit.libreoffice.org/29169 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-27tdf#101104 this paranoid safety check actually causes a bugMarkus Mohrhard1-4/+0
Change-Id: Id31f98f5f84eabf603045e4d9f7ebd448689eed5 Reviewed-on: https://gerrit.libreoffice.org/29307 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-27Resolves: rhbz#1378521 csv dialog a11y returns a new accessible on every queryCaolán McNamara2-4/+38
the gtk a11y rather assumes that the a11y things "belong" to the matching widget/component and those owners will dispose them, so follow that pattern here and dispose the a11y objects when the parent is disposed to reproduce, enable a11y, load a csv, click once in the first column of the preview area and cancel the dialog and close libreoffice Reviewed-on: https://gerrit.libreoffice.org/29301 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f626fd5f897796451685c06ce5f397a90aeaa8e6) Change-Id: Ib830da499e9f2d6fed94fb12ede7c929b607ab10 Reviewed-on: https://gerrit.libreoffice.org/29303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-09-20tdf#100393, handle copying one cell to multiple cols with cond formatMarkus Mohrhard1-2/+5
The same fix has been applied for rows already. Change-Id: I77300680a657fb874d07641fbae928eb6c210acd (cherry picked from commit 3a9917b66d6820ec9f2844f8292a46d8b0b9180b) Reviewed-on: https://gerrit.libreoffice.org/29033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-20Resolves: tdf#102215 do not return coded double error for single matrix valueEike Rathke1-2/+24
Change-Id: I94477bf64ee7972e9822921a8a15d935cb01e53b (cherry picked from commit 388014fc19b2a785f887cdfee91100fc9ab8d58d) Reviewed-on: https://gerrit.libreoffice.org/29035 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-16disable generation of ole previews in ODF format until after loadCaolán McNamara5-9/+43
so the user update links dialog can control their generation SdrEmbedObjectLink becomes exposed to calc so it can detect if the link dialog needs to be used to update ole links. Reviewed-on: https://gerrit.libreoffice.org/28879 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 74844277cc2194c9e43f5bd7a6f78a9603da32f3) Change-Id: Id1dd7ea17342140eab9307d546528747e3a98090 detangle gadzillion checks into something readable no logic change intended Change-Id: Ib6af93afc1f80b7fc36239c96d5e0a71fcbcb789 (cherry picked from commit fad9786b06d188ba6e354620f57176f3d94a6637) Unmodified default SdrOle2Obj size is 101x101 svx/source/unodraw/unoshape.cxx sets a css::awt::Size maSize to 100, 100 svx/source/unodraw/unopage.cxx increases that by 1, 1 awt::Size aSize = xShape->getSize(); aSize.Width += 1; aSize.Height += 1; to call SdrObjFactory::MakeNewObject with 101, 101 so default size is 101x101 (getWidth() vs GetWidth() confusion ?) Change-Id: I4d4375dff64d7b8e236d1a24322e749e04ee530f Reviewed-on: https://gerrit.libreoffice.org/28895 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7f0a219c9ad38ae33b51ff69d545f69659691c1e) Reviewed-on: https://gerrit.libreoffice.org/28926 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-16tdf#101541 function WORKDAY.INTL not working properlyWinfried Donkers1-9/+13
When holidays are adjacent to weekend days, wrong results occurred. Change-Id: I9ec86e00f1a62ea941ff70617a1b448601aff9cc Reviewed-on: https://gerrit.libreoffice.org/28771 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5e9d5eeb8a33fdcc500377d9eace40b5f5a7f750) Reviewed-on: https://gerrit.libreoffice.org/28970 Tested-by: Jenkins <ci@libreoffice.org>
2016-09-02tdf#101866: Get rid of two more erroneous upper-casings of stringsTor Lillqvist1-2/+2
Follow-up to f948dce856d51704e1962553198015dbebb6e527. Change-Id: I46c5a96a076fa6eec952e31201bb3563464cf602 Reviewed-on: https://gerrit.libreoffice.org/28626 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 326da3886e6f700ad1fb269df201fae9fa01d5df) Reviewed-on: https://gerrit.libreoffice.org/28627 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-02exclude also single quoted strings from function name suggestionEike Rathke1-5/+12
These may be sheet names or label names, but never function names. For example, typing ='e should not suggest "[EASTERSUNDAY], EDATE, ..." Change-Id: I818b91b533b868ccb6d2eb1eef74112162d2fe3d (cherry picked from commit b9a2c849a657bdb9d5953b96f60409cb877b0005) Reviewed-on: https://gerrit.libreoffice.org/28586 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-01let's make Impress crash less - SfxStyleFamily editionMichael Stahl1-2/+2
Commit bcb41235deaf4b7ca90522bda3ba21a686819e6e - in addition to introducing the enum SfxStyleFamily - inconsistently converted one call of DrawDocShell::SetStyleFamily to use enum SfxStyleFamily instead of a mysterious "5", but did not adapt all of the code that extracts the SfxUInt16Item that subsequently extracts this value and expects a number 0-5. Since it's clearly inexcusably stupid to have 2 different public sets of integers identifying styles, make the usage of the second "array index" integers private to templdlg.cxx; the SfxUInt16 item now always contains enum SfxStyleFamily. (regression from bcb41235deaf4b7ca90522bda3ba21a686819e6e) (cherry picked from commit 75c39b903f06b656293edf20ec4a5173a0755fb6) sfx2: SfxCommonTemplateDialog_Impl can't even decide if... ...no family selection should be represented as "0" or "0xffff". (cherry picked from commit 813a8944bdb337a0018208381aa30118151872ff) Change-Id: I333575c504277c2046f8f5a6b36ae3f86b3b3201 Reviewed-on: https://gerrit.libreoffice.org/28569 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-30Resolves: tdf#88257 handle FILTERXML array/matrix contextEike Rathke1-18/+101
... in which subsequent node elements are to be stored in the result matrix. Change-Id: Ia980a99a2b9ffba0e651f5d4c2420c8acfb80615 (cherry picked from commit 7d733e16513a1b9413303d60feb03c5a0de941fc) Reviewed-on: https://gerrit.libreoffice.org/28460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-29tdf#91305 fix sort calcYan Pashkovsky1-2/+26
Change-Id: Id8969e28d653add5ba4348ece622b2b53ce464da Reviewed-on: https://gerrit.libreoffice.org/28253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-08-23Resolves: tdf#101137 handle empty elements in matrix concatenationEike Rathke3-18/+80
Change-Id: I2de90e1cdfc4f215f6d7c644e0ab74372a4c2639 (cherry picked from commit 31d39c24e1ff2d3602e0212eeeecd8de88da6d38) Reviewed-on: https://gerrit.libreoffice.org/28335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-22tdf#70565 Set correct default values to "0" of xfId attributeBartosz Kosiorek1-1/+15
When xfId is not exist during .xlsx import it must have values set to "0". It is not impacts spreadsheets created with MS Excel, as xfId attribute is always created during export to .xlsx Not setting "0" value is causing wrong .xlsx import by LibreOffice, for spreadsheets created by external applications (ex. SAP BI). Change-Id: I1fb685f7ad38bcdb6cce78e6cf49e1825330f661 Reviewed-on: https://gerrit.libreoffice.org/28266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-18Resolves: tdf#101347 conditional formatting super slow on exitCaolán McNamara1-1/+6
since... commit 88a0c7d01b7dfd085a0569030f97cc7de0f0d106 Date: Sat Mar 26 13:11:53 2016 +0100 switch to a listener based cond format update, tdf#95437 I'm obviously assuming here that the notify doesn't matter when the broadcasted is shutting down. Change-Id: I0fef0ac1c1d8757199dcffb3c8ec1b05a73c1f17 Reviewed-on: https://gerrit.libreoffice.org/28006 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit cbab44f5eb27c8a45905167d2443f56b816b4a7b) Reviewed-on: https://gerrit.libreoffice.org/28205 Tested-by: Jenkins <ci@libreoffice.org>
2016-08-18tdf#48767 Fix orientation issue after export to .xlsx (lo-5-2)Bartosz Kosiorek1-1/+4
After save to .xlsx in usePrinterDefaults was added into PageSetup. Due to bug in MS Excel, when usePrinterDefaults is present, (no matter what value), the orientation of the Page is alway "portrait". To resolve that issue, if usePrinterDefaults is set to default value, then usePrinterDefaults XML field is not added during export to .xlsx Change-Id: Ie165420420fb4bc42048c4ed90413ebf69d4152e Reviewed-on: https://gerrit.libreoffice.org/28084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-16check SelectionForbidsPaste() on EnterBlock()Eike Rathke1-0/+6
... to prevent Alt+Enter filling a huge selection. (cherry picked from commit bbf671229cd06156e3d4eff5a2c7164ebd28e020) Backported. Change-Id: I8ce905c6e5ad0cb4dadf309f7b995142414e7193 Reviewed-on: https://gerrit.libreoffice.org/28079 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-16Resolves: tdf#100852 update miBroadcasterPos before copying itEike Rathke1-0/+20
Change-Id: I9ab9acfb0871355ceb2c3c83f51e7ba05a74d8f2 (cherry picked from commit 7b768dd9a78d2a979eb4d1b1b5b33a4f01a1a98a) Reviewed-on: https://gerrit.libreoffice.org/28151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-16Resolves: tdf#101165 crash on deselecting all filtersCaolán McNamara1-1/+4
this affects 5-1, but not master because of 7967e5e51e5210b8c3d3dc63502bd7d875eb36b7 which changed the trigger in ScCheckListMenuWindow::setAllMemberState but lets fix it in master anyway in case there's another route in here Change-Id: I49162bb73bf6dbef5cff68d35d10da2c47d9f2b5 (cherry picked from commit b101ff56e874824fa9f0d37a8468b07dbf3d002c) Reviewed-on: https://gerrit.libreoffice.org/28164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-08-11recognize another release's unknown currency saved as symbol we knowEike Rathke1-0/+9
This may happen when saving a currency with a changed symbol in the current release, load it in an older release, save it there and load it again in the newer release. For example DKK [$kr.-406] #.##0,00;[RED][$kr.-406] -#.##0,00 new in master/5.3 (changed symbol from 'kr' to 'kr.') loaded and saved in earlier releases writes currency 'kr.' instead of 'DKK' reloaded in master since there was no match as currency lead to number format #.##0,00 [$kr.] Change-Id: I5c8f165a2f420d77f5a2c0921c33a57797f92526 (cherry picked from commit a97e6990435bbc47be4a4f6f349404f438e2c315) Reviewed-on: https://gerrit.libreoffice.org/28040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-11Resolves: tdf#96568 check SelectionFillDOOM() on EnterMatrix()Eike Rathke2-2/+7
Change-Id: I6843b4fac175b646a6dd725f5591c49e960a5f18 (cherry picked from commit 6fb5d747893038e0748f30c205e820850ff8e010) Reviewed-on: https://gerrit.libreoffice.org/28061 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-10Resolves: tdf#101309 crash on deleted SdrObjectCaolán McNamara2-4/+14
when we're not recording undo, then SdrUndoDelObj just deletes the argument its passed. And this code assumes that it is transferred to the SdrUndoDelObj and it still exists. Use the same pattern as ScPostIt::RemoveCaption for this situation Invalid read of size 8 at 0xB1713B6: SdrObject::GetOrdNum() const (svdobj.cxx:777) by 0x3C9E029C: ScDetectiveFunc::DeleteArrowsAt(short, int, bool) (detfunc.cxx:695) by 0x3C9E1D4C: ScDetectiveFunc::FindSuccLevel(short, int, short, int, unsigned short, unsigned short) (detfunc.cxx:1118) by 0x3C9E2405: ScDetectiveFunc::DeleteSucc(short, int) (detfunc.cxx:1207) by 0x3CF812BA: ScDocFunc::DetectiveRefresh(bool) (docfunc.cxx:480) by 0x3CFC9FAF: ScDocShell::DoHardRecalc(bool) (docsh4.cxx:1250) Address 0x50992d50 is 112 bytes inside a block of size 464 free'd at 0x4C2D22A: operator delete(void*) (vg_replace_malloc.c:576) by 0xB1D04BC: SdrPathObj::~SdrPathObj() (svdopath.cxx:1681) by 0xB1701F5: SdrObject::Free(SdrObject*&) (svdobj.cxx:394) by 0xB258666: SdrUndoObjList::~SdrUndoObjList() (svdundo.cxx:720) by 0xB258A39: SdrUndoRemoveObj::~SdrUndoRemoveObj() (svdundo.cxx:774) by 0xB25E29B: SdrUndoDelObj::~SdrUndoDelObj() (svdundo.hxx:298) by 0xB25E2B7: SdrUndoDelObj::~SdrUndoDelObj() (svdundo.hxx:298) by 0x3C7E5D0E: ScDrawLayer::AddCalcUndo(SdrUndoAction*) (drwlayer.cxx:1120) by 0x3C9E0238: ScDetectiveFunc::DeleteArrowsAt(short, int, bool) (detfunc.cxx:692) Change-Id: Idc6d1f8e9ad8b203dac55630f8c100e74d3e017b (cherry picked from commit d79a4f46926e81a6d0fe353feb3322673c1b509d) Reviewed-on: https://gerrit.libreoffice.org/28009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-08-09Resolves: rhbz#1364406 inherit the actual format index also for date and timeEike Rathke1-3/+12
So summing [HH]:MM cells or calculating with dates uses the same format in the result, not just the default format of a type. This also fixes the apparently broken state stored by 4.4 (and earlier, later?) where no type information was stored with the formula cell, which may be just due to the old behavior of not applying the actual format but determining it on the fly instead. Change-Id: I14d0a7d07185bf5c77e0d7f6989a4a1d1a468d27 (cherry picked from commit f2e3de4dfcf10f9a59f8fc3f051c620fd50ef3c2) Reviewed-on: https://gerrit.libreoffice.org/27916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-09Resolves: tdf#100582 SetMatColsRows() when constructing matrix ScFormulaCellEike Rathke1-1/+13
... from an ScFormulaCellGroup token array, because ScFormulaResult that holds the matrix dimensions is not cloned in that case as we don't clone from an ScFormulaCell. Change-Id: I13ab1b29db71ae1618580de995fe12ec423d4dc7 (cherry picked from commit c82a81bbda104ef08dd9e18725a09475b2d65183) Reviewed-on: https://gerrit.libreoffice.org/27808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-08GetInputHdl may return nullptrMarkus Mohrhard1-1/+2
As can be seen in the other places we need to check for nullptr. See http://crashreport.libreoffice.org/stats/crash_details/553b9ef5-c85f-4cda-b432-472501795634 Change-Id: Ic5cab914f403fcae7f4e1e6f0e66c6295f7f56dd Reviewed-on: https://gerrit.libreoffice.org/27949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 8b86768a9a72ce6ef326615cb7c9ad5c76172921) Reviewed-on: https://gerrit.libreoffice.org/27979 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-05mapping ERROR.TYPE to ORG.OPENOFFICE.ERRORTYPE was always wrongEike Rathke1-1/+1
Change-Id: I02b941a1a884a984b39632cad36579130cd71d6c (cherry picked from commit 3d70765218986abba8b6d7c8e3cadd83a62ee035) Reviewed-on: https://gerrit.libreoffice.org/27852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-03Resolves: tdf#97193 restore pre 5-1 values for INS_INSROWS and INS_INSCOLSCaolán McNamara1-3/+3
i.e. INS_INSCOLS_BEFORE and INS_INSROWS_BEFORE have the same meaning as the old INS_INSROWS and INS_INSCOWS, so reorder the enum so they are at the positions of their corresponding originals. This makes macros recorded before 5-1 work like they did prior to 5-1-0. This unfortunately will have the same effect to macros recorded during the 5-1 period that the original change did. regression since... commit f97beeef352fdd9fd4f157a7a4c4f6af8341cbe6 Date: Wed May 20 16:54:27 2015 +0200 Calc: Insert row/col before/after [1/2] This part renames all INSROW / INSCOL to INSROWS_BEFORE / INSCOLS_BEFORE which is the current (default) behaviour. Change-Id: Ide90b8cfebe4af1a3718d93c34657663c20ccc62 (cherry picked from commit 7ec4a495291c7427bba5256bf2c54f1da999ea52) Reviewed-on: https://gerrit.libreoffice.org/27834 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-08-03Resolves: tdf#100123 prefer notation priority in detecting range/addressCaolán McNamara1-43/+91
i.e. try and parse whether something is a range or an address in order of document address convention, Calc A1, Excel A1 and Excel R1C1, rather than check if something is a range in any of those conventions before checking if it might be an address in any of those conventions. Reviewed-on: https://gerrit.libreoffice.org/27821 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Conflicts: sc/source/ui/view/tabvwsh3.cxx Change-Id: Ibb744c3eda78a80f33bdbfa5f5ddf0aa5b6361af Reviewed-on: https://gerrit.libreoffice.org/27824 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara25-35/+35
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-02Resolves: tdf#101246 errors are not stringsEike Rathke1-12/+12
Change-Id: I5a63dcc0452f0254e66e0ad743ae0d0926dfc14a (cherry picked from commit 8e495518c36359e565d6c172688e7120c477137f) Reviewed-on: https://gerrit.libreoffice.org/27775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-02limit SelectionFillDOOM to 24117248 cells, tdf#60021 tdf#60056 relatedEike Rathke1-5/+10
Change-Id: Idabf5e51b7f423d7d58094ad1caef166728c3bed (cherry picked from commit 5cf5975cef114870268bee792e44570ddfdaafe8) Reviewed-on: https://gerrit.libreoffice.org/27776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-31add missing nullptr checkMarkus Mohrhard1-1/+2
See http://crashreport.libreoffice.org/stats/crash_details/07407baf-17dc-4c39-8020-4975797d89cc Change-Id: Ia10cf6555869a402bd16fbb5a272b1ccb03b12fb Reviewed-on: https://gerrit.libreoffice.org/27737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-30Resolves: tdf#60056 disallow Fill and Random when entire sheet is selectedEike Rathke5-5/+36
This is a combination of 3 commits. move range detection to ScViewData::SelectionFillDOOM() (cherry picked from commit 4b90c9dc83d96908d3732d95e75c2f71d0f5d988) Resolves: tdf#60056 disallow Fill when entire sheet is selected (cherry picked from commit c729ee7622b1d54b2dc82b1807c68899efeab6d7) disallow Random Number when entire sheet is selected, tdf#60056 related (cherry picked from commit 77327759c9053da493430ee01b4d7fe98c174574) 866f84d72c27be962dbad8f8e4dcb345aa336bff e9e229c3d3e5a5a7e3f3e90ebd181471927bd452 Change-Id: Ic5205428136fc323affed8d956d6ee0434d43988 Reviewed-on: https://gerrit.libreoffice.org/27690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-30missing nullptr checkMarkus Mohrhard1-1/+1
See http://crashreport.libreoffice.org/stats/signature/ScPreviewObj::getSelectedSheets%28%29 Change-Id: I210426b8ac23fdf6b1195afe7dbc388802335e71 Reviewed-on: https://gerrit.libreoffice.org/27711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 71835fd8b5b04651e5be38b3b26a8dc80f5c3355) Reviewed-on: https://gerrit.libreoffice.org/27732 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-29tdf#97831 follow up : remove unused arguments from stackWinfried Donkers1-0/+16
Intention: Make e.g. [1+SWITCH(1;1;1;6)] work. Without this fix, the result is 7 but should be 2. Reviewed-on: https://gerrit.libreoffice.org/27664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 3ee2cae3a36e5d052e02c3f7b226dc3b79bd2ebc) Conflicts: sc/qa/unit/data/functions/fods/Functions_Excel_2016.fods Change-Id: I2a72e458e5458c02c3ce2f4214b86ba13f7b1d11 Reviewed-on: https://gerrit.libreoffice.org/27697 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-28Resolves: tdf#60021 disallow Paste when entire sheet is selectedEike Rathke4-1/+30
... which exhausts memory unless you have 100GB or more of free RAM. Change-Id: Ie6f02c48457f80acad33d2286194765f8343f2fb (cherry picked from commit 984b0d1599ff1672cb0d28019bd652d58d6bdefa) Reviewed-on: https://gerrit.libreoffice.org/27647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-28Drop OpenCL details from the 'Detailed Calculation Settings' dialogTor Lillqvist4-995/+1
There is really no need for end-users to have access to these settings. We don't want end-users to shoot themselves in the foot. If power users really think they need to modify these settings, they can poke the LibreOffice registry. tdf#101063: Get rid of the whole "Test OpenCL" functionality while at it Its intended use case has never been particularly clear. (I wrote it, so I know.) We now test OpenCL usability silently at each from-scratch start. (cherry picked from commit a92da660cd4aae511785da4f3a276309c64b47f7) (cherry picked from commit d78012872a15cdd0347cbabfc13e03ce5511bf90) (cherry picked from commit 70258bb2d637319d8ff1d19bf304f813c5b2e948) (cherry picked from commit e4781d09418fe1dc7219f6ae11f516da622329aa) Change-Id: Idb800ea7e35d09fd1d72da83e93c2c2b6a025115 Reviewed-on: https://gerrit.libreoffice.org/27617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-28handle notes on empty cells, display search results, tdf#65334 follow-upEike Rathke4-29/+112
This is a combination of 6 commits. include empty cells if notes are searched, tdf#65334 follow-up (cherry picked from commit f027c77c520adbdf8cec59e0484fc87b33cf203b) use GetCellArea() when searching for notes, tdf#65334 follow-up ... so empty cells with notes are included as last "data" position if they are below or right of the last "real" data, which GetLastDataPos() doesn't. (cherry picked from commit 09cc958dee93ad0ad2ab0d8cc9cc4c09e46c3653) do not search in empty string if there is no note, tdf#65334 follow-up (cherry picked from commit a02f7aa735c52f5d20df0e2a94cc06879cb3dfac) use GetCellArea() also in SearchAll() and ReplaceAll(), tdf#65334 follow-up (cherry picked from commit 156590e7c0bf3c81f50b3d9862961e50010ea08a) use HasCellNotes() when looping and searching for notes, tdf#65334 follow-up ... so we actually find all if on empty cells. (cherry picked from commit d93284f65cf14fdf5e2520b474eb7383ca1d99e4) display the SearchAll() and ReplaceAll() results for notes, tdf#65334 related (cherry picked from commit 4f719263ae8dc44eabfba4654f9dbed92a9c5360) 9bb7464033736e7e7fa24e635ef1a3d39626002b 6c347b5bccd4ffd6a43a80e9d73a0b5fcf82926b 50bfeee96e57010455bbb9e8be4312a39d392411 e504ce7df2a17877eddf21cf309990a2a8b692ba b9ff40b26526efdf242db2ef1804e54611f16b0e Change-Id: Ib67b9745ffff730b209df2b82dc7e46fc4774900 Reviewed-on: https://gerrit.libreoffice.org/27603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-27Resolves: tdf#65334 cannot search in cell notesCaolán McNamara3-4/+30
regression since... commit c06dbbe7594c2a0b5a5b19f8e183d9c421e6e094 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Thu Feb 23 23:36:49 2012 +0100 remove mpNote from ScBaseCell and requires restoring some code subsequently removed in commit a1a1131c16227327d17bcf5ad2a5209ddc0f01a1 Date: Sun Mar 4 15:27:27 2012 +0800 Remove unused code Change-Id: If931c3162cacaeb126e730e3e79c1c47be4ce434 (cherry picked from commit 7c84a219e3cc8d623826343f547ba8adacca6d56) Reviewed-on: https://gerrit.libreoffice.org/27577 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-26No need for own implementation of erfc() in OpenCLTor Lillqvist3-192/+1
The own code was copied from the C++ one we used to have in sal/rtl/math.cxx but which was removed in a62bc6a65abb47adb0e4caff7e38823c15b302fc. However, it did not work correctly on some machines at least, like my AMD A10-7800 running Windows 10. I was unable to figure out why not. This lead to OpenCL being disabled by the Desktop::CheckOpenCLCompute() code we now run early on startup. Anyway, as OpenCL has erfc(), just use that. Change-Id: I7ba6104fc4975cd570358760fa97a19390a54cce (cherry picked from commit 4afa88f289de1150850b52d36f2345fd9a9fbc1e) Reviewed-on: https://gerrit.libreoffice.org/27540 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-25Need to try to avoid TDR also with NVIDIA cards on Windows 7 or earlierLaszlo Nemeth1-3/+2
(TDR is Timeout detection and recovery, was introduced in Vista.) Change-Id: I0be565036c72dadcbec40b6fb9d5154dfacd0860 Reviewed-on: https://gerrit.libreoffice.org/27519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-19Resolves: tdf#99360 Revert "tdf#93889 Remove a busy loop"Eike Rathke2-21/+37
This reverts commit 6610ad9aee0c8299880cd1da6cd6a756860ccad9. It simply doesn't work, the dialog ends up being modal because bRefInputMode is always false. Calling SyncFocusState() in ctor doesn't help because pEdFilterArea->HasFocus() returns false even if we just called pEdFilterArea->GrabFocus() ... why? Also manipulating things with pRefInputEdit = pEdFilterArea; bRefInputMode = true; doesn't help. This is odd.. Conflicts: sc/source/ui/dbgui/sfiltdlg.cxx (cherry picked from commit 62442d9066ea553a4b68b8a93fa54748cbe96e06) Revert "Resolves: tdf#99360 can't select filter criteria with mouse" This reverts commit db279db13286653bff269f8ae7471b22498be319. It does not solve the problem but prevents revert of 6610ad9aee0c8299880cd1da6cd6a756860ccad9. (cherry picked from commit 181a1a3b2df7ca427802c1c17f3344a869c91444) 8ae22ee9af57bccb9812a7c40802cf19782bedd3 Change-Id: I90fc8cd99a2ab91dd581acfc51d7ca5eea8e1f61 Reviewed-on: https://gerrit.libreoffice.org/27308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 11:26:32 +0000