summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2014-04-29fdo#75397: Return an empty string for empty element.Kohei Yoshida1-1/+1
This is the behavior as of 3.6. It had changed in 4.0 and onward by accident, and caused the bug as reported in fdo#75397. (cherry picked from commit 5fab47ddbe332a150fb2005e941a2c19bd38ce7f) Change-Id: Id96fea354604b3c13cbbf2d9a73223b7725c7d66 Reviewed-on: https://gerrit.libreoffice.org/9188 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-04-25fdo#76663: Let's not skip the first element of a matrix in PRODUCT.Kohei Yoshida2-4/+11
(cherry picked from commit 4158d8843d50d50e9830c8dc24af8722de77f4af) Conflicts: sc/source/core/tool/interpr6.cxx Backported. Change-Id: I00683ce64fea58a80cd7137384e8f30464c44e9f Reviewed-on: https://gerrit.libreoffice.org/9159 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-04-11re-enabled user-defined numeric fields for dBase exportEike Rathke2-50/+162
Since commit f59e350d1733125055f1144f8b3b1b0a46f6d1ca it was impossible to define a numeric field with a precision of less than 2 decimals, even if all values were integers. It was also impossible to define a field width larger than needed for any values in that column. Furthermore, the integer part was shortened if the overall column's values resulted in more precision than defined, but the overall length did not reach the predefined length. This does not change the behavior of the original intention of f59e350d1733125055f1144f8b3b1b0a46f6d1ca to give the precision of number formats precedence over precision defined in the column header, which is debatable though because conflicts may silently change the field definition. (cherry picked from commit e65141e93a540fc9fb4343ee65a5a7da7e3b1769) Plus comment translation. Conflicts: sc/source/core/data/column3.cxx sc/source/ui/docshell/docsh8.cxx Backported. Change-Id: I234c4bceaa1a6aadbd259cb8d9b6cb6f16bf91c2 Reviewed-on: https://gerrit.libreoffice.org/8809 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-04-09fdo#71729: Fill the range edit boxes after the table is fully initialized.Kohei Yoshida4-14/+34
Otherwise the range formula expression would not be available yet. (cherry picked from commit ffaaf35206b8f049bb9e9ffd7a85c8ebd758a21c) Conflicts: sc/source/ui/namedlg/namedlg.cxx sc/source/ui/namedlg/namemgrtable.cxx Change-Id: If9c5040366f9038e8094fd5448ca5e4ee2e73edd Reviewed-on: https://gerrit.libreoffice.org/8898 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-27fdo#62155 - don't crash if we can't create an instance of a calc addin.Michael Meeks1-4/+12
Change-Id: I478d7777949683a91e7adf9fa6b54e9d01ced676 Reviewed-on: https://gerrit.libreoffice.org/8771 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-19Related: rhbz#1076264 intermittent a11y crash in calcCaolán McNamara1-27/+43
http://retrace.fedoraproject.org/faf/reports/338291/ this crash refuses to be captured alive. But seeing as we sometimes check mpViewShell against NULL and sometimes check GetViewData against NULL its worth making those checks everytime for consistency see also... rhbz#923993 rhbz#896711 rhbz#602273 rhbz#577595 lp#811057 lp#760665 (cherry picked from commit fae1e19af05e664364c55d4f686aaab860fd538d) Conflicts: sc/source/ui/Accessibility/AccessibleDocument.cxx Reviewed-on: https://gerrit.libreoffice.org/8604 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit d01abcc7beb215c7e425248f690db8a642f00c73) Conflicts: sc/source/ui/Accessibility/AccessibleDocument.cxx Change-Id: I5553848018f500b63ade60bcfc756a736b27c64f Reviewed-on: https://gerrit.libreoffice.org/8639 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-03-17justify range to prevent negative tab span and memory alloc, rhbz#1057741Eike Rathke1-0/+1
I could not reproduce the crash of that bug (probably having more memory available), but the backtrace had nTabSpan = -2 implicitly casted to size_t leading to allocation of a huge amount of memory with vector::reserve(), which ScRange::Justify() exactly prevents. Change-Id: Idb79e1be62649922ba793cab01e00011479fade9 (cherry picked from commit a45fde7235f95792bf8e6f6979d0040637c5785d) Reviewed-on: https://gerrit.libreoffice.org/8625 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-06resolved fdo#61520 do not add multiple empty strings to the validation listEike Rathke1-0/+12
(cherry picked from commit 7122ef19847b26529ed1d5bad40df869e91a8495) Backported. Change-Id: I4f6180b2f8c914a965965ca362e1670e8b434d37 Reviewed-on: https://gerrit.libreoffice.org/8470 Tested-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2014-03-06fdo#72491: Always set input as text when that's requested.Kohei Yoshida1-5/+20
Even when the text begins with '='. (cherry picked from commit ca50752c34de4477c696471b707e1b8136e27661) Conflicts: sc/source/core/data/column3.cxx Change-Id: I6e0a995f3042240b9f78068b5d0b9b758eb253ed Reviewed-on: https://gerrit.libreoffice.org/8123 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-06fdo#72691: Allow overwriting of string value with numeric one.Kohei Yoshida1-0/+3
This can legitimately happen when you have a matrix with a reference to another cell inside, and the referenced cell originally contained a string value then later overwritten by a numeric value. Example. Put a "Text" in A1, and in B1 put a 1x1 matrix {=A1}. It displays "Text" in B1. Then put 11 in A1. Prior to this change, B1 would become blank. With this change, B1 will display 11. Change-Id: I3feba3a8658e1a5ebf6f9e5ac34de2d579464ddb (cherry picked from commit 9bf907a8278cecd816368db7b8c4ab745a914a59) Reviewed-on: https://gerrit.libreoffice.org/8066 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-06fdo#72390: Let's not skip auto styles from unmodified sheets.Kohei Yoshida1-7/+0
We do re-use sheet XML stream for unmodified sheets on re-save, which is okay. But skipping auto style population from unmodified sheets is not okay because autostyles are shared across all sheets and written outside the sheet XML streams. Skipping styles from unmodified sheets could potentially fail to export used styles, not to mention could cause a crash as reported in the bug. Change-Id: I73e439f7354e341c2c07e28ecca5452193985860 (cherry picked from commit 5000e64ecc55efd47d92714cf6db375ff37aac4b) (cherry picked from commit 47e540d8323e8ea2db5e7aae455503b32f306ca3) Reviewed-on: https://gerrit.libreoffice.org/8051 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-02-24fix for bnc#819865 itemstate in parent style incorrectly reported as setNoel Power2-15/+12
Problem occurs because attrs set with default values are reported as set when queried Change-Id: I89d6c3b09312fb78052d87ff20aa12c6fbe7bc98 (cherry picked from commit bf8e9b29aaebcbdd8f2f06b42ac97b8d9f8f4503) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2014-02-18fdo#73773: Check if the *document* is closing, not the *app*.Kohei Yoshida3-1/+13
Otherwise it would crash if the app has multiple document instances open and only one of them is being closed. (cherry picked from commit 76bdf523981d2bd983dac4e01bc5cc934118a73f) Conflicts: sc/source/ui/app/inputhdl.cxx Change-Id: Ib6e370037ab6097c9c6eff8035249663944b3a6c Reviewed-on: https://gerrit.libreoffice.org/8055 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-14fdo#73800 fix incorrect separator in function description in CalcWinfried Donkers1-2/+2
Depending on locale, the function description with arguments did show incorrect separator(s) for functions with PAIRED_VAR_ARGS. Reviewed-on: https://gerrit.libreoffice.org/8052 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit f38aa72c1d8f9e535d2b5cefbb2af7f6f37b81a8) Conflicts: sc/source/core/data/funcdesc.cxx Reviewed-on: https://gerrit.libreoffice.org/8057 Tested-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Conflicts: sc/source/core/data/funcdesc.cxx Change-Id: Ie493a77285360a099e5b07e8360ecb5c6c6c1aec Reviewed-on: https://gerrit.libreoffice.org/8059 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-02-12cp#100030: Use internal API to fill dxf styles during xlsx import.Kohei Yoshida3-15/+38
It's faster, and it actually prevents a bug where styles fail to get set when the document contains at least one protected sheet. Change-Id: I9a5d7250ca44dd46364ab62f2e0130e967427c66 (cherry picked from commit d12c0e5d36cc106cb4f9a27dba2f29c10b5d6f93) Reviewed-on: https://gerrit.libreoffice.org/7983 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-02-11edit->changes->show has empty filter settingsCaolán McNamara1-1/+4
Change-Id: I98999c0f402cf84d89b3a1167480dc27fdbc2be9 (cherry picked from commit 55c413b9cb2692b784c6c43a519be08146438237) Reviewed-on: https://gerrit.libreoffice.org/7995 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04resolved fdo#74493 do not trust aCell.maBaseCellEike Rathke1-2/+1
Regression introduced with 70c61a549184cf8611f7890ac31b0ba4c460cdec on 4-1 and 68a753b6a36560eb83ba6ebe4fe9897a8759d265 on 4-1-5 Apparently aCell.maBaseCell does not always follow the current cell position, so do not trust it. Always explicitly obtain the correct cell. Change-Id: Ib88de44a326be75c13d37538b8ae56d265b60ee5 Reviewed-on: https://gerrit.libreoffice.org/7843 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-29Presumably "eType ==" is missing hereStephan Bergmann1-1/+1
Change-Id: I7af8cabac09369a9be605413b799289d48cb3f57 (cherry picked from commit d18827e266d1bf44b0bac02ed486d2cdccba9c8a) Reviewed-on: https://gerrit.libreoffice.org/7724 Tested-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2014-01-28fdo#69244: Avoid putting these cells in formula tree prematurely.Kohei Yoshida1-1/+1
Marking the cell dirty alone appears to be sufficient to trigger resetting of number format. SetDirty() would mark it dirty *and* put the cell into formula tree, which would prevent proper value propagation as seen in the bug report. Change-Id: Ib4000e955dec43ba976d1486e1e80d7b64197c80 Reviewed-on: https://gerrit.libreoffice.org/7708 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-27resolved fdo#71598 postpone SetDirty during Insert/DeleteEike Rathke7-36/+52
... until after all listeners are re-established. (cherry picked from commit 20b7476142f75b49d10a75e48429a94cff0cec32) Conflicts: sc/inc/formulacell.hxx sc/inc/table.hxx sc/source/core/data/column.cxx sc/source/core/data/document.cxx sc/source/core/data/formulacell.cxx Backported. Change-Id: I9f6036d4bcc9206191959a88ed5439b9860ca268 Reviewed-on: https://gerrit.libreoffice.org/7624 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-26Resolves: fdo#72682 text field doesn't horizontally expandCaolán McNamara1-8/+12
also see fdo#73920 (cherry picked from commit 674aeac88ffa1840f2d6a7f33656193aaebc9a0c) (cherry picked from commit c1e0e4364b9ca3e437e118cde91183271357f3c5) Change-Id: I3d12d0b376c9c0488d12df8f9d3fe76b1c00a437 Reviewed-on: https://gerrit.libreoffice.org/7591 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-21resolved fdo#70275 write correct office:string-value if text format appliedEike Rathke1-3/+5
Change-Id: I52e5135139fdf88abe380b6e5ae60e2afb582289 Reviewed-on: https://gerrit.libreoffice.org/7555 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-01-20resolved fdo#73836 do not apply format twice to stringEike Rathke1-4/+6
ScDocument::GetString() already returns the formatted string that then was formatted through number formatter. Format raw string instead. (cherry picked from commit f6b9b73a1f87d1815ed8ab8f2494e5526a710bb9) Change-Id: I806b4fc904d04169a6c1dbd4a3d00e2556eda7bd Reviewed-on: https://gerrit.libreoffice.org/7553 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-01-11fdo#73484: Ensure that we import all tab settings from Excel.Kohei Yoshida3-0/+23
The old code would not import settings of the last sheet if maTabData was not large enough before the loop begins. Enlarge maTabData ahead of time to ensure we load all tab settings. (cherry picked from commit 3e87471b6815a3cad48cab2ef81073bad5453c56) Conflicts: sc/inc/scextopt.hxx Change-Id: I9093a93ef26ccba9fef06a8929d1d86311f5c55d Reviewed-on: https://gerrit.libreoffice.org/7383 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-08fdo#72774: Generate correct group items for the year group.Kohei Yoshida4-9/+12
This changes bring it back to the same algorithm used in 3.5. Change-Id: I16855cef1de133a1f886baa823d5b0d2b148e781 (cherry picked from commit c2e88a32314012afb799e321ec1d658f99f71781) Reviewed-on: https://gerrit.libreoffice.org/7306 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-08fdo#72774: Ensure that all the group fields are in cache upon file load.Kohei Yoshida1-0/+3
This resolves the originally reported issue in that bug (in Comment 1). Change-Id: I6fb85cff1eafb78d784605aa08e7d992a1ac36e0 (cherry picked from commit 256e4ccba8a331f2d30c6b5da9dca70206deadae) Reviewed-on: https://gerrit.libreoffice.org/7302 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-08fdo#72645: Case-insensitive string comparison in GETPIVOTDATA.Kohei Yoshida2-13/+28
Change-Id: Ibdb2b7ab2bae03875a3462816e860f58d9076457 Reviewed-on: https://gerrit.libreoffice.org/7285 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-08fdo#72645: Allow GETPIVOTDATA to get result from leaf node of result tree.Kohei Yoshida4-9/+79
Change-Id: I0fc1fd069440ed6fee378fc2dfd2ed761afbdeab Reviewed-on: https://gerrit.libreoffice.org/7284 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-06read elements/attribs written to extension namespaceMarkus Mohrhard3-1/+10
Related to validation errors with fdo#31296 Change-Id: I1b76e05a9996b1123db164629475a3f7b07dda69 Reviewed-on: https://gerrit.libreoffice.org/7222 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-06only write new element and attributes in ODF 1.2 extendedMarkus Mohrhard1-1/+1
Change-Id: I038f200f500ef1c6a0815b6332fb17bb2f62282a Reviewed-on: https://gerrit.libreoffice.org/7221 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-03added "EEK" and "LVL" to EUROCONVERT(), "EUR" to [*-LV] locale data fdo#73239Eike Rathke1-3/+8
This is a combination of 3 commits. added Estonian "EEK" to EUROCONVERT(), fdo#73239 (cherry picked from commit 127f863c727c07f1da40005fe638d97e89baaccf) Conflicts: sc/source/core/tool/interpr2.cxx added EUR as default currency to Latvia [*-LV] locale data, fdo#73239 (cherry picked from commit c32996987354d045523beaa98b5d227d161f72fb) added Latvian "LVL" to EUROCONVERT(), fdo#73239 (cherry picked from commit cc1b6535e01db62688a7bee50852d33e4ee50761) Change-Id: I82085b6661c954b2afbf22b8b8ed5bd8c48cc50e Reviewed-on: https://gerrit.libreoffice.org/7263 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-21prepare to read loext:vertical-justify, fdo#72922Eike Rathke1-1/+5
Change-Id: I56d72d5cb8ea95aa63d4659899cba2f295ce9bea (cherry picked from commit 11a73705d9dd10ebefa2bcdefa560f55e7024a1b) Reviewed-on: https://gerrit.libreoffice.org/7150 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-12-21XMLPropertyMapEntry::mbImportOnly and XMLPropertySetMapper bForExportEike Rathke3-12/+12
Although a rather large change this does not change the property mappings or import/export behavior yet, but prepares for further changes that add mappings for generating correct ODF and consuming both old and new namespace/element/attribute names. This is a combination of 4 commits: added bool bForExport parameter to XMLPropertySetMapper ctor Set to true for export, false for import. If export true, an XMLPropertyMapEntry with mbImportOnly==true is not added to the mappings. This to be able to have more than one mappings for import (for example a current extension namespace and the future namespace proposed to the ODF-TC, or corrected typos in element or attribute names), but map only to one entry on export, of course. (cherry picked from commit ebc1b2fe50c7ed1002ed8431410b8e2ac6e795b9) Conflicts: dbaccess/source/filter/xml/xmlHelper.cxx xmloff/source/chart/PropertyMaps.cxx xmloff/source/draw/sdpropls.cxx xmloff/source/style/PageMasterPropMapper.cxx xmloff/source/table/XMLTableImport.cxx prepared XMLPropertyMapEntry with mbImportOnly flag (cherry picked from commit 9dd7ee88bd9835ae2bae36093100fcd651fd3aeb) Conflicts: dbaccess/source/filter/xml/xmlHelper.cxx xmloff/source/table/XMLTableExport.cxx xmloff/source/text/txtprmap.cxx just beautify this a little (cherry picked from commit 44b4973fbd0f190906f36321b31215d80b363d52) reordered member variables for 4 byte alignment (cherry picked from commit dd902b8e256867b5d5fed06b52995f14d969f67d) Change-Id: I15b03870fd14f110833037b6c0ff934624d72de1 Reviewed-on: https://gerrit.libreoffice.org/7144 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-12-13fdo#70499 selectn of lock/unlocked cells with worksheet protection reversedNoel Power3-32/+32
The ooxml spec documentation is rather confusing ( for me at least ) and the sense of the of the sheetProtection attributes as described seems reversed to how I read it ( or maybe it is the equivelant option in ScTableProtection that operates with the reverse sense <shrug> ) In anycase the import ( and export ) have been adjusted to take that into consideration, also the export now actually deals with the defaults correctly. Change-Id: Ia69567b8898b39c9d171486cfa800e1748c5814b Reviewed-on: https://gerrit.libreoffice.org/7075 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-12-12fdo#68160 Revert "Resolves: #ii122335# Disabling the old task pane"Eike Rathke2-0/+2
fdo#68160 Revert "Partly revert "Resolves: #ii122335# Disabling the old task pane"" This reverts commit cb4225144f1fff44f9bb972fe06f51524da11b8b. To be able to revert 95ae39c0c34c9a5e6fa6e72bf3a631a9a799b872 entirely. fdo#68160 Revert "Resolves: #ii122335# Disabling the old task pane" This reverts commit 95ae39c0c34c9a5e6fa6e72bf3a631a9a799b872. We need a TaskPane even in Writer and Calc to be used by extensions. Sidebar is experimental so TaskPane is needed anyway for Impress (see fdo#72371). Change-Id: Ia94ab377a59996ba434b56e3823117183674afb7 Reviewed-on: https://gerrit.libreoffice.org/7042 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-11fdo#66969: Reset group dimension data from all referencing pivot objects.Kohei Yoshida2-25/+42
The previous code was doing it only with the first referencing pivot table, which would break the rest of them sharing the same cache if the first one doesn't contain all group dimensions used in all of the referencing pivot tables. Change-Id: I35d6907ef8db7ed69db42583cac92b2b74406e2c (cherry picked from commit b3977983e9f662392426f581516d86d7034ad0fd) Reviewed-on: https://gerrit.libreoffice.org/7028 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-12-11fdo#66969: Set selected page name after building all dimension members.Kohei Yoshida2-1/+39
Because the new implementation relies on the visiblity flag of the dimension members, they need to exist before setting currently selected page, which is still used in documents generated by the older version of LibreOffice. Change-Id: I6cec5fd3d2165f714fc01b596d3761890d87a4ff (cherry picked from commit 2e1b90a4272defb917b23e2e360e171114d6fa4d) Reviewed-on: https://gerrit.libreoffice.org/7027 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-12-10be able to read the correct 'sort-ascending' value, fdo#72548Eike Rathke1-0/+6
... for <table:content-validation table:display-list='sort-ascending' ...> but do not write it yet. Change-Id: I05bdf27cee27f7456b660267b95126420474eb99 (cherry picked from commit 8047ae4a8244199717698f2e2f5281551e97912c) Reviewed-on: https://gerrit.libreoffice.org/7016 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-12-07fdo#66984: Define an assignment operator to prevent double deletion.Kohei Yoshida2-6/+46
The code path was assigning one ScDPObject to another via assignment, but we didn't define one. So we were using the compiler generated assignment which only shallow-copies data members, which ultimately caused double-deletion of one of its data members. Change-Id: Ie98d0789e51aebff683dbcc0e533a9a0a87943d5 (cherry picked from commit bd976e5b070ec68a4f842190db4d0c1ea0e93428) Reviewed-on: https://gerrit.libreoffice.org/6966 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-06resolved fdo#66564 calculate formula cell once if AutoCalc disabledEike Rathke1-0/+18
Was lost with 2ce72093cdc68e60fb06ddd4358e0bc7fc8c63a9 and previous restructuring. (cherry picked from commit 2212051e792cb5f51f4191afe83c85fc3730a087) Backported. Change-Id: Ie4c8bdb287b56448406c873840c26ec4759de375 Reviewed-on: https://gerrit.libreoffice.org/6964 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-12-06fdo#69518: Correctly handle the old constraint syntax.Kohei Yoshida4-104/+103
We apparently support this syntax for ODF-backward compatibility. To fix this, I resurrected ScDPObject::ParseFilters() which was removed as unused, adjusted it for the String->OUString change, and changed the filter data structure to the UNO one rather than using the old one we no longer use elsewhere. (cherry picked from commit 1d85c8df2fb9cb25fc524485339ae9f11e8da676) Conflicts: sc/inc/dpobject.hxx sc/source/core/data/dpobject.cxx sc/source/core/tool/interpr2.cxx Change-Id: If52b38aaa1e8b208fb0ef9d92a6e853decdf43e3 Reviewed-on: https://gerrit.libreoffice.org/6962 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-12-05fdo#69984: Handle duplicate field names correctly.Kohei Yoshida8-31/+82
Duplicate field names are represented in two ways: 1) 'Name' vs 'Name*' in the UNO part of the pivot engine, and 2) Name,0 vs Name,1 which are a pair of textural name and a numeric duplicate index in the non-UNO part of the engine. But some parts lost this duplicate index information and/or confused the 2 ways of representation. Hopefully this change will sort things out. (cherry picked from commit 7e491281d2ba71490fa22cce1e43ba91f60395e3) Conflicts: sc/inc/pivot.hxx Change-Id: I03ae7b6c011c31ace454679837542d6d0909ecaa Reviewed-on: https://gerrit.libreoffice.org/6944 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-12-05resolved fdo#71667 and fdo#72278, fdo#69971 follow-up fixEike Rathke5-1/+24
a9d85d62a889288b17899c8defc020da487d8b36 used ScInputHandler::EnterHandler() to reset all sort of things related to input EditEngine, but that is a handler for Enter and does not enter a handler and actually attempts to finalize input, which lead to various unwanted side effects. Introduced ScInputHandler::InputTurnOffWinEngine() as only the input bar window EditEngine needs to be reset in the window switching case (which EnterHandler also does hence it did prevent that bug). The approach could be polished with further refinement but most importantly fixes the actual problems now. (cherry picked from commit dfd1a47a38dac743f9ed0f1e9507714bac027d35) Conflicts: sc/inc/scmod.hxx sc/source/ui/app/scmod.cxx Change-Id: I9a0bc452b49ba11a3313cafbc1e5972f41dc65c7 Reviewed-on: https://gerrit.libreoffice.org/6935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-04write valid dxf record, related fdo#71971Markus Mohrhard1-6/+6
Change-Id: I99f4dfca78cc0fd5d9b947000a99f8414c2a899b (cherry picked from commit 7415fc31f5cdf7ff3f78dd304b9576b931a82aeb) Reviewed-on: https://gerrit.libreoffice.org/6878 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-12-03resolved fdo#71589 reimplemented horizontal range lookupEike Rathke4-3/+107
Regression introduced with ebdd9c300718bce454ef56a31d5d8fb699fc1822 (first eaea417bfdf8d06df2b7f2e42c904c32ce77e871) that removed the bMixedComparison member from ScQueryParam under the false assumption that is was only used to emulate a legacy Excel behavior. In fact it was also needed to do the at least horizontal range lookup in sorted mixed data, though didn't evaluate exactly the same conditions as Excel and defined in ODFF. Reimplemented a similar behavior for the new code structures but this time also checking for the additional condtion that a query ByString does not return the last numeric result and vice versa, which previously was missing. (cherry picked from commit f0701470858f57a855ba57c0c2283e52953db327) Conflicts: sc/source/core/data/dociter.cxx Backported. Change-Id: I46061777879ba5301bfcaca2d50cf87a994f93f2 Reviewed-on: https://gerrit.libreoffice.org/6839 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-12-02don't use fixed size icon sets, fdo#62652Markus Mohrhard1-2/+3
actually we should switch to svg as soon as it becomes possible Change-Id: Ifbbe5befab94441f04fadb90b779e0bc8c15eda4 Reviewed-on: https://gerrit.libreoffice.org/6890 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-02fdo#72078 make status bar text localizableAndras Timar1-4/+3
2nd try to get it right on libreoffice-4-1 Change-Id: I66ebc292231069cca708eb56ad876f56829e78f5 Reviewed-on: https://gerrit.libreoffice.org/6894 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-02Revert "fdo#72078 make status bar text localizable"Markus Mohrhard1-2/+4
This reverts commit ae5519c8c42b2a9473da236f3c84bfe630893cc4.
2013-12-01fdo#72078 make status bar text localizableAndras Timar1-4/+2
Change-Id: I5d8ce77c8034819fd618d3d970908462511d2e1d Reviewed-on: https://gerrit.libreoffice.org/6888 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-12-01fix 2D vs 3D coordinatesystem regression, fdo#67300Markus Mohrhard1-2/+2
regression from 088e86b865062dd4cc5ba0c85c6068dea62238db Change-Id: Ifc8d5a1da328278175bbc97b4f2aad8e6d200751 Reviewed-on: https://gerrit.libreoffice.org/6880 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
generated by cgit v1.2.1 (git 2.18.0) at 2023-03-22 21:32:50 +0000