summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2013-05-11resolved fdo#64384 check subtotal row filtered also for single referenceEike Rathke1-0/+4
(cherry picked from commit 3c2d0acc871057573fe9ab45b8161fce70190e80) Conflicts: sc/source/core/tool/interpr1.cxx Change-Id: Ic00b9135021f2c5f76755efbe88fc1f12e655320 Reviewed-on: https://gerrit.libreoffice.org/3847 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-05-10fix compile for change to boost 1.53.0 declaring smart pointer operator bool ↵Mark Wright4-5/+5
as explicity for C++11 compilers Change-Id: If2c3ad68b2ffea645a9f2035cd802553edc0ee79 Reviewed-on: https://gerrit.libreoffice.org/2064 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> (cherry picked from commit d4bab97023e3569571a92551040574b20aceca7c) Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-05-09fdo#61060 - Freezing now marks spreadsheet as unsaved.Sameer Deshmukh1-0/+1
Change-Id: I0b479500938e185fb6d163837b29e6e36e823260 Reviewed-on: https://gerrit.libreoffice.org/3641 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi> Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2013-05-07fdo#51828 - UI: Sort: can use more than 3 criteria once only - additional fixAlbert Thuswaldner2-16/+25
Change-Id: I220b3755d3ea30bd9aa25b175f7f3eea7590ebdb Reviewed-on: https://gerrit.libreoffice.org/3801 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-05-06fdo#63878 fix the zoom problem when the sheet are RTLFaisal M. Al-Otaibi1-0/+3
Change-Id: Ie451b7a84b5481e9209c5b6d6d439844de5082fd Reviewed-on: https://gerrit.libreoffice.org/3789 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5bff7f52075eb3ffe931d1779681262e1820a859) Signed-off-by: Eike Rathke <erack@redhat.com>
2013-05-03fdo#64048 - fix calc/VBA clearcontents regression.Michael Meeks1-1/+1
Change-Id: Id0c07507810ec1db41359f39dee804364fd37ecd Reviewed-on: https://gerrit.libreoffice.org/3744 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-04-29Resolves: fdo#51556 allow tab traversing into the conditional formatting listCaolán McNamara3-5/+13
Change-Id: Ie08a7312df0d42efc3697089cf766ceeefd623b0 (cherry picked from commit f0596516b943f90632ff4bbca83f4ce825e3b433) Reviewed-on: https://gerrit.libreoffice.org/3656 Reviewed-by: Tor Lillqvist <tml@iki.fi> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-04-24fixed out of bounds vector accessEike Rathke1-1/+1
in ScColumn::FindNextVisibleRowWithContent() if starting from the position all including the last present cell of a column are blank Change-Id: I0270331444f1707b6ad413f6127ae4c2cf0b1984 (cherry picked from commit 3874bad70ea48deed91b9966b3d35782b5584f7d) Reviewed-on: https://gerrit.libreoffice.org/3584 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-24fdo#61820: Avoid crasher when file URL contains unicode bytes.Kohei Yoshida2-5/+30
This is a cherry-pick of 6374df20c2a8378209cce21c0e9689e65b8bd9a2. Credit goes to Isamu Mogi for pin-pointing exactly what caused the crash and which commit fixed it on master. Change-Id: Ic5653c76c8c7d8eb8798a9c4ae0cbc43f0e946e4 Reviewed-on: https://gerrit.libreoffice.org/3581 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-16Remove the 4th option from the pivot table source selection dialog.Kohei Yoshida2-1/+5
Change-Id: I39ed1a9fd0476506cac0852af63182075f433ffd Reviewed-on: https://gerrit.libreoffice.org/3402 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-04-15resolved fdo#63421 crash in pivot table with accessibilityEike Rathke1-27/+64
The scenario of fdo#63421 (loading data and re-dragging the same field) is not needed, simple data is sufficient and crash happened also when dragging (removing) a field from a pane and dropping it anywhere else. Multiple errors: * getAccessibleChildCount() must return the real current count of children, not what mpFieldWindow says; AtkListener::updateChildList() uses this value to repopulate its own list; a child is added after it is added to mpFieldWindow but removed before it is removed from mpFieldWindow; * LostFocus() uses an index of -1 if the last child was already removed and the field was dropped after dragging it away from a pane, handle that but it still does not look right * RemoveField() called CommitChange() with AccessibleEventObject::NewValue set instead of OldValue, leading to AtkListener::handleChildAdded() being called instead of handleChildRemoved() Apparently this never worked since 2002. Change-Id: Idfb59d947002d2212bc67b414daecb65c55edae8 (cherry picked from commit 26114dcdf9d55a5a2490de6de619337e9733b0e2) Reviewed-on: https://gerrit.libreoffice.org/3372 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-13somewhat blind wae fix ( doesn't happen for me )Noel Power1-0/+3
Change-Id: Ia9b260c8bf2dc948f155fb89f0b5d960f9aada6f (cherry picked from commit 9c79ec29dba9dbdc6dc56f6e83b09f5176821768) Signed-off-by: Eike Rathke <erack@redhat.com>
2013-04-12fdo#51828 - UI: Sort: can use more than 3 criteria once onlyAlbert Thuswaldner1-2/+11
Change-Id: I7480e8d606e1eafde45635e36dfafa4232f529cb Reviewed-on: https://gerrit.libreoffice.org/3217 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/3350 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-04-11prevent vector and sequence out of bounds access, fdo#60300Eike Rathke1-12/+42
This fixes the symptom of the crash but not the underlying cause why a subtotal count would be wrong. (cherry picked from commit 8bd3be9915ff28458d010fc8f0a1a1ab66d730b0) Conflicts: sc/source/core/data/dpoutput.cxx Change-Id: I3782b5e39f18bc65ffe510b847ffa7969a26cd37 Reviewed-on: https://gerrit.libreoffice.org/3340 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2013-04-11prevent out of bounds vector access in ooo62493-1.xls recalculationEike Rathke1-0/+2
The document https://issues.apache.org/ooo/attachment.cgi?id=34418 attached to https://issues.apache.org/ooo/show_bug.cgi?id=62493 crashes in a dbgutil build due to an invalid subtotal count that leads to an out of bounds access in a vector, in this case with offset -1 This fixes the symptom, not the cause why the subtotal count would be wrong. Change-Id: If96c2eadba8753ea3e3166db0a81441818c89b2d (cherry picked from commit 58885eda4f15913fc46243dab726632f5904aab5) Reviewed-on: https://gerrit.libreoffice.org/3336 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2013-04-11resolved fdo#63403 do not create matrix with 0 rows or colsEike Rathke2-3/+26
Change-Id: Icb0000bde3723c1b37713d0f26ef8305c4a199b8 (cherry picked from commit 7c3ab3bc15cec211767490823539efcada4fe964) Reviewed-on: https://gerrit.libreoffice.org/3321 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-09Resolves: fdo#61948 delayed delete deletes nothing under windowsCaolán McNamara1-1/+1
The reason there appears to be two dialogs, is because there actually is. The original dialog doesn't get deleted under windows. If we use the actual returned type of the dialog here rather than a lower baseclass then the right thing happens. Original code works under Linux but not Windows. Change-Id: Iaf99fa4e16f743b1f5a3d29f42a140491f3d67b0 (cherry picked from commit afb3af7ce5fef803d42a549095863e6bb8210ef2) Reviewed-on: https://gerrit.libreoffice.org/3288 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-08fdo#49120 - Implementig XML_stateIrányossy Knoblauch Artúr2-2/+4
Change-Id: If4779aeb5301bb3e422ceb6a4029ddf5542ab03d Reviewed-on: https://gerrit.libreoffice.org/3222 Reviewed-by: Németh László <nemeth@numbertext.org> Tested-by: Németh László <nemeth@numbertext.org> Signed-off-by: Andras Timar <atimar@suse.com>
2013-04-05fdo#62155 - band-aid crash from poor addin registration on upgradeMichael Meeks1-0/+3
For some sadly unknown reason we get an exception traversing the calc addins and crashing doesn't seem a great response to that. Change-Id: I8d1eda7c8bab384817f19a86607c7035e4c3a8ab Reviewed-on: https://gerrit.libreoffice.org/3212 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-05fix selection change event firingNoel Power2-4/+48
Change-Id: I64e8b684dd5462e1a742ba47b5480951b4e3a4c4 Reviewed-on: https://gerrit.libreoffice.org/3210 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-04-05squash NoSuchElementExceptions when modifying keybindingsNoel Power2-1/+16
Change-Id: I37882845660929e0001a834b6685a4087dfb465f Reviewed-on: https://gerrit.libreoffice.org/3208 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-04-05Added and fixed various vba APINoel Power4-3/+59
Added OLEObject.LinkedCell Added ComboBox.LinkedCell Added Validation.Type provided a 'real' implemenation for AutoSize member ( applicable to various controls ) Change-Id: Id556d4c95a800951803609433e834105a6f20dbe Reviewed-on: https://gerrit.libreoffice.org/3207 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-04-05prepend Validation.Formula1 results with '=' for anything not a addressNoel Power3-3/+21
Change-Id: I6061378788b7299f8a8431d1e8d00a4e6ea3e8fb Reviewed-on: https://gerrit.libreoffice.org/3206 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-04-05Revert "fix selection change event firing"Noel Power2-48/+4
This reverts commit 4624a195238f27d9c7784aa3a710e479cb371ac6.
2013-04-05Revert "squash NoSuchElementExceptions when modifying keybindings"Noel Power2-16/+1
This reverts commit 276914e9cedfa28cc4461e9020c51c6e982f3a94.
2013-04-05Revert "Added and fixed various vba API"Noel Power4-59/+3
This reverts commit 57b8dcc4323f736f51f9ed8334affeb042efbca4.
2013-04-05Revert "prepend Validation.Formula1 results with '=' for anything not a address"Noel Power3-21/+3
This reverts commit b23f3059af8724cf6c1b19a4835e1bca3522ab2c.
2013-04-05fdo#56098 paste special shift options incorrect/incompleteWinfried Donkers1-20/+54
Change-Id: Ic84ec07f4e0963ad1759036f1d7cbfa295289375 Reviewed-on: https://gerrit.libreoffice.org/1903 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2013-04-05fdo#56098 Paste Special options after cut incorrectWinfried Donkers1-8/+5
Change-Id: Icf6aa698e69a2271cf68f420ceaec4aaffe94ad0 Reviewed-on: https://gerrit.libreoffice.org/1671 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-04-04fix selection change event firingNoel Power2-4/+48
Change-Id: I64e8b684dd5462e1a742ba47b5480951b4e3a4c4
2013-04-04squash NoSuchElementExceptions when modifying keybindingsNoel Power2-1/+16
Change-Id: I37882845660929e0001a834b6685a4087dfb465f
2013-04-04Added and fixed various vba APINoel Power4-3/+59
Added OLEObject.LinkedCell Added ComboBox.LinkedCell Added Validation.Type provided a 'real' implemenation for AutoSize member ( applicable to various controls ) Change-Id: Id556d4c95a800951803609433e834105a6f20dbe
2013-04-04prepend Validation.Formula1 results with '=' for anything not a addressNoel Power3-3/+21
Change-Id: I6061378788b7299f8a8431d1e8d00a4e6ea3e8fb
2013-03-29Revert "hacky fix for export of cell anchored flipped custom shapes (fdo#62448)"Luboš Luňák5-116/+0
This fails on at least two tinderboxes. This reverts commit 2058479575e4a3e003eb1917c4f0947db9145623.
2013-03-28hacky fix for export of cell anchored flipped custom shapes (fdo#62448)Noel Power5-0/+116
On export it is assumed the translate co-ords are the same as the topleft of the logical rectangle. What rectangle to use at any given time, the transformations and the fact that different object types seems to handle rotation etc. in their own way leaves me confused as to what the correct fix might be. This fix though won't make things worse ( afaict ) Change-Id: I6c704f9aebd650d530ebc32fbe73c251719494fe Reviewed-on: https://gerrit.libreoffice.org/3064 Tested-by: Petr Mladek <pmladek@suse.cz> Reviewed-by: Petr Mladek <pmladek@suse.cz>
2013-03-27complex categories are represented by ScRangeListMarkus Mohrhard1-2/+5
Change-Id: I35ab4e8299bb62ec0124a4c45e5cd20be6fc774a Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2013-03-25fdo#51296 Patch accounts security setting requiring ctrl+click for hyperlinks.Akash Shetye1-4/+17
Have used a boolean variable that acts as an entry condition to OpenURL methods main body/code and is set on qualification of security check. Change-Id: I1280e7cf7e8923282fda17088fd7c61fbf503b9d (cherry picked from commit 99932fa89be0e041abf5ce5da3271600c841ff19) Reviewed-on: https://gerrit.libreoffice.org/3032 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2013-03-25URM_INSDEL we need to update the src position, fdo#62206Markus Mohrhard1-6/+15
See ScFormulaCell::UpdateReference for a similar update Change-Id: I1f98d26adb5085e4bdab63cc23f97a81928d6b13 (cherry picked from commit 9261c0bf6ecf6633a5577879f003edfcb569f4d7) Reviewed-on: https://gerrit.libreoffice.org/2986 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-03-19error bar range is also part of chart range, related fdo#52159Markus Mohrhard1-17/+70
Change-Id: I344448db559de8435dcc26e2be4597c385724a7b (cherry picked from commit e15d8ef44fbf9fc23da58648e4d288782a81c7c1) Reviewed-on: https://gerrit.libreoffice.org/2820 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-19for internal data providers this makes no senseMarkus Mohrhard1-0/+3
Change-Id: Ic2651defd0ec8846dc0b0a81faee5dd6743310fb (cherry picked from commit 7b12b4677f658fd2dc9ff40371823da59533fa45) Reviewed-on: https://gerrit.libreoffice.org/2819 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-18Fix fdo#62399 Border incorrect for RTLFaisal M. Al-Otaibi1-1/+18
this patch will fix the incorrect border when you use the cell format dialog. Change-Id: Ieeeae4060a15e96e0de0f335f3c460df86f7dbf9 Reviewed-on: https://gerrit.libreoffice.org/2781 Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa> Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa> (cherry picked from commit 02c04319376e2124336a864aaf8b7de3c824c2f4)
2013-03-18Fix fdo#37464 - Cell Border works backwards on Right-to-Left sheetFaisal M. Al-Otaibi1-7/+32
Change-Id: Idb73d3029880b66602f163b2ab03c2b37c2306db Reviewed-on: https://gerrit.libreoffice.org/2782 Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa> Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa> (cherry picked from commit 84e4bf884718fcca8934b81b4037e063cf08c71e)
2013-03-14i#119972 - Formula GETPIVOTDATA returns #REF! valueWang Lei1-0/+17
Patch by: pengyunquan Review by: Wang Lei Changed SC_UNO_LAYOUTNAME to SC_UNO_DP_LAYOUTNAME to make it compile. (erAck) (cherry picked from commit 166db0df90f1a5443c6914f48848891fa8016782) Change-Id: I109885d5b2dfbb95207699a7f28741bd347e850b Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2013-03-14fix fdo#38385 - accept as valid 'start' and 'end' tokens for linebordersNoel Power1-0/+2
Change-Id: Ie092cc09c9c6e971c4f2020cb3b233ee350752ce (cherry picked from commit 8b29f5cb0333c156154adc151a613a547fde4f8f) Reviewed-on: https://gerrit.libreoffice.org/2709 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-13bnc#798309 inherit group style from parentNoel Power1-1/+1
Change-Id: Ie4f1d244f1c9b4935305742d12cabaee3e38647c (cherry picked from commit 1dbd088e4fb9597b0e2f5e4c4db6ecf047d85da3) Reviewed-on: https://gerrit.libreoffice.org/2695 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-12fix for fdo#62111 - don't count non-default empty rows as rows to repeatNoel Power1-4/+7
Change-Id: I075310ef63ab4eb666da2092d4be1c6f8d989b75 Reviewed-on: https://gerrit.libreoffice.org/2681 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-12Resolves: #i120017, filter button is not shown in merged cellJian Fang Zhang3-2/+25
Patch by: zhao shao zhi, aoo.zhaoshzh@gmail.com Found by: Yan Ji,<yanji.yj@gmail.com> Review by: zhangjf (cherry picked from commit bcf01fd794ec169aaf2a3f8b86f986ec60e5beb8) Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch> Conflicts: sc/source/ui/view/gridwin.cxx Change-Id: Ie8a529c697979cf75c303bddcaddd2776f5b8047 (cherry picked from commit aaab3a79dfd762a64fa4c1d19dd29ae46c0b9dd0) Reviewed-on: https://gerrit.libreoffice.org/2674 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-11Resolves: #119989# Support relative 3D pie chart height when importing charts.Armin Le Grand2-0/+7
Reported by: Yan Li Patch by: Yan Li, Tan Li, alg Review by: alg(cherry picked from commit 2b1cedbe547ea8f7979f91873dd6e602ebb08a7b) Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch> (cherry picked from commit ded39ea57b25617071012640cbaebaaf72a05744) Change-Id: Ibc6f070021c79809c651ba789409a5fb5096c185 Reviewed-on: https://gerrit.libreoffice.org/2671 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-03-11respect nDelFlags, fdo#57661Markus Mohrhard1-1/+1
Change-Id: I77d3e1f537b59504125d66f66f691d01f8f23894 (cherry picked from commit 41095e934bcd83e08a472c8fb53743cd3f8e926c) Reviewed-on: https://gerrit.libreoffice.org/2616 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-11use direct calls to set row height, fdo#61721Markus Mohrhard1-6/+9
Change-Id: I3c19e00b8ad2bc649b8e499cc869e3a4c488c343 (cherry picked from commit e1c281c6c1a2bd55d99e1af2023444c960cf02a3) Reviewed-on: https://gerrit.libreoffice.org/2615 Tested-by: Fridrich Strba <fridrich@documentfoundation.org> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>