summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2014-04-03resolved fdo#76949 correct grammar is GRAM_OOXMLEike Rathke1-1/+1
Regression introduced with ca8ca8c28742879220f3ff88ae0d71c8d69b11cd that used GRAM_ENGLISH_XL_OOX instead, which is English UI function names with OOXML reference syntax. Change-Id: If6b73e85a45e57f6ef281d1edf8e34dec7cb9bb8 (cherry picked from commit 31e4419ac7581aa7864905bcd4ce42e14df6c9bb) Reviewed-on: https://gerrit.libreoffice.org/8818 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-03-18fdo#75642: Check the high position block correctly.Kohei Yoshida1-1/+3
Change-Id: I25deabf69e78c6e0354e8a528ab88891a30f9aec (cherry picked from commit c078d5fef98ba77751b7a9593691d88dfc1c9ba1) Reviewed-on: https://gerrit.libreoffice.org/8573 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/8576 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2014-03-17fdo#76032: This row index is 1-based whereas our own mnRow is 0-based.Kohei Yoshida2-4/+4
Change-Id: I098d300532bef164bef0d40ebf62a6848bc19cb8 (cherry picked from commit ff56553e34dfed01b9226ce7a516dbeb6da32124) Reviewed-on: https://gerrit.libreoffice.org/8577 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/8578 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-03-12hidpi: Sidebar, fontwork, autoformat and other improvements.Keith Curtis2-1/+2
This is a second batch of HiDPI changes. It fixes the following areas: Sidebar * Impress Master pages preview * deck title height * tab (icon) bar * valueset dropdown control * wider maximum width * Draw and other misc. buttons which didn't get fixed by earlier change to Toolbar.SetItemImage There are several more sidebar issues, but it is much improved. Other changes * Writer and Calc auto-format dialog text * file-properties document image * fontwork gallery preview size * Calc table border control Change-Id: I95a0169a3b011836b1c75b3dcacb2733c9567ef3 Reviewed-on: https://gerrit.libreoffice.org/8519 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-12Let's not leak here.Kohei Yoshida1-0/+1
Change-Id: I12a50d0028164c37d06ff846bfbeff56a4591d12 (cherry picked from commit 9cfa665706cbced0fa71c43bb9425f28a0145f67) Reviewed-on: https://gerrit.libreoffice.org/8558 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-12Don't delete the kernel when pre-compiled.Kohei Yoshida1-3/+3
Because we'll be re-using that same kernel instance for subsequent runs. (cherry picked from commit 80842a50b1580b9a6da3a2c39a88a72b5b98d278) Conflicts: sc/source/core/opencl/formulagroupcl.cxx Change-Id: I08b6df65550cecfa48f937b163fb1c5b20ed8ac9 Reviewed-on: https://gerrit.libreoffice.org/8538 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-11fdo#74747: Correctly inspect formula result value for xlsx export.Kohei Yoshida1-29/+11
Change-Id: I757a8eb371b432970885e2fbd6aea9dd965ab5c0 (cherry picked from commit c1dc7576c18cc534e1934459f5fb210091a5b484) Reviewed-on: https://gerrit.libreoffice.org/8527 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-11fdo#74747: Make use of cached string formula results.Kohei Yoshida5-20/+54
Just like we do with cached numeric formula results. Change-Id: Ib8b311b540caeb47d8c2162a456f7490c5882ad5 (cherry picked from commit aa5ad7b8096cd15a55c467b1a23d03849aeb870d) Reviewed-on: https://gerrit.libreoffice.org/8526 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-11fdo#75815: Adjust external references here too.Kohei Yoshida1-0/+19
Adjusting external references are much simpler than adjusting internal ones since we don't need to worry about deleted references etc. Change-Id: I82111e383e1fc6976ef08c1438c3dd916a249af6 (cherry picked from commit dd7787ed75e33b65ebee2a6c0aa152efded6f1b8) Reviewed-on: https://gerrit.libreoffice.org/8529 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-11handle OOXML strict namespacesMarkus Mohrhard7-17/+36
Change-Id: I198862388426161e3f054a5f128639c59f3c9d24 support OOXML strict documents in Calc Conflicts: oox/source/core/relations.cxx Change-Id: I277d76aeec28e173d913ccc1506464afe4d09c6d import date cells from OOXML Change-Id: Id0b9ec034d559d489ca4ee2d1d6aca1bdf1beb9d no need to add another layer of macros Change-Id: I49992559a7d10127d55dbf0c7e257c86619fd8d6 fix one more relation type for OOXML strict Change-Id: Ia63309271ac225883540ca0453fc5da21844d3ad make more places aware of OOXML strict relations Change-Id: I292217537eb592cbad9af11f87402baa9f4cc442 fix strict namespace list generation The two perl scripts were apparently only generating the same order by luck. It did not work on all systems. Change-Id: Ib83ee5c6572d3bae2e2ac1846850bd65303e7d43 allow OOXML strict relationships in writer Conflicts: writerfilter/source/ooxml/OOXMLDocumentImpl.cxx writerfilter/source/ooxml/OOXMLStreamImpl.cxx Change-Id: I1c09280f68467748faedee19c4a66be3bc7d7aa3 make sure the two namespace lists are sorted the same way Change-Id: I90b3182e10dbbfc8993010dd885509537d2fe537 fix OOXML strict chart import Change-Id: I84a2fd575ced64d4774147063f13ebb8605c100f add the xml strict namespaces to misc/namespaces.txt Change-Id: Ie83b5c94f1f002851bff3b39b1d9b676a3e44aa1 Reviewed-on: https://gerrit.libreoffice.org/8515 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-03-10fdo#75960: Process pivot tables after named ranges are all set.Kohei Yoshida7-34/+242
Especially for those pivot tables that reference named ranges as their data sources, it's critical that we process them after named ranges are set. Else things would start to fail. Change-Id: I4bf8aa1a844aae3953f2dfbeba0e4d2542a7e53f (cherry picked from commit 057d269c5d1faf45c4c935b2f8120c45e646de65) (cherry picked from commit 98bd1911420f46380aa5373a92de6a748ced080d) Reviewed-on: https://gerrit.libreoffice.org/8507 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-10fdo#75950: Just set the right grammar and be done with it.Kohei Yoshida8-37/+13
Using the Excel A1 syntax with custom opcode was probably a hack back in the day. These days we can just set the right grammar and expect the compiler to do the right thing. Change-Id: Iae98f9f09a7da0b7b9549e06308d5d313bbff1ea (cherry picked from commit ca8ca8c28742879220f3ff88ae0d71c8d69b11cd) Reviewed-on: https://gerrit.libreoffice.org/8521 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-10fdo#75628: SUM should inherit error if one is present in its references.Kohei Yoshida1-4/+38
Change-Id: I94017fe91295dbb929f57be5e3fb26edf5032a8f (cherry picked from commit d658c092f488fc0d4cb924fe3e34cab997db76e2) Reviewed-on: https://gerrit.libreoffice.org/8504 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-10fdo#75962: Avoid unwanted number detection when placing page field name.Kohei Yoshida1-1/+3
Change-Id: I1a3c57ec029e03198b8f190acfa8d59e142acaba (cherry picked from commit 0919979bd1da3379e030b353a097d8fe1fd8341a) Reviewed-on: https://gerrit.libreoffice.org/8508 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-09Revert "fdo#75962: Avoid unwanted number detection when placing page field ↵Kohei Yoshida1-3/+1
name." This reverts commit f86d94a2d1b3a61d290c072431c0af8446ec15bf.
2014-03-09fdo#75962: Avoid unwanted number detection when placing page field name.Kohei Yoshida1-1/+3
Change-Id: I1a3c57ec029e03198b8f190acfa8d59e142acaba (cherry picked from commit 0919979bd1da3379e030b353a097d8fe1fd8341a)
2014-03-07Initialize OpenCL device on the main thread when pre-compiling kernels.Kohei Yoshida2-1/+6
Else it would cause extremely hard-to-debug random crashes when interpreting formulas with OpenCL. And let's re-enable kernel pre-compilation with this fix. Change-Id: Ib104bfdc3f56a02c052c837eb4bf3ecc95d562e0 (cherry picked from commit 6e24c789572aba5b6ee95e894f6d778777b1df58) Reviewed-on: https://gerrit.libreoffice.org/8498 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-07Various fixes (memory leak & crash) in the OpenCL interpreter code.Kohei Yoshida8-64/+72
Pre-compiling of OpenCL kernel is disabled with this change. (cherry picked from commit b981c089a9194f33b46272e3f4efa117241ea533) (cherry picked from commit e253d46af3b47afd0006084bec89b02473ee457a) (cherry picked from commit 0d7f89b021f1354a0fa607862296b11c9fd8a4dd) (cherry picked from commit 5325137783825c498ed4236080ed7fe51cdec09a) (cherry picked from commit 20ed6886ade81ee015a22b2eb3aeff64691971bf) (cherry picked from commit 7a0ed3a406bd14bb2b52c383282daf4777ba76e0) Conflicts: sc/source/core/data/formulacell.cxx Change-Id: Iae97f4f877c329f443c7d222c6a2016678af2387 Reviewed-on: https://gerrit.libreoffice.org/8496 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-07fdo#75718: Correctly count the length of trailing empty range.Kohei Yoshida1-5/+5
This affects auto fill, apparently. Change-Id: I653918d374122bc9bb938231934c149da79a3306 (cherry picked from commit 01de94471c20a8b9c36d6080638d70e57eac55bf) Reviewed-on: https://gerrit.libreoffice.org/8501 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-07fdo#67104 Use correct command for show gridMaxim Monastirsky9-88/+6
Not sure why .uno:ViewGridLines & SID_SCGRIDSHOW were introduced (in "merge sidebar feature" and related commits). Reviewed-on: https://gerrit.libreoffice.org/8459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c3403ac888c2e62edaf8befe7982f5f8cc95c16f) Conflicts: sc/sdi/scalc.sdi sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx Change-Id: I90bdfaef86adcbfa44129b8f7f9df61ca7f35114 Reviewed-on: https://gerrit.libreoffice.org/8463 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-03-06resolved fdo#61520 do not add multiple empty strings to the validation listEike Rathke1-0/+12
Change-Id: I4f6180b2f8c914a965965ca362e1670e8b434d37 (cherry picked from commit 7122ef19847b26529ed1d5bad40df869e91a8495) Reviewed-on: https://gerrit.libreoffice.org/8469 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-03-06Fix incorrect group calc state check.Kohei Yoshida3-28/+23
And the code in the else block is pretty dangerous as it passes an empty token array to the group interpreter whose effect is entirely unpredictable. Also, declare the destructor of CompiledFormula class to be virtual as it serves as a base class for DynamicKernel. Change-Id: I4e191550a4437ad6ebac55fcdeee4f3654722ff1 (cherry picked from commit 95637452609260c97d8e5aaa7500531bb458a8bc) Reviewed-on: https://gerrit.libreoffice.org/8468 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05Build fix for OSX.Kohei Yoshida1-0/+2
Change-Id: I63613c40a5a947625c449fcd52ca129af116c900
2014-03-05Build fix on Windows.Kohei Yoshida1-2/+2
Change-Id: Icbd46d5bc72bdc07490dd45b3d29a4400a66119f
2014-03-05Oopsy.Kohei Yoshida1-1/+1
Change-Id: Ie961fca03b99ec14f401462da56dd4110ea5518c Reviewed-on: https://gerrit.libreoffice.org/8467 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-05Ensure that numeric array storage is aligned to 256-byte boundary.Kohei Yoshida2-1/+82
OpenCL devices require this else we would get a performance hit. (cherry picked from commit 03f7a342011a4f69cfcbec7af3e4f1a2e835618b) (cherry picked from commit 757856e9275d19e2c7a3673d10fa8963fb9fbeb3) Change-Id: Ie69e07dc5d9b62abad5cc39d1f30e1d770c56758 Reviewed-on: https://gerrit.libreoffice.org/8466 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-03-05fdo#75260: Correctly draw double lines for both Writer and Calc.Kohei Yoshida4-4/+5
Fix all sorts of incorrect double line handling in drawinglayer in order to draw thick-thin double line types correctly. Also change handling of border lines in writer tables. There are still some outstanding issues but it's much better than how it was before. Also realized that Word and Excel handle simple thin double lines differently; Word varies widths of all of the lines and the gap whereas Excel only has one fixed size for its double line. For this reason I decided to add a separate double line type (DOUBLE_THIN) to handle Excel's double line. (cherry picked from commit 2c62596cf264ef10749d8bfdb2bb2ebef2d98fbc) Conflicts: cui/source/tabpages/border.cxx sc/qa/unit/subsequent_export-test.cxx sc/source/ui/view/tabvwsha.cxx sw/source/core/layout/paintfrm.cxx xmloff/source/style/bordrhdl.cxx Change-Id: Iaaa353b6e4f998b524262bea59260b4333e0cdb4 Reviewed-on: https://gerrit.libreoffice.org/8464 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-03-03fdo#75053: Adjust reference update on shift for formula groups.Kohei Yoshida5-28/+144
This is similar to my earlier fix for reference update on moving of cells. Change-Id: I592599507bfcab12f611eeae7b56c99da6c31919 (cherry picked from commit f32df2d590d0ee14f09664934457ba9e8de8cbe6) Reviewed-on: https://gerrit.libreoffice.org/8403 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2014-02-27fdo#75304: Set external reference info to ScCompiler.Kohei Yoshida6-31/+34
And remove this excessive const fetish which was unfortunately necessary to get this to compile. Setting the container const is good enough. Change-Id: I2c6cc55a88643a68e065c4518cdf069c247f4f02 (cherry picked from commit 4917cebdb988223be47b0f1a82241ade643bc675) Reviewed-on: https://gerrit.libreoffice.org/8212 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-27fdo#75259: Let undo document share its string pool with the source doc.Kohei Yoshida2-1/+6
We already do that for the pool helper. It would only make sense to do it for shared strings as well. Change-Id: I813d262799af6f0c1d3fa12246ad973f852ac199 (cherry picked from commit e752620bf593af8839831f693ec21bb02a8b23d6) Reviewed-on: https://gerrit.libreoffice.org/8210 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-26fdo#75386: Totally fix reference update during range move.Kohei Yoshida9-64/+293
It was just not working at all due to multiple reasons. The reference update needed to be reworked for formula groups such that the token array is adjusted only for the top cell but all formula cells still needed to be processed afterwards. The bound check also needed to be done against the old range prior to the move, not the new range after the move. During undo, the paint had to be deferred until after the two calls to DoUndo() else the formula cells would get re-calculated before the values were placed back to their old positions, causing them to mis- calculate wrong values. Change-Id: Iba66f80a413e0539cac5ab619226cd6f7a04f317 (cherry picked from commit 79d03eb090a5f88863c1004ef8b7f483cbecb69d) Reviewed-on: https://gerrit.libreoffice.org/8352 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-02-25fdo#74573: Delete ranges that are non-empty before pasting from clipboard.Kohei Yoshida12-39/+355
The conditional formatting part is still not working. But other bits appear to be working now. Also, adjust handling of mix document aka paste functions with this change. When using paste function (add, subtract, etc), the behavior between the 'skip empty' flag on and off makes no difference. Let's set the flag to off when paste function is used. (cherry picked from commit 0c12aa670b83b76241077dfb8bc21f40a55b1667) (cherry picked from commit 2f55cee39379a76920f3a4fb14e6c2774093bfcd) (cherry picked from commit cdc8ebf9646e773351c91039a62f2414c7b02105) Conflicts: sc/inc/clipcontext.hxx sc/inc/column.hxx sc/inc/document.hxx sc/inc/table.hxx sc/source/core/data/clipcontext.cxx sc/source/core/data/column4.cxx sc/source/core/data/document10.cxx sc/source/core/data/table7.cxx Change-Id: I67724ba923c9260b2c14464e4123b8445712dbaf Reviewed-on: https://gerrit.libreoffice.org/7906 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-25fdo#72041: Intern strings as we populate the external cache.Kohei Yoshida3-13/+27
This commit covers ods import and UNO API layer. Change-Id: I3ad1b7cfefe49575694e2351bcba6e5733b009d2 (cherry picked from commit 5706ff70dbb18d03e396fd484bd1392dbcefb6c7) Reviewed-on: https://gerrit.libreoffice.org/8350 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-22fdo#74345: Some shared formulas cannot be exported as shared formulas.Kohei Yoshida4-12/+87
Excel's shared formula has some restrictions that Calc's doesn't have. So we need to check each shared formula token to see if we can export it as shared when saving to Excel. Refer to the "SharedParsedFormula" section of the [MS-XLS] spec. Change-Id: I0ffce26700d2773bbd2893743edc6c03682c2ed7 (cherry picked from commit 180f593fbfea238df97d006f6847bba3d9b0e317) Reviewed-on: https://gerrit.libreoffice.org/8165 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-20fdo#72041: Intern strings in the external ref cache with the host document.Kohei Yoshida1-10/+23
To ensure that string comparison with those from the external ref cache works correctly in functions such as VLOOKUP. Change-Id: Ib5a466cb6c4b26439abe61b0c17406fc8139f6c0 (cherry picked from commit 2bcd18892f1903d2434bc5dc6828841e49bb78a2) Reviewed-on: https://gerrit.libreoffice.org/8149 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-20fdo#75130: Export cell borders to xls and xlsx correctly.Kohei Yoshida1-4/+4
Change-Id: Ic629fb4852d2ada9724dfee7618e2436c0fa28a8 (cherry picked from commit 1c1f42fdbad774cae7c45a7f8d60b9af766dee0a) Reviewed-on: https://gerrit.libreoffice.org/8147 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-20fdo#75228: We still need to get the value only to pop value from the stack.Kohei Yoshida1-0/+1
Change-Id: Iad231aa97ed35f91b96cddf8157ebcd9af0f8ec9 (cherry picked from commit 9e183fbfdbfbe364d17f9d36a0b33d2fae89862d) Reviewed-on: https://gerrit.libreoffice.org/8141 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-20fdo#73565: Populate date members in a locale-safe way.Kohei Yoshida1-42/+64
Change-Id: Id90b2829465fada690b0446d6d823e76e792c77b (cherry picked from commit 2be2786879883badd6d0075e63965bacd312ed23) Reviewed-on: https://gerrit.libreoffice.org/8139 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-20fdo#75032: Handle note copying correctly.Kohei Yoshida3-74/+50
(cherry picked from commit 575e88da278f536ebfb6562dfd98f341240afec4) Conflicts: sc/source/core/data/column2.cxx Change-Id: Iae37ac86889d7a25f25e6dd0b69f724107c6798a Reviewed-on: https://gerrit.libreoffice.org/8089 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-19don't generate broken XML files, related #i116460#Markus Mohrhard1-5/+5
Change-Id: I5d7f487b787295af6189425601c5d7e829a3db52 Reviewed-on: https://gerrit.libreoffice.org/8121 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-19fdo#74857: Update the incrementer when skipping over hidden regions.Kohei Yoshida1-0/+4
Otherwise it would over-shoot. Change-Id: I1f9741345dfe353e0b035ff3bead736ab3fccbef (cherry picked from commit 637353bb46d3c7d9537e47e4e003aef78a0c0ab3) Reviewed-on: https://gerrit.libreoffice.org/8117 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-19fdo#72491: Always set input as text when that's requested.Kohei Yoshida1-5/+20
Even when the text begins with '='. Change-Id: I6e0a995f3042240b9f78068b5d0b9b758eb253ed (cherry picked from commit ca50752c34de4477c696471b707e1b8136e27661) Reviewed-on: https://gerrit.libreoffice.org/8122 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-18multiple pivot tables on same sheet OOXML fix (part1), related #i83250#Markus Mohrhard2-6/+8
This just fixes the generation of the pivot table file and the relationship. It crashed in a dbgutil build because we tried to overwrite the same stream for each pivot table on one sheet. Change-Id: If2c9541e38b483ead75fff32d5f6d9e16970e702 Reviewed-on: https://gerrit.libreoffice.org/8097 Tested-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2014-02-18fix invalid string access, related #i83611#Markus Mohrhard1-1/+4
Change-Id: I5954f78e10d99a064f83e96282c28c086c7f07f1 Reviewed-on: https://gerrit.libreoffice.org/8096 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-02-18the string is UTF8 and not AsciiMarkus Mohrhard1-1/+1
Change-Id: Ibf9a837ca5689ceae91eff2a081da3b7fe0b9244 Reviewed-on: https://gerrit.libreoffice.org/8094 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-02-17fdo#74512: Fix the ODS export as well.Kohei Yoshida5-7/+28
Change-Id: I54a2b2f405f9172d2ec5646346ef4e8a7ae27cb2 (cherry picked from commit 9a5ce676ede4828db0acde5db79d91320575ec08) Reviewed-on: https://gerrit.libreoffice.org/8074 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-15fdo#74558: Re-implement BinarySearch() to disregard empty cell blocks.Kohei Yoshida1-108/+280
The old code before the calc core refactoring took advantage of the old calc storage which did not store empty cells at all. The new storage does "store" empty cell blocks, and it did negatively affect the binary search used for VLOOKUP. The revised binary search code properly skips empty cell blocks so that it will work more like the old algorithm in 4.1. This change also fixes fdo#72348, which was caused by the same root cause. Change-Id: Ic20cc54d8dae26b62f5e9193cd21dad06ad10a3e (cherry picked from commit 377d749ff8211fa9e69d47a92810af9bc0652990) Reviewed-on: https://gerrit.libreoffice.org/8042 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-15fdo#72390: Let's not skip auto styles from unmodified sheets.Kohei Yoshida1-7/+0
We do re-use sheet XML stream for unmodified sheets on re-save, which is okay. But skipping auto style population from unmodified sheets is not okay because autostyles are shared across all sheets and written outside the sheet XML streams. Skipping styles from unmodified sheets could potentially fail to export used styles, not to mention could cause a crash as reported in the bug. Change-Id: I73e439f7354e341c2c07e28ecca5452193985860 (cherry picked from commit 5000e64ecc55efd47d92714cf6db375ff37aac4b) Reviewed-on: https://gerrit.libreoffice.org/8049 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-15fdo#73773: Check if the *document* is closing, not the *app*.Kohei Yoshida3-1/+13
Otherwise it would crash if the app has multiple document instances open and only one of them is being closed. Change-Id: Ib6e370037ab6097c9c6eff8035249663944b3a6c (cherry picked from commit 76bdf523981d2bd983dac4e01bc5cc934118a73f) Reviewed-on: https://gerrit.libreoffice.org/8053 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-15fdo#72691: Allow overwriting of string value with numeric one.Kohei Yoshida1-0/+3
This can legitimately happen when you have a matrix with a reference to another cell inside, and the referenced cell originally contained a string value then later overwritten by a numeric value. Example. Put a "Text" in A1, and in B1 put a 1x1 matrix {=A1}. It displays "Text" in B1. Then put 11 in A1. Prior to this change, B1 would become blank. With this change, B1 will display 11. Change-Id: I3feba3a8658e1a5ebf6f9e5ac34de2d579464ddb (cherry picked from commit 9bf907a8278cecd816368db7b8c4ab745a914a59) Reviewed-on: https://gerrit.libreoffice.org/8064 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 05:25:20 +0000