summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2021-07-05lok: sc: unit test for non existent tab view data fixDennis Francis1-0/+43
Change-Id: I7c0ea95118448a49288ff70c8e7bcddc379df5ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118319 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-07-05lok: sc: avoid crash on non existent tab view dataDennis Francis4-9/+26
... when accessing position helpers. Change-Id: Ia627a8c4ed30ad1f1c2333df00b656fe041f111e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118318 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-02-11lok: Send rows heights invalidation on pasteDennis Francis1-2/+12
... when the dest cell has wrap-text option set. Change-Id: I9f0dd157694701c96fd91e02b8232ed205f13ae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109602 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110767 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-02-11prevent reference range resetting on panning in mobilePranam Lashkari3-3/+29
Change-Id: Ic6cabe1d4e5a1e7c4d42294550d654e38e27db22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110461 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-02-11LOK: stop range selection with mouse/touch move in mobilePranam Lashkari1-1/+4
Change-Id: I0a7b3a5fc89bcbced4acee18415308ed8aa57ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109035 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 408e59359b5b67af119059a5d3f47bc807f81300) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109747 Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-02-08tdf#133858 reduce the double-ref range to data contentDennis Francis8-4/+238
in certain matrix formulas like SUM(IF(A1=G:G, H:H)*B1/B2) where whole columns are used for comparison in the condition of IF ultimately followed by a reducer like SUM. In such cases we can safely reduce the double-refs involved in the comparison to the sheet area where there is data before converting the data to ScMatrix. This is a more restricted version of Noel's fix in 37ffe509ef011357123642577c04ff296d59ce68 Change-Id: I1c2e8985adedb3f4c4648f541fb0e8e7d0fae033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109050 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110580 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-01-25tdf#139830: keep the right sidebar context for chart after view switch (calc).Tamás Zolnai3-3/+70
There is a general behavior to switch to the default sidebar context by view deactivation and switch back to the right context by view activation. See SfxShell::Activate() and SfxShell::Deactivate(). By activation, we use the selection to find out the right sidebar context. See GetContextForSelection_SC() method for example. However, for charts, this does not work, because the chart window is a separate environment and the shell does not know what is selected inside the chart window. So let's avoid context switches when we have a chart window active. Let the chart controller handle sidebar context changes. Change-Id: I272ee5c35ac30221eed2930201c4710a9a5877c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109790 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109901
2021-01-25fixed range text not being updated on dragging reference markerPranam Lashkari1-0/+5
dragging reference stat marker in online did not change the text of range selection Change-Id: I0f9ee9df2418bc4dcf519ca3462b510758b9766d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109795 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-22Added uno command for formula range selectionPranam Lashkari4-1/+53
Change-Id: I01cd06ed51197ffe21102fb1fd0fcdce88ab333b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108810 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit e8a9157878f156e599e66349d7fb60ca39e62514) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109746 Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-01-21lok: don't turn off online spelling by view change.Tamás Zolnai1-7/+8
Since we don't exit editing for LOK inside this NotifyChange() method, we should keep also spelling functionality alive. See also the comment we have here: "As long as the content is not edited, turn off online spelling." So it seems a good idea to make this spelling modification dependent of bStopEditing flag. This causes issues, during view switches. Change-Id: Ic684073d129c1cac4b6f4d11f34cd64cb5db3295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109206 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 6554d69871b0798ae38e5a406aefb5dd90f19ff0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109625
2020-12-10Online: "Copy hyperlink location" feature improvement.gokaysatir1-7/+1
Lambda functions are replaced with class pointers. Change-Id: I48628d3105533aad2463bd8ade1f65cf5b154b0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104057 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-11-10tdf#137897 scRetypePassInputDlg: re-allow password removalJustin Luth1-1/+1
This weld-conversion logic error caused a LO 6.1 regression in commit 0e4f93e88bfae3489d2de84fc2febed100880628. - m_pPasswordGrid->Disable(); + m_xPasswordGrid->set_sensitive(false); //disable == false - m_pBtnOk->Enable(); + m_xBtnOk->set_sensitive(false); //enable == true The result is that attempting to remove the password did not enable the OK button, so it was impossible. Change-Id: I4067b2ec6b89e86b21968d33c8850cca6d067e71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105049 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9eeaff5fa9070bea685db8b6bbd2dfc1565756ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105060 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-10-30Calc & Impress & Draw: Hyperlink features are added into context menu.Gökay Şatır6-3/+51
Change-Id: I9e7532d68469144ae104fabcff986a023544d076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104866 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-26Online: Hide right clicked sheet.gokaysatir4-4/+28
On core side, if user clicks on a tab with right mouse button, clicked tab is selected. So, for core side, if this feature will be desired, some more modification will be needed. Change-Id: Ic4755b27b8ba98d3a6aa086b2e0a3566d095ba16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103685 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104077 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-10-06Online: Copy hyperlink location. / Core side.gokaysatir6-8/+49
Payload format is added to LOK_CALLBACK_CLIPBOARD_CHANGED. Clipboard changed event is not fired when "copy hyperlink location" command is issued. So i added a call to LOK_CALLBACK_CLIPBOARD_CHANGED inside TextDataObject::CopyStringTo function. Change-Id: I8157572288da88b5522662e13abe151ef8548b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103729 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-10-05Set correct gradient color for chart background in sidebarSzymon Kłos1-0/+29
Change-Id: I98dc177494fddc4a975479e99aba7b6318051b1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103618 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-10-05Set correct color for chart background in sidebarSzymon Kłos1-0/+47
Change-Id: Id41fba75133e3473dcb834c72ff2ecfb317ecb79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103603 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-09-28Online: Show input help on Online / Core part.gokaysatir3-0/+15
Change-Id: I9d10179f266a725b770fdae50045fdb5d77178ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102708 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103521 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
2020-09-04tdf#83779: convert TRUE/FALSE constants to functions TRUE()/FALSE()Mike Kaganski4-6/+39
This avoids problems with round-tripping Excel spreadsheets, where previously a formula like =IF(ISNA(A1)=FALSE;"a";"b") was imported as =IF(ISNA(A1)=0;"a";"b"), and when exported back, it didn't work in Excel, because boolean values had a distinct type in it. Change-Id: I672a631bfa1a4811349794f714293404c6b24381 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86238 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102064 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-09-01Resolves: tdf#130108 ensure we don't reuse the last SetSearchMask settingCaolán McNamara1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93366 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit c8a4fa577e5daec6520a810b4df753a67d9dd5a8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93372 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 636e1dff386d130e46ab39417d0d447241f33dde) Change-Id: Iddc4438b8bd30576be4531d47b6be0ac70847a9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101884 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2020-08-28LOK: do not show calc notes in the onlinePranam Lashkari1-2/+14
Change-Id: I3d69aab2a76948182483025536dbc4ddc928a86e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101510 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-08-21Use localized default sheet name, if sheet name is missing in xlsx fileAndras Timar1-1/+3
Change-Id: I8a4708437c41374f67e60d22f56d374c39b4ad3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101068 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-08-14Shadow color setter for onlineSzymon Kłos1-0/+8
Change-Id: Id79d879a6017beb39e95a8d923e8368178901c74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100502 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-07-28LOK: added margin between sidebar and formula-barPranam Lashkari1-1/+3
Margin code moved from online to core Adding offset in online caused row/column header getting out of sync Change-Id: Ie977e0f6c6180b2bc20c94b88fd1d56144ed5faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96893 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-07-22lok: sc: Desktop: Function wizard isn't properly asyncMarco Cecchetti2-3/+48
Open another view of the same spreadsheet when the function dialog is open. Note how the document in the new view can't be edited. This patch avoids to have a view locked after creation when in an other view the formula dialog is open. See also commit 009d275. Change-Id: Ie51f414c4ad83ef20526d10be3251e174158096c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98822 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-07-21Revert "tdf#128502: Try to support multiple documents ...cp-6.2-20Andras Timar16-65/+52
in LibreOfficeKit-using process" This reverts commit b0da52d19ed40dd0871f208eb7387ec1d8252de4. We decided not to have this "multiple docs" feature in stable cp-6.2 because it caused regressions that we could not fix quickly. Change-Id: Ib9ad6e010935e6a936832c01756700735a8cc6c5
2020-07-21Revert "tdf#128502: Remove assertions that fire for gtktiledviewer ...Andras Timar1-0/+3
on two docs" This reverts commit a84adccbd8cda66fd4d84c8443b0715820afd1da. We decided not to have this "multiple docs" feature in stable cp-6.2 because it caused regressions that we could not fix quickly. Change-Id: I01de0740cafa27a2fd5e07dd3a3ebd223c64297f
2020-07-21Revert "tdf#128502: Remove one more assertion"Andras Timar1-0/+1
This reverts commit daebdc6928aff7c09f9e961ce11c38d5e636ed0b. We decided not to have this "multiple docs" feature in stable cp-6.2 because it caused regressions that we could not fix quickly. Change-Id: I57928d615d03f850cae6b713eb6a0601a57c6e99
2020-07-21Revert "Avoid crash with multiple documents open in the iOS app"Andras Timar1-6/+0
This reverts commit 818a68cb259078fe2cc1ae1d82d3b854e49b24fe. We decided not to have this "multiple docs" feature in stable cp-6.2 because it caused regressions that we could not fix quickly. Change-Id: I526b094d255a40d7b9427237ffdd86e3923e64ca
2020-07-21Revert "Let's not run on hope"Andras Timar1-5/+6
This reverts commit 6dd8180d046e88f95816d59701f78b2f81e1cb64. We decided not to have this "multiple docs" feature in stable cp-6.2 because it caused regressions that we could not fix quickly. Change-Id: Ib2b6b5196221ef2ec16308cc79b245a2c8d6e7de
2020-07-10Don't reset reference marks when editing the formulaSzymon Kłos1-2/+7
This prevents us from hiding reference marks on switching sheets when formula is under edit. Change-Id: I4bf1e36967420c12bfa974b0aeefda537a26eed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98364 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 5fc0cea87be4b439bb3d3a5281984fd16b05dc28) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98349
2020-07-10Get correct tab for current selectionSzymon Kłos1-1/+1
Change-Id: Ie3146675a5b6cca5357fccc668ce17b859836147 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98315 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 88417fb01bf03969970b574421a7688768dff6ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98340
2020-07-09Empty reference marks on selection resetSzymon Kłos1-0/+2
Change-Id: Id085b6b608335e1bcc085d7a8c972622a918f1ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98316 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 7e8bcf38f00b3c45a78ba7a60aeb9e6dee11a23e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98341
2020-06-26Revert "tdf#133858 opening spreadsheet with large array formula takes 10 ↵Noel Grandin1-9/+0
mins" (tdf#134234) This reverts commit 9a5f2961b085ce2f23ecdf0a03d1114bacac8e2c. Reason for revert: causes regression, see tdf#134234 Change-Id: I1cc3e6daa0e65231e8a4d7c1ae4a60cfdf106457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97055 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-25Let's not run on hopeTor Lillqvist1-6/+5
Change-Id: If2fb2c55d53321ec2e5beff0ade9974c02811f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97120 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-25Avoid crash with multiple documents open in the iOS appTor Lillqvist1-0/+6
Also add a FIXME. Just 'hoping' is not good enough. But yeah, much of this code indeeed works mostly by accident. Change-Id: Ic6bcbc10229a0b7cdd8d696794efe152fca4faea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97117 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-25tdf#128502: Remove one more assertionTor Lillqvist1-1/+0
See bda60c9b1ca6a0fbfde9f3428489f33729cc81f1. Change-Id: If67f0696c56b0984dcfffdcf748d4f412874a64f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95061 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95145 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-25tdf#128502: Remove assertions that fire for gtktiledviewer on two docsTor Lillqvist1-3/+0
If you run gtktiledviewer so that it opens a spreadsheet and a text document these assertions would fire. In each case the assertion is followed by code that just returns if the asserted condition doesn't hold, so it is unlikely that this change will break anything. There sure will be a lot of further changes needed to make such a use case work. (For starters, editing either of the two documents does not work.) But let's do it step by step. Change-Id: I4063dbbcac7c77b57e1f4cb3f05bd5096c08c0fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95037 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95144 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-25tdf#128502: Try to support multiple documents in LibreOfficeKit-using processTor Lillqvist16-52/+65
The LibreOfficeKit-specific code typically has assumed that all the "views" (SfxViewShell instances) are for the same document, because all LibreOfficeKit-based application processes (including the "kit" processes in Online and the iOS app) so far have only had one document open at a time. It is now possible to pass several document file names on the command line to gtktiledviewer and that is an easy way to demonstrate how badly it still works even with this patch. Introduce a unique numeric document id that is increased in the LibLODocument_Impl constructor. Add APIs to access that. When iterating over views, try to skip views that are not of the document visible in the "current" view, if we know what the "current" view is. Also add a couple of FIXMEs at places where it is a bit unclear (to me) whether it is correct to iterate over all views, or whether only views for the "current" document are what we would want. Change-Id: I6e2d85e61a6743ca110500bf48b3d80b2027dfb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97085 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-25Revert "tdf#128502: Try to support multiple documents in ↵Tor Lillqvist15-62/+50
LibreOfficeKit-using process" This reverts commit 3d9e60524fcb4d62fbf17af0ccd1f9613b1b8470. Reason for revert: The commit dc13c656dc25ed35c31bec7b6c8ae7d0c6b258e3 that was merged in the meantime means that this change that now is reverted doesn't compile, and besides it doesn't handle the additional SfxViewShell loop that dc13c656dc25ed35c31bec7b6c8ae7d0c6b258e3 introduced. More work needed... Change-Id: I9886445d2f7b6ce939546c0673bdb8a32afe1abf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97053 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-24tdf#128502: Try to support multiple documents in LibreOfficeKit-using processTor Lillqvist15-50/+62
The LibreOfficeKit-specific code typically has assumed that all the "views" (SfxViewShell instances) are for the same document, because all LibreOfficeKit-based application processes (including the "kit" processes in Online and the iOS app) so far have only had one document open at a time. It is now possible to pass several document file names on the command line to gtktiledviewer and that is an easy way to demonstrate how badly it still works even with this patch. Introduce a unique numeric document id that is increased in the LibLODocument_Impl constructor. Add APIs to access that. When iterating over views, try to skip views that are not of the document visible in the "current" view, if we know what the "current" view is. Also add a couple of FIXMEs at places where it is a bit unclear (to me) whether it is correct to iterate over all views, or whether only views for the "current" document are what we would want. Change-Id: Id5ebb92a115723cdeb23907163d5b5f282016252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95353 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96356 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-24lok: calc: messed up view when deleting from multiline contentMarco Cecchetti3-0/+59
To see the problem was enough to click on the cell with the multiline content (because of wrap text enabled), and press delete. Change-Id: I8288e7739c8513f5fa0bdee5f7eb414b4abac456 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96905 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-12lok: formula bar: disable tunneled tooltipsMarco Cecchetti1-3/+3
Tooltips overlaps the entered text. Change-Id: If003217fe1270a4a3ebc0ba9eee71cb8f6765760 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95792 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-10tdf#133858 opening spreadsheet with large array formula takes 10 minsNoel Grandin1-0/+9
the spreadsheet has lots of SUM(IF over a whole column. Which results in us allocating a matrix with 1 million rows, which is rather slow to process. So reduce the matrix to the data that is actually there. We can only do this for some opcodes, because other opcodes act differently when referencing empty space, so for now I only perform this optimisation for the opcode in use in this spreadsheet. This takes the load time from 5m to 3s on my machine. Change-Id: I41fe9afcb0fbdf2a928a19c44a0f291a1247a41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9a5f2961b085ce2f23ecdf0a03d1114bacac8e2c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96041 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-10tdf#128502: Avoid potential crash in mobile app with multiple open documentsTor Lillqvist1-1/+1
Change-Id: Ibb819818db40b2f086e5c1f2330a7f8f2fcc1727 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95148 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-04LOK: Emit the doc. modified state even when changing the cell inline.Jan Holesovsky2-6/+21
The "LOK: emit modified status on entering cell data" patch did this only for the formula input line, and did not change the state when the user just clicked on the cell and started modifying it; so this patch extends it. Also change the actual DocumentModified state of the document directly instead of just sending a flag, so that the state in LOOLWSD and in the core don't get out of sync. Change-Id: Ie516ce5a74d94247d79cf993517d7f4a6657cc94 Reviewed-on: https://gerrit.libreoffice.org/75701 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95517 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-05-25Fix sending reference marks for current selectionSzymon Kłos1-5/+11
When selecting range on mobile in validation dialog the message wasn't sent due to missing ViewShell Change-Id: Iaab543368469cd363b54b1a89f6983b8c01877ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94693 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-21weld SvxSearchDialogCaolán McNamara1-4/+4
I have to use the other way to specify an a11y role, both are implemented in the vcl parser, but in my gtk3-3.24.7 the role tag crashes the gtk parser, while the other route works fine. The CONTENT_FLOWS_TO accessibility relation is another additional complexity over the norm Change-Id: Ia096bcbe9f00f9944e4e4d5ad9bb1a52d19c7b3f Reviewed-on: https://gerrit.libreoffice.org/69569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94592 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-19Fix 'GetNumLines' overrides a member function but is not marked 'override'Tor Lillqvist1-1/+1
Change-Id: I85fa65263337712005d5758b43f87ad5081653a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94534 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-19jsdialog: use for message dialogs on mobileSzymon Kłos1-1/+6
Change-Id: Ib172dc264d7f55fef08dc474f7e6f4d1b3108085 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94431 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-16 05:06:59 +0000