summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2013-03-15Turn off debugging and silence compiler warning.Kohei Yoshida2-2/+4
Change-Id: If2bfc9f346d7f2eee20caa30e1eb1f60d266ef90
2013-03-15Oops the erase() method takes start and end positions.Kohei Yoshida1-1/+1
The second parameter has to be the absolute end position, not the size from the start position. Change-Id: I310ec52697d0521a82810889f6fe861471279645
2013-03-15Better consistency checking.Kohei Yoshida1-1/+25
Change-Id: I096282ebb9a10d212affbab32aaa49ca1815b1a7
2013-03-15Fix the text width array going out of sync when shifting row positions.Kohei Yoshida1-0/+9
Change-Id: I7b9c5554e38a25dd4ff6980e6ae0d1eff241a746
2013-03-15Delete cell segments using reverse iterator (as TODO comment said).Kohei Yoshida1-43/+30
This makes it much simpler, and less error-prone. Change-Id: I21dbe0d2bb4a71fc2ac738a5ffb03e4d959d91a5
2013-03-15Don't forget to set text widths here too.Kohei Yoshida1-1/+6
Change-Id: Ieaa9bd0e4f8117e3bc7ceccc68d6f37daac61440
2013-03-15Move some of the code to local functions to make it easier to read.Kohei Yoshida1-46/+63
Change-Id: Ib7ca5c04ec057dbce958d580ad3b7d52d19ed21f
2013-03-15Reduce indentation level.Kohei Yoshida1-104/+100
Change-Id: Ia70d1dfde53e13e7d40e7cb8fa09dc401570aa93
2013-03-15Add integrity check after column cell storage is modified.Kohei Yoshida2-0/+29
Change-Id: I8d2bd7616e0428e4e881ef0dc1012c4973e636a9
2013-03-15Call CellStorageModified() *after* the text widths get modified.Kohei Yoshida2-18/+16
So that I can put some integrity check code in there to test the integrity of cell storage. Change-Id: I0cc141ea74c27db1a014390b7abf807220e7be9f
2013-03-15Create skeleton accessors for cell text script types.Kohei Yoshida8-3/+49
Change-Id: I5408cdd87f06423a6bb287c855237878859da880
2013-03-15restore enough of XOBitmap to do fore/back color setting on escher patternsCaolán McNamara1-0/+12
i.e. restore the logic of setting the colors of imported escher patterns like we always did in the past. Stripping that out seems risky in the absence of definite test-cases. Change-Id: I16bbb451b053fd04a5154602f8f38ed799e21286
2013-03-15Related: #i119125# change XFillBitmapItem to work with GraphicObjectArmin Le Grand2-15/+4
Completely changed XFillBitmapItem to work with GraphicObject, removed XOBitmap class, adapted all usages (also the pretty old 8x8 pixel editor). All Bitmap fill styles will now accept transparent bitmaps as fillings in all variations (tiled, etc.). LoadSave is no problem, ODF defines graphic as content for fill. Backward means that OOs before this change will use a white background of fill with transparent, same as the fallback all the time when using a transparent fill. This is also a preparation to e.g. offer SVG or Metafiles as fill style. Conflicts: cui/source/tabpages/backgrnd.cxx cui/source/tabpages/tparea.cxx cui/source/tabpages/tpbitmap.cxx filter/source/msfilter/msdffimp.cxx filter/source/msfilter/svdfppt.cxx sc/source/filter/excel/xiescher.cxx sd/source/ui/func/fupage.cxx svx/inc/svx/dlgctrl.hxx svx/inc/svx/xbitmap.hxx svx/inc/svx/xbtmpit.hxx svx/inc/svx/xtable.hxx svx/source/customshapes/EnhancedCustomShape2d.cxx svx/source/dialog/dlgctrl.cxx svx/source/svdraw/svdograf.cxx svx/source/tbxctrls/fillctrl.cxx svx/source/unodraw/XPropertyTable.cxx svx/source/xoutdev/xattrbmp.cxx svx/source/xoutdev/xtabbtmp.cxx Change-Id: Id838bfbacc863695d078fb3cf379d1c0cd951680
2013-03-15follow patch for fdo#38385 attempt to detect rtlNoel Power2-6/+39
tbh this is somewhat of an optimistic attempt to swap start and end borders if needed. I am not at all sure though that I am dectecting the RTL-ness of a cell in the correct way. There are some comments in the code in any case that reflect my uncertainty ( hopefully they will be of use if/when some tweak is needed ) Change-Id: Ic3099fbab08e46899ca311c81edbcad9bf5ab2a6
2013-03-15Tentative fix to make JunitTest_sc_unopai work againStephan Bergmann1-0/+4
...which started to fail reproducibly at least for me with recent commits, with [...] > checking: [sc.ScCellRangeObj::com::sun::star::beans::XTolerantMultiPropertySet] is iface: [com.sun.star.beans.XTolerantMultiPropertySet] testcode: [ifc.beans._XTolerantMultiPropertySet] > LOG> Execute: setPropertyValuesTolerant() > LOG> starting required method: getPropertyValuesTolerant() > LOG> Execute: getPropertyValuesTolerant() > LOG> starting required method: getDirectPropertyValuesTolerant() > LOG> Execute: getDirectPropertyValuesTolerant() > Method getDirectPropertyValuesTolerant() finished with state OK > LOG> getDirectPropertyValuesTolerant(): PASSED.OK > Method getPropertyValuesTolerant() finished with state OK > LOG> getPropertyValuesTolerant(): PASSED.OK > ValueChanger don't know type class com.sun.star.table.TableBorder2 > warn:legacy.osl:19841:96:sc/source/ui/unoobj/fmtuno.cxx:197: lclResolveGrammar - unspecified grammar, using GRAM_PODF_A1 > warn:legacy.osl:19841:96:sc/source/ui/unoobj/fmtuno.cxx:197: lclResolveGrammar - unspecified grammar, using GRAM_PODF_A1 causing a SIGSEGV at > #24 <signal handler called> > #25 0x00002aaacd9b310b in ScBaseCell::SetScriptType (this=0x0, nNew=8 '\b') at lo/core/sc/inc/cell.hxx:104 > #26 0x00002aaacdc86a9f in ScTable::InvalidateTextWidth (this=0x2aaad80d9e00, pAdrFrom=0x2aaacd16ac00, pAdrTo=0x2aaacd16abf0, bNumFormatChanged=true, bBroadcast=false) at lo/core/sc/source/core/data/table5.cxx:1200 > #27 0x00002aaacdabb18a in ScDocument::InvalidateTextWidth (this=0x2aaad88a19f8, pAdrFrom=0x2aaacd16ac00, pAdrTo=0x2aaacd16abf0, bNumFormatChanged=true) at lo/core/sc/source/core/data/documen8.cxx:440 > #28 0x00002aaacd982d94 in ScAttrArray::ApplyCacheArea (this=0x2aaad81d5380, nStartRow=0, nEndRow=4, pCache=0x2aaacd16ac70, pDataArray=0x0) at lo/core/sc/source/core/data/attarray.cxx:825 > #29 0x00002aaacd9cdaa2 in ScColumn::ApplyPatternArea (this=0x2aaad80d9e00, nStartRow=0, nEndRow=4, rPatAttr=..., pDataArray=0x0) at lo/core/sc/source/core/data/column.cxx:450 > #30 0x00002aaacdc638cf in ScTable::ApplyPatternArea (this=0x2aaad80d9e00, nStartCol=0, nStartRow=0, nEndCol=3, nEndRow=4, rAttr=..., pDataArray=0x0) at lo/core/sc/source/core/data/table2.cxx:2174 > #31 0x00002aaacdad93ce in ScDocument::ApplyPatternArea (this=0x2aaad88a19f8, nStartCol=0, nStartRow=0, nEndCol=3, nEndRow=4, rMark=..., rAttr=..., pDataArray=0x0) at lo/core/sc/source/core/data/document.cxx:4204 > #32 0x00002aaacdaddeef in ScDocument::ApplySelectionPattern (this=0x2aaad88a19f8, rAttr=..., rMark=..., pDataArray=0x0) at lo/core/sc/source/core/data/document.cxx:5232 > #33 0x00002aaace0c46ab in ScDocFunc::ApplyAttributes (this=0x2aaad8910f70, rMark=..., rPattern=..., bRecord=1 '\001', bApi=1 '\001') at lo/core/sc/source/ui/docshell/docfunc.cxx:1267 > #34 0x00002aaace268e02 in ScCellRangesBase::setPropertyValuesTolerant (this=0x2aaafa235fb0, aPropertyNames=uno::Sequence of length 97 = {...}, aValues=uno::Sequence of length 97 = {...}) at lo/core/sc/source/ui/unoobj/cellsuno.cxx:2933 > #35 0x00002aaabc674df6 in gcc3::callVirtualMethod (pThis=0x2aaafa236018, nVtableIndex=3, pRegisterReturn=0x2aaad8b94820, pReturnTypeRef=0x2aab601513a0, bSimpleReturn=false, pStack=0x2aaacd16b240, nStack=0, pGPR=0x2aaacd16b2c0, nGPR=4, pFPR=0x2aaacd16b2f0, nFPR=0) at lo/core/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:119 Change-Id: I4cf6386f903e2681033bd63005141f71feb13ad7 Reviewed-on: https://gerrit.libreoffice.org/2740 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-03-15fix "simplify copy"Ivan Timofeev1-1/+1
the second argument is a count Change-Id: I1b6d7db8ba3ac83ef0be091c25e28ad93375d432
2013-03-15forgot the fileMarkus Mohrhard1-0/+42
Change-Id: I90a001b354810daefd6cd05ca96de4207eee15aa
2013-03-15simplify copyThomas Arnhold1-1/+1
Change-Id: Iec5a960b0a6492b1e4690c31b9c2098248c23cfa
2013-03-15remove some unnecessary linesMarkus Mohrhard1-10/+0
Change-Id: I0a83769f19a38fd5c0421ba6117603517cded17b
2013-03-15first step for Insert->Chart From FileMarkus Mohrhard5-2/+75
This needs some tweaks but it looks like we are already able to choose the chart and import it. There are some more tweaks needed to handle internal vs. external data provider, errors, other components, ... Change-Id: Ib3e7f8bbf7b7f49b071d85120930624e2add91a7
2013-03-15remove empty destructorMarkus Mohrhard2-10/+10
the base class destructor is already virtual Change-Id: Iab38666fab3a8ef33e2fd1ee1c53754ef50f5481
2013-03-15remove unnecessary ascii artMarkus Mohrhard2-54/+0
Change-Id: If554782930a8cf35fa4366d8f92020f1c7b5cbd3
2013-03-15initial work on an odc exportMarkus Mohrhard6-4/+63
We can now export a chart to odc when we are in chart edit mode from Calc. I need to add support for it to Writer and Impress as well. We can already open these files but copy&paste from the opened file fails. The next step is then to add a new menu entry Insert->Object->Chart from file Change-Id: I14d1702e79517e7319a1929de2be5501d375885d
2013-03-15fixesThomas Arnhold5-6/+6
from b0cf3aba085373d84a55ef144b273a8a89d017af Change-Id: I03a7df23ea9838715304d0359536403af89bcfa3
2013-03-14fdo#38838: Replaced some (Uni)String to OUString in core/scelixir10-98/+99
Change-Id: I4fa27b933c5b3cf2645b139bf6349b90f613feab Reviewed-on: https://gerrit.libreoffice.org/2735 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-14Remove ambiguity for the windows build.Kohei Yoshida1-1/+2
Change-Id: I9b94281f7acd2223686508baa219b87c13838d5c
2013-03-14Pointless nit-picking on coding styleFridrich Štrba1-5/+3
Change-Id: I54bd60c11a83feceb39557a82c62e290438dff80
2013-03-14Remove a local inline function that's used from only one call site.Kohei Yoshida1-9/+6
Change-Id: I73954b8a1de436b9c4881d803f4f33cff1b79c4f
2013-03-14Unit test for the new column-based text width storage, via new iterator.Kohei Yoshida7-53/+171
Change-Id: Ibf1e254e34df98ad5c46a46252168787b07d161c
2013-03-14Move TEXTWIDTH_DIRTH to globalnames.hxx.Kohei Yoshida9-1/+11
Change-Id: I648da6f2c43a10137c0834659022296883368dc9
2013-03-14We should exit the idle calc when the sheet changes.Kohei Yoshida1-0/+3
Otherwise the code would end up in an undefined state. Change-Id: I47f58698ac1eb94bf92ab7278bb7521d892ba340
2013-03-14ScBaseCell::nTextWidth is no more.Kohei Yoshida4-11/+13
Change-Id: I32368d39a21d44bef8ab7fe265077cd147a50024
2013-03-14MaybeAddExtraColumn() too. This one is trivial.Kohei Yoshida1-2/+3
Change-Id: I0cd33c90bdb3c6b7cf48677140e3c66fa78caaba
2013-03-14InvalidateTextWidth() now uses the new iterator.Kohei Yoshida1-43/+51
No more SetTextWidth() directly to the cells. Change-Id: I0a2aba63685ea1461b763e8d628052ecd4c71c25
2013-03-14Forgot to increment the iterator.Kohei Yoshida1-0/+1
Change-Id: Ica8c9be8a383879a509d90c6da6309d2eee4fe8c
2013-03-14IdleCalcTextWidth() now sets cell text widths to the new container.Kohei Yoshida3-12/+29
No more direct access to ScBaseCell's nTextWidth. Change-Id: I5a0a5fd24555d9fa8e1de895f0f9d8b710cc8094
2013-03-14First cut on column text width iterator implementation. Untested.Kohei Yoshida4-6/+164
Change-Id: Ic615e5645f1a89a4b1a60dc519eb79ff921203a9
2013-03-14Add skeleton files for the new iterator for column cells' text widths.Kohei Yoshida4-0/+42
To be implemented soon. Change-Id: Ifa72245f89635ac604c233197891fb67c8d99915
2013-03-14Some renaming of local variables...Kohei Yoshida1-10/+9
Change-Id: I27b5512d90eba0c0235d11d1b4f1c9cafc4bcce6
2013-03-14Reduce scope level.Kohei Yoshida1-95/+97
Change-Id: I28db9130864ac3408398834bfbbdeb904ca4948e
2013-03-14A bit more re-organization.Kohei Yoshida1-14/+7
Change-Id: Ie722a910303ff8852c164ccc9ae256d52f4695f0
2013-03-14Move the style sheet pool handling too.Kohei Yoshida1-16/+15
Change-Id: Ia24e2effa8d6200eb0e9ad5e30fb5c9a4d8dd670
2013-03-14Move progress bar handling to the scope object too.Kohei Yoshida1-10/+19
Change-Id: Iff93958c5025e000f7e39eb71e3f91ff41db911a
2013-03-14Use a scope object to avoid manual unwinding at the end of the call.Kohei Yoshida1-55/+103
Change-Id: Id2565dfa250b93ba4f70e596d6b66f3e5e55fb5f
2013-03-14Reverse the logic of enable / disable idle flag...Kohei Yoshida16-49/+50
so that true -> enabled and false -> disabled. This is much easier for human brain to process. Change-Id: I51059ee9090610ad8455a072b165860527cd9d50
2013-03-14Use inline function over preprocessor macro.Kohei Yoshida1-12/+16
Change-Id: I08d83f274af1ce891235c2f24d5e4b697de19309
2013-03-14Annotate this algorithm & a few cleanup and one possible bug fix.Kohei Yoshida1-11/+21
Change-Id: Ifd101364119db7c30ba28e66b4a8b1320a54fe66
2013-03-14Turns out I can't really use ScColumnImpl.Kohei Yoshida4-48/+82
Because the column source files are split; not all source files had access to the impl class definition. Change-Id: Ic8cff0eeec3504660304be9f020c40bcd98cee85
2013-03-14Accessor in ScTable.Kohei Yoshida2-0/+12
Change-Id: Id29e746c799365c679e60f22f88bfbcb3dbdf693
2013-03-14Add accessor methods for text widths using mdds::multi_type_vector.Kohei Yoshida2-9/+24
We only use unsigned short and empty types in this container. Empty type represents empty cells whereas unsigned short type represents non-empty cells. Change-Id: Id9b6e0941fdfabc48fc8bb2aa6479f466270381c