summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2013-02-13bnc#802350: Cell validation is not a special (cell) content.Kohei Yoshida1-2/+1
Cell validation is stored as cell attributes which are stored with columns not with cells. When HasSpecialContent() is true, it flags the *cell* not empty, which in turns causes AddTextAndValueCell to iterate over every single cell position for all repeated columns and rows. That can very very slow when the number of repeated rows is very high. Since cell validation is stored with columns, skipping empty cells even when they have cell validation settings set won't cause any issues, and all cell validation settings are imported correctly even after this change. With the test document I have (confidential), this change alone reduces the load time from 30 seconds to 0.3 seconds. 3.6 cherry-pick note: The 3.6 branch doesn't have HasSpecialContent() method, but the logic was still the same and I've applied equivalent fix for this branch. Change-Id: Ifa6c6d70fa926d0a0037b35149373cfaf29db431
2013-02-05fdo#39135: Prevent integer overflow & update the character during loop.Kohei Yoshida1-0/+5
These two errors in the code contributed to the reported bug. Let's fix them. Change-Id: If82a1bd4d1e27145b48e722b30388cc9dc4a8a6e
2013-02-05fdo#59426: Don't try to repair package during flat detection phase.suse-3.6-10Kohei Yoshida1-3/+9
Conflicts: comphelper/source/misc/mediadescriptor.cxx sc/source/ui/unoobj/scdetect.cxx Change-Id: I35968241a79db0aabe06e25c0efac2aa3d1c5b84
2013-02-05Disabling sc_chart_regression_test (like on Master)Muthu Subramanian1-1/+3
Change-Id: I18d8fb4b993771d3365bf3dbfbb781ef17ed20ab
2013-02-01bnc#801152: Scan all columns to determine the first data row.Kohei Yoshida1-3/+4
When scanning the entire data range in an attempt to determine where the first data row is, we shouldn't stop at the first column. We should scan all data columns to make sure we pick the lowest value row position among all columns. Change-Id: I693ec169857b181c6b4237efcba3fa6a46eaa531
2013-01-30bnc#492440: Sort autofilter popup items correctly.Kohei Yoshida1-5/+5
Use locale-aware collator to sort strings, instead of using the transliterator. The actual sorting algorithm for cell sort uses collator. Let's be consistent with it. Change-Id: I6729553ce92d50e45fa1ea6e1c35581fd791807d
2013-01-30Fix the build.Kohei Yoshida1-1/+1
Change-Id: Iea8a02ceab7b603b5363b9df74e1381f152d70e1
2013-01-30Don't overwrite bCalcAll when it's already set & remove SetCompile().Kohei Yoshida2-2/+2
Change-Id: Ieaf84e8d36efa8314729903be029f83c31bcbdf3
2013-01-30bnc#615357: Recompile cells with #NAME! for English function name option.Kohei Yoshida7-6/+102
When the option for using English function name changes, we should re-compile all cells with #NAME! as the error may have been caused by unresolved function name which may be fixed after the option change. Change-Id: Id340ce9b5db3ed368b98e814861be5c3f96df071
2013-01-02fdo#47466 FORMATTING: Autoformat empty rows causes app to crashJulien Nabet1-0/+2
Thank you John LeMoyne Castle for your support http://nabble.documentfoundation.org/Wrong-indentation-which-leads-to-segfault-in-sc-source-ui-docshell-docfunc-cxx-td4026726.html However, the weird thing is I reproduced the crash with master sources but didn't with 4.0 branch nor with 3.5.4.2 Debian packages Change-Id: Ia5366f479a1066106551b77b5a6315fb78e1bf7d
2012-12-21we need to catch the exception here, fdo#57451Markus Mohrhard1-1/+8
Change-Id: I203aa640e7d4373f3a090a4988c28c6059b93064 Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2012-12-14Do extra check on source range to make sure no funny things happen.Kohei Yoshida2-0/+13
Like a crash in the pivot layout dialog... :-/ Change-Id: I9a330ee3f39ebacb7299d24868bb13ee2a9c3ec5
2012-12-14fix sometimes data corruption with xlsx import ( with scenario sheets )Noel Power1-5/+2
formula import is buffered 'till the end of import. The processing of the formula data need to happen before the scenario import happens. This is necessary because sheet numbers stored in the formula addresses can become invalid as scenario import insertes new hidden sheets upsetting the previous table order Change-Id: I9357f028f31bec1b1504ca991f5534f80d79c9bc
2012-12-14fix fdo#58237 import hyperlinks for shapes in xlsx documentsNoel Power3-1/+43
Change-Id: Ib0c661dbb3ce9a2f8c8d29707a1cf0c65aadc81f
2012-12-13bnc#791706: Support multiple selection in page fields.Kohei Yoshida28-408/+405
This change allows selecting multiple items in page field popups in pivot table. Conflicts: sc/source/ui/cctrl/checklistmenu.cxx sc/source/ui/inc/viewdata.hxx Change-Id: I692e13c0815211bac6da47fefd83bba18c901c5c
2012-12-13Revert "fix for bnc#791731 preserve cell formatting of datapilot area ("Kohei Yoshida5-33/+7
This reverts commit 3bc88c4fdc2a05f816f29cb42b7d4f609214357c. This needs a new solution.
2012-12-06bnc#792528: Import static data series labels from xlsx correctly.Kohei Yoshida2-52/+40
Static data series label is a data series label whose value is a string value rather than a cell reference. Also, when inputting static string label in the UI, we don't have to manually check for quotes; the formula compiler will take care of that later. Change-Id: I1657fc9879a7f652bba84898e308c3a5d5ba87a3
2012-12-06Avoid activating window pane when launching popup window.Kohei Yoshida2-17/+26
Else, activating another window pane where the cursor is not would cause the pivot table field popup to immediately get dismissed after launch because ClickExtern() gets called from ActivatePart(). For example, imagine a field popup button is on C2, the cell cursor is on E5, and the window is frozen between rows 2 and 3. Clicking the popup button in C2 would launch it for a brief second and dismiss it immediately afterward. Conceptually, launching a popup in another pane shouldn't activate that pane anyway. So it makes sense not to activate it for that scenario. Change-Id: Ib970cb898fb9c79d254411e2519cfce74c60b72f
2012-12-06fdo#57497: Remove group table data when all group dimensions are gone.Kohei Yoshida5-37/+86
Otherwise ungrouping date grouped dimension may crash, or produce incorrect results. Change-Id: I3634e3c0bf8336fc1221f5d234cb7e01eb1f07c6
2012-12-05fix for bnc#791731 preserve cell formatting of datapilot area (Noel Power5-7/+33
also uses the cell formatting to set up the field buttons background & text/font attributes Change-Id: I5f5a46bfc7f0b7aabb8872c25b3c3134e90611ac
2012-11-21fdo#56584: delete also note caption.Markus Mohrhard1-1/+1
Change-Id: I1d792082e79d6bb68004a84c172cc3bb5c194826 Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-21fdo#54898: Test equality by order index (integer) which is more stable.Kohei Yoshida1-3/+3
At the point where std::unique is called, we can use order indices to determine whether the two items are equal. This should be more stable than using CaseInsEqual() to assess equality. Change-Id: I88310fc7beede19fb1c629b9b7e3cb9a069b2b23 Reviewed-on: https://gerrit.libreoffice.org/1013 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2012-11-21remove conditional formats withiout range after import, related fdo#56983Markus Mohrhard3-4/+29
(cherry picked from commit eb240530443b964ea45bf80a5e3711e11a3f09c5) Change-Id: I9a8c02369c3e5a12310a46229bdc1671f75593ad
2012-11-20only set entries for existing sort entries, related fdo#56958Markus Mohrhard1-1/+1
Change-Id: Ib48606402fb90b259f705badeac294d7c336cb9c (cherry picked from commit c45b6496e87fe74570a41821bc5f4fbdb3d3cf8e) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-11-20make sure that the sort vector is large enough, fdo#56958Markus Mohrhard1-0/+3
Change-Id: I7099e984a8b05ccd3324f3b9231c193e716eaf83 (cherry picked from commit cd545dcf511daedd548c11159b8c244f272e9cb6) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-11-20fix for fdo#55875 numbers as text converted strangelyNoel Power1-1/+8
old code used to use XCell->setString, new code uses rDoc.SetString which by default tries to detect number formats. The ScColumn::SetString that eventually gets called seems to do lots of additional checks ( and apparently even if an ScSetStringParam instance with mbDetectNumberFormat ( false ) was passed it seems that it will still try to detect decimal number formats. With that in mind I restore and un-unoified version of what XCell->setString used do Change-Id: Ifaef74c78b198f492a390a3d5dc1721622a01ea4 Reviewed-on: https://gerrit.libreoffice.org/1020 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-20fdo#56776: Change in formula options should cause repaint.Kohei Yoshida1-0/+5
Else Calc would fail to update the column headers due to A1 to R1C1 change (and vise versa). Change-Id: I2c403212f5bc539aea92370e60da96f480549d6d Reviewed-on: https://gerrit.libreoffice.org/1049 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2012-11-20resolved fdo#56278 broadcast deletion to dependent formula cellsEike Rathke1-32/+35
Consolidated changes for fdo#56278 fdo#54074 fdo#53364 fdo#55059 (and earlier i#99844 and i#101869). The replacement cell for the broadcaster to inform listeners, if any, is transferred the broadcaster and owns it, the remembered formula cell never does. When broadcasting the change use the replacement cell instead of the remembered formula cell. Don't fiddle around with ReleaseBroadcaster() at the remembered cell, we don't delete twice and now also don't leak. (cherry picked from commit 8165bfa2afbe828caf37df57b83cb31bef2559cb) Change-Id: Ia11b6d3d751c784af64aaed05f8508887f869a80 Reviewed-on: https://gerrit.libreoffice.org/1069 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-11-07fix ooxml color exportMarkus Mohrhard1-1/+1
Change-Id: I4b94883f594e13e9923bdd05593447a152fa8b0a Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-07export dxfs at the correct placeMarkus Mohrhard1-1/+1
Change-Id: I2ab31904169adad4f173d4655d0511855de77464 Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-07fdo#53531: Time field can be represented with an extended time field type.Kohei Yoshida1-0/+2
And Calc's header footer currently don't distinguish between time and extended time. Time fields in the header / footer are always dynamic and never static. Change-Id: If628d179968c270a63d38cdc3bf6018c01241ac1 Reviewed-on: https://gerrit.libreoffice.org/992 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-07halt corrupted styles with multi-saved xlsx document fdo#55418Noel Power1-1/+4
Change-Id: I2d53c88ab121edeec2bf53f7fd177a0edcc05a25 Reviewed-on: https://gerrit.libreoffice.org/958 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-07fix copy paste error, fdo#55673Markus Mohrhard1-1/+1
Change-Id: I1e31fe05e00ed7e298642da9c0e35ae834dfa74f Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-07only delete cond formats if the correct attributes are passed, fdo#56316Markus Mohrhard1-1/+2
Change-Id: If9859b5021c532daacccfaf386e0489c134e4afb Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-05Correctly handle cell note shifting when immediate row/column is deleted.Kohei Yoshida1-4/+12
Currently, having a note e.g. at D5, and deleting cell D4 and shifting the cells below upward will remove the note at D5. But the correct behavior is to shift that note up to D4. This change fixes it. Change-Id: Ia37f1ce67a003deab424f2b805a2ce333fc10ed4 (cherry picked from commit d3344dd85ee31b195a3709d16e734245e1d0a4b6) Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-05Fix incorrect shifting of cell notes upon cell insertion / deletion.Kohei Yoshida1-2/+8
Steps to reproduce: 1) Insert a comment at D5. 2) Move cursor to C4. 3) Right-click and select Insert. 4) Choose shift cells down. 5) The comment gets shifted down but it shouldn't. The same thing happens when deleting a cell and shifting content. Change-Id: I5a71845cca6abde6b7c940e152e155da26343cef Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-05Remove the correct range, or else maItems would end up with invalid pointer.Kohei Yoshida1-1/+1
nStopPos is non-inclusive, and STL's erase() method also expects a non-inclusive end position (like any other STL methods do). It's wrong to -1 here which would end up not erasing the last element containing a pointer to the deleted cell instance. Change-Id: Ic09ab4a6bb03d0f56bb854a91bf93a99be867116
2012-11-05fdo#56325: Don't forget to build_tree() in fillTable().Kohei Yoshida1-6/+10
Else you'll get the wrong answer in isRowActive(), which always search flag via tree. Change-Id: I3fa92d06f7ba3040eca061d5424afefe362703de Signed-off-by: David Tardon <dtardon@redhat.com>
2012-11-05Merge remote-tracking branch 'origin/libreoffice-3-6-3' into suse-3.6Petr Mladek34-198/+312
Conflicts: desktop/source/app/sofficemain.cxx instsetoo_native/util/openoffice.lst solenv/inc/minor.mk Change-Id: I3e9510067c7173f6c71368e70ba6dfe168c5318e
2012-10-30vba procedures and macro names will result in crash, fdo#55174Markus Mohrhard1-0/+4
Change-Id: I23073ecc56482670d185b39452a7d8b9d6eb38c8
2012-10-30hopefully more successful attempt to solve fdo#50304Noel Power1-5/+17
Change-Id: I86dfff571c14bce97d0851b4093dbc376d8b6ea4
2012-10-22only use non blank cells in the visible data methods, fdo#54552Markus Mohrhard1-3/+7
(cherry picked from commit 40377a6e26aa61a1c0788cad1c97a10911d38da8) Signed-off-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 23e6bac62ef6482c287bb0f55c662ac2047ebb33) Change-Id: I2a0914fbaff3e3f707a9c06f693079aed2b89ba4 Signed-off-by: Petr Mladek <pmladek@suse.cz> Signed-off-by: Eike Rathke <erack@redhat.com>
2012-10-22write the custom sort list info into the item set, fdo#53870Markus Mohrhard2-0/+5
(cherry picked from commit 4302eb0a6c4e28ab675de9d59e73cac345ba30c7) Signed-off-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 07cc274256ebff259e228e7285bc27e6ddc94fdc) Change-Id: I9c7f62b47f83b7798a8efdbf3896503918929f03 Signed-off-by: Petr Mladek <pmladek@suse.cz> Signed-off-by: Eike Rathke <erack@redhat.com>
2012-10-22ignore broadcaster cells to fill autofilter dialog, fdo#55712Markus Mohrhard1-0/+4
(cherry picked from commit 622f7751b78fd8584e34f5fa96a04ed6e8bb98f5) Signed-off-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 637096b75f2989640967e72aee41e48b07a5a602) Change-Id: Iacd3f8cfc26bb147eaf3b6957338be212b448226 Signed-off-by: Petr Mladek <pmladek@suse.cz> Signed-off-by: Eike Rathke <erack@redhat.com>
2012-10-19exchange sort settings between the two tab pages, fdo#53482Noel Power2-10/+10
Change-Id: I540481585bec2479db541025755c2a5a670da9ed Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com> Signed-off-by: Petr Mladek <pmladek@suse.cz>
2012-10-16don't insert notes from deleted cells, fdo#55885Markus Mohrhard1-4/+14
Change-Id: I036f0531dc2290c5eb480258bc70ec13b810e6bc Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com> Signed-off-by: Eike Rathke <erack@redhat.com> Signed-off-by: Noel Power <nopower@novell.com>
2012-10-15Check for null object. The OLE name may not always be set.Kohei Yoshida1-1/+1
(cherry picked from commit fb1d9cc99e026ba9cf15ab49b2251cecfbbf6d10) Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit ea50fe437b4f61e6c97d81721441da2b7d1e2f66) Change-Id: Ib3e55af8870b41a5b76179d2215fc5125ceda5af Signed-off-by: Michael Meeks <michael.meeks@suse.com> Signed-off-by: Eike Rathke <erack@redhat.com>
2012-10-11only access first element if vector is not empty, fdo#55734Markus Mohrhard1-1/+3
Change-Id: I60db486195e7216968dc8c7c7c0c79fb7e8c1b88 Signed-off-by: Noel Power <nopower@suse.com> Signed-off-by: Eike Rathke <erack@redhat.com> Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-10-11kill this hard coded sheet limit for xlsx import, rhbz#864858Markus Mohrhard1-1/+1
(cherry picked from commit 458d68fffa883bc706638299e5a5b2d1399beb0d) Signed-off-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 0eee6469304ba15f42bcafb6707cc98bcbff9112) Change-Id: I49e12d97d1e17b0a63daf374e7ff4b4720129553 Reviewed-on: https://gerrit.libreoffice.org/857 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-10-11fix for fdo#53814 Revert "there should be no need any more for this check"Noel Power1-0/+4
This reverts commit bea018a7040c36e91487b27c7b59c6c8a970bf5f. Change-Id: Id554a8f05b82f146a505ac0a39afe14a3161291c (cherry picked from commit cd9d51a36cc3106d4124855874af657615a93061) Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com> Signed-off-by: Jan Holesovsky <kendy@suse.cz> Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-18 21:24:37 +0000