summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2017-09-22loplugin:flatten in pyuno..scNoel Grandin11-472/+422
Change-Id: I7ddc0b76532d26910f78642200750459508c2861 Reviewed-on: https://gerrit.libreoffice.org/42617 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-22Bin leftover SAL_DEBUGTor Lillqvist1-2/+0
Change-Id: I452909cc1f0529ecb24b1f705a86a0a8bc1a3c9f
2017-09-22ofz: don't leak in face of exceptionsCaolán McNamara17-64/+64
Change-Id: Ic15590a13bd3770ee5dd7db76b21c830a4fe73e2 Reviewed-on: https://gerrit.libreoffice.org/42587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21tdf#112501: Pivot table: popupbuttons are placed on wrong cellsTamás Zolnai9-2/+133
...imported from XLS Change-Id: I45bc4a0182e6a62471bc02ac1bca31f9735e6566 Reviewed-on: https://gerrit.libreoffice.org/42508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt41-170/+170
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt27-60/+60
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21add fods fuzzerCaolán McNamara1-0/+49
Change-Id: I3cc5a0d8bb24dd33b63ed82866a4acfb7a2dd043 Reviewed-on: https://gerrit.libreoffice.org/42459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21ScXMLImport dtor deleted pSolarMutex before SvXMLImport dtor is calledCaolán McNamara1-2/+5
so if there are still ScXMLDatabaseRangesContext on the import stack, i.e. exception thrown during ScXMLDatabaseRanges import, then stuff crashes ================================================================= ==23249==ERROR: AddressSanitizer: heap-use-after-free READ of size 8 at 0x6020001c3190 thread T0 SolarMutexGuard::~SolarMutexGuard() /src/libreoffice/include/vcl/svapp.hxx:1420:9 ScXMLImport::UnlockSolarMutex() /src/libreoffice/sc/source/filter/xml/xmlimprt.cxx:1916:13 ScXMLDatabaseRangesContext::~ScXMLDatabaseRangesContext() /src/libreoffice/sc/source/filter/xml/xmldrani.cxx:64:19 ScXMLDatabaseRangesContext::~ScXMLDatabaseRangesContext() /src/libreoffice/sc/source/filter/xml/xmldrani.cxx:63:1 destroy /usr/local/bin/../include/c++/v1/memory:1838:64 __destroy<rtl::Reference<SvXMLImportContext> > /usr/local/bin/../include/c++/v1/memory:1706 destroy<rtl::Reference<SvXMLImportContext> > /usr/local/bin/../include/c++/v1/memory:1574 std::__1::deque<rtl::Reference<SvXMLImportContext>, std::__1::allocator<rtl::Reference<SvXMLImportContext> > >::pop_back() /usr/local/bin/../include/c++/v1/deque:2604 pop /usr/local/bin/../include/c++/v1/stack:212:19 SvXMLImport::~SvXMLImport() /src/libreoffice/xmloff/source/core/xmlimp.cxx:418 ScXMLImport::~ScXMLImport() /src/libreoffice/sc/source/filter/xml/xmlimprt.cxx:769:1 freed by thread T0 here: #0 0x6164a0 in operator delete(void*) /src/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:126 #1 0x6254e3 in ScXMLImport::~ScXMLImport() /src/libreoffice/sc/source/filter/xml/xmlimprt.cxx:787:5 #2 0x6259cc in ScXMLImport::~ScXMLImport() /src/libreoffice/sc/source/filter/xml/xmlimprt.cxx:769:1 Change-Id: Ia72284f99e2e2efe4f1f9e57b1483c0f1333274d Reviewed-on: https://gerrit.libreoffice.org/42502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21update calc notebookbar styles drop down and context-EditCell fixandreas kainz2-2/+15
Change-Id: Iaa3242120f250fb75946c8c3c448364a54203db8 Reviewed-on: https://gerrit.libreoffice.org/42342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-20tdf#112005 xmloff: ODF export: export embedded object text *first*Michael Stahl1-0/+22
... before adding any attributes, so that the attributes don't erroneously get added to the paragraph element. Also fix the problem that if you set "ODF format version" to 1.1 or 1.2, export asserts in SvXMLNamespaceMap::GetQNameByKey() because the "loext" namespace isn't registered, and creates an invalid <p> element. Change-Id: I637f9d3ff746d877ced480e35ef53f4545a06a4b
2017-09-20Resolves: tdf#99477 freeze first col/row always set a freezeEike Rathke2-11/+23
The previous implementation had the odd behavior that Freeze First Column and Freeze First Row removed any frozen state (column or row) if there was one, instead of freezing the actually selected choice. Changed to * Freeze First Column * always freezes the first column * removes another column freeze if there was one * keeps a row freeze if there is one * checks the Freeze Rows and Columns toggle box * Freeze First Row * always freezes the first row * removes another row freeze if there was one * keeps a column freeze if there is one * checks the Freeze Rows and Columns toggle box * Freeze Rows and Columns * freezes at the current cell cursor position if there was no freeze (toggle box was unchecked) * removes any freeze if there was one (toggle box was checked) Change-Id: I38c4b6f0486ef8e93da0bb3a69a99e5c7709a21e Reviewed-on: https://gerrit.libreoffice.org/41908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-20filter,sc: try to prevent potential SeekToEndOfRecord infinite loopsMichael Stahl2-15/+16
SeekToEndOfRecord() now doesn't seek to EOF if the offset is too large; break out of loops in the obvious cases where this could be problematic. But don't use SAL_WARN_UNUSED_RESULT because unfortunately GCC doesn't allow to explicitly suppress that with a (void) cast. Change-Id: Ie0211075bf0f4ef271bb26bdfead5fb070875a2b
2017-09-20unused aCId in ScHTMLExportNoel Grandin3-31/+2
ever since commit fa135fd0e05fc4ba784b4349d65f2e5ed26c0f55 Date: Tue May 31 10:30:35 2016 +0200 remove unused SID constants and associated code Change-Id: I47388fa5dcfec67bbcd9f7bf0a079d9376bc05af
2017-09-20simplify calling listenersNoel Grandin1-32/+12
Change-Id: I4bf0d378003d1f54685f6c55c0314c117b243526
2017-09-19add signature icon cause the icon is available (in breeez)andreas kainz1-1/+6
Change-Id: If221848b1ef389a1816e5aab71f784ddd932c9bc Reviewed-on: https://gerrit.libreoffice.org/42347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-19sc: fix infinite loop in XclImpDffConverter::ProcessShGrContainer()Michael Stahl1-4/+6
... and also in XclImpDffConverter::ProcessDgContainer() This was looping in CppunitTest_sc_filters_test, reportedly since commit 7e8c38b69742ff037a5e239bf0f02665f053ea53. The problem is that checkSeek() doesn't actually seek until EOF if the offset is too large. Change-Id: I16226a88388dcac8069d6a4cad860470540466e3
2017-09-19ofz: disable more config related codeCaolán McNamara1-3/+3
Change-Id: I2458000c5d46a371cec0a17fb0bfd86a2444dc42 Reviewed-on: https://gerrit.libreoffice.org/42472 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-19ofz: survive missing configCaolán McNamara1-1/+1
Change-Id: Ie09544ffefcd1789aef7a7f6193aaaddd3ad1896 Reviewed-on: https://gerrit.libreoffice.org/42467 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-19ofz: survive missing configCaolán McNamara1-1/+2
Change-Id: I9d05602b6e3af2bb54e1c82668090d71153b3c9d Reviewed-on: https://gerrit.libreoffice.org/42463 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-19fix SequenceOutputStream constnessNoel Grandin2-2/+2
Change-Id: I6e1039c077602b2cb42702cb4131f9503ef533c2
2017-09-18ofz#3412 SYLK import: check ;X;Y;C;R col/row validity earlyCaolán McNamara1-0/+10
Change-Id: I91fcd2571e528201e01467f3bcdbbff30cdfb50c Reviewed-on: https://gerrit.libreoffice.org/42423 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-18convert SvxDateFormat to scoped enumNoel Grandin1-1/+1
And simplify the code in sd/headerfooterdlg, no need for the complex encoding of date and time when we can just index into a static array. Change-Id: I677400bf1f956c81eba665b71dbda9183b63f55c Reviewed-on: https://gerrit.libreoffice.org/42346 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxTimeFormat to scoped enumNoel Grandin1-1/+1
and make the numerators look more like our internal formatting codes Change-Id: I3b3d448cec913e72c7ffb6cc3e7754241af36d93 Reviewed-on: https://gerrit.libreoffice.org/42345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxTimeType to scoped enumNoel Grandin1-2/+2
Change-Id: Ic5ca8c50ccd74837cd0521a13e1f5eaa8e326ff3 Reviewed-on: https://gerrit.libreoffice.org/42344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxURLFormat to scoped enumNoel Grandin10-15/+15
Change-Id: Ie2199cf0bcfb6d649f8aa33325ab645b18e7c000 Reviewed-on: https://gerrit.libreoffice.org/42343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: I574313da20851417c7659ce7b5bcc687ac3c97a3 Reviewed-on: https://gerrit.libreoffice.org/42339 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-15Fix loplugin:redundantcast's VisitCXXFunctionalCastExprStephan Bergmann1-2/+2
...when t1 is ElaboratedType sugar (which isn't only used when the type is written with an elaborated type keyword, but also when it is written with a qualified name). (I originally wrote testArithmeticTypedefs to track down a different issue, which turned out to be a non-issue, with this fix as fall-out. So that test doesn't quite match the theme of this commit, but is a worthwhile addition nonetheless.) Change-Id: Ic447da4399853d7d045e3e2e7ade8ddf52d89749
2017-09-15Test joining two disjoint ranges into one by adding a third inbetweenTor Lillqvist1-0/+20
In particular, the case where the third one even overlaps one of the existing ones, not just borders it. Change-Id: I3a0dff51a68b048b615f60e579e6e698518cf1bd
2017-09-15borderline: Extended decomposeArmin Le Grand1-1/+1
Decompose of BorderLinePrimitive2D extended to take care of non-perpendicular line endings for matching. Improved matching, one error in calc fixed Change-Id: I869a75385711b58e6725daba0f22be8a98158ad9
2017-09-15borderline: Adapt ViewContactOfTableObjArmin Le Grand2-3/+6
Adapted to usage of svx::frame::Style helpers for primitive creation, need much less SvxBorderLine classes and less overhead. Class SdrBorderlinePrimitive2D completely removed. Working on Array::DrawRange to get it using the Coodinate Systems which are available and include the rotation. Solved problems in BorderLinePrimitive creation in DrawRange and DrawArray by completely restucturing these. Also changed to now return a sequence of primitives to the caller instead of handing over a primitive renderer and using it for each single primitve. This is a preparation for later buffering these and not re-create for each paint. Have now a working version that uses the Cell used by the Style and creates all info on the fly, so that the correct coordinate systems will be used. Works in Calc and it's dialogs with one or multiple cells.
2017-09-15borderline: Abstraction of BorderLinePrimitiveArmin Le Grand1-6/+13
As preparation for more detailed definition of BorderLine primitives I have adapted the BorderLine definition to work with motre possibilities to define the LineStartEnd definitions in a BorderLineExtend class. That one is flexible to hold all kinds of definitions - from none to all four possible extends (Start/End, Left/Right of vector) Cleanup of DiagStyle and others: DiagStyle is not needed anymore due to no longer using angles calculated, but being based on vectors defining the geometry. Also cleaned up quite a bit of no longer needed calculation stuff for the control.
2017-09-15Handle also the case where a range extends an existing one with overlapTor Lillqvist2-4/+42
Check for a new range being joined Extending an existing one in any of four directions (up, right, down, left), within a tab (sheet), that is. And add unit test for this. Change-Id: I4bd0525c2837f8b4b9d5a8967e0d5d661c6a5e2f Reviewed-on: https://gerrit.libreoffice.org/42304 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-15convert SvxFileType to scoped enumNoel Grandin3-6/+6
Change-Id: Iec1c67f7f0f9b2244b1d6ef52921ddd09f944fbb Reviewed-on: https://gerrit.libreoffice.org/42314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxFileFormat to scoped enumNoel Grandin5-19/+19
Change-Id: Ia75c86a89c89bb22759e1d588ce603701cb7fad5 Reviewed-on: https://gerrit.libreoffice.org/42313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxCellVerJustify to scoped enumNoel Grandin19-131/+131
Change-Id: I9d1cdb4ddfee43b7a0990624d7d16e06679343c4 Reviewed-on: https://gerrit.libreoffice.org/42276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14Replace some lists by vectors (sc/filter)Julien Nabet6-51/+49
Change-Id: Id5e5702045ef597db9ad1a44f99624152128f7a9 Reviewed-on: https://gerrit.libreoffice.org/42257 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-14Add test for joining a range totally contained in an existing oneTor Lillqvist1-0/+23
It is supposed to be "swallowed". Change-Id: I6184e5ff8560e5ad0c97dce1481123b9acecfabc
2017-09-14Add debugging output operator<< for ScRangeTor Lillqvist1-0/+19
2017-09-14InsertMatrixFormula,InsertTableOp: assert valid cols/rowsEike Rathke1-0/+2
We don't check and return without operation for these, so the caller is responsible for handling bad prerequisites. Change-Id: I47bf5dc171c2362bf7096022058a51460c6e50e0
2017-09-14improve redundantcast lopluginNoel Grandin15-32/+32
to find c-style casts where the expression is a templated method Change-Id: Ifbd1e2cdc72d906fc95a7ec0f9408c3f6d2a836b Reviewed-on: https://gerrit.libreoffice.org/42275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14ofz#3362 SYLK import: check ;X;Y;C;R col/row validity earlyEike Rathke1-0/+20
Change-Id: I37d5ce67f975b6b89c4b8a9baefae2467da2eb84
2017-09-14convert SvxCellOrientation to scoped enumNoel Grandin8-74/+74
Change-Id: Ia4c75c6394b47805f24a7daca593e0074a8ddf0b Reviewed-on: https://gerrit.libreoffice.org/42268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14simplify calls to IsStreamValid/SetStreamValidNoel Grandin16-111/+65
just add a short-circuit check inside SetStreamValid, and we can simplify all of the call sites Change-Id: Ib3d19455c60fe9569faf548b1fefbc274d03574c Reviewed-on: https://gerrit.libreoffice.org/42267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14convert ScAttrArray to use std::vectorNoel Grandin11-387/+353
instead of re-implementing it ourselves. Which lead to some changes in Xf::AttrList since the import process wants to donate it's array to ScAttrArray. Change-Id: I176148131fb5f163e25691ad690f63398ba1a556 Reviewed-on: https://gerrit.libreoffice.org/42205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13tdf#107267: Fix grand total calculationJean-Sebastien Bevilacqua2-56/+99
To fix the grand total calculation, we add another step. This step loop through all row to find the min and max of each value. These min and max are then used by the grand total. Patch by Linagora Change-Id: If3200840764d0ad9cb63231ac9f67b5d5ed197f1 Reviewed-on: https://gerrit.libreoffice.org/42042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-13tdf#109096 Allow 0 as argument value(s) to GEOMEAN()Winfried Donkers2-9/+124
Both ODFF1.2 and the mathematical definition allow 0 as value(s). Excel does not allow 0 as argument value(s), but IMHO this is to be regarded as an aberration of Excel. Also added tests for no arguments or negative arguments, which is not allowed by ODFF1.2. Change-Id: I330206b6e817e0ec092fe19f713b044578da41d1 Reviewed-on: https://gerrit.libreoffice.org/42107 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-13no need to call GetNumerator() / GetDenominator() for FractionNoel Grandin7-18/+15
simplify the calculations - why have a Fraction and then just split it up for the calculation? Change-Id: I81af95e1ee1633f77e088c0990f308b1c169a6a2 Reviewed-on: https://gerrit.libreoffice.org/42242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13Fraction: make conversion operators and constructor explicitNoel Grandin1-4/+2
and simplify some of the calculations that needed to be changed. Which resulted in one unit test needing to change by one pixel, let's hope not an indication of a real problem. Change-Id: Ie56434f35f4e58d21ee6f671392e93dc7542fca3 Reviewed-on: https://gerrit.libreoffice.org/42240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13having context in strings is not enough, it should also be ~uniqueChristian Lohmaier1-8/+8
using the same context as in datastreams.ui causes duplicate (identical) strings in pot files, and some translation tools stumble over those see also tdf#109258 Change-Id: I88b083f56a45123a6cf7521ceaaefa89f77e0477
2017-09-13This return value is unused nowTamás Zolnai2-7/+5
Change-Id: I6145e9bd5736b5c48683d0a85d13ad02d66d5084 Reviewed-on: https://gerrit.libreoffice.org/42227 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-25 10:40:32 +0000