summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2017-03-24changed wording of cell merge warningAndras Timar1-1/+1
Change-Id: Ib2773d1aca6ff0ca8bfad2263b59daf1450fff6a
2017-03-15LOK: Calc: unit test for invalidation on insert imageMarco Cecchetti2-0/+68
Change-Id: Ie7c55c3a5c366618cafa51f9f1a102fb3cb26ec5 Reviewed-on: https://gerrit.libreoffice.org/32691 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-03-15LOK: Calc: invalidation on insert imageMarco Cecchetti8-4/+80
Change-Id: Ib0ec104b14385473a2a7f7dc2a33558d998996fa Reviewed-on: https://gerrit.libreoffice.org/32690 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-03-15Revert "Invalidate the entire sheet after having inserted the image."Marco Cecchetti2-51/+1
This reverts commit fe87a31885dc870a9a8e4c4dcb105a4a5627164f Change-Id: I8fb9b67696913c1de0778d22b242673c89b07813 Reviewed-on: https://gerrit.libreoffice.org/32689 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-03-08Re-introduce a check I dropped in 47b5f3a07236bb07a681e99e509c78e3af18c0b5Tor Lillqvist1-1/+2
Without fully understanding the code, best to let the condition be there. Use the same function to check for validity as before. (IsValid() which was renamed to IsValidForXml().) (cherry picked from commit a77908a2d82986ad9d2d9597536d1e22ce2cafd2) Change-Id: If50df539737352f12cb0178706cbc38512a99366
2017-03-08A 'CondFmt' record can have a maximum of three CF records following (eek)Tor Lillqvist2-6/+16
What an odd restriction. Oh well. Don't export the conditional formats for the cell(s) in that case then. See https://msdn.microsoft.com/en-us/library/03AE6098-BDC2-475B-BA2C-B8AEF7882174 Change-Id: I4eeec8d33f9fbc572a02f727f38564d6c43b4f10
2017-03-08Make sure that the 'stAuthor' field of a 'NoteSh' structure filfills the specTor Lillqvist1-1/+7
Its length must be greater than or equal to 1 and less than or equal to 54, so if the author is empty, use a single space, and otherwise truncate to max 54 characters. See https://msdn.microsoft.com/en-us/library/dd945371 Change-Id: I7604ae9e1d8eea336b42116ea7d305e183e6ca51 (cherry picked from commit 27e34a7dbb9aa2ce52ca529ec835d54c6a5508fc)
2017-03-08tdf#104729 FILESAVE Save author name in comment during export to .xlsxBartosz Kosiorek3-0/+24
Change-Id: I59d46f6a713e4f252844cda0f631ace239d73cdb Reviewed-on: https://gerrit.libreoffice.org/32115 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 36cdf3c35459df63ce137e550a6840a61865c0ca)
2017-03-08Write the 'FtNts' subrecord of 'Obj' when necessaryTor Lillqvist1-1/+20
See https://msdn.microsoft.com/en-us/library/dd952807 : nts (26 bytes): An optional FtNts structure that specifies the properties of this comment object. This field MUST exist if and only if cmo.ot is equal to 0x19. Change-Id: Ib4a007940c29a4f8eac1087601cfc7d242cfebd3 (cherry picked from commit 20a7d4b16d600101f4073ad4ce669a7566bf14c1)
2017-03-08It's SetSliceSize, not SetSliceLenTor Lillqvist1-2/+2
Change-Id: Ife4449f5afa7321c18e8eb963878d9c037f6d623 (cherry picked from commit 93a53e0ebba62873c768d887c6aa1125967aa9e4)
2017-03-08Use symbolic constants instead of hardcoded numbersTor Lillqvist1-3/+4
The constants were commented out, so uncomment them. Probably lots of the same left. Change-Id: Iac87bef3bc331ae126741efbb4d58cc539e5a42a
2017-03-08The 'fLockObj' field of an 'ObjProtect' MUST be 0x0001 says the specTor Lillqvist1-1/+2
So generate such a record only when the protection state is on. See https://msdn.microsoft.com/en-us/library/dd922139(v=office.12).aspx Change-Id: I710395527cd53dc47018806e51fcc699e11fb461 (cherry picked from commit 4a332d54b80bbc502ccc98bf924a269e00c10070)
2017-03-08The 'reserved1' bit of a 'Formula' MUST be zero according to current specTor Lillqvist1-1/+1
See https://msdn.microsoft.com/en-us/library/dd908919(v=office.12).aspx . This means we will never set the EXC_FORMULA_RECALC_ONLOAD flag, hmm? Change-Id: Ic081caa7f98426394cbc7b0b320fa1a5a9a34f6c (cherry picked from commit 727ee3f92a8882914ac3f68eaf53ac519ace5f38)
2017-03-08Set the 'unused2' bit of 'Font' to 1 iff 'uls' is greater than 0 per specTor Lillqvist1-0/+2
See https://msdn.microsoft.com/en-us/library/dd906117(v=office.12).aspx . Change-Id: I4ff278f4cdd388947bbe81b88b6c39ff2b208b1a (cherry picked from commit 970f8dc7847967719652590f71f0f19e46ba7268)
2017-03-06Resolves: tdf#105667 forget target area's caption pointer in Merge UndoEike Rathke1-1/+7
It's the same that was copied to the Undo document, so don't delete the caption. (cherry picked from commit a627c44026fcf883918f84bddd1c3b745e1f898c) Change-Id: Ib89870ed6e392c4271de2f416c78d42135922609 Reviewed-on: https://gerrit.libreoffice.org/34385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 0eda0807f9b0ba81035cf4bd630e50a27ba2678b)
2017-03-02LOK: Calc: autocomplete makes view to jump to a different placeMarco Cecchetti1-1/+5
We disable auto-complete feature as a workaround. Change-Id: I25fa7591231836e0673e97fdf2c3ca72ab20e1e4 Reviewed-on: https://gerrit.libreoffice.org/34761 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-03-01tdf#100393, handle copying one cell to multiple cols with cond formatMarkus Mohrhard1-2/+5
The same fix has been applied for rows already. Change-Id: I77300680a657fb874d07641fbae928eb6c210acd (cherry picked from commit 3a9917b66d6820ec9f2844f8292a46d8b0b9180b)
2017-03-01tdf#90943 Don't ask to move cells if they are emptyLaurent Balland-Poirier1-3/+9
During merge of cells, test of empty cells was wrong. Test of first column should not be done if there is only 1 row Change-Id: If8011f3e6d6e9006d242a8c2ef0fcb2ce12180ad Reviewed-on: https://gerrit.libreoffice.org/27354 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 0baeea95f38a5cdb19936290c69d33541274ad41)
2017-02-27Resolves: tdf#105858 check SC_DPOUT_MAXLEVELS to prevent crashEike Rathke1-44/+68
Backported. This is a combination of 2 commits. Resolves: tdf#105858 check nDataCount<SC_DPOUT_MAXLEVELS to prevent crash (cherry picked from commit 9bdf971b0202c6d55d88e61861b251459de9586b) more counts<SC_DPOUT_MAXLEVELS to check, tdf#105858 related Also for row, column and page field arrays. (cherry picked from commit 7fbdd8b7d3741d55b229977f9e6d6213af5fa542) 1dccdf139af778a2c0dc550be0b573c984256a2d Change-Id: If9084543a0a191d08da37b5b8a187bce46440871 Reviewed-on: https://gerrit.libreoffice.org/34370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit cbba64225a2abfdd8b2437e8a06925b15fb15d26)
2017-02-27tdf#98493 UI : "SCENARIO SELECTION IN NAVIGATOR (sheet group)"sll1-6/+22
Change-Id: I71071ba71ce05487273ce66e64f930cd2ec7b8d0 Reviewed-on: https://gerrit.libreoffice.org/28697 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1eebbd48fabbefaa52f5f223649c8d591915a884) Reviewed-on: https://gerrit.libreoffice.org/33953 Reviewed-by: Jean-Sébastien B. <realitix@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 95c1c7d3b085541735f964ac3c1fff9d286baa16)
2017-02-11tdf#86470: Let's not forget to move onto the next column.Kohei Yoshida1-2/+2
Change-Id: I451f521723458b5d6fe9d9fa8b41855fe17def64 Reviewed-on: https://gerrit.libreoffice.org/34159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit bcdde13996e3e33f9d4c41be25d062560c72636b)
2017-02-10tdf#95306: Be sure to specify the entire range.Kohei Yoshida1-2/+2
Especially in presence of multiple disjointed selections. Change-Id: I8e7779824109c30e69fd43a2448ae900beaf28d3 Reviewed-on: https://gerrit.libreoffice.org/34140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 6d450aad0a8f82ee0320ffc3e76eefb43c16addb)
2017-02-10tdf#103890: Fix the logic on setting 3D flag on reference.Kohei Yoshida1-6/+7
This is a backport commit that combines 3 original commits from the master branch. (cherry picked from commit bf8d4fb60da5e583b3a90639af45b901e19cb5aa) (cherry picked from commit 6e1efe7b6bd16e3183cdb7c87d786cb714a61959) (cherry picked from commit aeb465a458fc7ba02e3b1ca6b4193488defef511) Change-Id: I401d379be058cc45a5715a4a8a8f72aa56208655
2017-02-10revert tdf#98106 Preserving hidden and empty rows after xlsx exportJustin Luth2-23/+4
That patch has caused massive file bloat and and import hanging in xls and xlsx files (bug 105840). That patch was backported to 5.2.5. Just revert from the stable 5.2 branch and work on fixing 5.3 since the proper fix needs to be well tested. Since bug 98106 is just an enhancement, it is an obvious candidate for a simple revert of commit 7dd19273530730478b5ed24b79f42ac480c7ae43 Change-Id: I339694a86bab489ba0905b4d1090245bcb07fe86 Reviewed-on: https://gerrit.libreoffice.org/34104 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 3e67dc9dbbd802dd82b92304098aaa44e70c014c)
2017-02-08Resolves: tdf#104153 crash on drag and drop pivot table fieldCaolán McNamara5-36/+19
This is a combination of 2 commits. Resolves: tdf#104153 crash on drag and drop pivot table field now though sometimes it doesn't get removed at all, so a band aid for the moment (cherry picked from commit 068edb65b1dce375223d8642a01b07db3948ac03) Resolves: tdf#104153 lookup what listbox an entry is dragged from so we can find where its been dragged from in order to remove it from that source, rather than relying that it comes from the previously focused listbox Reviewed-on: https://gerrit.libreoffice.org/33575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 011bae55cdd24a1d3e42f0aa2fcfd98d3ddc9b14) e6aa1a311b46e5e9ee96cab05e0705b794b5eb0b Change-Id: I6ccbbe51fe9250af0f85c30a9d253269a18df457 Reviewed-on: https://gerrit.libreoffice.org/33633 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit a9b7c569652ba27ecda572a0cc8ad7a12143e903)
2017-02-08Resolves: tdf#105351 pass matching index key to conditional format dialogEike Rathke1-0/+1
Change-Id: I9d872140755c4ec0ae67349530b00f339057a356 (cherry picked from commit 0367acdcc59e14b0b067976a08202e8afef0ecf3) Reviewed-on: https://gerrit.libreoffice.org/33533 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit d0b841e5501881c5676e27da08fddcb5f9d4bc1a)
2017-02-08coverity#1399031 golden, Out-of-bounds readCaolán McNamara1-1/+1
There are 17 elements, so SAL_N_ELEMENTS(sppnPatterns) is 17 The largest valid index is 16, not 17, so valid max index is out by one Change-Id: Id20218a0e73cb9e502a631fa6bfbb3f0a22c4727 (cherry picked from commit 9ad08b403be9c6646cda9a379332545c3668975b) Reviewed-on: https://gerrit.libreoffice.org/33401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5e314dfb058990a78cd9e1b9045ac0f186de7003)
2017-02-08tdf#104967 prevent crash when pasting notes originating from a closed documentEike Rathke1-0/+15
This is only a workaround to prevent a crash, the actual note content is lost when pasting, only a standard empty note caption will be pasted. Change-Id: Ifaef5d30cc2024f3d03d6b2b4f56c5ccfbb67142 (cherry picked from commit cb566c056b0e8f9f73dac3cbaf497e102a247cb9) Reviewed-on: https://gerrit.libreoffice.org/33274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4d3b4a8ad12767c846b48c3a424e6bb0fa7af924)
2017-02-08Resolves: tdf#104711 adjust range reference constructed of named anchorsEike Rathke4-10/+45
A constructed range reference of named anchors (i.e. extended during expression compilation) forms a range listened at that needs to be adjusted if the cell is shifted and one or both anchor parts are individually named relative references. Currently the resulting range (ScComplexRefData aka DoubleRef) does not know to distinguish between whether its anchors are the result of a literal range in a named expression or the result of individually named anchors, so such RelName DoubleRef needs to be adjusted unconditionally when shifting or moving the formula cell. Change-Id: I75e2cc79ac60116671acce7641567337d5f5f7ed (cherry picked from commit 439b2a134218b93e6ca9fa23005b89c19498f586) Reviewed-on: https://gerrit.libreoffice.org/32924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 33c1491acb3fd6b87ac16d80ed728f423762e867)
2017-02-08handle paste special of single formula cell with error resultEike Rathke1-0/+7
This apparently was never implemented, unlike in the block pasting code that handles it fine. Formula cells with error results were always copied as is if numeric was requested, even if formulas weren't requested. Change-Id: Id550c4e757b6bb2c06aa0637328216383cdf3d6b (cherry picked from commit 12ecd30476f17c6f6efde976f8e56d604eda0f1e) Reviewed-on: https://gerrit.libreoffice.org/32744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 9fa92265bbbb95958410b4ca7d790e8e3dd27345)
2017-02-08display error constants written by 5.3+ in the for 5.2 usual way, tdf#105024Eike Rathke1-2/+17
Change-Id: I5b61ed58144ae1583d74056389478e9d5c86d2cb Reviewed-on: https://gerrit.libreoffice.org/32794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 7f3e71d2a6e34e33d04739bdf48ea3c18beef1be)
2017-02-08tdf#104981 Fix deficiencies with PERCENTRANK functions.Winfried Donkers1-2/+7
Added constraint check for significance argument. Replced inproper use of log() with log10(). Improved code efficiency a little bit. Change-Id: Ie918857e6a04ea9fcf18410f789d7252f9c1cfc8 Reviewed-on: https://gerrit.libreoffice.org/32528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit facb4e69e4c75839df89969206403d2e97146dbd) Reviewed-on: https://gerrit.libreoffice.org/32724 Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit f0241948bd5c68c50c380d9c38704da563a80ac4)
2017-02-08tdf#71435: Accessible caret-moved events are missing when "freeze" is enabledTamás Zolnai1-1/+1
Two accessible document is created when "freeze" options is enabled. meSplitPos identifies which accessible document handle which part of the window. We should handle events only in that accessible document which handles the active part. Change-Id: Ic9674344951f620546dd272beaad796de611d258 Reviewed-on: https://gerrit.libreoffice.org/32065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 06ea887f8ba34a628d7641eab210501f7bd2493d) Reviewed-on: https://gerrit.libreoffice.org/32078 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8e776ddb0a65fcf2be72166fa6da1bde6a885e91)
2017-02-08write the customWidth property also to XLSMarkus Mohrhard2-1/+2
Change-Id: I3d12e141e1cf6c70c3fbae7b6fb25a2fabeed77b (cherry picked from commit 776544f5e9b58a3fa05a9559c0fe9f678b2076c2) Reviewed-on: https://gerrit.libreoffice.org/31660 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 74da8ee082dd4a7c2073a6174589174ec42ce9b1)
2017-02-08sc: fix Android buildMiklos Vajna1-0/+11
trunc() is missing in the std namespace on the broken Android toolchain, work it around. Change-Id: I9715bce8e888a6f35d06753e40ab34ac43642acc (cherry picked from commit 10652c109e732584e43b81ecbd6f97277edb5c7b) Reviewed-on: https://gerrit.libreoffice.org/31661 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit b87da122f34245dfc573a7c0aaf1ed00051fead5)
2017-02-08tdf#91475 Fix column width during .xlsx exportBartosz Kosiorek4-23/+111
With commit 16726a1b37df8bdcae02b3c7699df814977222bd the new import algorithm was introduced. Unfortunately it looks like that some specific column width are improved, but for other widths it is worse. More information is available at: https://bugs.documentfoundation.org/show_bug.cgi?id=91475#c29 In this commit I added unit tests which prooves proper working of old algorithm and I have switched to old algorithm. Unit test which was done: 1. After resave .xlsx file, the column width values did not change 2. After export .ods to .xlsx displayed column width did not change 3. After save .xlsx to .ods displayed column width did not change This commit resolve column width after exporting to .xlsx, and correctly preserve column width for LibreOffice. Reviewed-on: https://gerrit.libreoffice.org/27943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit f2a75fecdfb5d92d27074312f29dc7dc4afb16ec) Conflicts: sc/source/filter/oox/worksheethelper.cxx Change-Id: I26d074b203d08a4bf4e9e31e52dbfd7ca7d3beb1 Reviewed-on: https://gerrit.libreoffice.org/31648 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 962b53a3a36c388d7fa9706541e3d630292861c4)
2017-02-08tdf#70565 Set correct default values to "0" of xfId attributeBartosz Kosiorek2-1/+25
When xfId is not exist during .xlsx import it must have values set to "0". It is not impacts spreadsheets created with MS Excel, as xfId attribute is always created during export to .xlsx Not setting "0" value is causing wrong .xlsx import by LibreOffice, for spreadsheets created by external applications (ex. SAP BI). Change-Id: Ia4986236d5e902d0ff6f7a7a8da8f142b2c5061f Reviewed-on: https://gerrit.libreoffice.org/28069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 9b9bcef5ef1858c63c8708bfae2ecea3d398eeb8) Reviewed-on: https://gerrit.libreoffice.org/31647 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit c88c3f66984df5ac4ca65431e7eacbeb93cb2217)
2017-02-08tdf#101135 FILESAVE .xlsx Save XML_outlineLevelRow, XML_outlineLevelCol keysBartosz Kosiorek4-4/+39
In .xlsx, the XML_outlineLevelRow and XML_outlineLevelCol keys are required for Microsoft Office365 application to properly displaying Outline values. Change-Id: If4184ddc4fbfaa409732ddb0fb4ca85b4a27b024 (cherry picked from commit ad121df71ad463bed8caf147d27f020b548f0862) Reviewed-on: https://gerrit.libreoffice.org/31644 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 517eddcbfd8dd5d6da50210a12ba917998897bbf)
2017-02-08tdf#101363 Fix precision of column width according to MS specificationBartosz Kosiorek1-3/+14
In MS specification the output value is set with double precision after delimiter, according to formula: =Truncate(({width in pixels} - 5)/{Maximum Digit Width} * 100 + 0.5)/100 Explanation of magic numbers: - 5 number - are 4 pixels of margin padding (two on each side), plus 1 pixel padding for the gridlines. It is still unknown if it should be applied during LibreOffice export - 100 number - used to limit precision to 0.01 with formula =Truncate( {value} * 100 ) / 100 - 0.5 number (0.005 to output value) - used to increase value before truncating, to avoid situation when 2.997 will be truncated to 2.99 and not to 3 Benefits of limited precision: - small .xlsx file size - slightly better performance during .xlsx import - easier to track column width changes, especially in unit tests - according to MS Excel specification Change-Id: I0537df5f9d04f5c715784c2b0c4e0d4472904dcc Reviewed-on: https://gerrit.libreoffice.org/27932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 12408dad1b2af4055b91439e3cfbe46e0df52b41) Reviewed-on: https://gerrit.libreoffice.org/31646 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8ec7c5e332c30d807a0ed0b765e44559181c91a2)
2017-02-08tdf#100946 Fix width calculation and add customWidth support (.xlsx)Bartosz Kosiorek2-0/+96
On some MS Excel version (OS X), the column "width" is not applied, if "customWidth" key (in "col") is not set to "true". It means that in case of .xlsx files, exported by LibreOffice, all columns have default width. To resolve that "customWidth" key was added during export into .xlsx file format. During development it appears that Default Column Width is wrongly calculated, and it was done not according to MS documentation. This issue was also fixed. After fix default column width is properly set. MS documentation: https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.column.aspx Change-Id: I0d1944081a5ea445d1e4284db62e9b4d504bf1c0 (cherry picked from commit 40d892a2db4d750aaf0562c63004e693c028273c) Reviewed-on: https://gerrit.libreoffice.org/31645 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 02d93c7a53f55f0416d321b3cddfb8b6fc9e6c59)
2017-02-08tdf#51524 Preserve hidden column width after saving into .xlsx and .xlsBartosz Kosiorek3-20/+97
Change-Id: I7f69a1e8f8ef46d8b0ab889df30498ec54917230 Reviewed-on: https://gerrit.libreoffice.org/27035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b0d96a82a4f6a0832d03d185f4a53db669adcc99) Reviewed-on: https://gerrit.libreoffice.org/31643 (cherry picked from commit 740f369a90a7e524bfd2f82ba9cb350c190fe282)
2017-02-08tdf#100347 Fix Outline export into XLSX formatBartosz Kosiorek4-7/+95
In previous XLSX export implementation the outline for column was not saved. Also rows without cell content was not saved if it was collapsed or outline level was set. This commit resolve all such issues Change-Id: I401f23e97f4803209fcd31c7d93baca3bd2a2385 Reviewed-on: https://gerrit.libreoffice.org/26625 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit cc503abb860c33a54a188640a5962dbdf7052284) Reviewed-on: https://gerrit.libreoffice.org/31642 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 21d340948d564c819e24edd96051c42a9ca2c78e)
2017-02-08tdf#48767 Fix orientation issue after export to .xlsxBartosz Kosiorek3-1/+21
After save to .xlsx in usePrinterDefaults was added into PageSetup. Due to bug in MS Excel, when usePrinterDefaults is present, (no matter what value), the orientation of the Page is alway "portrait". To resolve that issue, if usePrinterDefaults is set to default value, then usePrinterDefaults XML field is not added during export to .xlsx Change-Id: I3ab310babb278913bce3d66f7fae1192ed9727b9 Reviewed-on: https://gerrit.libreoffice.org/26871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 46094ff4b0ea06931f2af3fc45d00fd38c3ebf26) Reviewed-on: https://gerrit.libreoffice.org/31641 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 91328bab6f47dc9659a2124a73d88ff3d7ba4279)
2017-02-08tdf#98106 Preserving hidden and empty rows after xlsx exportBartosz Kosiorek4-8/+29
Change-Id: I1ff2bab766eadac1dd5d483453af0e760634083d Reviewed-on: https://gerrit.libreoffice.org/26421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 228c25fd17727660a3372307e3f73dbcff5e71d2) Reviewed-on: https://gerrit.libreoffice.org/31640 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 7dd19273530730478b5ed24b79f42ac480c7ae43)
2017-02-08allow to call xpath expression on different files in containerAndras Timar2-1/+22
Change-Id: I422ea6a7bf2a9a39772947707b41cfea8f7261bd
2017-02-08prevent corrupt warning in MSO - justify dimensionJustin Luth1-0/+1
In 2007, the document will not open. In 2013, it requires repair if <dimension ref=""> is not normalized. Change-Id: I5ee5ba314944c960de90f4c9b234f8cc8056c734 Reviewed-on: https://gerrit.libreoffice.org/31524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit e0781244dacda54b3f30e8ddde708b25944f1344) Reviewed-on: https://gerrit.libreoffice.org/31538 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 6546ff4786f428556643410b0a0a109e802b7b70)
2017-02-08Resolves: tdf#103994 AdjustReferenceOnMove: handle external referencesEike Rathke1-0/+14
Change-Id: I8b104b0c843dd268d8760a2a73cdd3e672e6efd6 (cherry picked from commit 4665be3af48587505bb7f49a53e8422945ec49eb) Reviewed-on: https://gerrit.libreoffice.org/30941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 5e397250c0ab2c092091c6dfe30d906a17fdca9e)
2017-02-08tdf#101042 Fix for frozen windows in ExcelBartosz Kosiorek1-1/+1
Window protection is "not allowed to move and resize windows" in MS Excel, it is definitely not Frozen Panes ( maData.mbFrozenPanes ) Change-Id: I04f0429738a6daecb26274f169c5118dba73e895 Reviewed-on: https://gerrit.libreoffice.org/30076 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 0637d0f43d3dc5b41a1bbc5726d6a68b7c36a519) Reviewed-on: https://gerrit.libreoffice.org/30777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit a6114042c590ff319e7d1877935e56e6c77bc3ee)
2017-02-08Resolves: tdf#97968 adjust references during Cut&Paste of formula groupsEike Rathke2-2/+17
... and split groups for cases where references point outside or into the moved range. Change-Id: Iab799e94eed1677f266413b6304651ac4d330e95 (cherry picked from commit dfa92e106f7eaa8c3fc6cda034001197ecc53a8f) Reviewed-on: https://gerrit.libreoffice.org/30067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 560469473f8485da4be1e9cedcb7f5399799a485)
2017-02-08Resolves: tdf#101583 references to be expanded must be at least 2 cols/rowsEike Rathke1-18/+32
... wide/tall also in named expressions. Change-Id: If0c192def74812cc9405ae633b6f83f7021344d0 (cherry picked from commit 6b9804b8f2ca85e9eb42d344d17cfee7a7a9414c) Reviewed-on: https://gerrit.libreoffice.org/30023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0230a4eccd3884ef3c3d6b7b4c6d54e5582a1268)
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 09:31:49 +0000