summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2015-02-03Related: fdo#88455 crash using delete in available fieldsCaolán McNamara2-8/+12
Change-Id: I4ac5fe6f42b425ee96124b2dde39ff397a081638 (cherry picked from commit 1746c886362b8525b04365dd6b7203b8098b99ba) Reviewed-on: https://gerrit.libreoffice.org/14290 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-02-03Resolves: rhbz#1179642 crash in GetFocus with empty mpPreviouslyFocusedListBoxCaolán McNamara1-2/+3
Change-Id: I7559067c00617482d34e7cbdd177202868cbfc76 (cherry picked from commit dae7d2089516d9cf014b9fad0adb484f19282a29) Reviewed-on: https://gerrit.libreoffice.org/14161 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-02-03Resolves: fdo#75565 reduce block on pasting rtf like we do for htmlCaolán McNamara1-1/+2
Change-Id: I74a9748a2e4981dc5d1677f06db7eceed9e4b108 (cherry picked from commit 0efbd9931ea854cf71c4c54ca3f3d55d6db1fa13) Reviewed-on: https://gerrit.libreoffice.org/14144 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit a0ef7698b7df63b8befe274305051063425f8eb6)
2015-01-27Resolves: fdo#88735 crash after calling sort after subtotal removalCaolán McNamara1-1/+1
Change-Id: Ia30271426ea47b7bf5af85d16591a02e6d52b3d9 (cherry picked from commit 0442cd217645aa4fdd924e4c2e4f90a77f1fbbad) Reviewed-on: https://gerrit.libreoffice.org/14140 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-27Resolves: tdf#81124 crash on setting autofilter on column with no contentCaolán McNamara1-1/+2
Change-Id: Id53e589789144d892427a8a4ec1af1926aa97b52 (cherry picked from commit 3a5fa612b4afb72b5f91877a5c52e25c7604ae1a) Reviewed-on: https://gerrit.libreoffice.org/14159 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-01-08avoid use of ref. to possibly deleted objectDavid Tardon1-1/+1
Change-Id: If5977b280fed8d8b053f59852d3984a59ce61a69 (cherry picked from commit ce5cc7afb0f1c99237d04e0c754527c725d8491c) Reviewed-on: https://gerrit.libreoffice.org/11832 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-08fdo#79249 call formula compiler with error stringEike Rathke3-10/+18
... instead of attempting to stringize a NaN coded error value. Regression introduced with 30a20743ae17e6e02183a65603d38968253b3ffb (cherry picked from commit 994607b55104b9ae4554554c13b001b8d5d513b6) construct grouped ScFormulaCell with bDirty=true, fdo#79249 related Noticed when loading https://bugs.freedesktop.org/attachment.cgi?id=99844 with fdo#79249 fix where oox::xls::applyCellFormulas() groups the consecutive =#N/A formulas. Only A1 result was displayed, other cells were displayed empty. (cherry picked from commit a1dc5e97da273bf35d58d54e625149022569a993) correct error string, #N/A instead of #NA (cherry picked from commit 758755e31b3d9e1ed2eab522d4794282178346ac) implement an actually working setErrorCell() from BIFF error codes (cherry picked from commit ca9a81b2ca858b82e863e1e6f917928916fea79e) 3a541f74d3d25e1515a1c6d47f02ec6a8e817c93 15019072b6e812b9ffe29d3ee6afacd9ab526948 67b8fc324779875ba14e2d69204c40fe27cc180e Reviewed-on: https://gerrit.libreoffice.org/13492 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Conflicts: sc/source/filter/oox/sheetdatabuffer.cxx Change-Id: Ia7a8ca39938820ac75db169404446fa696c6ee1b
2015-01-05valgrind: initialize theseCaolán McNamara1-3/+3
Change-Id: I6440832fe508689ffa8e20fa17827528331e3585 (cherry picked from commit 2645b1979365085edf4a94500f2c610bfc4e668b)
2015-01-04reimplement shared formula import for xlsb, fdo#86734Markus Mohrhard4-12/+30
(cherry picked from commit e1351ed4c5f9152c80b32bbaa53e3eff56671331) Change-Id: Ic5d678a2b1197ce8d83b308b0a4387bf657052d5
2014-12-30use the correct tab for sheet local names, fdo#81195Markus Mohrhard1-2/+2
Change-Id: I7e8b7ed552a37c6d9c6ce7c75765267b343d508c
2014-12-30relative refs wrap around in xls, fdo#84556Markus Mohrhard2-7/+16
Change-Id: If84d468d4bd55ed55ccd517d0b078d283a1a9c38
2014-12-29handle relative refs correctly in xls import, fdo#80091Markus Mohrhard1-2/+5
Change-Id: Ia70f96e1d31e71c56f03c828be0a4e49fff4b198
2014-12-22fix OOXML validation errorsMarkus Mohrhard1-0/+6
Change-Id: Ieac082a3b312602eff5ec101529536d747fa3836
2014-12-19resolved fdo#86809 connect filter conditions correctlyEike Rathke1-3/+10
Maybe since 0960ec3e1b7b0d872d1f84d2d56f480a4df08b21 all conditions of a single filter stack were OR connected, regardless whether filter-and was given in the file. Change-Id: Ifb423ccc7deb42bb6bba0bfc810607633f2c342c (cherry picked from commit b500e60b32b5cf8fd61beb7476c2c29e65aee3e4) Reviewed-on: https://gerrit.libreoffice.org/13450 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-18fdo#68385 update references only if cut originates from the same documentEike Rathke1-5/+10
Change-Id: Ia7b27309251cf9e47505c58d8ed0172d134280f4 (cherry picked from commit f2ac9fab2677a6a718f251baef75d3cae96d1f01)
2014-12-18fdo#79249 call formula compiler with error stringEike Rathke3-3/+8
... instead of attempting to stringize a NaN coded error value. Regression introduced with 30a20743ae17e6e02183a65603d38968253b3ffb (cherry picked from commit 994607b55104b9ae4554554c13b001b8d5d513b6) construct grouped ScFormulaCell with bDirty=true, fdo#79249 related Noticed when loading https://bugs.freedesktop.org/attachment.cgi?id=99844 with fdo#79249 fix where oox::xls::applyCellFormulas() groups the consecutive =#N/A formulas. Only A1 result was displayed, other cells were displayed empty. (cherry picked from commit a1dc5e97da273bf35d58d54e625149022569a993) correct error string, #N/A instead of #NA (cherry picked from commit 758755e31b3d9e1ed2eab522d4794282178346ac) Change-Id: Ia7a8ca39938820ac75db169404446fa696c6ee1b 3a541f74d3d25e1515a1c6d47f02ec6a8e817c93 15019072b6e812b9ffe29d3ee6afacd9ab526948
2014-12-18resolved fdo#87237 propagate error values through matrix comparisonsEike Rathke2-45/+53
Apparently introduced with 8e8b43a03e77dd251876c1de0ac06eeeb09192cd the comparison results were stored as boolean values, effectively discarding any infinite double values and error values encoded as NaN values. (cherry picked from commit 3c405ff82fcc9f8f044833420485c54658064636) Change-Id: I1fb6f46894a0bee02a37e28b7e6cc84f8c051f28
2014-12-15no separator really means no separator, fdo#83027Markus Mohrhard1-2/+1
Change-Id: I612a46701e7447db63f38ed709e8693d0533710d Reviewed-on: https://gerrit.libreoffice.org/13474 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-12-08don't update range name if ref not in update range, fdo#85304Markus Mohrhard1-0/+3
Change-Id: I1ccfacd98bd10f6ae1d4eaf7a705fe8863045697
2014-12-08we need the SdrPage for deleting the notes, fdo#86166Markus Mohrhard3-0/+11
The SdrPage that contains the shapes for the note captions is deleted before the notes. Prevent that case by deleting the notes before deleting the SdrPage. Change-Id: I13727cea7df0b033fb386a6a8e20dcadec743335
2014-12-08correct order of xml elements, related fdo#45266Markus Mohrhard1-1/+1
Change-Id: I03ea0e5bb064222e50dc08a682091ec3e23bf11d
2014-12-08remove invalid attribute that is not read anywayMarkus Mohrhard1-2/+0
Change-Id: Id7770ffda49ba7bc0ebc780c67c56b81152213f7
2014-12-03Revert "ODF export: don't write invalid "group-name" attribute"cp-4.2-20Andras Timar1-2/+1
This reverts commit 53824b05f99ac7c68e6d48b53e2bd98c0fe274c7.
2014-12-03fdo#86762 re-establish listeners to move cell broadcastersEike Rathke11-94/+219
... for UpdateReferenceOnSort=false (cherry picked from commit 6c2111f17089eb667bf526561d7667d17825e822) Conflicts: sc/source/core/data/table3.cxx fdo#86762 broadcast also empty cells after sort (cherry picked from commit 08793e08c7e9cefe594c49130f782725e386c463) Conflicts: sc/inc/column.hxx sc/source/core/data/column.cxx sc/source/core/data/document.cxx sc/source/core/data/table2.cxx sc/source/ui/docshell/dbdocfun.cxx fdo#86762 re-establish listeners on moved broadcasters ... also in SortReorderByColumn() similar to SortReorderByRow() (cherry picked from commit e119f3883513aeaa49f332362620e955dc8b453f) Conflicts: sc/source/core/data/table3.cxx e275a754c530d6039ed14304900dd71416f36e46 7665dcc90d70fcf3b08bef0adb9ab6aaff1cdcdf Change-Id: Id90288660e317d6e47ee01ee3b5ff9058cfa18df Reviewed-on: https://gerrit.libreoffice.org/13275 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-02ODF export: don't write invalid "group-name" attributeMichael Stahl1-1/+2
Radio buttons are grouped via their "form:name" attribute already. Change-Id: I9f8b27a2904d947c3d4665495d36961e3e41d2c6
2014-11-29set only valid positions from ScExtTabSettings at ScViewDataTableEike Rathke1-4/+13
Some address fields of ScExtTabSettings are initialized invalid and maybe kept invalid, on purpose, so take care of that and use only the valid fields. Change-Id: I37cbf8ff49c6ccf38bfac3e1c8c6492ac7bad61b (cherry picked from commit 8bc56801af0540c0496c1f8ddd335578a8791017) Reviewed-on: https://gerrit.libreoffice.org/13184 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-11-29test rows for validityCaolán McNamara1-0/+3
Change-Id: I501c1c18df96b5b2ad628e86cfb724a541d5c4b6 (cherry picked from commit 1e514c8da8e37fc3cb26af6ddaf95a3ed8093a41) Reviewed-on: https://gerrit.libreoffice.org/13171 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-11-28Resolves: rhbz#1165444 abrt crash with NULL pViewCaolán McNamara1-5/+2
Change-Id: I37f02f16209f274cf0358defba6bfa109948990f (cherry picked from commit 755209d88073fd497b884b8de1348ec75c2df7eb)
2014-11-26fix fdo#79441 again and keep references to other sheets during sortEike Rathke4-0/+55
... also if other references are not updated. References to other sheets are never to be treated as relative during sort, they are always absolute, even if they have relative row/column part references. Broken again during the big sort mess. Even if there was a unit test, which didn't help as it got disabled / adapted to the change.. (cherry picked from commit f0e7364603c9566bc158303c515c3274ccba62ca) Backported. Change-Id: Ic0e61c5e1cb0728e20725c29e450ab0eb55c3305 Reviewed-on: https://gerrit.libreoffice.org/13118 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-11-25fdo#86708 paint after Undo of SortEike Rathke1-0/+3
Regression of 10fc138307afb4b39baddb0d56eb8e986e5d29ea that exchanged the PostPaint with SetDirty, but the paint is also needed. Change-Id: Ic3e81fa106f405568effaed71ab33b575b4c5c5c (cherry picked from commit 5cec4ea827570a5bb0a368025f3733b841107d07)
2014-11-23added Lithuanian "LTL" to EUROCONVERT(), CONVERT()Aurimas Fišeras1-1/+2
Change-Id: Iefde129177df827c4b6508ff190f20e1e1973221 Reviewed-on: https://gerrit.libreoffice.org/11088 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org> (cherry picked from commit 21c8b5815a21b6586fe13b12d00a9fb432c2aef4) Reviewed-on: https://gerrit.libreoffice.org/12463 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-20fdo#83765 do not update references in SortReorderByColumn() if disabledEike Rathke3-10/+15
Similar to SortReorderByRow() (cherry picked from commit 115a4b7ca36f65d93070d2e81048320d202e87a3) Conflicts: sc/inc/column.hxx Change-Id: I11dd710c00a56a5f56aeb048fa2258631555a220
2014-10-29bnc#893791 XLS export: external sheet references on Linux/OSXAndras Timar3-0/+32
The commit solves two problems. 1. Make sure we save absolute paths on Linux/OSX 2. Make sure we don't save invalid XLS (VirtualPath longer than 255 chars) The first problem has always been there, so after a few load/save cycles an XLS with reference to other XLS on a Unix-like file system became invalid, and only LibreOffice could open it, Excel could not. These broken XLS files can be repaired by saving after this patch, however, the original reference will remain broken. (cherry picked from commit 3f5251675eeeeae56ea282fdeb09dbc53ce4aae6) Conflicts: sc/qa/unit/subsequent_export-test.cxx Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: I8f575acb1d560d539c1da61a1afdaac3f0c13977
2014-10-27fdo#85282: Correct adjustment of range reference on delete & shift.Kohei Yoshida1-6/+61
Change-Id: I6e01c160f77599dfa4a2e55b60e23d256184c822
2014-10-27fdo#85215: Ensure that formula broadcasting works after sort.Kohei Yoshida1-0/+15
When the reference update on sort is turned off. Change-Id: I547dd1525a638dd447fe331e22583af4a7947308 (cherry picked from commit 1eb82c78a223d9a0b2bb5c3f5c129c1ee8bdf303)
2014-10-26fdo#85215: Don't adjust references wrt cell position when disabled.Kohei Yoshida2-4/+6
Change-Id: Ie1a12cc189bcb66fad59ea9901ac0dc95bb68788 (cherry picked from commit 10fc138307afb4b39baddb0d56eb8e986e5d29ea)
2014-10-18fdo#82047: Correctly adjust references in range names on row deletion.Kohei Yoshida1-0/+47
Change-Id: Iac924b0b6932863f7f9cc088f996e0b07c340d2c (cherry picked from commit 281847613bd3ae472523822f4be9c21cc353867e)
2014-10-18fdo#80284: Avoid broadcasting during cell delete & shift.Kohei Yoshida1-5/+2
Broadcasting it here and marking formula cells dirty prevents them from being entered into the formula tree at the end. They get marked "postponed dirty" during reference update, and are supposed to be set dirty at the end. Change-Id: I65977300ee4ee26b6166d170acd2145abcbbf288 (cherry picked from commit 7fef943114b9184e69c8c714bf158116b8d9caf7)
2014-10-17fdo#81633: Add a hidden configuration option to toggle ref update on sort.Kohei Yoshida12-73/+125
This option is defaulted to off for 4.3 for back-compatibility. Reviewed-on: https://gerrit.libreoffice.org/11902 Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Conflicts: sc/inc/inputopt.hxx sc/qa/unit/ucalc.cxx sc/source/core/tool/inputopt.cxx Change-Id: I5ac686e96742df40f7d8ba5ffec23806db2988a6
2014-10-17fdo#73080: Fix the single cell reference cases as well.Kohei Yoshida1-22/+32
Conflicts: sc/source/core/tool/interpr1.cxx Change-Id: Ib9a8ae04733c5bcb982ef4d337112eb8249d0ee0
2014-10-15fdo#73080: Correctly count blank cells in COUNTBLANK.Kohei Yoshida1-2/+20
Especially when formula cells are involved. Change-Id: I40950e7108778821c17d08354f01bb157b1551e6 (cherry picked from commit 3e2bd1e4022e25b77bcc8eba5e02c1adc57008a1)
2014-10-12fdo#83901: ROW() and COLUMN() to be properly recalculated on cell move.Kohei Yoshida2-1/+7
For cases where ROW or COLUMN references another cell that has shifted. Change-Id: Ic4bef8672dab811ceff6886d9af0388306a66485 (cherry picked from commit 0b29a16d1dcffd75e49bd7ad3da867b0d0ebfa38)
2014-10-11fdo#80846: Broadcast changes before EndUndo().Kohei Yoshida1-14/+9
EndUndo() calls PostDataChanged(), which renders the recalculated formula cells. Not broadcasting before EndUndo causes some dependent formula cells to not get recalculated. This one unfortunately is not currently unit-testable as this behavior depends on the presence of ScTabViewShell.... Change-Id: I86288608b7f2627cda7c74be27a18029832775ef (cherry picked from commit 424bfaa773e58d6b609ac7f64907db4b542d1315)
2014-10-06cp#1000103: Set 3D flag when adjusting reference on cell move.Kohei Yoshida1-0/+4
This is conceptually a backport of 31abf4ce4e18cf2e94c6e598f255ae7cd8f675fa, adjusted to apply to the 4.2 code base. Change-Id: Id2979c7699e2b28cc752d527f4cb328da1529c0d
2014-10-06resolved fdo#82936 do not clear the 3D flag on refupdateEike Rathke1-1/+2
Change-Id: I2ae1368a2ffc20e988ff3ab66590a9f98902b862 (cherry picked from commit 75aad687cb5e63a41303aea568bf68b2b5f15d31)
2014-10-03fdo#53920 Switch back tab at RefButton closure timeLaurent Balland-Poirier2-3/+11
Bug occurs because visible tab is not the initial tab. So, instead of switching back to initial tab at dialog closure time (removed from cellsh2.cxx), this commit proposes that switching back to initial tab is operate when expanding the RefButton shrink dialog. Reviewed-on: https://gerrit.libreoffice.org/11660 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 31432c4469e7e0d05516143533d6b5e0b411dda3) Change-Id: I3cf7ed14054fa69881d4ecbc55c48dfbfc4356aa
2014-10-03fdo#83848 Add GetAddressConvention to RefButtonLaurent Balland-Poirier1-1/+2
Reviewed-on: https://gerrit.libreoffice.org/11578 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 2c7595a911c3b0102162c2ad9cef4a84538b66f8) Change-Id: I20d633909d3c13bf49998a6cca054ab125b6c991
2014-10-03fdo#65281 Empty/Not empty doesn't work in columns with date formatDavid Ostrovsky1-1/+4
"Empty" and "Not empty" predicates were unconditionally overriden in filter dialog for date format columns. Rectify it by preventing the overriding for these functions. Test Plan: * open calc document * define column with date format * put some data and let some columns empty * apply standard filter on date column with "Not empty" function * verify that rows with non empty columns still visible Change-Id: I2111c5a6b6350cab63173d42419069813d1137b6 Reviewed-on: https://gerrit.libreoffice.org/11613 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 551ee32dfaaddd2aa48efebaefab0730474b656d)
2014-09-23bnc#592918: Display data description in pivot table.Kohei Yoshida2-26/+35
When there are no column fields and exactly one data field. Change-Id: I10d2af7e626f98a4d8a981e078e99e7da9207d1c (cherry picked from commit 902564bfe52e7699cefc80b3334c2eb0a8cacdcf)
2014-09-23fdo#83764: Ensure that the row position is below MAXROW.Kohei Yoshida2-3/+11
When attempting to split formula groups, else multi_type_vector would try to locate a block outside its logical range. Change-Id: I424ede112138de459b5ba3bff5e021c4407ccf3d (cherry picked from commit 0ef6263ed2b31b8f9e431971e6c5e8928996c1c8)
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-14 17:53:33 +0000