summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2018-01-04lok: send modified status when applying cell-formula before savingAshod Nakashian2-0/+19
Without this, the modified status resulting from applying the cell-formula immediately before saving is lost, since it is clobbered after the save. Change-Id: Ie402812d0fc0528020161fffe57e8220c5abfeb5 Reviewed-on: https://gerrit.libreoffice.org/47368 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-12-09sc: compact ScColumnAshod Nakashian10-134/+153
Remove ScDocument* member from ScColumn and re-use the one in ScAttrArray. This saves 8 bytes and makes the code more homogenious by using GetDoc() member everywhere. Change-Id: I16a94b7ef7c45ef3af14e812b45f255f39939a6e
2017-12-06Remove unused ScColumn::mbDirtyGroupsEike Rathke3-6/+0
Change-Id: If8ed724ccec136653db5fcf43f9e74a82826add7 (cherry picked from commit 96a307be540fd609bed5b1a35dfe27d7e6652f21)
2017-12-06Drop a bunch of font metrics flagsKhaled Hosny1-1/+1
These flags mean nothing these days, there are either always true or always false, since we no longer support bitmap or Type 1 fonts. Change-Id: Ie14ca480225a6346d868a44e58e7666c3a06931d Reviewed-on: https://gerrit.libreoffice.org/31346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 74314b11a4b5a2887bd1ff19bdcfb3572b09240c)
2017-12-06vcl: rename Window::Notify to EventNotifyMichael Stahl9-22/+20
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49 (cherry picked from commit 6bb20609a2fd1d591cedc7fa2b9cabb589c346c7)
2017-12-06use o3tl::typed_flags in ConfigurationListener::ConfigurationChangedNoel Grandin6-6/+6
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e (cherry picked from commit 04a84913ead2f82510d91eea2bb8526274feeeae)
2017-12-06convert SFX_VISIBILITY constants to scoped enumNoel Grandin12-12/+23
* split the position and the flags information * remove unused DESKTOP constant Change-Id: Ibfccb44c7567e89d4527bfd36b3915a73682e6e2 (cherry picked from commit 5af0071d42e5962ed849261134ef0630c7ec3b45)
2017-12-06Use std::unique_ptr for the edit engine member of ScInputHandler.Kohei Yoshida2-128/+131
Change-Id: I46c9ac46f2b7d9f803fe5f09c3667c3feb1e65d0 Reviewed-on: https://gerrit.libreoffice.org/31139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit c3433b87985486bfe5352fda381bb9683d82b1a5)
2017-12-06Reduce the indirection count...Kohei Yoshida1-3/+7
... by getting the input handler instance directly from the view shell that owns it. Change-Id: I3b6e74285f64457d694db05d591461b291fa34c5 (cherry picked from commit d33a81c24ec0b4a05eb0b69fa85c5fd7eb8ec5a7)
2017-12-06Use std::unique_ptr for the input handler instance here.Kohei Yoshida3-12/+14
Change-Id: I73024b4d49bc99fa2110f5f0f0b80f950ad57baa Reviewed-on: https://gerrit.libreoffice.org/31137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 7fe08af6b1c579dc12da836b6bcfa2f84734328a)
2017-12-02convert DecodeMechanism to scoped enumNoel Grandin27-45/+45
(cherry picked from commit bfde4866e07746eafa2f0d6173c29d805cc35ad0) Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2017-12-02convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin3-3/+3
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade (cherry picked from commit 803215142efa6437515348f63bd70ffdcf5d45f1)
2017-11-29sc: simplify ScColContainerAshod Nakashian4-43/+23
Less clutter, no indirection and smaller memory footprint. Change-Id: Ic24272e9853a7af28df62298fd26e7edce554986 Reviewed-on: https://gerrit.libreoffice.org/45379 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-29remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin10-12/+12
Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2e8acde112e1c6754df26902e79a78346ba45a2d) Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/45452 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-28tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski6-5/+18
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c (cherry picked from commit 9e51007039770370182839846676b205f5c34c57)
2017-11-28vector::data seems more natural than &vector::frontCaolán McNamara7-15/+15
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1 (cherry picked from commit 3a74745367a73ed9351379fc32bbe9253cdae697)
2017-11-28convert BmpConversion to scoped enumNoel Grandin1-1/+1
and drop unused 4BIT_TRANS and 1BIT_MATRIX enumerators Also fix a bug in x11::convertBitmapDepth where we were incorrectly passing BmpConversion enumeratirs to ReduceColors Reviewed-on: https://gerrit.libreoffice.org/34062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b5699cd01b6a52906880c107bac6f3802ea7353d) Change-Id: I903c6866750e46ee752e10a17c05fcaaf6b11242
2017-11-28loplugin:useuniqueptr extend to check local varsNoel Grandin4-14/+7
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2489000d3fd66319a8355fd4e37cfdfda47296d0) Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625
2017-11-28convert ScChartGlue to scoped enumNoel Grandin2-21/+21
Change-Id: Ia3dd20988d26e23e94581b019ff32c9ebc8663fe Reviewed-on: https://gerrit.libreoffice.org/33753 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 256ec177f90d43862a7422f01523d22bdb2cd681)
2017-11-28new loplugin: useuniqueptr: sc part 1Noel Grandin35-163/+120
Change-Id: Ic96fd3b56b2063df0882168a7d02725d3c50515f Reviewed-on: https://gerrit.libreoffice.org/32961 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 414ede0435645a2ebf8f1476435b6ec3bb248f33)
2017-11-28new loplugin: useuniqueptr: vclNoel Grandin2-3/+3
Reviewed-on: https://gerrit.libreoffice.org/32948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e8b49f09074fe184374bee5062715357427ae044) Change-Id: Idcbc8655108ff57c06c33bbcabd652387bf3c4ec
2017-07-06handle SID_ENCRYPTIONDATA for shared password protected docs, tdf#56173Markus Mohrhard1-0/+7
Change-Id: Iadfe880b7be3186410a08568844d8812f176005d Reviewed-on: https://gerrit.libreoffice.org/39332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 669c12d59b6131f44945f166c77ae98df52ebb9e) Reviewed-on: https://gerrit.libreoffice.org/39337 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 20ca5b5fae58ee46362fbd4c5f51ee21e89c3c35)
2017-07-06always import page scaling, tdf#65848Markus Mohrhard1-1/+1
Change-Id: If5bad2336443280dd33d750b1b2749a06f2b5101 Reviewed-on: https://gerrit.libreoffice.org/39334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit fef72f9623bac7f9aa50b4f2606e6ec6282cfe1f) Reviewed-on: https://gerrit.libreoffice.org/39340 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit ae56c9862222718871b6bf098162c2b8b4c44b82)
2017-07-06Resolves: tdf#108671 mark named expression single reference #REF! if deletedEike Rathke1-0/+59
Probably broken already since commit f77c9d5b3cb65d9c2e2417f60bec1113feac50e1 Date: Mon Jul 29 14:47:07 2013 -0400 Change-Id: If90a959d000a1bf5ab0804deb22d5cfad413ea5e (cherry picked from commit 6580e171ad054dca38f55822e67a400191cecdf5) Reviewed-on: https://gerrit.libreoffice.org/39072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 777103737f9b20f680d9c9f3d0610e91383f7499)
2017-07-05sc lok: disable items of the overlay managerHenry Castro1-12/+12
They consume unnecessary CPU idle task in the tiled redenring case Change-Id: I477d17479ee83b31474675ef0d2317163d4fcee7 Reviewed-on: https://gerrit.libreoffice.org/39437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/39439 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-07-05support for saving a modified image instead of original versionMarco Cecchetti1-3/+23
Normally when you save an image through the "Save..." entry in the context menu for an image, the saved image is the original one more eventually applied filters (which are not removeable). Further applied transformations like rotation, cropping, color effects are not included in the saved image. This patch offers the user to choose if saving the original image (with filters) or the modified version through a pop-up dialog. The new feature is available in Writer, Draw and Calc. Change-Id: I4f983e3a5e8a6839fa5789a96c4d8c44477c1fd7 Reviewed-on: https://gerrit.libreoffice.org/39487 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-03pBASM can be nullptr in copy docs, e.g. during insert sheet from docMarkus Mohrhard1-0/+3
Found through http://crashreport.libreoffice.org/stats/crash_details/3bd264ba-ec12-476a-9bb4-e832caca3445 Reviewed-on: https://gerrit.libreoffice.org/39411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit caf1ddedbef77ac648d8b8b35978a0613aa77da6) Change-Id: I0a4e6dddca61a2538c0fe6bbc51770a9886c464d
2017-06-27tdf#40713: dBASE, don't lose dbt fileJulien Nabet1-0/+6
if aDbtFile corresponds exactly to aTmpFile, we just have to return Reviewed-on: https://gerrit.libreoffice.org/39189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 36d91a65ab2db0c4c81e09771f6b44e1905122a0) Change-Id: I1dde8efbe01838dc94f6025d5b81f5aee01932ac Reviewed-on: https://gerrit.libreoffice.org/39196 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit e9cb227d3fd65ea46ffb926f2babb1926e5f2133)
2017-06-27Resolves: tdf#108292 WalkAndMatchElements: really limit the matchEike Rathke1-4/+9
... to the columns queried, not just when entering an mdds node. Otherwise it would return an unexpected index, plus bailing out early spares unnecessary comparisons for the rest of a node block. Regression of commit 3fed166279377f7ad702b8911899243b8adff3bf Date: Fri Aug 16 16:29:38 2013 +0200 that started to use commit 7334f8db6f6004d48e2dbf014f27878a7ae21eb1 Date: Fri Aug 16 16:29:27 2013 +0200 with its bad implementation. Just that VLOOKUP on a matrix with a larger block of same typed data as the query *and* a match in an excess column seems to be rare.. Change-Id: Ia4ef3fd56490de82910d5aa13a84be2de851f9b0 (cherry picked from commit d3b77628efc72d857c63c8fb91d7ed2b499ac860) Reviewed-on: https://gerrit.libreoffice.org/39082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit f8f29503cc4fda0a2f3750f82ac5d7f784bdf0f6)
2017-06-26tdf#89139: pivotCache: output sharedItems children only for string fieldsMike Kaganski1-37/+65
... to avoid "corrupted" warning from Excel. In case of string fields, Excel expects the item list to be present, and containsXXX attributes of sharedItems to be absent, otherwise it shows a warning about file corruption. For numeric fields, it doesn't expect item list, othervise it also warns about file corruption. Change-Id: I5ded5b836587bed3177eb0a6b6c418e459e6be8b Reviewed-on: https://gerrit.libreoffice.org/39114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 47f0e83989c4c03d9690229b6433a5541032a3eb) Reviewed-on: https://gerrit.libreoffice.org/39257 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-06-26tdf#89139: dump pivotField itemsMike Kaganski1-5/+97
This makes the pivot table exported to XLSX refreshable (does not crash Excel on pivot table refresh). Change-Id: Icc35795cd116e091b75bb1d4a603c52ccc71c44d Reviewed-on: https://gerrit.libreoffice.org/39018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 430774c4edcdba3e6a4e383d9ac9345a517e227f) Reviewed-on: https://gerrit.libreoffice.org/39256 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-06-21Resolves: tdf#104875 defer filter detection to first load/update of externalEike Rathke2-7/+8
This is a combination of 2 commits. This could never have been meant Since commit 67b374980f340faa2695001984aaf98886a32fad executing ScDocumentLoader::GetFilterName() twice if there was no stored filter, and still executing it if there was one, even if the comment says we shouldn't. (cherry picked from commit 1bc793f8ab8f9b4ce435bd3585f9579df4a11819) Resolves: tdf#104875 defer filter detection to first load/update of external Attempting to access all linked external documents right on load time was specifically nasty for non-local URIs (unmounted smb, http, ...) (cherry picked from commit 416752b9e4bc4605c479d3eff7797be9f0ef2a38) f4a7414dfe36875b505c73b8c963b650eeffe204 Change-Id: Iaf4b88e63b3987fb661df0e9b095f06b29076894 Reviewed-on: https://gerrit.libreoffice.org/38820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 4175045ebe4c895ff4617fbcdaacbbb058751597)
2017-06-19Resolves: tdf#104989 a matrix/array formula cell needs to have dimensionsEike Rathke2-0/+8
This is a combination of 2 commits. Resolves: tdf#104989 a matrix/array formula cell needs to have dimensions Most spreadsheet functions don't need it, but some may. (cherry picked from commit 033d018a3a1d345d61f3c4dc4da693cdd4004dea) Ensure all cases push an error return, tdf#104989 related (not the cause) A formula cell in matrix context could have no dimensions.. (which is the cause but elsewhere). (cherry picked from commit e6abe9c3d06d6776e05bef93b5e6f87b403ea967) 1a04f9808d8f5c802789e3db77052351b24c24c7 Change-Id: I954acaa0a64c4dac8d15acd5b3f404019a7e0bce Reviewed-on: https://gerrit.libreoffice.org/38832 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit b85a1921585d70323c1c10ea6a7d29f1aa00ed25)
2017-06-13tdf#106423: dbase file can have no recordsJulien Nabet1-1/+2
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=4e3ff19b33c84557fd20e68960499933b4e52638 tdf#84834 sc: stricter type detection for dBASE files Log test file from tdf#84834 still opens in Writer as expected Change-Id: Ibf5a0f586e3a132455d2363e61e5cc7ea249002d Reviewed-on: https://gerrit.libreoffice.org/38660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 57ae8834c8313354477117b65d87c86407f6bf82) Reviewed-on: https://gerrit.libreoffice.org/38692 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> (cherry picked from commit d2353a5a8afa5aa0a760b0e6412c2f77aa3a6df6)
2017-06-06sc::ColRowSpan::mnEnd is inclusiveEike Rathke1-2/+2
Wrong since commit 1e721077b43de84edab2a3ed2f316ddcbec6e3ec Date: Tue Oct 7 00:22:32 2014 +0900 and commit 91502a72c12c559442e8bf77c27a516b49c2a68d Date: Thu Oct 9 14:44:27 2014 +0200 So HasAttribSelection() and HasSelectionMatrixFragment() did not query the rightmost column of each marked range from ScMarkData. Change-Id: Ie3aca26ee1b6c249c1135268dc0ad3ea053ea2b8 (cherry picked from commit 77d1e0c49adea959dd418de9b6cf9901e01be3ae) Reviewed-on: https://gerrit.libreoffice.org/38371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7821c84215be4f3e968f9a6afd8f8325992ef03c)
2017-06-06Resolves: tdf#108279 dimension rows are 32-bit and don't wrap at 64kEike Rathke1-1/+1
Change-Id: I7bf7a149fb1db526ef62bea2f52b200cf5053cc2 (cherry picked from commit 259c2409310814ae62c8d0aefef19a71e8d88dbe) Reviewed-on: https://gerrit.libreoffice.org/38331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 190c0d9ed02a5ed0659b07955b839bb16b1ba638)
2017-05-31tdf#104219 Don't export color information when color is automaticBartosz Kosiorek2-5/+13
In LibreOffice and MS Office, there are two types of colors: - Automatic (which is taken from settings) and Fixed (which is set by RGB value). OOXML is setting automatic color by default, by not providing any RGB color. To preserve automatic color we need to not export RGB color during OOXML export. Change-Id: I8895230c4fffc9d8741f3eff37e64c4823d71da8 Reviewed-on: https://gerrit.libreoffice.org/37970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/38276 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-05-30import stream on the LibreOffice side, tdf#107827Markus Mohrhard1-3/+13
This adds support for all LibreOffice content providers and non-ascii file names. Change-Id: I0a0fd0ab0c78ef039679516e7a3e880929e8f725 Reviewed-on: https://gerrit.libreoffice.org/37578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 5e9178f765b327a8aba17476d135ba3b1f881bf7) Reviewed-on: https://gerrit.libreoffice.org/37582 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b1d039c2ce986424a8a7c6e9460924291318ceb7)
2017-05-30use empty document in orcus gnumeric import, tdf#107828Markus Mohrhard3-0/+11
Change-Id: Ia7ee2de6f9b14a132a29c01f8d863889477c0a8d Reviewed-on: https://gerrit.libreoffice.org/37579 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/37659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit a45fedeb9e7ae451b3b719e7830108ee7aff03b9)
2017-05-30PushError() instead of SetError() so there's a result tokenEike Rathke1-5/+5
Change-Id: I8c2a7e01b04c26e008c8cbea9332f71d47293c75 (cherry picked from commit cd87661b4761ee9f512fc01f95d84f786c97bb66) Reviewed-on: https://gerrit.libreoffice.org/37950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit bcd3e9f29c458847df839724def86f4ebd388cdd)
2017-05-30tdf#108049 VBA exception avoided in ScVbaRange::setStyleJustin Luth1-1/+2
Change-Id: I5fc928373d70829b6e68d9000140a30f04179536 Reviewed-on: https://gerrit.libreoffice.org/37981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 4dc3e7d5e9044be66177e467d739bd8be7556783) Reviewed-on: https://gerrit.libreoffice.org/38063 (cherry picked from commit bb9c240046955c432d963610d5dd99edcc6b43e6) Reviewed-on: https://gerrit.libreoffice.org/38083 Tested-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit f82a36749a9df51d2344e4acb88f0e53b39f8e72)
2017-05-30tdf#108017 xlsb import: protection settings were reversedJustin Luth3-26/+41
Back in LO4.3, commit 5728a56b20e01d6c9e86a23f20af64a1b68ad604 fdo#70499 selectn of lock/unlocked cells with worksheet protection reversed ...reversed finalizeImport's understanding of maSheetProt.* to match xml import, but then it no longer matched the binary stream import. So, .xlsb imported the opposite of what .xlsx/.xlsm imported. Reviewed-on: https://gerrit.libreoffice.org/37952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 0d3fcbf809852aab0d0f88272bbfd2e8507d1c5e) Reviewed-on: https://gerrit.libreoffice.org/38041 Change-Id: I2da3967ef52187e4ef36ce7d01b17a4672f61e1c Reviewed-on: https://gerrit.libreoffice.org/38052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 4fbb8ad023c95266ce0882cd28bdf6703f5b67bf)
2017-05-29tdf#107389: Wrong positioning of AutoFilter buttons in tiledrendering modeTamás Zolnai1-1/+4
Must be a regression from this commit: 9113f17e65b1dafbc178fd269e2967c1e2632f0e Where the offset's and origin's meaning were changed, but not all code path was updated accordingly. Change-Id: Ib519303d5ca5ac7f13e74944e8147ea3220d7684 Reviewed-on: https://gerrit.libreoffice.org/38102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit ba5a9132375bcfedebd7c3d2500006161800da3b) Reviewed-on: https://gerrit.libreoffice.org/38107 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-29sc lok: prevent wrong assignment aEnd.Y()Henry Castro1-1/+1
In tiled rendering case, the window size is small, and the assignment aEnd.Y() will cause wrong invalidation area. However, at this time will never happen because MAXTILEDROW < MAXROW, so better to avoid in case the last row meets the condition. Conflicts: sc/source/ui/view/tabview3.cxx Reviewed-on: https://gerrit.libreoffice.org/37908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Conflicts: sc/source/ui/view/tabview3.cxx Change-Id: I9c6af57c0342f173195bb2f3d8ac5ef0f3964911 Reviewed-on: https://gerrit.libreoffice.org/37915 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-23tdf#107945: properly iterate over mtv during pivot cache loading.Kohei Yoshida16-25/+324
This reduces the total time required for populating the pivot cache by ~60%. Reviewed-on: https://gerrit.libreoffice.org/37971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit d4cd8677889ec3807c194ef5b462f8e031807e5b) Conflicts: sc/inc/document.hxx sc/source/core/data/formulacell.cxx Change-Id: I6a8511959c20231a8a5dbd0b0a9a3d0930a1fa0c
2017-05-22tdf#107920: Crash when using ScCompiler in condformatJulien Nabet1-0/+2
Just call SetGrammar from ScCompiler object with grammar of document See bt in https://bugs.documentfoundation.org/attachment.cgi?id=133382 Change-Id: Iedf4b88f2821bbcf728e4b1c023041fd6f10e5f3 Reviewed-on: https://gerrit.libreoffice.org/37739 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 63843a97262ccfa38d838a9cbbc3faadba8290a6) Reviewed-on: https://gerrit.libreoffice.org/37756 Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5756d3d5bd2175335ac302aaa806fd5f2277f564)
2017-05-22tdf#107892: fix negative values case with maxifsJulien Nabet2-2/+2
std::numeric_limits<double>::min() returns positive value for float/double so use std::numeric_limits<double>::lowest() (see http://stackoverflow.com/questions/17070351/why-does-numeric-limitsmin-return-a-negative-value-for-int-but-positive-values) Change-Id: I0afce2d38c6936aeff26923182bcafd2f0008d9e Reviewed-on: https://gerrit.libreoffice.org/37693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 20d3a60b41bda2513723c145d919f584840b1056) Reviewed-on: https://gerrit.libreoffice.org/37730 (cherry picked from commit f6d7bd1f525d3930c48b61abb2e91418f2c66ca5)
2017-05-19Respect read-only config items in Options/Calc/Calculate dialogAron Budea2-0/+19
Read-only state is now read except for settings in General Calculations (except Decimal places). Change-Id: Ia947f6657ae5638c414bf4e82fac314b5993f4c5 Reviewed-on: https://gerrit.libreoffice.org/37546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit ab34329ce2c5d6c1e340155e1b2f6d65f5fb162b) Reviewed-on: https://gerrit.libreoffice.org/37799 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-05-18sc lok: fix wrong assignment aEnd.X()Henry Castro1-2/+3
In tiled rendering case, the window size is small and the end point will be cut, then result wrong invalidation area Change-Id: Ief49c5f47bbc69485354ab396c7508db9548f82a Reviewed-on: https://gerrit.libreoffice.org/37737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/37753 Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-17sc lok: Don't crash on comment undo.Jan Holesovsky2-1/+3
Change-Id: I3b8686e2d52359de2d99413e63d4a424ba1439d1 Reviewed-on: https://gerrit.libreoffice.org/37709 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 14:03:31 +0000