summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)AuthorFilesLines
2014-11-14Handle the 'New' and 'Delete' buttonsTor Lillqvist2-0/+40
Change-Id: I1d5d6d70e9ac8d95b1189346fdab29ded39745bf
2014-11-14I don't know what I planned the 'Edit' button to do, drop itTor Lillqvist2-2/+0
Change-Id: I9944023d4cfd897acce8fd71296034ca32d8d136
2014-11-14coverity#1251589 silence Using invalid iteratorCaolán McNamara1-5/+1
Change-Id: I116294ee40eb61e8cbf308369998bd48a2f27812
2014-11-14coverity#1251587 Unchecked dynamic_castCaolán McNamara1-12/+10
Change-Id: Ibde77906333699046357bec4ff392e5e08b4a426
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava11-26/+26
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-13Blacklist has precedence over whitelist, so order them like thatTor Lillqvist1-7/+7
Change-Id: I0cf00abd582aaaaa4be4d385a6ef4f199c7aa0bc
2014-11-12addNewFromTitles : avoid broadcasting SC_HINT_AREAS_CHANGED twiceLaurent Godard1-2/+0
as it is already done in subsequent calls (in ModifyRangeNames --> SetNewRangeNames) perfchek result before : 899399452 after : 645684676 Change-Id: I29b8add457c3177e63df29f93be7a11dacde4953 Reviewed-on: https://gerrit.libreoffice.org/12302 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-11-12calc SetNewRangeNames remove useless bool typeLaurent Godard2-8/+7
Change-Id: I0c8bca04c3d0e318caacfbfa306284153305d8eb Reviewed-on: https://gerrit.libreoffice.org/12381 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-11-12Split driver version specification into a rangeTor Lillqvist2-7/+18
Change-Id: I1f26b47054e70e54ce81d3ec4cbc5ff58c1aeea3
2014-11-12Rename OpenCLImpl to OpenCLImplMatcher to better match its purposeTor Lillqvist2-11/+11
Change-Id: If9b7052385a49df1403a5f652c67ca7c103a8be2
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini13-16/+16
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11iwyu: remove unneeded includes in sc, sd, swRiccardo Magliocchetti4-11/+1
Remove only include for files where iwyu does not suggest any includes to add. Change-Id: I58f3e956485ce058750c2635db9633736708d7f0 Reviewed-on: https://gerrit.libreoffice.org/12342 Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Tested-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
2014-11-11sc: ~ScViewPaneBase() needs the SolarMutexMichael Stahl1-0/+2
Change-Id: Idbda230e8e4e48804b356e35cba3a3488cd4c55c
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin2-4/+4
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10coverity#1242526 silence Arguments in wrong orderCaolán McNamara1-2/+4
Change-Id: I6b05747772c324c6ab285082b3a6de4cadabe0aa
2014-11-10callcatcher: unused codeCaolán McNamara2-5/+0
Change-Id: I2ead5d998c3b1b3cde1222fee6f072bf09ab0021
2014-11-09SfxTabDialog ctors: take an OUStringMiklos Vajna4-6/+6
Change-Id: I91b9b2ffd19b2412ac01dd12429d6460b4c4812c
2014-11-07sc, opencl dependant code called even without FEATURE_OPENCLNorbert Thiebaud1-1/+4
Change-Id: I9629904b6b48d6b8356d6abb0c3cffe6e3fba517
2014-11-07coverity#735814 Explicit null dereferencedEike Rathke1-2/+4
Change-Id: I7c6ebe65cd8c3364b541b5545ab36a13d155a61c
2014-11-07Update the white or black list when editing an entryTor Lillqvist1-7/+14
Must be careful to re-select the logically same entry even after it actually has been removed and the edited on inserted. Change-Id: Id19f7845fadbc018affab7a6cb6b421ed9170297
2014-11-07Make it possible to actually edit existing white/black list entriesTor Lillqvist2-32/+83
Still not possible to add new ones or delete existing ones, though. And the UI for this is not finished at all. Work in progress. Also some refactoring. To increase readability, introduce typedefs in ScCalcConfig. Not sure whether nested types inside the class is a good idea or not. Change-Id: I8e1695bb0594e2cd5f8b5ce0ece075842b77762a
2014-11-07Some simplification and refactoring, no functional changeTor Lillqvist2-50/+18
Change-Id: Ie7ba158063dc0c588e114278cedb80e414ccc4cb
2014-11-07More work on OpenCL whitelist/blacklist UITor Lillqvist2-17/+74
Change-Id: I526d6652a956be3031ed46ab15eeb333d3f40a7c
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin6-7/+7
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-1/+2
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-2/+1
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06Bin unused include files, thanks to Andrea GelminiTor Lillqvist1-23/+0
Change-Id: I848505b1d4ff03779b89a08d4aeefd6ea0ff205b
2014-11-06Bin unnecessary variablesTor Lillqvist2-30/+0
Doing .ui "manually" is not *that* verbose;) Change-Id: Ide50258174e86cc94975a33c5c0e5c663ae8d77c
2014-11-06Intermediate commit: start on whitelist/blacklist of OpenCL implementationsTor Lillqvist2-4/+123
Change-Id: I5a6ef8f5e428ec4e62b3fdac8fe3e63f0ae58f1b
2014-11-06More work on the new OpenCL optionsTor Lillqvist3-8/+160
Now the new options show up in the "Detailed Calculation Settings" dialog and are saved and restored from the per-user configuration. The code that manipulates the "Detailed Calculation Settings" dialog is quite ugly with all its manual hiding and showing of widgets depending on which detail it is that is being edited. This also means that the dialog cannot be designed using Glade. But no time now to re-work this. Change-Id: I03a3a51d902084e73aab5a787b588d22ea7578f2
2014-11-05Register ParaLineSpacingPopup in sc and sdMaxim Monastirsky1-0/+2
The Sidebar Paragraph panel is used there for text boxes. Change-Id: Icff81d50c0341f02d29e36d0c3b99478a872a48f
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin16-76/+58
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04remove some unused code in scNoel Grandin4-43/+0
Change-Id: I6cd2acaf361ae1947787b5aacc86b75a6e21c379
2014-11-04Bin presumably obsolete SUNWS crackTor Lillqvist1-4/+0
Change-Id: I83038a7160251e59a2178e54859c2ab8e4bffe2e
2014-11-03fdo#84844 Use SvxColorToolBoxControl for border colorMaxim Monastirsky4-169/+4
Change-Id: Id177964ec35d6b5a08c46b8ba96615c2a4729136
2014-11-03coverity#1209103 copy-paste errorDavid Tardon1-1/+1
Change-Id: I9ed3ef809401ecf23e9c1f9bd020cf96049b56f0
2014-11-03callcatcher: update unused codeCaolán McNamara4-47/+0
Change-Id: Ida4221bfbfe30f7e1abd5c367d8cb8b9edd310bb
2014-11-03fdo#85403 broadcast changes after TextToColumnEike Rathke1-0/+1
Regression introduced with 3d869cda8db03820dea8c4ba463eb155d05e933b for fdo#74014 Change-Id: Ie8ca1e7c15609aaf80b4ecbb6ccffc30a3f79f0a
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin1-1/+1
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31i#90076: avoid double-free race condition for ScCellRangesBaseMichael Stahl1-4/+24
This is similar to fdo#72695, just with SfxBroadcaster in Calc. Solve it in a similar way, by putting a WeakReference to "this" into the UNO object so its Notify() can return if another thread is already in the dtor waiting for the SolarMutex. ==11581==ERROR: AddressSanitizer: heap-use-after-free on address 0x6170006fdb08 at pc 0x2b2c4f5b8e3e bp 0x2b2c0b2ad9f0 sp 0x2b2c0b2ad9e8 READ of size 8 at 0x6170006fdb08 thread T262 (cppu_threadpool) #0 0x2b2c4f5b8e3d in ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1448 #1 0x2b2c4f643914 in ScCellRangeObj::~ScCellRangeObj() /sc/source/ui/unoobj/cellsuno.cxx:4751 #2 0x2b2c4f697624 in ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6053 #3 0x2b2c4f69648d in ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6052 #4 0x2b2c4f69661f in non-virtual thunk to ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6053 #5 0x2b2b2c58b6af in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:204 #6 0x2b2c4f5c50ff in ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1752 #7 0x2b2c4f64de58 in ScCellRangeObj::release() /sc/source/ui/unoobj/cellsuno.cxx:4800 #8 0x2b2c4f6a2c08 in ScCellObj::release() /sc/source/ui/unoobj/cellsuno.cxx:6093 #9 0x2b2c4f6a5f0f in non-virtual thunk to ScCellObj::release() /sc/source/ui/unoobj/cellsuno.cxx:6094 #10 0x2b2c053b96fb in bridges::cpp_uno::shared::freeUnoInterfaceProxy(_uno_ExtEnvironment*, void*) /bridges/source/cpp_uno/shared/unointerfaceproxy.cxx:43 #11 0x2b2b2bae80fb in (anonymous namespace)::s_stub_defenv_revokeInterface(__va_list_tag (*) [1]) /cppu/source/uno/lbenv.cxx:383 0x6170006fdb08 is located 264 bytes inside of 728-byte region [0x6170006fda00,0x6170006fdcd8) freed by thread T264 (cppu_threadpool) here: #3 0x2b2c49c980f5 in cppu::OWeakObject::operator delete(void*) /include/cppuhelper/weak.hxx:87 #4 0x2b2c4f5b840a in ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1442 #5 0x2b2c4f5b858f in non-virtual thunk to ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1458 #6 0x2b2b2c58b6af in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:204 #7 0x2b2c4f5c50ff in ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1752 #8 0x2b2c4f5c65ff in non-virtual thunk to ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1753 #9 0x2b2c4af84583 in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference() /include/com/sun/star/uno/Reference.hxx:104 #10 0x2b2c4f5bc66f in ScCellRangesBase::Notify(SfxBroadcaster&, SfxHint const&) /sc/source/ui/unoobj/cellsuno.cxx:1570 #11 0x2b2c4f5bdf0d in non-virtual thunk to ScCellRangesBase::Notify(SfxBroadcaster&, SfxHint const&) /sc/source/ui/unoobj/cellsuno.cxx:1645 #12 0x2b2b31dda705 in SfxBroadcaster::Broadcast(SfxHint const&) /svl/source/notify/SfxBroadcaster.cxx:41 #13 0x2b2c4b03f2e4 in ScDocument::InsertTab(short, rtl::OUString const&, bool, bool) /sc/source/core/data/document.cxx:510 #14 0x2b2c4e7ed861 in ScDocFunc::InsertTable(short, rtl::OUString const&, bool, bool) /sc/source/ui/docshell/docfunc.cxx:3007 #15 0x2b2c50b1f415 in ScViewFunc::InsertTable(rtl::OUString const&, short, bool) /sc/source/ui/view/viewfun2.cxx:1855 #16 0x2b2c502e075f in ScDBFunc::ShowDataPilotSourceData(ScDPObject&, com::sun::star::uno::Sequence<com::sun::star::sheet::DataPilotFieldFilter> const&) /sc/source/ui/view/dbfunc3.cxx:2056 #17 0x2b2c4fa8924d in ScDataPilotTableObj::insertDrillDownSheet(com::sun::star::table::CellAddress const&) /sc/source/ui/unoobj/dapiuno.cxx:1286 Change-Id: I4cd0fca46b9b81311bddfab2229ab9abf4c06c4e
2014-10-31Removed duplicated includesAndrea Gelmini1-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31coverity#735320 Unchecked return valueEike Rathke1-1/+2
assert if fouled Change-Id: I1bc38690c755b8bc6eab16c8aa33c8f568e0c854
2014-10-31coverity#735811 Dereference after null checkEike Rathke1-1/+1
We always have a DB collection. Change-Id: I8933be3a01b4c2e63b852361d5d2438e6fca4d05
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin3-5/+5
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin2-3/+1
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29coverity#1242433 SdrMakeOutliner alway derefs pModCaolán McNamara1-1/+1
so change from a pointer to a reference Change-Id: I81eb2c9e4df8353fbbdad7058c6ca7ea22286e62
2014-10-28coverity#704001 silence Unchecked return valueCaolán McNamara1-1/+1
that's definitely ok, it returns if its an advanced query, and we don't care as we're going to force it to be anyway Change-Id: I5c5fec3f0978bc7f66db0b746dd69b60dc4c9026
2014-10-28cid#738785 Uninitialized pointer fieldStephan Bergmann1-10/+10
Change-Id: I2256682639084c8889d1137f087e34f7b0dab6e7
2014-10-28coverity#1233509 Uncaught exceptionCaolán McNamara1-1/+24
Change-Id: I09087bb872446d426e3556a64745d3faad254f9b
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 15:33:40 +0000