summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)AuthorFilesLines
2018-05-29tdf#115582 Correct coordinate usage for sc's ::ArrayArmin Le Grand1-6/+15
In ScOutputData::SetCellRotations() eventually existing CellRotations are added to the svx::frame::Array data that gets created for repaint. This used the wrong coordinate calculation, thus in some cases the repaint of rotated Cells failed. Change-Id: Ib5df8576e8c9404d717d5dcc5662aa04b82cf959 Reviewed-on: https://gerrit.libreoffice.org/53171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit 0185e65bcd73dbad2205a39369e1e06b33a2ca51) Reviewed-on: https://gerrit.libreoffice.org/54922
2018-05-18Resolves: tdf#117093 sanitize the active grid window valueEike Rathke2-13/+33
Don't know yet how that could had happened, but the sample document has a bad ActiveSplitRange value that doesn't match HorizontalSplitMode and VerticalSplitMode. * sanitize the value when reading view settings * prevent writing such value to help versions that don't sanitize Change-Id: I1b450c7b8102148a24d545ff7568f725d7492a6a (cherry picked from commit 646e9564007b13bd841d28e7c02c060d2f96fb39) Reviewed-on: https://gerrit.libreoffice.org/54504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-08Resolves: tdf#117005 undo/redo skips comment when switching sheetsCaolán McNamara1-1/+2
while insert comment is active regression from.... commit 80509950d35cebaede89fcb52c446a1fd3e45ba3 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Jul 4 15:31:29 2016 +0100 Resolves: tdf#100761 after insert note, focus cannot return to inputbar which is a suspected regression from. commit 11d605cc5a0c221d2423b6e63f502db660d085d2 Date: Mon Feb 1 18:39:51 2016 +0200 tdf#84843 Stop using PseudoSlots for drawing slots Change-Id: Id4614624cbb85411ba0d368ae072a05f5f9e09ad Reviewed-on: https://gerrit.libreoffice.org/53799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-04tdf#117017 Make modifier keys not trigger the InputChanged handlerMaxim Monastirsky3-2/+21
(cherry picked from commit a860c94f0da22065074cc36e8ddda73261641533) sc: Fix menubar auto-accelerator behavior under gtk2 ... when the focus is in the input field of the formula bar. Regression of commit d90dcf3554a84b5600800ee6deb3cde879c62b8d ("tdf#113894 release ctrl of ctrl+v in input line should strip formatting"). (cherry picked from commit baddcc38dee7b286cc73c1eaeb6f78d10b911a8e) tdf#117017 Pasting into the formula bar shouldn't retain formatting This is (kind of) regression from the previous commit a860c94f0da22065074cc36e8ddda73261641533 ("tdf#117017 Make modifier keys not trigger the InputChanged handler"). Reset of formatting when pasting into the formula bar via a keyboard shortcut, was actually a side effect of the gtk auto-accelerator work. In particual, bibisect (of the 5.2 cycle) points to commit 8d53d01f38b856f177aca3ed4d3cba3db10f24a5 ("tdf#96739: Send Ctrl-Left/ RightShift events to correct window"). The behavior was later changed back with commit 0321dbb9be72f92c02919457cdc3c4e76cfbd11d ("Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with alt"), but introduced again upon request of tdf#113894, with commit d90dcf3554a84b5600800ee6deb3cde879c62b8d ("tdf#113894 release ctrl of ctrl+v in input line should strip formatting"). Now it's broken again with the previous commit of this bug. However, even if not retaining formatting is the desired behavior, triggering it on a modifier key release isn't a good idea. So keep the previous commit, and implement tdf#113894 differently. In addition, make sure to get identical behavior regardless of the pasting method, be it via a keyboard shortcut, a toolbar button or a menu/context menu command. And users can still override this behavior with the usual paste special dialog, or the toolbar dropdown. (cherry picked from commit 632bc11ce8fab1c4046ab24810b90a7ce9ac5914) Change-Id: Ib05883688ef4143c0b53871c4336920dde6f91cc Reviewed-on: https://gerrit.libreoffice.org/53144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-24tdf#116821 Keep row/column buttons enabled even when insert impossibleMaxim Monastirsky2-4/+0
So other commands included in these buttons (like delete or set height/ width), could still be used. Change-Id: If9e96116aebf73b2d20fb8d63ee67da3d17e3d9f Reviewed-on: https://gerrit.libreoffice.org/52909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 3732d5ab1782bbadfee457115fbd8dce78453cc2) Reviewed-on: https://gerrit.libreoffice.org/53286 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-13Related: tdf#100925 background not getting set under X sometimesCaolán McNamara1-1/+6
not sure why this is the case, but it is reminiscent of rhbz#1283420 which results in missing glyphs in some circumstances X11CairoTextRender::getCairoContext has a hack in it for that problem, whic forces a read from the underlying X Drawable before writing to it which seems to have the effect of syncing it up. So, just before drawing the bg, draw a glyph on it to get it synced, and then overwrite it. Change-Id: I2ffff7e8e989b91821869d8b75a59728ac513d1b Reviewed-on: https://gerrit.libreoffice.org/52818 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-04-13Resolves: tdf#116813 Height/Width swappedCaolán McNamara1-2/+2
Change-Id: I9b41a4b65fda895ed73fa346fb0b8e13df010706 Reviewed-on: https://gerrit.libreoffice.org/52693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-04-04tdf#112997 multiple animated gif only one frameNoel Grandin1-1/+1
Not sure what the problem is, but using a vector and just making sure we insert into the right spot for the sorting fixes it. Change-Id: I11c08e08a14c98ba7eb6a5d925c75bab891ecf63 Reviewed-on: https://gerrit.libreoffice.org/51829 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d312ff2b52c0ea2e2864518a36f6b432653c8297) Reviewed-on: https://gerrit.libreoffice.org/52009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-27ofz#7121 NamedDBs::insert takes ownership of its argumentEike Rathke1-1/+0
at one point this was based on std::auto_ptr and didn't free its arg on failure Adapt description to reality Change-Id: I24133fb6c52bd7500037364120cb11d1b1f099c2 (cherry picked from commit f161cdc979587488df83e63002bee7ee15152d42) Change-Id: I8aeed6876d80b7ebe4ebb5e2cfd12e00420bd207 Reviewed-on: https://gerrit.libreoffice.org/51933 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-21Resolves: tdf#116215 separate column sums and row sums, tdf#71339 relatedEike Rathke1-7/+16
Change-Id: Ifc7ab0c460f521ad3be4aa2785d54a1e4ed304e5 (cherry picked from commit 9d8dcec608dde63c68b34450a95a3b168121e289) Reviewed-on: https://gerrit.libreoffice.org/50845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-03-16Resolves: tdf#115923 try a different approach to solving tdf#46637Caolán McNamara1-5/+20
Try scrolling to the cell the mouse is over if its not fully visible already and this is not autofill selection. To avoid the mouse over the autofill handle which overflows into neighbours scrolling the neighbour cell into view before its truly desired to be selected when the mouse passes the center point in other words, for autofill go back to how it always was Change-Id: I6f67ad0f49c2d4087949f71f38322f06ced13c79 Reviewed-on: https://gerrit.libreoffice.org/51392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-15Resolves: tdf#54197 update input line with new cell content after Ctrl+D fillEike Rathke1-0/+26
This is a combination of 3 commits. Resolves: tdf#54197 update input line with new cell content after Ctrl+D fill ... and invalidate cell slots. Related: tdf#115297 copy AutoSpellData from row above if no selection Related: tdf#54197 copy AutoSpellData from adjacent if no selection 62ebb3579d5c05e71ca10879ae0ade5bda3bbeba 82223a64f5c5ec3c98dba390d88af8369a322bd7 Change-Id: Icbe7784430f7ddeed8fa0bc56352269447ee8cbb Reviewed-on: https://gerrit.libreoffice.org/50608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-13forcepoint #26 check input against max valid enum valuesCaolán McNamara2-8/+8
Change-Id: Ide72884c77904ae9495b5189cde086e43923e4bd Reviewed-on: https://gerrit.libreoffice.org/51137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13tdf#103175: Initialize DrawLayer if requiredMike Kaganski1-2/+3
Change-Id: Ia99dd1e349e807d339dce0ead518a72a31e0fc02 Reviewed-on: https://gerrit.libreoffice.org/51096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit de53d4690d25b9f1bbc0def6c66ce5b45b2fdc96) Reviewed-on: https://gerrit.libreoffice.org/51110 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-03-07Resolves: tdf#113805 insert special character fails in insert footnote...Caolán McNamara3-3/+3
etc. dialogs i.e. since commit 710a39414569995bd5a8631a948c939dc73bcef9 Date: Thu May 11 13:27:38 2017 +0530 GSoC: Glyph View and Recent Characters Control in Special Characters dialog Change-Id: Ia55f3fefe7c14327cff2e996ab0038dc52f9b017 it inserts into the document, extend the fix of commit 4020945651b4f3c636980e2103db440b5c55459c Author: Daniel <danielfaleirosilva@gmail.com> Date: Sun Sep 24 17:55:19 2017 -0300 tdf#111739 fix Selecting a custom character as a bullet symbol insertion to do the old thing that existing code depends on if this is not an "insert" dialog, and bubble that setting around from the callers Change-Id: Id8acf16955d0167beffae43e3b201e500ee7a929 Reviewed-on: https://gerrit.libreoffice.org/50781 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/50799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-06tdf#116171: Tunnel arbitrary rtl_TextEncoding from sc to sdbc:dbase connectionStephan Bergmann1-22/+5
...including those that have no corresponding textual IANA character set name representation, like RTL_TEXTENCODING_MS_950 which is apparently used in some DBase files. In the past, if eCharSet was RTL_TEXTENCODING_DONTKNOW in lcl_getDBaseConnection it was sent as an empty string CharSet property, which the receiving OConnection::construct translated back to else m_nTextEncoding = RTL_TEXTENCODING_DONTKNOW; so the net effect remains the same for that special case. Change-Id: I84eec8a93d000752b3c429976c58721ea9ea32a4 Reviewed-on: https://gerrit.libreoffice.org/50772 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 5ad62544bce42396faaae2bc79c7517af6ff085b) Reviewed-on: https://gerrit.libreoffice.org/50780 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-02-21Resolves: tdf#115710 let css::sheet::FunctionAccess execute WEBSERVICEEike Rathke1-1/+1
... independent of a LinkManager that is not present in the interim FunctionAccess document. FunctionAccess is executed by extensions, Add-Ons and macros that the user gave permission already. Change-Id: I9349a59ee24089c3657de7786b49e5e81946f175 (cherry picked from commit 121fda77b0cc16d54607a1f5f7b26c0f1050284f) Reviewed-on: https://gerrit.libreoffice.org/50019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-16Resolves: tdf#115046 don't restore a sheet-local DBData from temporaryEike Rathke1-3/+18
And don't clear AutoFilter button flags in the new temporary range. Change-Id: I273de1e04632ac99c267523b2843665d257fd361 (cherry picked from commit 74d30155c5067271fb98bacbcb895c215e61678d) Reviewed-on: https://gerrit.libreoffice.org/49809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-16ofz#6311 still problems with SdrEdgeObj listening to same obj at start as endCaolán McNamara5-9/+9
Change-Id: Ibd80b484788779b73943b28a5f36e51ebcacec30 Reviewed-on: https://gerrit.libreoffice.org/49824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-15tdf#115483 svl xmloff sc sw: verify all ODF 1.2 protection-key hashesMichael Stahl1-0/+4
ODF 1.2 has added some mandatory requirements for protection-key hashes which did not exist in ODF 1.1. This affects sections and indexes in ODT documents, as well as spreadsheets and sheets in ODS documents. 1. Accept the following hashed passwords: * UTF16 LE/BE encoded StarOffice-SHA1, OOo legacy and allowed by ODF 1.1 * UTF8 encoded proper SHA1, as required by ODF 1.2 * UTF8 encoded SHA256, as required by ODF 1.2 - specified either with the wrong URL used in the ODF 1.2 spec or the correct URL from the W3C spec, see OFFICE-3702 * Excel+SHA1 double-hash, only in Calc, see OFFICE-2112 2. Round-trip any of the above as-is * for SHA256 only write the URL from the ODF 1.2 spec 3. Generate only UTF16 LE encoded SHA1 for now, so that older LO releases can still verify the password * some time in the future, switch to generating some valid ODF 1.2 hash More changes are necessary in Calc, which can actually preserve different hashes for the same passwords in its runtime data model, whereas Writer just has a single buffer without even any metadata. For the Calc unit tests we need one document per hash because the protection-key attribute can be set on the entire spreadsheet, which is an unique element in the document. There are further uses of SvlPasswordHelper for change-tracking passwords, but apparently those are stored in settings.xml, so ODF has no requirements for them, so let's leave that as it is. Reviewed-on: https://gerrit.libreoffice.org/49352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 398275ba9f4d65bebcc78864e70eee6212a84397) Change-Id: Icb720b14ae9c0d9c04d2e082769ae2b74e3af8aa Reviewed-on: https://gerrit.libreoffice.org/49390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-02-14it does not make sense to check for nullptr and then access anywayMarkus Mohrhard1-3/+5
Seems to be related to the crashreports with the signatures: http://crashreport.libreoffice.org/stats/signature/ScTabViewShell::~ScTabViewShell() http://crashreport.libreoffice.org/stats/signature/ScInputHandler::EnterHandler(ScEnterMode) Change-Id: Iff22db3988687a52a7596f01facd5bdd12ce4140 Reviewed-on: https://gerrit.libreoffice.org/49694 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 2fd7c18f42710bdaaf3262f4be9f1a706b33d38d) Reviewed-on: https://gerrit.libreoffice.org/49700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-13CheckLinkFormulaNeedingCheck() for .slk importEike Rathke1-0/+1
Change-Id: I79953cf4fd6e9e00351a3b1f1687b6024085e395 (cherry picked from commit 664c2902a6672be51c4a3163a5bf44aa2145d408) Reviewed-on: https://gerrit.libreoffice.org/49610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-12tdf#72440 Abs sheet ref must be givenLaurent BP1-1/+2
When resolving tdf#90799, sheet ref was forced abs But its value must be changed. It worked only if initial sheet = Sheet1 Change-Id: I715f93dce93beb78d767e00dd45fb9634cb173a8 Reviewed-on: https://gerrit.libreoffice.org/49548 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit d69017c8a17be21657ea7ab9d37023ee59116799) Reviewed-on: https://gerrit.libreoffice.org/49608
2018-02-09CheckLinkFormulaNeedingCheck() for .csv importEike Rathke1-0/+11
Change-Id: I89be713531436f10b38d38f9e0fa527db1e036cd (cherry picked from commit c7dd72b2bd6a7988e4e1074e9a85222b53ba84ac) Reviewed-on: https://gerrit.libreoffice.org/49498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-30fix tdf#114934 borderline feature regressionsArmin Le Grand4-8/+10
squashing some master commits, fixes the following bugs: - tdf#114934 which contains: - tdf#115169: Calc: Rotated Cells not shown rotated when using Print/PDF/PrintPreview - tdf#113751: Borders for Merged Cells are Partially Shown - tdf#114625: Calc can not print right border of merged cells from LO 6.0 - tdf#114824: Export to PDF and Printing: Borders of Merged Cells Flow to Page Footer BorderlineFix: Need to redesign Borderline paint for Calc To fix some errors, need to change svx::frame::Array conversion to Primitives, especially regarding handling of merged cells. These make problems in the currtent form where the full extended merged cell tries to be converted. This is bad for cropped stuff and also wrong for double-line stuff attaching to a merged cell. The solution is to handle cells single and merge created primitives which is more expensive but will work. This will involve special handling for X-Ed (crossed) and 'roated' Cells. Also need to be very careful since all this is used in the meantime for all visualizations of Tables in multiple apps/situations. Change-Id: If0652a3ba97a6f27dd5d782ea22b1514303f3710 BorderlineFix: Corrected missing borders in print In Print/PDF/PrintPreview border lines were missing, this happened for merged cells. It has to do with access to the involved Styles and/or 'Clip' set (to avoid creating everything). Thus a 'mixed' usage of cell and merged-cell stuff was needed. As it turns out support for this is already there, need to use it. Change-Id: Ic16085b97eef5c79a4501279432f43491bca350e BorderlineFix: Avoid BorderLines to be too prolonged For MergedCells there was an effect that the BorderLines were painted too far in PrintPreview/Print/PDF visualization, found reason and changed. Checked (hopefully) all usages, looks good. Change-Id: I0acf8dcb20548a98533f3ab317ac72c0d0f0a947 BorderlineFix: Corrected handling for 'rotated' CellBorders CellBorders can be rotated (including their Text) and need special visualization that is based on an own sheared/rotated coordinate system. Currently only possible for single cells (not merged ones) and needs to handle all borders (also bottom-right directly in the rotated cell, not in the neighboured ones to have the geometry, plus avoiding these in the non-rotated neighbour cells. Also corrected adding CellRotation data to svx::frame::Array in calc using SetCellRotations() which now gets called in the ScOutputData constructor to ensure it gets called in all places where it is used. Change-Id: I47bdfc29ba5ca76bbc07d98cb64733f867b1ee20 BorderlineFix: Fixed visual updates when scrolling For Cells with DoubleLine the connections to perpendicular DoubleLine-Styles may have to be displayed in a Cell which is 'around' the orig cell in a Cell-Border of one. To represent that and to avoid repaint errors when scrolling in, the preparation of Primitives has to take accordingly more neighbour cells into account. Tested this change with the usages in Calc, UI (Dialogs) and Calc exports Print/PrintPreview/PDF. This does not affect Tables in Writer and/or Draw/Impress. Change-Id: I3bcc68cdf7b4fc1825a87a9773892c359421024e BorderlineFix: Fix WriterPaint if scrolling CellTableBorders Similar to CalcBorders in Writer the overlap regions for FrameBorders have to be taken into account when repainting the CellBordes of WriterTables Change-Id: I488ba158e1de579bfb06b9c8353adaa2cac706c6 BorderlineFix: Corrected Draw/Impress TableStyle accesses In Draw/Impress the indices for accessing the correct neighbouring TableStyles were wrong and thus created wrong visualizations, corrected that. Change-Id: Iebc5f294adb62fa4c6358e2f8c27d29cc3163fbc BorderlineFix: Use svx::frame::Array tooling in Draw/Impress For creating the needed BorderPrimitives for TableCells for the Tables used in Draw/Impress, adapt the ViewContactOfTableObj doing this to use svx::frame::Array tooling now. This will correct the error for not taking the neighboured connects for merged cells into account and unify one more space to the same tooling. Change-Id: I2e6f732985e9b963359f156628bd29ddfec1a80c BorderlineFix: Corrected wrong indexing in Array initialization Change-Id: I4222ef1c82620a05cea9f6db1a0664196cfb3bd4 Reviewed-on: https://gerrit.libreoffice.org/48891 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-30tdf#115044: do not load external documents if it is not allowedVasily Melenchuk1-0/+9
Referenced external document data can be loaded after user permission from dialog or corresponding settings. Change-Id: If3aec37c8bbdee4aebeb99c7807e87c26df8e592 Reviewed-on: https://gerrit.libreoffice.org/48398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8b98991a66197a71953dbb900dc3aece6b4f9e3a) Reviewed-on: https://gerrit.libreoffice.org/48869 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25tdf#114519 Update cell content on sidebar number format changeJim Raykowski1-0/+1
In Calc, when the cursor is flashing in a cell (input mode) and the sidebar Number Format panel 'Select a category of contents' drop down selection is changed the cell contents does not update on selection change. This patch ends cell input mode on 'Select a category of contents' drop down change allowing cell to be updated to the selected number format. Change-Id: Ia1f46499ada2cfbcc82bd5babb6cf56ae0d6259c Reviewed-on: https://gerrit.libreoffice.org/46883 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 7416c2ea6c25ec1ff60ce1055b79b216cd501140) Reviewed-on: https://gerrit.libreoffice.org/48632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-16handle ocWebservice similarly to ocDdeCaolán McNamara3-7/+17
might have too much in here seeing as we don't need to worry about ocWebservice calling into itself Change-Id: I0145f38cc1c1f9ff514a496f7101d81cde9e7c67 Reviewed-on: https://gerrit.libreoffice.org/47816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-16Better handle ScDde formulas with missing dde-link entriesCaolán McNamara2-1/+3
typically each ScDde formula has a matching table:dde-link which results in a ScDdeLink getting inserted during the load. If that dde-link is missing then no ScDdeLink exists and ScDde() will create a new one without cached content. So detect that ScDde is used in the freshing loaded ods and defer fetching new content until the right time. only call GetHasMacroFunc to set SetHasMacroFunc and bHasMacroFunc is not accessed any other way, so this is an oxbow Change-Id: I016b53288076d83dd49e92e245346a5f7f560522 Reviewed-on: https://gerrit.libreoffice.org/47757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b0597ba5d745974fce752e1b677451a19350d351) Reviewed-on: https://gerrit.libreoffice.org/47815 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-16tdf#114992: fix crash in deleting sheetJulien Nabet1-1/+1
See bt: https://bugs.documentfoundation.org/attachment.cgi?id=139087 Change-Id: Iee72385a8e5400436da72fe5e18b8cdfccad193d Reviewed-on: https://gerrit.libreoffice.org/47850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 1d71f886d6760e5b3eeb4a0f9aaaead0816a45aa) Reviewed-on: https://gerrit.libreoffice.org/47859 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-16shapes provide their name through the container::XNamed interface, tdf#114932Markus Mohrhard1-3/+3
This is actually a problem introduced by 1c80246e5ff8aeb3e05384d86766a56aa878c7be and not by 5ee141ee2fb77c3cc452ac656235d7e83e15072c as mentioned in the bug report. Change-Id: I5f4032c13cf5eac3e515ada10b9bfa87598da438 Reviewed-on: https://gerrit.libreoffice.org/47841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit cfa0b631d00f1c17d15646ddcf78093b7f4df03b) Reviewed-on: https://gerrit.libreoffice.org/47843 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-12VclPtr, missing disposeCaolán McNamara1-1/+1
Change-Id: I790cd8be0d461d4c82c9b1c64e334bd37115dcaf Reviewed-on: https://gerrit.libreoffice.org/47802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-12Add back initialization of ScNavigatorSettings::maExpandedVecStephan Bergmann1-0/+1
...lost with 2ea92be9973e6892727eae37ae958863702b3658 "convert SC_CONVERT constants to scoped enum". And indeed, e.g., opening the document from <https://bugs.documentfoundation.org/show_bug.cgi?id=114932#c2> through steps 1 and 2 in a UBSan build reports a use of an uninitialized (bad-valued) bool in ScNavigatorSettings::IsExpanded. Change-Id: If0dfadc6bd8033e61e334f59b3028ab005a892cd Reviewed-on: https://gerrit.libreoffice.org/47767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit fbec01b7af438fc7409c875e59be7483772b53a2) Reviewed-on: https://gerrit.libreoffice.org/47785 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-07tdf#113980 Refresh row/column buttons state after selection changeMaxim Monastirsky1-0/+2
Change-Id: I21684ffe83d7b924e1d83c853ed4846e0db53c3b Reviewed-on: https://gerrit.libreoffice.org/45614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 4b65a67caacee1ef0b31219d55bfe0cc6032c9f3) Reviewed-on: https://gerrit.libreoffice.org/47026 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-22Add UI config option to enable/disable threading.Dennis Francis2-0/+15
Clarify that this is experimental. Change-Id: I7a83d80c0db233a48026d1254021b926f28002f3 Reviewed-on: https://gerrit.libreoffice.org/46782 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/46937 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-20tdf#114545 Enabling/Disabling Ok button depending on correct formattagezi1-0/+6
Change-Id: Iab3c4363dda0260d16c7167946044c39c21b863a Reviewed-on: https://gerrit.libreoffice.org/46790 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 7504af39686171ffb16e70f798d9ecf4ea98f1d3) Reviewed-on: https://gerrit.libreoffice.org/46823 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-12-19Uncheck Engineering notation checkbox on Scientific selectionJim Raykowski1-0/+1
In Calc, the Engineering notation checkbox in the Sidebar Properties deck Number Format panel can show checked when the cell number format does not contain engineering notation. Change-Id: Ia26fc430aecd7af2e0f614bf9314d99f8408e690 Reviewed-on: https://gerrit.libreoffice.org/46650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 9e7caee0173c5ec2d8b5cfa6aedfd1c9674d442b) Reviewed-on: https://gerrit.libreoffice.org/46826
2017-12-18clear the data provider cache after import, tdf#111960Markus Mohrhard1-0/+5
This might also fix some problems with normal ODS files and not just with FODS files when we recompile formulas after the whole import. Change-Id: Iec05d2052ca5ce3bdf03abf02d502e4537fd3082 Reviewed-on: https://gerrit.libreoffice.org/46672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit f9d8fe959d88011d63fc047a8cc00ded1dd2fda1) Reviewed-on: https://gerrit.libreoffice.org/46689
2017-12-15tdf#114216 Uncheck Thousands separator on Number category selectionJim Raykowski1-0/+1
Change-Id: Iaf616379fad1333d63bc397a9fba2220d7bbfc9b Reviewed-on: https://gerrit.libreoffice.org/46072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit eee645a4c281a99247fa7ae6e34711283156c614) Reviewed-on: https://gerrit.libreoffice.org/46540
2017-12-09A "standard" format does not necessarily mean the General formatEike Rathke1-4/+2
Actually there can be up to three and most times are at least two (short,medium[,long]) of which usually the medium default is General. Change-Id: Iab853fbaa2db3dca488ee40f63271ccd55b6b517 (cherry picked from commit 4d850442a04b63e4ed92dcd431c8620ce12010c2) Reviewed-on: https://gerrit.libreoffice.org/46128 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-09lok: calc: fix: CTRL+RIGHT => crashMarco Cecchetti1-1/+2
Change-Id: I5c127aa4cbdca5e13d2329c1fb68f466464fe432 Reviewed-on: https://gerrit.libreoffice.org/45799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-08Fix segfault when ScDBDocFunc::AddDBRange is called ...Jens Carl1-1/+0
multiple time with same name. ScDBCollection::NamedDBs::insert() use an unique_ptr to hold ScDBData* and if the insert isn't a success we don't have clean up with delete. Change-Id: I9b24834ea2e2dfd67b07438e6c4789ad0c01b888 Reviewed-on: https://gerrit.libreoffice.org/46075 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit d51e7581d90d55b5fe9a0f175d3cbee32de51721) Reviewed-on: https://gerrit.libreoffice.org/46091
2017-12-08Key must be sal_uInt32 instead of sal_Int16 SCCOL, tdf#113861 follow-upEike Rathke1-2/+2
FormulaTokenMapMap key is bit masked left shifted tab value plus column value. And as FormulaTokenMap key was changed from sal_uInt32 to SCROW (which is correct), use that type when assigning. Change-Id: I4c76330378e64cb7dc06a956cbf2c23f4428b658 (cherry picked from commit 78a3f7e10e650bc464202dacd131f9c3b0ddfcdf) Reviewed-on: https://gerrit.libreoffice.org/46061 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-08assert on export of fdo69698-1.ods to pdfCaolán McNamara1-7/+13
since... commit 3af8a4faf5e20ccae2386052697713da160afb16 Date: Wed Nov 15 13:10:40 2017 +0300 tdf#113861: Less aggressive expansion of chart headers. In this example nAllColCount is 3, nAllRowCount is 5, the columns available are 0, 1, 4 and the rows are 20, 21, 22, 25, 26. So I assume, comparing to the original version, that its not the actual row and column we want, but the index of the row/column into the range provided Change-Id: I568c561a8c5f0b2ee84590293bed8e302d5dda75 Reviewed-on: https://gerrit.libreoffice.org/45811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2074a3785371692dcfb86f45204f3707cbac1eec) Reviewed-on: https://gerrit.libreoffice.org/45944 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-07tdf#114228: fix crash when deleting sheet in specific caseJulien Nabet1-2/+3
1. Create a brand new ods file 2. Select L12 (so cursor is obviously on sheet1 L12) 3. Create a brand new sheet (and cursor is on sheet2 A1) 4. Delete sheet2 It crashes with gtk3, see https://bugs.documentfoundation.org/attachment.cgi?id=138199 As indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=114228#c5 the tab number is wrong Reporting cursor management later in ScTabView::SetTabNo prevents from the crash Change-Id: Iea307267d2cdcf1c01f7e72f45b6a68aeef26fa1 Reviewed-on: https://gerrit.libreoffice.org/45976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-01tdf#113831 Show number of search resultsheiko tietze2-28/+21
Skipped label used to show the number via resource strings Change-Id: I6f57799565126c202041d0bf6a9f361d4e64cdfd Reviewed-on: https://gerrit.libreoffice.org/45269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 470682b3abf0622f5e9663d62d8641f63ceb6f30) Reviewed-on: https://gerrit.libreoffice.org/45320 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-11-25coverity#1422232 Improper use of negative valueCaolán McNamara1-1/+1
Change-Id: I79b24e175906ca5552f45b6af472c436ffde5fe3 Reviewed-on: https://gerrit.libreoffice.org/45247 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-25Convert ScConditionMode to scoped enumTor Lillqvist7-135/+135
Change-Id: I9b6aaa64e7f649581b27f0238e2908026ab6e0bd Reviewed-on: https://gerrit.libreoffice.org/45157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-24drop unused ATTR itemsNoel Grandin1-2/+0
the table autoformat stuff does not use these values at all, it just writes the internal details of PoolItems in a pre-determined order Change-Id: Id6d8ae7508a8d19f5fd1e70f9a428d324082d3bf Reviewed-on: https://gerrit.libreoffice.org/45199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-24consistently use sal_uInt32 for number formats in scNoel Grandin8-10/+10
instead of a mix of short/sal_uLong/sal_uInt32 Change-Id: Ie5bd26e1a6f716c0c4e174a6d560827084b3f421 Reviewed-on: https://gerrit.libreoffice.org/45159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-16 04:57:50 +0000