summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)AuthorFilesLines
2014-08-11Ensure we actually render all cells in the selected area.Andrzej Hunt1-0/+4
Only cells within maVisibleRange are rendered, even if we request a larger area (and maVisibleRange is otherwise not updated for tiled rendering). Hence we should explicitly set it here. Change-Id: I399be9df1f266a2b3d32a95483960b21f561c6b3
2014-08-11Take into account drawing layer for data area size.Andrzej Hunt1-2/+18
The drawing layer could potentially have items that are outwith the data area, but we probably want to have them included for tiled rendering. Change-Id: I958c4fa29491cdb0fd80392dfcfa033306f2b76c
2014-08-11Use output device mapping for draw layer too.Andrzej Hunt1-1/+3
Otherwise draw layer items don't get scaled at all for tiled rendering. Change-Id: I4ed54f61420eae82fcf4692b8e9b605a3338fc52
2014-08-11Set correct scaling for normal painting.Andrzej Hunt1-0/+6
As we no longer read the scaling from the viewdata, we should instead set it on the output device when doing normal rendering. However the grid still doesn't exactly match the external axes yet, there are probably more rounding errors wherever they are painted. Change-Id: I25b1bd9b344115578fe892aa94fbf753a3c10c81
2014-08-11Use output device scaling to determine cells in draw-area.Andrzej Hunt1-11/+12
Change-Id: Idf4e6ccb72090a55b6a9234cafae21821e3df0b0
2014-08-11Don't scale grid and cell dimensions multiple times.Andrzej Hunt2-24/+37
Previously we had multiple layers of scaling, with rounding errors propagating, leading to up to 5% differences in expected and rendered sheet widths -- for tiled rendering dimensions have to scale accurately as we may paint the same tile at multiple zoom levels, by eliminating multiple scaling and letting the output device instead deal with the scaling once we can eliminate these errors. (However currently rendering of text/images isn't quite right.) Change-Id: I0a725fd5c030f3c089c2bbd25947088c321eb2d4
2014-08-08Implement data area size retrieval.Andrzej Hunt3-4/+49
Cell dimensions appear to be in TWIPs (but the drawing layer is in 100th mm).
2014-08-08Allow overriding of device for Paint, and use that for Tiles.Andrzej Hunt2-7/+14
Paint handles figuring out which cells are within the visible area for us etc. Gridwin being a Window which paints to itself is a bit of a pain, since we now need to be able to reroute painting calls to alternative output devices, however these changes seem to be sufficient to at least get the cells in the desired tile rendered. Change-Id: I7bd1434c97acc6e9ef6e1e63cbcf039b987c88e4
2014-08-08Calc: Add tiled rendering device to the paint view.Andrzej Hunt1-0/+13
This prevents the previous warnings of SdrPageView::DrawLayer: Creating temporary SdrPageWindow (ObjectContact), \ this should never be needed Change-Id: I76cb7c9ed4d45bfcbd297f697314309b4e036f80
2014-08-08Render tiles from calc.Andrzej Hunt3-14/+32
Currently the document size and number of cells to be rendered is hardcoded, this will need some more work to select the correct cells for a given tile (i.e. cells from location). Also, there isn't really a "size" for a calc sheet, so presumably we'd need to instead return the area containing cells that aren't empty, whilst still being able to render larger tiles? (And in any case the client will need to be aware of this and provide an appropriate interface, i.e. the current LO UI simply extends the sheet ad-infinitum.) We also currently get some warnings most likely related to the way we push our OutputDevice into the rendering methods: SdrPageView::DrawLayer: Creating temporary SdrPageWindow (ObjectContact), \ this should never be needed Change-Id: Ia9d64d7de6c22d5b401350f88497a7ec106f1973
2014-08-07coverity#706946 Uncaught exceptionCaolán McNamara1-3/+28
Change-Id: I836e353ae3a8274842465719b3d8ae82ad433375
2014-08-07coverity#735805 Explicit null dereferencedCaolán McNamara1-4/+9
Change-Id: I6641930b42f233096f4a0067ab320383ff07a72a
2014-08-07coverity#1158491 Uninitialized pointer fieldCaolán McNamara1-0/+1
Change-Id: I618427793885f6dce918e432e5d532f30bed71ad
2014-08-07fdo#82241 fix autocompletion for calc functions withWinfried Donkers1-5/+6
dot or underscore in function name Change-Id: Id460cad619098265b4ae000894df64a996ef0514 Reviewed-on: https://gerrit.libreoffice.org/10801 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-08-06RID_SCDLG_CONFLICTS conversion to .uiSzymon Kłos4-248/+75
Change-Id: Ibdfa27e834cd8fba0f732233338e5fba699c1e90 Reviewed-on: https://gerrit.libreoffice.org/10778 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-06Related fdo#69006: Reintroduce some height calculation back.Jan Holesovsky1-3/+2
When importing CSV with multiple lines in a cell, it looks as if some content was lost. It is not, it is in the spreadsheet, but looks very confusing, and only way to get around that was to let the heights be recalculated. It seems that the large CSV still opens in reasonable time even with this change in. Change-Id: I701110fcd8a92daa5f374d80f5af696666a7aa6a Reviewed-on: https://gerrit.libreoffice.org/10499 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2014-08-05handle autocomplete with dot in formula name, fdo#80058Markus Mohrhard1-0/+28
The problem is that a dot is a word separator so the break iterator provided by ICU will think that the dot separates two words whereas it is part of the name here. Change-Id: I73cee4304f83888b1645fec7b1851b9f42ef879f
2014-08-05use a anonymous namespace and sane function namesMarkus Mohrhard1-3/+7
Change-Id: I8fdd5fb4f21e6c90e352089858ce98a62ac213de
2014-08-04Convert RID_SCDLG_DPSHOWDETAIL to .uiPalenik Mihály3-69/+15
Change-Id: If515e8f554f36e4ba203474d08d5ebe9caa023fa Reviewed-on: https://gerrit.libreoffice.org/10739 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-04Consistency around SdrOnOffItem in svx/sdtagitm.hxxStephan Bergmann2-9/+9
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
2014-07-31fdo#78555: Oopsy.Kohei Yoshida1-24/+4
Change-Id: I969973b2d8165d7ff7a46e6b7e60ad07e58bfdee
2014-07-31fdo#78555: Retain formula results when moving a range of cells.Kohei Yoshida2-14/+63
* No need to re-compile RPN token array on reference change alone. We do that when the formula contains one or more names that have been updated. * Adjust undo code to get it to work without relying on ref undo document, which would cause the token arrays to be unnecessarily recompiled. * Whatever else need to be changed in order to pass all unit tests. Change-Id: I99e86d23320aca8900fef011da23a9d34e42751e
2014-07-30the dialog hierarchy changed iwith the ui format, fdo#81867Markus Mohrhard4-34/+42
We need to be explicit now and can no longer rely on GetParent returning the right object. Seems like sometimes you get punished for an ugly hack a bit later than expected. Change-Id: I145e97ae0ceee741c4128c29a6ca26fad2178cb5
2014-07-30fix wrong calculation for text size, fdo#81499Markus Mohrhard2-14/+14
Change-Id: Ifd9e09dd9e1d843728e1874c48efdd127bffe11e
2014-07-29fdo#80846: Get the parameter order right.Kohei Yoshida1-1/+1
It's column, row, tab in this order, not tab, column row. Change-Id: I32e69a403feaf18532c7ac241fa2a98fc65a4ba7
2014-07-29Bring this logic from ScViewFaunc::DeleteContents to ScDocFunc's.Kohei Yoshida1-3/+31
To make the bug reported in fdo#80846 reproducible. Change-Id: Iec400f26c6c6af9ae3bd0afd4fce75939ab1e23d
2014-07-29Revert "it makes no sense to use the second column as well, fdo#81499"Kohei Yoshida2-3/+7
This reverts commit 14277af57b397b03b753a61c22cc5211e43a5f82. There is a reason why we do this, to allow misspelled word outside the cell area to be right-clickable.
2014-07-29Remove some unused codeMarcos Paulo de Souza2-9/+0
Change-Id: Ib1fb5108a858c35a5bbe8ba865e15660639725e3 Reviewed-on: https://gerrit.libreoffice.org/10593 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29Drop unnecessary SfxApplication::CreateResManager wrapperStephan Bergmann1-1/+1
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
2014-07-28fdo#79578: Properly update formulas upon change in db collection.Kohei Yoshida8-20/+20
Update it to handle formula groups correctly. Change-Id: I009a7fcf3d3fb17ef6951c50534ca6bc1fffc259
2014-07-28Move this fucntion to ScDBDocFunc.Kohei Yoshida5-49/+47
so that it could be usable from unit test. Change-Id: Iea10cb473bc17d7e030c018fd2c84fbeccce3e47
2014-07-27Dead declarationMaxim Monastirsky1-3/+0
DetectFilter impl. removed in 2fcfebf3900ee4df2e2fe39e37d55ee87ab5d6cb. Change-Id: Ia21199066ac00c1b0ddc40168bcc7f1406cb9ea0
2014-07-26coverity#704706 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: I22f376f747ffbb7f559d7e0ea631e2baae92138f
2014-07-26coverity#704702 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: Ie87a6e27a399b2c758e160eed1ab0f4b1704b5cd
2014-07-26Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'Matteo Casalin6-10/+10
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-24fix coding styleMarkus Mohrhard1-6/+7
Change-Id: I4841929ac8f1a50892d72f7b2a32ba2f55b62a85
2014-07-24avoid static variablesxukai2-1/+19
Change-Id: Ib73464cbd9ddc644b008ab7fdcab5ca70dcaa2f1
2014-07-24move SFX_ITEMS_DIRECT etc. definitions inside the moduleNoel Grandin1-1/+1
These are internal constants, they don't need to be visible to the rest of LO Change-Id: I313def85b8c404948ec9ecb3996fed03b32ff9bf
2014-07-23Revert "opengl charts: Move the init from sc to chart2 ...Markus Mohrhard3-0/+32
This reverts commit 46cea34638b371570073c0e86f79969753c543ed. Conflicts: chart2/source/view/charttypes/GL3DBarChart.cxx Change-Id: Ia29ea6a95b8b9eb870d14538d0cadaa40472582f
2014-07-22callcatcher: update unused codeCaolán McNamara2-14/+0
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-20it makes no sense to use the second column as well, fdo#81499Markus Mohrhard2-7/+3
Change-Id: If5990d41f444a2d051c9b9029d61ffd8b8cf377e
2014-07-20that was just a complex way to describe that the whole range is in itMarkus Mohrhard1-2/+2
Change-Id: Ib204b6ab39872280c8889615170735ed8c1fc811
2014-07-20vcl consitent use of long for corrdinateNorbert Thiebaud1-1/+1
most of length in vcl are calculated in 'long' but array of X position tend to be in sal_Int32. As a prep work to be able to support 'double' as the base type of Device Coordinate, harmonize the use of 'long' for non-float coordinate. Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-20fdo#63756 build libxml2 with ICU supportDavid Tardon1-1/+2
Change-Id: I0523e49e640812be435ba4c97b1881ca253eb2ab
2014-07-20opengl charts: Move the init from sc to chart2, to have the right parent.Jan Holesovsky1-18/+0
Change-Id: I1e23329345e00e7d8e1f269c832e84d015824c0a
2014-07-20Resolves fdo#81549: Crash pivot tableJulien Nabet1-1/+1
Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=345d6dd9d938a88722fb6d1f1963047a9761412d ? Change-Id: Ie2ebef88bd8369065b8a4ab176099c71674d5090 Reviewed-on: https://gerrit.libreoffice.org/10410 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-07-19XFillStyle -> css::drawing::FillStyleMiklos Vajna2-2/+4
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-07-18coverity#1226486 Dereference null return valueCaolán McNamara1-2/+4
Change-Id: I9157f1844923e3e6ac360e859ee2cd97c33512ba
2014-07-17scrolling very slow in calcCaolán McNamara5-21/+8
even on a short spreadsheet scrolling up and down leaves the first/last row (depending on the direction of scroll) unchanged until the scrolling stops. http://people.freedesktop.org/~mst/calc_4.2_scrolling.webm On larger document there are rendering artifacts during scrolling which go away after scrolling for me and mstahl, but a bunch of people can show us piles of horribly broken spreadsheets after scrolling, esp wheel scrolling Revert "fdo#75026: Sometimes we need to update grid view... while not being active." This reverts commit 52cc88d6191ba0c4b6477e5c4b9c5d0f0228030d. Revert "fdo#68961: Check visible range during scrolling, and re-paint if necessary." This reverts commit e36c8a674845ab19577fc06d44b780549757e1e7. Revert "Repaint grid view when the visible area changes." This reverts commit b54c1a53b4d400b1c2d282c186af1fa8f151894e. Conflicts: sc/source/ui/app/scmod.cxx Revert "Update visible ranges when updating the scroll bars." This reverts commit 391a57ef65687f2e373bac8d410e551aafa780ec. Change-Id: Ie170308cba18a9a74c7c72daf07dfa0a4ef7bd13 Reviewed-on: https://gerrit.libreoffice.org/10350 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert1-1/+1
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>