summaryrefslogtreecommitdiff
path: root/sc/source/ui/view
AgeCommit message (Collapse)AuthorFilesLines
2014-12-03remove boolean parameter default from ScDocument::SetDirtyEike Rathke1-1/+1
... and force the caller to make a decision. In fact some needed to include empty cells. Change-Id: I82b6ef72f7ecda6543b3cafc70f475519870b471 (cherry picked from commit 135b8d6466ade1e8724e604f705f95cecf4c4881)
2014-11-28set only valid positions from ScExtTabSettings at ScViewDataTableEike Rathke1-4/+13
Some address fields of ScExtTabSettings are initialized invalid and maybe kept invalid, on purpose, so take care of that and use only the valid fields. Change-Id: I37cbf8ff49c6ccf38bfac3e1c8c6492ac7bad61b (cherry picked from commit 8bc56801af0540c0496c1f8ddd335578a8791017)
2014-11-28sanitize viewdata col/row valuesEike Rathke1-7/+4
Change-Id: Iec51b032c96189b20cd43934c477b587da3011a7 (cherry picked from commit d042bef351af4649e656bfb8c60273149e5daeb5)
2014-11-20One more IsMapMode() -> IsMapModeEnabled().Jan Holesovsky1-1/+1
Change-Id: Id8e5ca61eedb7607b5ef9d7e67bee47c87d4990b
2014-11-19Resolves: rhbz#1165444 abrt crash with NULL pViewCaolán McNamara1-5/+2
Change-Id: I37f02f16209f274cf0358defba6bfa109948990f
2014-11-18fdo#86018 Don't do anything when clicked on placeholder in statusbarSamuel Mehrbrodt2-6/+0
No idea why this code got executed in sw, it has no action in sd and sc. Change-Id: I1d2b4b049f6ae6d117e7bf3464ae993c6951f1dc Reviewed-on: https://gerrit.libreoffice.org/12314 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-18fdo#76868 Add chi-square test Statistics DialogTomaž Vajngerl3-0/+18
Change-Id: I35c115a1f1cb733a0d6841596d8baf2e5ade4a1d
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl1-0/+2
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-15fdo#74669 Add z-test Statistics DialogTomaž Vajngerl3-0/+18
Change-Id: I8169e9ceefc48c06b358d5a8e1fc08dabf019eb3
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava3-3/+3
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-4/+4
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11iwyu: remove unneeded includes in sc, sd, swRiccardo Magliocchetti3-10/+1
Remove only include for files where iwyu does not suggest any includes to add. Change-Id: I58f3e956485ce058750c2635db9633736708d7f0 Reviewed-on: https://gerrit.libreoffice.org/12342 Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Tested-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin1-3/+3
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin2-3/+3
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-04remove some unused code in scNoel Grandin1-33/+0
Change-Id: I6cd2acaf361ae1947787b5aacc86b75a6e21c379
2014-11-03fdo#85403 broadcast changes after TextToColumnEike Rathke1-0/+1
Regression introduced with 3d869cda8db03820dea8c4ba463eb155d05e933b for fdo#74014 Change-Id: Ie8ca1e7c15609aaf80b4ecbb6ccffc30a3f79f0a
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin1-1/+1
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin2-4/+4
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-28cid#738785 Uninitialized pointer fieldStephan Bergmann1-10/+10
Change-Id: I2256682639084c8889d1137f087e34f7b0dab6e7
2014-10-28loplugin: cstylecastNoel Grandin38-455/+455
Change-Id: I42cd0be78478536322357ca7a03cf30e624b1afc
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin1-2/+2
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-24fdo#73617 sc: Don't update the gui during live previewMaxim Monastirsky1-1/+0
Apart from (apparently) being not necessary, it creates bugs like this one. If the selection consist of multiple fonts, it leads to clearing the font name box, which in turn leads to scrolling the list up. Change-Id: I8e702b9b4d4a1f7ad1ded5de1a5e162f039f6d4d
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky24-153/+155
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky23-116/+116
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-22Update all script types in the marked ranges up-front.Kohei Yoshida1-0/+2
This is slightly faster than doing it on a as-needed basis. Change-Id: I7618f003f3c98ee894c3f1cf597681e4281cc6ab
2014-10-22callcatcher: update unused codeCaolán McNamara1-2/+2
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist4-6/+14
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon23-116/+116
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-1/+1
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin19-42/+42
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10Have ScViewFunc::DeleteContents() to call ScDocFunc's.Kohei Yoshida1-75/+4
If bSimple = true, call DeleteCell(), otherwise call DeleteContents(). Change-Id: Ic08d9501797b537430bef0b6f3d920c3b497104b
2014-10-09InsertCurrentTime: in input mode inherit matching format if setEike Rathke1-7/+17
In case a date or time cell format was set, inherit that format for Ctrl+; or Ctrl+: date/time insertion while editing the cell. Change-Id: If13e680fc74ab36611f8c11d992dba4b9c91ddb4
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca24-155/+153
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-08Move this one to a common place too.Kohei Yoshida1-6/+3
Change-Id: I7f4e007cfc861dc323b42be353c6ba11091e8fa1
2014-10-08Share undo doc creation code.Kohei Yoshida1-44/+2
Change-Id: I55f27b61637ba0284479c63c2fa48b0bd8938c0f
2014-10-08Start sharing common code between DeleteContents of ScViewFunc/ScDocFunc.Kohei Yoshida1-9/+3
The goal is to have ScViewFunc::DeleteContents() simply call ScDocFunc::DeleteContents() while doing the view only stuff in the ScViewFunc variant. This is just a step toward that goal. Change-Id: I2e574f9eb2b2be5340dbfb6f10739dfc2406faae
2014-10-06Resolves: fdo#80101 inserting non-chart as chart -> unhandled exceptionCaolán McNamara1-0/+5
Change-Id: I4d5438292d9a5c49f1336304ebd3dc4e155dd212
2014-10-06fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt1-1/+0
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed Reviewed-on: https://gerrit.libreoffice.org/11648 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-04coverity#704002 Unchecked return valueNorbert Thiebaud1-1/+1
Change-Id: Ibf506a219df7d0ad67959b3d266a037003fceea4
2014-10-04Add menu entry for the "formula to value" feature.Kohei Yoshida1-0/+6
Not sure 100% if that's the best place for this. Feel free to move it to a better place. Change-Id: Id66a92e1184e988bd71f7d845ea370b021c02c21
2014-10-04coverity#1242818 Unused valueNorbert Thiebaud1-2/+0
Change-Id: I487026489937679978e7ed403edb7125eb2c7fcf
2014-10-04coverity#1242771 Unused valueNorbert Thiebaud1-1/+0
Change-Id: I86455a041c98f010724ac6878e78a1b14cd26899
2014-10-03coverity#1242443 Identical code for different branchesCaolán McNamara1-8/+0
Splitter derives from Window and doesn't override MouseMove so both branches are the same Change-Id: Id74f12e2efb458ac2ae183686a57befdf0225778
2014-10-03coverity#1242454 Identical code for different branchesCaolán McNamara1-8/+0
Splitter derives from Window and doesn't override MouseButtonUp so both branches are the same Change-Id: I9072d24b60dacfdb1d3e9ca1c97f08002f7e24ba
2014-10-03coverity#1242477 Dereference null return valueCaolán McNamara1-0/+3
Change-Id: Ic2d8dab00d5af47f6274433ee811f567f990400b
2014-10-02New feature to allow converting formula cells to static values.Kohei Yoshida2-0/+16
You used to have to convert formula cells to static values by copying them and pasting them as values onto the original place. Why not just allow converting them in place? This is something I've always wanted to implement.
2014-10-02Bin EE_CNTRL_URLSFXEXECUTE which was only set, never testedTor Lillqvist1-1/+0
Change-Id: I18a9355bb902b19f0eeecb26d33eba4fb25db8cb
2014-10-02coverity#1242506 silence Arguments in wrong orderCaolán McNamara1-1/+1
order doesn't matter one bit as far as I can see Change-Id: I55aa5d23d9865a47ef4dcda9d3e19863794a18c9
2014-10-02coverity#1242872 Unused valueCaolán McNamara1-2/+0
Change-Id: If385b910c1778217d8db881b5d27ea993e27a66e
2014-10-02coverity#735819 Unchecked dynamic_castCaolán McNamara1-2/+2
Change-Id: I4e8834a2cdc979757ae6d37730a89fc20bcc6b26
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-16 07:32:12 +0000