summaryrefslogtreecommitdiff
path: root/sc/source/ui/view
AgeCommit message (Collapse)AuthorFilesLines
2020-05-27lok: formula bar: send whole function listMarco Cecchetti2-7/+121
Change-Id: Ibbd142652f3190387700f820e56c494b61bfa658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93341 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-27lok: set device form factor of the client on view creationMarco Cecchetti2-5/+5
This patch allows the lok core to know about the device form facor of the client requesting the creation of new view, immediately instead of a later time. When a new view is needed a "DeviceFormFactor" parameter is forwarded to lo_documentLoadWithOptions and doc_createViewWithOptions from the client. This parameter can have one of the following values: 'desktop', 'tablet','mobile' and it is used to set a global variable accessible by SfxLokHelper::setDeviceFormFactor and SfxLokHelper::getDeviceFormFactor. This global variable is retrived in the SfxViewShell constructor for setting SfxViewShell::maLOKDeviceFormFactor attribute. In SfxViewShell we have the following 3 methods: - bool isLOKDesktop() - bool isLOKTablet() - bool isLOKMobilePhone() which replace the following boolean functions: - comphelper::LibreOfficeKit::isTablet - comphelper::LibreOfficeKit::::isMobilePhone Change-Id: I9b36f354278df8c216fcb90f6a9da8256ec9c1e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93340 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-27Revert "tdf#37268: use also sheet local range in Pivot"Julien Nabet1-25/+5
This reverts commit 73af06a6a7fcb2d92d36a45bbe54395bcba8dfb0. The patch is wrong according to: https://bugs.documentfoundation.org/show_bug.cgi?id=37268#c24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94748 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 818af4717bd7d4fbb6f622128c99259efb0714c9) Change-Id: I63dd69afa3fc324930cd16ccc3458372d7745531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94684 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-05-27lok: send "EMPTY" if the rect is empty for cell selection or fillTomaž Vajngerl1-7/+19
It can happen that the selection or auto-fill rectangles are empty and if that's the case then we need to send "EMPTY" string and not the content of an empty rectangle (0, 0, -32768, -32768). This can happen for CELL_SELECTION_AREA or CELL_AUTO_FILL_AREA in calc. Change-Id: I9a60e3907a2ab8b0e0fd1a2ff81137fba6c8e9a3 Reviewed-on: https://gerrit.libreoffice.org/85437 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit df6871286d7b769bc47554955213a2d727c47875)
2020-05-26lokit: fix edit-text/view-cursor positionDennis Francis2-7/+119
in case of views with heterogeneous zooms. 1. EditText render position fix The EditView has an 'output-area' which is used to clip the rectangle we pass to the Paint() call. It also holds on to the ScGridWindow instance where the edit started. The 'output-area' of the EditView is in the coordinates/units of the MapMode of the ScGridWindow it holds. So we need to temporarily change the MapMode and 'output-area' of the EditView in agreement to the device(with the current view's zoom settings) where we are going to paint to. After we call the Paint(), we rollback the original settings of the EditView. 2. EditViewCursor position fix Before this change the cursor position in twips (calculated based on pixel aligned cell position in the view where editing occurred) is broadcasted to all the client-views. If the clients have different zooms, then simply scaling this common cursor position in the client for its zoom is not going to be accurate enough (due to the non-linear Logic->Pixel->Logic transformation involving pixel rounding). This is very visible if you are editing far away from A1 (like Z50). The fix is to turn off this broadcast for calc-cell editing and send view specific edit-cursor invalidation messages. This is accompanied by a online.git patch that removes unnessecary broadcast of view-cursor invalidation messages which messes up things again. "Do not broadcast view-cursor invalidation messages" Change-Id: Ib2fbbe4b6f93f26fc85d6adaa8684dd4397d886f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92631 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit d58f1e334245f9e136750fbba267c2a941a213cc) Conflicts: editeng/source/editeng/impedit.hxx
2020-05-26lok: calc - update our version of the other view's selections on zoom.Michael Meeks1-1/+37
Change-Id: I4d23bb77045b41d04109e7dd70a1f47bca8aaa56 Reviewed-on: https://gerrit.libreoffice.org/84767 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ca2fdd792de5d6d208097b3049238865058c7cc1)
2020-05-26lok: calc - update our version of the other view's selections on zoom.Michael Meeks2-25/+52
Change-Id: I8487f28d762c8bf5be4f00a331263218dc71d179 Reviewed-on: https://gerrit.libreoffice.org/84694 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 2986620074d104611a6e78c98ee5a09941866125)
2020-05-26lok: calc - send other views our selection in their co-ordinates.Michael Meeks2-31/+75
Change-Id: If48b5adb9b8b03310d2d2c4e4fefab84ad8bb149 Reviewed-on: https://gerrit.libreoffice.org/84370 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ab07df7ee12aef8bb3770e69d22ecb272d379ece)
2020-05-26lok: send other views our cursor position in their view co-ordinates.Michael Meeks1-17/+31
Change-Id: If8d84a04e8d7b4863dcb9bc9058939b1eb793266 (cherry picked from commit c6b18508aec0e609b4c3c000faf89c21e93620bd)
2020-05-23lokit: trim validation dropdown height to contentDennis Francis1-1/+5
The validation dropdown looks ugly for lists with small number of items as its height is hardcoded to SC_FILTERLISTBOX_LINES(=12) * TextHeight Instead lets use the number of entries in the list to determine the height if this count is less than SC_FILTERLISTBOX_LINES Change-Id: If026140044e6665159cd616c13a2eb57356ae53f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92914 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit adf10bae8aecd8b765a21660b31056292276bdb2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93066 Tested-by: Jenkins
2020-05-23lokit: fix validation dropdown's wrong positionDennis Francis1-0/+16
Reverse the zoom scale on the position of the dropdown before letting the vcl::FloatingWindow convert this to twips without any scale information. Without this reverse scaling, the dropdown will be incorrect due to double application of the same zoom (one in core and one in client). Change-Id: I73de12593b13e1bc9fb0514bec23c20d440d8923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92913 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit a68bfe87f6c720dd2b4721edf869c6801fa2d967) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93008 Tested-by: Jenkins
2020-05-23lok: Center shape on insert also for Desktop viewMuhammet Kara1-7/+1
Change-Id: I85c3fe3d0166eb42f46f2aa65d0319e582b851af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88489 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2020-05-23mobile: Center inserted shapes on visible areaMuhammet Kara1-0/+12
Change-Id: I366ef5d01ee3afb072b1f67d24015c889a41f4b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88488 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-23tdf#130770 apply autofilter to data regardless of autofilter changesscito1-22/+15
Add a unit test Apply autofilter to data if there are no changes from the user for AutoFilterMode::Normal mode The condition eMode == AutoFilterMode::Normal at that position is equivalent to eMode != AutoFilterMode::Top10 && eMode != AutoFilterMode::Empty && eMode != AutoFilterMode::NonEmpty because - Top10: Excluded in if() - Custom: Already handled before - Empty: Excluded in if() - NonEmpty: Excluded in if() - SortAscending: Already handled before - SortDescending: Already handled before - Normal: The remaining condition Delete dead code: The condition if (mpAutoFilterPopup->isAllSelected()) will never be true since eMode == AutoFilterMode::Normal && mpAutoFilterPopup->isAllSelected() is excluded in the "outer if condition" !(eMode == AutoFilterMode::Normal && mpAutoFilterPopup->isAllSelected()) Moreover aParam.RemoveAllEntriesByField(rPos.Col()); has already been called before. Change-Id: I1a5362f6edf6d28b3e049977d761cef83897e63e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91645 Tested-by: Jenkins Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit e9c04fdc6d91a152c9197bda3b07316bed1dc4f3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94457 Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-18tdf#130112 lok: Do not apply zoom-factor twice...Dennis Francis1-4/+5
... in ScOutputData::FillReferenceMarks(). mnPPT[XY] already has the factor aZoom[XY] in it. Refer ScViewData::CalcPPT() to see how PPT[XY] are derived. Change-Id: I3f9b5c01cb53514450fad5f7b2b6861b112effdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87158 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 3f62c10548466119ec6b1a662ab339e5dbe0b05f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87170 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-05-18lok: cleanup getCellCursorMichael Meeks2-51/+34
Switching the zoom is no longer necessary - we now have a known and fixed zoom per view now (as the core has), that saves some complexity. Change-Id: I14c952ca1e06fae016faa8b6ee07115c56312ed6 Reviewed-on: https://gerrit.libreoffice.org/84372 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94392 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-18revert optimization - 31b7dc19c32f42197c481cb7d2f44c600b755e2bMichael Meeks2-9/+0
Doing faster lookups across the calc data structrures is far more effective than complex caching of this kind. Change-Id: I43d3ee948ae817ec1d196acc6e5603e6acf1970c Reviewed-on: https://gerrit.libreoffice.org/84371 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94391 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-17Rename isMobile to isMobilePhone and introduce a separate isTabletTor Lillqvist2-3/+4
The intended semantics of isMobile() has been to say whether the device is a mobile phone ot not. Not whether it is a mobile device in general. So make that explicit. Adjust call sites as necessary. Also, in a couple of places where it is likely that what is relevant is whether it is a mobile device in general, not just whether it is a mobile phone, check both isMobile() and isTablet(). For stable interoperability with current Online, keep accepting also the .uno:LOKSetMobile "command" (and .uno:LOKUnSetMobile, except that Online never sends that), but Online will be changed to use .uno:LOKSetMobilePhone. Also drop the default value for the bool parameter to setMobilePhone(). Default bool parameters can be quite confusing, and it was especially silly in this case as there is one (1) call site. Change-Id: I2a71c37323ee151cbc671bd8e714e1dee10f8b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90560 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94390 Tested-by: Tor Lillqvist <tml@collabora.com>
2020-05-17fix ToC links give unhelpful url popupsMert Tumer1-3/+7
core expects ctrl+click for internal links too and it should not expect it if it is tiled rendering Change-Id: Id841f0e9729e46f00988ea0b4eb29bd65098a740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89559 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3fe9dfca2d44d9e41ee329883f199359c673f382) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89919 Tested-by: Jenkins
2020-05-17send hyperlinkclicked callback on calc mobileMert Tumer1-1/+20
for opening links ctrl+click must be pressed but in mobile this cant be done This patch allows it to send the callback and also cell coordinates for hyperlink popup Change-Id: I8c0fac167627ef449d9cf20a36a7a5a77978ae0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89121 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 9bfa939f87f28cdaed2a24c3dc5f9a21004b19da) Blind build fix for Android After 9bfa939f87f28cdaed2a24c3dc5f9a21004b19da Also, replace chained OStringBuffer::append() with operator+ Change-Id: I7012667b3c4173cc0193720e0197992e5942bc7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89693 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-17lok: calc: unwanted cell range selection occurs when clicking on a cellMarco Cecchetti1-1/+1
When user clicks on a cell after the browser has lost focus user gets the cell range from A1 to the current clicked cell selected Change-Id: I1dd495f42ca7e5ee8cad1d2354dcebc0cb05d65f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88549 Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90071 Tested-by: Jenkins
2020-05-17lok: calc: zoomed text entry not renderedMarco Cecchetti1-4/+7
Change-Id: I829966d81bd68571a0651feb458a817587e4d88e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84992 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-17lok: calc formula bar tunnelingMarco Cecchetti1-0/+11
Change-Id: I92026098222e04a163796225a048c6d7dc1b37c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89857 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-05-17lok: on calc spelling context menu didn't pop upMarco Cecchetti2-10/+17
The problem has been fixed by making visible cell range syncronized with client visible area Change-Id: I632f8ef4d5e8fa227b55fcb0459ed89d10798134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89856 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-05-17LOK: emit modified status on entering cell dataAshod Nakashian1-0/+12
Entering data into a cell without committing will normally not set the modified flag. However clients might want to know whether there is in-flight changes when they need to save the document. A possible scenario is that the user enters some cell data and then closes the window. Both WSD and the client app would here rely on the modified notification to decide whether to save the document or not. We do not change the document modified state, since that may be incorrect (in case the user actually cancel the cell entry), so we preserve that so future updates to the modified status would reflect the correct state of the file. Instead, we emit a client notification that the document has been modified, to signal them that saving is sensible. Note that ideally we would undo this when the user cancels the cell edit, but that would be complicated due to multi-editor scenarios. For example, another user might actually edit the document while we cancel our cell edit, and in this case we should not reset the modify flag. Since this is unreliable, we leave the flag set, unless the Core emits an update, which will surely be accurate. Reviewed-on: https://gerrit.libreoffice.org/75513 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 38b899312245758381fa72ad17c2d4c281edb1ba) Reviewed-on: https://gerrit.libreoffice.org/78451 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Change-Id: Id26aa6f8ce2c0a08f8bee6812fcf99275dc24551 Reviewed-on: https://gerrit.libreoffice.org/82093 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-05-16lokit: Mark document as modified on chart insert/edit...Dennis Francis1-1/+4
immediately at least in the case when LOKit is active. This is to allow prompt emission of .uno:ModifiedStatus=true statechange message from lokit to the client. Without this, in online the chart insert/modify related changes may not get saved on client exit. (cherry picked from commit 75adb624dfff4659e6f3099a1720fbd697560f9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91036 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Change-Id: I8c38a37cc455f74a70d43b6aaa3e5035b283d47f
2020-05-16sc: clear the spell checking markers after applying correctionsAshod Nakashian1-0/+5
Change-Id: Ia3fc3b5a21d21b9b945ce72f397350a57859f107 (cherry picked from commit afa5f2b0edb43b36b1b4f0ab8f70ecbe638435e5) Reviewed-on: https://gerrit.libreoffice.org/85006 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e1ca2b989bf4d124588c35f7f4a0bc3da3c1f58e) Reviewed-on: https://gerrit.libreoffice.org/85682 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-16sc: spelldialog: lock before resetting the editviewAshod Nakashian1-0/+3
Painting also resets the view and that can happen asynchronously. When the spelldialog gets focus it resets the editview if it detects it has changed, which happens when, for example, another view is created. (cherry picked from commit d91d940ad0319e0cc6e0080a903ac0a7e9f6ba88) Reviewed-on: https://gerrit.libreoffice.org/85003 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 550c0a666e119c911b311c96f9185c11d8465dcb) Change-Id: Ib23e332e4ba069e05787d1cc03ae23fe657b12c8 Reviewed-on: https://gerrit.libreoffice.org/85679 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-16lok: Improve hyperlink insertion to cell with contentMuhammet Kara1-2/+19
Change-Id: I520939dd5b44236cf835108ee2bc96c29f0a9677 Reviewed-on: https://gerrit.libreoffice.org/85509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89707 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-05-16lok: calc: zoom: object selection - is unreliableMarco Cecchetti1-0/+25
Change-Id: Ic8e61c56bdf38bbb74f179fa36075bdd3a601249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90068 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-05-13Fix csv dialog pops up on mobile when copy/pasteMert Tumer1-1/+2
Change-Id: I9e4b154090ad9da0d10a368656f6f63fe335cecf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87132 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit f99605b6df506d51411d22d377eafd722685edbd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88397 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-13reduce iteration in ScViewData::GetScrPosNoel Grandin1-18/+11
we already have a ScTable::GetRowHeightScaled method that uses spans, so use that. Change-Id: I126292b4a8b37ebf2d4f737dcbfdadc31226531e Reviewed-on: https://gerrit.libreoffice.org/82520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-13Make Chart Creation Wizard asyncSzymon Kłos3-2/+36
* FuInsertChart as a memeber in ScTabViewShell stores instance is needed to react on the dialog's result * CreationWizardUnoDlg converted to XAsynchronousExecutableDialog added dialog close handler which notifies listeners In the Online dialog become dead after closing, additional PostUserEvent was needed to kill the dialog after real close (without it user needed to select any cell to close dialog) * Reuse in Writer Change-Id: Ib09b5d83af9e1aa67218e093aa161419e8ddb922
2020-05-08FrameLineColor - add Color parameter, and share code for color params.Michael Meeks1-27/+32
Change-Id: I50483228221e817eb1a1d049d3c1ddf55a9c91d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91354 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-05-08Fix FontColor does not change selected cells on calcMert Tumer1-2/+24
Change-Id: Iae2f72bff4fd6986fc8cc07ba09996b1af4eb140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86670 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-03-04tdf#126904 calc right arrow large unexpected column jump in protected sheetNoel Grandin1-1/+2
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I3b6f6e5430c97ef52f63c406eb3c3b39b9dd578e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7ae33e175007d04021f5e911e3f7f6cbd0966804) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89914 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-27Resolves tdf#127508 - Flat table header in CalcHeiko Tietze1-31/+4
Amends 67fd62b3edc86c2891f279b25cf9919c4bbbbca1 with flat corner button Change-Id: Ia26aff0844069dd435cf4edd7524c19f5f0f22ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89365 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit d8c7864407249fd1ed69713dfdf4fa533a9efb0b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89575 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-14tdf#130640: Revert "tdf#124983 In calc make printable page...Xisco Fauli1-23/+0
...borders also initially visible" This reverts commit caeb7b141280a65e60525f11a7e6514b76e12e11. Change-Id: I691934db79982c16bf0f43e7e38b00f3ab440a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88616 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins (cherry picked from commit c4281cb41e6b76cabd5fe42fc707877e864dfb82) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88646 Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-14tdf#130325 Fix listbox used as dropdownSamuel Mehrbrodt1-1/+1
In this case, the listbox is not used as a static widget, also not as a combobox with dropdown. Instead the listbox is placed in a popup to choose values from. Need to handle this case similiar to the combobox dropdown (Cursor movement only travels through items, Return selects one item). Regression from 7de9417d5f65d35227c7f80f6d587c2a56bde4e0 Change-Id: Idadc3da5847e12e1408203b13ab59eb53fe14eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88581 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit d92463c88a557eea7a439def39659b1409772583) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88503 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-13tdf#128873 speed up switching into page layoutSerge Krot1-3/+3
Change-Id: I993fdafe226680ac718f4611cfb1f842bc99f385 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88231 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 153c4c7e6ab066c6b1c06704e08e5be815cfc024) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88302 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12tdf#130054: consider all row/col bars in ScTabView::EnableRefInputMike Kaganski1-12/+9
Left col bar and bottom row bar were ignored - apparently overlooked at least since commit 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24. Change-Id: I5c2386b0aa1fdbb42f352c0b654e268dc62c7e66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87007 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit bda31b1a95b284749cd5e4d9596aab8e1aa93714) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87022 Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-07tdf#119191 Implement SdrObjCustomShape::AdjustToMaxRectRegina Henschel1-2/+4
and use in ScDrawLayer::RecalcPos and in ScDrawView::FitToCellSize(). Error was, that it was assumed, that SdObjCustomShape::SetSnapRect() changes the shape so, that it fits into the passed rectangle. That is true for other type of shapes, but not for custom shapes. Change-Id: Ib00d52087509f459165000abf43c7f244980a01b Reviewed-on: https://gerrit.libreoffice.org/84216 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit f44140bebb9c493d97ba5aef26c9692c53a6b93f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85043 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-07tdf#130187: Don't crash on exiting print preview with NotebookbarMike Kaganski1-2/+2
Crash caused by this sequence (tested in Writer): 1. Closing print preview, frame is attached to controller; 2. This calls SfxNotebookBar::StateMethod 3. There notebookbar's listener is added to list of the controller's context change event listeners 4. Then in SwPagePreview::~SwPagePreview, notebookbar's listener is added to that list again 5. ContextChangeEventMultiplexer::addContextChangeEventListener detects second addition, and throws an unhandled exception. I don't know why starting listening is needed in SwPagePreview dtor; unfortunately commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd doesn't say much about context and reasons. ControlListener is renamed to ControlListenerForCurrentController to emphasize that it operates on the current controller of notebookbar's frame; and its bListen parameter meaning was reverted: previously its "true" value awkwardly meant "stop listening". All direct operations with listener of notebookbar are replaced with calls to notebookbar's methods. In ContextChangeEventMultiplexer::addContextChangeEventListener, uno::UNO_QUERY_THROW was replaced with uno::UNO_QUERY, because not only chart controller may appear here, and it's not an error: e.g. SfxBaseController doesn't implement lang::XServiceInfo. Regression after commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd. Change-Id: Ief1aed188d8f02a6cfe3ea25f4d082dfdf449f32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86257 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87582
2020-01-07tdf#129552 sc: avoid infinite invalidation loop when the print range is emptyMiklos Vajna1-1/+6
Commit caeb7b141280a65e60525f11a7e6514b76e12e11 (tdf#124983 In calc make printable page borders also initially visible, 2019-07-10) added the ability to paint page breaks right after opening a document. The implementation calls ScPrintFunc::UpdatePages() whenever there are no calculated page breaks. The problem is that this is not only true when they are not calculated, but also happens when the print range is empty. This means that ScGridWindow::Paint() resulted in a vcl::Window::Invalidate() for the same window, and this happened again and again as the idle handler was invoked, resulting in flickering form controls. Fix the problem by only calculating page breaks when ScPrintFunc::HasPrintRange() confirms something will be calculated. This works because HasPrintRange() return false when ScTable::aPrintRanges is empty, and UpdatePages() also does nothing in that case. (cherry picked from commit e7e01efc56f7061d0a2e5142b4bae84dd403cc50) Change-Id: I14d8a728f4672e647e9009a3dc3e0dd5fb40c023 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86274 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06Fix "Open Hyperlink" context menu in scSamuel Mehrbrodt1-1/+1
Change-Id: I05fce087d20123447c1e5bd0f27db8d1c9ef3641 Reviewed-on: https://gerrit.libreoffice.org/84518 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 069a45e661086d1014855ca4f7ad384ba5752bb6) Reviewed-on: https://gerrit.libreoffice.org/84577
2019-12-06tdf#128666 Only enable hyperlink actions when just the field is selectedSamuel Mehrbrodt1-11/+4
Change-Id: I984df967877a47fb9f89c3626737348a87d3ffa5 Reviewed-on: https://gerrit.libreoffice.org/84418 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit f31c3ebb60e4678eb09e377b638b368531df47dc) Reviewed-on: https://gerrit.libreoffice.org/84571
2019-12-06tdf#128466: Accept also JPEGTor Lillqvist1-1/+1
Change-Id: If8499cde875e03cb6c56259badd64ba6aee08a66 Reviewed-on: https://gerrit.libreoffice.org/82584 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 7dba640b5691c22d6529e53752255fddc2b461e6) Reviewed-on: https://gerrit.libreoffice.org/82618 Tested-by: Jenkins (cherry picked from commit 3adb591bc632854dc9f0af0c8498ae45171080a7) Reviewed-on: https://gerrit.libreoffice.org/84524
2019-12-05lok: calc - store zoom in the view itself.Michael Meeks1-0/+7
Don't duplicate this on the ITiledRenderable interface, which is not a per-view construct, this just confuses everything. Store & restore the zoom level before/after rendering a tile - unfortunately this is not done by the most optimal view yet. Change-Id: I1f7dfaa353333f45c5601d49a9bca784d34fb81a Reviewed-on: https://gerrit.libreoffice.org/84281 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 3b7661cda1c910524a2c4e3394417971fa025f31) Reviewed-on: https://gerrit.libreoffice.org/84303
2019-11-22tdf#47490: Show overwrite warning when pasting data using "Enter"Aditya1-1/+1
In Calc when a cell is copied and its value is filled/pasted to different cell(s) by using the "Enter" key when focus is on selected cells -- replace warning is not shown even if the selected cells have values of their own inside it. The old data is simply lost. Provide a replace warning dialog box whenever such a case is encountered. Change-Id: I13acb424bc449e096512b5a0864ebc47a407f234 Reviewed-on: https://gerrit.libreoffice.org/83333 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 844b4ac41009143092ef08f163783d48dfbe9b77) Reviewed-on: https://gerrit.libreoffice.org/83450 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-19Related: tdf#125917 remove active editing when we want to replace contentsCaolán McNamara1-0/+5
this addresses comment #6 so that the chosen value is entered in the cell Change-Id: I3b45301e00b2f79038e88c926f15babd49dcc2bf Reviewed-on: https://gerrit.libreoffice.org/83167 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-09 23:44:03 +0000