summaryrefslogtreecommitdiff
path: root/sc/source/ui/view
AgeCommit message (Collapse)AuthorFilesLines
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek6-8/+8
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-08skip hidden rows/columns for spellchecking, tdf#99607Markus Mohrhard1-2/+22
Change-Id: Ic84368f4bb70973c3c5f5293d852fc573c5f73f7 Reviewed-on: https://gerrit.libreoffice.org/29601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-07loplugin:staticmethods: scStephan Bergmann2-2/+2
Change-Id: I7fb92d55a48e1a79568a25002bf17155b8f387b4
2016-10-06Resolves: tdf#76836 use text format only for text contentEike Rathke1-5/+3
Numeric content is not to be formatted with the text format. Entering a value in such formatted cell still forces it to text content as usual and then it is displayed using the text format. The previous behavior displaying also numeric content using the text format was always wrong and neither Excel nor Gnumeric do it. A numeric content is displayed left aligned though, which also Excel does. Change-Id: I3038123b2bfdc4669a8f73840742da92a1df895d
2016-10-06LOK: Calc: page-up/down - cursor moves far more than a pageMarco Cecchetti1-2/+9
Change-Id: I1253044f26553dab08bc2a38c706f634e9377c86 Reviewed-on: https://gerrit.libreoffice.org/29578 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-05sc lok: add .uno:AutoSumHenry Castro2-0/+186
Change-Id: Id2bc0200734308aae1c2e39814c22c6b76664c59 Reviewed-on: https://gerrit.libreoffice.org/29525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-10-05convert MapUnit to scoped enumNoel Grandin20-76/+76
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann11-23/+23
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03loplugin:vclwidgetsCaolán McNamara1-2/+1
Change-Id: If31494809ba8ce0028a15a88cf1bb2ead2769701
2016-10-03LOK: Calc: clear cell background in other views on editingMarco Cecchetti1-24/+15
Change-Id: Ia61bcdf7db0994b6681607403c56be707a9f17d9 Reviewed-on: https://gerrit.libreoffice.org/29456 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> (cherry picked from commit 1922c8b1d46e0067ed21a18d249f04da6f3b0160) Reviewed-on: https://gerrit.libreoffice.org/29489
2016-10-03Calc LOK: clear cell background when editing in parallelAshod Nakashian1-10/+10
Change-Id: Id8eccf00ec6555d62c49e06130e3aa3a0eaaddea Reviewed-on: https://gerrit.libreoffice.org/29450 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit b16ba7314ef93b657dea4d6dd676b2dfd265bcaa) Reviewed-on: https://gerrit.libreoffice.org/29486 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03Calc: fixed bug in parallel cell editingMarco Cecchetti2-40/+43
The background color by the wrong edit view was used causing a segmentation fault. Change-Id: Ife489989e382d6f4f905f0ca305928e64bbce588 Reviewed-on: https://gerrit.libreoffice.org/29415 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03Calc: implemented parallel cell text editingMarco Cecchetti4-1/+316
Change-Id: If8cc7a637cee6ba66813d55b25160fee13a2a219 Reviewed-on: https://gerrit.libreoffice.org/29410 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03Calc: edit engine could be accessed after being destroyedMarco Cecchetti1-1/+6
ScTabView <---------------- ScTabViewShell +ScViewData +ScInputHandler +EditView[4] +EditEngine +ImpEditEngine +vector<pointer<EditView>> On tab view shell destruction: ~ScTabViewShell -> ~ScTabView -> ScViewData::KillEditView -> EditEngine::RemoveView but it occurs after the following: ~ScTabViewShell -> ~ScInputHandler -> ~EditEngine since data members are destroyed before ancestor classes. Change-Id: Ida56b8009c0d8a3cd23952259d78318e96ae5124 Reviewed-on: https://gerrit.libreoffice.org/29409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03LOK - when a view is enabled, the existing edit views are killedMarco Cecchetti2-5/+28
A view is notified about killing its own edit view, if any, in 4 cases: - before being deactivated - soon after being activated - when a 'cursor position changed' event occurs in any view - when a 'selection changed' event occurs in any view Now these notifications are skipped when LOK is active. Change-Id: I94020987a35b1450ec41e2fa5fcce8cfa7e92130 Reviewed-on: https://gerrit.libreoffice.org/28948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03add more dumpAsXml()Noel Grandin1-0/+2
and make it format the output nicely, so I don't have to use 'xmllint --format' before I can read it. Change-Id: I065ee93193f3c6c7bab87212ab96021fb0d7c5ed Reviewed-on: https://gerrit.libreoffice.org/29407 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01avoid coverity#1371264 Missing move assignment operatorCaolán McNamara1-3/+1
Change-Id: I5085b0a04cf24b8d4678165371e44dc3556300e3
2016-09-29LOK: conditionally include part number in invalidation payloadMiklos Vajna2-3/+5
Since desktop/ code queues, compresses and only emits callbacks on idle, it's possible that two invalidations are in the queue, and there was a setPart() call between them. In this case it's impossible to tell what part the invalidation was sent for. Fix this by conditionally including the part number in the invalidation payload. It's off by default, a new feature flag is added to request this behavior. gtktiledviewer enables this feature flag by default, though just to show the part number in the debug output. Android doesn't enable it. Change-Id: I73e6def848c0eb61d64e71026002c7a0e750aab4
2016-09-29only date autofilter menus need the space for the tree expandersCaolán McNamara1-0/+1
so for lists that don't include dates then drop the tree view bits to save space to the left of the entries Change-Id: I44f624d8a06d578674806813239a408466c87d70
2016-09-26convert PAINT constants to typed_flagsNoel Grandin12-72/+71
Change-Id: Ie0a02c87ca225ee7a8b8e76a2498836836e79c82
2016-09-26convert CR flags to typed_flags_setNoel Grandin3-10/+10
Change-Id: I20f602eedc72581e22f18c514d8f406690844c28
2016-09-26convert HASATTR constants to typed_flags_setNoel Grandin10-25/+25
Remove unused constant RTL. Inline PAINTEXT constant since it is only used in one place. Change-Id: I7b2c15e7579fc5bc475d00fe714f17592bd5e2a1
2016-09-26convert BREAK constants to typed_flags_setNoel Grandin5-21/+21
Change-Id: I33edff5feca07ed891df4c6c4dbc470748c4f4b4
2016-09-25handle the debug output earlierMarkus Mohrhard1-23/+25
Change-Id: I4a47fd063ca9f57d6f5d38abcc84e21899f28876 Reviewed-on: https://gerrit.libreoffice.org/29259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-25tdf#101390 Add Arrows toolbox functions on calc drawingbar.Gulsah Kose1-0/+14
Calc arrows toolbox includes following commands .uno:LineArrowEnd .uno:LineCircleArrow .uno:LineSquareArrow .uno:LineArrows .uno:LineArrowStart .uno:LineArrowCircle .uno:LineArrowSquare .uno:Line Change-Id: I09c93447baeafd3f7d4993117458d4585d21cbaf Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-09-23convert formula error codes to scoped enumNoel Grandin4-12/+12
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb Reviewed-on: https://gerrit.libreoffice.org/28897 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke12-137/+137
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-22rename GetId() to GetTablesHintId() and GetIndexHintId()Eike Rathke1-2/+2
In preparation of moving SfxSimpleHint that has GetId() to SfxHint. Change-Id: If781ba9578931d9543875ee288ce37c727bfba10
2016-09-20sc draw: emit LOK_CALLBACK_GRAPHIC_VIEW_SELECTION when view is createdHenry Castro2-5/+29
In multiple view environment, when a new view is created ensure to notify other views graphic view selections. Change-Id: If75f9525af6e851e096b6d273957b94882c441cf Reviewed-on: https://gerrit.libreoffice.org/29094 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-19tdf#96453, tdf#100793 rework transfer of data between cond format dlgsMarkus Mohrhard2-67/+54
The xml based transfer of information was a bad idea from the start. It can obviously not transport the temporary conditional format information from the manager dialog. Therefore the whole handling here was completely broken and deleted formats came back, changed formats were not saved and added formats got applied directly to the document. Now the document fornat list and the one from the manager are indepedent again and as long as the manager has not been closed with ok nothing is written to the document. Change-Id: I9802be11cd15c2d2d877e55c91d836735fe0e0ff Reviewed-on: https://gerrit.libreoffice.org/28995 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-18fix indentationMarkus Mohrhard1-3/+2
Change-Id: Iab226c47b63253bc8d0876af861e3e4731ff1ce2 Reviewed-on: https://gerrit.libreoffice.org/28993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-15disable generation of ole previews in ODF format until after loadCaolán McNamara1-1/+1
so the user update links dialog can control their generation SdrEmbedObjectLink becomes exposed to calc so it can detect if the link dialog needs to be used to update ole links. Change-Id: Id1dd7ea17342140eab9307d546528747e3a98090 Reviewed-on: https://gerrit.libreoffice.org/28879 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann1-2/+2
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-10loplugin:constantparam in scNoel Grandin4-9/+9
Change-Id: I82c78dd880c98532db407b0183a43705be2de67c Reviewed-on: https://gerrit.libreoffice.org/28777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09loplugin:constantparam in svtoolsNoel Grandin1-1/+1
Change-Id: I04caae0c9ae621c55e16d3bdc014a4729617feb3 Reviewed-on: https://gerrit.libreoffice.org/28757 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-05convert Orientation to scoped enumNoel Grandin1-1/+1
Change-Id: Ifbfcf3557ca2a16d21e7a1d613ee54c1c6625f07
2016-09-05convert ScrollType to scoped enumNoel Grandin1-7/+7
Change-Id: I6dd02d4f7df028dada6cfd5d767a6ec1b1c1efe1
2016-09-05convert GradientStyle to scoped enumNoel Grandin1-1/+1
Change-Id: Ib740da708612df7a5f4b8c82262b9b1bd436604d
2016-09-05convert LineStyle to scoped enumNoel Grandin1-1/+1
Change-Id: I30cfa5a0649b806604c443f55683d1f2a430983d
2016-09-04Restore the toggle state of the currency buttonMaxim Monastirsky1-11/+1
Change-Id: Ibe7d8b183038c4a925282ccab1b637342a714712
2016-09-01sc lok: implement SfxViewShell::NotifyCursor() APIMiklos Vajna2-5/+25
This way a new Calc view gets the cell cursors of existing views even if they don't move after registering the LOK callback in the new view. Change-Id: I5babc9921d37217ac199d4c19ed33cbb9620d119 Reviewed-on: https://gerrit.libreoffice.org/28581 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-01use IsStaticDefaultItem from poolitem.hxx instead of custom checksJochen Nitschke1-2/+2
Change-Id: Ic49a940d83e5b8944bd724203bb2045bb1eb22b9 Reviewed-on: https://gerrit.libreoffice.org/28567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-31let's make Impress crash less - SfxStyleFamily editionMichael Stahl1-2/+2
Commit bcb41235deaf4b7ca90522bda3ba21a686819e6e - in addition to introducing the enum SfxStyleFamily - inconsistently converted one call of DrawDocShell::SetStyleFamily to use enum SfxStyleFamily instead of a mysterious "5", but did not adapt all of the code that extracts the SfxUInt16Item that subsequently extracts this value and expects a number 0-5. Since it's clearly inexcusably stupid to have 2 different public sets of integers identifying styles, make the usage of the second "array index" integers private to templdlg.cxx; the SfxUInt16 item now always contains enum SfxStyleFamily. (regression from bcb41235deaf4b7ca90522bda3ba21a686819e6e) Change-Id: I333575c504277c2046f8f5a6b36ae3f86b3b3201
2016-08-30Translate some German comments and messagesMaarten Bosmans1-1/+1
Change-Id: Id15e1afd991f3476e260ba40a8c45c7261113577 Reviewed-on: https://gerrit.libreoffice.org/28493 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (sc)Stephan Bergmann1-1/+1
Change-Id: I41af3d6acdb5dfdaa27febf99cc3c5aa031ad779
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann2-2/+2
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-24convert SvxNumberValueType to scoped enumNoel Grandin1-9/+9
Change-Id: Ic82c18c16de8bd756a444de47c9a68e88fa1c7ee
2016-08-24convert OverlayType to scoped enumNoel Grandin1-6/+6
Change-Id: Ic7758ec96bdf7f532b5b95048dbb7eb5f360f74a
2016-08-23sc lok: fix re-sizing several rows/columns at onceHenry Castro1-2/+20
Change-Id: I7b3760432aa4b3120bfd586a1abc42a46fff0df8 Reviewed-on: https://gerrit.libreoffice.org/28351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-08-23convert SearchLabel to scoped enumNoel Grandin1-4/+4
Change-Id: I0c62a3166b9284895f119c600776dc2c7d6d1078
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-25 05:36:35 +0000