summaryrefslogtreecommitdiff
path: root/sc/source/ui/view/output2.cxx
AgeCommit message (Collapse)AuthorFilesLines
2018-06-21tdf#66089 tdf#105720: only rely on bPixelToLogicAron Budea1-8/+6
Left-aligned currency symbols were put in preceding cells sometimes, because fill width was calculated incorrectly. Commit 37210da00a9190f7765fa9c1e4a08629d2f4c2c4 fixed the issue for LOK, but the bug was still reproducible in Calc if setting "Use printer metrics for text formatting" was enabled. Change-Id: I6cf90493cbf98c5020acd5faf1d0f3cf2def5c25 Reviewed-on: https://gerrit.libreoffice.org/56172 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 93e9a3e2b545c853f53ffe28d2795f55ad29f304) Reviewed-on: https://gerrit.libreoffice.org/56213 Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-18tdf#105720: lok: sc: currency symbol is displayed in the preceding cellMarco Cecchetti1-2/+11
Now in online the currency symbol is placed exactly as in the desktop case. Essentially there was a mapping issue. Change-Id: I6175cfeab3d8bc3a757c8522aa9c7a7e49c4bf2b Reviewed-on: https://gerrit.libreoffice.org/55800 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-11-24consistently use sal_uInt32 for number formats in scNoel Grandin1-2/+2
instead of a mix of short/sal_uLong/sal_uInt32 Change-Id: Ie5bd26e1a6f716c0c4e174a6d560827084b3f421 Reviewed-on: https://gerrit.libreoffice.org/45159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23TypedWhichId create custom get methods in ScPatternAttrNoel Grandin1-48/+48
Change-Id: Iaa326332f5806477dd81463e6b6004a962bac934 Reviewed-on: https://gerrit.libreoffice.org/45128 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Follow our naming conventions, tdf#39593 follow-upEike Rathke1-11/+11
Change-Id: Iee95b5bf0dd42169447163a41be5b2aa1899e83c
2017-11-22tdf#39593 deduplicate code in ScOutputDatatagezi1-139/+39
Change-Id: Ie7efcdf23e65b2047af7972756c2ba11cc178672 Reviewed-on: https://gerrit.libreoffice.org/45064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-19Typos about "bottom"Julien Nabet1-1/+1
Change-Id: I8fec1f12d5f8330cd54da3e219268bf4e0b4c213 Reviewed-on: https://gerrit.libreoffice.org/44932 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-17TypedWhichId for EE_CHAR* constantsNoel Grandin1-3/+3
Change-Id: I261f8a949ddd858dee196118bb42993a101a2a28 Reviewed-on: https://gerrit.libreoffice.org/44829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15TypedWhichIdNoel Grandin1-2/+2
use a strong-typedef template to give which IDs a type, which we can carry around to do a (a) little bit more convenience when Get()'ing them and (b) a little bit of enforcement of which PoolItem subclass each ID uses Fix a bug in casting EE_PARA_BULLETSTATE to the wrong subclass in AccessibleEditableTextPara::_correctValues Change-Id: I015ce8b3b0f6d21308af182afa3caf122c877a5b Reviewed-on: https://gerrit.libreoffice.org/44587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: scStephan Bergmann1-17/+17
Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd
2017-09-15convert SvxCellVerJustify to scoped enumNoel Grandin1-46/+46
Change-Id: I9d1cdb4ddfee43b7a0990624d7d16e06679343c4 Reviewed-on: https://gerrit.libreoffice.org/42276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14improve redundantcast lopluginNoel Grandin1-5/+5
to find c-style casts where the expression is a templated method Change-Id: Ifbd1e2cdc72d906fc95a7ec0f9408c3f6d2a836b Reviewed-on: https://gerrit.libreoffice.org/42275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14convert SvxCellOrientation to scoped enumNoel Grandin1-53/+53
Change-Id: Ia4c75c6394b47805f24a7daca593e0074a8ddf0b Reviewed-on: https://gerrit.libreoffice.org/42268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-11cppcheck: knownConditionTrueFalse 'bClip' is always trueJochen Nitschke1-31/+21
always true since initial import in year 2000 Change-Id: I66596f50580d2db29b5aee0617164a56e8635806 Reviewed-on: https://gerrit.libreoffice.org/42146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-26loplugin:constparam in sc part7Noel Grandin1-6/+6
Change-Id: Ica5421ddc343ce18a08f993778f42183b571ed0e Reviewed-on: https://gerrit.libreoffice.org/41578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28borderline: adaptions to primitivesArmin Le Grand1-1/+3
Handling and paint of borderlines greatly adapted to primitive usage. Solved the double paint mechanisn to no longer use the sc-local special cases. The svx tooling for borderline paint is now the only one and was extended to also handle diagonal lines. Big cleanups/removals of old paint to OutputDevice and sc-specific rendering. All other app-usages of borderline also adapted. Preparations for careful line-start/end adaption prepared and possible due to unified coordinate-system usages and basegfx class-usage Change-Id: If9e4efcfc0fe25e14d4052907038ca5cf222a432
2017-06-28loplugin:unusedfields in sc part1Noel Grandin1-6/+1
in ScNavigatorDlg::ScNavigatorDlg, we replace the assignment of nAreaId with an assignment to nDataId instead, which is never initialized but used, whereas nAreaId was initialized but never used. Change-Id: I9681af7f7d515d4891c9b52d3809e88e3d5e8256 Reviewed-on: https://gerrit.libreoffice.org/39062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26loplugin:oncevar in scNoel Grandin1-4/+2
Change-Id: Ice59e286debb6bd0eb692f2b2b0c2c5087c069c0 Reviewed-on: https://gerrit.libreoffice.org/39239 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock1-8/+8
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert sc module away from OSL_ASSERT to assertChris Sherlock1-8/+8
Change-Id: Iead653868ea7e0d1ed4ba83ef1a46e1ae5874d13
2017-04-24clang-tidy readability-simplify-boolean-expr in scNoel Grandin1-7/+2
Change-Id: I702e52e56487f201b9e0d7af21ff8167464aa58c Reviewed-on: https://gerrit.libreoffice.org/36876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06tdf#39468 Translate German commentsJens Carl1-8/+8
Translate German comments and terms in sc/ Change-Id: I93c7cf423325715435910a89420e7522b440c81e Reviewed-on: https://gerrit.libreoffice.org/36192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna1-17/+17
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-25Fix typosAndrea Gelmini1-2/+2
Change-Id: I4e1a613fc99b931e84a1955695364e1d25e25e5c Reviewed-on: https://gerrit.libreoffice.org/35642 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-15convert SvxFrameDirection to scoped enumNoel Grandin1-2/+2
Based on the casts in chart2/source/view/main/ChartView.cxx and the similarity of naming of values, I conclude that this enum was intended to abstract over css::text::WritingMode2. Added a comment to that effect. Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57 Reviewed-on: https://gerrit.libreoffice.org/35164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14sc: change nDirection type to enumJochen Nitschke1-1/+1
Change-Id: Icaa71f99de7c97d1a9601ad00d2a6b0dbe8dae14 Reviewed-on: https://gerrit.libreoffice.org/35130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-09convert SvxCellHorJustify to scoped enumNoel Grandin1-81/+81
Change-Id: I0dd88b5bf9e1aededfa2d94b6b2d3d26694fff33 Reviewed-on: https://gerrit.libreoffice.org/34968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert SvxAdjust to scoped enumNoel Grandin1-19/+19
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639 Reviewed-on: https://gerrit.libreoffice.org/34941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25loplugin: unnecessary destructor scNoel Grandin1-5/+0
Change-Id: I877bc0927aff7d175c1978fdf3db55d2e048d3b9 Reviewed-on: https://gerrit.libreoffice.org/33510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-21coverity#1399019 Division or modulo by zeroCaolán McNamara1-0/+3
Change-Id: I0f21612effa91a6c9e7e0a48c46dde88c4b34b94
2016-10-19loplugin:expandablemethodds in scNoel Grandin1-2/+1
Change-Id: Idda64b23ea91ec457b60279d851b7f01d8c02881 Reviewed-on: https://gerrit.libreoffice.org/30033 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12convert SC_CLIPMARK constants to typed_flags_setNoel Grandin1-6/+6
Change-Id: Ibdfe3c46da35b96b040f02a167d35651502a65ef
2016-10-12convert SC_ROTDIR constants to scoped enumNoel Grandin1-2/+2
Change-Id: Ia726ce9e9fcfe9a8b5bc4057f0176edf10b6ab3f
2016-10-06Resolves: tdf#76836 use text format only for text contentEike Rathke1-5/+3
Numeric content is not to be formatted with the text format. Entering a value in such formatted cell still forces it to text content as usual and then it is displayed using the text format. The previous behavior displaying also numeric content using the text format was always wrong and neither Excel nor Gnumeric do it. A numeric content is displayed left aligned though, which also Excel does. Change-Id: I3038123b2bfdc4669a8f73840742da92a1df895d
2016-09-26convert CR flags to typed_flags_setNoel Grandin1-5/+5
Change-Id: I20f602eedc72581e22f18c514d8f406690844c28
2016-09-26convert HASATTR constants to typed_flags_setNoel Grandin1-3/+3
Remove unused constant RTL. Inline PAINTEXT constant since it is only used in one place. Change-Id: I7b2c15e7579fc5bc475d00fe714f17592bd5e2a1
2016-09-23convert formula error codes to scoped enumNoel Grandin1-1/+1
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb Reviewed-on: https://gerrit.libreoffice.org/28897 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-08-17convert SvxCellJustifyMethod to scoped enumNoel Grandin1-3/+3
Change-Id: Ifdb9192f6556477a28af05a74042f216d4e9e8fd
2016-05-25Convert SC_MF to scoped enumNoel Grandin1-6/+6
Change-Id: I3089006b502e33710bfb2564f051ebf2892ad08a Reviewed-on: https://gerrit.libreoffice.org/25085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin1-2/+0
Change-Id: I7113a13ac36db5beef3a17e9849c1f5506df2374 Reviewed-on: https://gerrit.libreoffice.org/25194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12if we can't use assert() as intended then use SAL_WARN()Eike Rathke1-2/+2
Change-Id: I5b8d4a8054fb2cfbab2b762371e52fac73cf5e55
2016-05-12Revert "Silence -Werror,-Wimplicit-fallthrough under NDEBUG"Eike Rathke1-4/+4
This reverts commit 1d54b93670ac2c40661e3890ecea987d334cba31. Calling abort() here was not the intention.
2016-05-12Silence -Werror,-Wimplicit-fallthrough under NDEBUGStephan Bergmann1-4/+4
Change-Id: If2fc8dd5a3b2dab2f1b3654dbdb42e112ff64347
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann1-0/+1
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-04-22Avoid reserved identifiersStephan Bergmann1-4/+4
Change-Id: I782784f34975d708fdf179d098ce6654aad7a976
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock1-2/+2
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-29vcl: add text alignment functions to ImplFont and FontAttributesChris Sherlock1-1/+1
ImplFont and FontAttributes now have GetAlignment and SetAlignment, and I have renamed Font::GetAlign to Font::GetAlignment, and Font::SetAlign to Font::SetAlignment. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit test added to vcl/qa/cppunit/font.cxx to test text alignment. Change-Id: I6272c84fc9416c90616d957d1897eba9469fe7ba Reviewed-on: https://gerrit.libreoffice.org/21876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-20nitpicks, tdf#96822 follow-upEike Rathke1-2/+3
Change-Id: Ic745433a870c70c09afa953a4ebef86f4363f9f4
2016-01-20tdf#96822 : Make cell contents left align when number formatting is textYogesh Desai1-7/+21
Change-Id: I9754db93f4cf71a6001d5b3f39ee2bc2b01889cc Reviewed-on: https://gerrit.libreoffice.org/21134 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-13vcl: Create accessor and mutator for int and ext leading in FontMetricChris Sherlock1-2/+2
Accessor and mutator created for external and internal leading space in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set external and leading space - check equality operator on FontMetric after setting both external and internal leading space - enhanced tests to also check the inequality operator Change-Id: I973970dd0b0631c5eca3e89039dce57ac3a3eb63 Reviewed-on: https://gerrit.libreoffice.org/21454 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 16:28:02 +0000