summaryrefslogtreecommitdiff
path: root/sc/source/ui/view/gridwin.cxx
AgeCommit message (Collapse)AuthorFilesLines
2016-10-08skip hidden rows/columns for spellchecking, tdf#99607Markus Mohrhard1-2/+22
Change-Id: Ic84368f4bb70973c3c5f5293d852fc573c5f73f7 Reviewed-on: https://gerrit.libreoffice.org/29601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-05convert MapUnit to scoped enumNoel Grandin1-5/+5
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann1-4/+4
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-01avoid coverity#1371264 Missing move assignment operatorCaolán McNamara1-3/+1
Change-Id: I5085b0a04cf24b8d4678165371e44dc3556300e3
2016-09-29only date autofilter menus need the space for the tree expandersCaolán McNamara1-0/+1
so for lists that don't include dates then drop the tree view bits to save space to the left of the entries Change-Id: I44f624d8a06d578674806813239a408466c87d70
2016-09-26convert PAINT constants to typed_flagsNoel Grandin1-6/+6
Change-Id: Ie0a02c87ca225ee7a8b8e76a2498836836e79c82
2016-09-26convert HASATTR constants to typed_flags_setNoel Grandin1-3/+3
Remove unused constant RTL. Inline PAINTEXT constant since it is only used in one place. Change-Id: I7b2c15e7579fc5bc475d00fe714f17592bd5e2a1
2016-09-25handle the debug output earlierMarkus Mohrhard1-23/+25
Change-Id: I4a47fd063ca9f57d6f5d38abcc84e21899f28876 Reviewed-on: https://gerrit.libreoffice.org/29259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann1-2/+2
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-01sc lok: implement SfxViewShell::NotifyCursor() APIMiklos Vajna1-5/+16
This way a new Calc view gets the cell cursors of existing views even if they don't move after registering the LOK callback in the new view. Change-Id: I5babc9921d37217ac199d4c19ed33cbb9620d119 Reviewed-on: https://gerrit.libreoffice.org/28581 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-24convert OverlayType to scoped enumNoel Grandin1-6/+6
Change-Id: Ic7758ec96bdf7f532b5b95048dbb7eb5f360f74a
2016-08-19loplugin:countusersofdefaultparams in scNoel Grandin1-4/+4
Change-Id: I4052af7a19616d33c3c5fda9650d8fc4dff32256
2016-08-11loplugin:constantparamNoel Grandin1-3/+3
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-02Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with altCaolán McNamara1-0/+6
this returns things to passing the alt to the thing with the focus and depends on ::Command handlers passing the alt-press/release back up through the Command hierarchy to get to the default top-level handler eventually Change-Id: I869120f43810adfa2fac4670c2db143b790a1f9b
2016-08-01svl: implement SfxUndoAction::GetViewShellId() interface in SfxListUndoActionMiklos Vajna1-3/+3
Client code in sw, sd, sc and svx is adapted, the rest is just a placeholder for now. With this, e.g. the undo item for Writer's insert comment properly tracks which window was used for the insertion. Change-Id: Idad587e6ca07ba69bf59aa7013b251af8bf95bab Reviewed-on: https://gerrit.libreoffice.org/27781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-01svl: avoid defaulted parameter in SfxUndoManager::EnterListAction()Miklos Vajna1-3/+3
It's a virtual function, and defaulted parameters there are problematic. Change-Id: I3f110c7ac36dfda90811b033620286ad9fce1af1 Reviewed-on: https://gerrit.libreoffice.org/27772 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-26sc: convert SC_SCENARIO_.. defines typed flags ..Jochen Nitschke1-1/+1
ScScenarioFlags add ScScenarioFlags::NONE for 0. replace uses of '-= flag' with '&= ~flag'. Change-Id: I003c0ca1f59b060f52935fec8bb6282fd9981805 Reviewed-on: https://gerrit.libreoffice.org/27464 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-19sc lok: notify other views about selection changes of multiple cellsMiklos Vajna1-0/+2
A single cell is handled by the cell cursor, which was already handled. This one takes care of the situation when multiple cells are selected. Change-Id: I11b3045e4884ad9629655e2c05c16af83d21e7b2 Reviewed-on: https://gerrit.libreoffice.org/27318 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-19sc: convert SC_DROP_* defines to typed flagsJochen Nitschke1-8/+8
flags are stored by ScTransferObj and ScDrawTransferObj in members nDragSourceFlags, implemented in the same way by both classes. set only in ScTabControl::DoDrag() and ScContentTree::DoDrag(). convert to typed_flags ScDragSrc and move flags closer to users, from sc/inc/scmod.hxx to sc/source/ui/inc/viewdata.hxx Change-Id: I15f58a5c828e154114971a1fcf941a3e27acbd56 Reviewed-on: https://gerrit.libreoffice.org/27303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13loplugin:singlevalfields in sc(part1)Noel Grandin1-15/+5
Change-Id: I25760def2c12e4ca87843c2f3ce1a60b5a9b2e44 Reviewed-on: https://gerrit.libreoffice.org/26680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-01sc lok: add LOK_CALLBACK_CELL_VIEW_CURSORMiklos Vajna1-0/+3
So a view can be aware where the cell cursors of other views are. Change-Id: Ifcf06c0019c6af8b859e2e92222e4f3fd18da74f Reviewed-on: https://gerrit.libreoffice.org/26844 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20tdf#96540 dragging between sheets can change the current cursor positionCaolán McNamara1-2/+12
so the at position at time of drop may not be that at the start of the drag. So set the current cursor position to ScTransferObj when the drag starts and retrieve it later Related to: commit ac3b66057ba677903b6de354317417b267be0fa0 Author: Kohei Yoshida <kyoshida@novell.com> Date: Thu Sep 16 11:09:29 2010 +0200 calc-selection-fixed-cursor.diff: Migrated n#502717, i#21869, i#97093, when making selection, don't move the cursor position and commit c433fa0639ccf5caeb0c128c8a3794322e2a1c81 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Fri Jul 6 02:04:44 2012 +0200 adjust the calculation of the cursor pos if ALT is used, fdo#48869 Change-Id: I6316717c860d999270aa7f0fb50af5f6dfc7efd7 I haven't used SetSourceCursorPos everywhere a ScTransferObj is created, just where its created through a drag event Change-Id: I50c36b4a2ba45426edebc1f1dfa5e262db3c5d03 Reviewed-on: https://gerrit.libreoffice.org/26512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20ScFilterListBox::LoseFocus doesn't seem to have a purpose...Caolán McNamara1-6/+0
after the strange code was removed by... commit c3a5012c5a9699040698505d3e34672382c026b8 Author: Caolán McNamara <caolanm@redhat.com> Date: Sun Jun 19 17:42:56 2016 +0100 Related: tdf#99310 data validity cell range dropdown empty under windows Change-Id: Icf6acdb2e5fff90aff45704f17f7918c877e166e
2016-06-19Related: tdf#99310 data validity cell range dropdown empty under windowsCaolán McNamara1-3/+0
if I make this block unconditional then it also disappears under Linux so I speculate that this is why its missing under Windows. I can't see why this is the way it is (since initial import in 2000), This is reportedly a problem since commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves; tdf#87120 no keyboard navigation inside floating windows Change-Id: I6159d419bccef851c8f9e965d063882173d91620
2016-06-18uitest: add wrapper for calc's gridwindowMarkus Mohrhard1-0/+11
It already supports selecting cell ranges. Change-Id: I8c3e4a42dea8956e2429b82b50ff8506c1774bbb
2016-06-18uitest: start annotating a few important non-ui calc windowsMarkus Mohrhard1-0/+1
Change-Id: I504e386eea4249c7b0d69181eb6019a05aa80a74
2016-06-17comphelper lok: remove the g_bViewCallback globalMiklos Vajna1-50/+15
Its purpose was to allow incrementally migrate all callers of SdrModel::libreOfficeKitCallback() to use SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only the currently active or all views) instead. That is done by now, so it can go. Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3 Reviewed-on: https://gerrit.libreoffice.org/26413 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-14sc: implement per-view LOK_CALLBACK_SEARCH_RESULT_SELECTIONMiklos Vajna1-3/+15
One view doesn't crash the other one now when the search is performed. Change-Id: I9ba0a07a76d9c11c4cec279305efb4e5025ec12d Reviewed-on: https://gerrit.libreoffice.org/26263 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-14sc: implement per-view LOK_CALLBACK_INVALIDATE_TILESMiklos Vajna1-8/+32
Port enough callbacks to the view callback, so that gtktiledviewer doesn't crash on opening a file. Change-Id: Iec39608ce3cdf7dcf5a7272f8c9a3415483a8e76 Reviewed-on: https://gerrit.libreoffice.org/26251 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara1-1/+0
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-09convert SfxStyleFamily to scoped enumNoel Grandin1-2/+2
and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
2016-05-07clang-tidy modernize-loop-convert in scNoel Grandin1-10/+7
Change-Id: I620028d69b11ea0469efd7b02ac7bbc7edab1066 Reviewed-on: https://gerrit.libreoffice.org/24690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-04-20clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin1-1/+1
suspect that some of these may reveal latent bugs.... Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71 Reviewed-on: https://gerrit.libreoffice.org/24200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05Resolves; tdf#87120 no keyboard navigation inside floating windowsCaolán McNamara1-8/+0
lets try and treat these the same as we do normal toplevels like dialogs if they popup with GrabFocus. This way focus can be set on widgets inside the floating windows, and so keyboard traversal of widgets etc all works. Change-Id: If447429756cf5d136b9c2e2f62fafb37c167b1ce
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl1-6/+9
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-24loplugin:constantparam in scNoel Grandin1-1/+1
Change-Id: I8608a6cb47972e9b838cc5ea431863348758ded0
2016-03-23loplugin:constantparam in scNoel Grandin1-164/+51
Change-Id: I437367b8c6960db730a69c020ba82792a9170d01
2016-03-12tdf#84938 Change defines to typed_flagsJochen Nitschke1-8/+8
Put defines into an enum class and use typed_flags template from o3tl to give them flag operators. There were some shift operations to apply flags from start references to end references, these went into a helper in address.hxx to hide them. A marco with shift operations in address.cxx was rewritten in two helpers without shifts. One shift remained in ScRange::Format with a comment. The other flag untypical operator was a minus 1 in a helper for ScRefFinder::ToggleRel, which iteratates through all possible combinations for absolute references. This is used to make referecnces absolute via SHIFT+F4. A replacement would be too complex. Change-Id: I4850f1623e01e56c60ac2260b95fc5cad8b6fd71 Signed-off-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-on: https://gerrit.libreoffice.org/22840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-02-28move the cell property dump code into dbgutil buildsMarkus Mohrhard1-29/+4
We now allow with a CTRL+SHIFT+F9 to dump the cell properties as a xml file. Change-Id: I730e7009bbe95d3105541a9afbd2c8a19c992600
2016-02-28tdf#97667 Added a dump method for SfxItemSet in gridwin.cxxJaskaran1-0/+28
This is the first part of solving the task at tdf#97667. The goal is to dump SfxItemSet where our cell properties are stored.Improved it after inputs from moggi.Also I've commented out a few lines in gridwin_dbgutils.cxx That were causing build to fail on jenkins.Once the dump function is moved to the DBG_UTIL Change-Id: I502eaa985b3bf8d296e301d96e42f13d6fd53da5
2016-02-19change all bool bRegExp to utl::SearchParam::SearchType enum, tdf#72196Eike Rathke1-2/+2
Later inspect all places that use utl::SearchParam::SRCH_REGEXP if and how to use utl::SearchParam::SRCH_WILDCARD as well. Change-Id: I6ad4e5dea3cd656fd670f2281aaceec817953211
2016-02-16sc lok: Handle left mouse button up events for tiled renderingPranav Kant1-0/+8
This solves two common problems: 1) Allow selections via mouse drag 2) Deselect when clicked inside already selected block of cells Change-Id: I9c1b5f90b6c4dc6155b14c68852d6cad81e2290a Reviewed-on: https://gerrit.libreoffice.org/22391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-02-16sc lok: Notify LibreOfficeKit of empty selectionPranav Kant1-0/+5
Change-Id: Ib77f2e008473a18460e7783b20ef3237ff885d57 Reviewed-on: https://gerrit.libreoffice.org/22387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-02-05Fix typosAndrea Gelmini1-2/+2
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-13sc: clean up remaining non-static isTiledRendering() usageMiklos Vajna1-9/+9
Change-Id: I546f644e220069904fc2723f953ce2e6e2bfaca3
2016-01-10Fix typosAndrea Gelmini1-1/+1
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-05new loplugin rangedforcopy - use reference in range based forAndrzej Hunt1-1/+4
Inspired by 6e6ae9803796b120e95f6e89575e03c5fd0ed3c2 Change-Id: Ia0f264d3a6bbf076aa5080e3398683e50bc6ef01 Reviewed-on: https://gerrit.libreoffice.org/20190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-22loplugin:unusedfields in scNoel Grandin1-2/+2
Change-Id: Ic801acdd16eded595fdb2a452bbed532b7c9fd65
2015-12-17nConfigId is always 0Maxim Monastirsky1-1/+1
Change-Id: Ic314bc04a22ebf23fa7b06dca06e4d2afae096f9
2015-12-11geez, how about actually checking the Move() error return? tdf#92779 relatedEike Rathke1-4/+8
Handle failure condition where we know how to treat it, i.e. when updating references, assert in all other places that so far silently ignored it and implicitly assumed the failing Move() truncating at bounds would be alright. In case we'll encounter an assertion we'll have to inspect those places and decide what to do about it. Noticed this error with a reference like B1048575 and inserting two rows above, it became B1048576 instead of B#REF! Change-Id: I00757f3ed2e305b591178047933ed60f1533317e
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-11 03:08:25 +0000