summaryrefslogtreecommitdiff
path: root/sc/source/ui/pagedlg
AgeCommit message (Collapse)AuthorFilesLines
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl1-3/+3
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-23loplugin:constantparam in scNoel Grandin1-1/+1
Change-Id: I437367b8c6960db730a69c020ba82792a9170d01
2016-03-22tdf#84938 replace #define with scoped typed_flagsJochen Nitschke1-4/+6
'RangeType' becomes 'Type', goes into ScRangeData and is strongly typed now. This revealed a misuse of RangeType in vbanames.cxx where the uno equivalent was expected, but it had no impact because both values were 0. Change-Id: I0b4764d1411c709a1faa243ec70afeb160410990 Reviewed-on: https://gerrit.libreoffice.org/23415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17sc: remove unused member variableJochen Nitschke1-22/+0
aCmdArr is only set but never used Change-Id: I90b2b954383122696190692890fa1fb6143486f4 Reviewed-on: https://gerrit.libreoffice.org/23306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-12tdf#84938 Change defines to typed_flagsJochen Nitschke1-33/+35
Put defines into an enum class and use typed_flags template from o3tl to give them flag operators. There were some shift operations to apply flags from start references to end references, these went into a helper in address.hxx to hide them. A marco with shift operations in address.cxx was rewritten in two helpers without shifts. One shift remained in ScRange::Format with a comment. The other flag untypical operator was a minus 1 in a helper for ScRefFinder::ToggleRel, which iteratates through all possible combinations for absolute references. This is used to make referecnces absolute via SHIFT+F4. A replacement would be too complex. Change-Id: I4850f1623e01e56c60ac2260b95fc5cad8b6fd71 Signed-off-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-on: https://gerrit.libreoffice.org/22840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-02-28tdf#97963: Impose size limit on all 3 edit windowsKatarina Behrens1-4/+8
Doing it for 1 window (tdf#90257) isn't enough, the dialog will grow outta screen with large fonts not immediately, but on the next opening Change-Id: I890ecd91a00efc4c7596b30a237f5abb4f87215a Reviewed-on: https://gerrit.libreoffice.org/22739 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-12-15Bin silly 'STATIC DATA' commentsTor Lillqvist2-4/+0
Change-Id: I50e3772b7b479d2cf1eb644c7334d0f987874ccb
2015-11-25loplugin:unusedfields in include/sfx2/Noel Grandin2-24/+23
Change-Id: I3eb27ed10e82ee56b33866ac576c1b1f8c9756b9
2015-11-13sc: loplugin:badstatics: remove pActiveEdWnd global variableMichael Stahl2-24/+23
Just use a Link, or rather std::function to set a member in the tab page. Unfortunately loplugin:vclwidgets complains about the new member. Change-Id: Ie2f9cb73c38292d02057d43b12694c6609fa0db8
2015-11-13sc: loplugin:badstatics: _one_ global pActiveEdWnd is enoughMichael Stahl2-7/+5
Change-Id: Idb0eacc8c14b2c56e8255c47c8330e5e6572d5de
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann6-52/+52
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-10-28com::sun::star->css in scNoel Grandin1-5/+5
Change-Id: I7774890f46f9343e944e34db27af8bce3b1d0915
2015-10-19loplugin:defaultparamsStephan Bergmann2-6/+6
Change-Id: I9bfa7be4a8035d6dfbd0bd13505ba13c3d085455
2015-10-16convert Link<> to typedNoel Grandin1-14/+12
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin1-2/+1
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-12convert Link<> to typedNoel Grandin3-13/+8
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-06 tdf#94559: 4th step to remove rtti.hxxOliver Specht4-10/+10
replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-24convert Link<> to typedNoel Grandin1-10/+8
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b Reviewed-on: https://gerrit.libreoffice.org/18825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-23convert Link<> to typedNoel Grandin2-22/+18
Change-Id: Ib0f043cf40f2a1b4b9f0837a5c536994bff3aeef Reviewed-on: https://gerrit.libreoffice.org/18810 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-23convert Link<> to typedNoel Grandin2-4/+2
Change-Id: I245ba9e550c7b833fe184a24b63b55027aeecac9 Reviewed-on: https://gerrit.libreoffice.org/18809 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-18boost->stdCaolán McNamara3-10/+10
Change-Id: I7f3bb094f116103c1146a7d60e3af94c0b37d9ea Reviewed-on: https://gerrit.libreoffice.org/18677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17revert for mac and win unit case crashes after boost->stdCaolán McNamara3-10/+10
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17boost->stdCaolán McNamara3-10/+10
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-09-12Update many ListBox users to its sal_Int32 interfaceMatteo Casalin2-20/+23
Change-Id: I6469ac5e2d17406bee9bc434930e2471cb3bae9f
2015-08-28make PostUserEvent Link<> typedNoel Grandin1-4/+2
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-26Convert vcl Button Link<> click handler to typed Link<Button*,void>Noel Grandin4-17/+7
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-14loplugin: defaultparamsNoel Grandin1-2/+2
Change-Id: Idd291659ca786b7bd2755c8faf98edc51314687b
2015-06-30Fix typosAndrea Gelmini1-1/+1
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann1-6/+6
Change-Id: I700b727c048aff5c19411fb9d5bd9601b296cb06
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin3-7/+15
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-28Rewrite all calls like Dialog(params).Execute()Philippe Jung1-1/+1
Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-25Audit all PostUserEvent calls and instrument for VclPtr.Michael Meeks1-1/+1
Hold a reference on the VclPtr while we're waiting for the UserEvent. Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-22convert POINTER constants to scoped enumNoel Grandin1-1/+1
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-19Typo: SetCharAttriutes->SetCharAttributesJulien Nabet2-2/+2
Change-Id: I889f67f1bc097b171ba416cd07d1a54a0cbc542d
2015-05-13wrap some static fields in VclPtrNoel Grandin2-2/+2
Change-Id: I2df0929d1b34b9ebf2d5d4c27321abdea072007a
2015-05-12Switch VclBuilder constructors to use VclPtr.Michael Meeks1-1/+1
Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
2015-05-11Revert "Switch VclBuilder constructors to use VclPtr."Michael Meeks1-1/+1
Behaves oddly; not ready yet. This reverts commit 9f016bd69422bdfb4cf7c4f5e57356eb98db2d8c. Change-Id: I30d746eac29d1dbe78d3072b10d2e22c051e3f4e
2015-05-11Switch VclBuilder constructors to use VclPtr.Michael Meeks1-1/+1
Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
2015-05-10NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann1-1/+1
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-09tdf#91052 - more macros for 'make' constructors.Michael Meeks1-5/+4
Change-Id: Id05266810760f73db2daba10d1efa14aa9f88dd9
2015-05-08lopluign:staticmethods: Handle DECL_LINKStephan Bergmann1-1/+1
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-08tdf#90257: Prevent dialog from growing out of the screenKatarina Behrens1-0/+6
when large font sizes are used. Set size request on 1 edit widget (+- match what used to be in the old .src file), the remaining two are in the same grid, so this will hopefull do the trick Change-Id: I3ca27ea4d037cf8877f022c1ee5ed7f348b0cfdd
2015-05-07convert PUSHBUTTON_DROPDOWN constants to scoped enumNoel Grandin1-1/+1
Change-Id: Iae363b8478ef2d560ae661af06ba989f27adc093 Reviewed-on: https://gerrit.libreoffice.org/15650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-05Use typed Idle::SetIdleHdl LinkStephan Bergmann1-4/+3
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-02Audit LoseFocus - forms, reportdesign, sc, starmath, svtools.Michael Meeks1-0/+3
Change-Id: If7068e59c88e8c3c3bafc70f64899a26d739e331
2015-04-30Gradually typed LinkStephan Bergmann1-2/+2
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-29fix compile: delegate RenderContext parameter to superTomaž Vajngerl1-3/+3
Change-Id: I1c08e29c45d8334db52b129a957098481f3e57a4
2015-04-29mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&)Tomaž Vajngerl1-1/+1
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
2015-04-28Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks5-15/+100
Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28SfxTabPage::DeactivatePage wants to return SfxTabPage::sfxpgStephan Bergmann2-2/+2
Change-Id: Iba538bb51635e6cae1e033d14e8da3dabfb36634