summaryrefslogtreecommitdiff
path: root/sc/source/ui/optdlg
AgeCommit message (Collapse)AuthorFilesLines
2021-03-09defer getting toplevel for color picker until we need itCaolán McNamara2-5/+10
Change-Id: I60f4ded47f7d80b397647ea3344e83a5dfd1b11e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-18tdf#34686 calc: add option to disable paste with enter keyMartin van Zijl1-0/+11
Change-Id: Ie20a8931a16f6609ac5be23032a0b2e3a7ad1784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95627 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-11-01use officecfg for Experimental flagNoel Grandin1-2/+2
move IsShowOutlineContentVisibilityButton out of header to avoid having to add extra include paths to all the unit test makefiles. Change-Id: I2763390e07cd85b8f09b6f2ad7702039daecb22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-15establish that ScViewData::GetDocument can always return ScDocument&Caolán McNamara1-1/+1
we can only be ctored with a ScDocShell& or ScDocument&, and ScDocShell provides a ScDocument& from its GetDocument() so we can always have a ScDocument& when a public ctor has completed some null checks can then be seen to be redundant and are removed Change-Id: Ifaf39cb06e8dbce363999c05ee0aeb3ec4f00428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102775 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15ScRangeUtil::IsAbsPos ScDocument* arg dereferenced on all branchesCaolán McNamara1-1/+1
Change-Id: Ie42e6eb280886c237b7042948298eef0bd38eebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15ScRangeUtil::IsAbsArea ScDocument* arg dereferenced on all branchesCaolán McNamara1-1/+1
Change-Id: Ie83a42db769b45f6d64d0c2b7fda58216efc36c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102718 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-09loplugin:flatten in scNoel Grandin1-15/+15
Change-Id: Iedb6ca37d1b006131d1fc77eca3303a12ccb60c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100401 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: scStephan Bergmann1-1/+1
Change-Id: Ie2d2d26bac69f4b228eadef712b06b665b3974eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97650 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-25clang-format sc with under 5-percent lines of changeMuhammet Kara1-2/+2
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I2d37d9c94116d2823f9a21024bdb7ff1a6207d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94744 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-22ScGlobal - change direct access to a static ptr for a getterTomaž Vajngerl1-1/+1
pLocalData and pCharClass static veriables on ScGlobal are always set from SvtSysLocale on init, probably for "faster" access. This can just be made simpler with access through a getter, so this introduces a getter for ScGlobal::getCharClassPtr and ScGlobal::getLocaleDataPtr, where the access is made directly to SvtSysLocale instance. In addition all the usages needed to be fixed, which is all over the calc module. Change-Id: Ie047b158094e25bbaa2aba15074d7998d9541787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89249 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-20Resolves: tdf#129501 cannot change formula separators in optionsCaolán McNamara1-21/+30
Change-Id: I5cf5736f8ad3d5e28f2c31ffa88dafac59df8a8e Reviewed-on: https://gerrit.libreoffice.org/85587 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-27sc: rowcol: tdf#50916 add UI to turn jumbo sheets onNoel Grandin1-1/+10
Change-Id: I9e50c38f38acdf5a275b125e9e421a6c6af6d590 Reviewed-on: https://gerrit.libreoffice.org/83661 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-14cid#1455325 establish that pDoc cannot be null thereCaolán McNamara1-1/+1
Change-Id: Ia7bca1e74a8ede90e29ec6cbd63c7fdcaf25b072 Reviewed-on: https://gerrit.libreoffice.org/82696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17Rename OUStringLiteral1 to OUStringCharStephan Bergmann1-2/+2
It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-03drop some unnecessary includesCaolán McNamara1-0/+1
Change-Id: Ia388aef3063c99f3b0d9282f53e78edfda5ce4bb Reviewed-on: https://gerrit.libreoffice.org/80085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01tdf#119021 Support lock down settings of Formula tab pageGabor Kelemen2-0/+17
Change-Id: I3131e8fd98b43cf4073970444589e8fae9553bc1 Reviewed-on: https://gerrit.libreoffice.org/75402 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-09-26TODO rename to GetFrameWeldCaolán McNamara3-7/+7
Change-Id: I28527b6773075fe682682a4812cf86bb7ac13180 Reviewed-on: https://gerrit.libreoffice.org/79560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26now drop TabPageParent intermediateCaolán McNamara8-41/+41
Change-Id: I47328f76342ac023628d9042bdfa8213a1c93d0c Reviewed-on: https://gerrit.libreoffice.org/79469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26disinherit OWizardPage and SfxTabPage from vcl TabPageCaolán McNamara8-34/+22
Now that there's no need to support weld/unwelded mixes of pages in dialog any more. inherit from a BuilderPage which contains a Builder and Toplevel container BuilderPage Activate and Deactivate replace TabPage ActivatePage and DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and DeactivatePage. Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812 Reviewed-on: https://gerrit.libreoffice.org/79317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24set correct parentCaolán McNamara3-7/+7
Change-Id: I133cccc72896021c38f90efa3f9819fd5410d836 Reviewed-on: https://gerrit.libreoffice.org/79419 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23config dialog uses a controller nowCaolán McNamara1-1/+1
Change-Id: I0341b0b51d638b5ea8f28d16dca87d50376873a4 Reviewed-on: https://gerrit.libreoffice.org/79417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17weld ScTpUserListsCaolán McNamara1-213/+191
Change-Id: I3686b038aabf0b7fa132a5172cbabb667265fe64 Reviewed-on: https://gerrit.libreoffice.org/79069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-31drop some unnecessary includesCaolán McNamara1-1/+0
Change-Id: Ic3ccc7f0e93258cce30a42c71011154bc9313f52 Reviewed-on: https://gerrit.libreoffice.org/78343 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScRedlineOptionsTabPageCaolán McNamara1-24/+23
Change-Id: I80151384f5e75eac08665f45ce87468e10fb987e Reviewed-on: https://gerrit.libreoffice.org/76553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpContentOptionsCaolán McNamara1-191/+163
Change-Id: Ia0ad05337ae3195e565e4b913cdf34e9a32e9cea Reviewed-on: https://gerrit.libreoffice.org/76552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpFormulaOptionsCaolán McNamara1-113/+92
Change-Id: I8d45dfc745dbb7f90346028eb29a432309db0845 Reviewed-on: https://gerrit.libreoffice.org/76547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29rename DoubleField back to ScDoubleFieldCaolán McNamara1-1/+1
Change-Id: I3d3923f3131e13abde145f96468ade0d0c8cc142 Reviewed-on: https://gerrit.libreoffice.org/76546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpCalcOptionsCaolán McNamara1-120/+91
Change-Id: I4b5bd08a9ed04b9bceb08640a275dee02d6e9b36 Reviewed-on: https://gerrit.libreoffice.org/76544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpLayoutOptionsCaolán McNamara1-127/+98
Change-Id: I02f36b18d3803a7539a66b95cfc5e485d30344d7 Reviewed-on: https://gerrit.libreoffice.org/76539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-28weld ScTpCompatOptionsCaolán McNamara1-16/+9
Change-Id: Id67570b53604489fa0b2194a0f9ad0b67d535f0e Reviewed-on: https://gerrit.libreoffice.org/76487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-28weld ScTpDefaultsOptionsCaolán McNamara1-48/+32
Change-Id: I2a4a053b38229b971fbf6fc8205680ce02132234 Reviewed-on: https://gerrit.libreoffice.org/76486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-22tdf#42949 Fix IWYU warnings in include/svx/[h-r]*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib7e1d0f7483aa8b5cab320278714f2d5f36fdbd9 Reviewed-on: https://gerrit.libreoffice.org/72534 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-17Resolves tdf#87965 - Make 'Search Results' dialog optionalheiko tietze1-0/+7
* Option introduced at Tools > Options > Calc > View (Windows) * Convenience checkbox added to the dialog Change-Id: Ic30fb302e61e77b0eefacd504f61f955bcf6e595 Reviewed-on: https://gerrit.libreoffice.org/71910 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-04-08tdf#42949 Fix IWYU warnings in include/sfx2/[t-z]*Gabor Kelemen2-0/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib3252828385d1dc8faf48a428b1593199647a679 Reviewed-on: https://gerrit.libreoffice.org/70383 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-04tdf#124323: show restart dialog when toggling multi-threaded...Xisco Fauli1-0/+6
calculation Change-Id: I853ae21d4c085488232a375ef42480453c01880b Reviewed-on: https://gerrit.libreoffice.org/70210 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-11tdf#42949 Fix IWYU warnings in sc/source/ui/[f-o]*/*cxxGabor Kelemen8-49/+7
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I56e32029f40a7c440143e395d851396fb2740fa8 Reviewed-on: https://gerrit.libreoffice.org/68837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-08convert "*xxx.get()" to "*xxx"Noel Grandin1-6/+6
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9 Reviewed-on: https://gerrit.libreoffice.org/65951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-30tdf#42949 Fix IWYU warnings in sc/source/ui/*/hxxGabor Kelemen1-5/+0
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I3a945828b4c74be7747850e3e0eab2f4adeb67fd Reviewed-on: https://gerrit.libreoffice.org/64140 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-21loplugin:redundantfcast improvementsNoel Grandin1-3/+2
check for calls to constructors, and extend the list of types we check for unnecessary temporary creation Change-Id: Ia2c1f202b41ed6866779fff5343c821128033eec Reviewed-on: https://gerrit.libreoffice.org/63472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-08Convert FieldUnit to scoped enumMike Kaganski1-9/+9
Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af Reviewed-on: https://gerrit.libreoffice.org/62958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-07move SvTreeListBox to vclCaolán McNamara1-2/+2
Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44 Reviewed-on: https://gerrit.libreoffice.org/62787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[a-e]*Gabor Kelemen1-0/+1
Also files starting with capital letters. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia79de45524315e2aaa1283ee6e42c54c9e14a31e Reviewed-on: https://gerrit.libreoffice.org/61735 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-17rename to weld::ComboBox are they are not text only nowCaolán McNamara2-8/+8
Change-Id: Ice26d1fd2ad97a6959c6916fef428777efea9c2d Reviewed-on: https://gerrit.libreoffice.org/60500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-09Avoid getTokenCount and use indexed getTokenMatteo Casalin1-5/+5
Change-Id: I84141b9863225346d2bedfb702468f37bbeb9f64
2018-08-01loplugin:stringloop in scNoel Grandin1-18/+16
Change-Id: I12c020d5dd75d9c8ffcb7a2e8d6ff310628fa04d Reviewed-on: https://gerrit.libreoffice.org/58432 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-20loplugin:useuniqueptr in ScTpContentOptionsNoel Grandin1-6/+5
Change-Id: If19da8d2d7ffe1d245e67466fa55166b76774013 Reviewed-on: https://gerrit.libreoffice.org/57752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-20loplugin:useuniqueptr in ScTpUserListsNoel Grandin1-5/+4
Change-Id: I15f30f655d409e3570bb33aa032f809263d3035b Reviewed-on: https://gerrit.libreoffice.org/57751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in ScTpCalcOptionsNoel Grandin1-2/+2
Change-Id: Iebf8bc4036ed6b530e088429a71200097816bccd Reviewed-on: https://gerrit.libreoffice.org/57526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03tdf#118452 Don't crash when multi thread calculation is disabledGabor Kelemen1-1/+1
...by default configuration. Change-Id: If6075ae66537f613434dd38766324436f2426517 Reviewed-on: https://gerrit.libreoffice.org/56840 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>