summaryrefslogtreecommitdiff
path: root/sc/source/ui/docshell
AgeCommit message (Collapse)AuthorFilesLines
2013-02-26fdo#38838 Replaced some use of (Xub)String with OUString.Jean-Noël Rouvignac1-23/+19
Change-Id: I5a8f2d1a5762c20d21d31b04778a9e2cac8df9cb Reviewed-on: https://gerrit.libreoffice.org/2364 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-25loplugin: unused variablesThomas Arnhold1-1/+0
Change-Id: I07b82471f0f32e9e894d4eb392beedeafc6be0c7
2013-02-22fdo#38838 search replace for String::CreateFromInt32().Jean-Noël Rouvignac5-21/+21
I ran the following code replace: s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/ Change-Id: I45edaec4de2481ad45f9bcae2e280d5aca487714 Reviewed-on: https://gerrit.libreoffice.org/2281 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-22resolved fdo#57841 ignore embedded NULL characters in CSV importEike Rathke1-0/+19
Change-Id: Ib0eb044f009227c0aa6e1bc520905d605323c3db
2013-02-22fix sc buildCaolán McNamara3-7/+7
Change-Id: I2c5ad65863a516516f8a944fb1344753e08d6c9e
2013-02-21parse html filter options more legibly.Michael Meeks1-11/+10
Change-Id: I951d26df9c99f47b3e1415b96efaa050adf82892
2013-02-21clone documentfontsdialog from sw, add method to SfxDocumentInfoDialog add tabNoel Power1-0/+1
Change-Id: I9cfb4f65e27a73921ac7944376677c5ddecdf9a9
2013-02-17coverity: fix memory leakMarkus Mohrhard1-0/+1
Change-Id: I2e0b97285edf1544091402c05d3880f560a352e9
2013-02-17coverity: fix memory leakMarkus Mohrhard1-12/+7
Change-Id: I60d1845dbef9d53545db4bb743764bcb0b6a57cc
2013-02-16coverity: prevent acces to unintialized variableMarkus Mohrhard1-1/+1
Change-Id: Ic2c28232574460fd59dd404618af6b581f410a83
2013-02-16coverity: fix memory leakMarkus Mohrhard1-0/+1
Change-Id: I5c8f4002d92be1ddef3f075be7cbcd6a2e88075f
2013-02-16coverity: seems to be unused nowMarkus Mohrhard1-5/+0
Change-Id: I8bc75ab429619efef65d29a021403444dcd8a1c0
2013-02-12Go through all ScEditCell instantiations and fix memory leaks.Kohei Yoshida1-3/+3
Changed the signature of the constructor (one that clones the text object) to take a reference instead of a pointer, to smoke out the callers that use this constructor. Went through all its callers and made changes to either 1) pass ownership to the cell instance (if the text object uses the SfxItemPool instance returned from ScDocument::GetEditPool()), or 2) pass as const reference to make it clear that the instance will get cloned. Change-Id: I669e066d4739536bf8d3b356186503dcdfa303b0
2013-02-06String->OUStringCaolán McNamara1-1/+1
Change-Id: I42193a40a0b5b905a721cb511d69836385bfcb40
2013-02-04clean up EnableAdjustHeight calls, disable at start of import reset at endNoel Power1-5/+2
Change-Id: I61ffa13d857134c4a39b1370f0bcd5b926b8e8a7
2013-01-30Let's stick with just one variant of ScDocument::GetString()...Kohei Yoshida3-9/+8
Instead of having 3 of them. Change-Id: I2de9b63c33b7362162a56ea391f8b68a468163fa
2013-01-30no user of nVisibleTab inside ScDocument anymoreMarkus Mohrhard1-1/+1
Change-Id: I1ee09c7be958b0231f99df2ebadb0dc6a3a20246
2013-01-30move these methods to ScDocShellMarkus Mohrhard2-5/+87
Change-Id: I050e4d992c601c7af1a83b30137ab38fd05b8a74
2013-01-30remove these unused static data membersMarkus Mohrhard1-5/+0
Change-Id: I8b3dc969fc371a47b89055e80ea762565e405f26
2013-01-29bnc#484599: Prevent pivot table from getting sheared when cells are shifted.Kohei Yoshida1-1/+191
Change-Id: Ic6766105bb221aa4ebc700cbf99b4f6f5b3abf8b
2013-01-29Let's stick with FooCol, FooRow naming as opposed to FooX, FooY.Kohei Yoshida1-104/+104
The latter always confuses me, which likely would lead to bugs caused by brain shortcircuiting. Change-Id: Ide7545d8d28e89265cad0d4457ab29cecc1869d3
2013-01-29Boolean cleanup in InsertCells and DeleteCells.Kohei Yoshida1-30/+30
Change-Id: I11d8ba422b280a9a06dbc9bb13c2ccaae7435afb
2013-01-29Bool cleanup with ScEditableTester.Kohei Yoshida1-25/+23
Change-Id: If4ae85bec451897f5c22397f4301200d1d3c77ac
2013-01-28fdo#46808, Convert SvNumberFormatter to use XComponentContextNoel Grandin2-3/+3
Change-Id: If4e8312dae6bc5eb8bb7655cf250f06ab37b7e5c
2013-01-25a few more fixes for cached value importMarkus Mohrhard1-1/+3
Change-Id: I2b6baedc8232811df1e5525bd2884b54db5a8f70
2013-01-22reset automatic row height flag after import, fdo#59193Markus Mohrhard1-0/+3
Change-Id: Ied9cb4a2b6a17d8c7b65f4fec3cb17219a5afa5b
2013-01-12Maybe this will make the Windows tinderbox happy...Kohei Yoshida1-1/+1
Change-Id: I9e838d2e4cadd79c55a5648b006f40d3dcd04518
2013-01-11Remove more duplicated code blocks.Kohei Yoshida1-85/+50
Change-Id: I4b392a10b324ba082764df92a8640edb3e225666
2013-01-11Remove duplicate blocks.Kohei Yoshida1-19/+13
Change-Id: If994ea2505078ea7133c162c95df4f89a3c5ba99
2013-01-11Redo DataPilotUpdate() as well.Kohei Yoshida1-125/+84
Change-Id: I8c53c233f42b6640ef8d77982082945e07882979
2013-01-11Actually let's do these earlier so we can bail out early.Kohei Yoshida1-10/+10
Change-Id: I1903efe4dba876e4d373cc329c66595840d7be81
2013-01-11Check this first before instantiating heap objects.Kohei Yoshida1-6/+6
To prevent memory leak. Change-Id: Ia4a5bb3fbad8bdd5646bc92c405458b929b5f7da
2013-01-11Remove duplicate code blocks.Kohei Yoshida1-84/+42
Change-Id: I403b6a1e3639c221b007f38ad07daf19dfd8e643
2013-01-11Remove all checks for NULL pointers from DataPilotUpdate().Kohei Yoshida1-148/+77
Now we can safely assume that both pOldObj and pNewObj are non-NULL, and they are not equal. Remove unnecessary checks to make the code simpler. Change-Id: I263dc377aeb245dc9261b40ee0605e2cb54c28f2
2013-01-11A little cleaning of RefreshPivotTables().Kohei Yoshida1-21/+11
Change-Id: I0cc99d68545f5b7e27132930626afa830fc86633
2013-01-11Add a variant of DataPilotUpdate that removes pivot table.Kohei Yoshida1-0/+84
This one became pretty small. Change-Id: Ic1e1e2b7afc35e5d1141a34722a6fe395832d936
2013-01-11Create another variant of DataPilotUpdate() for new table creation.Kohei Yoshida1-0/+137
Again, this version has much less branching. Change-Id: I9138471261f2d4df14b64e603a88d4495b6ea45e
2013-01-11Let's remove this underused bAlive flag....Kohei Yoshida1-1/+0
It's no longer that useful in today's pivot table design. Change-Id: I665a7707126793dfde17a2221ba563d22a59aad1
2013-01-11Resolves: fdo#58865 hard-coded LibreOffice stringsCaolán McNamara1-1/+3
Change-Id: Ie03106c3089f6d1bc0172a2e2c702b5725e55acf Reviewed-on: https://gerrit.libreoffice.org/1656 Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com> Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2013-01-11ScDBDocFunc::UpdatePivotTable: -Werror=deprecated-declarationsMichael Stahl1-2/+4
Change-Id: I0d1b8176c9796ae39bc692d48e4481bdedb6ff09
2013-01-11Let's not return here to prevent memory leak.Kohei Yoshida1-2/+1
There are several heap objects that are deleted at the end of the method. Returning prematurely would leak those objects. Change-Id: If70cb3c9c02e47229d10b30f1542f7b25534d593
2013-01-11Create a self-update variant of DataPilotUpdate().Kohei Yoshida1-2/+141
DataPilotUpdate() is getting more and more complicated, with so many branches. Since self-updating a pivot table object is common, let's create a variant just for that. This variant has much less branching. Change-Id: I75b0512258a09961ef13516d8d9bc8a2939287e1
2013-01-11Makes no sense to 'continue' at the end of the block.Kohei Yoshida1-2/+1
Change-Id: I2b02430944c5c6ecf67d2b7cd02c66bb549c93f9
2013-01-10fdo#59084: Sync dimension members after reloading the group data.Kohei Yoshida1-3/+4
Else the syncing would end up syncing to the older version of the group data before the reload, which (as you can see in the bug report) may lead to a crash. Change-Id: Ibd674a97a59205e5e28efd007f8857731e8df4d3
2013-01-10fdo#58069: Invalidate sheet stream cache when directory path changes.Kohei Yoshida1-1/+37
To properly regenerate hyperlinks (among other things) which depend on the full path of the host document. Change-Id: I44fdd5b0ef0a57bf4fae13f29f1ebacfe1ab19a8
2013-01-08Let's not have two variants of this getter. One is enough.Kohei Yoshida1-2/+1
And let's stick with the one that returns the data pointer. Change-Id: I931be0d73adcf6f3888d05ef58bc0f905f5a6958
2013-01-08DynamicErrorInfo objects must be allocated on the heapStephan Bergmann2-3/+3
cf. "delete pInfo;" in ErrorHandler::HandleError_Impl (tools/source/ref/errinf.cxx). This reverts the remaining (non UNO related) changes from e48d47469508dee55ae6abcb3988222b5612e1e9 "fix some memory leaks in sc" and 5ea7e74c29f7279b6c31d38185ace576f68f4fb2 "fix some memory leaks in sd" that had not already been reverted. Whether any of these instantiations are really leaked (i.e., never deleted again in calls to ErrorHandler::HandleError_Impl) is unclear to me, but that would need to be fixed in a different way. Change-Id: I6d9e7a2f6fce6d6a4d5d390c09a5a12f593028a6
2013-01-06fix some memory leaks in scMarkus Mohrhard2-3/+3
Change-Id: I1e3b9a55561f941346cb9f553f960dc2bafbb1b6
2013-01-01remove use of #pragma optimizeLuboš Luňák1-6/+0
All these are years old, guessing from some comments as old as Windows 9x support. These workarounds do not seem to be needed now. Change-Id: If67baa5cdefcec33b28696c764b1ed96143b7ccd
2013-01-01fdo#47466 FORMATTING: Autoformat empty rows causes app to crashJulien Nabet1-0/+2
Thank you John LeMoyne Castle for your support http://nabble.documentfoundation.org/Wrong-indentation-which-leads-to-segfault-in-sc-source-ui-docshell-docfunc-cxx-td4026726.html However, the weird thing is I reproduced the crash with master sources but didn't with 4.0 branch nor with 3.5.4.2 Debian packages Change-Id: Ia5366f479a1066106551b77b5a6315fb78e1bf7d
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-08 02:16:25 +0000