summaryrefslogtreecommitdiff
path: root/sc/source/core
AgeCommit message (Collapse)AuthorFilesLines
2020-05-24Revert "tdf#37268: use also sheet local range in Pivot"Julien Nabet1-27/+1
This reverts commit 73af06a6a7fcb2d92d36a45bbe54395bcba8dfb0. The patch is wrong according to: https://bugs.documentfoundation.org/show_bug.cgi?id=37268#c24 Change-Id: I63dd69afa3fc324930cd16ccc3458372d7745531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94748 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-13Resolves: tdf#132173 handle API sequence to inline array token correctlyEike Rathke1-1/+1
The API token of an inline array is always a two dimensional matrix. Regression from commit 3f80ac477354f4c6293d983d3ca9eef59a07dce0 CommitDate: Wed Apr 1 08:40:39 2015 +0200 Replace remaining getCppuType et al with cppu::UnoType Change-Id: I9ab2a807d29847fb843625b898ab8bbd005fab2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94085 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-05-10new loplugin:simplifypointertoboolNoel Grandin5-7/+7
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-09compact namespace in scNoel Grandin14-26/+24
Change-Id: I05ffad6b92883d3eb6d337fe75f5fc7864485861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93860 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-07fix use after std::moveNoel Grandin1-1/+1
regression from commit 5efd34eabcbd374f0f06cac12b7b25f955db7965 loplugin:makeshared in sc Change-Id: I1ec603f6ea01aca86cb478f2bf3a6d5d37f235af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-07sanitize properly Calc search bounds (tdf#132097)Luboš Luňák1-4/+6
The row/col handling seems really weird to me here in some places (like starting actually at startcol+1 in some cases). But at least properly limit the values to prevent out-of-bounds accesses. This also reverts 2670e980c7dbadbdc20ff23d57ad892951edc254. Change-Id: I5eb94f3841f3defa763046d5d5bec805abd97c62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93634 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-05Resolves: tdf#131536 TEXT() support empty format string mimicking ExcelEike Rathke1-0/+12
Change-Id: Iffc37179cafb8b8bcfa1232e7aa54ae119ab5846 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93504 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-05-05ScOrcusStyles::commit_cell_style creates SfxStyleFamily::Para stylesCaolán McNamara1-2/+2
and setAllStandard is only called on the results of that so rename it to setAllParaStandard and we can safely assume that the mask should be ::All Change-Id: I087b40ed919c1b8724d5d36bae2f94180148cec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93470 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05make the family and mask explicit in SfxStyleSheetBasePool::FirstCaolán McNamara1-1/+1
Change-Id: I36655b65ca00e5f7b8779a28d4a1778c8e35dc4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05IdleCalcTextWidthScope uses SfxStyleSheetBasePool::FindCaolán McNamara1-10/+0
with a SfxStyleFamily::Page arg so there no need to call SetSearchMask(SfxStyleFamily::Page) on the SfxStyleSheetBasePool so then there's no need to save and restore the family and mask because we don't change it and don't need to use it. Change-Id: I6677731d680a72554a1c02b3008b62d47aa8b568 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93454 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-04default CreateIterator mask to SfxStyleSearchBits::AllCaolán McNamara2-2/+2
Change-Id: Ie79eff57646853613e8c6060adbce92dd388df5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-30loplugin:makeshared in scNoel Grandin4-256/+253
Change-Id: I512d05ea24c519c25f03a35842e362bf23f05693 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-29Fix typo in codeEike Rathke1-2/+4
... and provide a compatibility mechanism for supported service names, as the typo was long standing since the beginning and existing extensions may rely on it. Co-authored-by: Andrea Gelmini <andrea.gelmini@gelma.net> Change-Id: I289ec8a17b131bd013dd4b69327aed41e488d4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92938 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-28Resolves: tdf#127831 implement RAND.NV() and RANDBETWEEN.NV() non-volatileEike Rathke5-6/+46
Same as RAND() and RANDBETWEEN() but not recalculating on every change, just the normal expression recalculation. Change-Id: I8ba7099125e487a78bd3d91db8b666c2f36b22fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92994 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-27Add the few functions without parameters as entries with BoundsEike Rathke1-0/+8
It doesn't really matter, but the assumption is that functions without entries take at least one and only scalar value arguments. Change-Id: I6a4cb882c86c50a0c63ddd5fc6a3b885fab32ea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92990 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann3-0/+3
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-23tdf#132278 crash after opening an old fileNoel Grandin1-1/+2
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: I7a37631094b91f4859326db054f285daa8dccbb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-22tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/Gabor Kelemen1-0/+1
Turns out we can save about 500Mb of preprocessor input if we use rtl_math_approxEqual from rtl/math.h instead of its C++ wrapper rtl::math::approxEqual from rtl/math.hxx and manage the fallout accordingly. Before: bin/includebloat.awk | head sum total bytes included (excluding system headers): 19017296671 After: $ bin/includebloat.awk | head sum total bytes included (excluding system headers): 18535432672 Change-Id: I1691171f3a309405a7099882ad9989d147f59118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-20add tools::Rectangle::JustifyNoel Grandin1-2/+2
so rectangles can be constructed already valid Change-Id: I3ae5e24add3c81f79dcdf863f855dca439876f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-18Move implementation of CELL("format";...) to SvNumberFormatter, tdf#132106 prepEike Rathke1-54/+1
In preparation of further detailed handling. Change-Id: I9e4d916de031b742d0af1025b945b7608fed8266 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92462 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-04-17Break overly long lineEike Rathke1-2/+3
... and make it more legible. Change-Id: Ie5325f614cf8d95290e04c9b0e9fa29f353d8301
2020-04-17tdf#130583: fix Switch in CalcJulien Nabet1-1/+1
Don't set bFinished to true too soon if there are still some params to take into account Change-Id: Ie7bdd6f316c08342d379d55bf3853774dd738e7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92345 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-16tdf#132097: fix Find Previous with direction columns crashes in specific caseJulien Nabet1-2/+2
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=159553 nBlockPos vector is created with nLastCol + 1 elements, so if we click on a cell in a column which is after last value, the search will crash Change-Id: I9de688a8a80a45c3e5ddea6d2f461926e9777052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15loplugin:buriedassign in scNoel Grandin14-241/+313
Change-Id: I9b4146c4e8814a36c7bfcd4c31f913c8412320e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15add an IsEmpty method to tools::Size and use itNoel Grandin1-1/+1
Change-Id: I7f5201e2ea6c74329336e16bf219630e38ff92cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11tdf#131907 Crash: reject/clear formattingNoel Grandin1-1/+1
regression from commit 0ef5c47547bec6319b853326603f3b807407fe78 sc: rowcol: tdf#50916 convert core/tool Change-Id: Ib8207f60d34e4257fc9a854f4e4d358951e24718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-08Resolves: tdf#131442 Sort must not contain matrix formula except 1x1 arrayEike Rathke3-12/+31
Change-Id: Idc7a9646a70c59fceee0b36426f38a938cf073ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91858 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-31convert enum to scoped in SvBaseLinkNoel Grandin2-2/+2
Change-Id: Ief399381ac27764fce95ee053c322571a07b671c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-27Resolves: tdf#131096 Handle argument error and propagateEike Rathke1-10/+31
For etsPIAdd and etsPIMult also check if the fPILevel parameter was actually specified (explicitly or missing/omitted) and do not pop the 3rd parameter if not. GetDoubleWithDefault() can't handle that as apparently was erroneously assumed. Use IllegalArgument error instead of IllegalParameter in most cases (the parameter is fine but the argument value is not). Actually propagate ScETSForecastCalculation::mnErrorValue if set as PushMatrix() does not, on purpose. Change-Id: Ia2db5b0a7a388f0f40b73c6a4f66debbedec41e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91232 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-26tdf#131380 crash on loading specific xlsx documentCaolán McNamara1-3/+4
mpPerIdx is null, because bEDS is true, assume 0 in this case Change-Id: I44c2433b0de57a28cece6b9b01ba543bdc3cb8d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91145 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen3-3/+0
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-15Fix typoAndrea Gelmini1-1/+1
Change-Id: I9715f320bbf35ceafc2d0f2eb9a69c02821779d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90528 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-15Resolves: tdf#130371 Undo of sheet-local named expressionsEike Rathke1-0/+24
... created during paste (and maybe other operations). Change-Id: I75d668f717b7336a1a65a9e02c75bf2aefe860b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90497 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi3-3/+3
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-14tdf#130974 replace `rtl::math::isSignBitSet` with `std::signbit`.Yukio Siraichi1-1/+1
Change-Id: I91235eee8c6a9d4a59c1933527b49141f64cd91b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12tdf#130976 replace `rtl::math::isInf` with `std::inf`.Yukio Siraichi1-1/+1
Change-Id: Id0f0e07b324230d2d69cbf4ab07b0fff5b24474d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90377 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12tdf#130977 replace `rtl::math::isFinite` with `std::isfinite`.Yukio Siraichi12-45/+45
- make all calls look like `std::isfinite`. - change the comments referring `rtl::math::isFinite`. Change-Id: I0cde9ceb9f20150467b454cddde5e62003cfde1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90234 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12Revert "loplugin:constfields in sc"Noel Grandin50-218/+218
This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09improve loplugin:unusedfieldsNoel Grandin2-4/+5
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06formula manager: wrong category returned by ScFuncDesc::getCategoryMarco Cecchetti1-1/+1
In the function manager the index associated to each category starts from 0 while in ScFuncDesc starts from 1 (data member ScFuncDesc::nCategory) Change-Id: I92d0cd2a1a2871785e45faafd797dcf3a500bec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89198 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90072 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-01Related: tdf#130371 Broadcast ScAreasChanged for created namesEike Rathke1-0/+9
... to notify the Name Box to refresh its name list. Change-Id: I20fb461d59c0dd98698837d91e2a7ef9a8c5a4ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89768 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-29ofz#20904 check boundsCaolán McNamara1-4/+7
Change-Id: I5d6d381ebd359b233b309e08131f3dda21310d80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89620 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-26Resolves: tdf#130825 Compare exclusive end, not inclusive end sheet numberEike Rathke1-1/+1
Change-Id: Id5c3056f4e4466ccb5ea3654e60869bf7788b7ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89471 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-25loplugin:referencecastingNoel Grandin2-2/+4
getting --enable-pch=normal working with clang means that the plugins now have a better view on some stuff, so trigger more warnings Change-Id: I83ca010c0ef07c8106068362bb50a354e3cf7dae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-24workaround GCC 9.2.1 -Og -Werror=maybe-uninitializedMichael Stahl1-2/+2
vcl/unx/generic/gdi/salbmp.cxx:727:32: error: ‘pixmapHandle’ may be used uninitialized in this function [-Werror=maybe-uninitialized] vcl/unx/gtk3/gtk3gtkinst.cxx:7336:16: error: ‘eRet’ may be used uninitialized in this function [-Werror=maybe-uninitialized] etc. One looks like it might occur in practice. Change-Id: I09af7d36b134b31cb7bd8047b5c73f4a49c9d9b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89351 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-24tdf#114441: Convert use of sal_uLong to better integer typesPelin Kuran1-9/+9
Change-Id: I9d0e6cf0a638866ac11ea9b3ac4a840f5c0a241d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89295 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-22Resolves: tdf#130563 Add predefined 4-digit year date+time formatEike Rathke1-0/+1
Add a predefined NF_DATETIME_SYS_DDMMYYYY_HHMM format code with formatindex="50" to all locale data files, which shifts all reserved area internally generated built-in formats up by one. Reserved area was filled already so that boundary has to be increased as well. Add some flexibility for future additions by setting the new boundary to 65, free first format index to be used by additional locale data formats is 66 now. Adapt all locales to the new boundary. The existing predefined NF_DATETIME_SYSTEM_SHORT_HHMM format code with formatindex="46" mostly was and is used with 2-digit years (stemming back from the old binary format and Excel compatibility), some locales that don't use 2-digit years at all already defined it to 4-digit years. Keep those but move the default="true" attribute (if so) to the new "50" format. Modify populating the format list such that resulting duplicates will be suppressed there as well. Also try to match the new format in ODF import if a long year was requested with date+time. Finally set the new format as default for all *_IT locales. In future changing the default date+time format to 4-digit year is just a matter of moving the default="true" attribute to the new format. Change-Id: Ib16aa9fda0e71b2d03f78e3dd013785de03cd288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89265 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-22ScGlobal - change direct access to a static ptr for a getterTomaž Vajngerl30-102/+105
pLocalData and pCharClass static veriables on ScGlobal are always set from SvtSysLocale on init, probably for "faster" access. This can just be made simpler with access through a getter, so this introduces a getter for ScGlobal::getCharClassPtr and ScGlobal::getLocaleDataPtr, where the access is made directly to SvtSysLocale instance. In addition all the usages needed to be fixed, which is all over the calc module. Change-Id: Ie047b158094e25bbaa2aba15074d7998d9541787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89249 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-21tdf#114441: Convert use of sal_uLong to better integer typesPelin Kuran1-4/+4
Change-Id: If530139af18f26cf0fcdd84fa36df6a5367d6b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87767 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann7-28/+28
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 22:46:24 +0000