path: root/sc/source/core/tool/sharedformula.cxx
AgeCommit message (Collapse)AuthorFilesLines
2015-09-17Resolves: tdf#94249 do not remove broadcasters while iterators are in useEike Rathke1-4/+11
EndListeningContext holds BroadcasterStoreType iterators in its ColumnBlockPositionSet and collects broadcasters to purge them at the end. Removing broadcasters from ScColumn::maBroadcasters in between invalidates the iterators. Hence calling the "normal" EndListening() that removes a broadcaster when all listeners are gone while an EndListeningContext is in use is bad. Change-Id: Ibdd88469e91e6173ceff1f391c23ef7cb7c6f596 (cherry picked from commit e4a8ae0bf54476e9a0c9e1f5348c05f3cd838899) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2015-06-10tdf#90694 reset group area listeners when splitting groupEike Rathke1-2/+14
(cherry picked from commit 2f6a06856ad8df0c11a112d1e457b408e9a7af1d) tdf#90694 reset group area listeners on correct top Follow-up on 2f6a06856ad8df0c11a112d1e457b408e9a7af1d, rTop is top of created group, listening needs to be ended on original (previous) group. (cherry picked from commit 5d6448a5131488eac3a6af16bff06140663c3db4) 1f975a0a6c85e649aa07ce5c6e97bc6e917ff9ce Change-Id: Ib3e85e1f7e12447fc2998711663ea1e9d1b322e5 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2014-12-11fdo#86572: Increment row position *only when* the row ref is relative.Kohei Yoshida1-2/+5
This is just a simple oversight. Change-Id: I024777c46641cce3410a20f40c48f47ad6a5dade (cherry picked from commit 52781a55441cb270ffecc2522d1e069141a21607)
2014-11-21Use group area listeners when deleting rows.Kohei Yoshida1-7/+10
Change-Id: I9ceb1cabf448349e087e4d5c4c2b1a75af91dd75 (cherry picked from commit 5432e2a5ef7a3e131d2496e19bd0c6a86955319f)
2014-11-18Dedicated listener type tailored for formula groups.Kohei Yoshida1-1/+77
Right now, it's only used when loading an xlsx file. But eventually this one should be used everywhere. Change-Id: I216c3a9a33c4b8040e8284d59299e0637471fb50
2014-11-18Differentiate shared and non-shared formula cells when registering.Kohei Yoshida1-0/+13
For now this is just for a pure redirection, but later we'll use this to do a different area listening registration for grouped formula cells. Change-Id: I8e68bb53c3e96821175ae562ef36ec5e800c8688
2014-07-13fdo#81309: Adjust references during sort.Kohei Yoshida1-0/+29
Change-Id: I2b98610f6b774400ecfaffe2905201c27fcab33f
2013-11-20Fix a few of my own thinkos, and add some assertionsTor Lillqvist1-0/+1
Fix two obvious mistakes from 8c37bafbc5adc0c79f218f9db2dc25ca8e683125. Add asserts to make sure the calls to ScFormulaCell::CreateCellGroup() that now don't take the nStart parameter any more (but assume that the cell for which this methoid is called is the start one) match the old ones in semantics. Change-Id: I50cb0cdaf620253881225baf39ae9cd935917b27
2013-11-20Point to the group's top cell in ScFormulaCellGroup instead of the top rowTor Lillqvist1-13/+13
It will make implementing the background compilation of OpenCL kernels easier, I hope. That needs data accessible through the ScFormulaCell. Change-Id: I77ad5a94eb13551e6238d5f5285f1c916d7cb992
2013-08-12Ungroup a cell when the group length becomes 1.Kohei Yoshida1-6/+18
Change-Id: Ic656d4837ab1fc5feb4b19765ae427371dfdfe10
2013-08-12Fix indentation.Kohei Yoshida1-6/+6
Change-Id: I2caebb42d92bf81e3ba8809a47f833a9379e769d
2013-08-12Do the splitting of formula groups.Kohei Yoshida1-2/+26
Change-Id: I5a8661895b558b67abc19cdc39de9eb027bc1c34
2013-08-12Collect all boundaries at which to split the formula group.Kohei Yoshida1-0/+5
Change-Id: Ic78d7a06991b983e625b161f11fbbabce02334f3
2013-08-12Handle shared token array correctly when adjusting formula grouping.Kohei Yoshida1-6/+4
Change-Id: Ib4b141f415b36565106e946ccbc47f2b9f80d89c
2013-07-11Move UnshareFormulaCell() out of ScColumn into SharedFormulaUtil.Kohei Yoshida1-0/+118
This one too doesn't operate on column. Change-Id: Ieb23641ca4860d6f137b266813ad56f4984e0523
2013-07-11Move more methods to SharedFormulaUtil.Kohei Yoshida1-5/+1
Change-Id: Ibd58f5d15292805d50823223d1ebe94e7b51b808
2013-07-11Move these methods out of ScColumn since they don't operate on column.Kohei Yoshida1-0/+130
Change-Id: I1a03b9b18dd236138306fd545e961a5443e22bc8
2013-07-11Group formula cells in ScColumn::MixData().Kohei Yoshida1-0/+18
Change-Id: I38186e2bf82ed56fbe859b17dcc1d31f36471bd8