summaryrefslogtreecommitdiff
path: root/sc/source/core/tool/cellform.cxx
AgeCommit message (Collapse)AuthorFilesLines
2017-11-24consistently use sal_uInt32 for number formats in scNoel Grandin1-4/+4
instead of a mix of short/sal_uLong/sal_uInt32 Change-Id: Ie5bd26e1a6f716c0c4e174a6d560827084b3f421 Reviewed-on: https://gerrit.libreoffice.org/45159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: scStephan Bergmann1-5/+5
Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd
2017-07-03Translate German comments and debug strings (leftovers in dirs sal to sc)Johnny_M1-1/+1
Translates leftovers found using a custom regex and manually checking the rest of the affected file. Additionally: - A few spelling fixes Change-Id: I2b83bd11adf520b90bb29c8ea624990759dad3c6 Reviewed-on: https://gerrit.libreoffice.org/39427 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-01-09New loplugin:externvar: scStephan Bergmann1-3/+0
Change-Id: I6f9df997a957a1fa49161add2adafe228d036a30
2016-11-16remove anything svHybridValueCell related, it's nowhere set anymoreEike Rathke1-2/+0
Change-Id: I9887d7ca83ffc012fec1a78ef9ef537d2188a7e3
2016-10-06Resolves: tdf#76836 use text format only for text contentEike Rathke1-19/+4
Numeric content is not to be formatted with the text format. Entering a value in such formatted cell still forces it to text content as usual and then it is displayed using the text format. The previous behavior displaying also numeric content using the text format was always wrong and neither Excel nor Gnumeric do it. A numeric content is displayed left aligned though, which also Excel does. Change-Id: I3038123b2bfdc4669a8f73840742da92a1df895d
2016-09-23convert formula error codes to scoped enumNoel Grandin1-4/+4
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb Reviewed-on: https://gerrit.libreoffice.org/28897 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke1-1/+0
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-25we already pass the ScRefCellValue as parameter, tdf#93405Markus Mohrhard1-1/+1
Change-Id: I27f7e8ffe93545fe872a0c5b64f26dc90cb70e6f
2016-03-25these two methods are identical copies, related tdf#93405Markus Mohrhard1-83/+2
This already gives a 15% improvement as we now only query the cell twice instead of three times. Change-Id: I2e0533f05ace6773ad0710b2c586ca325aeae91b
2016-03-03loplugin:unuseddefaultparams in sc (part2)Noel Grandin1-6/+5
Change-Id: I356a86bfca20cbf2c52185697042dce5237e847d
2015-12-15Bin silly 'STATIC DATA' commentsTor Lillqvist1-1/+0
Change-Id: I50e3772b7b479d2cf1eb644c7334d0f987874ccb
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-3/+3
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-11-02trash usage of ScRefCellValue default ctor followed by assign()Eike Rathke1-4/+2
... that only results in a performance penalty. Change-Id: Ia161ab7fb03f2d32cf966ce9da9d0319d919fc4c
2015-10-20loplugin:defaultparamsStephan Bergmann1-1/+1
Change-Id: If189c1e4254ae00725ec76a5ca6354d24df2d351
2015-06-02fdo#39468 Translate German Comments - sc/source/core/tool/ #1Christian M. Heller1-5/+5
Change-Id: I95c6669cfbdcbc81c5a173a6687fca14bed255fb Reviewed-on: https://gerrit.libreoffice.org/16003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-18sc: Use appropriate OUString functions on string constantsStephan Bergmann1-7/+7
Change-Id: Ifc00b2045de0d356e175733b0f03ab0c90083039
2014-06-10-Werror,-Wtautological-undefined-compareStephan Bergmann1-11/+0
Change-Id: Ibf0abf45f0522c7e887f9ce4567aca647325b9ce
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante1-2/+2
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-11fix-includes.pl: scThomas Arnhold1-2/+2
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-04-15fdo#76409: Write output cell string to <text:p> element when saving to ods.Kohei Yoshida1-0/+32
The change was made by accident. Change-Id: Ife2461b0fca6e3ea5a65d72d985d1e0976737b5a
2014-02-27coverity#1187687 Dereference null return valueCaolán McNamara1-0/+2
Change-Id: Iaaa2f17382d83e864d7f14f3788e7f7476ac3212
2014-02-24Remove some temporaries around calls to SvNumberFormatter methodsMatteo Casalin1-4/+4
Change-Id: Ib03c97a52df120bac1ac9b2b9d2e52431ead1027
2014-01-20resolved fdo#73836 do not apply format twice to stringEike Rathke1-4/+6
ScDocument::GetString() already returns the formatted string that then was formatted through number formatter. Format raw string instead. Change-Id: I806b4fc904d04169a6c1dbd4a3d00e2556eda7bd
2013-11-11remove unnecessary use of OUString constructor in SC moduleNoel Grandin1-9/+9
Change-Id: I2d40c589eb3b5c99300f36cd705c32cf824b2a98
2013-10-11Formula tokens, formula cells and formula interpreters to use shared strings.Kohei Yoshida1-5/+5
Change-Id: I5da99869fc7f61ce698180fa5daa9be9db9ac132
2013-10-08Store svl::SharedString in document cell storage instead of OUString.Kohei Yoshida1-2/+4
With this, both ScColumn and ScMatrix store svl::SharedString as their string values, instead of OUString. Change-Id: I3faece94d98f774881fd72b3ed5f6143504cd350
2013-09-10fdo#62475 removed pointless commentsJelle van der Waa1-4/+1
Conflicts: sc/source/core/tool/interpr1.cxx sc/source/core/tool/interpr4.cxx sc/source/core/tool/token.cxx Change-Id: I507d747b6c087d089203f7bce6be836da28fc537 Reviewed-on: https://gerrit.libreoffice.org/5824 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-07-25resolved fdo#67249 use ScFieldEditEngine to resolve field contentEike Rathke1-5/+5
ScEditUtil::GetString() iterated over the paragraphs of an EditTextObject where GetText() does not resolve field content but returns the embedded field markers. To resolve field content an ScFieldEditEngine is needed. This makes it necessary to pass an ScDocument* to obtain the ScFieldEditEngine from, or for cases where there is no ScDocument in the context use a static ScFieldEditEngine which unfortunately is not capable of resolving document specific fields of course, such as DOCINFO_TITLE and TABLE. Also added unit test. Change-Id: Ife3c23b2fec2514b32303239d276c49869786eb5
2013-06-02all formula cells have now an explicit number formatMarkus Mohrhard1-5/+0
Remove ScFormulaCell::GetStandardFormat Change-Id: I0b19f572cfcf5c08c81009b0f10e7cc44a1aa2f4
2013-06-02accept this result as bug fixedMarkus Mohrhard1-4/+0
We still have the number format type in ScFormulaCell. Removing that one from ScFormulaCell is more work and needs much more inspection than removing the formula index. Additionally we should inspect all callers of ScFormulaCell::GetStandardFormat as most of them are useless when we know that a cell has a fixed number format. Change-Id: I3ad55a0c072da0fc4046d6c7245ed734a1dcaabc
2013-03-28Move ScFormulaCell into its own header source files: formulacell.?xx.Kohei Yoshida1-1/+1
Change-Id: I65f2cb12c06784b5bcf6c6a2fad773825b6c409c
2013-03-28Reduce calls to ScDocument::GetCell().Kohei Yoshida1-2/+2
Change-Id: I39196eced68d25b6b2ae1378f712564badfc4572
2013-03-27GetInputString() now takes ScRefCellValue instead of ScBaseCell.Kohei Yoshida1-42/+24
Change-Id: Ibf746351eb111a03be4f00ec719a4428c5fe47a4
2013-03-27Remove variant of GetCellString() that takes ScBaseCell*.Kohei Yoshida1-111/+0
Change-Id: Ide78ab011e1f06bdb61ac2b29bc7c170cdb8d245
2013-03-27More of the same...Kohei Yoshida1-0/+103
Change-Id: I829d221d6bf164cd6087d41c65e26240108aa021
2013-03-22Reduce use of ScValueCell outside ScDocument.Kohei Yoshida1-2/+96
Change-Id: Ia1a39016e1389e551169ae8dda179cb38d30a42a
2013-03-04RTL_CONSTASCII_USTRINGPARAM and ::rtl:: removalsKrisztian Pinter1-13/+13
Change-Id: Ica78f316d481130c28da83f92561206518342eaa Reviewed-on: https://gerrit.libreoffice.org/2483 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-01-24import inherited number formats with cached values, fdo#59724Markus Mohrhard1-0/+2
Change-Id: I698f60daf4e591b57d8d99c130d2e524dc10c306
2012-12-04re-base on ALv2 code. Includes:Michael Meeks1-23/+14
Patches contributed by Herbert Duerr i#118735 prevent endless loop if vlookup/hlookup doesn't find anything http://svn.apache.org/viewvc?view=revision&revision=1239673 Patches contributed by Andre Fischer remove lp_solver http://svn.apache.org/viewvc?view=revision&revision=1199180 i#118160: Added external CoinMP library. http://svn.apache.org/viewvc?view=revision&revision=1233909 Patches contributed by Armin Le-Grand i#118485 - Styles for OLEs are not saved. http://svn.apache.org/viewvc?view=revision&revision=1182166 i#118524: apply patch, followup fixes to 118485 http://svn.apache.org/viewvc?view=revision&revision=1186077 Patches contributed by lihuiibm i#108860 - Fix range validation. http://svn.apache.org/viewvc?view=revision&revision=1242846 i#118954 Chart data will lost after copy to different file http://svn.apache.org/viewvc?view=revision&revision=1301345 Patches contributed by Ariel Constenla-Haile Fix Linux build breaker: extra qualification on member http://svn.apache.org/viewvc?view=revision&revision=1301591 i#118696 - i#118697 - Fix some Sheet Tab Color API issues http://svn.apache.org/viewvc?view=revision&revision=1225428 i#118697 - Fix uninitialized variable http://svn.apache.org/viewvc?view=revision&revision=1225859 i#118771 - ScUndoImportTab should preserve tab background color http://svn.apache.org/viewvc?view=revision&revision=1230356 i#118921 - Repaint linked sheet tab background color after updating link http://svn.apache.org/viewvc?view=revision&revision=1245177 i#118927 - Undo/Redo "Update Link" does not reset sheet tab color http://svn.apache.org/viewvc?view=revision&revision=1245241 i#118747 - Copy tab color when transferring sheets across documents http://svn.apache.org/viewvc?view=revision&revision=1230355 Patch contributed by Oliver Rainer-Wittman i#118012 - methods <ScBroadcastAreaSlot::AreaBroadcast(..)> and <ScBroadcastAreaSlot::AreaBroadcastInRange(..)> adapt stl-container iteration in order to avoid destroyed iterators during iteration. http://svn.apache.org/viewvc?view=revision&revision=1297916 Patches contributed by Mathias Bauer gnumake4 work variously http://svn.apache.org/viewvc?view=revision&revision=1394707 http://svn.apache.org/viewvc?view=revision&revision=1394326 http://svn.apache.org/viewvc?view=revision&revision=1396797 http://svn.apache.org/viewvc?view=revision&revision=1397315 Patch contributed by Daniel Rentz calc69: #i116936# fix VBA symbol Cells http://svn.apache.org/viewvc?view=revision&revision=1172135 Patches contributed by leiw: i#118546 CPU 100% on switched off AutoCalculate with Conditional Formatting on date values http://svn.apache.org/viewvc?view=revision&revision=1301380 Re-add new function documentation. Many various cleanups. Add missing calc66: #o11817313# also look at formula result number format, remove redundant binaries.
2012-08-28tweaking the "fill in character" support in Calc Number Format StringsJohann Messner1-3/+3
a) changed ordering of repeat code marker ( 0x1b ) and repeat code to more sensible ( and correct imo ) order b) prevent some possible div/0 errors c) added some missing formatter 'GetOutputString' calls
2012-06-09Remove superfluous include commentsThomas Arnhold1-2/+0
Change-Id: Ie5792855761b9be209bf3fa2cba9e6998523c982
2012-04-17enable '*' repeat next char to fill available width for calc num formatsNoel Power1-2/+3
but - however no support to import/export this to file format yet
2012-03-05String to OUString in cell.[ch]xx and follow upMarkus Mohrhard1-19/+19
2012-02-27merge GetString variantsCaolán McNamara1-9/+6
2011-11-27remove include of pch header from scNorbert Thiebaud1-2/+0
2011-11-07String->OUString in ScDocument and follow upMarkus Mohrhard1-25/+29
2011-03-10Merge commit 'ooo/DEV300_m101' into integration/dev300_m101Kohei Yoshida1-6/+6
2011-03-04Oops.Kohei Yoshida1-1/+1
2011-03-04Don't strip the first apostrophe from a text input. (fdo#34260)Kohei Yoshida1-1/+1
Also removed the abuse of this behavior during datapilot output construction. Thanks largely to the unit test. :-)
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-22 12:59:34 +0000