summaryrefslogtreecommitdiff
path: root/sc/source/core/data/conditio.cxx
AgeCommit message (Collapse)AuthorFilesLines
2014-11-24Bin commented-out unreachable 'break' statementsTor Lillqvist1-1/+0
Change-Id: If0f47a78bbffec5c2ebd33c552d0d8a300b48eb1
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-3/+3
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-23Remove ScToken from the formula::FormulaToken hierarchyStephan Bergmann1-6/+6
...to keep UBSan from complaining about illegal downcasts from FormulaToken to ScToken (which were practically harmless, given that ScToken did not add any data members). Change-Id: I8fdc026eec363442cc4b720b71d65c972b4a4446
2014-10-23Make ScToken::GetSingleRef etc. return * instead of &Stephan Bergmann1-4/+4
...so that default implementations can return nullptr without further ado Change-Id: Idc8778fe868efa00b1de597a54aa07a2e6fa3bc0
2014-08-23Translate German comments, fix some wsPhilipp Weissenbacher1-89/+73
Change-Id: I3bc8d82c5689b8a2da1374e42dd70191e2fe8ef3 Reviewed-on: https://gerrit.libreoffice.org/11099 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-25remove whitespaceMarkus Mohrhard1-3/+0
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin1-4/+0
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin1-4/+0
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-05-13fdo#76710: Adjust sheet position of conditional format entries.Kohei Yoshida1-0/+37
When inserting or deleting sheets. Change-Id: Ibf898350e22f092ec38b75ad98957832a5580e6a
2014-05-13fdo#78402: Adjust references of validity entries as appropriate.Kohei Yoshida1-2/+27
Change-Id: I7fd62153c7267a3d606b86d74bebecf6b8d75250
2014-05-10Lsan: fix memory leak in conditio.cxxMarkus Mohrhard1-0/+2
My test file leaks 9MB during import with that. Change-Id: Ie7aba31878721ad8caef1e301a6b54a42a8c0c54
2014-04-26Avoid possible memory leaks in case of exceptionsTakeshi Abe1-8/+9
Change-Id: Id8a85f6c7bcf8eed4688ebebf30b1b74676dae0d
2014-04-14fdo#76294: Properly intern string literals in formula on xls import.Kohei Yoshida1-3/+10
Change-Id: Ib3a442cbb68c23294762561f2911101a087a795e
2014-04-06whitespace cleanup in scMarkus Mohrhard1-8/+0
Change-Id: Id1dcadcac179c52977e48a6912ce4d5fd542f60c
2014-03-03Remove visual noise from scAlexander Wilms1-1/+1
Conflicts: sc/source/ui/inc/docfunc.hxx Change-Id: I9314437ed3dd60e84d28c08ac0a2d1ed7bd1daf8 Reviewed-on: https://gerrit.libreoffice.org/8301 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27coverity#1187669 Dereference null return valueCaolán McNamara1-1/+1
Change-Id: Ic77fc2d436bf70ee166e4732f19f2067907f7c53
2014-02-23Remove unneccessary commentsAlexander Wilms1-5/+5
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-17coverity#984133 Uninitialized scalar fieldNorbert Thiebaud1-2/+3
Change-Id: I933aa0d34d99808ccc359acfd895a7b9ea60217c
2014-01-14bool improvementsStephan Bergmann1-4/+4
Change-Id: I27609462f2daba6b2289aff7a6a96686c961f3ce
2013-11-07Umgekehrte Polnische Notation is German for Reverse Polish NotationTor Lillqvist1-1/+1
Change-Id: I80480f963b643596ff1c0e93af3eaa6ffc63c9dd
2013-11-06Modify ScFormulaCell's ctor to take a const reference to ScTokenArray.Kohei Yoshida1-4/+4
Instead of a pointer to ScTokenArray, and then clone its instance. If the token array gets cloned in ctor, take a const reference. Change-Id: I280fd7eb9eaea9905dbf954a1ace904ab0814dfe
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin1-3/+3
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-21remove uses of COMPARE_*Caolán McNamara1-10/+9
Change-Id: Icdc36b4b24d2f399f481065df3200feb98025135
2013-10-11Formula tokens, formula cells and formula interpreters to use shared strings.Kohei Yoshida1-7/+7
Change-Id: I5da99869fc7f61ce698180fa5daa9be9db9ac132
2013-10-08Store svl::SharedString in document cell storage instead of OUString.Kohei Yoshida1-1/+2
With this, both ScColumn and ScMatrix store svl::SharedString as their string values, instead of OUString. Change-Id: I3faece94d98f774881fd72b3ed5f6143504cd350
2013-09-05increase conditional format range during inserting rows/cols, fdo#67783Markus Mohrhard1-0/+22
Change-Id: Ib74667fb958aa9bbbcae3a0289b3cbd6edf8fb37
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák1-9/+9
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-07-30Now nobody accesses reference members directly. Make them private.Kohei Yoshida1-1/+1
Change-Id: If4499dbee52532cc8a95c380bbe840719fe9279b
2013-07-30More on avoiding direct access to reference data members.Kohei Yoshida1-10/+12
Change-Id: I313c6504d7c0beeb68318ce436b48fa900e4cf48
2013-07-30Rework reference update in conditional formatting and cell validation.Kohei Yoshida1-115/+96
No tests are written for this yet. Change-Id: Ic26a7f19d6ce6e6d7059035dc9c99ae5bcb9d77b
2013-07-30Adjust named range references on sheet move.Kohei Yoshida1-2/+3
Change-Id: I3b20f79d9c2f373c93a34ccdb308c6d5c09f69e7
2013-07-30Update range names on sheet deletion.Kohei Yoshida1-2/+9
It works fine with live calc instance, but somehow fails in unit test. Change-Id: Ie60774b4f1f8391801e0d9358f6cca78d8e52397
2013-07-30More on avoiding direct access to data members.Kohei Yoshida1-2/+2
Change-Id: I5fdc0d248fe9c36418fd02a1e652e4e35a638c8a
2013-07-30More on removing unused methods after some adjustments.Kohei Yoshida1-6/+3
Change-Id: Ib8322228f25094c7c90a6623293e61f56b66b659
2013-07-30Make this guy unused, and remove it.Kohei Yoshida1-6/+6
Change-Id: Ib4a2f195b3ff1d291b0ffe99c27b1d3e807252d5
2013-07-30More on removing direct access to reference position members.Kohei Yoshida1-17/+15
Change-Id: I7ca5cd0aefbcbda5d89116aca90e974b4bed6ca0
2013-07-25resolved fdo#67249 use ScFieldEditEngine to resolve field contentEike Rathke1-4/+5
ScEditUtil::GetString() iterated over the paragraphs of an EditTextObject where GetText() does not resolve field content but returns the embedded field markers. To resolve field content an ScFieldEditEngine is needed. This makes it necessary to pass an ScDocument* to obtain the ScFieldEditEngine from, or for cases where there is no ScDocument in the context use a static ScFieldEditEngine which unfortunately is not capable of resolving document specific fields of course, such as DOCINFO_TITLE and TABLE. Also added unit test. Change-Id: Ife3c23b2fec2514b32303239d276c49869786eb5
2013-07-24Work on remving direct access to ScSingleRefData's data members.Kohei Yoshida1-2/+2
This broke the shared formula import from xls and xlsx. Disabling the tests for now. Change-Id: I75d802b00947b21083db19b5c07204a0c3d4f369
2013-06-29allow these cond formats to be updated when formula val changes,fdo#64401Markus Mohrhard1-1/+16
When the formulas depend on cells outside of the paint range we need to update the whole range. This approach will update the range more often than necessary but prevents that we need to mess with ScFormulaCell. In the future we should replace ScFormulaCell in this part of the code with something simpler that will correctly fix this problem. Change-Id: Ie8a8e5205f9ea1e43bb6d9f8bee6e0bab29e4840
2013-05-20Speed up ScColumn::HasEditCells() by keeping track of block position.Kohei Yoshida1-0/+12
Use block position hint to avoid re-starting search in the cell text attribute array. This change alone cuts additional 10 seconds off of the previously mentioned use case, by reducing the duration of HasEditCells() call from the previous ~10 seconds to a tiny fraction of a second. Change-Id: Id9f951cd235a88928c900619b6b66d7b8a057e0c
2013-05-09Remove broadcaster from ScBaseCell, remove ScNoteCell and CELLTYPE_NOTE...Kohei Yoshida1-1/+1
and Calc is now officially broken. Let's start fixing this bit by bit... Change-Id: I383c88245fe1e573666da636c6a8ca8815352ce7
2013-05-06Revert "abstract type in ptr_container needs this workaround"Stephan Bergmann1-13/+15
d3f063cc86b50ac9adf08eb46dd2caf7975ed43c, by instead restricting the use of the Boost pointer containers to non-inline code (watch out for implicitly generated copy ctors and copy assignment ops), thus preventing MSVC from trying to generate full template instantiations of those containers (similar to f4227c822c7f5a4e1e1b3b4e096cb63cf710a3f1 "Blind fix for MSVC, take two"). Turns out the ScConditionalFormat copy ctor was unused anyway (but the ScConditionalFormatList copy ctor isn't, so only prevent generation of an implicit copy assignment op there). Change-Id: I23303a98df7024dbce95638ac13097b71a9c5c04
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák1-36/+36
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-28Remove some headers in cell.hxx.Kohei Yoshida1-0/+1
Change-Id: Ic99967a3ef6a35ca4fc465054e0d4de512cafb43
2013-03-28Move ScFormulaCell into its own header source files: formulacell.?xx.Kohei Yoshida1-1/+1
Change-Id: I65f2cb12c06784b5bcf6c6a2fad773825b6c409c
2013-03-26Make the conditional formatting code free of ScBaseCell.Kohei Yoshida1-57/+55
Change-Id: I93f83a840874c973cdc0821ddeb1913be7f09767
2013-03-24URM_INSDEL we need to update the src position, fdo#62206Markus Mohrhard1-6/+15
See ScFormulaCell::UpdateReference for a similar update Change-Id: I1f98d26adb5085e4bdab63cc23f97a81928d6b13
2013-03-23fix above/below equal average ods import/exportMarkus Mohrhard1-6/+8
Change-Id: I1c305c67772b46cede6b4da3e79578f2f1a8ee89
2013-03-23remove the code for this old test conceptMarkus Mohrhard1-16/+0
Change-Id: I4c9c383cffa2cfadbee32ec1e19af4b569b13f0c
2013-03-16sc: translate some debug messagesThomas Arnhold1-2/+2
Change-Id: I0c741d2cda4568aef81a18788a764f3ef679660c
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-16 17:49:01 +0000