summaryrefslogtreecommitdiff
path: root/sc/source/core/data/column3.cxx
AgeCommit message (Collapse)AuthorFilesLines
2015-09-17Resolves: tdf#94249 do not remove broadcasters while iterators are in useEike Rathke1-4/+4
EndListeningContext holds BroadcasterStoreType iterators in its ColumnBlockPositionSet and collects broadcasters to purge them at the end. Removing broadcasters from ScColumn::maBroadcasters in between invalidates the iterators. Hence calling the "normal" EndListening() that removes a broadcaster when all listeners are gone while an EndListeningContext is in use is bad. Change-Id: Ibdd88469e91e6173ceff1f391c23ef7cb7c6f596 (cherry picked from commit e4a8ae0bf54476e9a0c9e1f5348c05f3cd838899) Reviewed-on: https://gerrit.libreoffice.org/18618 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17Resolves: tdf#92995 do not delete caption objects that are held by UndoEike Rathke1-1/+4
Drag&Drop Undo is a special case of ownership.. Change-Id: I2fe7769c4d84efe09d432335d5d8e72d506bf7a1 (cherry picked from commit 44f34c1163882c2e3086282374fee9cd55ee211f) Reviewed-on: https://gerrit.libreoffice.org/18474 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-03Resolves: tdf#92767 use ISO 8601 for internal date string representationEike Rathke1-0/+4
Change-Id: I481bf3295feb64827de2122234a9300d0b8ced40 (cherry picked from commit 3e17ed1fc2845da5a279d21ffa3ea51d637e515e) Reviewed-on: https://gerrit.libreoffice.org/17173 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-12only delete cell content for CELLTYPE_NONE, fdo#88200Markus Mohrhard1-1/+12
Change-Id: I43463b56cabfea4c9ee2b98445f7fb522221197d Reviewed-on: https://gerrit.libreoffice.org/13842 Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-12-08we need the SdrPage for deleting the notes, fdo#86166Markus Mohrhard1-0/+6
The SdrPage that contains the shapes for the note captions is deleted before the notes. Prevent that case by deleting the notes before deleting the SdrPage. Change-Id: I13727cea7df0b033fb386a6a8e20dcadec743335
2014-11-28test rows for validityCaolán McNamara1-0/+3
Change-Id: I501c1c18df96b5b2ad628e86cfb724a541d5c4b6 (cherry picked from commit 1e514c8da8e37fc3cb26af6ddaf95a3ed8093a41) Reviewed-on: https://gerrit.libreoffice.org/13168 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-11-25Adjust ref undo to ensure group area listeners are used.Kohei Yoshida1-13/+30
When undoing row deletion (and possibly other similar undo's). And write test for it. Change-Id: I04b4fd9932f4236f124dcd25967355c6055dec33 (cherry picked from commit 0dae7466fff1e742543ef7512b7dd22472c75624)
2014-11-21Use group area listeners when deleting rows.Kohei Yoshida1-4/+12
Change-Id: I9ceb1cabf448349e087e4d5c4c2b1a75af91dd75 (cherry picked from commit 5432e2a5ef7a3e131d2496e19bd0c6a86955319f)
2014-11-19Use group area listener when entering a new single formula cell.Kohei Yoshida1-6/+16
Change-Id: I01dc4537919b69a312e92ede2ae00fbe7d781bd7
2014-11-18Combine StartAllListeners() and StartNeededListeners()...Kohei Yoshida1-23/+8
And call the new method StartListeners(). This also adjusts what was previously StartAllListener() to be group-listener aware. Change-Id: I74de45c00f5b8ef232eea9fe3b93aa44d1d8855b
2014-11-18Rename Activate... -> Attach...Kohei Yoshida1-8/+8
Attach is the new one we are going with & offers nice contrast with 'Detach...'. Change-Id: I4578f4c7b9d989e41d433d7c8aa96a9317aa6919
2014-11-18Simplify DeleteCells to not require 2 out parameters for the same thing.Kohei Yoshida1-16/+22
One can easily get constructed from the other after returning from the method. Change-Id: Iafc52efa7714b7cf4d284effda8034cb6f36bf91
2014-11-18Register group area listeners as needed when inserting/deleting cells.Kohei Yoshida1-9/+26
Change-Id: I583ace5d134d526d660d4ff0bbf4a16aa10cbe5a
2014-11-18Use group-area listeners during copy & paste if we can.Kohei Yoshida1-22/+0
This should reduce the number of area listeners generated esp. when replicating tons of formula cells down the column. Change-Id: I1ea8f51f667e6b0e1a646f84d79f5e8430b478d5
2014-11-18Reduce duplicate broadcasting done when pasting a range of cells from clip.Kohei Yoshida1-6/+11
We do pasting from clip in 2 steps: 1) delete the destination range, then 2) paste the content onto the destination range. The old code would broadcast both during 1) and 2). This change consolidates them and do broadcasting only once at the end, and also avoids broadcasting the same cell twice, which the old code sometimes did. Change-Id: Ic524c2b70888ce158619d99cbfb55dea85870497
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini1-1/+1
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23loplugin: cstylecastNoel Grandin1-1/+1
Change-Id: If991c0efe1ded6ef6d32b3a722ee87bbe36bf0bf
2014-10-22Be sure to copy the cell text attributes values to and from clip.Kohei Yoshida1-2/+39
Otherwise we'd have to unnecessarily re-calculate the script types again which is not cheap... Change-Id: Ie589fb4a7e5ec9b5ef646dabea4e6bd0c0aca560
2014-09-04create type-safe bitfield for sc insert/delete flagsNoel Grandin1-16/+16
The most important part of the change is in sc/inc/global.hxx It creates a type-safe struct that prevents the accidental interaction between regular integer types and the flags struct. It also provides utility methods that make combining and testing the flags type-safe. Change-Id: Ibc5b20058b1655df913490682b679afd1297b36d Reviewed-on: https://gerrit.libreoffice.org/11071 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-06-25remove whitespaceMarkus Mohrhard1-7/+0
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-05-29MAXROWCOUNT-1 -> MAXROW, same number but tidierCaolán McNamara1-1/+1
Change-Id: I710365e8e44923c320203f749da84323ffa3d063
2014-05-29Resolves: fdo#79392 don't access after last row, when last row is max last rowCaolán McNamara1-10/+13
Change-Id: I06749af90bed6a43f3fb6b3b5ceb61d5fbbc7c02
2014-05-23Remove dead codeStephan Bergmann1-54/+0
Change-Id: I198fb0193fed891c4dd8a8a92c29e36f6c4d48b9
2014-05-22fdo#78903: Don't broadcast prematurely during cell deletion.Kohei Yoshida1-22/+0
We need to wait until all the affected cells get marked dirty at the end of the deletion process. Change-Id: I49618fcc386ec2209f5f0267d50257ecb8dd21d1
2014-05-20enhance pass-by-ref plugin to detect large argumentsNoel Grandin1-3/+3
Detect arguments larger than 64 chars passed by value. Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-11fix-includes.pl: scThomas Arnhold1-4/+4
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-05-09fdo#77056: Treat empty cells as if they have a value of 0.0.Kohei Yoshida1-17/+26
Change-Id: Ibe64cf7177a5298c1878e0014c049dc9c82b1344
2014-05-09fdo#77379: Don't return from the call. Notes are handled at the end.Kohei Yoshida1-2/+2
Returning prematurely would end up skipping pasting of notes. Change-Id: I79e0968023342a68fe729f31eb6cfc3cfacd5850
2014-04-29fdo#74650: Speed up GetFilteredFilterEntries().Kohei Yoshida1-2/+5
Change-Id: I1b3ae601726401a0e70fb1a05b9a90c43773794c
2014-04-23Handle sorting of broadcasters correctly.Kohei Yoshida1-3/+62
Change-Id: Iab46c26606880f0fa7c7067d8514b8be3629fe0f
2014-04-02just nitpicking on scopeEike Rathke1-2/+1
Change-Id: I01969fb4596e7866ddb348d026a22f45deeef0c8
2014-03-31re-enabled user-defined numeric fields for dBase exportEike Rathke1-22/+86
Since commit f59e350d1733125055f1144f8b3b1b0a46f6d1ca it was impossible to define a numeric field with a precision of less than 2 decimals, even if all values were integers. It was also impossible to define a field width larger than needed for any values in that column. Furthermore, the integer part was shortened if the overall column's values resulted in more precision than defined, but the overall length did not reach the predefined length. This does not change the behavior of the original intention of f59e350d1733125055f1144f8b3b1b0a46f6d1ca to give the precision of number formats precedence over precision defined in the column header, which is debatable though because conflicts may silently change the field definition. Change-Id: I234c4bceaa1a6aadbd259cb8d9b6cb6f16bf91c2
2014-03-23WaE: unused variable 'it'Tor Lillqvist1-1/+1
Change-Id: Ib98e20284a2311db5b93412be7c59026deeefee2
2014-03-22fdo#76470: Avoid joining new formula cells individually.Kohei Yoshida1-0/+69
Instead, insert the formula cells in the group first, then only try to join the top and bottom cells afterward. Otherwise the grouping would get messed up and a problem would ensue. Change-Id: I4fdd5326c029032a636d8225b5fb16cbde427c7d
2014-03-03Remove visual noise from scAlexander Wilms1-2/+2
Conflicts: sc/source/ui/inc/docfunc.hxx Change-Id: I9314437ed3dd60e84d28c08ac0a2d1ed7bd1daf8 Reviewed-on: https://gerrit.libreoffice.org/8301 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27remove unused code in ScColumnNoel Grandin1-10/+0
Specifically: ScColumn::DeleteCellNote(int) ScColumn::MoveListeners(SvtBroadcaster&, int) ScColumn::SetRawString(sc::ColumnBlockPosition&, int, rtl::OUString const&, bool) Change-Id: I34ec659bce7ae18cc3e9d0e27fcd138bc64201b0
2014-02-26remove unused code ScDocument::GetFormulaTokensNoel Grandin1-9/+0
and consequently unused code ScTable::GetFormulaTokens ScColumn::GetFormulaTokens Change-Id: Iad1fd45e67489bb8b0f9ed96a36b647e40e6f774
2014-02-18fdo#72491: Always set input as text when that's requested.Kohei Yoshida1-5/+20
Even when the text begins with '='. Change-Id: I6e0a995f3042240b9f78068b5d0b9b758eb253ed
2014-02-18fdo#74573: Delete ranges that are non-empty before pasting from clipboard.Kohei Yoshida1-25/+27
The conditional formatting part is still not working. But other bits appear to be working now. Change-Id: Ia8a2cbe57cd2fa9ca9ad46635a91a1d8b99b0e7d
2014-02-17fdo#74573: Skip removing of cell notes on empty cells if the flag is set.Kohei Yoshida1-1/+1
Change-Id: I0d9cb5b48c5fdf51cf290cd838f5d6d7cb572e8b
2014-02-07fdo#74273: Let's not shift the note twice. Once is enough.Kohei Yoshida1-4/+0
The notes already are shifted at the top of the function. We don't need this bottom one. Change-Id: I10858d937674e236eecbc42ee08bf6eba197755a
2014-02-07resolved fdo#74622 re-intern shared strings copied between documentsEike Rathke1-4/+24
Change-Id: I64719e12be1f1c61bc86c99f1698f35db87d97be
2014-02-06fdo#74573: Skip deletion of destination area when 'skip empty' is on.Kohei Yoshida1-1/+0
Also, adjust handling of mix document aka paste functions with this change. When using paste function (add, subtract, etc), the behavior between the 'skip empty' flag on and off makes no difference. Let's set the flag to off when paste function is used. Change-Id: I67724ba923c9260b2c14464e4123b8445712dbaf
2014-02-03xub_StrLen and tools/string.hxx final strawNorbert Thiebaud1-1/+1
Thre is still some 0xffff limit left and possibly some less than gracefully handled overflow/error cases Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638 Reviewed-on: https://gerrit.libreoffice.org/7787 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-29fdo#74014: Broadcast changes during undo and redo after paste.Kohei Yoshida1-4/+8
Change-Id: I271bbba5e5eb70e48274a4a062d125456af8ff6c
2014-01-24Optimize copy-n-pasting of single cell replicated over a range.Kohei Yoshida1-10/+2
This is a very common operation. Let's speed it up a bit. TODO : Handle cell comments. Change-Id: I5442bf19008475a9427b889c1eb641cacd8ff161
2014-01-23fdo#73986: Don't forget to receive returned object from for_each.Kohei Yoshida1-1/+1
Change-Id: Ia4ccb83c45ea3ce72a8e5c62a560ab1802bb2441
2014-01-14fdo#73606: Avoid excessive and unnecessary heap allocation of array objects.Kohei Yoshida1-4/+4
This is a leftover from the 1 million row conversion we did years ago. Change-Id: Ib50819ed51c7017bcc559bfc8b6062ff46615d09
2014-01-05Don't crash when entering a value into cell at MAXROW position.Kohei Yoshida1-1/+8
Beucase that would be bad. Change-Id: I7ce22105d88346f1cda12897eb57923dee8bd467
2013-12-11Fix paste as link, and a test case to catch it in the future.Kohei Yoshida1-1/+1
Change-Id: I55fd3fabb7594ee2c635cc0b02dbf506bd5ab3df
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 02:51:37 +0000