path: root/sc/qa
AgeCommit message (Collapse)AuthorFilesLines
2013-12-13fdo#70499 selectn of lock/unlocked cells with worksheet protection reversedNoel Power1-2/+2
The ooxml spec documentation is rather confusing ( for me at least ) and the sense of the of the sheetProtection attributes as described seems reversed to how I read it ( or maybe it is the equivelant option in ScTableProtection that operates with the reverse sense <shrug> ) In anycase the import ( and export ) have been adjusted to take that into consideration, also the export now actually deals with the defaults correctly. Change-Id: Ia69567b8898b39c9d171486cfa800e1748c5814b Reviewed-on: Reviewed-by: Kohei Yoshida <> Tested-by: Kohei Yoshida <>
2013-10-03Resolves: rhbz#1013844 fdo#47482 encrypted OOo 1.0 docs cannot be reopenedCaolán McNamara2-0/+10
Workaround for the encrypted 1.0 documents generated by Libreoffice <= 3.6 with the new encryption format and using SHA256, but missing a specified startkey of SHA256 Change-Id: Ib1acc4441b5adc6721cb3cde7a1191aa978e9a1b (cherry picked from commit 11ad93f4ba84f190c908e92a2c960f7a9fa800c0) Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Miklos Vajna <>
2013-08-031st step fix for exporting SheetProtection fdo#64753 is to import correctlyNoel Power2-0/+31
(cherry picked from commit 016e18680e471d9f0cea8ee35f9716ae0f9baa11) 2nd step to export SheetProtection fdo#64753, actually export the data (cherry picked from commit 8ce1124359783df750d176b8390b4eb0f54fb6ba) unit test for fdo#64753 ( import/export of sheetprotection ) Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: If420b386543c15c7b550a720b6e2db69bf372d7f Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2013-08-02fdo#67489: Don't stop range search even when the first cell is empty.Kohei Yoshida1-0/+36
Because we aren't supposed to. Think of those formula cells that follow the empty one. Change-Id: I2cd04833d5e6c561e9ab6d83a984dbdceefa2e71 Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2013-07-26fix for fdo#62729 reference pos can point to non existing tableNoel Power2-0/+30
there is an existing function ( called at least from uno names api also ) that updates the tab pos, calling that seems to fix this problem (cherry picked from commit b5fffdb8d0438a2fe933a5742d41fe50a14b71f3) with squash of unit test for fdo#62729 (cherry picked from commit 7b3d8e0a7dcf6ae05e1de5c33ed382822cf52cce) Change-Id: I6f6f31895eda9c338eeabd3f3285bf2c9eb23b7e b9be75459aa49b8bab968dedae9e0760ccef9a26 Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2013-07-25resolved fdo#67249 use ScFieldEditEngine to resolve field contentEike Rathke1-0/+9
ScEditUtil::GetString() iterated over the paragraphs of an EditTextObject where GetText() does not resolve field content but returns the embedded field markers. To resolve field content an ScFieldEditEngine is needed. This makes it necessary to pass an ScDocument* to obtain the ScFieldEditEngine from, or for cases where there is no ScDocument in the context use a static ScFieldEditEngine which unfortunately is not capable of resolving document specific fields of course, such as DOCINFO_TITLE and TABLE. Also added unit test. (cherry picked from commit 1ecdc7aaf661e97a33cf521f553481d79cd26de2) Conflicts: sc/qa/unit/subsequent_filters-test.cxx sc/qa/unit/ucalc.cxx sc/source/core/data/column.cxx sc/source/core/data/column2.cxx sc/source/core/data/column3.cxx sc/source/core/data/dociter.cxx sc/source/core/data/table3.cxx sc/source/core/data/table4.cxx Change-Id: Ife3c23b2fec2514b32303239d276c49869786eb5 Reviewed-on: Reviewed-by: Kohei Yoshida <> Tested-by: Kohei Yoshida <>
2013-07-25unit test for <text:s> in <text:p> and <text:span>, fdo#67094Eike Rathke2-8/+49
Change-Id: I033668dcdcdcc1a5710f2ddacadf9a1a5344638e (cherry picked from commit 038d162b175b62d67a94d4418b3a15a1a382419d) Reviewed-on: Reviewed-by: Fridrich Strba <> Tested-by: Fridrich Strba <>
2013-07-24fdo#67206: Don't forget to swap the broadcaster storage when swapping columns.Kohei Yoshida1-8/+44
And a new unit test case to catch this in the future. Change-Id: Ife7d0579849a769c23ace8bfd86a39892253a121 Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2013-07-03temporarily disable tests known to failChristian Lohmaier1-2/+2
Change-Id: I95c3c1af64b7d8b499c085c345b26d2df7e31965 Reviewed-on: Reviewed-by: Markus Mohrhard <> Tested-by: Markus Mohrhard <>
2013-06-28we don't need this hack without inherited number formats, fdo#66076Markus Mohrhard1-1/+1
Change-Id: If315ce28a4182019002141c7330475e0843f9a40 (cherry picked from commit 3f0b5770790dfcb408d169df1265546d6e8e3ece) Reviewed-on: Reviewed-by: Fridrich Strba <> Tested-by: Fridrich Strba <>
2013-06-28unit test for commit:1680a8cd4f4393ec15c4f85cb63b6654117d56d1 (fdo#56960)Noel Power3-3/+22
expand the existing borders import check to cater for xlsx ( and testing for fine/hair border styles ) Change-Id: Ic5c3cd46e0049dbce9997f0881c4d98e0d64e00c (cherry picked from commit 69dcacedaccd1d698a54eed615ee8739747bc975) Reviewed-on: Reviewed-by: Fridrich Strba <> Tested-by: Fridrich Strba <>
2013-06-28fix hair & fine cell border export ( followon fix fdo#56960 )Noel Power1-3/+3
1) align excel binary and oox import filter border thickness values 2) use new fine-dash border style 3) detect & determine hair vrs fine borderline on export also squashed relevant part of commit ee51444ed1f7003dafc93c8181b5f8c1b0fd165b ( fix borders unit test ( test values have changed ) ) Change-Id: Ieb024bc6f4bfc87c525082c7b9a1f3c444f5c5ca (cherry picked from commit 1680a8cd4f4393ec15c4f85cb63b6654117d56d1) Reviewed-on: Reviewed-by: Fridrich Strba <> Tested-by: Fridrich Strba <>
2013-06-07add missing PageSetup.PageSize apiNoel Power1-0/+0
Change-Id: If52fb46f61962827acc08025617d9d61a6ab6d40 (cherry picked from commit 254a2d6c71f7615c7652ca401b9dd3eac1e0d570)
2013-06-05some systems seem to fail with the range geometry tests. Increase toleranceNoel Power1-0/+0
not really sure what is going on here, there is at least a reported difference between 32 & 64 systems ( 64 bit passes 32 bit doesn't ) and imported size and pos of Range is not expected. Testing for hard position and sizes in a unit test like this is not ideal ( this test should be rewritten ) because the imported geometry is dependant on available fonts ( and font selection ) We need a relative based test ( against known imported positions ) rather than against some hardcoded value. This patch just attempts to get us over the hump for that moment by increasing the fudge/tolerence we use. Change-Id: Id7c6cc0857ff9c79ea506904b4585fd746f7e8be
2013-06-04some systems seem to fail with the rangessize test increase toleranceNoel Power1-0/+0
not really sure what is going on here, there is at least a reported difference between 32 & 64 systems ( 64 bit passes 32 bit doesn't ) and imported size and pos of Range is not expected. Testing for hard position and sizes in a unit test like this is not ideal ( this test should be rewritten ) because the imported geometry is dependant on available fonts ( and font selection ) We need a relative based test ( against known imported positions ) rather than against some hardcoded value. This patch just attempts to get us over the hump for that moment Change-Id: I55ceb30b5bab7f8eed757825b39718b751ea1812
2013-05-22Disable Calc perf test by default & output both pseudo-cycles and real time.Kohei Yoshida1-47/+39
Change-Id: I35120e576208640976cdda0a5628e355bbe2dc7c (cherry picked from commit 4fa7a0ce8131106a038ba441bcc230d0377690ac)
2013-05-22Use the block position of the destination, not of the source.Kohei Yoshida1-0/+1
And a test to catch this. Change-Id: Ia73be239b4be96cbe029390efbbec5f49e429652 (cherry picked from commit 6958b6a3ce9f28bed2a529939e7740452929a5b3)
2013-05-22Adjust a bit.Kohei Yoshida1-1/+1
Change-Id: I74be2d40d9eb92813836a35892f461fe27b79aeb (cherry picked from commit 563f15a609f5c637cd73d831830a68bdb61fb4d8)
2013-05-22Hopefully this will disable testPerf for Windows too... Untested.Kohei Yoshida1-1/+1
Change-Id: I6d06b8e2b3cdb22948e606a7d928c57ea9347cea (cherry picked from commit 80648e06cac011c01e624cba91ce71fdf431e78a)
2013-05-22Disable the perf test for dbgutil build.Kohei Yoshida1-0/+2
Change-Id: Ifd95ea4f88175b9010f93a4a064be5d908b2a224 (cherry picked from commit df4d6b134bfe45e380416f0d9eecb482843e8a47)
2013-05-22make calc tests use some sort of pseudo-cycle measurementMichael Meeks1-79/+71
Change-Id: I9f58a7b00a6e4441c08254ef99829fab805beef8 (cherry picked from commit 7141c7517db5bbb9814308aa4c68bc95beb4de8c)
2013-05-20Test performance of pasting of formula cells as well.Kohei Yoshida1-0/+94
Undo and redo of this are still a bit slow. Not fast enough to be reliably tested. Change-Id: I0e0b4c16e55bae60f8d7b1db71347a93eb977de8
2013-05-20Another performance scenario. Pasting of cells interspersed with empty ones.Kohei Yoshida1-0/+92
Change-Id: Ia03af65dc1daf13e1228cacc20ce931839305ab8
2013-05-20A bit cleaner way to measure time segment.Kohei Yoshida1-21/+40
Change-Id: I999baaa3acba5513a148542fa28f7ae43dd7ee4f
2013-05-20Make these stack variables & fix one memory leak with the undo object.Kohei Yoshida1-9/+6
Change-Id: I1dd2bf0fc843394502119928c921913131c86f7e
2013-05-20Add performance test for repeat-pasting cell to a large cell range.Kohei Yoshida1-0/+80
Change-Id: I98dcdb1e0a72f2c3ad6f33c7b6b7d4a4bcf89096
2013-05-20Add perf test for removal of large array of formula cells.Kohei Yoshida1-1/+26
Change-Id: I2fdf38b23e74a9f4cad7abd9a943e8817f39474c
2013-05-20Unit test for range deletion of broadcasters.Kohei Yoshida1-6/+30
Change-Id: I615c9f9e95a44149c8079754e9aa6497f34c76cf
2013-05-20First (?) performance regression unit test against clearing of a sheet.Kohei Yoshida1-0/+52
I screwed this up earlier which made this operation take almost 50 seconds to complete. It should finish in 0.00001 seconds or less. The test checks against 1 second, which should be enough of a buffer for slower machines. Change-Id: I9923033045111c75a0740b6bb30a518fe93e01d2
2013-05-15make some vba Name object attributes read/write and add test documentNoel Power2-0/+4
Change-Id: Ibd12835cc5368080a302b3b8d7c6f52ccc434e3c
2013-05-13fix Workbooks.xls unit test ( was failing on windows )Noel Power2-7/+19
Change-Id: Id1e3a761765c1e860f611f40a78a6c24fa17d055
2013-05-10resolved fdo#35756 import more than 64k HTML table cellsEike Rathke1-7/+7
Enhanced EditEngine to be able to hold more than 64k paragraphs. Used also in RTF import Calc and Writer, so that could benefit as well. * changed all EditEngine,Outliner,... related paragraph index/count variables from sal_uInt16 to sal_Int32 * sal_Int32 instead of sal_uInt32 to match accessibility API * matched some Outliner methods' paragraph parameters from sal_uLong to sal_Int32 * containers capable to hold size_t nevertheless are limited to a maximum of sal_Int32 * changed definition of EE_PARA_NOT_FOUND and EE_PARA_ALL to SAL_MAX_INT32 + added EE_PARA_MAX_COUNT and EE_TEXTPOS_MAX_COUNT to initialize ESelection with what previously were hard coded 0xFFFF all over the place + for similar reason added EE_TEXTPOS_ALL corresponding to EE_PARA_ALL to initialize an ESelection spanning all available text like aSel(0,0,EE_PARA_ALL,EE_TEXTPOS_ALL) Change-Id: I62d1b9c399cd709a4f93dbac31b219a61c46ec00 Reviewed-on: Tested-by: LibreOffice gerrit bot <> Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2013-05-10temporarily disable unit test that fails on windowsNoel Power1-0/+2
Change-Id: Id3cc26b6fbb1ec0ddacf7228e1c147085db415e1
2013-05-09Test more broadcaster relocation scenarios.Kohei Yoshida1-4/+75
Change-Id: Ib34b86cfe6b96134dadf5f8da6dcd14ec0adb9d6
2013-05-09The same thing applies in reverse direction.Kohei Yoshida1-2/+7
Change-Id: I3f5863d79ad948461d63dbc9addc8ca01e1b275e
2013-05-09Fix another broadcaster bug and a test code to catch it.Kohei Yoshida1-0/+13
Broadcasters are now independent of cell storage. We need to move them even when the cell array is empty. Change-Id: Ib26e544ad6e3842fa722d989c994c19d7c1b3005
2013-05-09Test to ensure that removing a listening formula cell remove the broadcaster.Kohei Yoshida1-0/+8
Change-Id: Iae816c68ffed30fda0115ac0f5ac2800ceed5e58
2013-05-09More test and more fix wrt broadcaster rework.Kohei Yoshida1-13/+81
Much of the fix went into mdds actually. Change-Id: Ia27b0bde31081a5a28fb4afb80960777bd4fdd4f
2013-05-09Start writing unit test for broadcaster storage. Found & fixed one bug.Kohei Yoshida1-0/+52
Change-Id: Ibc00f3fb4eb188b036b4f3ae70e45cb9c7385fe8
2013-05-09add simple Range.Name testNoel Power1-0/+0
Change-Id: I705e05878015f5c8aad993219ea89ea9d47f07fb
2013-05-09add some Range.value testsNoel Power1-0/+0
Change-Id: I4800ad80f1b447cae03664653285f1917ad3ee7e
2013-05-09add new test for WorkbooksNoel Power2-3/+14
Change-Id: Id271f10ac82ebae9fedd68d30c7f44435d60751d
2013-05-09add OLEObject related testNoel Power1-0/+0
Change-Id: I6ce22ecd6295bd8ad302d0f53c783f4ac2a1a036
2013-05-09some testcases for api generated changed & click events for vba controlsNoel Power1-0/+0
Change-Id: I408c9aa0b80971f326b607b274ce046c27098f74
2013-05-09tweak MiscControls to test simple textbox change eventNoel Power1-0/+0
Change-Id: I256a029afefe5990dfb0c87859bae4508f5920bc
2013-05-09Add check form contrast and IncrememtContrast behaviour in Shapes.xlsNoel Power1-0/+0
Change-Id: I6ef275c6a978db0da59da953511105c407a66f72
2013-05-09Tweak further the indices checked for break, also tweak test documentNoel Power1-0/+0
<sigh> pagebreak implementation is still flawed here, the used range is used to determine whether the page break should be considered ( or not ) Problem is that it is not the used range but rather the rightmost column position that contains content ( but not necessarily the column that contains content but rather the righmost column that has content ( or even that is covered either by spillover from an adjacent column or drawing ) Change-Id: I68c8ccc5911049bc4b2076992f839bc684d966a9
2013-05-09Renable Range-2 vba test as I589b93461b5f4125408f4fc2cb87cd84686f7b95 fixed itNoel Power1-5/+0
note: Change ID I589b93461b5f4125408f4fc2cb87cd84686f7b95 " Fix ScRangeList::Parse wrt defaulted delimiter and default tab params" in addition to fixing problems with Ranges.xls appears also to solve the issue with Range-2.xls Change-Id: I28f53e09a6c7004f766d7e4f2ca9524cc8bbd83f
2013-05-09add Range.Cut checkNoel Power1-0/+0
Change-Id: I6d33ce8fe2333e7920b5c6cf82531ee859352748
2013-05-09re-enable Ranges.xls vba testdocument, additionally remove some failing testsNoel Power2-2/+0
Change-Id: I6289aa7e7872cc0c6aacd89f0679609792d37c28